mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-12-03 21:12:28 +00:00
0f6715bd91
In PR #37300, Alexej asked why we the compiler does not warn about unnecessary semicolons, e.g. f() { }; // <-- here The answer is surprising: In C++98, above syntax was disallowed but by most compilers accepted it regardless. C++>11 introduced "empty declarations" which made the syntax legal. The previous behavior can be restored using flag -Wc++98-compat-extra-semi. This finds many useless semicolons which were removed in this change. Unfortunately, there are also false positives which would require #pragma-s and HAS_* logic (--> check_flags.cmake) to suppress. In the end, -Wc++98-compat-extra-semi comes with extra effort for little benefit. Therefore, this change only fixes some semicolons but does not enable the flag.
29 lines
816 B
C++
29 lines
816 B
C++
#include <Functions/FunctionFactory.h>
|
|
#include <Functions/FunctionDateOrDateTimeAddInterval.h>
|
|
|
|
|
|
namespace DB
|
|
{
|
|
|
|
using FunctionSubtractNanoseconds = FunctionDateOrDateTimeAddInterval<SubtractNanosecondsImpl>;
|
|
void registerFunctionSubtractNanoseconds(FunctionFactory & factory)
|
|
{
|
|
factory.registerFunction<FunctionSubtractNanoseconds>();
|
|
}
|
|
|
|
using FunctionSubtractMicroseconds = FunctionDateOrDateTimeAddInterval<SubtractMicrosecondsImpl>;
|
|
void registerFunctionSubtractMicroseconds(FunctionFactory & factory)
|
|
{
|
|
factory.registerFunction<FunctionSubtractMicroseconds>();
|
|
}
|
|
|
|
using FunctionSubtractMilliseconds = FunctionDateOrDateTimeAddInterval<SubtractMillisecondsImpl>;
|
|
void registerFunctionSubtractMilliseconds(FunctionFactory & factory)
|
|
{
|
|
factory.registerFunction<FunctionSubtractMilliseconds>();
|
|
}
|
|
|
|
}
|
|
|
|
|