ClickHouse/src/Storages/tests
Robert Schulze 330212e0f4
Remove inherited create() method + disallow copying
The original motivation for this commit was that shared_ptr_helper used
std::shared_ptr<>() which does two heap allocations instead of
make_shared<>() which does a single allocation. Turned out that
1. the affected code (--> Storages/) is not on a hot path (rendering the
performance argument moot ...)
2. yet copying Storage objects is potentially dangerous and was
   previously allowed.

Hence, this change

- removes shared_ptr_helper and as a result all inherited create() methods,

- instead, Storage objects are now created using make_shared<>() by the
  caller (for that to work, many constructors had to be made public), and

- all Storage classes were marked as noncopyable using boost::noncopyable.

In sum, we are (likely) not making things faster but the code becomes
cleaner and harder to misuse.
2022-05-02 08:46:52 +02:00
..
gtest_aux_funcs_for_adaptive_granularity_compact_parts.cpp
gtest_aux_funcs_for_adaptive_granularity.cpp Mechanical refactoring 2020-12-09 21:10:09 +03:00
gtest_columns_description_normalize.cpp better formatting 2021-09-24 14:41:49 +03:00
gtest_row_source_bits_test.cpp Fix gtest build. 2021-10-09 10:01:58 +03:00
gtest_SplitTokenExtractor.cpp Added function ngram 2021-10-04 18:53:17 +03:00
gtest_storage_log.cpp Remove inherited create() method + disallow copying 2022-05-02 08:46:52 +02:00
gtest_transform_query_for_external_database.cpp Remove inherited create() method + disallow copying 2022-05-02 08:46:52 +02:00