mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-11-10 01:25:21 +00:00
e0d5020a92
- In general, it is expected that clickhouse-*-bridges and clickhouse-server were build from the same source version (e.g. are upgraded "atomically"). If that is not the case, we should at least be able to detect the mismatch and abort. - This commit adds a URL parameter "version", defined in a header shared by the server and bridges. The bridge returns an error in case of mismatch. - The version is *not* send and checked for "ping" requests (used for handshake), only for regular requests send after handshake. This is because the internally thrown server-side exception due to HTTP failure does not propagate the exact HTTP error (it only stores the error as text), and as a result, the server-side handshake code simply retries in case of error with exponential backoff and finally fails with a "timeout error". This is reasonable as pings typically fail due to time out. However, without a rework of HTTP exceptions, version mismatch during ping would also appear as "timeout" which is too misleading. The behavior may be changed later if needed. - Note that introducing a version parameter does not represent a protocol upgrade itself. Bridges older than the server will simply ignore the field. Only servers older than the bridges receive an error but such a situation should never occur in practice.
98 lines
3.1 KiB
C++
98 lines
3.1 KiB
C++
#include "IdentifierQuoteHandler.h"
|
|
|
|
#if USE_ODBC
|
|
|
|
#include <DataTypes/DataTypeFactory.h>
|
|
#include <Server/HTTP/HTMLForm.h>
|
|
#include <Server/HTTP/WriteBufferFromHTTPServerResponse.h>
|
|
#include <IO/WriteHelpers.h>
|
|
#include <Parsers/ParserQueryWithOutput.h>
|
|
#include <Parsers/parseQuery.h>
|
|
#include <Poco/Net/HTTPServerRequest.h>
|
|
#include <Poco/Net/HTTPServerResponse.h>
|
|
#include <Common/BridgeProtocolVersion.h>
|
|
#include <Common/logger_useful.h>
|
|
#include <base/scope_guard.h>
|
|
#include "getIdentifierQuote.h"
|
|
#include "validateODBCConnectionString.h"
|
|
#include "ODBCPooledConnectionFactory.h"
|
|
|
|
#include <charconv>
|
|
|
|
|
|
namespace DB
|
|
{
|
|
void IdentifierQuoteHandler::handleRequest(HTTPServerRequest & request, HTTPServerResponse & response)
|
|
{
|
|
HTMLForm params(getContext()->getSettingsRef(), request, request.getStream());
|
|
LOG_TRACE(log, "Request URI: {}", request.getURI());
|
|
|
|
auto process_error = [&response, this](const std::string & message)
|
|
{
|
|
response.setStatusAndReason(Poco::Net::HTTPResponse::HTTP_INTERNAL_SERVER_ERROR);
|
|
if (!response.sent())
|
|
*response.send() << message << std::endl;
|
|
LOG_WARNING(log, fmt::runtime(message));
|
|
};
|
|
|
|
if (!params.has("version"))
|
|
{
|
|
process_error("No 'version' in request URL");
|
|
return;
|
|
}
|
|
else
|
|
{
|
|
String version_str = params.get("version");
|
|
size_t version;
|
|
auto [_, ec] = std::from_chars(version_str.data(), version_str.data() + version_str.size(), version);
|
|
if (ec != std::errc())
|
|
{
|
|
process_error("Unable to parse 'version' string in request URL: '" + version_str + "' Check if the server and library-bridge have the same version.");
|
|
return;
|
|
}
|
|
if (version != XDBC_BRIDGE_PROTOCOL_VERSION)
|
|
{
|
|
// backwards compatibility is for now deemed unnecessary, just let the user upgrade the server and bridge to the same version
|
|
process_error("Server and library-bridge have different versions: '" + std::to_string(version) + "' vs. '" + std::to_string(LIBRARY_BRIDGE_PROTOCOL_VERSION) + "'");
|
|
return;
|
|
}
|
|
}
|
|
|
|
if (!params.has("connection_string"))
|
|
{
|
|
process_error("No 'connection_string' in request URL");
|
|
return;
|
|
}
|
|
|
|
try
|
|
{
|
|
std::string connection_string = params.get("connection_string");
|
|
|
|
auto connection = ODBCPooledConnectionFactory::instance().get(
|
|
validateODBCConnectionString(connection_string),
|
|
getContext()->getSettingsRef().odbc_bridge_connection_pool_size);
|
|
|
|
auto identifier = getIdentifierQuote(std::move(connection));
|
|
|
|
WriteBufferFromHTTPServerResponse out(response, request.getMethod() == Poco::Net::HTTPRequest::HTTP_HEAD, keep_alive_timeout);
|
|
try
|
|
{
|
|
writeStringBinary(identifier, out);
|
|
out.finalize();
|
|
}
|
|
catch (...)
|
|
{
|
|
out.finalize();
|
|
}
|
|
}
|
|
catch (...)
|
|
{
|
|
process_error("Error getting identifier quote style from ODBC '" + getCurrentExceptionMessage(false) + "'");
|
|
tryLogCurrentException(log);
|
|
}
|
|
}
|
|
|
|
}
|
|
|
|
#endif
|