mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-12-04 13:32:13 +00:00
5a4f21c50f
- TSA is a static analyzer build by Google which finds race conditions and deadlocks at compile time. - It works by associating a shared member variable with a synchronization primitive that protects it. The compiler can then check at each access if proper locking happened before. A good introduction are [0] and [1]. - TSA requires some help by the programmer via annotations. Luckily, LLVM's libcxx already has annotations for std::mutex, std::lock_guard, std::shared_mutex and std::scoped_lock. This commit enables them (--> contrib/libcxx-cmake/CMakeLists.txt). - Further, this commit adds convenience macros for the low-level annotations for use in ClickHouse (--> base/defines.h). For demonstration, they are leveraged in a few places. - As we compile with "-Wall -Wextra -Weverything", the required compiler flag "-Wthread-safety-analysis" was already enabled. Negative checks are an experimental feature of TSA and disabled (--> cmake/warnings.cmake). Compile times did not increase noticeably. - TSA is used in a few places with simple locking. I tried TSA also where locking is more complex. The problem was usually that it is unclear which data is protected by which lock :-(. But there was definitely some weird code where locking looked broken. So there is some potential to find bugs. *** Limitations of TSA besides the ones listed in [1]: - The programmer needs to know which lock protects which piece of shared data. This is not always easy for large classes. - Two synchronization primitives used in ClickHouse are not annotated in libcxx: (1) std::unique_lock: A releaseable lock handle often together with std::condition_variable, e.g. in solve producer-consumer problems. (2) std::recursive_mutex: A re-entrant mutex variant. Its usage can be considered a design flaw + typically it is slower than a standard mutex. In this commit, one std::recursive_mutex was converted to std::mutex and annotated with TSA. - For free-standing functions (e.g. helper functions) which are passed shared data members, it can be tricky to specify the associated lock. This is because the annotations use the normal C++ rules for symbol resolution. [0] https://clang.llvm.org/docs/ThreadSafetyAnalysis.html [1] https://static.googleusercontent.com/media/research.google.com/en//pubs/archive/42958.pdf
174 lines
4.7 KiB
C++
174 lines
4.7 KiB
C++
#pragma once
|
|
|
|
#include <Common/logger_useful.h>
|
|
#include <nanodbc/nanodbc.h>
|
|
#include <mutex>
|
|
#include <base/BorrowedObjectPool.h>
|
|
#include <base/defines.h>
|
|
#include <unordered_map>
|
|
|
|
|
|
namespace DB
|
|
{
|
|
namespace ErrorCodes
|
|
{
|
|
extern const int NO_FREE_CONNECTION;
|
|
}
|
|
}
|
|
|
|
namespace nanodbc
|
|
{
|
|
|
|
using ConnectionPtr = std::unique_ptr<nanodbc::connection>;
|
|
using Pool = BorrowedObjectPool<ConnectionPtr>;
|
|
using PoolPtr = std::shared_ptr<Pool>;
|
|
|
|
static constexpr inline auto ODBC_CONNECT_TIMEOUT = 100;
|
|
|
|
|
|
class ConnectionHolder
|
|
{
|
|
public:
|
|
ConnectionHolder(PoolPtr pool_,
|
|
ConnectionPtr connection_,
|
|
const String & connection_string_)
|
|
: pool(pool_)
|
|
, connection(std::move(connection_))
|
|
, connection_string(connection_string_)
|
|
{
|
|
}
|
|
|
|
explicit ConnectionHolder(const String & connection_string_)
|
|
: pool(nullptr)
|
|
, connection()
|
|
, connection_string(connection_string_)
|
|
{
|
|
updateConnection();
|
|
}
|
|
|
|
ConnectionHolder(const ConnectionHolder & other) = delete;
|
|
|
|
~ConnectionHolder()
|
|
{
|
|
if (pool != nullptr)
|
|
pool->returnObject(std::move(connection));
|
|
}
|
|
|
|
nanodbc::connection & get() const
|
|
{
|
|
assert(connection != nullptr);
|
|
return *connection;
|
|
}
|
|
|
|
void updateConnection()
|
|
{
|
|
connection = std::make_unique<nanodbc::connection>(connection_string, ODBC_CONNECT_TIMEOUT);
|
|
}
|
|
|
|
private:
|
|
PoolPtr pool;
|
|
ConnectionPtr connection;
|
|
String connection_string;
|
|
};
|
|
|
|
using ConnectionHolderPtr = std::shared_ptr<ConnectionHolder>;
|
|
|
|
}
|
|
|
|
|
|
namespace DB
|
|
{
|
|
|
|
static constexpr inline auto ODBC_CONNECT_TIMEOUT = 100;
|
|
static constexpr inline auto ODBC_POOL_WAIT_TIMEOUT = 10000;
|
|
|
|
template <typename T>
|
|
T execute(nanodbc::ConnectionHolderPtr connection_holder, std::function<T(nanodbc::connection &)> query_func)
|
|
{
|
|
try
|
|
{
|
|
return query_func(connection_holder->get());
|
|
}
|
|
catch (const nanodbc::database_error & e)
|
|
{
|
|
tryLogCurrentException(__PRETTY_FUNCTION__);
|
|
/// SQLState, connection related errors start with 08 (main: 08S01), cursor invalid state is 24000.
|
|
/// Invalid cursor state is a retriable error.
|
|
/// Invalid transaction state 25000. Truncate to 2 letters on purpose.
|
|
/// https://docs.microsoft.com/ru-ru/sql/odbc/reference/appendixes/appendix-a-odbc-error-codes?view=sql-server-ver15
|
|
if (e.state().starts_with("08") || e.state().starts_with("24") || e.state().starts_with("25"))
|
|
{
|
|
connection_holder->updateConnection();
|
|
return query_func(connection_holder->get());
|
|
}
|
|
|
|
/// psqlodbc driver error handling is incomplete and under some scenarious
|
|
/// it doesn't propagate correct errors to the caller.
|
|
/// As a quick workaround we run a quick "ping" query over the connection
|
|
/// on generic errors.
|
|
/// If "ping" fails, recycle the connection and try the query once more.
|
|
if (e.state().starts_with("HY00"))
|
|
{
|
|
try
|
|
{
|
|
just_execute(connection_holder->get(), "SELECT 1");
|
|
}
|
|
catch (...)
|
|
{
|
|
connection_holder->updateConnection();
|
|
return query_func(connection_holder->get());
|
|
}
|
|
}
|
|
|
|
throw;
|
|
}
|
|
}
|
|
|
|
|
|
class ODBCPooledConnectionFactory final : private boost::noncopyable
|
|
{
|
|
public:
|
|
static ODBCPooledConnectionFactory & instance()
|
|
{
|
|
static ODBCPooledConnectionFactory ret;
|
|
return ret;
|
|
}
|
|
|
|
nanodbc::ConnectionHolderPtr get(const std::string & connection_string, size_t pool_size)
|
|
{
|
|
std::lock_guard lock(mutex);
|
|
|
|
if (!factory.count(connection_string))
|
|
factory.emplace(std::make_pair(connection_string, std::make_shared<nanodbc::Pool>(pool_size)));
|
|
|
|
auto & pool = factory[connection_string];
|
|
|
|
nanodbc::ConnectionPtr connection;
|
|
auto connection_available = pool->tryBorrowObject(connection, []() { return nullptr; }, ODBC_POOL_WAIT_TIMEOUT);
|
|
|
|
if (!connection_available)
|
|
throw Exception("Unable to fetch connection within the timeout", ErrorCodes::NO_FREE_CONNECTION);
|
|
|
|
try
|
|
{
|
|
if (!connection)
|
|
connection = std::make_unique<nanodbc::connection>(connection_string, ODBC_CONNECT_TIMEOUT);
|
|
}
|
|
catch (...)
|
|
{
|
|
pool->returnObject(std::move(connection));
|
|
throw;
|
|
}
|
|
|
|
return std::make_unique<nanodbc::ConnectionHolder>(factory[connection_string], std::move(connection), connection_string);
|
|
}
|
|
|
|
private:
|
|
/// [connection_settings_string] -> [connection_pool]
|
|
using PoolFactory = std::unordered_map<std::string, nanodbc::PoolPtr>;
|
|
PoolFactory factory TSA_GUARDED_BY(mutex);
|
|
std::mutex mutex;
|
|
};
|
|
|
|
}
|