ClickHouse/src/Coordination/KeeperLogStore.h

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

78 lines
2.4 KiB
C++
Raw Normal View History

2021-02-15 15:36:25 +00:00
#pragma once
2021-10-27 23:10:39 +00:00
#include <libnuraft/log_store.hxx>
2021-02-15 15:36:25 +00:00
#include <map>
#include <mutex>
#include <Core/Types.h>
#include <Coordination/Changelog.h>
2022-04-27 15:05:45 +00:00
#include <Common/logger_useful.h>
Support for Clang Thread Safety Analysis (TSA) - TSA is a static analyzer build by Google which finds race conditions and deadlocks at compile time. - It works by associating a shared member variable with a synchronization primitive that protects it. The compiler can then check at each access if proper locking happened before. A good introduction are [0] and [1]. - TSA requires some help by the programmer via annotations. Luckily, LLVM's libcxx already has annotations for std::mutex, std::lock_guard, std::shared_mutex and std::scoped_lock. This commit enables them (--> contrib/libcxx-cmake/CMakeLists.txt). - Further, this commit adds convenience macros for the low-level annotations for use in ClickHouse (--> base/defines.h). For demonstration, they are leveraged in a few places. - As we compile with "-Wall -Wextra -Weverything", the required compiler flag "-Wthread-safety-analysis" was already enabled. Negative checks are an experimental feature of TSA and disabled (--> cmake/warnings.cmake). Compile times did not increase noticeably. - TSA is used in a few places with simple locking. I tried TSA also where locking is more complex. The problem was usually that it is unclear which data is protected by which lock :-(. But there was definitely some weird code where locking looked broken. So there is some potential to find bugs. *** Limitations of TSA besides the ones listed in [1]: - The programmer needs to know which lock protects which piece of shared data. This is not always easy for large classes. - Two synchronization primitives used in ClickHouse are not annotated in libcxx: (1) std::unique_lock: A releaseable lock handle often together with std::condition_variable, e.g. in solve producer-consumer problems. (2) std::recursive_mutex: A re-entrant mutex variant. Its usage can be considered a design flaw + typically it is slower than a standard mutex. In this commit, one std::recursive_mutex was converted to std::mutex and annotated with TSA. - For free-standing functions (e.g. helper functions) which are passed shared data members, it can be tricky to specify the associated lock. This is because the annotations use the normal C++ rules for symbol resolution. [0] https://clang.llvm.org/docs/ThreadSafetyAnalysis.html [1] https://static.googleusercontent.com/media/research.google.com/en//pubs/archive/42958.pdf
2022-06-14 22:35:55 +00:00
#include <base/defines.h>
2021-02-15 15:36:25 +00:00
namespace DB
{
/// Wrapper around Changelog class. Implements RAFT log storage.
2021-03-29 08:24:56 +00:00
class KeeperLogStore : public nuraft::log_store
2021-02-15 15:36:25 +00:00
{
public:
KeeperLogStore(const std::string & changelogs_path, uint64_t rotate_interval_, bool force_sync_, bool compress_logs_);
2021-02-15 15:36:25 +00:00
/// Read log storage from filesystem starting from last_commited_log_index
2021-04-08 14:17:57 +00:00
void init(uint64_t last_commited_log_index, uint64_t logs_to_keep);
2021-02-15 17:59:40 +00:00
2021-04-08 14:17:57 +00:00
uint64_t start_index() const override;
2021-02-15 17:59:40 +00:00
2021-04-08 14:17:57 +00:00
uint64_t next_slot() const override;
2021-02-15 17:59:40 +00:00
/// return last entry from log
2021-02-15 17:59:40 +00:00
nuraft::ptr<nuraft::log_entry> last_entry() const override;
/// Append new entry to log
2021-04-08 14:17:57 +00:00
uint64_t append(nuraft::ptr<nuraft::log_entry> & entry) override;
2021-02-15 17:59:40 +00:00
/// Remove all entries starting from index and write entry into index position
2021-04-08 14:17:57 +00:00
void write_at(uint64_t index, nuraft::ptr<nuraft::log_entry> & entry) override;
2021-02-15 17:59:40 +00:00
/// Return entries between [start, end)
2021-04-08 14:17:57 +00:00
nuraft::ptr<std::vector<nuraft::ptr<nuraft::log_entry>>> log_entries(uint64_t start, uint64_t end) override;
2021-02-15 17:59:40 +00:00
/// Return entry at index
2021-04-08 14:17:57 +00:00
nuraft::ptr<nuraft::log_entry> entry_at(uint64_t index) override;
2021-02-15 17:59:40 +00:00
/// Term if the index
2021-04-08 14:17:57 +00:00
uint64_t term_at(uint64_t index) override;
2021-02-15 17:59:40 +00:00
/// Serialize entries in interval [index, index + cnt)
2021-04-08 14:17:57 +00:00
nuraft::ptr<nuraft::buffer> pack(uint64_t index, int32_t cnt) override;
2021-02-15 17:59:40 +00:00
/// Apply serialized entries starting from index
2021-04-08 14:17:57 +00:00
void apply_pack(uint64_t index, nuraft::buffer & pack) override;
2021-02-15 17:59:40 +00:00
/// Entries from last_log_index can be removed from memory and from disk
2021-04-08 14:17:57 +00:00
bool compact(uint64_t last_log_index) override;
2021-02-15 17:59:40 +00:00
/// Call fsync to the stored data
2021-02-15 17:59:40 +00:00
bool flush() override;
2021-02-15 15:36:25 +00:00
/// Stop background cleanup thread in change
void shutdownChangelog();
/// Flush logstore and call shutdown of background thread in changelog
bool flushChangelogAndShutdown();
/// Current log storage size
2021-04-08 14:17:57 +00:00
uint64_t size() const;
2021-02-17 08:00:17 +00:00
/// Flush batch of appended entries
2021-04-16 13:50:09 +00:00
void end_of_append_batch(uint64_t start_index, uint64_t count) override;
2021-10-19 14:10:09 +00:00
/// Get entry with latest config in logstore
2021-10-18 15:27:51 +00:00
nuraft::ptr<nuraft::log_entry> getLatestConfigChange() const;
2021-02-15 15:36:25 +00:00
private:
2021-02-15 17:59:40 +00:00
mutable std::mutex changelog_lock;
Poco::Logger * log;
Support for Clang Thread Safety Analysis (TSA) - TSA is a static analyzer build by Google which finds race conditions and deadlocks at compile time. - It works by associating a shared member variable with a synchronization primitive that protects it. The compiler can then check at each access if proper locking happened before. A good introduction are [0] and [1]. - TSA requires some help by the programmer via annotations. Luckily, LLVM's libcxx already has annotations for std::mutex, std::lock_guard, std::shared_mutex and std::scoped_lock. This commit enables them (--> contrib/libcxx-cmake/CMakeLists.txt). - Further, this commit adds convenience macros for the low-level annotations for use in ClickHouse (--> base/defines.h). For demonstration, they are leveraged in a few places. - As we compile with "-Wall -Wextra -Weverything", the required compiler flag "-Wthread-safety-analysis" was already enabled. Negative checks are an experimental feature of TSA and disabled (--> cmake/warnings.cmake). Compile times did not increase noticeably. - TSA is used in a few places with simple locking. I tried TSA also where locking is more complex. The problem was usually that it is unclear which data is protected by which lock :-(. But there was definitely some weird code where locking looked broken. So there is some potential to find bugs. *** Limitations of TSA besides the ones listed in [1]: - The programmer needs to know which lock protects which piece of shared data. This is not always easy for large classes. - Two synchronization primitives used in ClickHouse are not annotated in libcxx: (1) std::unique_lock: A releaseable lock handle often together with std::condition_variable, e.g. in solve producer-consumer problems. (2) std::recursive_mutex: A re-entrant mutex variant. Its usage can be considered a design flaw + typically it is slower than a standard mutex. In this commit, one std::recursive_mutex was converted to std::mutex and annotated with TSA. - For free-standing functions (e.g. helper functions) which are passed shared data members, it can be tricky to specify the associated lock. This is because the annotations use the normal C++ rules for symbol resolution. [0] https://clang.llvm.org/docs/ThreadSafetyAnalysis.html [1] https://static.googleusercontent.com/media/research.google.com/en//pubs/archive/42958.pdf
2022-06-14 22:35:55 +00:00
Changelog changelog TSA_GUARDED_BY(changelog_lock);
2021-02-15 15:36:25 +00:00
};
}