Better naming

This commit is contained in:
avogar 2022-01-24 16:27:04 +03:00
parent 7bfb1231b9
commit 1f49acc164
8 changed files with 10 additions and 10 deletions

View File

@ -402,7 +402,7 @@ void FormatFactory::registerAppendSupportChecker(const String & name, AppendSupp
target = std::move(append_support_checker); target = std::move(append_support_checker);
} }
void FormatFactory::markFormatDoesntSupportAppend(const String & name) void FormatFactory::markFormatHasNoAppendSupport(const String & name)
{ {
registerAppendSupportChecker(name, [](const FormatSettings &){ return false; }); registerAppendSupportChecker(name, [](const FormatSettings &){ return false; });
} }

View File

@ -176,7 +176,7 @@ public:
/// If format always doesn't support append, you can use this method instead of /// If format always doesn't support append, you can use this method instead of
/// registerAppendSupportChecker with append_support_checker that always returns true. /// registerAppendSupportChecker with append_support_checker that always returns true.
void markFormatDoesntSupportAppend(const String & name); void markFormatHasNoAppendSupport(const String & name);
bool checkIfFormatSupportAppend(const String & name, ContextPtr context, const std::optional<FormatSettings> & format_settings_ = std::nullopt); bool checkIfFormatSupportAppend(const String & name, ContextPtr context, const std::optional<FormatSettings> & format_settings_ = std::nullopt);

View File

@ -93,7 +93,7 @@ void registerOutputFormatArrow(FormatFactory & factory)
{ {
return std::make_shared<ArrowBlockOutputFormat>(buf, sample, false, format_settings); return std::make_shared<ArrowBlockOutputFormat>(buf, sample, false, format_settings);
}); });
factory.markFormatDoesntSupportAppend("Arrow"); factory.markFormatHasNoAppendSupport("Arrow");
factory.registerOutputFormat( factory.registerOutputFormat(
"ArrowStream", "ArrowStream",
@ -104,7 +104,7 @@ void registerOutputFormatArrow(FormatFactory & factory)
{ {
return std::make_shared<ArrowBlockOutputFormat>(buf, sample, true, format_settings); return std::make_shared<ArrowBlockOutputFormat>(buf, sample, true, format_settings);
}); });
factory.markFormatDoesntSupportAppend("ArrowStream"); factory.markFormatHasNoAppendSupport("ArrowStream");
} }
} }

View File

@ -479,7 +479,7 @@ void registerOutputFormatAvro(FormatFactory & factory)
{ {
return std::make_shared<AvroRowOutputFormat>(buf, sample, params, settings); return std::make_shared<AvroRowOutputFormat>(buf, sample, params, settings);
}); });
factory.markFormatDoesntSupportAppend("Avro"); factory.markFormatHasNoAppendSupport("Avro");
} }
} }

View File

@ -284,7 +284,7 @@ void registerOutputFormatJSON(FormatFactory & factory)
}); });
factory.markOutputFormatSupportsParallelFormatting("JSON"); factory.markOutputFormatSupportsParallelFormatting("JSON");
factory.markFormatDoesntSupportAppend("JSON"); factory.markFormatHasNoAppendSupport("JSON");
factory.registerOutputFormat("JSONStrings", []( factory.registerOutputFormat("JSONStrings", [](
WriteBuffer & buf, WriteBuffer & buf,
@ -296,7 +296,7 @@ void registerOutputFormatJSON(FormatFactory & factory)
}); });
factory.markOutputFormatSupportsParallelFormatting("JSONStrings"); factory.markOutputFormatSupportsParallelFormatting("JSONStrings");
factory.markFormatDoesntSupportAppend("JSONStrings"); factory.markFormatHasNoAppendSupport("JSONStrings");
} }
} }

View File

@ -526,7 +526,7 @@ void registerOutputFormatORC(FormatFactory & factory)
{ {
return std::make_shared<ORCBlockOutputFormat>(buf, sample, format_settings); return std::make_shared<ORCBlockOutputFormat>(buf, sample, format_settings);
}); });
factory.markFormatDoesntSupportAppend("ORC"); factory.markFormatHasNoAppendSupport("ORC");
} }
} }

View File

@ -85,7 +85,7 @@ void registerOutputFormatParquet(FormatFactory & factory)
{ {
return std::make_shared<ParquetBlockOutputFormat>(buf, sample, format_settings); return std::make_shared<ParquetBlockOutputFormat>(buf, sample, format_settings);
}); });
factory.markFormatDoesntSupportAppend("Parquet"); factory.markFormatHasNoAppendSupport("Parquet");
} }
} }

View File

@ -256,7 +256,7 @@ void registerOutputFormatXML(FormatFactory & factory)
}); });
factory.markOutputFormatSupportsParallelFormatting("XML"); factory.markOutputFormatSupportsParallelFormatting("XML");
factory.markFormatDoesntSupportAppend("XML"); factory.markFormatHasNoAppendSupport("XML");
} }
} }