mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-09-20 08:40:50 +00:00
check-style: cover *.j2 too
This commit is contained in:
parent
617cdd5d4d
commit
6c61d3731e
@ -89,7 +89,7 @@ find $ROOT_PATH/tests/queries -iname '*fail*' |
|
|||||||
# Queries to system.query_log/system.query_thread_log should have current_database = currentDatabase() condition
|
# Queries to system.query_log/system.query_thread_log should have current_database = currentDatabase() condition
|
||||||
# NOTE: it is not that accuate, but at least something.
|
# NOTE: it is not that accuate, but at least something.
|
||||||
tests_with_query_log=( $(
|
tests_with_query_log=( $(
|
||||||
find $ROOT_PATH/tests/queries -iname '*.sql' -or -iname '*.sh' -or -iname '*.py' |
|
find $ROOT_PATH/tests/queries -iname '*.sql' -or -iname '*.sh' -or -iname '*.py' -or -iname '*.j2' |
|
||||||
grep -vP $EXCLUDE_DIRS |
|
grep -vP $EXCLUDE_DIRS |
|
||||||
xargs grep --with-filename -e system.query_log -e system.query_thread_log | cut -d: -f1 | sort -u
|
xargs grep --with-filename -e system.query_log -e system.query_thread_log | cut -d: -f1 | sort -u
|
||||||
) )
|
) )
|
||||||
@ -102,7 +102,7 @@ done
|
|||||||
# Queries to system.tables/system.parts/system.detached_parts/system.parts_columns/system.columns should have database = currentDatabase() condition
|
# Queries to system.tables/system.parts/system.detached_parts/system.parts_columns/system.columns should have database = currentDatabase() condition
|
||||||
# NOTE: it is not that accuate, but at least something.
|
# NOTE: it is not that accuate, but at least something.
|
||||||
tests_with_database_column=( $(
|
tests_with_database_column=( $(
|
||||||
find $ROOT_PATH/tests/queries -iname '*.sql' -or -iname '*.sh' -or -iname '*.py' |
|
find $ROOT_PATH/tests/queries -iname '*.sql' -or -iname '*.sh' -or -iname '*.py' -or -iname '*.j2' |
|
||||||
grep -vP $EXCLUDE_DIRS |
|
grep -vP $EXCLUDE_DIRS |
|
||||||
grep -v -x -e $ROOT_PATH/tests/queries/query_test.py |
|
grep -v -x -e $ROOT_PATH/tests/queries/query_test.py |
|
||||||
xargs grep --with-filename -e system.tables -e system.parts -e system.detached_parts -e system.parts_columns -e system.columns | cut -d: -f1 | sort -u
|
xargs grep --with-filename -e system.tables -e system.parts -e system.detached_parts -e system.parts_columns -e system.columns | cut -d: -f1 | sort -u
|
||||||
@ -121,7 +121,7 @@ done
|
|||||||
# Queries with ReplicatedMergeTree
|
# Queries with ReplicatedMergeTree
|
||||||
# NOTE: it is not that accuate, but at least something.
|
# NOTE: it is not that accuate, but at least something.
|
||||||
tests_with_replicated_merge_tree=( $(
|
tests_with_replicated_merge_tree=( $(
|
||||||
find $ROOT_PATH/tests/queries -iname '*.sql' -or -iname '*.sh' -or -iname '*.py' |
|
find $ROOT_PATH/tests/queries -iname '*.sql' -or -iname '*.sh' -or -iname '*.py' -or -iname '*.j2' |
|
||||||
grep -vP $EXCLUDE_DIRS |
|
grep -vP $EXCLUDE_DIRS |
|
||||||
xargs grep --with-filename -e ReplicatedMergeTree | cut -d: -f1 | sort -u
|
xargs grep --with-filename -e ReplicatedMergeTree | cut -d: -f1 | sort -u
|
||||||
) )
|
) )
|
||||||
@ -131,7 +131,7 @@ for test_case in "${tests_with_replicated_merge_tree[@]}"; do
|
|||||||
test_case_zk_prefix="\$CLICKHOUSE_TEST_ZOOKEEPER_PREFIX"
|
test_case_zk_prefix="\$CLICKHOUSE_TEST_ZOOKEEPER_PREFIX"
|
||||||
grep -q -e "ReplicatedMergeTree.*$test_case_zk_prefix" "$test_case" || echo "ReplicatedMergeTree should contain '$test_case_zk_prefix' in zookeeper path to avoid overlaps ($test_case)"
|
grep -q -e "ReplicatedMergeTree.*$test_case_zk_prefix" "$test_case" || echo "ReplicatedMergeTree should contain '$test_case_zk_prefix' in zookeeper path to avoid overlaps ($test_case)"
|
||||||
;;
|
;;
|
||||||
*.sql)
|
*.sql|*.sql.j2)
|
||||||
test_case_zk_prefix="{[ ]*database[ ]*}"
|
test_case_zk_prefix="{[ ]*database[ ]*}"
|
||||||
grep -q -e "ReplicatedMergeTree.*$test_case_zk_prefix" "$test_case" || echo "ReplicatedMergeTree should contain '$test_case_zk_prefix' in zookeeper path to avoid overlaps ($test_case)"
|
grep -q -e "ReplicatedMergeTree.*$test_case_zk_prefix" "$test_case" || echo "ReplicatedMergeTree should contain '$test_case_zk_prefix' in zookeeper path to avoid overlaps ($test_case)"
|
||||||
;;
|
;;
|
||||||
@ -180,7 +180,7 @@ find $ROOT_PATH/{src,programs,utils} -name '*.h' |
|
|||||||
while read file; do [[ $(head -n1 $file) != '#pragma once' ]] && echo "File $file must have '#pragma once' in first line"; done
|
while read file; do [[ $(head -n1 $file) != '#pragma once' ]] && echo "File $file must have '#pragma once' in first line"; done
|
||||||
|
|
||||||
# Check for executable bit on non-executable files
|
# Check for executable bit on non-executable files
|
||||||
find $ROOT_PATH/{src,base,programs,utils,tests,docs,website,cmake} '(' -name '*.cpp' -or -name '*.h' -or -name '*.sql' -or -name '*.xml' -or -name '*.reference' -or -name '*.txt' -or -name '*.md' ')' -and -executable | grep -P '.' && echo "These files should not be executable."
|
find $ROOT_PATH/{src,base,programs,utils,tests,docs,website,cmake} '(' -name '*.cpp' -or -name '*.h' -or -name '*.sql' -or -name '*.j2' -or -name '*.xml' -or -name '*.reference' -or -name '*.txt' -or -name '*.md' ')' -and -executable | grep -P '.' && echo "These files should not be executable."
|
||||||
|
|
||||||
# Check for BOM
|
# Check for BOM
|
||||||
find $ROOT_PATH/{src,base,programs,utils,tests,docs,website,cmake} -name '*.md' -or -name '*.cpp' -or -name '*.h' | xargs grep -l -F $'\xEF\xBB\xBF' | grep -P '.' && echo "Files should not have UTF-8 BOM"
|
find $ROOT_PATH/{src,base,programs,utils,tests,docs,website,cmake} -name '*.md' -or -name '*.cpp' -or -name '*.h' | xargs grep -l -F $'\xEF\xBB\xBF' | grep -P '.' && echo "Files should not have UTF-8 BOM"
|
||||||
|
Loading…
Reference in New Issue
Block a user