thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-24 08:32:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not silently catch errors for writing to S3

Browse Source
This commit is contained in:
Azat Khuzhin 2021-03-27 07:20:16 +03:00
parent c489355357
commit 6ebe4e7dbb
2 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/IO/WriteBufferFromS3.cpp
View File

@ -112,18 +112,6 @@ void WriteBufferFromS3::finalizeImpl()
finalized = true; finalized = true;
} }
WriteBufferFromS3::~WriteBufferFromS3()
{
try
{
finalizeImpl();
}
catch (...)
{
tryLogCurrentException(log);
}
}
void WriteBufferFromS3::createMultipartUpload() void WriteBufferFromS3::createMultipartUpload()
{ {
Aws::S3::Model::CreateMultipartUploadRequest req; Aws::S3::Model::CreateMultipartUploadRequest req;

2
src/IO/WriteBufferFromS3.h
View File

@ -64,8 +64,6 @@ public:
/// Receives response from the server after sending all data. /// Receives response from the server after sending all data.
void finalize() override; void finalize() override;
~WriteBufferFromS3() override;
private: private:
bool finalized = false; bool finalized = false;