thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 23:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Added required comment #10576

Browse Source
This commit is contained in:
Alexey Milovidov 2020-05-03 01:34:50 +03:00
parent a235533d5f
commit abe40e2127
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/IO/S3Common.cpp
View File

@ -83,7 +83,8 @@ namespace S3
return ret;
}
std::shared_ptr<Aws::S3::S3Client> ClientFactory::create(
/// This method is not static because it requires ClientFactory to be initialized.
std::shared_ptr<Aws::S3::S3Client> ClientFactory::create( // NOLINT
const String & endpoint,
const String & access_key_id,
const String & secret_access_key)
@ -95,7 +96,7 @@ namespace S3
return create(cfg, access_key_id, secret_access_key);
}
std::shared_ptr<Aws::S3::S3Client> ClientFactory::create(
std::shared_ptr<Aws::S3::S3Client> ClientFactory::create( // NOLINT
Aws::Client::ClientConfiguration & cfg,
const String & access_key_id,
const String & secret_access_key)

4
src/IO/S3Common.h
View File

@ -23,12 +23,12 @@ public:
static ClientFactory & instance();
static std::shared_ptr<Aws::S3::S3Client> create(
std::shared_ptr<Aws::S3::S3Client> create(
const String & endpoint,
const String & access_key_id,
const String & secret_access_key);
static std::shared_ptr<Aws::S3::S3Client> create(
std::shared_ptr<Aws::S3::S3Client> create(
Aws::Client::ClientConfiguration & cfg,
const String & access_key_id,
const String & secret_access_key);