thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 16:50:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #45067 from kitaisreal/jit-compilation-float-to-bool-conversion-fix

Browse Source 
JIT compilation float to bool conversion fix
This commit is contained in:
Alexey Milovidov 2023-01-10 04:45:00 +03:00 committed by GitHub
commit c1ae35958d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/DataTypes/Native.h
View File

@ -138,7 +138,7 @@ static inline llvm::Value * nativeBoolCast(llvm::IRBuilder<> & b, const DataType
if (value->getType()->isIntegerTy())
return b.CreateICmpNE(value, zero);
if (value->getType()->isFloatingPointTy())
return b.CreateFCmpONE(value, zero); /// QNaN is false
return b.CreateFCmpUNE(value, zero);
throw Exception(ErrorCodes::NOT_IMPLEMENTED, "Cannot cast non-number {} to bool", from_type->getName());
}

4
tests/queries/0_stateless/02525_jit_logical_functions_nan.reference Normal file
View File

@ -0,0 +1,4 @@
1
1
1
1

9
tests/queries/0_stateless/02525_jit_logical_functions_nan.sql Normal file
View File

@ -0,0 +1,9 @@
SET min_count_to_compile_expression = 0;
SELECT NOT NOT cos(MAX(pow(1523598955, 763027371))) FROM numbers(1) SETTINGS compile_expressions = 0;
SELECT NOT NOT cos(MAX(pow(1523598955, 763027371))) FROM numbers(1) SETTINGS compile_expressions = 1;
SELECT not(not(materialize(nan))) FROM numbers(1) SETTINGS compile_expressions = 0;
SELECT not(not(materialize(nan))) FROM numbers(1) SETTINGS compile_expressions = 1;