thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-16 11:22:12 +00:00
Code Issues Packages Projects Releases Wiki Activity
62,510 Commits 9,338 Branches 1,783 Tags 2.1 GiB
01b1440bd4
Commit Graph

12685 Commits

Author SHA1 Message Date
alesapin
156ba8a7fc Disable setting by default and ban for old-syntax MergeTree 2021-04-05 12:16:38 +03:00
pingyu
e05ee09621 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into datasketches-uniq 2021-04-05 16:47:53 +08:00
Maksim Kita
d9cc03bc34 Fixed tests 2021-04-05 11:29:05 +03:00
alesapin
8d5a787f6b Merge branch 'master' into merge_tree_deduplication 2021-04-05 10:40:03 +03:00
Azat Khuzhin
181cde0970 Fix impossible invalid-read for system.errors accounting 
Simple reproducer is throw Exception(-1, "foo"), but there is no such
code, hence it is impossible.
 2021-04-05 09:01:29 +03:00
Azat Khuzhin
42d858b7e5 Fix LOGICAL_ERROR for Log with nested types w/o columns in the SELECT clause 
Found with fuzzer [1]:

<details>

    2021.04.04 10:25:46.762596 [ 135 ] {4b6b5de3-d242-4267-910a-76b235467356} <Fatal> : Logical error: 'Logical error: no information about file column%2Ename.size0 in StorageLog'.
    ...
    2021.04.04 10:25:46.763563 [ 44 ] {} <Trace> BaseDaemon: Received signal 6
    2021.04.04 10:25:46.765884 [ 165 ] {} <Fatal> BaseDaemon: 5. abort @ 0x25859 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    2021.04.04 10:25:46.901540 [ 165 ] {} <Fatal> BaseDaemon: 6. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:51: DB::handle_error_code() @ 0x11cc4f16 in /workspace/clickhouse
    2021.04.04 10:25:47.030755 [ 165 ] {} <Fatal> BaseDaemon: 7. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:58: DB::Exception::Exception() @ 0x11cc5025 in /workspace/clickhouse
    2021.04.04 10:25:47.617201 [ 165 ] {} <Fatal> BaseDaemon: 8. ./obj-x86_64-linux-gnu/../src/Storages/StorageLog.cpp:183: DB::LogSource::readData()

</details>

  [1]: https://clickhouse-test-reports.s3.yandex.net/22583/69296876005c0fa171c755f8b224e4d58192c402/fuzzer_debug/report.html#fail1

The problem here is that there is no column%2Ename.size0 there is
column.size0 instead, and it seems that reading sizeX file is not enough
in other places, so just filter them out in
ExpressionActions::getSmallestColumn() (fallback method for storages w/o
getColumnSizes() implemented)
 2021-04-05 08:48:04 +03:00
alexey-milovidov
6cefb8e620
Merge pull request #22583 from azat/log-rwlock-ub-fix 
Avoid UB in *Log engines for rwlock unlock due to unlock from another thread
 2021-04-05 05:20:16 +03:00
alexey-milovidov
f78c846bdf
Merge pull request #22591 from nvartolomei/nv/out-init-check 
Try flush write buffer only if it is initialized
 2021-04-05 04:32:54 +03:00
Maxim Akhmedov
725fa17961 Introduce IStorage::distributedWrite method for distributed INSERT SELECT. 2021-04-05 02:14:27 +03:00
Alexey Milovidov
e50d82ab45 Merge branch 'master' into change-accurate-comparison 2021-04-05 01:38:55 +03:00
Alexey Milovidov
6e93d936d3 Highlight potential bugs in code 2021-04-05 01:38:47 +03:00
Maksim Kita
deb35c5f4e DirectDictionary dictGet multiple columns optimization 2021-04-05 01:26:26 +03:00
Maksim Kita
e486fde35e
Update HashMap.h 2021-04-05 01:20:17 +03:00
Maksim Kita
fa49817421
Update HashMap.h 2021-04-05 01:01:20 +03:00
alexey-milovidov
b1e7624b3f
Merge pull request #22589 from ClickHouse/fix-comments 
Fix comments
 2021-04-05 00:22:27 +03:00
alexey-milovidov
c0a13bb5d2
Merge pull request #22586 from ClickHouse/minor-improvement-deserialize-index 
Minor improvement in index deserialization
 2021-04-05 00:20:29 +03:00
alesapin
caaa19edb8
Merge pull request #22373 from ClickHouse/jepsen_for_ci 
Add image to run jepsen tests
 2021-04-04 18:35:21 +03:00
alesapin
0ceb95aa55 Merge branch 'master' into merge_tree_deduplication 2021-04-04 18:32:27 +03:00
Anton Popov
0d03b8c0c4
Merge pull request #21889 from CurtizJ/fix-aggregation-in-order-1 
Fix bugs in aggregation by primary key
 2021-04-04 18:17:04 +03:00
pingyu
1ea74a1947 bug fix. add unit tests.# 2021-04-04 22:22:47 +08:00
Maksim Kita
027ca2484e FlatDictionary added layout options initial_array_size, max_array_size 2021-04-04 16:30:48 +03:00
Maksim Kita
41ef9291f1 Fixed tests 2021-04-04 16:30:48 +03:00
Maksim Kita
ff86c21e65 Dictionary update field fix 2021-04-04 16:30:48 +03:00
alesapin
76d0e60e26 Merge branch 'master' into jepsen_for_ci 2021-04-04 16:07:53 +03:00
alexey-milovidov
0e1035735c
Merge pull request #22565 from ClickHouse/fix-assert-arena 
Fix assert in Arena when doing GROUP BY Array of Nothing of non-zero size.
 2021-04-04 15:38:17 +03:00
alexey-milovidov
72cf7b01e8
Merge pull request #22571 from mastertheknife/allow_unbundled_xz_lzma 
Allow building with unbundled xz
 2021-04-04 15:36:45 +03:00
Alexey Milovidov
32f9a407ff More precise and safe accurate comparison of int vs. float 2021-04-04 14:49:48 +03:00
Vladimir Chebotarev
0eb051961c Consistent AWS timeouts. 2021-04-04 14:06:10 +03:00
Maksim Kita
0bfb429c42
Merge pull request #22479 from kitaisreal/clickhouse-dictionary-source-loop-fix 
ClickHouseDictionarySource loop fix
 2021-04-04 13:29:17 +03:00
Azat Khuzhin
44abb7588a StorageStripeLog: avoid UB for rwlock unlock due to unlock from another thread 2021-04-04 13:25:44 +03:00
Azat Khuzhin
89a96cf14d StorageLog: avoid UB for rwlock unlock due to unlock from another thread 2021-04-04 13:25:44 +03:00
Azat Khuzhin
5d795661ed StorageTinyLog: add regression test for UB due to unlock from different thread 
Refs: #22560
 2021-04-04 13:25:44 +03:00
Azat Khuzhin
5ced6e2e9a StorageStripeLog: drop mutable qualifier for rwlock 2021-04-04 13:25:43 +03:00
Azat Khuzhin
5ef845af40 StorageLog: drop mutable qualifier for rwlock 2021-04-04 13:25:43 +03:00
Alexey Milovidov
d67ced585a Fix engrish 2021-04-04 13:09:39 +03:00
fuqi
043bd11d2e fix dist map type select 2021-04-04 18:00:30 +08:00
Nicolae Vartolomei
49abdeb967 Try flush write buffer only if it is initialized 
Fixes #22579
 2021-04-04 12:59:51 +03:00
Alexey Milovidov
54caa61af5 Fix comments 2021-04-04 12:33:06 +03:00
fuqi
b590926c1c fix dist map type select 2021-04-04 17:23:47 +08:00
Alexey Milovidov
8b5d0a598f Minor improvement in index deserialization 2021-04-04 12:17:54 +03:00
alesapin
548ec6d2cb Trying enabled setting 2021-04-04 11:02:09 +03:00
Alexey Milovidov
a0f2b85cd3 Make round function to behave consistently on non-x86_64 2021-04-04 05:21:56 +03:00
alexey-milovidov
b35ba1152f
Update IColumnDummy.h 2021-04-04 05:04:11 +03:00
Maksim Kita
b9e8ff137a Fixed build 2021-04-04 01:19:57 +03:00
mastertheknife
65ca073f42 Allow unbundled xz (lzma) using USE_INTERNAL_XZ_LIBRARY=OFF 2021-04-04 01:05:07 +03:00
alexey-milovidov
cb4e119c3d
Merge pull request #22561 from traceon/apple-clang-compilation-fix 
AppleClang compilation fix
 2021-04-04 00:25:58 +03:00
Alexey Milovidov
3050486308 Fix assert in Arena 2021-04-03 22:50:49 +03:00
alexey-milovidov
67fdfd4b89
Merge pull request #22560 from azat/tiny-log-rwlock-ub-fix 
Fix UB by unlocking the rwlock of the TinyLog from the same thread
 2021-04-03 21:59:01 +03:00
Denis Glazachev
36b03b2740 Compilation fix 2021-04-03 22:17:51 +04:00
alesapin
1906c77884 Fix tidy one more time 2021-04-03 17:57:03 +03:00
Azat Khuzhin
6cebd3ee1f Fix UB by unlocking the rwlock of the TinyLog from the same thread 
Before this patch the build with libstdc++ hangs for
00967_insert_into_distributed_different_types test (and I guess some
others), this is because the rwlock is acquired from different thread as
it was unlocked which causes UB [1], fix this by moving unlock into
writeSuffix().

  [1]: The pthread_rwlock_unlock() function shall release a lock held on
       the read-write lock object referenced by rwlock. Results are undefined
       if the read-write lock rwlock is not held by the **calling thread**.
 2021-04-03 16:04:39 +03:00
Azat Khuzhin
10d35867e3 Drop mutable qualifier for StorageTinyLog::rwlock 2021-04-03 16:03:17 +03:00
alesapin
0204f5dd35 Merge branch 'master' into merge_tree_deduplication 2021-04-03 15:24:26 +03:00
alesapin
b127e31451 CI fixes 2021-04-03 14:56:56 +03:00
alexey-milovidov
30ece2c28f
Merge pull request #22510 from vdimir/merge-join-lc-bug-fix 
Convert right block to full in MergeJoin
 2021-04-03 12:54:34 +03:00
alexey-milovidov
143f4b59a0
Merge pull request #22527 from ClickHouse/fix-missing-nl-parse-tsv 
Fix deserialization of empty string without newline at end of TSV format
 2021-04-03 12:51:10 +03:00
alexey-milovidov
2de808ec5a
Update SerializationNullable.cpp 2021-04-03 12:50:57 +03:00
alexey-milovidov
687d1e9b54
Merge pull request #22528 from kitaisreal/format-settings-null-as-default-default-value-fix 
FormatSettings null_as_default default value fix
 2021-04-03 12:49:08 +03:00
kssenii
13d1f17d3e Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into replicas-shards-for-mysql-and-postgres 2021-04-03 08:00:09 +00:00
alexey-milovidov
9f5cd35a69
Merge pull request #22323 from abyss7/poco-http2 
Follow up to #19516
 2021-04-03 02:09:10 +03:00
alexey-milovidov
3d860fc6ac
Merge pull request #22322 from abyss7/issue-21907 
Do not limit HTTP chunk size
 2021-04-03 01:58:22 +03:00
Maksim Kita
07d5a1ec21 ClickHouseDictionarySource loop fix 2021-04-03 00:40:07 +03:00
Maksim Kita
5ba6c7b731 FormatSettings null_as_default default value fix 2021-04-03 00:05:40 +03:00
Alexey Milovidov
7a4637c645 Fix deserialization of empty string without newline at end of TSV format 2021-04-02 23:54:03 +03:00
alexey-milovidov
c3a9cbe01c
Merge pull request #22421 from ClickHouse/fix-buffer-overflow-in-token-extractor 
Fix buffer overflow in token extractor
 2021-04-02 22:08:28 +03:00
alexey-milovidov
840ecb5e99
Update MergeJoin.cpp 2021-04-02 21:07:11 +03:00
alesapin
b884593186 Followup fix 2021-04-02 20:55:05 +03:00
alesapin
ca30c91868 More comments 2021-04-02 20:54:24 +03:00
alesapin
fc3afe1087 Fix typos 2021-04-02 20:51:57 +03:00
alesapin
b105153d2c Useful comment 2021-04-02 20:48:58 +03:00
alesapin
ab34873344 Add some comments 2021-04-02 20:46:01 +03:00
alesapin
a555d078a2 Add exception handling 2021-04-02 19:56:02 +03:00
Alexander Kuzmenkov
d0037329cf
Merge pull request #22459 from ClickHouse/aku/window-frame-offset 
fix window frame offset check and add more tests
 2021-04-02 19:49:59 +03:00
alesapin
759dd79c76 Add tests 2021-04-02 19:45:18 +03:00
kssenii
2de6b99f84 Better names 2021-04-02 16:12:14 +00:00
kssenii
02c6332e86 Pass null values properly 2021-04-02 18:45:42 +03:00
robot-clickhouse
39b5674bef Auto version update to [21.5.1.1] [54450] 2021-04-02 18:34:29 +03:00
Alexander Kuzmenkov
e7df8893df
Merge pull request #22300 from ClickHouse/trying_parallel_func_tests 
Trying parallel func tests
 2021-04-02 18:09:58 +03:00
vdimir
c8f51998ba
Remove LowCardinality from right block sample in MergeJoin 2021-04-02 17:51:02 +03:00
tavplubix
93bd2c3b67
Merge pull request #18978 from myrrc/feature/attach-partition-local 
Lookup parts/partitions in replica's own detached/ folder before downloading them from other replicas
 2021-04-02 17:46:03 +03:00
Nikolai Kochetov
0421460943 Always call even.set for zk client callbacks. 2021-04-02 17:06:53 +03:00
vdimir
8cd841c4ac
Handle lowcardinality block in MergeJoin extractMinMax 2021-04-02 16:55:42 +03:00
alesapin
6f36661575 Buildable code 2021-04-02 16:34:36 +03:00
tavplubix
c1ab9de720
Update MergeTreeDataPartChecksum.cpp 2021-04-02 15:57:30 +03:00
alesapin
2ab87d61eb Some build fixes 2021-04-02 15:37:42 +03:00
Alexander Kuzmenkov
16c5658df6 Merge remote-tracking branch 'origin/master' into HEAD 2021-04-02 15:16:24 +03:00
Anton Popov
a000d6154c fix clang-tidy 2021-04-02 15:10:49 +03:00
alesapin
14634689e5 Idea code 2021-04-02 14:46:42 +03:00
hexiaoting
6e8583a028 Add array size check for Nested Type subcolumns when Update 2021-04-02 19:31:33 +08:00
Ivan Lezhankin
8a455d347a Fix build 2021-04-02 14:08:32 +03:00
Pavel Kruglov
dff7834af0 Fix config comparison 2021-04-02 13:17:28 +03:00
Kruglov Pavel
6fb70cfd3f
Merge pull request #22443 from Avogar/hedged 
Remove socket from epoll before cancelling packet receiver in HedgedConnections to prevent possible race
 2021-04-02 11:49:21 +03:00
Vladimir
9b40f384e9
Merge pull request #20622 from vdimir/issue-20497 2021-04-02 11:48:29 +03:00
Maksim Kita
3b799c5d7d
Merge pull request #22413 from kitaisreal/added-function-dict-get-or-null 
Added function dictGetOrNull
 2021-04-02 11:39:01 +03:00
Maksim Kita
d06fb1197a
Merge pull request #22096 from kitaisreal/hierarchy-dictionaries-updated 
Refactored hierarchy dictionaries interface
 2021-04-02 11:38:01 +03:00
Kseniia Sumarokova
b80951b06a
Merge pull request #21519 from fastio/aliases_to_visitParam 
add aliases to visitParam/visitParamExtract* functions
 2021-04-02 10:31:32 +03:00
Anton Popov
56320bcbfd minor refactoring 2021-04-02 01:16:54 +03:00
Anton Popov
88cd775f6a Merge remote-tracking branch 'upstream/master' into HEAD 2021-04-02 00:14:03 +03:00
kssenii
b66e0401f6 Lowercase 2021-04-01 23:07:01 +03:00
alesapin
4eaf585fe5 Almost nothing added 2021-04-01 22:49:51 +03:00
Mike Kot
c947280dfc Merge remote-tracking branch 'upstream/master' into feature/attach-partition-local 2021-04-01 21:38:51 +03:00
Mike Kot
60e5946449 Removed needless logging, fixed data part initialization while checking 
in the detached folder
 2021-04-01 20:11:14 +03:00
Alexander Kuzmenkov
d006c5532e fix window frame offset check and add more tests 2021-04-01 18:56:58 +03:00
Pavel Kruglov
6f65a72112 Remove socket from epoll before cancelling packet receiver to prevent race 2021-04-01 17:35:00 +03:00
alexey-milovidov
2d1a2ddb9b
Merge pull request #22411 from nvartolomei/nv/replication-queue-directory-already-exists 
Delete temporary fetch directory if it already exists
 2021-04-01 17:12:51 +03:00
alexey-milovidov
c7f134d0b7
Merge pull request #22430 from mastertheknife/ppc64le_compile_stacktrace 
ppc64le: Fix compile and stack trace
 2021-04-01 17:11:32 +03:00
kssenii
99f0b08ac3 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into replicas-shards-for-mysql-and-postgres 2021-04-01 13:48:33 +00:00
Alexey Milovidov
39c3efdb00 Fix build 2021-04-01 16:38:04 +03:00
Alexey Milovidov
fbb4b05df0 Merge remote-tracking branch 'origin' into fix-buffer-overflow-in-token-extractor 2021-04-01 16:30:10 +03:00
Ivan Lezhankin
d9d143675a Merge remote-tracking branch 'upstream/master' into issue-21907 2021-04-01 16:29:26 +03:00
alexey-milovidov
28c7980fba
Merge pull request #22427 from ClickHouse/protocol-break-oom 
Better exception message in client in case of exception while writing blocks
 2021-04-01 16:28:50 +03:00
Ivan Lezhankin
19550d5173 Initialize pointer with nullptr 2021-04-01 16:26:13 +03:00
alexey-milovidov
e3aa47c525
Merge pull request #22425 from ClickHouse/parallel-formatting-memory 
Add memory accounting in parallel formatting
 2021-04-01 16:23:48 +03:00
alesapin
85fbb7eccf
Merge pull request #21976 from ClickHouse/try-fix-excessive-rows-for-collapsing-merge 
CollapsingSortedAlgorithm should not return more than index_granularity rows
 2021-04-01 16:20:28 +03:00
Ivan Lezhankin
cc1c439ad8 Merge remote-tracking branch 'upstream/master' into poco-http2 2021-04-01 16:20:15 +03:00
Alexander Kuzmenkov
c7bf01fa33 typo 2021-04-01 16:08:18 +03:00
Alexander Kuzmenkov
ba64bc8557 quick fix for inaccessible DatabaseReplicated 2021-04-01 15:21:29 +03:00
alesapin
8fc01195ce Some improvements 2021-04-01 15:19:39 +03:00
kssenii
8300a74f5a Fix 2021-04-01 12:09:44 +00:00
Maksim Kita
2c522cf8bb
Update FunctionsExternalDictionaries.h 2021-04-01 15:06:08 +03:00
kssenii
2c70183652 Fix settings 2021-04-01 11:41:22 +00:00
vdimir
3f464595eb
Accurate removing 'join' part for queries to 'Merge' engine 2021-04-01 14:31:57 +03:00
vdimir
fff8043e55
Revert "Fix joined table access with Merge engine and aggregation" 
This reverts commit 5476e68d6c.
 2021-04-01 14:31:46 +03:00
kssenii
522d170588 Add default port 2021-04-01 11:30:20 +00:00
vdimir
5476e68d6c
Fix joined table access with Merge engine and aggregation 2021-04-01 14:26:28 +03:00
Alexander Kuzmenkov
b669b3aca9 Merge remote-tracking branch 'origin/master' into HEAD 2021-04-01 14:25:04 +03:00
Pavel Kruglov
cc65a1db97 Update paths to the model configs in config reloading 2021-04-01 13:30:05 +03:00
kssenii
747967a9bb Better 2021-04-01 10:27:24 +00:00
Maksim Kita
42ae39f78f Updated tests 2021-04-01 12:13:36 +03:00
alesapin
7c8f54e694 More changes 2021-04-01 11:07:56 +03:00
mastertheknife
2a44a808a6 ppc64le: Fix compile and stack trace 2021-04-01 10:44:26 +03:00
alexey-milovidov
956dba1d9c
Merge pull request #22396 from ClickHouse/stress-oom 
Fix some OOMs in stress tests
 2021-04-01 10:12:31 +03:00
kssenii
799a1f177e Rename to SimpleJSON* 2021-04-01 14:24:10 +08:00
fastio
4daf011e0b add aliases to visitParam/visitParamExtract* functions 2021-04-01 14:24:10 +08:00
alexey-milovidov
5ae494521d
Merge pull request #22389 from ClickHouse/map-op-ubsan 
Fix UBSan report in mapOp
 2021-04-01 07:35:44 +03:00
pingyu
86d8bc1c54 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into datasketches-uniq 2021-04-01 12:35:24 +08:00
Alexey Milovidov
58681e7315 Merge branch 'protocol-break-oom' into protocol-compression-auto 2021-04-01 07:18:24 +03:00
Alexey Milovidov
f441fd3015 Merge branch 'master' into protocol-compression-auto 2021-04-01 07:18:08 +03:00
alexey-milovidov
95d761f350
Merge pull request #22412 from ClickHouse/aku/invalid-frame-start 
fix error message for invalid window frame start
 2021-04-01 07:17:03 +03:00
Alexey Milovidov
9d65d83c83 Better exception message in client in case of exception while writing blocks 2021-04-01 07:12:07 +03:00
Alexey Milovidov
b0539eb28f Move method 2021-04-01 06:28:25 +03:00
Alexey Milovidov
14f2cf9b80 Add memory accounting in parallel formatting 2021-04-01 06:17:23 +03:00
Alexey Milovidov
7db8fcdebd Fix buffer overflow in TokenExtractor #19233 2021-04-01 05:37:19 +03:00
Peng Jian
1e033e8817 fix code style 2021-04-01 10:12:37 +08:00
Alexey Milovidov
7589a014f9 Better fix 2021-04-01 03:44:02 +03:00
Alexey Milovidov
c9fac714b4 Merge branch 'master' into map-op-ubsan 2021-04-01 03:27:33 +03:00
Alexey Milovidov
12ff56673b Merge branch 'master' into datasketches-cmake 2021-04-01 03:17:05 +03:00
alexey-milovidov
bbd41d64c2
Update DataPartsExchange.cpp 2021-04-01 02:59:47 +03:00
alexey-milovidov
538be4086b
Recursive removal is extremely dangerous. 2021-04-01 02:59:23 +03:00
Alexey Milovidov
e67d93d165 Merge branch 'master' into stress-oom 2021-04-01 01:43:40 +03:00
alexey-milovidov
2a88db677e
Merge pull request #22407 from amosbird/m 
Correctly place debug helpers
 2021-04-01 01:40:35 +03:00
Maksim Kita
2ad29a541a Updated interfaces 2021-04-01 00:12:21 +03:00
Maksim Kita
f4ab8b84b6 Added comment 2021-03-31 22:56:30 +03:00
kssenii
18dd8dd79b Typo 2021-03-31 17:05:41 +00:00
Alexander Kuzmenkov
deaba9f722
Update formatReadable.cpp 2021-03-31 18:40:33 +03:00
alesapin
c15d7e009d Some initial code 2021-03-31 18:20:30 +03:00
Alexander Kuzmenkov
20066d8cd9
Update ExpressionElementParsers.cpp 2021-03-31 18:17:44 +03:00
Maksim Kita
f2e6a0a97d Added function dictGetOrNull 2021-03-31 17:46:13 +03:00
Peng Jian
26b5482b4d remove the flag in the parser 2021-03-31 22:25:51 +08:00
Alexander Kuzmenkov
0e75f7bad5 fix error message for invalid window frame start 2021-03-31 17:12:48 +03:00
kssenii
4e849f3b77 Less logging 2021-03-31 14:06:24 +00:00
kssenii
ba5ddd5c32 Do not parse replicas in PoolWithFailover 2021-03-31 14:03:52 +00:00
Nicolae Vartolomei
5cd1dc485f Delete temporary fetch directory if it already exists 
It could be left there after a network timeout, a system crash, or
checksum issues.

The downside of this PR is that it would be harder to debug checksum
issues if replication will continuously delete and try to fetch the same
part.
 2021-03-31 14:14:58 +01:00
Maksim Kita
55984e849c
Merge branch 'master' into hierarchy-dictionaries-updated 2021-03-31 15:55:07 +03:00
Amos Bird
061e3c7d81
Correctly place debug helpers 2021-03-31 18:28:58 +08:00
Maksim Kita
9772d30754 Fixed performance tests 2021-03-31 13:21:30 +03:00
Peng Jian
86a76bbfe4 fix compilation error 2021-03-31 17:38:46 +08:00
tavplubix
6c1e2a0d87
Merge pull request #21690 from ClickHouse/test_multiple_nodes 
Run three nodes with Replicated database and NuKeeper in CI
 2021-03-31 12:31:13 +03:00
vdimir
0353775086
Pass inner_columns to PredicateRewriteVisitorData::rewriteSubquery explicitly 2021-03-31 12:28:25 +03:00
Peng Jian
cf19ab76dc skip to next one before throw parsing exception 2021-03-31 17:16:51 +08:00
Peng Jian
ec54f2a361 fix compilation error 2021-03-31 17:16:51 +08:00
Peng Jian
278d2d7df0 fix typo 2021-03-31 17:16:51 +08:00
Peng Jian
cad54d4e2c reset the parser if exception catched. 2021-03-31 17:16:51 +08:00
Peng Jian
85cfb927e6 move HandleKafkaErrorMode to KafkaSettings 2021-03-31 17:16:51 +08:00
vdimir
7f1b67db06
Merge branch 'master' into issue-20497 2021-03-31 12:16:36 +03:00
Peng Jian
909d5ad2b5 Handle errors for Kafka engine 2021-03-31 17:15:57 +08:00
Vladimir
57eb5f8772
Merge pull request #22070 from Jokser/disk-s3-migration 2021-03-31 11:06:40 +03:00
alexey-milovidov
124d9e14ad
Merge pull request #22387 from ClickHouse/fix-msan-range 
Fix MSan report for function `range` with UInt256.
 2021-03-31 09:05:10 +03:00
Alexey Milovidov
2f7ac2424d Merge branch 'master' into datasketches-cmake 2021-03-31 08:47:27 +03:00
Alexey Milovidov
e9bfc7456d Merge branch 'master' into virtualutil 2021-03-31 08:19:43 +03:00
Alexey Milovidov
7f9c0e621a Merge branch 'virtualutil' of github.com:amosbird/ClickHouse into virtualutil 2021-03-31 08:19:39 +03:00
Alexey Milovidov
14c4cc2ccb Update ya.make 2021-03-31 08:19:15 +03:00
alexey-milovidov
6ed78827a5
Merge pull request #22326 from ClickHouse/test-mmap-io 
Run performance tests with enabled mmap IO
 2021-03-31 06:33:56 +03:00
Alexey Milovidov
7b1890f0b3 Fix some OOMs in stress tests 2021-03-31 06:19:34 +03:00
alexey-milovidov
a21fe0b492
Merge pull request #22378 from ianton-ru/s3_zero_copy_replication 
Fix S3 Zero-Copy replication for hybrid storage
 2021-03-31 04:15:47 +03:00
alexey-milovidov
59c158300a
Merge pull request #22365 from ClickHouse/aku/processes-database 
add current database to system.processes
 2021-03-31 04:14:17 +03:00
Alexey Milovidov
a59c66c266 Fix UBSan report in mapOp 2021-03-31 04:07:18 +03:00
Alexey Milovidov
c3b4587d9d Fix MSan report in function "range" 2021-03-31 03:54:40 +03:00
alexey-milovidov
5c15b8a896
Merge branch 'master' into virtualutil 2021-03-30 23:59:44 +03:00
alexey-milovidov
d7c15c6b9a
Merge pull request #22289 from traceon/fix-apple-clang-build 
Fix native macOS build for ALL_BUILD (Xcode/AppleClang)
 2021-03-30 23:55:13 +03:00
tavplubix
5117de1a0e
Merge pull request #22343 from Avogar/secure-socket-timeouts 
Remove setting same timeouts in secure socket
 2021-03-30 23:10:33 +03:00
Anton Ivashkin
f87435213e Fix S3 Zero-Copy replication for hybrid storage 2021-03-30 20:38:04 +03:00
kssenii
ce05087b1b Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into replicas-shards-for-mysql-and-postgres 2021-03-30 17:27:10 +00:00
Alexander Tokmakov
4f896d2b07 fix tests 2021-03-30 19:46:23 +03:00
Nikolai Kochetov
8fad179800 Fix some tests. 2021-03-30 18:14:20 +03:00
Amos Bird
69204e1d21
Add prefer_column_name_to_alias settings (#22044) 2021-03-30 16:51:45 +03:00
Alexander Kuzmenkov
0252f60c23 add current database to system.processes 2021-03-30 16:36:08 +03:00
Alexander Tokmakov
500a20f30d Merge branch 'master' into test_multiple_nodes 2021-03-30 16:23:33 +03:00
Ivan Lezhankin
873a98b33b Add test 2021-03-30 16:19:05 +03:00
Alexey Milovidov
150faa5e4d Merge branch 'master' into protocol-compression-auto 2021-03-30 15:59:36 +03:00
Kseniia Sumarokova
39ba3e4024
Merge pull request #20382 from stigsb/materializemysql-version-index 
MaterializeMySQL: add skipping index for _version column
 2021-03-30 14:30:50 +03:00
Alexey Milovidov
9e4e70ddac Merge branch 'master' into protocol-compression-auto 2021-03-30 13:32:34 +03:00
alexey-milovidov
6acb9bc827
Merge pull request #22320 from ClickHouse/fix-timeout-unit-test 
More coarse test for DateLUT
 2021-03-30 13:26:56 +03:00
Vladimir
5ae9f2c5bb
Merge pull request #21329 from depressed-pho/isIPAddressContainedIn 2021-03-30 13:26:49 +03:00
alesapin
2f891521db
Merge pull request #22291 from ClickHouse/no_logical_error_on_mutation 
Relax covering part check on mutation
 2021-03-30 13:25:27 +03:00
Nikolai Kochetov
88bfa6c9ba Add ReadFromMergeTree step. 2021-03-30 13:25:26 +03:00
Pavel Kovalenko
0bb369d5e2 Code review fixes. 2021-03-30 13:21:46 +03:00
alexey-milovidov
4e4d33e93b
Merge branch 'master' into fix-apple-clang-build 2021-03-30 13:15:07 +03:00
alexey-milovidov
971167c68f
Merge pull request #22328 from CurtizJ/remove-code 
Remove useless code
 2021-03-30 13:14:00 +03:00
Pavel Kruglov
5f3cb525ee Remove setting same timeouts in secure socket 2021-03-30 10:51:44 +03:00
Alexander Tokmakov
24fc120076 Merge branch 'master' into test_multiple_nodes 2021-03-30 10:40:38 +03:00
alesapin
5e3ebb3e0e
Merge pull request #22274 from ClickHouse/rename_keeper 
Rename NuKeeper and TestKeeper to Keeper in all places
 2021-03-30 10:39:22 +03:00
Nikolai Kochetov
78e27dc1b6
Merge pull request #22270 from liuneng1994/fix-query-failed 
fix constant condition conflict with column name and add stateless test
 2021-03-30 09:37:43 +03:00
Alexey Milovidov
21a909bde0 Merge branch 'master' into protocol-compression-auto 2021-03-30 04:15:02 +03:00
alexey-milovidov
a6959584d5
Merge pull request #22235 from ClickHouse/quantile-deterministic-msan 
Fix MSan report in `quantileDeterministic`
 2021-03-30 03:48:58 +03:00
alexey-milovidov
b7b55ce61d
Merge pull request #20088 from nvartolomei/nv/replicated-fetches-timeouts 
Replicated fetches timeouts
 2021-03-30 03:46:09 +03:00
Alexey Milovidov
e9c2309c05 A comment 2021-03-30 02:02:53 +03:00
Alexey Milovidov
466c70fb7c Code simplification 2021-03-30 02:00:25 +03:00
Anton Popov
43d9972f18 remove useless code 2021-03-30 01:34:02 +03:00
Anton Popov
5ada14082f
Merge pull request #22025 from vdimir/window-funncel-strict-increase 
Add option strict_increase to windowFunnel
 2021-03-30 01:20:17 +03:00
Alexey Milovidov
230b2930b7 Merge branch 'master' into virtualutil 2021-03-30 00:43:00 +03:00
Alexey Milovidov
85e4cfa731 Run performance tests with enabled mmap IO 2021-03-30 00:04:03 +03:00
alexey-milovidov
25f02f13b0
Merge pull request #22238 from ClickHouse/remove-harmful-code 
Remove harmful default parameters
 2021-03-29 23:46:18 +03:00
kssenii
49fc550d10 Merge branch 'master' of github.com:ClickHouse/ClickHouse into stigsb-materializemysql-version-index 2021-03-29 23:31:47 +03:00
flynn
858d1fe593
Fix table function clusterAllReplicas return wrong _shard_num (#21498) 
* Fix deadlock in delete mutations when predicate contains table itself

* Fix table function clusterAllReplicas return wrong _shard_num

fix build on gcc-10

better

update test

fix

fix

fix

fix

fix

fix cluster config

Co-authored-by: alesapin <alesapin@gmail.com>
 2021-03-29 23:21:08 +03:00
Maksim Kita
8a65e8b06e Fix arcadia build 2021-03-29 23:00:40 +03:00
Alexander Tokmakov
ccd31d1b72 Merge remote-tracking branch 'ch/rename_keeper' into test_multiple_nodes 2021-03-29 22:44:40 +03:00
Alexander Kuzmenkov
3a4ac94901 make some perf test queries more stable 2021-03-29 22:43:34 +03:00
Alexander Tokmakov
a5b07f2f03 Merge branch 'master' into test_multiple_nodes 2021-03-29 22:43:25 +03:00
tavplubix
3c0f5a57ec
Merge pull request #21535 from ClickHouse/distributed_ddl_improvements 
Distributed DDL improvements
 2021-03-29 22:40:11 +03:00
alexey-milovidov
9d84f3113a
Merge pull request #21512 from azat/optimize_skip_unused_shards_limit 
Add optimize_skip_unused_shards_limit
 2021-03-29 21:13:18 +03:00
alexey-milovidov
bb925e16bf
Merge pull request #22042 from Slach/fix_issue_22028 
case insensitive aliases for CONNECTION_ID() and VERSION()
 2021-03-29 21:02:24 +03:00
Ivan Lezhankin
ae741c7411 Do not limit HTTP chunk size 2021-03-29 20:49:28 +03:00
Kruglov Pavel
103de0838b
Merge pull request #22172 from Avogar/hedged 
Prevent busy waiting in hedged requests when async_socket_for_remote=0
 2021-03-29 20:14:49 +03:00
Alexey Milovidov
0876b146a5 More coarse test for DateLUT 2021-03-29 19:54:07 +03:00
Alexey Milovidov
f7662df06f Fix gcc build 2021-03-29 19:30:53 +03:00
Alexey Milovidov
c374be3ead Merge branch 'master' into quantile-deterministic-msan 2021-03-29 19:28:32 +03:00
alexey-milovidov
1512ff832e
Merge branch 'master' into nv/replicated-fetches-timeouts 2021-03-29 19:25:13 +03:00
changvvb
c1c5db1944 Update jemalloc_internal_defs & fix unit test 2021-03-30 00:07:34 +08:00
Maksim Kita
6fb444f732
Merge pull request #20184 from nvartolomei/nv/macos-shared 
Fix macOS shared lib build
 2021-03-29 18:25:43 +03:00
alexey-milovidov
9fd1577cd4
Merge pull request #22060 from ClickHouse/to-start-of-interval-hour-align 
Change behaviour of `toStartOfInterval` in backward incompatible way
 2021-03-29 17:52:41 +03:00
tavplubix
e3cf2d99b7
Update DatabaseReplicated.cpp 2021-03-29 16:44:41 +03:00
Maksim Kita
3071d45ade Fixed tests 2021-03-29 16:41:03 +03:00
Anton Popov
ea82e7725f
Merge pull request #21562 from CurtizJ/serialization-refactoring-4 
Refactoring of data types serialization
 2021-03-29 16:36:44 +03:00
vdimir
02a0caf28b
Fix build isIPAddressContainedIn 2021-03-29 16:28:51 +03:00
Alexander Kuzmenkov
0171ab95fa
Merge pull request #21640 from vdimir/fix-join-where-database-engine 
Remove unknown columns from joined table in where for queries to external database engines
 2021-03-29 16:14:10 +03:00
alesapin
f439e17ece Fix build 2021-03-29 15:41:26 +03:00
alesapin
2c06eb8382 Relax covering part check on mutation 2021-03-29 14:59:28 +03:00
Alexander Kuzmenkov
92c3db8f22
Merge pull request #22133 from ClickHouse/aku/negate-stable 
stable formatting for negate()
 2021-03-29 14:16:12 +03:00
Denis Glazachev
7fd7a7114f Remove unused local variable definition 2021-03-29 14:47:56 +04:00
Kruglov Pavel
6d60f2eb87
Merge pull request #22183 from azat/async_socket_for_remote-query-cancel-on-timeout-fix 
Fix query cancellation with use_hedged_requests=0 and async_socket_for_remote=1
 2021-03-29 13:07:59 +03:00
vdimir
ae4b8e3181
Rename isIPAddressContainedIn -> isIPAddressInRange 2021-03-29 12:56:11 +03:00
vdimir
81ff4f4791
Remove Nummable support from isIPAddressContainedIn, do not use OverloadResolver 2021-03-29 12:54:35 +03:00
alesapin
e4a028c4d4 Missed ya.make 2021-03-29 12:25:40 +03:00
alesapin
4ce81a91e5 Remove unused file 2021-03-29 12:16:58 +03:00
vdimir
24aa25d7dc
Reuse some functions for IPAddressContainedIn 2021-03-29 12:04:05 +03:00
alesapin
be132a32a2 More renames 2021-03-29 11:24:56 +03:00
Neng Liu
0d78427fbf fix query failed and add stateless test 2021-03-29 16:12:02 +08:00
alesapin
e936bb1dae Rename files 2021-03-29 10:58:42 +03:00
pingyu
69ac23e870 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into datasketches-uniq 2021-03-29 14:48:14 +08:00
Vladimir
0e9926e6c6
Update src/Storages/transformQueryForExternalDatabase.cpp 
Co-authored-by: Alexander Kuzmenkov <36882414+akuzm@users.noreply.github.com>
 2021-03-29 09:34:43 +03:00
Alexey Milovidov
f582b7169a Remove unit test (less convenient) after adding functional test 2021-03-29 05:44:20 +03:00
alexey-milovidov
f90a328568
Merge pull request #22109 from azat/nested-epoll-wait 
Disable async_socket_for_remote/use_hedged_requests for buggy linux kernels
 2021-03-29 05:29:10 +03:00
alexey-milovidov
c762fa2f75
Merge pull request #22129 from vdimir/issue-19303 
Shrink totals block to 1 row for JOIN with TOTALS and arrayJoin
 2021-03-29 05:26:17 +03:00
alexey-milovidov
c81d807dbc
Update JoiningTransform.cpp 2021-03-29 05:25:58 +03:00
alexey-milovidov
3bc170e5ec
Merge pull request #22122 from fastio/fix_thread_pool_name_exception 
The thread pool name should be not longer than 15 chars
 2021-03-29 05:24:55 +03:00
alexey-milovidov
7ab2890c4d
Merge pull request #22206 from ClickHouse/mmap-cache 
Add cache for mmap IO
 2021-03-29 05:17:55 +03:00
alexey-milovidov
7225293540
Merge pull request #22225 from kitaisreal/compressed-cache-buffer-fix-cache-usage 
CachedCompressedReadBuffer fix cache usage
 2021-03-29 05:15:25 +03:00
Alexey Milovidov
169369e90f Remove harmful default parameters 2021-03-29 04:08:28 +03:00
Alexey Milovidov
003bd1a3c1 Whitespace 2021-03-29 04:08:21 +03:00
Alexey Milovidov
b336de9ebd Remove harmful default arguments 2021-03-29 04:07:42 +03:00
Alexey Milovidov
39bb7c39c0 Autodetect compression #22234 2021-03-29 04:04:52 +03:00
Alexey Milovidov
922265d28d Fix MSan report; add a test 2021-03-29 04:03:11 +03:00
alexey-milovidov
c08289517a
Merge pull request #21766 from amosbird/indexfix 
Fix scalar subquery index analysis
 2021-03-29 02:03:27 +03:00
Alexey Milovidov
a0a3380d91 Remove useless headers 2021-03-28 22:46:45 +03:00
Maksim Kita
459d00f999 Fixed tests 2021-03-28 22:42:34 +03:00
Alexey Milovidov
2a8ac01cdb Rename as suggested by Kita 2021-03-28 22:24:28 +03:00
Alexey Milovidov
15b41fd110 Review fix 2021-03-28 22:15:13 +03:00
Maksim Kita
608d37deed CachedCompressedReadBuffer fix cache usage 2021-03-28 21:32:38 +03:00
Slach
9761db7efb Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix_issue_22028 2021-03-28 18:41:22 +01:00
pingyu
1ac42e003c wip #14893 2021-03-29 00:46:50 +08:00
kssenii
1bd1a705ce Fix clang tidy 2021-03-28 12:45:49 +00:00
kssenii
3cb5225bb8 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into replicas-shards-for-mysql-and-postgres 2021-03-28 12:40:13 +00:00
kssenii
0a66f11f69 Fix style, fix build 2021-03-28 10:27:37 +00:00
pingyu
48b745206c wip #14893 2021-03-28 11:49:49 +08:00
Alexey Milovidov
6f9f7d118d Fixes 2021-03-28 04:27:26 +03:00
Alexey Milovidov
50f712e198 Integrate mmap cache to the infrastructure 2021-03-28 04:10:30 +03:00
Alexey Milovidov
bdb69b8f08 Slightly better 2021-03-28 02:11:46 +03:00
Alexey Milovidov
cbf5913109 Review fixes 2021-03-28 01:57:59 +03:00
Alexey Milovidov
b3750b670f Merge remote-tracking branch 'origin/master' into mmap-cache 2021-03-28 01:57:11 +03:00
alexey-milovidov
d07a40c675
Merge pull request #22145 from ClickHouse/speedup-none 
Speedup codec NONE
 2021-03-28 01:56:00 +03:00
kssenii
c17748a0ba Add proper settings 2021-03-27 21:57:35 +00:00
kssenii
ef537b802f Better comments 2021-03-27 21:10:44 +00:00
kssenii
22b515fbc9 Add namespace, simplify names 2021-03-27 20:14:02 +00:00
kssenii
f40c582e7a Replicas/shards for postgres storage 2021-03-27 20:11:48 +00:00
kssenii
f141f027f4 Make common class for external storages 2021-03-27 17:12:47 +00:00
kssenii
95e8a8b9f0 Support shards 2021-03-27 14:40:07 +00:00
kssenii
ae868208c2 Use pool with failover in mysql storage 2021-03-27 14:39:45 +00:00
Maksim Kita
4f298d54b9 Added perf tests 2021-03-27 17:00:00 +03:00
Maksim Kita
ca6146b040 Fixed build 2021-03-27 13:42:46 +03:00
alesapin
ced6d8e6bd
Merge pull request #21677 from ClickHouse/jepsen_for_nukeeper 
Jepsen for nukeeper
 2021-03-27 10:18:42 +03:00
alesapin
3b119355d2
Merge pull request #22118 from ClickHouse/try_to_fix992 
Trying to fix my favorite test
 2021-03-27 10:17:14 +03:00
pingyu
8337792722 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into datasketches-cmake 2021-03-27 11:31:26 +08:00
Alexey Milovidov
c7d2671f32 Merge branch 'speedup-none' into mmap-cache 2021-03-27 02:42:44 +03:00
Alexey Milovidov
0e3571478d Code review changes 2021-03-27 02:42:22 +03:00
Alexey Milovidov
bcdf3dce36 Add cache for mmapped files 2021-03-27 02:22:51 +03:00
Alexey Milovidov
1d9e23f925 Fix error 2021-03-27 01:28:57 +03:00
Maksim Kita
0faab7ae35 Fixed PODArray insertFromItself 2021-03-27 00:49:16 +03:00
Alexey Milovidov
7aac5e1849 Preparation 2021-03-26 23:51:46 +03:00
Alexey Milovidov
ff891c5002 Preparation 2021-03-26 23:46:04 +03:00
alexey-milovidov
607d36dd9d
Merge pull request #22147 from azat/writers-fixes 
Use finalize() over next() for nested writers
 2021-03-26 22:05:18 +03:00
Pavel Kruglov
90afc9ce2f Fix build 2021-03-26 21:25:30 +03:00
Azat Khuzhin
82c79fe4ce Fix query cancellation with use_hedged_requests=0 and async_socket_for_remote=1 
In #21643 async_socket_for_remote=1 was fixed to avoid leaving the
connection in the unsynchronised state.

But one should not try to wait for the current packet in case of timeout
because this will exceed the timeout.

Anyway if the timeout is exceeded, then the connection will be shutdown
(disconnected), so it will not left in an unsynchronised state.
 2021-03-26 21:24:42 +03:00
Alexander Kuzmenkov
3dea1c8c01
Merge pull request #21946 from azat/tld-fixes 
Fix cutToFirstSignificantSubdomainCustom()/firstSignificantSubdomainCustom() for 3+level domains
 2021-03-26 21:19:09 +03:00
Maksim Kita
3f273ef983 Updated hash dictionary nullable attribute implementation 2021-03-26 21:01:56 +03:00
Alexander Kuzmenkov
c3cc65f826 use macro 2021-03-26 20:30:36 +03:00
Alexander Kuzmenkov
cc93055e9e ignore UB as in negate() 2021-03-26 20:29:41 +03:00
kssenii
97e6040cf1 Encode passed data 2021-03-26 16:11:02 +00:00
Maksim Kita
5fd575977a Fixed typos 2021-03-26 18:42:32 +03:00
Maksim Kita
2cac8d13cc Updated tests and documentation 2021-03-26 18:42:32 +03:00
Maksim Kita
13417b5b40 Added documentation 2021-03-26 18:42:32 +03:00
Maksim Kita
eb0039ed03 Fixed tests 2021-03-26 18:42:32 +03:00
Maksim Kita
21d28a37aa Fixed build 2021-03-26 18:42:32 +03:00
Maksim Kita
3b10043eb2 Fix style check 2021-03-26 18:42:32 +03:00
Maksim Kita
720e2e0501 Updated dictGetDescendants, dictGetChildren implementation 2021-03-26 18:42:32 +03:00
Maksim Kita
566541528d Update function naming 2021-03-26 18:42:32 +03:00
Maksim Kita
bbd180caf3 Added functions dictGetChildren, dictGetDescendants 2021-03-26 18:42:32 +03:00
Maksim Kita
9f2f0d1095 Refactored hierarchy dictionaries interface 2021-03-26 18:42:32 +03:00
Pavel Kruglov
2979feb23f Prevent busy waiting in hedged requests when async_socket_for_remote=0 2021-03-26 18:11:06 +03:00
Anton Popov
421d8eb180 fux build 2021-03-26 17:34:04 +03:00
alexey-milovidov
ac53d30e53
Merge pull request #22146 from azat/writers-uncaught-exceptions 
Fix uncaught exception in InterserverIOHTTPHandler
 2021-03-26 17:23:09 +03:00
Alexander Kuzmenkov
a455762933
Merge pull request #22117 from ucasFL/useless-code 
remove useless code
 2021-03-26 17:18:14 +03:00
alesapin
35d1443a9c Don't wait when table shutdown called 2021-03-26 15:54:08 +03:00
tavplubix
d9ec4090d2
Merge pull request #21936 from abyss7/html-form-fix 
Fix issues with HTMLForm::MultipartReadBuffer and PeekableReadBuffer
 2021-03-26 15:35:34 +03:00
alesapin
9bdeb436c2 Fix typo 2021-03-26 15:06:36 +03:00
alesapin
2db57f0f16 Followup fix 2021-03-26 14:18:31 +03:00
alesapin
331c5b6636 Fix startup one more time 2021-03-26 13:55:39 +03:00
alesapin
ba5c151037 Fix race condition on snapshots 2021-03-26 13:20:07 +03:00
changvvb
5e07551d17 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into support-apple-m1 2021-03-26 16:57:26 +08:00
tavplubix
ae62bee939
Merge pull request #21913 from ClickHouse/fix_context_ref 
Fix possibly dangling reference to Context
 2021-03-26 10:39:13 +03:00
tavplubix
fa930d49c4
Update gtest_peekable_read_buffer.cpp 2021-03-26 10:29:58 +03:00
PHO
26dc629366 Add a function isIPAddressContainedIn() 
This function takes an IP address and a CIDR network prefix, and determines if the address is contained in the network. It supports both IPv4 and IPv6 addresses, and expects arguments to be strings.

ClickHouse doesn't support union types. We cannot use the native IPv4 and IPv6 types for this reason.
 2021-03-26 12:11:35 +09:00
PHO
9ece398c35 Changed the return type of DB::getCIDRMaskIPv6() 
It now returns std::array instead of uint8_t *. Also added DB::getCIDRMaskIPv4().
 2021-03-26 12:11:34 +09:00
PHO
6606d8ac0b Correct comments about what parseIPv4() and parseIPv6() actually do 
They were wrong as to what endian their results were in.
 2021-03-26 12:11:34 +09:00
PHO
1868ca34b8 Fix build on GCC where std::isinf() cannot be called without the namespace prefix 2021-03-26 12:11:22 +09:00
alexey-milovidov
f1efa33571
Merge branch 'master' into client-fix-highlight-multiline-comment 2021-03-26 02:40:11 +03:00
alexey-milovidov
f4d014c022
Update connectionID.cpp 2021-03-26 02:38:49 +03:00
alexey-milovidov
0e42060523
Merge pull request #22114 from ucasFL/bar 
Fix bar with invalid float value
 2021-03-26 02:36:02 +03:00
Alexey Milovidov
e55f7e6333 Fix error 2021-03-26 02:21:59 +03:00
Alexey Milovidov
ad66c4a916 Fix error 2021-03-26 01:56:24 +03:00
Azat Khuzhin
b68517f69e Fix cutToFirstSignificantSubdomainCustom()/firstSignificantSubdomainCustom() for 3+level domains 
Custom TLD lists (added in #17748), may contain domain of the 3-d level,
however builtin TLD lists does not have such records, so it is not
affected.

Note that this will significantly increase hashtable lookups.

Fixes: #17748
 2021-03-26 00:00:16 +03:00
Azat Khuzhin
30cd1c6145 Fix typo in FirstSignificantSubdomainCustomLookup name 2021-03-26 00:00:16 +03:00
Azat Khuzhin
f1907acbcd Use finalize() over next() for nested writers 
Refs: https://github.com/ClickHouse/ClickHouse/pull/21325#discussion_r585348309
 2021-03-25 23:42:58 +03:00
Azat Khuzhin
50003e496a Use existing logger for logging from WriteBufferFromS3 dtor 2021-03-25 23:41:03 +03:00
Azat Khuzhin
e1de960025 Fix uncaught exception in InterserverIOHTTPHandler 
There was one more uncaught exception case [1]:

    2021.03.19 18:11:00.845632 [ 17469 ] {} <Debug> InterserverIOHTTPHandler: Done processing query
    ...
    2021.03.19 18:11:31.698961 [ 80145 ] {} <Fatal> BaseDaemon: ########################################
    2021.03.19 18:11:31.699903 [ 80145 ] {} <Fatal> BaseDaemon: (version 21.4.1.6293 (official build), build id: 859E400E1C65C4702FE491420741DD8B58190002) (from thread 17469) (no query) Received signal Aborted (6)
    2021.03.19 18:11:32.614075 [ 80145 ] {} <Fatal> BaseDaemon: 8. ./obj-x86_64-linux-gnu/../contrib/libcxxabi/src/cxa_handlers.cpp:89: std::terminate() @ 0x21e9b3a2 in /usr/bin/clickhouse
    2021.03.19 18:11:43.831215 [ 80145 ] {} <Fatal> BaseDaemon: 10. ./obj-x86_64-linux-gnu/../src/Server/HTTP/WriteBufferFromHTTPServerResponse.cpp:201: ? @ 0x1be77038 in /usr/bin/clickhouse
    2021.03.19 18:11:44.743193 [ 80145 ] {} <Fatal> BaseDaemon: 11. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:892: std::__1::allocator<DB::WriteBufferFromHTTPServerResponse>::destroy(DB::WriteBufferFromHTTPServerResponse*) @ 0x1bddd7c9 in /usr/bin/clickhouse
    2021.03.19 18:11:45.283905 [ 80145 ] {} <Fatal> BaseDaemon: 12. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/__memory/allocator_traits.h:541: void std::__1::allocator_traits<std::__1::allocator<DB::WriteBufferFromHTTPServerResponse> >::__destroy<DB::WriteBufferFromHTTPServerResponse>(std::__1::integral_constant<bool, true>, std::__1::allocator<DB::WriteBufferFromHTTPServerResponse>&, DB::WriteBufferFromHTTPServerResponse*) @ 0x1bddd79d in /usr/bin/clickhouse
    2021.03.19 18:11:45.805233 [ 80145 ] {} <Fatal> BaseDaemon: 13. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/__memory/allocator_traits.h:487: void std::__1::allocator_traits<std::__1::allocator<DB::WriteBufferFromHTTPServerResponse> >::destroy<DB::WriteBufferFromHTTPServerResponse>(std::__1::allocator<DB::WriteBufferFromHTTPServerResponse>&, DB::WriteBufferFromHTTPServerResponse*) @ 0x1bddd76d in /usr/bin/clickhouse
    2021.03.19 18:11:46.351371 [ 80145 ] {} <Fatal> BaseDaemon: 14. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2611: std::__1::__shared_ptr_emplace<DB::WriteBufferFromHTTPServerResponse, std::__1::allocator<DB::WriteBufferFromHTTPServerResponse> >::__on_zero_shared() @ 0x1bddd525 in /usr/bin/clickhouse
    2021.03.19 18:11:46.579263 [ 80145 ] {} <Fatal> BaseDaemon: 15. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2476: std::__1::__shared_count::__release_shared() @ 0x119490ed in /usr/bin/clickhouse
    2021.03.19 18:11:46.790912 [ 80145 ] {} <Fatal> BaseDaemon: 16. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2517: std::__1::__shared_weak_count::__release_shared() @ 0x1194908f in /usr/bin/clickhouse
    2021.03.19 18:11:47.277990 [ 80145 ] {} <Fatal> BaseDaemon: 17. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:3213: std::__1::shared_ptr<DB::WriteBufferFromHTTPServerResponse>::~shared_ptr() @ 0x1bdd75fc in /usr/bin/clickhouse
    2021.03.19 18:11:47.649213 [ 80145 ] {} <Fatal> BaseDaemon: 18. ./obj-x86_64-linux-gnu/../src/Server/InterserverIOHTTPHandler.h:34: DB::InterserverIOHTTPHandler::Output::~Output() @ 0x1bdf6bd5 in /usr/bin/clickhouse
    2021.03.19 18:11:47.921556 [ 80145 ] {} <Fatal> BaseDaemon: 19. ./obj-x86_64-linux-gnu/../src/Server/InterserverIOHTTPHandler.cpp:154: DB::InterserverIOHTTPHandler::handleRequest(DB::HTTPServerRequest&, DB::HTTPServerResponse&) @ 0x1bdf653f in /usr/bin/clickhouse

  [1]: https://clickhouse-test-reports.s3.yandex.net/0/78c56b891383288cf3a893139e796fc87476412e/stress_test_(debug).html

Since in case of no errors during processing we should call finalize, to
ensure that it will not be called from dtor.

Fixes: #22046
Fixes: #22067
 2021-03-25 23:41:03 +03:00
Azat Khuzhin
48fe30e5a2 Add missing logging for exception in InterserverIOHTTPHandler 2021-03-25 23:41:03 +03:00
Azat Khuzhin
8e445c5e55 Disable async_socket_for_remote/use_hedged_requests for buggy linux kernels 
async_socket_for_remote/use_hedged_requests uses nested epolls, which
may not be reliable in 5.5+ [1], but it has been fixed in shortly in
5.7+ [2] or
5.6.13+.

  [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=339ddb53d373
  [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0c54a6a44bf3
 2021-03-25 23:39:30 +03:00
Alexey Milovidov
a8ce138788 Speedup codec NONE 2021-03-25 23:08:47 +03:00
Alexander Kuzmenkov
33647ef3d5 fix build 2021-03-25 23:02:09 +03:00
Alexander Kuzmenkov
0675f9403c
Merge pull request #21895 from ClickHouse/aku/laglead 
float RANGE OFFSET and lag/lead_in_frame
 2021-03-25 23:00:22 +03:00
Alexander Kuzmenkov
7444eab536 Merge remote-tracking branch 'origin/aku/negate-stable' into HEAD 2021-03-25 21:40:02 +03:00
Alexander Kuzmenkov
9aa89161dc fix for decimals 2021-03-25 21:39:57 +03:00
Maksim Kita
bbe1960eea
Merge pull request #21573 from kitaisreal/updated-cache-dictionary-storage 
Added specialized CacheDictionaryStorage
 2021-03-25 21:29:01 +03:00
Nikolai Kochetov
e9f7213858 Filter push down for LEFT/INNER JOIN, CreatingSets, Union. 2021-03-25 21:11:54 +03:00
Alexey Milovidov
177a017c5c Minor modification #22115 2021-03-25 20:51:32 +03:00
Alexander Kuzmenkov
72b742258a
Update src/Parsers/ASTFunction.cpp 2021-03-25 19:20:36 +03:00
Alexander Kuzmenkov
4e96675a30
Update src/Parsers/ASTFunction.cpp 2021-03-25 19:18:57 +03:00
Alexander Kuzmenkov
8ea697b7df use camelCase 2021-03-25 18:49:45 +03:00
Alexander Kuzmenkov
48af3f5851 stable formatting for negate() 2021-03-25 18:38:43 +03:00
Peng Jian
fc1cd6f65e remove unnecessary code 2021-03-25 22:57:08 +08:00
vdimir
8f5c8f32df
Shrink totals block to 1 row for JOIN with TOTALS and arrayJoin 2021-03-25 17:32:36 +03:00
Kruglov Pavel
66b8431e71
Merge pull request #21429 from Avogar/secure-socket 
Fix receive and send timeouts and non-blocking read in secure socket
 2021-03-25 17:30:17 +03:00
Anton Popov
da2d0d2682 fix build 2021-03-25 17:18:29 +03:00
Peng Jian
2ede490152 The thread pool name should not longer than 15 chars 2021-03-25 21:57:47 +08:00
feng lv
55ba4ec15e Fix bar with invalid float value 
fix
 2021-03-25 13:28:07 +00:00
alexey-milovidov
f895bc895c
Merge pull request #22011 from ClickHouse/min_max_time_system_parts_datetime64 
Expose DateTime64 minmax part index in system.parts and system.parts_columns
 2021-03-25 16:02:33 +03:00
alexey-milovidov
52396acba1
Merge pull request #22064 from ClickHouse/fix-overflow-aes 
Fix missing check in decrypt for AEAD mode
 2021-03-25 16:01:44 +03:00
alexey-milovidov
cb6926629e
Merge pull request #22099 from ClickHouse/map-populate-series-ubsan 
Fix UBSan report in mapPopulateSeries.
 2021-03-25 16:00:21 +03:00
alexey-milovidov
37a4f3ab3a
Merge pull request #22063 from ClickHouse/tuple-null-in 
Allow to search tuple of NULLs in a set
 2021-03-25 15:59:41 +03:00
Anton Popov
6a15431be7 Merge remote-tracking branch 'upstream/master' into HEAD 2021-03-25 15:57:35 +03:00
Anton Popov
f58d470dd6
Merge pull request #21830 from foolchi/optimize_select_with_final 
optimize select final with prewhere primary key
 2021-03-25 15:32:13 +03:00
alesapin
4c28c25a75 Merge branch 'master' into jepsen_for_nukeeper 2021-03-25 14:34:00 +03:00
feng lv
b7622868fc remove useless code 2021-03-25 11:10:41 +00:00
Vitaly Baranov
f6f739eca5
Merge pull request #22027 from vitlibar/external-loader-small-simplification 
Small simplification in ExternalLoader.
 2021-03-25 13:43:31 +03:00
Vitaly Baranov
86a293d6c8
Merge pull request #22057 from vitlibar/update-simdjson 
Update simdjson
 2021-03-25 13:27:05 +03:00
Nikolai Kochetov
3efd11becc Extract converting from UnionStep. 2021-03-25 12:57:53 +03:00
Nikolai Kochetov
0e2f52518f Extract converting from UnionStep. 2021-03-25 12:57:14 +03:00
Nikolai Kochetov
0afede382b Use empty header for CreatingSets step. 2021-03-25 11:39:55 +03:00
kssenii
bc36baef26 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into library-bridge 2021-03-25 07:48:07 +00:00
Nikolai Kochetov
977ebe8b44
Merge pull request #22058 from azat/system.errors-trace 
Convert system.errors.stack_trace from String into Array(UInt64)
 2021-03-25 10:23:05 +03:00
hexiaoting
90548d9c85 ReImplement AggregateFunctionSumCount 2021-03-25 11:15:03 +08:00
alexey-milovidov
94dabbac60
Merge pull request #22001 from ClickHouse/timezone-of 
Add function `timezoneOf` and fix inconsistencies
 2021-03-24 23:15:22 +03:00
Alexey Milovidov
c325ed65e2 Fix UBSan report in mapPopulateSeries 2021-03-24 23:10:15 +03:00
alexey-milovidov
087be05dfd
Merge pull request #22062 from ClickHouse/datetime64-ubsan 
Fix UBSan report in TransformDateTime64
 2021-03-24 22:36:20 +03:00
Mike Kot
285af08949 Merge remote-tracking branch 'upstream/master' into feature/attach-partition-local 2021-03-24 22:34:20 +03:00
kssenii
6d41f7356b Better way to pass attributes 2021-03-24 19:32:31 +00:00
Mike Kot
9f25ee3719 Replaced removing checksums.txt with version 
with the explicit data loading and verification.

If the function fails, the exception will re-throw upper,
cancelling the fetch in the handling of the replicated log entry,
but this event will also wake the PartCheckThread, which will
issue a re-fetch.
 2021-03-24 22:30:16 +03:00
kssenii
d9326cc229 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into library-bridge 2021-03-24 18:28:55 +00:00
alexey-milovidov
ffa6585170
Merge pull request #21837 from Jokser/disk-cache-cleanup-directory-before-move 
Cleanup destination directory during DiskCacheWrapper::moveFile()
 2021-03-24 21:19:48 +03:00
Anton Popov
f967fa574c
Merge pull request #22036 from CurtizJ/merge_21760 
Add test for #21760
 2021-03-24 16:31:14 +03:00
Nikolai Kochetov
a325d75d75 Remove AddingDelayedSourceStep. 2021-03-24 16:27:04 +03:00
Nikolai Kochetov
12de01cb48 Remove AddingDelayedSourceStep. 2021-03-24 16:22:51 +03:00
vdimir
bc1b0aed85
Correctly handle table alias in PredicateRewriteVisitor 2021-03-24 15:48:29 +03:00
Alexander Kuzmenkov
02eee100a0 formatting fixes 2021-03-24 15:36:39 +03:00
alexey-milovidov
1fadf8bad1
Merge pull request #22078 from georgthegreat/patch-1 
Flatten libcpuid PEERDIRs
 2021-03-24 15:03:46 +03:00
Nikolai Kochetov
6ca8a66da2
Merge pull request #21550 from amosbird/shardpruningliteral 
Shard pruning via literals
 2021-03-24 13:59:34 +03:00
Slach
769162765c fix connectionID.cpp after fail https://clickhouse-test-reports.s3.yandex.net/22042/419e1555d66469aee90ffb991baad6b2b4f8b294/fast_test.html#fail1 2021-03-24 15:13:33 +05:00
Yuriy Chernyshov
e2760101c1
Update ya.make.in 2021-03-24 13:13:04 +03:00
Pavel Kovalenko
0c0ddefc75 Disk S3 possibility to migrate to restorable schema 2021-03-24 13:12:47 +03:00
Yuriy Chernyshov
c89861a2ac
Better 2021-03-24 13:11:52 +03:00
Pavel Kovalenko
9f9419cf14 Disk S3 possibility to migrate to restorable schema 2021-03-24 13:08:37 +03:00
Pavel Kovalenko
7e462a77a7 Disk S3 possibility to migrate to restorable schema 2021-03-24 13:07:01 +03:00
kssenii
7da36be9b6 Better 2021-03-24 09:23:29 +00:00
Pavel Kovalenko
e378c0bf8a Disk S3 possibility to migrate to restorable schema 2021-03-24 12:20:33 +03:00
kssenii
c008f054ae Pass sample_block only once 2021-03-24 08:41:42 +00:00
fuqi
487d6bdcd9 add test case 
fix order key check
 2021-03-24 16:36:45 +08:00
Slach
7c580d8a01 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix_issue_22028 2021-03-24 09:35:05 +01:00
alesapin
9d8b21a04d Fix ephemeral node removal 2021-03-24 11:12:37 +03:00
Kruglov Pavel
a07dfe328f
Merge pull request #21836 from Jokser/write-buffer-s3-better-error-handling 
Better error handling and logging in WriteBufferFromS3
 2021-03-24 10:59:27 +03:00
kssenii
1ef3c1f780 Use binary format for params 2021-03-24 07:55:21 +00:00
Nikolai Kochetov
f164c2462f
Update Exception.cpp 
Fix build
 2021-03-24 09:41:57 +03:00
Azat Khuzhin
7c07b43597 Convert system.errors.stack_trace from String into Array(UInt64) 
This should decrease overhead for the errors collecting.
 2021-03-24 06:52:48 +03:00
Alexey Milovidov
37948ac80a Fix style 2021-03-24 04:12:52 +03:00
Alexey Milovidov
a6c1b30b3c Merge branch 'master' into timezone-of 2021-03-24 04:12:05 +03:00
Alexey Milovidov
5dc9223288 Fix Arcadia 2021-03-24 04:11:57 +03:00
Alexey Milovidov
3e74f56261 Fix missing check in decrypt for AEAD mode 2021-03-24 03:34:30 +03:00
Alexey Milovidov
eae268f2f0 Allow to search tuple of NULLs in a set 2021-03-24 03:15:48 +03:00
Alexey Milovidov
47b00ad11b Fix UBSan report in TransformDateTime64 2021-03-24 02:49:17 +03:00
Alexey Milovidov
4de5afed4e Whitespaces 2021-03-24 02:07:13 +03:00
alexey-milovidov
612d4fb073
Update IMergeTreeDataPart.cpp 2021-03-24 02:03:14 +03:00
Alexander Kuzmenkov
e0d1f6d80f fixes 2021-03-24 01:52:16 +03:00
Alexander Kuzmenkov
f2ef536dfb fix formatting 2021-03-24 01:40:27 +03:00
alexey-milovidov
18c9167ba1
Merge pull request #22009 from ClickHouse/intdiv-ubsan-3 
Fix UBSan report in intDiv #21769
 2021-03-23 23:53:24 +03:00
alexey-milovidov
150a2df9df
Merge pull request #22026 from kitaisreal/cast-to-enum-nullable-fix 
Cast to enum nullable fix
 2021-03-23 23:51:19 +03:00
Azat Khuzhin
912144307d Fix type of the ErrorCodes 2021-03-23 23:40:46 +03:00
Vitaly Baranov
1f4df07e08 Update used version of simdjson to 0.9.1 2021-03-23 20:58:30 +03:00
alexey-milovidov
c19045da25
Merge pull request #22010 from ClickHouse/fix-doc-metric 
Fix documentation for CurrentMetrics
 2021-03-23 20:54:18 +03:00
alexey-milovidov
ed0ad9ec17
Update version.cpp 2021-03-23 20:30:50 +03:00
Slach
c977348076 fix build after fails https://clickhouse-test-reports.s3.yandex.net/22042/0bc0af117eb6faa554d77323f1026dc971abb470/fast_test/runlog.out.log 2021-03-23 21:06:09 +05:00
kssenii
b8d9b97903 Better 2021-03-23 15:43:14 +00:00
Slach
0bc0af117e fix build after fails https://clickhouse-test-reports.s3.yandex.net/22042/6ce139dd800fb658ab915adaba6bbd0ca075ce7a/fast_test.html#fail1 2021-03-23 20:20:44 +05:00
tavplubix
48b89a0ace
Merge pull request #21998 from Avogar/hedged-test 
Update tests for hedged requests
 2021-03-23 18:18:49 +03:00
Maksim Kita
bde02c72f3 Fixed typos 2021-03-23 18:14:22 +03:00
Alexander Kuzmenkov
c9facd631c Merge remote-tracking branch 'origin/master' into HEAD 2021-03-23 17:40:13 +03:00
Alexander Kuzmenkov
0c70fe1a6d fix field get 2021-03-23 17:39:59 +03:00
Slach
6ce139dd80 fix https://github.com/ClickHouse/ClickHouse/issues/22028 2021-03-23 19:31:05 +05:00
Anton Popov
8a56d04714 Merge branch 'merge_tree_part_block_number' of git://github.com/ahrefs/ClickHouse into merge_21760 2021-03-23 16:47:14 +03:00
Alexander Kuzmenkov
97d5be20bb
Merge pull request #22003 from ClickHouse/aku/field-reinterpret 
prevent accidental reinterpret_cast in Field::get<>
 2021-03-23 15:57:26 +03:00
Anton Popov
2e1f293bd5
Merge pull request #21699 from CurtizJ/fix-map-field-conversion 
Fix conversions for fields in function 'arrayElement' for type Map
 2021-03-23 15:30:44 +03:00
Vitaly Baranov
46f4c60839 Small simplification in ExternalLoader. 2021-03-23 15:15:44 +03:00
Maksim Kita
890bd6f1e9 Fixed code review issues 2021-03-23 15:14:37 +03:00
vdimir
ea6b8486e9
Try to fix issue #20497 2021-03-23 15:07:51 +03:00
alesapin
0c525b4ec4 Add an ability to run from .deb and .tgz package 2021-03-23 15:07:21 +03:00
Vitaly Baranov
090e558da4
Merge pull request #21844 from Avogar/catboost-deadlock 
Fix deadlock in first catboost model execution
 2021-03-23 15:01:04 +03:00
Ivan Lezhankin
be76defcfa Remove check for absent checkpoint on rollback 2021-03-23 14:59:36 +03:00
Maksim Kita
75f5679bf0 Cast to enum nullable fix 2021-03-23 14:58:00 +03:00
Alexander Tokmakov
c938f4f2fe fix 2021-03-23 14:29:29 +03:00
vdimir
38a6dba3e3
Add option strict_increase to windowFunnel 2021-03-23 14:23:48 +03:00
alesapin
36898bdc4a
Merge pull request #21142 from Jokser/unfreeze-partitions 
Add ALTER TABLE UNFREEZE command.
 2021-03-23 14:05:38 +03:00
Pavel Kovalenko
a92cf30b67 Code review fixes. 2021-03-23 13:33:07 +03:00
Pavel Kovalenko
d55af1fa45 Merge branch 'write-buffer-s3-better-error-handling' of github.com:Jokser/ClickHouse into write-buffer-s3-better-error-handling 2021-03-23 13:02:57 +03:00
Pavel Kovalenko
393631a753 Merge remote-tracking branch 'origin/master' into write-buffer-s3-better-error-handling 
# Conflicts:
#	src/IO/WriteBufferFromS3.cpp
 2021-03-23 13:00:09 +03:00
Nikolai Kochetov
ed19864e5b
Update CollapsingSortedAlgorithm.cpp 
Add comment.
 2021-03-23 11:25:45 +03:00
Nikolai Kochetov
d7fc5e69f4
Update CollapsingSortedAlgorithm.h 
Added comment.
 2021-03-23 11:18:49 +03:00
Alexey Milovidov
8d0210b510 Expose DateTime64 minmax part index in system.parts and system.parts_columns #18244 2021-03-23 01:16:41 +03:00
Anton Popov
5de2b8512f fix destruction of aggregate states 2021-03-23 01:12:14 +03:00
Alexander Kuzmenkov
49f617d8ec return the type check 2021-03-23 01:07:04 +03:00
Alexey Milovidov
ce67afd9e3 Fix bad code #18244 2021-03-23 00:49:18 +03:00
Alexey Milovidov
d8088190f9 Fix documentation for CurrentMetrics 2021-03-23 00:44:25 +03:00
Alexey Milovidov
c94841bca5 Fix UBSan report in intDiv #21769 2021-03-23 00:38:25 +03:00
Pavel Kruglov
6278a7efac Fix build 2021-03-23 00:21:52 +03:00
Alexander Kuzmenkov
d40f781b9a Merge origin/master into tmp (using imerge) 2021-03-22 23:27:18 +03:00
Alexander Kuzmenkov
77a2f03d3b prevent accidental reinterpret_cast in Field::get<> 2021-03-22 23:23:44 +03:00
alexey-milovidov
231c7266ab
Merge pull request #21954 from ucasFL/s3-log 
Fix misleading log in WriteBufferFromS3
 2021-03-22 23:22:44 +03:00
alesapin
ef82333089 Merge branch 'master' into jepsen_for_nukeeper 2021-03-22 23:06:26 +03:00
Alexey Milovidov
84be58453b Add function timezoneOf and fix inconsistencies 2021-03-22 22:50:04 +03:00
Pavel Kruglov
dbc5018000 Update tests for hedged requests 2021-03-22 22:18:06 +03:00
Kruglov Pavel
a215bf7812
Restart CI 2021-03-22 22:12:42 +03:00
Alexander Kuzmenkov
b0284f20c3
Merge branch 'master' into aku/laglead 2021-03-22 21:16:27 +03:00
Ivan Lezhankin
6d4d669f96 Move checkpoint to sub-buffer only from internal memory 2021-03-22 20:20:42 +03:00
Alexander Kuzmenkov
2f5dbf57b6
Merge pull request #21839 from kssenii/add-postgres-connection-pool 
Add connection pool for postgres engine
 2021-03-22 19:49:51 +03:00
tavplubix
5dfd0045a6
Merge branch 'master' into distributed_ddl_improvements 2021-03-22 18:13:19 +03:00
Mike Kot
da67e06aa0 Added another test case to handle missing part data 2021-03-22 17:52:21 +03:00
Nikolai Kochetov
35ff8925df Fix crash. 2021-03-22 17:43:45 +03:00
kssenii
472ce89b75 Small fixes 2021-03-22 14:39:17 +00:00
Mike Kot
c55a73b752 Added the solution to handle the corruption case 
When the part data (e.g. data.bin) is corrupted, but the checksums.txt
is present -- explicitly deleting the checksums.txt.

Removed the extra logging, changes some exceptions message.
 2021-03-22 17:23:43 +03:00
Mike Kot
5789507e8b Investigating, why the checksums may match when they shouldn't. 2021-03-22 17:23:43 +03:00
Alexander Kuzmenkov
ac5fdda999
Merge pull request #21915 from ClickHouse/aku/window-mt-order 
disable optimize_read_in_order for window functions
 2021-03-22 17:21:00 +03:00
Alexander Tokmakov
fc3e11a068 fix 2021-03-22 17:09:38 +03:00
alesapin
4145033d00 Merge branch 'master' into try-fix-excessive-rows-for-collapsing-merge 2021-03-22 16:47:32 +03:00
kssenii
8a650c4408 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into library-bridge 2021-03-22 13:38:25 +00:00
Nikolai Kochetov
22444045f0 CollapsingSortedAlgorithm should not return more then index_granularity rows. 2021-03-22 16:18:14 +03:00
Maksim Kita
8be263062d
Merge pull request #21910 from kitaisreal/table-function-dictionary 
Added table function dictionary
 2021-03-22 16:08:56 +03:00
Maksim Kita
56840aba5a Fixed tests 2021-03-22 16:02:32 +03:00
Nikita Mikhaylov
330e74b665
Merge pull request #21890 from kitaisreal/polygon-dictionary-added-nullable-support 
PolygonDictionary added nullable support
 2021-03-22 14:49:28 +03:00
Maksim Kita
af25805a70
Merge pull request #21948 from kitaisreal/hashed-dictionary-clickhouse-source-preallocate-regression-fix 
HashedDictionary clickhouse source preallocate regression fix
 2021-03-22 14:11:19 +03:00
alesapin
043b3cc7b5 Fix startup when leadership changed 2021-03-22 13:45:22 +03:00
Kruglov Pavel
6ce7acb5a9
Merge pull request #21941 from azat/hedged-requests-fixes 
Prevent hedged connections overlaps
 2021-03-22 12:52:51 +03:00
tavplubix
0e5362a02c
Merge pull request #21903 from ClickHouse/tavplubix-patch-3 
Show path to data directory of EmbeddedRocksDB
 2021-03-22 12:46:53 +03:00
Nikolai Kochetov
730785f4c2
Merge pull request #21459 from ClickHouse/refactor-actions-dag 
Refactor actions dag
 2021-03-22 11:58:16 +03:00
alesapin
27b90007aa Merge branch 'master' into jepsen_for_nukeeper 2021-03-22 11:20:00 +03:00
feng lv
d40ffa96e2 Fix misleading log in WriteBufferFromS3 2021-03-22 05:49:41 +00:00
changvvb
b947fcac75 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into support-apple-m1 2021-03-22 10:42:35 +08:00
Maksim Kita
c5f918f198 CacheDictionaryStorage insert into default value fix 2021-03-21 19:26:06 +03:00
Maksim Kita
257e0455dd Fixed tests 2021-03-21 18:10:12 +03:00
Maksim Kita
249d4a1843 Fixed tests 2021-03-21 18:10:12 +03:00
Maksim Kita
df9223e13b PolygonDictionary added nullable support 2021-03-21 18:09:47 +03:00
Maksim Kita
fff110aa38 HashedDictionary clickhouse source preallocate regression fix 2021-03-21 17:52:33 +03:00
Azat Khuzhin
17eaddc3ab Prevent hedged connections overlaps 
Some replicas may be in the establishing state, this means that hedged
connection is waiting for TablesStatusResponse, and if the connection
will not be canceled, then next user of the connection will get
TablesStatusResponse, while this is not the expected package, and you
will see:

    DB::Exception: Received from localhost:9000. DB::Exception: Received from ch-1:9000. DB::Exception: Unknown packet 9 from server ch-2:9000: While executing Remote. Stack trace:

Fix this by disconnecting connection to such replicas, note that this
should be fine in general, since they are "slow" anyway (you may wish
configure hedged requests settings to increase timeouts and similar).
 2021-03-20 19:05:29 +03:00
Maksim Kita
849a980644 Updated ExternalDictionariesLoader interface with context parameter 2021-03-20 18:02:09 +03:00
pingyu
83b7ab1fb5 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into datasketches-cmake 2021-03-20 21:15:07 +08:00
kssenii
698b1b043c Fix typos check 2021-03-19 21:54:59 +00:00
kssenii
3b32c8fe9a Block on empty connection pool 2021-03-19 21:00:45 +00:00
Ivan Lezhankin
957c053f7e Fix segfault 2021-03-19 23:29:01 +03:00
Maksim Kita
95c87d4ded
Merge pull request #21884 from kitaisreal/system-dictionaries-updated 
Improve system.dictionaries table
 2021-03-19 22:49:49 +03:00
kssenii
e066feb81c Slightly better 2021-03-19 18:50:41 +00:00
Alexander Kuzmenkov
3166f0cbfc cleanup 2021-03-19 20:18:17 +03:00
kssenii
50743b19c4 Add one more test 2021-03-19 16:12:33 +00:00
kssenii
f374a71165 Fix 2021-03-19 16:07:53 +00:00
Alexander Kuzmenkov
590259a7a5 disable optimize_read_in_order for window functions 2021-03-19 17:29:09 +03:00
Vladimir
c8b5be636f
Merge pull request #21438 from arenadata/ADQM-170 2021-03-19 17:06:55 +03:00
Alexander Tokmakov
1845df25f3 fix possibly dangling reference to Context 2021-03-19 17:02:48 +03:00
Maksim Kita
c703ea137b
Merge pull request #21891 from kitaisreal/lru-cache-fix-exception-unsafe-element-insertion 
LRUCache fix exception unsafe element insertion
 2021-03-19 16:37:26 +03:00
Alexander Kuzmenkov
78c56b8913
Merge pull request #21886 from Avogar/hedged 
Add profile event in hedged requests and change timeout from sec to ms.
 2021-03-19 15:50:33 +03:00
Alexander Kuzmenkov
07c967b5c7
Merge pull request #21896 from ClickHouse/aku/tuple-element 
fix fuzzer failure in tupleElement formatting
 2021-03-19 15:49:45 +03:00
Maksim Kita
32831e37ba Added table function dictionary 2021-03-19 15:47:27 +03:00
Alexander Kuzmenkov
46e4134deb fix fuzzer failure in tupleElement formatting 2021-03-19 15:47:06 +03:00
Kruglov Pavel
0cb88fb20e
Restart tests 2021-03-19 15:00:21 +03:00
Maksim Kita
a53c90e509 Upated system.dictionaries table 2021-03-19 12:43:57 +03:00
Nikolai Kochetov
bc63d4244b
Merge pull request #21856 from ClickHouse/aggregator-no-more-keys-batch 
Batch aggregation for overflow rows.
 2021-03-19 11:52:55 +03:00
Maksim Kita
f340e71913
Merge pull request #21859 from kitaisreal/ddl-dictionary-current-database-name 
DDL dictionary use current database name
 2021-03-19 11:39:51 +03:00
kssenii
a0f717619c Remove initial filling 2021-03-19 08:33:04 +00:00
kssenii
9057aad798 Better version 2021-03-19 08:11:36 +00:00
alesapin
81c408cb7f Return meta and storage from snapshot 2021-03-19 11:08:43 +03:00
tavplubix
fc0b87c5c4
Update StorageEmbeddedRocksDB.h 2021-03-19 10:24:27 +03:00
changvvb
b4e92f6b12 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into support-apple-m1 2021-03-19 13:52:09 +08:00
Alexander Kuzmenkov
4bf2e94fa4 clang is too smart 2021-03-19 03:02:35 +03:00
Alexander Kuzmenkov
1beba597ca Merge remote-tracking branch 'origin/master' into HEAD 2021-03-19 02:11:08 +03:00
Alexander Kuzmenkov
6aa9039f7d float frames and lag/lead_in_frame 2021-03-19 02:05:43 +03:00
Kruglov Pavel
055242fe95
Style 2021-03-19 01:38:15 +03:00
Maksim Kita
31b7734407 LRUCache fix exception unsafe element insertion 2021-03-19 00:26:02 +03:00
alesapin
2654147113 Fix on fix 2021-03-19 00:14:43 +03:00
Anton Popov
6f7c8894e9 fix bugs in aggregation by primary key 2021-03-18 23:57:42 +03:00
alesapin
0137a6baac Add test founding bug 2021-03-18 23:55:11 +03:00
kssenii
f1ef87d966 Fix 2021-03-18 20:04:54 +00:00
Alexander Tokmakov
ce31d4608b fix tests 2021-03-18 22:13:21 +03:00
Pavel Kruglov
d380454044 Change read_data_timeout from sec to ms, add profile event for hedged requests and better process receiving packets 2021-03-18 20:16:17 +03:00
Alexander Kuzmenkov
c821c0c27a
Merge pull request #21761 from ClickHouse/aku/chunk-no-columns 
fix incorrect number of rows for Chunks with no columns in PartialSor…
 2021-03-18 17:58:09 +03:00
Alexander Kuzmenkov
f85b089292
Merge pull request #21466 from ClickHouse/aku/frame-formatting 
add query formatting idempotence check to fuzzer
 2021-03-18 17:57:11 +03:00
Maksim Kita
a65bfaeab3 Fixed tests 2021-03-18 17:03:22 +03:00
Nikolai Kochetov
07c5a7766c Fxi test. 2021-03-18 16:23:09 +03:00
Alexander Tokmakov
343b8c906d Merge branch 'master' into test_multiple_nodes 2021-03-18 16:01:04 +03:00
Alexander Tokmakov
fdae70df6c fix tests 2021-03-18 15:50:03 +03:00
Anton Popov
33aefa832b
Merge pull request #21818 from amosbird/datarace2 
Fix arena data race in two level merge
 2021-03-18 15:05:25 +03:00
Maksim Kita
c01171c626 Fixed tests 2021-03-18 14:58:43 +03:00
Nikolai Kochetov
f4cbecec27 Remove comment. 2021-03-18 14:37:45 +03:00
Nikolai Kochetov
c3c393a7aa Merge branch 'master' into refactor-actions-dag 2021-03-18 14:33:07 +03:00
Maksim Kita
0f95bcac0b DDL dictionary use current database name 2021-03-18 14:30:12 +03:00
Maksim Kita
18ed9c5c67 SSDCacheDictionary remove max_stored_keys option 2021-03-18 12:55:17 +03:00
Nikolai Kochetov
66d5968cbc Batch aggregation for overflow rows. 2021-03-18 12:31:14 +03:00
Nikolai Kochetov
c4dfd97709 Fix ActionsDAG::Index::insert 2021-03-18 10:59:48 +03:00
Pavel Kovalenko
7c0a1b9451 Cleanup destination directory during DiskCacheWrapper::moveFile() 2021-03-18 10:23:19 +03:00
kssenii
7847b78af9 Fix style, build 2021-03-17 20:49:56 +00:00
Maksim Kita
d5a1b50fd2 Updated naming 2021-03-17 22:06:46 +03:00
Maksim Kita
f140204279 Improved performance of SSDCache dictionary 2021-03-17 22:01:45 +03:00
Pavel Kruglov
bf888b7e5f Fix deadlock in first catboost model execution 2021-03-17 21:57:40 +03:00
Nikolai Kochetov
45fead9062 Fix typos 2021-03-17 21:42:42 +03:00
Nikolai Kochetov
9fdb0e667f Add comment. 2021-03-17 21:40:26 +03:00
Maksim Kita
bc22f4f6eb Updated implementation 2021-03-17 20:14:36 +03:00
Nikolai Kochetov
2c1539f641 Fix added input. 2021-03-17 20:08:30 +03:00
fuqi
cfa92f0045 fix code style 2021-03-18 00:25:43 +08:00
Nikolai Kochetov
3eba817a68 Add comments. 2021-03-17 19:08:46 +03:00
fuqi
b8edc12812 fix code style 2021-03-17 23:56:55 +08:00
Mike Kot
e309dd275a Trying to investigate the errors after attaching the part. 
+ A new entry is added to the part_log.
 2021-03-17 18:49:04 +03:00
Nikolai Kochetov
738cb1af62 Fix filter push down columns order. 2021-03-17 18:33:18 +03:00
Alexander Kuzmenkov
1cd9f28bd4 another way 2021-03-17 18:31:30 +03:00
kssenii
3903d59d30 Better 2021-03-17 14:34:04 +00:00
Pavel Kovalenko
e6711e936e Cleanup destination directory during DiskCacheWrapper::moveFile() 2021-03-17 17:33:13 +03:00
Alexander Tokmakov
91068b782b fix 2021-03-17 17:29:24 +03:00
Pavel Kovalenko
71b36a7029 Better error handling and logging in WriteBufferFromS3 2021-03-17 17:20:55 +03:00
fuqi
e116e8d5e8 fix bug 2021-03-17 22:19:10 +08:00
kssenii
ae64a24844 Add connection pool 2021-03-17 13:55:47 +00:00
Mike Kot
831b90f272 Replaced the iteration algorithm in part finder 
Now, instead of iterating through the directories, we iterate though
directories of on of the table disks (which doesn't give us a
substantial boost but is a bit neater to read).

- Updated the system.replication_queue command types.
- Fixed the part ptr being empty (added the checksum loading and
initialization).
- Removed extra logging.
 2021-03-17 16:55:26 +03:00
Mike Kot
2ccdb7ef5c Multiple small code and test updates 
- Updated the docs to make everything clear.
- Multiple small logger fixes.
- Changed the attach_part command -- now it's after check for the
covering parts -- motivation is to do less work with the checksums
fetching.
- Better logging in the integration test.
 2021-03-17 16:52:35 +03:00
kssenii
34dea63248 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into library-bridge 2021-03-17 13:32:43 +00:00
Nikita Mikhaylov
2303f1788c
Merge pull request #21807 from 3ldar-nasyrov/master 
DDLWorker.cpp: fixed exceeded amount of tries typo
 2021-03-17 16:04:59 +03:00
Nikita Mikhaylov
f51b41b7a4
Merge pull request #21710 from kssenii/replica-priorities 
Support replicas priority for postgres dictionary source
 2021-03-17 16:02:00 +03:00
Kseniia Sumarokova
f8fc4281f2
Update PostgreSQLReplicaConnection.h 2021-03-17 15:56:47 +03:00
fuqi
9ab713c2e1 optimize select final with prewhere primary key 2021-03-17 18:57:58 +08:00
fuqi
5e20ea2c33 optimize select final with prewhere primary key 2021-03-17 18:49:24 +08:00
Pavel Kovalenko
5627ae9067 Make MergeTreeData::getPartitionMatcher const 2021-03-17 12:12:55 +03:00
Nikolai Kochetov
3a3f800f6e
Merge pull request #21579 from azat/dist-query-zero-shards-fix 
Fix optimize_skip_unused_shards for zero shards case
 2021-03-17 11:54:08 +03:00
Nikolai Kochetov
4f1f344d4d
Merge pull request #21529 from azat/system.errors-improvements 
Add last_error_time/last_error_message/last_error_stacktrace/remote columns for system.errors
 2021-03-17 11:51:29 +03:00
kssenii
9662a492c9 Proper bridge start 2021-03-17 08:21:04 +00:00
alexey-milovidov
d02726bcac
Merge pull request #9404 from Enmk/DateTime64_extended_range 
Date time64 extended range
 2021-03-17 11:06:03 +03:00
Amos Bird
0640bb4cba
Fix arena data race in two level merge 2021-03-17 14:33:57 +08:00
tavplubix
a093980767
Merge pull request #21711 from kssenii/non-default-schema 
Support non-default table schema for postgres storage/table-function
 2021-03-17 02:10:32 +03:00
Alexey Milovidov
9ca0566132 Minor modification 2021-03-17 02:08:33 +03:00
tavplubix
7ae5e51ee9
Update InterpreterAlterQuery.cpp 2021-03-17 01:50:37 +03:00
Alexander Tokmakov
69cbb99f2c fix 2021-03-17 01:01:48 +03:00