Commit Graph

12458 Commits

Author SHA1 Message Date
Alexey Zatelepin
01c39dcf1c fix CREATE TABLE bugs and idiosyncrasies: [#CLICKHOUSE-3000]
* fix segfault on ATTACH MATERIALIZED VIEW
* allow only TEMPORARY TABLEs (not databases or views)
* forbid choosing ENGINE for TEMPORARY tables
* fix segfault on CREATE TABLE t1 AS t2 where t2 is a View
2017-10-26 07:53:52 +03:00
Alexey Milovidov
2cc3fdae9b Useless modifications for cppcheck [#CLICKHOUSE-2]. 2017-10-26 04:47:03 +03:00
Marek Vavruša
ee22253857 tests: added tests for sumWithOverflow(x) preserving input type 2017-10-25 22:21:59 +03:00
Marek Vavruša
c0458999f9 SummingSortedBlockInputStream: fix summing of multiple blocks
Previously the destination columns were only computed for the first
block, so that subsequently written blocks failed to write
aggregation results to corrent columns.
2017-10-25 22:21:59 +03:00
Marek Vavruša
e936c4d066 AggregateFunctionSum: implemented sumWithOverflow(x)
By default sum(x) promotes the result type to
largest possible integral type to avoid
arithmetic overflow when summing values from
smaller data types.

This is generally desirable behaviour, but it doesn’t
work with summing merge tree, as the result is
expected to be of same type as the input.
2017-10-25 22:21:59 +03:00
Marek Vavruša
5c87a91aaf SummingSortedBlockInputStream: fix explicitly configured columns to sum
This fixes a variant of SummingMergeTree() in which
the columns to sum are explicitly configured.
Previously columns not in that list were ignored,
instead of writing last value.

This also fixes summation of invalid maps with
with only one key column and no value columns.

Modified test to work around compaction limitation
in which a zero-value column isn’t compacted
immediately if the inputs are non-zero but the
output is zero (+1 -1).
2017-10-25 22:21:59 +03:00
Marek Vavruša
fa098b469c AggregateFunctionSumMap: compact keys with zero value
This allows `sumMap(k, v)` to compact all keys
for which the values are all zero.
2017-10-25 22:21:59 +03:00
Alexey Milovidov
65982a1642 Fixed exception messages [#CLICKHOUSE-2]. 2017-10-25 22:17:37 +03:00
Alexey Milovidov
93e32e92fa Merge branch 'master' of github.com:yandex/ClickHouse 2017-10-25 21:53:44 +03:00
Alexey Milovidov
84d966f0d3 Fixed overflow in function toRelativeWeekNum with argument of first week of unix epoch; result values changed by 1 [#CLICKHOUSE-3384]. 2017-10-25 21:53:35 +03:00
proller
4ffbca2d8c Fix warnings (#1406)
* Log query id in executeQuery; Better type mismatch error; change format in report tool

* Better log query_id

* fix message

* Use c++11 thread_local instaed of gcc's __thread

* lock mutex before notifying waiting thread in sync insertion into distributed [#CLICKHOUSE-3379]

* Cmake: fix build without downloaded submodules (#1379)

* fix

* ZooKeeper: fixed stack smashing with tryGet()

The tryGet() operation creates a 1MB buffer on stack. This may or
may not work depending on the default stack size for threads,
whether the stack protector is enabled or not, recursion depth,
and the actual value size.

This is probably going to slow down some ZK operations, but I don't
see how else this could work reliably with the existing API.

* increased timeout for test_insertion_sync_fails_with_timeout

* Update CHANGELOG_RU.md

* Update ZooKeeper.cpp

* Fix warnings

* Fixes

* Dont strip debug info from  asan, tsan and other builds except releases

* Fix asan error causd by test 00144

* Fix empty log message (#CLICKHOUSE-3378)
2017-10-25 21:39:10 +03:00
alexey-milovidov
ca3c209f18 Merge pull request #1401 from proller/fix8
Update submodule contrib/poco
2017-10-25 05:05:33 +03:00
proller
00c995bffc Update submodule contrib/poco 2017-10-25 01:03:37 +03:00
proller
f5853a7af6 Fix revision of submodule contrib/librdkafka 2017-10-25 00:56:24 +03:00
alexey-milovidov
996b18c816 Merge pull request #1398 from yandex/revert-1381-fix2
Revert "Make gperftools (libtcmalloc) as submodule and update."
2017-10-24 22:18:28 +03:00
alexey-milovidov
8c327e9378 Revert "Make gperftools (libtcmalloc) as submodule and update. (#1381)"
This reverts commit fa2484ea90.
2017-10-24 22:18:15 +03:00
proller
fa2484ea90 Make gperftools (libtcmalloc) as submodule and update. (#1381)
* Update tcmalloc and make submodule

* wip

* wip

* wip

* wip

* clean

* fix

* fix

* fix

* Fix tests
2017-10-24 22:11:42 +03:00
alexey-milovidov
6d62a117a1 Merge pull request #1395 from proller/fix4
Fix stripping debug info from huge .o (-g0)
2017-10-24 22:04:21 +03:00
Alexey Milovidov
66f099cf93 Merge branch 'master' of github.com:yandex/ClickHouse 2017-10-24 21:28:31 +03:00
Alexey Milovidov
7c99e50a2f Fixed build [#CLICKHOUSE-2]. 2017-10-24 21:28:20 +03:00
alexey-milovidov
c8d66bfed0 Merge pull request #1391 from yandex/arbitrary-partitioning
Custom partitioning 3
2017-10-24 21:18:34 +03:00
Alexey Zatelepin
6bb34a4494 Merge branch 'master' into arbitrary-partitioning
Conflicts:
	dbms/src/Storages/StorageFactory.cpp
2017-10-24 17:23:18 +03:00
Alexey Zatelepin
b6b5d1cf25 store rows count for part on disk to allow tables without fixed size columns [#CLICKHOUSE-3000] 2017-10-24 17:11:53 +03:00
proller
2d2a4afa3f Fix stripping debug info from huge .o (-g0) 2017-10-24 16:30:44 +03:00
alexey-milovidov
d5cf664297 Update build.rst 2017-10-24 02:50:54 +03:00
proller
82134e44cb Split ComplexKeyCacheDictionary to faster compile (part2) 2017-10-24 00:26:42 +03:00
proller
86a587e482 Fix test (supress stderr) 2017-10-23 21:40:07 +03:00
alexey-milovidov
3c2155df0b Update StorageKafka.cpp 2017-10-23 20:47:33 +03:00
alexey-milovidov
139e2080ae Update StorageKafka.cpp 2017-10-23 20:47:33 +03:00
alexey-milovidov
5bfb4c213c Update JSONEachRowRowInputStream.cpp 2017-10-23 20:47:33 +03:00
Marek Vavruša
3926851343 StorageKafka: use config string instead of just server name 2017-10-23 20:47:33 +03:00
Marek Vavruša
a494491f47 contrib: updated librdkafka to v0.11.1@3401fa1
This is the last version with CMake fixes from @proller
2017-10-23 20:47:33 +03:00
Marek Vavruša
a7c391fbf7 StorageKafka: use std::vector instead of stack array for error string buffers 2017-10-23 20:47:33 +03:00
Marek Vavruša
f4c1149606 Settings: renamed schema to format_schema 2017-10-23 20:47:33 +03:00
Marek Vavruša
6be0ffd943 DataStreams/JSONEachRow: read exact number of rows
When using a LIMIT to reduce the number of rows
read, JSONEachRow format would always read an
extra row as it triggered a scan to seek the
EOF or beginning of the next row. This is not
an issue with physical tables, but it is
for streaming tables as an extra row is
unintentionally consumed on each read.
2017-10-23 20:47:33 +03:00
Alexey Milovidov
365f1c2a3b Merge branch 'master' of github.com:yandex/ClickHouse 2017-10-23 20:39:07 +03:00
Alexey Milovidov
c57a62611b Removed StorageTrivialBuffer because it is underdeveloped [#CLICKHOUSE-2]. 2017-10-23 20:38:56 +03:00
proller
13e5e9fbde Fix build in ubuntu xenial in pbuilder 2017-10-23 20:35:43 +03:00
proller
c66228a746 Log query id in executeQuery; Better type mismatch error; change format in report tool (#1372)
* Log query id in executeQuery; Better type mismatch error; change format in report tool

* Better log query_id

* fix message

* Use c++11 thread_local instaed of gcc's __thread

* lock mutex before notifying waiting thread in sync insertion into distributed [#CLICKHOUSE-3379]

* Cmake: fix build without downloaded submodules (#1379)

* fix
2017-10-23 20:32:39 +03:00
proller
ddb0dcd2fd Increase default maximum size of brtie dictionary to 128m ips (#1364)
* Increase default maximum size of brtie dictionary to 128m ips
pbuilder: use newer cmake on ubuntu trusty

* no cmake
2017-10-23 20:19:15 +03:00
Alexey Zatelepin
8ccebefae6 add tests for extended storage definition syntax [#CLICKHOUSE-3000] 2017-10-23 18:21:44 +03:00
alexey-milovidov
6555d08782 Merge pull request #1390 from proller/fix6
Fix: An Error SQL will make server down (#1388)
2017-10-23 18:10:42 +03:00
Alexey Milovidov
d77686685a Using PODArray instead of std::vector in ZooKeeper library [#CLICKHOUSE-2]. 2017-10-23 18:08:31 +03:00
alexey-milovidov
91aa0713e5 Merge pull request #1371 from vavrusa/fix-zookeeper-stack-smashing
ZooKeeper: fixed stack smashing with tryGet()
2017-10-23 17:40:12 +03:00
alexey-milovidov
4f86ec9d58 Update ZooKeeper.cpp 2017-10-23 17:39:29 +03:00
proller
d8038cf746 Fix: An Error SQL will make server down (#1388) 2017-10-23 17:37:46 +03:00
Alex Zatelepin
dd451946cf Update CHANGELOG_RU.md 2017-10-23 17:22:22 +03:00
Nikolai Kochetov
adae8205a7 increased timeout for test_insertion_sync_fails_with_timeout 2017-10-23 16:56:42 +03:00
Nikolai Kochetov
5966574405 fix timeout lock in DistributedBlockOutputStream 2017-10-23 16:47:00 +03:00
Nikolai Kochetov
3317251e2f fix jobs flags in DistributedBlockOutputStream 2017-10-23 15:00:56 +03:00