alexey-milovidov
022648a154
Merge pull request #16558 from azat/query_thread_log_current_database
...
Add current_database into query_thread_log
2020-10-31 06:36:10 +03:00
Azat Khuzhin
5bab7a5bc7
Add current_database into query_thread_log
2020-10-30 21:16:10 +03:00
Maxim Akhmedov
3627fabfb9
Remove -g0 form Arcadia build settings.
2020-10-29 17:37:23 +03:00
alesapin
8a6be1602b
Merge pull request #16364 from ClickHouse/fix_uuid_mapping_exists
...
Minor improvements in DatabaseCatalog
2020-10-28 10:54:39 +03:00
Mikhail Filimonov
41971e073a
Fix typos reported by codespell
2020-10-27 12:04:03 +01:00
Alexander Tokmakov
f8f2d62d70
minor improvements in DatabaseCatalog
2020-10-25 20:27:21 +03:00
alexey-milovidov
e00f6c4a0d
Merge branch 'master' into total_memory_tracker-by-default
2020-10-24 21:17:53 +03:00
Azat Khuzhin
114ea9b1eb
Fix accounting for new/delete from different threads for VariableContext::Thread
...
MemoryTracker assumes that for VariableContext::Thread new/delete may be
called from different threads, hence the amount of memory can go
negative.
However the MemoryTracker is nested, so even if the negative amount is
allowed for VariableContext::Thread it does not allowed for anything
upper, and hence the MemoryTracking will not be decremented properly.
Fix this, by passing initial size to the parent free.
This should fix memory drift for HTTP queries.
2020-10-23 21:07:52 +03:00
Azat Khuzhin
72d7b6117e
Use total_memory_tracker when there is no other MemoryTracker object.
...
This should significantly reduce the MemoryTracking drift, test shows
that there is 0 drift after query storm (100 queries, via http/tcp/tcp
in one session).
TL;DR;
To track memory, clickhouse creates memory tracker object for each
thread **explicitly**, but until it is not created the memory
allocations are not under account.
There should not be lot of allocations w/o memory tracker, since most of
the time it is created early enough, but even this maybe enough to
trigger some problems.
Plus sometimes it is not possible to create it, for example some 3d
party library does not allow to do this explicitly:
- for example before #15740 allocations from librdkafka threads,
- or even worse, poco threads, they don't have any routines to do this.
This won't be a problem for `MemoryTracking` metric if the deallocation
will be done from the same thread w/o memory tracker (or vise versa),
but this is not always true.
NOTE, that this will slow down per-thread allocations w/o memory
tracker, since before this patch there were no memory tracking for them
while now they will be accounted in total_memory_tracker, and for
total_memory_tracker max_untracked_memory is always reached.
But this should not be significant.
2020-10-23 21:07:52 +03:00
Amos Bird
ccf59c6412
Fix definitely wrong bug
2020-10-22 22:56:45 +08:00
alexey-milovidov
2ae32e3d5c
Merge pull request #16101 from azat/http-memory-tracking-fixes
...
Fix memory tracker settings (for HTTP queries)
2020-10-22 00:00:47 +03:00
Alexey Milovidov
2619efadc8
Fix multiple issues with memory tracking
2020-10-21 03:31:34 +03:00
Vladimir Chebotarev
aa5f207fd4
Added disable_merges option for volumes in multi-disk configuration ( #13956 )
...
Co-authored-by: Alexander Kazakov <Akazz@users.noreply.github.com>
2020-10-20 18:10:24 +03:00
Alexey Milovidov
448c87363c
Style
2020-10-20 04:29:34 +03:00
Alexander Kuzmenkov
defcd29b31
Merge pull request #16036 from ClickHouse/stress_test_improvemets
...
Minor improvements of stress test
2020-10-19 16:12:30 +03:00
Azat Khuzhin
082f30a3a1
Introduce ThreadStatus::applyQuerySettings() to reduce copy-paste
2020-10-17 15:01:53 +03:00
Alexander Tokmakov
026896835c
fixes
2020-10-16 15:20:30 +03:00
Alexander Tokmakov
95ad45a3b0
minor improvements of stress test
2020-10-15 21:14:04 +03:00
Nikolai Kochetov
939d8edf33
Merge pull request #15999 from ClickHouse/fix-after-15437
...
Continuation of 15437
2020-10-15 18:20:48 +03:00
Vitaly Baranov
5f261cec3c
Merge pull request #15199 from filimonov/non_delimited_protobuf
...
ProtobufSingle format
2020-10-15 16:58:39 +03:00
Nikolai Kochetov
963ce315b2
Merge pull request #15454 from azat/dict-prealloc
...
Speedup hashed/sparse_hashed dictionary loading by preallocating the hash table
2020-10-15 15:03:53 +03:00
Nikolai Kochetov
40f62719ff
Move event to stack.
2020-10-15 13:24:18 +03:00
Vitaly Baranov
997570780d
Merge branch 'master' into non_delimited_protobuf
2020-10-14 16:26:57 +03:00
Anton Popov
7470ac98bb
Merge pull request #15855 from hexiaoting/dev_fetch
...
Add Support for OFFSET_FETCH_CLAUSE
2020-10-14 15:21:28 +03:00
hexiaoting
dea965832a
Fix error for previous offset test
2020-10-13 11:32:43 +08:00
Azat Khuzhin
2947eff878
Fix query hang with connections_with_failover_max_tries = 0 (endless loop)
2020-10-12 22:07:26 +03:00
Mikhail Filimonov
87a8ba63f7
Few more CR fixes
2020-10-12 15:05:40 +02:00
alexey-milovidov
10e9d14466
Merge pull request #15818 from ClickHouse/style-pragma-once
...
Check for #pragma once in headers
2020-10-11 13:14:09 +03:00
alexey-milovidov
39e58128cd
Merge pull request #15812 from ClickHouse/bigint-hash
...
Minor changes in BigInt hash
2020-10-11 01:11:30 +03:00
Alexey Milovidov
269b6383f5
Check for #pragma once in headers
2020-10-10 21:37:02 +03:00
Alexey Milovidov
9f15daf45c
Remove useless metrics to avoid confusion
2020-10-10 18:52:44 +03:00
Alexey Milovidov
a2ef0f6cba
Minor changes in BigInt hash
2020-10-10 18:46:41 +03:00
Alexey Milovidov
4f2d4988c6
Fix build on Mac OS
2020-10-10 13:51:57 +03:00
Alexey Milovidov
2c71327ff5
Fix build on Mac OS
2020-10-10 11:02:02 +03:00
Azat Khuzhin
f4f79aa84a
Add HashTable::reserve() (for preallocated hashed/sparse_hashed dictionaries)
2020-10-09 21:53:57 +03:00
Azat Khuzhin
553f6aa4cd
Remove unused functions
2020-10-07 21:30:53 +03:00
alexey-milovidov
97d97f6b2e
Merge pull request #15513 from ClickHouse/aku/error-context
...
Add some context to an error message
2020-10-03 16:24:19 +03:00
alexey-milovidov
ae61f8f7a6
Update filesystemHelpers.cpp
2020-10-03 15:57:35 +03:00
alexey-milovidov
4d6402525a
Update filesystemHelpers.h
2020-10-03 15:57:12 +03:00
Alexey Milovidov
d426ba3074
Step 4: cleanup
2020-10-03 03:07:55 +03:00
Alexey Milovidov
b6ca8a0676
Step 3: check other usages, add a comment
2020-10-03 03:05:54 +03:00
Alexey Milovidov
2441be4b66
Step 2: move code to .cpp
2020-10-03 03:02:47 +03:00
Alexey Milovidov
6608de470d
Step 1: handle EINTR in statvfs
2020-10-03 03:01:32 +03:00
Alexander Kuzmenkov
3be7c7745e
Use a separate overload for formatting with fmt
2020-10-02 14:06:38 +03:00
Alexander Kuzmenkov
6e07bfe7bc
return the comment
2020-10-01 17:29:22 +03:00
Alexander Kuzmenkov
c5d6e2e67c
Add context to error messages
2020-10-01 14:02:53 +03:00
Nikolai Kochetov
45618c9d4c
Merge pull request #15437 from ClickHouse/azat-ThreadPool-UAF-fixes
...
Destroy resources captured by lambda after `ThreadFromGlobalPool::join()`
2020-09-30 16:50:30 +03:00
alesapin
01d8a36cd6
Merge pull request #15456 from ClickHouse/more-exception-safety-in-shellcommand
...
Fix exception safety in ShellCommand
2020-09-30 12:56:55 +03:00
Nikolai Kochetov
0e412686bc
Better comments.
2020-09-30 11:25:22 +03:00
alexey-milovidov
412a54e356
Merge pull request #14693 from hustnn/zk_exist_fix2
...
Fix potential memory leak caused by zookeeper exist calling
2020-09-30 04:48:11 +03:00
