thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-16 03:12:43 +00:00
Code Issues Packages Projects Releases Wiki Activity
116,616 Commits 9,326 Branches 1,783 Tags 2.1 GiB
029a4fd201
Commit Graph

9953 Commits

Author SHA1 Message Date
Azat Khuzhin
5277c802f7 Fix table dependencies in case of failed RENAME TABLE 
CI found this [1]

    [ 382620 ] {} <Error> Application: Caught exception while loading metadata: Code: 60. DB::Exception: Table test_25.join doesn\'t exist: While processing _CAST(joinGet(test_25.join, \'m\', CAST(\'42\', \'int\')) AS m_tmp_alter1351896088559986425, \'Int32\') AS m: default expression and column type are incomp
    [ 382620 ] {} <Error> Application: Code: 60. DB::Exception: Table test_25.join doesn\'t exist: While processing _CAST(joinGet(test_25.join, \'m\', CAST(\'42\', \'int\')) AS m_tmp_alter1351896088559986425, \'Int32\') AS m: default expression and column type are incompatible.: Cannot attach table `test_25`.`t

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/48670/d7f865037266ed87538cf4df7ec7e8165681871b/stress_test__asan_.html

The problem here is that after failed RENAME dependencies got lost:

    [4e937f39d866] 2023.04.12 00:51:06.833624 [ 13419 ] {61429225-64cb-4fce-b60d-01e0dac6e52c} <Error> executeQuery: Code: 241. DB::Exception: Memory limit (total) exceeded: would use 34.65 GiB (attempt to allocate chunk of 2097419 bytes), maximum: 34.29 GiB. OvercommitTracker decision: Memory overcommit has freed not enough memory. (MEMORY_LIMIT_EXCEEDED) (version 23.4.1.1) (from [::1]:45710) (comment: 01160_table_dependencies.sh) (in query: create database test_25_1), Stack trace (when copying this message, always include the lines below):
    [4e937f39d866] 2023.04.12 00:51:07.351914 [ 5151 ] {66d8bdd4-668e-4239-a8af-6b8f17bb5222} <Error> executeQuery: Code: 81. DB::Exception: Database test_25_1 doesn't exist. (UNKNOWN_DATABASE) (version 23.4.1.1) (from [::1]:45762) (comment: 01160_table_dependencies.sh) (in query: rename table t to test_25_1.t), Stack trace (when copying this message, always include the lines below):

And from the test output:

    OK
    OK
    OK
    OK
    a       []      []      []
    data_02344      []      []      []
    date_table      []      []      []
    dict1   []      ['dict_src']    ['join']
    dict2   []      ['join']        []
    dict_src        []      []      ['dict1']
    dist_02346      []      []      []
    join    []      ['dict1']       ['dict2','s']
                                    ^^^^^^^^^^^^^ no "t"

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-12 11:11:05 +02:00
flynn
ea9187511e Make Schema inference works for CREATE AS SELECT 2023-04-12 04:21:03 +00:00
pufit
078b8f5399 Small refactor, additional tests 2023-04-11 19:55:59 -04:00
Dmitry Novik
06e6794fc0 Merge remote-tracking branch 'origin/master' into background-memory-tracker 2023-04-11 15:29:35 +00:00
Anton Popov
09c66c3879 fix async inserts with empty data 2023-04-11 15:13:46 +00:00
Mikhail f. Shiryaev
89e4509e68
Merge branch 'master' into fix-memory-compressed-tables 2023-04-11 16:38:51 +02:00
Alexander Tokmakov
a1fda047f6 add docs 2023-04-11 16:32:40 +02:00
Alexander Tokmakov
dfff30e1a9 Merge branch 'master' into clusters_is_active_column 2023-04-11 16:32:15 +02:00
Anton Popov
3896375247 fix getting subcolumn from in-memory data 2023-04-11 14:26:31 +00:00
Nikolay Degterinsky
0621222737 Fix crashes with incorrect query parameters 2023-04-11 14:22:55 +00:00
Nikolay Degterinsky
f34b304707 Fixes, add test 2023-04-11 12:54:54 +00:00
SmitaRKulkarni
e2010c0257
Merge branch 'master' into zk_retry_timeout 2023-04-11 14:05:52 +02:00
Nikolay Degterinsky
7606336fd8 Merge remote-tracking branch 'upstream/master' into add_default_password_type 2023-04-11 11:59:45 +00:00
vdimir
4605d71947
Fix build src/Interpreters/InterpreterInsertQuery.h 2023-04-11 11:17:02 +00:00
Sema Checherinda
4dd86a406a
Merge pull request #48543 from azat/mv-uniq-thread-group 
Use one ThreadGroup while pushing to materialized views (and some refactoring for ThreadGroup)
 2023-04-11 11:47:46 +02:00
Alexey Milovidov
d259217cf3
Merge pull request #48570 from azat/build/logger_useful 
Remove superfluous includes of logger_userful.h from headers
 2023-04-11 03:56:39 +03:00
Nikolay Degterinsky
908be1e324 Fix tests 2023-04-10 22:04:10 +00:00
Alexey Milovidov
f4d6596eaa
Merge pull request #48577 from ClickHouse/evillique-patch-2 
Don't use type conversion with String query parameters
 2023-04-10 22:18:39 +03:00
Azat Khuzhin
013a3ed269 Fix possible lock order inversion in Context::setTemporaryStorageInCache() 
TSan report [1]:

    WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid=1)
      Cycle in lock order graph: M0 (0x7b9000000008) => M1 (0x7b90000000a8) => M0

      Mutex M1 acquired here while holding mutex M0 in main thread:
        0 pthread_mutex_lock <null> (clickhouse+0xc66a8da) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        3 std::__1::lock_guard<std::__1::mutex>::lock_guard[abi:v15000](std::__1::mutex&) build_docker/./contrib/llvm-project/libcxx/include/__mutex_base:94:27 (clickhouse+0x1d0ccb3a) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        4 DB::Context::getDisk() const build_docker/./src/Interpreters/Context.cpp:3281:21 (clickhouse+0x1d0ccb3a)
        5 DB::Context::setTemporaryStorageInCache() build_docker/./src/Interpreters/Context.cpp:927:21 (clickhouse+0x1d0cc188) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        6 DB::Server::main() build_docker/./programs/server/Server.cpp:1055:25 (clickhouse+0x148504c2) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)

      Mutex M0 previously acquired by the same thread here:
        0 pthread_mutex_lock <null> (clickhouse+0xc66a8da) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        3 std::__1::unique_lock<std::__1::recursive_mutex>::unique_lock[abi:v15000](std::__1::recursive_mutex&) build_docker/./contrib/llvm-project/libcxx/include/__mutex_base:122:61 (clickhouse+0x1d0cc148) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        4 DB::Context::getLock() const build_docker/./src/Interpreters/Context.cpp:690:12 (clickhouse+0x1d0cc148)
        5 DB::Context::setTemporaryStorageInCache() build_docker/./src/Interpreters/Context.cpp:922:17 (clickhouse+0x1d0cc148)
        6 DB::Server::main() build_docker/./programs/server/Server.cpp:1055:25 (clickhouse+0x148504c2) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)

      Muex M0 acquired here while holding mutex M1 in main thread:
        0 pthread_mutex_lock <null> (clickhouse+0xc66a8da) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        3 std::__1::unique_lock<std::__1::recursive_mutex>::unique_lock[abi:v15000](std::__1::recursive_mutex&) build_docker/./contrib/llvm-project/libcxx/include/__mutex_base:122:61 (clickhouse+0x1d0c7ce1) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        4 DB::Context::getLock() const build_docker/./src/Interpreters/Context.cpp:690:12 (clickhouse+0x1d0c7ce1)
        5 DB::Context::getPath() const build_docker/./src/Interpreters/Context.cpp:713:17 (clickhouse+0x1d0c7ce1)
        6 DB::loadDiskLocalConfig() build_docker/./src/Disks/DiskLocal.cpp:75:30 (clickhouse+0x1ce7ed8a) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        7 DB::DiskLocal::applyNewSettings() build_docker/./src/Disks/DiskLocal.cpp:491:5 (clickhouse+0x1ce7e7ef) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        8 DB::DiskSelector::updateFromConfig() const build_docker/./src/Disks/DiskSelector.cpp:92:19 (clickhouse+0x1d14088e) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        9 DB::Context::updateStorageConfiguration() build_docker/./src/Interpreters/Context.cpp:3388:49 (clickhouse+0x1d0ec002) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        ..
        17 DB::ConfigReloader::reloadIfNewer() build_docker/./src/Common/Config/ConfigReloader.cpp:149:13 (clickhouse+0x1fff4250)

      Mutex M1 previously acquired by the same thread here:
        0 pthread_mutex_lock <null> (clickhouse+0xc66a8da) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        3 std::__1::lock_guard<std::__1::mutex>::lock_guard[abi:v15000](std::__1::mutex&) build_docker/./contrib/llvm-project/libcxx/include/__mutex_base:94:27 (clickhouse+0x1d0ebf25) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        4 DB::Context::updateStorageConfiguration() build_docker/./src/Interpreters/Context.cpp:3384:21 (clickhouse+0x1d0ebf25)
        ..
        12 DB::ConfigReloader::reloadIfNewer() build_docker/./src/Common/Config/ConfigReloader.cpp:149:13 (clickhouse+0x1fff4250)

    SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock) (/usr/bin/clickhouse+0xc66a8da) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280) in pthread_mutex_lock
    ==================

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/48596/a1272e8536265929255fdf5020836f057859e425/integration_tests__tsan__[6/6].html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-10 19:56:52 +02:00
Nikolay Degterinsky
def8611d2c Fix style 2023-04-10 17:05:31 +00:00
Nikolay Degterinsky
6f57a952d9 Improvements 2023-04-10 16:40:49 +00:00
Azat Khuzhin
79b83c4fd2 Remove superfluous includes of logger_userful.h from headers 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-10 17:59:30 +02:00
Nikolai Kochetov
28484cd762
Merge pull request #48522 from ClickHouse/many-mutations-memory-limit 
Reduce memory usage for multiple alter delete mutations.
 2023-04-10 12:50:42 +02:00
Raúl Marín
45ad555c39
Merge branch 'master' into zk_retry_timeout 2023-04-10 10:04:16 +02:00
Nikolay Degterinsky
8524f6958a
Update src/Interpreters/ReplaceQueryParameterVisitor.cpp 
Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
 2023-04-10 09:09:57 +02:00
Nikolay Degterinsky
7957752128 Merge remote-tracking branch 'upstream/master' into add_default_password_type 2023-04-10 02:25:46 +00:00
Nikolay Degterinsky
64dc60a8d1 Better version, introduce ASTAuthenticationData 2023-04-10 02:20:57 +00:00
Nikolay Degterinsky
e71c7fe744
Fix 2023-04-10 03:48:58 +02:00
Nikolay Degterinsky
6b1c86c6ec
Don't use type conversion with String query parameters 2023-04-10 03:39:13 +02:00
Vitaly Baranov
62e9c419de
Merge pull request #48519 from azat/build/fwd-decl-threadpool 
Use forward declaration of ThreadPool
 2023-04-08 00:44:01 +02:00
Alexey Milovidov
e09e80b493
Merge pull request #48500 from CurtizJ/fix-sparse-column-query-cache 
Fix query cache with sparse columns
 2023-04-07 19:34:10 +03:00
Alexander Tokmakov
9ec91acef3 add some columns to system.clusters 2023-04-07 18:26:23 +02:00
Azat Khuzhin
44ae8485f1 Use one ThreadGroup while pushing to materialized views 
Before this patch only the case when ThreadStatus (current_thread)
already has ThreadGroup works that way, after they will be identical in
this aspect.

But this should not affect anything, but it just make sense.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-07 15:37:35 +02:00
Azat Khuzhin
aacf2a0838 Move ThreadGroupSwitcher to ThreadStatus.h (out from MergeTree code) 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-07 15:32:08 +02:00
Azat Khuzhin
5b2b20a0b0 Rename ThreadGroupStatus to ThreadGroup 
There are methods like getThreadGroup() and ThreadGroupSwitcher class,
so seems that this is logical.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-07 15:31:48 +02:00
Sema Checherinda
0503ed6fb8
Merge pull request #46668 from azat/fix-query_views_log-from-bg 
Fix system.query_views_log for MVs that are pushed from background threads
 2023-04-07 14:47:05 +02:00
Azat Khuzhin
011480924a Use forward declaration of ThreadPool 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-07 11:25:35 +02:00
Yakov Olkhovskiy
8d1924cc9a
Merge pull request #47962 from ClickHouse/imp-use-structure-from-insertion 
Improvement and fix for use_structure_from_insertion_table_in_table_functions
 2023-04-06 19:01:00 -04:00
Nikolai Kochetov
e8fb135180 Reduce memory usage for multiple alter delete mutations. 2023-04-06 19:07:53 +00:00
Anton Popov
8d1b535efb fix storage Memory with compression 2023-04-06 18:27:53 +00:00
Sema Checherinda
9d8d9e8ec9
Merge branch 'master' into fix-query_views_log-from-bg 2023-04-06 18:16:47 +02:00
Anton Popov
4757d76fbf fix query cache with sparse columns 2023-04-06 16:01:23 +00:00
Anton Popov
b5a3723c88
Merge pull request #48395 from ClickHouse/with_fill_clarification 
WITH FILL clarification and cleanup
 2023-04-06 17:02:57 +02:00
pufit
d1fa9596b8 Prevent execution on cluster 2023-04-06 10:56:35 -04:00
Sema Checherinda
b8729be97a
Merge pull request #47104 from CheSema/thead-group-for-merge 
merge and mutation make thread group for setting memory trackers right
 2023-04-06 15:46:56 +02:00
Vitaly Baranov
b45b662fe3
Merge pull request #48431 from Algunenano/system_referential_table 
Don't check dependencies when renaming system tables automatically
 2023-04-06 15:28:37 +02:00
Nikolai Kochetov
6c6335b686
Merge pull request #48357 from ClickHouse/fix-projections-analysis-with-analyzer 
Batch fix for projections analysis with analyzer.
 2023-04-06 15:13:56 +02:00
Yakov Olkhovskiy
d2e897d4b8
Merge branch 'master' into imp-use-structure-from-insertion 2023-04-06 08:52:38 -04:00
Antonio Andelic
28a33f0a47
Merge pull request #48435 from ClickHouse/kv-update-only-affected-rows 
Update only affected rows in KV storage
 2023-04-06 12:33:54 +02:00
Vladimir C
e7a5c96353
Merge pull request #48219 from ClickHouse/vdimir/lock_order_47072 2023-04-06 11:54:33 +02:00
Vladimir C
a2b71a0054
Merge pull request #48386 from ClickHouse/vdimir/reset-downloader-tmp-data-cache 2023-04-06 11:23:16 +02:00
Yakov Olkhovskiy
8a19ac4e73
Merge branch 'master' into imp-use-structure-from-insertion 2023-04-06 00:51:44 -04:00
pufit
144ee7aed4 Fix logic, additional tests 2023-04-05 22:52:31 -04:00
robot-ch-test-poll3
3ad0a6ac18
Merge pull request #48433 from ClickHouse/some-fixes-for-parallel-replicas 
Some fixes for parallel replicas
 2023-04-06 02:00:06 +02:00
Alexander Tokmakov
a154fa73f4
Merge pull request #48401 from ClickHouse/fix_00002_log_messages 
Find big allocations without memory limits checks
 2023-04-05 23:52:39 +03:00
Sema Checherinda
554c928534
Merge branch 'master' into thead-group-for-merge 2023-04-05 21:09:38 +02:00
Raúl Marín
1fa992f015
Merge branch 'master' into system_referential_table 2023-04-05 20:47:53 +02:00
robot-clickhouse
3d2c279859
Merge pull request #48242 from azat/better-throttling 
Per-query/per-server throttling for remote IO/local IO/BACKUPs
 2023-04-05 19:32:37 +02:00
kssenii
a405d06e8a Merge remote-tracking branch 'upstream/master' into cache-better-locks 2023-04-05 18:46:52 +02:00
Antonio Andelic
0260b84bc3 Update only affected rows in KV storage 2023-04-05 16:12:14 +00:00
Raúl Marín
5d9e006c46 PR comments 2023-04-05 18:04:03 +02:00
Igor Nikonov
46f7016d8c Add search alias by input name in ActionsDAG 2023-04-05 15:56:06 +00:00
Nikita Mikhaylov
3f44c6d936 Better 2023-04-05 15:19:45 +00:00
Raúl Marín
d65d00f496 Don't check dependencies when renaming system tables automatically 2023-04-05 16:15:24 +02:00
vdimir
d9abcf2f69
Reduce scope storage_policies_mutex in setTemporaryStoragePolicy 2023-04-05 13:42:49 +00:00
vdimir
01ce3baf0f
Rename Context::getTemporaryVolume to getGlobalTemporaryVolume 2023-04-05 13:42:13 +00:00
Igor Nikonov
41f6e0e7b5 More efficient original node search in ActionsDAG 2023-04-05 13:36:07 +00:00
vdimir
6f3fa33641
Add unbound flag to system.filesystem_cache 2023-04-05 13:12:20 +00:00
Nikita Mikhaylov
7b526d3df9
Always communicate with local replica through loopback interface for parallel replicas (#48246) 2023-04-05 13:32:46 +02:00
Sema Checherinda
f504cd5fed avoid race, do not set thread_group.counters.parent from query 2023-04-05 12:36:55 +02:00
Igor Nikonov
47e7e19ca9 Move suffix generation code into one function 2023-04-05 10:12:42 +00:00
vdimir
bae1286b63
Update temp_data_on_disk in shared context 2023-04-05 10:07:44 +00:00
vdimir
7fe06f8435
Do not take lock for shared context in setTempDataOnDisk 2023-04-05 09:22:09 +00:00
Azat Khuzhin
4008155a6e Add max_ prefix for backup_bandwidth settings 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-05 10:54:25 +02:00
Azat Khuzhin
61405b827d Use MAKE_DEPRECATED_BY_SERVER_CONFIG() for deprecated throttle settings 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-05 09:40:18 +02:00
Azat Khuzhin
684ecc24e2 Ignore deprecated values max_remote_{read,write}_network_bandwidth_for_server 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-05 09:40:18 +02:00
Azat Khuzhin
ad96d3c249 Do not require proper Poco Application for Context 
$ yes | head | clickhouse-obfuscator --structure 'id String' --seed foo --input-format TSV --output-format TSV
    Poco::Exception. Code: 1000, e.code() = 0, Null pointer: _pInstance in file "/src/ch/clickhouse/base/poco/Util/include/Poco/Util/Application.h", line 446, Stack trace (when copying this message, always include the lines below):

    0. /src/ch/clickhouse/contrib/llvm-project/libcxx/include/exception:134: std::exception::capture() @ 0x15605622 in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    1. /src/ch/clickhouse/contrib/llvm-project/libcxx/include/exception:112: std::exception::exception[abi:v15000]() @ 0x156055ed in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    2. /src/ch/clickhouse/base/poco/Foundation/src/Exception.cpp:27: Poco::Exception::Exception(String const&, int) @ 0x2ebd2d80 in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    3. /src/ch/clickhouse/base/poco/Foundation/src/Exception.cpp:132: Poco::LogicException::LogicException(String const&, int) @ 0x2ebd3667 in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    4. /src/ch/clickhouse/base/poco/Foundation/src/Exception.cpp:134: Poco::NullPointerException::NullPointerException(String const&, int) @ 0x2ebd3da7 in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    5. /src/ch/clickhouse/base/poco/Foundation/src/Bugcheck.cpp:42: Poco::Bugcheck::nullPointer(char const*, char const*, int) @ 0x2ebc5851 in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    6. /src/ch/clickhouse/base/poco/Util/include/Poco/Util/Application.h:446: Poco::Util::Application::instance() @ 0x1ee3e6cd in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    7. /src/ch/clickhouse/src/Interpreters/Context.cpp:358: DB::ContextSharedPart::ContextSharedPart() @ 0x263b0cca in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    8. /src/ch/clickhouse/contrib/llvm-project/libcxx/include/__memory/unique_ptr.h:714: std::__unique_if<DB::ContextSharedPart>::__unique_single std::make_unique[abi:v15000]<DB::ContextSharedPart>() @ 0x26387b6e in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    9. /src/ch/clickhouse/src/Interpreters/Context.cpp:652: DB::Context::createShared() @ 0x26361a3c in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    10. /src/ch/clickhouse/programs/obfuscator/Obfuscator.cpp:1293: mainEntryClickHouseObfuscator(int, char**) @ 0x1ef6eb26 in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    11. /src/ch/clickhouse/programs/main.cpp:481: main @ 0x155e569a in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    12. ? @ 0x7ffff7dd2790 in ?
    13. __libc_start_main @ 0x7ffff7dd284a in ?
    14. _start @ 0x155e51ae in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
     (version 23.3.1.2537)

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-05 09:40:18 +02:00
Azat Khuzhin
a8c1407bc4 Use existing ServerSettings in Context instead of reading it again 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-05 09:40:18 +02:00
Azat Khuzhin
c332d290d8 Keep only one throttler for BACKUPs IO (instead of separate read/write) 
There is no need in separate read/write throttling, because you cannot
write faster then read anyway, and plus this makes the code less cleaner

(and also it will allow avoid implementing throttling backups to S3,
since it does not use common S3 writer).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-05 09:40:17 +02:00
Azat Khuzhin
218b1f9c29 Add ability to throttle BACKUPs on per-server/backup basis 
Server settings:
- backup_read_bandwidth_for_server
- backup_write_bandwidth_for_server

Query settings:
- backup_read_bandwidth
- backup_write_bandwidth

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-05 09:39:48 +02:00
Azat Khuzhin
a25dd1d348 Add ability to throttle local IO on per-query/server basis 
Server settings:
- max_local_read_bandwidth_for_server
- max_local_write_bandwidth_for_server

Query settings:
- max_local_read_bandwidth
- max_local_write_bandwidth

This is the preparation for adding ability to throttle BACKUPs

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-05 09:39:15 +02:00
Azat Khuzhin
b3406beeb7 Add per-query network throttling 
Controlled with:
- max_remote_read_network_bandwidth
- max_remote_write_network_bandwidth

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-05 09:39:15 +02:00
Azat Khuzhin
abdb682048 Move some methods for Context into module part 
This will be required later, for per-query bandwidth limiting.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-05 09:39:15 +02:00
Azat Khuzhin
40cb87c2ac Make remote bandwidth settings server settings 
Right now those two settings are applied only at start:
- max_remote_read_network_bandwidth_for_server
- max_remote_write_network_bandwidth_for_server

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-05 09:39:15 +02:00
pufit
8441b0a3e1 Fix comments, tests, docs 2023-04-04 20:43:15 -04:00
Alexander Tokmakov
ba65be22da fix bad error messages 2023-04-04 20:21:22 +02:00
vdimir
5966281f7c
Test WriteBufferToFileSegment with several threads 2023-04-04 18:15:27 +00:00
vdimir
61c8a9586e
Fix usage of is_unbound in FileSegment 2023-04-04 18:14:54 +00:00
Raúl Marín
0e17b3b147 Merge remote-tracking branch 'blessed/master' into zk_retry_timeout 2023-04-04 18:53:55 +02:00
Igor Nikonov
1fb0292fcb polishing 2023-04-04 16:13:21 +00:00
Igor Nikonov
5a9acac12f Clarification and cleanup 2023-04-04 16:00:09 +00:00
Azat Khuzhin
9235d1cde2 Fix system.query_views_log for MVs that are pushed from background threads 
Some of such places:
- push from Buffer
- push from Distributed sends
- system.*_log workers

Before #47564 it simply does not work, but after it throws LOGICAL_ERROR
in such situation.

v2: remove expired() check after #46709 got merged
v3: use ThreadGroupStatus ctor with ContextPtr (after #47564)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-04 17:43:10 +02:00
vdimir
50c8472c57
Reset downloader in WriteBufferToFileSegment::nextImpl 2023-04-04 15:39:25 +00:00
vdimir
999a3889d0
Revert "Reset downloader for cache file segment in TemporaryFileStream" 
This reverts commit 07147771e6.
 2023-04-04 14:22:33 +00:00
vdimir
07147771e6
Reset downloader for cache file segment in TemporaryFileStream 2023-04-04 13:26:24 +00:00
Kruglov Pavel
5f930aeb26
Merge pull request #48115 from save-my-heart/throw_non_parametric_function 
throw exception while non-parametric functions having parameters
 2023-04-04 12:05:34 +02:00
Antonio Andelic
52e4149c98
Merge pull request #47934 from ClickHouse/alternative-keeper-configs 
Merge #35113
 2023-04-04 09:58:33 +02:00
Antonio Andelic
d0ba1e76bf
Merge pull request #48293 from ClickHouse/keeper-map-strict-mode 
Add strict mode for KeeperMap
 2023-04-04 09:57:01 +02:00
Nikolai Kochetov
b327a93cf7 Add comments. 2023-04-03 18:18:39 +00:00
Nikolai Kochetov
61a484f0bd Batch fix for projections analysis with analyzer. 2023-04-03 16:44:31 +00:00
Yakov Olkhovskiy
e3457da144 for auto check subset of columns support, fix some minor issues 2023-04-03 16:05:21 +00:00
Antonio Andelic
f21c664744 Add error code 2023-04-03 15:17:06 +00:00
Antonio Andelic
f5e97fbb66 Merge branch 'master' into alternative-keeper-configs 2023-04-03 15:06:52 +00:00
Antonio Andelic
e81c2999a3
Update src/Interpreters/InterpreterAlterQuery.cpp 
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
 2023-04-03 16:56:45 +02:00
Antonio Andelic
12bee0573f Correctly check table 2023-04-03 14:54:14 +00:00
Antonio Andelic
eacc3752bf Merge branch 'master' into dont-replicate-mutations-keepermap 2023-04-03 14:38:57 +00:00
Antonio Andelic
950a7d9948 Merge branch 'master' into keeper-map-strict-mode 2023-04-03 14:26:14 +00:00
Antonio Andelic
e7d00c8f34 Don't replicate mutations for KeeperMap tables 2023-04-03 14:22:08 +00:00
Nikolai Kochetov
d4b91b7f8c
Merge pull request #47319 from ClickHouse/query-plan-update-sort-description 
Query plan: update sort description
 2023-04-03 15:42:49 +02:00
Robert Schulze
a50e741bea
Merge pull request #45912 from ClickHouse/qc-compression 
Query cache: Enable compression of cache entries
 2023-04-03 13:33:47 +02:00
Robert Schulze
3e124f09d0
Merge remote-tracking branch 'origin/master' into qc-compression 2023-04-03 11:28:17 +00:00
Antonio Andelic
2d89057142 Merge branch 'master' into keeper-map-strict-mode 2023-04-03 09:30:52 +00:00
Raúl Marín
8fdf87982c Merge remote-tracking branch 'blessed/master' into zk_retry_timeout 2023-04-03 10:26:18 +02:00
Alexey Milovidov
5ebf66819b
Merge pull request #47617 from ClickHouse/cnf-new-analyzer 
CNF/Constraint optimizer in new analyzer
 2023-04-02 20:09:34 +03:00
Alexey Milovidov
15a62df60c
Merge pull request #48054 from ClickHouse/custom-key-new-analyzer 
Make custom key for parallel replicas work in new analyzer
 2023-04-02 20:09:00 +03:00
Alexey Milovidov
9c6594a043
Merge pull request #48320 from azat/explain-fix 
Fix crash in EXPLAIN PIPELINE for Merge over Distributed
 2023-04-02 17:11:27 +03:00
Azat Khuzhin
907ed27ae2 Fix crash in EXPLAIN PIPELINE for Merge over Distributed 
CI: https://s3.amazonaws.com/clickhouse-test-reports/48314/179450542879d11711cd2415c3fa7eeab18188be/fuzzer_astfuzzerasan/report.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-02 10:48:23 +02:00
kssenii
54df42136b Rewrite space reservation so that at most one key lock is taken at a time 2023-04-01 17:53:03 +02:00
Azat Khuzhin
c64f9e6f07 Use StrongTypedef for ProfileEvents 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-01 16:01:33 +02:00
Azat Khuzhin
8d0e516310 Use StrongTypedef for CurrentMetrics to avoid possible incorrect usage 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-01 16:01:33 +02:00
Azat Khuzhin
3ede50ccfc Fix MaxPushedDDLEntryID 2023-04-01 16:00:03 +02:00
Alexander Tokmakov
48b23dd012
Fix race between DROP MatView and RESTART REPLICAS (#47863) 
* fix race between drop mv and restart replicas

* unrelated: fix bad exception messages

* fix test

* fix

* fix

* fix

* fix

* fix test

* fix

* fix test

* Update 02437_drop_mv_restart_replicas.sh

* fix tests
 2023-04-01 15:26:00 +03:00
Alexander Gololobov
bf02068702
Merge pull request #48303 from ClickHouse/grouping-sets-repeated-keys 
Do not remove inputs from maybe compiled DAG.
 2023-04-01 11:39:34 +02:00
Yakov Olkhovskiy
2f280e247a review suggestions 2023-03-31 21:37:18 +00:00
Alexander Tokmakov
9df882c37a
Merge pull request #48085 from ClickHouse/sync_replica_lightweight 
More options for `SYSTEM SYNC REPLICA`
 2023-03-31 23:18:31 +03:00
Nikolai Kochetov
1693e46640 Do not remove inputs from maybe compiled DAG. 2023-03-31 19:03:20 +00:00
Alexander Tokmakov
9552b37414
Merge pull request #48267 from ClickHouse/fix_some_tests2 
Fix some tests
 2023-03-31 22:03:00 +03:00
Robert Schulze
1e347e626c
Merge pull request #48241 from ClickHouse/rs/sort-show-processlist 
Sort output of SHOW PROCESSLIST
 2023-03-31 18:09:11 +02:00
Alexander Tokmakov
e39498129c
Merge branch 'master' into sync_replica_lightweight 2023-03-31 18:17:08 +03:00
Antonio Andelic
1e3abc9e84 Add strict mode for KeeperMap 2023-03-31 14:24:32 +00:00
Robert Schulze
5d64841276
Merge pull request #48017 from ClickHouse/rs/show_columns 
MySQL compatibility: Implement `SHOW COLUMNS`
 2023-03-31 15:50:23 +02:00
Alexander Tokmakov
caf00b5968 Merge branch 'master' into sync_replica_lightweight 2023-03-31 14:52:55 +02:00
Alexander Tokmakov
f54fd15112 fix 2023-03-31 12:58:11 +02:00
Robert Schulze
8d91a9f4c2
Sort descendingly by elapsed time 2023-03-31 09:36:03 +00:00
Alexander Tokmakov
64b1f74a60 fix 2023-03-31 01:39:49 +02:00
pufit
dacdbe469e GRANT CURRENT GRANTS implementation 2023-03-30 18:15:08 -04:00
Alexander Tokmakov
d12bab3ce1 add zk retries for distributed ddl 2023-03-30 20:47:25 +02:00
Azat Khuzhin
edeeac84cf Fix incorrect ThreadPool usage after ThreadPool introspection 
```
$ gg 'ThreadPool[^()]([A-Za-z_]\+,' src/
src/Interpreters/Context.cpp:        shared->load_marks_threadpool = std::make_unique<ThreadPool>(pool_size, pool_size, queue_size);
src/Interpreters/Context.cpp:        shared->prefetch_threadpool = std::make_unique<ThreadPool>(pool_size, pool_size, queue_size);
src/Interpreters/Context.cpp:        shared->threadpool_writer = std::make_unique<ThreadPool>(pool_size, pool_size, queue_size);
```

Fixes: #47880
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-03-30 20:08:38 +02:00
Robert Schulze
191f780223
Sort output of SHOW PROCESSLIST 
Follow-up to #48127
 2023-03-30 17:22:20 +00:00
Yakov Olkhovskiy
2ca77b13fe
Merge branch 'master' into imp-use-structure-from-insertion 2023-03-30 12:23:12 -04:00
Mikhail f. Shiryaev
9593ffc7cb
Determine the hosts order in SHOW CLUSTER query 2023-03-30 17:37:31 +02:00
kssenii
e2cbccfbc4 Merge remote-tracking branch 'upstream/master' into cache-better-locks 2023-03-30 17:33:46 +02:00
filimonov
fbb22348ea
Refactor reading the pool setting & from server config. (#48055) 
After #36425 there was a lot of confusions/problems with configuring pools - when the message was confusing, and settings need to be ajusted in several places.
See some examples in #44251, #43351, #47900, #46515.

The commit includes the following changes:
1) Introduced a unified mechanism for reading pool sizes from the configuration file(s). Previously, pool sizes were read from the Context.cpp with fallbacks to profiles, whereas main_config_reloader in Server.cpp read them directly without fallbacks.
2) Corrected the data type for background_merges_mutations_concurrency_ratio. It should be float instead of int.
3) Refactored the default values for settings. Previously, they were defined in multiple places throughout the codebase, but they are now defined in one place (or two, to be exact: Settings.h and ServerSettings.h).
4) Improved documentation, including the correct message in system.settings.

Additionally make the code more conform with #46550.
 2023-03-30 16:44:11 +02:00
Alexander Tokmakov
131395b00f
Merge pull request #48171 from aalexfvk/add_option_disable_on_cluster_queries 
Add allow_distributed_ddl_queries option to the cluster config
 2023-03-30 17:29:02 +03:00
kssenii
d94d08c18d Fix tests 2023-03-30 15:58:12 +02:00
Yakov Olkhovskiy
79a8bf7375
Merge branch 'master' into imp-use-structure-from-insertion 2023-03-30 09:12:10 -04:00
Nikolai Kochetov
b3d77c0c30
Merge pull request #48177 from ClickHouse/deprecate-explain-query-tree-with-disabled-analyzer 
Deprecate EXPLAIN QUERY TREE with disabled analyzer.
 2023-03-30 13:56:40 +02:00
Robert Schulze
b0473098c6
Merge branch 'master' into qc-compression 2023-03-30 10:55:42 +02:00
Robert Schulze
47fd1ee06d
Merge pull request #48127 from ClickHouse/rs/sort-show 
Sort output of SHOW <INFO> statements
 2023-03-30 10:54:23 +02:00
SmitaRKulkarni
d9c67a3380
Merge branch 'master' into 42192_Lower_parallel_parsing_threads_with_globs 2023-03-30 09:35:03 +02:00
Nikolay Degterinsky
870ee4b4f5
Merge pull request #47813 from FrankChen021/query_id 
Add `X-ClickHouse-Query-Id` to HTTP response when queries fail to execute
 2023-03-30 09:00:03 +02:00
Alexey Milovidov
e982fb9f1c
Merge pull request #47880 from azat/threadpool-introspection 
ThreadPool metrics introspection
 2023-03-30 01:27:31 +03:00
kssenii
245d04bb84 Fix changes from commit ba582dd, refactor a bit 2023-03-30 00:01:56 +02:00
Aleksei Filatov
0ac9dcd723 Add allow_distributed_ddl_queries option to the cluster config 2023-03-29 18:15:46 +03:00
Nikolai Kochetov
85795965c0 Deprecate EXPLAIN QUERY TREE with disabled analyzer. 2023-03-29 14:59:01 +00:00
Alexey Milovidov
cc345853e7
Merge pull request #47594 from ClickHouse/decimal256-various 
Add specializations for Decimal256 in various places
 2023-03-29 17:33:20 +03:00
Alexander Tokmakov
c5b6ed410d
Merge pull request #48130 from ClickHouse/support_undrop_table 
Merging "Support undrop table"
 2023-03-29 16:49:58 +03:00
kssenii
ba582dd74c Move assertions to a better place 2023-03-29 15:31:25 +02:00
Robert Schulze
b324d0ed5e
Merge branch 'master' into qc-compression 2023-03-29 15:09:22 +02:00
kssenii
4cf2862a0e Merge remote-tracking branch 'upstream/master' into cache-better-locks 2023-03-29 12:50:36 +02:00
Robert Schulze
d0f4c63d27
Fix tests 2023-03-29 10:30:40 +00:00
Azat Khuzhin
f38a7aeabe ThreadPool metrics introspection 
There are lots of thread pools and simple local-vs-global is not enough
already, it is good to know which one in particular uses threads.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-03-29 10:46:59 +02:00
save-my-heart
167757746f
Merge branch 'master' into throw_non_parametric_function 2023-03-29 16:15:11 +08:00
Yakov Olkhovskiy
211fa2117c clang wants it 2023-03-29 03:50:21 +00:00
Alexander Tokmakov
cfe0fb6571 fix 2023-03-29 03:31:39 +02:00
Alexander Tokmakov
53725bdea1 monor improvements 2023-03-28 23:47:45 +02:00
Robert Schulze
6f8a450805
Sort output of SHOW <INFO> statements 
Sorting is strictly speaking not necessary, but
1. sorted output is more user-friendly,
2. SQL currently does not allow to sort the output of SHOW <INFO>
   otherwise, e.g. SELECT * FROM (SHOW <INFO> ...) ORDER BY is rejected.
3. SQL tests can take advantage of that.
 2023-03-28 20:55:59 +00:00
Alexander Tokmakov
614f8b313e
Merge pull request #47856 from Algunenano/zk_inject_timeout 
Allow injecting timeout errors on Keeper
 2023-03-28 23:40:51 +03:00
kssenii
c9ba1e7a71 Move checks 2023-03-28 22:14:45 +02:00
Robert Schulze
6c84eabb79
Fix stylecheck 2023-03-28 20:07:26 +00:00
Robert Schulze
e743f840f0
Fix taipos 2023-03-28 20:05:17 +00:00
Alexander Tokmakov
a1076005c7 Merge branch 'master' into support_undrop_table 2023-03-28 22:03:31 +02:00
Robert Schulze
202f52dc3a
Implement SHOW COLUMNS 
Modeled after (*)

Fixes #46437

(*) https://dev.mysql.com/doc/refman/8.0/en/show-columns.html
 2023-03-28 18:04:22 +00:00
Yakov Olkhovskiy
a03bf8568a implement use_structure_from_insertion_table_in_table_functions=auto 2023-03-28 17:03:35 +00:00
save-my-heart
cea631a4c2 throw exception while non-parametric functions having parameters 2023-03-28 23:24:07 +08:00
Sema Checherinda
b774310dc9 keep query id for logging when optimize query 2023-03-28 16:44:47 +02:00
Igor Nikonov
259df04415 Merge remote-tracking branch 'origin/master' into decimal256-various 2023-03-28 13:36:53 +00:00
kssenii
b541ec485d Fix 2023-03-28 11:55:55 +02:00
Kseniia Sumarokova
62c6aea45b
Merge pull request #47975 from MikhailBurdukov/mburdukov_ignore_inacc_tables 
Skip materialized view checking if source table does not exist
 2023-03-28 11:29:11 +02:00
SmitaRKulkarni
98999c2afb
Merge pull request #48065 from ClickHouse/Support_parameterized_view_with_cte 
Support for cte in parameterized views
 2023-03-28 11:18:16 +02:00
Antonio Andelic
0b5fd2140a Merge branch 'master' into cnf-new-analyzer 2023-03-28 07:57:12 +00:00
Antonio Andelic
d2c1d16e29 Merge branch 'master' into custom-key-new-analyzer 2023-03-28 07:24:29 +00:00
Antonio Andelic
4aa8c5fe49 Merge branch 'master' into alternative-keeper-configs 2023-03-28 07:23:24 +00:00
Alexander Tokmakov
b5fe1ada0b more options for sync replica 2023-03-28 01:39:36 +02:00
xiedeyantu
62087c3f09 fix 2023-03-28 07:27:13 +08:00
Alexey Milovidov
5d0e34d2a7
Merge pull request #47953 from ClickHouse/Avogar-patch-2 
Fix tsan error lock-order-inversion
 2023-03-28 01:10:50 +03:00
MikhailBurdukov
c296c2e299 Review changes 2023-03-27 18:34:12 +00:00
Raúl Marín
ff209db129
Merge branch 'master' into zk_inject_timeout 2023-03-27 19:46:10 +02:00
kssenii
667905f645 Fix duplicate include 2023-03-27 19:24:46 +02:00
kssenii
daa3d913c0 Fix 2023-03-27 19:06:49 +02:00
xiedeyantu
9382c6ffdc better 2023-03-27 23:51:35 +08:00
Smita Kulkarni
cb04c6301c Support for cte in parameterized views
Implementation: 
* Updated to allow query parameters while evaluating scalar subqueries.
Testing:
* Added test case with cute for parameterized view.
 2023-03-27 16:30:53 +02:00
Sema Checherinda
a6ab33a906 no use query, but storage context 2023-03-27 16:30:32 +02:00
xiedeyantu
5036d19af3 better 2023-03-27 22:16:37 +08:00
xiedeyantu
5a18e0d5a5 support undrop table 2023-03-27 22:16:36 +08:00
Antonio Andelic
fa8ea85f3d Make custom key work with new analyzer 2023-03-27 13:39:33 +00:00
avogar
64db4c478b Use one map 2023-03-27 13:19:45 +00:00
Raúl Marín
714b54b322 Reimplement enable_fault_injections_during_startup 2023-03-27 15:06:46 +02:00
kssenii
569a1508eb Fix 2023-03-27 14:05:12 +02:00
Nikolay Degterinsky
227425968f
Merge branch 'master' into query_id 2023-03-27 13:41:42 +02:00
Antonio Andelic
86b40a1b79 address PR review 2023-03-27 10:03:40 +00:00
Antonio Andelic
93f5920e02
Merge branch 'master' into alternative-keeper-configs 2023-03-27 10:00:21 +02:00
Antonio Andelic
e4a78a982f Merge branch 'master' into cnf-new-analyzer 2023-03-27 07:43:21 +00:00
Alexey Milovidov
b6892f53fc
Merge pull request #47724 from ClickHouse/rs/qc-better-cfg-name 
Rename cfg parameter query_cache.size to query_cache.max_size
 2023-03-27 00:36:24 +03:00
kssenii
b808c35480 Fix style check 2023-03-26 23:17:04 +02:00
kssenii
f5fa43b79b Remove redundant 2023-03-26 22:33:59 +02:00
kssenii
1adef76cbd Better comment 2023-03-26 22:10:14 +02:00
kssenii
e6e71dc832 Do not take KeyGuard::Lock under CacheMetadataGuard::Lock to make metadata lock truly lightweight 2023-03-26 22:02:51 +02:00
kssenii
88f631b297 Review fixes, perform delayed removal in background 2023-03-26 16:53:33 +02:00
kssenii
85160f7265 Slightly less pressure on debug server 2023-03-25 22:22:01 +01:00
kssenii
9531aa0b79 Better 2023-03-25 18:25:10 +01:00
kssenii
b8e958df07 Review fix 2023-03-25 18:10:14 +01:00
kssenii
b167edc1e6 Fix data race because of incorrect destruction order 2023-03-25 18:05:11 +01:00
Nikolai Kochetov
327674f56d
Merge pull request #46537 from ClickHouse/aggregate-projections-analysis-query-plan 
Projections analysis from query plan
 2023-03-25 13:23:30 +01:00
Yakov Olkhovskiy
07502600f7 clang wants it :\ 2023-03-25 05:15:10 +00:00
Yakov Olkhovskiy
a4e2d09001 without schema inference from actual data 2023-03-24 21:58:23 +00:00
Yakov Olkhovskiy
1108a299a6
Merge branch 'master' into imp-use-structure-from-insertion 2023-03-24 16:36:12 -04:00
kssenii
47d91b63ae Fix 2023-03-24 20:34:42 +01:00
avogar
d00587202d Make better 2023-03-24 19:25:07 +00:00
Maksim Kita
5cb2d30563
Merge pull request #47316 from ClickHouse/vdimir/transform_external_query_analyzer 
Support transformQueryForExternalDatabase for analyzer
 2023-03-24 17:53:00 +01:00
kssenii
9dc9f67f93 Get rid of metadata references 2023-03-24 17:18:41 +01:00
avogar
ee0fd39f2a Fix data-race 2023-03-24 15:20:19 +00:00
Nikolai Kochetov
a2182f2659
Merge pull request #47874 from amosbird/correct_exact_rows_before_limit 
Correct `exact_rows_before_limit` in some scenarios
 2023-03-24 15:09:42 +01:00
kssenii
0d89be20b0 Review fixes 2023-03-24 14:45:03 +01:00
Robert Schulze
0712627c05
Query cache: Fix config naming ambiguity 
Add 'max_' prefix to 'size' setting to make it more clear that the cache
consumes no space if not used.
 2023-03-24 12:52:09 +00:00
Kruglov Pavel
97592cfdfd
Merge branch 'master' into Avogar-patch-2 2023-03-24 13:44:28 +01:00
MikhailBurdukov
cc92eacb3e Merged several tests into one and rm unnecessary func 2023-03-24 11:51:09 +00:00
MikhailBurdukov
68118388e6 Rename opt key, added test and refactored code. 2023-03-24 08:23:22 +00:00
Dmitry Novik
3488a4d84b Improve file includes 2023-03-24 03:44:52 +01:00
Yakov Olkhovskiy
3e50ccdb45 fixed bug with names mapping, better structure propagation 2023-03-24 00:27:04 +00:00
Nikolai Kochetov
73e98de46d Merge branch 'master' into aggregate-projections-analysis-query-plan 2023-03-23 21:28:36 +01:00
Maksim Kita
24b9e5103f
Merge pull request #47748 from ClickHouse/revert-47721-revert-47622-analyzer-planner-fixes-before-enable-by-default 
Revert "Revert "Analyzer planner fixes before enable by default""
 2023-03-23 22:20:34 +03:00
Kruglov Pavel
9003b7d789
Fix tsan error lock-order-inversion 2023-03-23 20:14:32 +01:00
vdimir
c2a3679959
Add buildSelectQueryInfo to Planner/Utils, use in unit tests 2023-03-23 15:53:22 +00:00
Antonio Andelic
d6cbc5d05b Fix tests 2023-03-23 15:01:51 +00:00
Azat Khuzhin
2b439f079e
Make backup_threads/restore_threads server settings (#47881) 
Those settings can be applied only at start, so it is better to have
them in configuration file instead of user profile settings.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-03-23 15:44:15 +01:00
kssenii
fcd535124a Better 2023-03-23 14:00:14 +01:00
kssenii
3f1d0fa14c Simplify cache loading 2023-03-23 13:46:38 +01:00
kssenii
6dc08b2768 Review fixes 2023-03-23 13:02:16 +01:00
kssenii
b4837af20f Fix race 2023-03-23 12:21:58 +01:00
Antonio Andelic
a4d1cd514d Refactor 2023-03-23 08:58:56 +00:00
MikhailBurdukov
62c8eeb25c Ignoring inaccessible tables for attaching to the materilized view 2023-03-22 20:13:30 +00:00
vdimir
426f4ec233
Better transformQueryForExternalDatabase for analyzer 2023-03-22 16:58:34 +00:00
kssenii
5ee5e2c339 Remove fixme 2023-03-22 17:37:49 +01:00
kssenii
5b7f214ea9 Better names for some methods 2023-03-22 17:34:29 +01:00
Maksim Kita
f45dac99c2 Revert "Revert "Analyzer planner fixes before enable by default"" 2023-03-22 17:19:32 +01:00
kssenii
9b9cf13607 Add comment 2023-03-22 17:01:31 +01:00
kssenii
876fb55156 Remove redundant code 2023-03-22 16:51:30 +01:00
kssenii
c35deb8094 Review fixes 2023-03-22 16:49:33 +01:00
Amos Bird
02c5d1f364
Correct exact_rows_before_limit in all senarios 2023-03-22 23:26:31 +08:00
kssenii
419d9a4887 Fix typo from previous commit 2023-03-22 15:11:14 +01:00
Antonio Andelic
65b99ec6a7 Merge branch 'master' into alternative-keeper-configs 2023-03-22 12:22:57 +00:00
Frank Chen
532590773a Fix typo check 2023-03-22 17:46:09 +08:00
Frank Chen
c1927d8f3e Fix check style 2023-03-22 16:39:14 +08:00
Maksim Kita
4dc5a629c3
Merge pull request #47758 from ClickHouse/vdimir/comparsion_tuple_elimination_ast 
Add ComparisonTupleEliminationVisitor
 2023-03-22 11:22:25 +03:00
SmitaRKulkarni
464b166e91
Merge pull request #47725 from ClickHouse/46741_Parameterized_view_support_subquery 
Support for subquery in parameterized views
 2023-03-22 09:05:26 +01:00
vdimir
023d14a894 Support transformQueryForExternalDatabase for analyzer 2023-03-22 08:59:04 +01:00
Frank Chen
3e05f2c58a Improve comment 2023-03-22 14:35:58 +08:00
Frank Chen
3de73d03cc Improve the robustness 2023-03-22 14:31:16 +08:00
kssenii
da05e63f2e Simplify code 2023-03-21 23:14:25 +01:00
kssenii
2376f3a298 Review fixes 2023-03-21 22:50:16 +01:00
Alexander Tokmakov
0989dd837a
Merge pull request #47802 from ClickHouse/fix_some_tests 
Fix 993 and two other tests
 2023-03-21 22:20:06 +03:00
Smita Kulkarni
aa079efbb7 Addressed review comments 2023-03-21 18:29:26 +01:00
Igor Nikonov
d72c0def6e Improve search of original node name in ActionsDAG 2023-03-21 16:30:13 +00:00
vdimir
c25170381c
Better ComparisonTupleEliminationVisitor 2023-03-21 16:23:09 +00:00
vdimir
030ee3a525
Add ComparisonTupleEliminationVisitor 2023-03-21 16:11:06 +00:00
Alexander Tokmakov
9c4c7948e5
Update src/Interpreters/Session.cpp 
Co-authored-by: alesapin <alesapin@clickhouse.com>
 2023-03-21 17:39:45 +03:00
Alexander Tokmakov
be4884d07a
Update src/Interpreters/Session.cpp 
Co-authored-by: alesapin <alesapin@clickhouse.com>
 2023-03-21 17:39:40 +03:00
Igor Nikonov
5e1c645483 Merge remote-tracking branch 'origin/master' into query-plan-update-sort-description 2023-03-21 14:25:07 +00:00
Alexander Tokmakov
17e1c6be8e fix race condition on session close 2023-03-21 15:01:39 +01:00
Kseniia Sumarokova
a9bcd022d5
Merge pull request #46241 from kssenii/named-collections-granular-access 
Allow separate grants for every named collection
 2023-03-21 12:27:53 +01:00
Vladimir C
ab1105a5a6
Merge pull request #47685 from ClickHouse/vdimir/issue_47533 2023-03-21 11:41:00 +01:00
Frank Chen
837638e1c1 Fix style 2023-03-21 15:27:13 +08:00
Frank Chen
91a34fa627 Set query id in case of exceptions during query execution 2023-03-21 14:10:01 +08:00
Robert Schulze
595796e63d
Merge branch 'master' into rs/more-llvm-16-preparation 2023-03-20 21:16:27 +01:00
Robert Schulze
d8493780b2
Query cache: Enable compression and squashing of result blocks 
ClickHouse reads table data in blocks of 'max_block_size' rows. Due to
filtering, aggregation, etc., result blocks are typically much smaller
than 'max_block_size' but there are also cases where they are much
bigger. Setting 'query_cache_squash_partial_results' (enabled by
default) now controls if result blocks are squashed (if they are tiny)
or split (if they are large) into blocks of 'max_block_size' size before
insertion into the query result cache. This reduces performance of
writes into the query cache but improves compressability of cache
entries and provides more natural block granularity when query results
are later served from the query cache.

Entries in the query cache are now also compressed by default. This
reduces the overall memory consumption at the cost of slower writes into
/ reads from the query cache. To disable compression, use setting
'query_cache_compress_entries'.
 2023-03-20 20:11:41 +00:00
Robert Schulze
82a4b307ae
Merge branch 'master' into rs/qc-cachebase 2023-03-20 20:44:34 +01:00
Anton Popov
158131053b
Merge pull request #47688 from ucasfl/fix-limit-offset 
Fix limit offset
 2023-03-20 18:47:41 +01:00
Robert Schulze
3b7f929001
Merge branch 'master' into rs/qc-cachebase 2023-03-20 17:08:47 +01:00
kssenii
75624c52f7 Merge remote-tracking branch 'upstream/master' into named-collections-granular-access 2023-03-20 16:38:14 +01:00
vdimir
19fb88c2c1
Simple fix logical error in evaluate constant expression 2023-03-20 15:10:50 +00:00
Robert Schulze
5b036a1a3b
More preparation for libcxx(abi), llvm, clang-tidy 16 (follow-up to #47722) 2023-03-20 12:55:03 +00:00
vdimir
9b8d20e443
Revert better fix logical error in evaluate constant expression 2023-03-20 12:42:09 +00:00
vdimir
a78b817e6f
Fix logical error in evaluate constant expression 2023-03-20 12:35:54 +00:00
kssenii
019de827a1 Fix 2023-03-20 13:23:24 +01:00
Alexey Milovidov
4a44dafdee Merge branch 'master' into decimal256-various 2023-03-20 03:30:14 +01:00
Alexey Milovidov
ddf29b69f9
Merge branch 'master' into fuzzer-of-data-formats 2023-03-20 03:26:51 +03:00
Alexey Milovidov
e788bf0712
Merge pull request #47721 from ClickHouse/revert-47622-analyzer-planner-fixes-before-enable-by-default 
Revert "Analyzer planner fixes before enable by default"
 2023-03-20 03:24:03 +03:00
Smita Kulkarni
87cb2e1629 Support for subquery in parameterized views
Implementation: 
* Updated to pass the parameter is_create_parameterized_view to subquery processing.
Testing:
* Added test case with subquery for parameterized view.
 2023-03-19 19:41:19 +01:00
Robert Schulze
0e01e912fe
Preparation for libcxx(abi), llvm, clang-tidy 16 2023-03-19 17:25:41 +00:00
Alexey Milovidov
ef5e8462da
Revert "Analyzer planner fixes before enable by default" 2023-03-19 19:25:37 +03:00
Alexey Milovidov
7f54aab145 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fuzzer-of-data-formats 2023-03-19 16:57:35 +01:00
Robert Schulze
c4664c70a1
Merge branch 'master' into rs/qc-cachebase 2023-03-19 15:23:24 +01:00
Alexey Milovidov
3655667188 Make the code in Join less disgusting 2023-03-19 07:35:56 +01:00
Alexey Milovidov
0ec04cca5e Make the code in Join less disgusting 2023-03-19 07:32:29 +01:00
Alexey Milovidov
8fdbc5409c Make the code in Join less disgusting 2023-03-19 07:31:18 +01:00
Alexey Milovidov
100089a76c Make the code in Join less disgusting 2023-03-19 07:17:59 +01:00
Alexey Milovidov
2a077f11f6 Merge branch 'master' into fuzzer-of-data-formats 2023-03-19 01:07:31 +01:00
Ongkong
d9c7bc1859
Fix ASOF LEFT JOIN performance degradation (#47544) 2023-03-18 23:53:00 +01:00
Alexey Milovidov
b97154263d
Merge pull request #47703 from ClickHouse/add-style-check-for-dereference-after-cast 
Add a style check for unsafe code
 2023-03-18 22:07:47 +03:00
Alexander Tokmakov
f1df91cd09
Merge pull request #47659 from ClickHouse/fix_993 
Fixes for 993 and friends
 2023-03-18 14:46:43 +03:00
Maksim Kita
5187138510
Merge pull request #47622 from kitaisreal/analyzer-planner-fixes-before-enable-by-default 
Analyzer planner fixes before enable by default
 2023-03-18 13:11:40 +03:00
Alexey Milovidov
aea421cc9b Add a style check for unsafe code 2023-03-18 03:29:14 +01:00
Sema Checherinda
0b641fcead
Merge pull request #47564 from CheSema/remove-redundant 
remove counters for threads, fix negative counters
 2023-03-18 02:23:52 +01:00
Alexey Milovidov
26d17fe560 Merge branch 'master' of github.com:ClickHouse/ClickHouse into decimal256-various 2023-03-17 22:15:16 +01:00
Alexey Milovidov
c11915d35b Merge branch 'fix-bson-2' of github.com:Avogar/ClickHouse into fuzzer-of-data-formats 2023-03-17 22:05:46 +01:00
vdimir
68da4f713e
Real better fix logical error in evaluate constant expression 2023-03-17 18:38:47 +00:00
Alexander Tokmakov
d11aee2b0c
Merge branch 'master' into fix_993 2023-03-17 21:28:23 +03:00
vdimir
dcf8314122
Better fix logical error in evaluate constant expression 2023-03-17 17:04:28 +00:00
vdimir
4930683aa8
Revert "Fix logical error in evaluate constant expression" 
This reverts commit 2958c5f0f1.
 2023-03-17 17:01:40 +00:00
flynn
868e86e9ed Fix limit offset 2023-03-17 16:27:24 +00:00
kssenii
19413f6228 Add assertions 2023-03-17 16:39:10 +01:00
vdimir
2958c5f0f1
Fix logical error in evaluate constant expression 2023-03-17 15:08:16 +00:00
Sema Checherinda
e8295be9be if no group then do attachInternalTextLogsQueue to the thread only 2023-03-17 15:56:30 +01:00
Antonio Andelic
79cff0a14b Merge branch 'master' into cnf-new-analyzer 2023-03-17 14:37:40 +00:00
Antonio Andelic
0fb9f9ffe6 Add support for substitute column 2023-03-17 13:38:01 +00:00
kssenii
a2977e373a Merge remote-tracking branch 'upstream/master' into cache-better-locks 2023-03-17 14:34:04 +01:00
Sema Checherinda
49feba9272
Merge pull request #47632 from ClickHouse/filling-transform-untangle 
FillingTransform: remove unnecessary indirection when accessing columns
 2023-03-17 12:40:53 +01:00
Sema Checherinda
e2af8f6ed6 add a comment, rename a field 2023-03-17 11:59:44 +01:00
Sergei Trifonov
1a84203c7f
Merge pull request #47656 from ClickHouse/background_pool_limit_metric 
Add background pools size metrics
 2023-03-17 11:49:53 +01:00
chen
60b7ad819d
Add system.marked_dropped_tables (#47364) 
* add system table marked_dropped_tables

* add test

* add test

* fix

* fix test

* fix style

* fix test

* Update 25400_marked_dropped_tables.sql

* Update 25400_marked_dropped_tables.sql

* Update 25400_marked_dropped_tables.sql

* Update 25400_marked_dropped_tables.sql

* Update 25400_marked_dropped_tables.sql

* fix

* fix test

* Update StorageSystemMarkedDroppedTables.cpp

* fix

* if table_mark_dropped.table is nullptr, engine set empty
 2023-03-17 13:48:26 +03:00
Sema Checherinda
df9e247d67 fix tidy build, fix test when Databasereplicated 2023-03-17 10:49:41 +01:00
Antonio Andelic
d6efe7fc21 Fix 2023-03-17 08:08:07 +00:00
Sergei Trifonov
2cbd91b852
Merge branch 'master' into background_pool_limit_metric 2023-03-16 23:23:42 +01:00
Igor Nikonov
dbbf20909a Merge remote-tracking branch 'origin/master' into query-plan-update-sort-description 2023-03-16 20:50:57 +00:00
Sema Checherinda
3c6deddd1d work with comments on PR 2023-03-16 19:55:58 +01:00
Alexey Milovidov
704cb54afe Merge branch 'master' of github.com:ClickHouse/ClickHouse into fuzzer-of-data-formats 2023-03-16 19:50:33 +01:00
robot-ch-test-poll
ff56d49ce2
Merge pull request #47647 from jorisgio/fix_quadratic_debug_code 
fix typo in HashJoin insertion that enables debug code in release build #46726
 2023-03-16 19:39:51 +01:00
Alexander Tokmakov
a72f0cae07
Merge pull request #46071 from arenadata/ADQM-639 
Add support of arbitrary engines for temporary tables
 2023-03-16 20:56:25 +03:00
Igor Nikonov
4904a9fb7a Create result columns as MutableColumns at the begining 
Use IColumn* to manipulate columns on specific positions in result columns
 2023-03-16 17:44:29 +00:00
serxa
3ad7194e31 add pool size metrics 2023-03-16 17:31:41 +00:00
Antonio Andelic
985a0285c7 Merge branch 'master' into cnf-new-analyzer 2023-03-16 16:00:51 +00:00
Antonio Andelic
e07a8e1fd2 Some fixes with tests 2023-03-16 15:59:48 +00:00
Alexander Tokmakov
8e36f883d3 add 'strict' mode for sync replica, fix 00993 2023-03-16 16:04:42 +01:00
Antonio Andelic
c7787a6652 Fix column resolution 2023-03-16 14:57:07 +00:00
Igor Nikonov
f5c8250f58 Merge remote-tracking branch 'origin/master' into query-plan-update-sort-description 2023-03-16 14:53:52 +00:00
Joris Giovannangeli
6c8fc4cd11
fix hashjoin debug code condition 2023-03-16 14:06:37 +01:00
Mike Kot
bf2670ddaf recalc rights after changing setting 2023-03-16 10:56:14 +00:00
Robert Schulze
7d7052350c
Merge branch 'master' into rs/qc-cachebase 2023-03-16 10:42:17 +01:00
Maksim Kita
558aa6c164
Merge pull request #47583 from kitaisreal/merge-tree-explain-prewhere-and-row-policy 
ReadFromMergeTree explain prewhere and row policy actions
 2023-03-16 12:31:34 +03:00
Antonio Andelic
0f6e4d3934 Start implementing constraint optimizer 2023-03-16 09:30:55 +00:00
Alexey Milovidov
92a5b81222 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fuzzer-of-data-formats 2023-03-15 23:59:16 +01:00
pufit
f4d9b4a888
Merge pull request #47086 from pkit/pkit/insert_http_body 
use http request body in predefined http handlers
 2023-03-15 17:41:05 -04:00
Sema Checherinda
67ac858a52 remove counters for threads, fix negative counters 2023-03-15 22:22:22 +01:00
Dmitry Novik
be40218a9a
Revert "Revert #46622 (test_async_insert_memory)" 2023-03-15 22:14:54 +01:00
Robert Schulze
1f9c84e747
Revert "Un-friend system view (no longer necessary)" 
This reverts commit b2aa9324ac.
 2023-03-15 16:53:01 +00:00
Salvatore Mesoraca
d7f4bc4c72
ActionsDAG: remove wrong optimization 
Replacing AND with a casto to UInt8 can change the condition.
e.g.
0x100 cast to UInt8 is 0, but it should be 1.
0.1 cast to UInt8 is 0, but it should be 1.

Basically we can't cast anything to UInt8 so we completely remove
this optimization.

Closes #47317
 2023-03-15 17:16:57 +01:00
Maksim Kita
c102adb728 Analyzer added PREWHERE support 2023-03-15 15:21:49 +01:00
Alexey Milovidov
bb6b775884 Merge branch 'master' into fuzzer-of-data-formats 2023-03-15 12:42:00 +01:00
Robert Schulze
b2aa9324ac
Un-friend system view (no longer necessary) 2023-03-15 11:03:42 +00:00
Robert Schulze
75ca2dd0e2
Merge remote-tracking branch 'origin/master' into rs/qc-cachebase 2023-03-15 10:55:53 +00:00
Alexey Milovidov
e952ecae8c Add Decimal256 to a lot of places 2023-03-14 22:10:52 +01:00
Maksim Kita
26ba62bb9e ReadFromMergeTree explain prewhere and row policy actions 2023-03-14 18:02:56 +01:00
Anton Popov
d2a8cd3ed4 fix performance regression 2023-03-14 14:51:28 +00:00
SmitaRKulkarni
52b6976822
Merge pull request #47495 from ClickHouse/Parameterized_view_bug_fix_47287_47247 
Parameterized view bug fix 47287 47247
 2023-03-14 14:33:44 +01:00
Adam Rutkowski
694ba01c78 Fix typo 2023-03-14 12:48:00 +01:00
Nikolai Kochetov
e8f42e5fb3 Fix aliases in analyzeAggregateProjection. Remove setting from test. 2023-03-14 11:26:35 +00:00
Alexander Tokmakov
5a1ee881f8
Merge pull request #47547 from ClickHouse/filter_too_frequent_logs 
Hide too noisy log messages, fix some tests
 2023-03-14 13:53:21 +03:00
Nikolai Kochetov
396e1b45a4
Merge pull request #47433 from ClickHouse/apply-settings-for-explain-earlier 
Apply settings for EXPLAIN earlier (in the same way we do for SELECT).
 2023-03-14 11:52:20 +01:00
Nikolai Kochetov
0298a96d81
Merge pull request #47451 from ClickHouse/disable-logical-expression-optimizer-with-aliases 
Disable logical expression optimizer for expression with aliases.
 2023-03-14 11:51:24 +01:00
Nikolai Kochetov
be0ae6a238
Merge pull request #47537 from ClickHouse/lc_null_as_default 
Fix block structure mismatch for nullable LowCardinality column
 2023-03-14 11:45:39 +01:00
Robert Schulze
73afae2d3f
Introduce TTLCachePolicy 2023-03-14 09:45:20 +00:00
Alexander Tokmakov
ba6c6255a3 hide too noisy log messages, fix some tests 2023-03-14 00:23:36 +01:00
Alexey Milovidov
14647525f8 Merge branch 'fix-bson-bug' of github.com:Avogar/ClickHouse into fuzzer-of-data-formats 2023-03-13 22:45:00 +01:00
Nikolai Kochetov
669a92bae0 Merge branch 'master' into aggregate-projections-analysis-query-plan 2023-03-13 19:55:49 +01:00
Alexey Milovidov
741acf18c3
Merge branch 'master' into disable-logical-expression-optimizer-with-aliases 2023-03-13 21:41:55 +03:00
Nikolai Kochetov
650427614f Fix block structure mismatch for nullable LowCardinality column with default expression. 2023-03-13 17:57:07 +00:00
Roman Vasin
36c639ed2f Fix grants hierarchy for temporary tables and comment about default engine 2023-03-13 16:39:15 +00:00
Igor Nikonov
14498c1d2b Merge remote-tracking branch 'origin/master' into query-plan-update-sort-description 2023-03-13 16:33:42 +00:00
Alexander Tokmakov
ee6c18cbc6
Better error after failed Ordinary-to-Atomic conversion (#47487) 
* better error on failed Ordinary-to-Atomic conversion

* fix test

* Update loadMetadata.cpp
 2023-03-13 19:13:49 +03:00
Robert Schulze
657aa65446
Cleanup: Untangle CacheBase's constructors 
This prepares for the custom TTLCachePolicy which users should not be
able to configure explicitly.
 2023-03-13 15:11:12 +00:00
Nikolai Kochetov
ceeb36b596
Merge branch 'master' into disable-logical-expression-optimizer-with-aliases 2023-03-13 15:12:02 +01:00
Vladimir C
9cb018545c
Merge pull request #47499 from FrankChen021/span_kind 2023-03-13 11:35:03 +01:00
Alexey Milovidov
43b938d303 Update the fuzzer 2023-03-13 05:21:48 +01:00
Alexey Milovidov
f33b651686 Add fuzzer for data formats 2023-03-13 04:51:50 +01:00
Alexey Milovidov
b6169552b0 Merge branch 'master' into fix-query-parameters 2023-03-12 18:59:25 +01:00
Frank Chen
6812e493dc Set SpanKind for DDL 2023-03-12 21:31:24 +08:00
Frank Chen
dfcb9c9431 Add SpanKind 2023-03-12 21:30:29 +08:00
Nikolai Kochetov
28c2ac6bce Fix test. 2023-03-12 11:13:44 +00:00
Nikolai Kochetov
861b0397fa Add a comment. 2023-03-12 11:06:29 +00:00
Alexander Tokmakov
2c65f67201
Merge pull request #47476 from ClickHouse/revert_46622 
Revert #46622 (test_async_insert_memory)
 2023-03-12 14:05:29 +03:00
Smita Kulkarni
39a146ab87 Merge branch 'master' into Parameterized_view_bug_fix_47287_47247 2023-03-12 11:05:28 +01:00
Smita Kulkarni
e85096b444 Updated variable name to fix build & call to getSampleBlockForColumns. Added a test for substring parameter name. 2023-03-12 11:00:17 +01:00
robot-ch-test-poll1
bc39f3e4d9
Merge pull request #47473 from ucasfl/explain-graph 
Fix explain graph with projection
 2023-03-12 01:31:04 +01:00
Smita Kulkarni
5b11d72ce4 In parameterized view, moved parameter values to SelectQueryInfo from StorageView as it can be used by multiple queries and updated column name check to avoid issues with parameter name being substring of column name. 2023-03-11 20:39:43 +01:00
Alexey Milovidov
4cfc040829 Fix parameterized queries 2023-03-11 20:16:06 +01:00
Maksim Kita
114d30d2bb
Merge pull request #47383 from kitaisreal/analyzer-planner-fixes-before-enable-by-default 
Analyzer planner fixes before enable by default
 2023-03-11 22:09:04 +03:00
Alexander Tokmakov
0359b3e336 Revert "Merge pull request #46622 from ClickHouse/async-insert-memory-fix" 
This reverts commit 67469ad46b, reversing
changes made to 678e4250cd.
 2023-03-11 17:01:10 +01:00
flynn
530c9ae490 revert 2023-03-11 15:43:19 +00:00
Maksim Kita
0358cb36d8 Fixed tests 2023-03-11 11:51:54 +01:00
Alexey Milovidov
a5c8f23f69 Remove a feature 2023-03-10 23:33:56 +01:00
Nikolai Kochetov
815c5aa87e
Merge branch 'master' into apply-settings-for-explain-earlier 2023-03-10 21:19:07 +01:00
Nikolai Kochetov
aaecc233b2 Disable logical expression optimizer for expression with aliases. Never use it with optimize_min_equality_disjunction_chain_length=0 2023-03-10 20:14:35 +00:00
Nikolai Kochetov
d2c28fb555 Apply settings for explain subquery as well. 2023-03-10 18:29:13 +00:00
Nikolai Kochetov
f6ac225f98 Apply settings for EXPLAIN earlier (in the same way we do for SELECT). 2023-03-10 15:24:47 +00:00
Vladimir C
12480f60b5
Merge pull request #47068 from ClickHouse/vdimir/auto-join-cross 2023-03-10 16:12:46 +01:00
Sema Checherinda
1260f6910f
Merge pull request #47398 from CheSema/additional-asserts 
add checks for ptr
 2023-03-10 12:32:51 +01:00
Kseniia Sumarokova
7cbf77a178
Update LRUFileCachePriority.cpp 2023-03-09 19:55:58 +01:00
Alexander Tokmakov
9a95e7b4ee
Merge pull request #47312 from ClickHouse/fix_implicit_transactions 
Fix an assertion with implicit transactions in interserver mode
 2023-03-09 16:47:40 +03:00
Alexander Tokmakov
f8b4af27b2
Merge pull request #47365 from ClickHouse/supress_01111_in_upgrade_check 
Suppress expected errors from test 01111 in Upgrade check
 2023-03-09 16:46:30 +03:00
Sema Checherinda
7bf1b83414 add checks 2023-03-09 12:37:57 +01:00
Roman Vasin
f42f3ee655
Merge branch 'master' into ADQM-639 2023-03-09 09:48:33 +03:00
Azat Khuzhin
d7b5e36218
Merge branch 'master' into mv-ignore-errors 2023-03-08 22:13:05 +01:00
Igor Nikonov
c952886e66 Merge remote-tracking branch 'origin/master' into query-plan-update-sort-description 2023-03-08 18:09:37 +00:00
Antonio Andelic
a04b38db90
Merge pull request #45108 from ClickHouse/custom-key-parallel-replicas 
Add support for custom key in parallel replicas
 2023-03-08 17:46:11 +01:00
Alexander Tokmakov
38f9f08e1a
Merge pull request #47268 from myrrc/improvement/more-to-base-3 
use std::lerp, constexpr hex.h
 2023-03-08 19:07:34 +03:00
Alexander Tokmakov
debd69f03a fix an assertion with implicit transactions in interserver mode 2023-03-08 16:53:23 +01:00
Alexander Tokmakov
ecab007486
Merge pull request #47310 from ClickHouse/vdimir/fix_transaction_read_only 
Fix MergeTreeTransaction::isReadOnly
 2023-03-08 18:02:19 +03:00
Alexander Tokmakov
0fb537e880 suppress expected errors from test 01111 in Upgrade check 2023-03-08 15:27:43 +01:00
Kruglov Pavel
c2079e708b
Merge pull request #47161 from Avogar/fix-deadlock 
Fix possible deadlock in QueryStatus
 2023-03-08 14:05:30 +01:00
Maksim Kita
299b1d8fed
Merge pull request #45910 from ClickHouse/analyzer-group-by-use-nulls 
Support `group_by_use_nulls` setting in new analyzer
 2023-03-08 13:14:10 +03:00
Antonio Andelic
816a9c1099
Merge branch 'master' into custom-key-parallel-replicas 2023-03-08 11:06:30 +01:00
Igor Nikonov
cc5b97b624
Merge pull request #46997 from AndyBys/log-level-change 
Change level log in executeQuery
 2023-03-08 10:36:21 +01:00
Vladimir C
4f048ce535
Merge pull request #47153 from ClickHouse/vdimir/grace_hash_limit_race_45986 2023-03-08 10:18:32 +01:00
Mike Kot
9920a52c51 use std::lerp, constexpr hex.h 2023-03-07 22:50:17 +00:00
Igor Nikonov
3f7dd78c9b Merge remote-tracking branch 'origin/master' into query-plan-update-sort-description 2023-03-07 22:45:31 +00:00
Igor Nikonov
6f2851ef70 Update FilterStep 2023-03-07 22:16:22 +00:00
Alexander Tokmakov
ffd55d951d
Merge branch 'master' into followup_46681 2023-03-07 23:38:06 +03:00
vdimir
86410a7a3f
Fix MergeTreeTransaction::isReadOnly 2023-03-07 16:16:51 +00:00
Dmitry Novik
13f1e5b022 Merge remote-tracking branch 'origin/master' into analyzer-group-by-use-nulls 2023-03-07 16:16:48 +00:00
Nikolai Kochetov
0da310c8dc
Update ProcessList.cpp 2023-03-07 15:30:40 +01:00
Alexander Tokmakov
7ce20f5cd2 fix tests 2023-03-07 14:25:28 +01:00
Antonio Andelic
f408f750eb Disable parallel replicas for joins 2023-03-07 11:24:46 +00:00
Antonio Andelic
2ae0bceb2b Address PR comments 2023-03-07 10:56:11 +00:00
Antonio Andelic
35c15e6ef8 Merge branch 'master' into custom-key-parallel-replicas 2023-03-07 09:37:38 +00:00
Igor Nikonov
838ff88abe
Merge branch 'master' into log-level-change 2023-03-06 18:00:49 +01:00
Roman Vasin
cf85915466 Refactor grants logic, create test for grants, update docs 2023-03-06 16:37:41 +00:00
Mike Kot
4bc443f3c7 initial solution 2023-03-06 19:35:00 +03:00
Vladimir C
3076e92980
Apply suggestions from code review 
Co-authored-by: Igor Nikonov <954088+devcrafter@users.noreply.github.com>
 2023-03-06 16:56:02 +01:00
Kruglov Pavel
e4751f95e1
Fix typo 2023-03-06 14:56:05 +01:00
Mike Kot
1fca58b694
Merge branch 'master' into feature/show-secrets-option 2023-03-06 15:46:54 +03:00
Kruglov Pavel
aa776d00fe
Use executors snapshot 2023-03-06 13:24:36 +01:00
kssenii
b4e492c78c Fix stress test 2023-03-06 12:56:16 +01:00
Roman Vasin
7dc0f8705c
Merge branch 'master' into ADQM-639 2023-03-06 13:05:47 +03:00
Roman Vasin
95a7e11a47 Merge branch 'master' of github.com:ClickHouse/ClickHouse into ADQM-639 2023-03-06 09:11:20 +00:00
Vladimir C
1455e7602d
Merge pull request #47154 from azat/prewhere-columns-fix 2023-03-06 10:03:31 +01:00
Roman Vasin
b5bb2eb3dc Add new grant CREATE ARBITRARY TEMPORARY TABLE 2023-03-06 07:20:05 +00:00
kssenii
623e46646d Fix stress test 2023-03-05 22:50:55 +01:00
Anton Popov
6f3e4d4137
Merge pull request #46118 from CurtizJ/fix-issues-with-sparse 
Randomize setting `ratio_of_defaults_for_sparse_serialization`
 2023-03-05 22:28:18 +01:00
kssenii
608f5b17b6 Fix typos check 2023-03-05 13:17:17 +01:00
Alexander Tokmakov
08ce7b031e release shared ptrs after finishing a transaction 2023-03-04 22:07:59 +01:00
Alexey Milovidov
241fc7cadd
Merge branch 'master' into fix-deadlock 2023-03-04 12:10:59 +03:00
Alexey Milovidov
694f5eb0a8
Update ProcessList.cpp 2023-03-04 12:10:27 +03:00
Alexander Tokmakov
082194a755
Merge pull request #47175 from ClickHouse/correct_fatal_handling 
More correct handling of fatal errors
 2023-03-04 00:38:00 +03:00
Sema Checherinda
85178c9609
Merge pull request #47102 from CheSema/merge-mutate-do-thread-group 
do flushUntrackedMemory when context switches
 2023-03-03 20:23:25 +01:00
vdimir
a0f5756751
Fix DelayedJoinedBlocksWorkerTransform for grace hash join 2023-03-03 16:30:01 +00:00
kssenii
7b369e516c Fix stress test 2023-03-03 17:20:27 +01:00
Antonio Andelic
737cf8e149 Better 2023-03-03 15:14:49 +00:00
Alexander Tokmakov
cadaf06829
Merge pull request #46681 from ClickHouse/fix_insert_cancellation_in_native_protocol 
Fix queries cancellation when a client dies
 2023-03-03 16:27:20 +03:00
avogar
221ac4a1e5 Better 2023-03-03 13:23:44 +00:00
Alexander Tokmakov
b1a288d271
Merge branch 'master' into correct_fatal_handling 2023-03-03 14:50:07 +03:00
vdimir
db2ffc109c
Add comment to GrachHashJoin::current_bucket_mutex 2023-03-03 10:17:34 +00:00
vdimir
38d157a850
Fix race in grace hash join with limit 2023-03-03 10:13:38 +00:00
Alexander Tokmakov
619b282060 more correct handling of fatal errors 2023-03-03 01:22:04 +01:00
LiuNeng
d4c5ab9dcd
Optimize one nullable key aggregate performance (#45772) 2023-03-02 21:01:52 +01:00
Salvatore Mesoraca
81b30021db
ActionsDAG: do not change result of and() during optimization - part 2 (#47028) 2023-03-02 20:48:13 +01:00
Maksim Kita
3cd88003dd
Merge pull request #47101 from kitaisreal/analyzer-planner-fixes-before-enable-by-default 
Analyzer Planner fixes before enable by default
 2023-03-02 22:16:39 +03:00
Sema Checherinda
a6c2473518 do flushUntrackedMemory when context swith 2023-03-02 19:21:03 +01:00
kssenii
0c4bb3c80f Merge remote-tracking branch 'upstream/master' into named-collections-granular-access 2023-03-02 19:08:29 +01:00
Azat Khuzhin
167e4903a8 Fix concrete columns PREWHERE support 
This is the fix for the IStorage::supportedPrewhereColumns() API.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-03-02 18:51:23 +01:00
Alexander Tokmakov
c518f3690e Merge branch 'master' into fix_insert_cancellation_in_native_protocol 2023-03-02 18:24:08 +01:00
avogar
14351922e3 Fix possible deadlock in QueryStatus 2023-03-02 17:20:29 +00:00
Robert Schulze
af56646f63
Merge pull request #47139 from ClickHouse/rs/ctad 
Shorten some code with CTAD
 2023-03-02 17:22:36 +01:00
Antonio Andelic
01cf9c94f4 Merge branch 'master' into custom-key-parallel-replicas 2023-03-02 14:28:42 +00:00
Sema Checherinda
bd5d7f3f81
Merge pull request #47098 from CheSema/release-lambda-before 
release lambda resources before detaching thread group
 2023-03-02 15:28:18 +01:00
Robert Schulze
740aeaba1f
Apply some CTAD 2023-03-02 13:36:47 +00:00
Constantine Peresypkin
fdc6de2a27 use http request body in predefined http handlers 
adds a new "virtual" parameter `__request_body`
which can be used in http rules, see below

tremendously helps in producing arbitrary REST interfaces

for example:

```xml
<http_handlers>
  <rule>
    <methods>POST</methods>
    <url>/ingest</url>
    <handler>
      <type>predefined_query_handler</type>
      <query>INSERT INTO events(id, data) SELECT {id:UInt32}, {__request_body:String}</query>
    </handler>
  </rule>
</http_handlers>
```
 2023-03-02 12:51:48 +01:00
Alexander Gololobov
5870969837
Merge pull request #47109 from ClickHouse/enable_lwd 
Enable lightweight delete support by default
 2023-03-02 09:56:38 +01:00
Alexander Tokmakov
ad4a44df52 fix 2023-03-02 02:59:27 +01:00
kssenii
c272f4befb Fix lock order inversion 2023-03-01 21:40:28 +01:00
Robert Schulze
15fec805fb
Merge pull request #46950 from ClickHouse/rs/uninline-likePatternToRegexp 
Un-inline likePatternToRegexp()
 2023-03-01 21:38:40 +01:00
Sema Checherinda
76451745bc
Update threadPoolCallbackRunner.h 2023-03-01 20:56:38 +01:00
Anton Popov
c4a999ce29 Merge remote-tracking branch 'upstream/master' into HEAD 2023-03-01 19:33:16 +00:00
Alexander Gololobov
f64d08bd5c Enable lightweight delete support by default 2023-03-01 19:35:55 +01:00
Sema Checherinda
242552b019
Update threadPoolCallbackRunner.h 2023-03-01 18:39:48 +01:00
Maksim Kita
d39be3ac9c Fixed tests 2023-03-01 18:05:07 +01:00
Maksim Kita
14e01566a0 Fixed tests 2023-03-01 18:05:07 +01:00
Maksim Kita
51ee007e01 Fixed tests 2023-03-01 18:05:07 +01:00
Maksim Kita
54b704254d Analyzer support InterpreterCreateQuery 2023-03-01 18:03:41 +01:00
Maksim Kita
f1093716f0 Analyzer MutationsInterpreter fix 2023-03-01 18:03:41 +01:00
Sema Checherinda
c59220274b release lambda resources before detaching thread group 2023-03-01 17:53:48 +01:00
kssenii
04557b9678 Fix race 2023-03-01 14:42:41 +01:00
Alexander Tokmakov
a97e15e36f Merge branch 'master' into fix_insert_cancellation_in_native_protocol 2023-03-01 14:26:41 +01:00
vdimir
98004eec6b
Fix NOT_IMPLEMENTED error with CROSS JOIN and algorithm = auto 2023-03-01 13:08:24 +00:00
Yakov Olkhovskiy
e800557743
Merge pull request #46705 from canhld94/ch_fix_aggregate_arithmetic 
Fix arithmetic operations in aggregate optimization
 2023-03-01 00:49:34 -05:00
Dmitry Novik
54680b1a0a Merge remote-tracking branch 'origin/master' into analyzer-group-by-use-nulls 2023-03-01 01:08:17 +00:00
AndyB
5fb1f20882 LOG_DEBUG over LOG_INFO 2023-02-27 23:16:34 +00:00
Robert Schulze
35f4b42608
Move likePatternToRegexp from Functions/ to Common/ 2023-02-27 16:41:15 +00:00
kssenii
03bb66b9a1 Fix style check 2023-02-27 17:13:33 +01:00
kssenii
53f521ef1c Review fixes 2023-02-27 17:00:46 +01:00
Mike Kot
c799bd094b
Merge branch 'master' into feature/show-secrets-option 2023-02-27 18:43:14 +03:00
avogar
12a9ff36b2 Better exception messages when schema_inference_hints is ill-formatted 2023-02-27 15:20:56 +00:00
Anton Popov
caa1d22759
Merge branch 'master' into fix-issues-with-sparse 2023-02-27 15:25:19 +01:00
kssenii
5418dd655e Merge remote-tracking branch 'upstream/master' into cache-better-locks 2023-02-27 14:35:30 +01:00
Robert Schulze
5c8edcc2e7
Merge pull request #46940 from ClickHouse/rs/sizes-of-arrays-dont-match 
Typo: SIZES_OF_ARRAYS_DOESNT_MATCH --> SIZES_OF_ARRAYS_DONT_MATCH
 2023-02-27 14:33:09 +01:00
Mike Kot
62acc7a6cf setting and some docs 2023-02-27 13:18:21 +00:00
Nikolai Kochetov
3392b96cc3
Merge branch 'master' into aggregate-projections-analysis-query-plan 2023-02-27 14:07:04 +01:00
Sema Checherinda
29a0d766a0
Merge pull request #46886 from azat/async-metrics-intervals 
Add new metrics to system.asynchronous_metrics
 2023-02-27 11:25:38 +01:00
Robert Schulze
22d09caea2
SIZES_OF_ARRAYS_DOESN_MATCH --> SIZES_OF_ARRAYS_DONT_MATCH 2023-02-27 08:31:40 +00:00
Duc Canh Le
eba00f5094
Merge branch 'master' into ch_fix_aggregate_arithmetic 2023-02-27 09:44:40 +08:00