thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-26 01:22:04 +00:00
Code Issues Packages Projects Releases Wiki Activity
138,469 Commits 9,175 Branches 1,781 Tags 2.1 GiB
05792ee9ca
Commit Graph

138469 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Azat Khuzhin
05792ee9ca Make 02980_dist_insert_readonly_replica test more stable (by using round_robin LB) 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-03-26 11:34:43 +01:00
Azat Khuzhin
0900c4af60 Add comments for 02980_dist_insert_readonly_replica 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-03-26 11:31:48 +01:00
Azat Khuzhin
3481fd5191 Fix settings history for distributed_insert_skip_read_only_replicas 
CI: https://s3.amazonaws.com/clickhouse-test-reports/59176/fa0c47a42f4187e8284e19d1cd008a0a76c38caf/fast_test.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-03-26 11:25:28 +01:00
Azat Khuzhin
a90d64abf3 Cleanup test 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-03-26 11:24:59 +01:00
Azat Khuzhin
1bb9cffb9b Remove distributed_insert_skip_read_only_replicas from settings history 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-03-26 11:24:59 +01:00
Azat Khuzhin
f86bb1e9e9 Rename to DistributedConnectionSkipReadOnlyReplica 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-03-26 11:24:59 +01:00
Azat Khuzhin
ac882c1e70 Simplify condition in PoolWithFailoverBase 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-03-26 11:24:59 +01:00
Azat Khuzhin
c7b919b19e Replace distributed_insert_replicas_preferences with distributed_insert_skip_read_only_replicas 
v2: fix test
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-03-26 11:24:57 +01:00
Azat Khuzhin
63f92b2c16 Add documentation for distributed_insert_replicas_preferences 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-03-26 11:24:16 +01:00
Azat Khuzhin
a19b27bd7c Revert extra changed lines 
That was the changes that looks OK for the initial patchset version, but
not now, after all review comments.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-03-26 11:24:16 +01:00
Azat Khuzhin
fe613ddd06 Convert distributed_insert_replicas_preferences into enum 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-03-26 11:24:14 +01:00
Azat Khuzhin
eb334d717a Remove superior check for empty pools 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-03-26 11:23:21 +01:00
Azat Khuzhin
dbdf080108 Remove insert argument for ConnectionPoolWithFailover 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-03-26 11:22:38 +01:00
Azat Khuzhin
d922bfb1b0 Introduce distributed_insert_prefer_non_readonly_replica setting 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-03-26 11:21:40 +01:00
Azat Khuzhin
0e99781686 Move insert flag from ConnectionEstablisher to TryResult 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-03-26 11:21:40 +01:00
Azat Khuzhin
a3c3bff5df tests: cover filtering out read-only replicas during INSERT into Distributed 
v2: replace without s3_plain disk
v3: add check for DistributedConnectionReadOnlyReplica
v4: set insert_keeper_max_retries=0
v5: do not set insert_keeper_max_retries=0
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-03-26 11:21:40 +01:00
Azat Khuzhin
5b872aba7b tests: adjust 02537_distributed_loosing_files_after_exception 
Now, since there is connection probing, the error changed from
UNKNOWN_TABLE to ALL_CONNECTION_TRIES_FAILED, though I'm not sure that
this good...

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-03-26 11:21:39 +01:00
Azat Khuzhin
b9469e2729 Do not try to INSERT into readonly replicas for Distributed engine 
Sometimes replica may be readonly for a long time, and this will make
some INSERT queries fail, but it does not make sense to INSERT into
readonly replica, so let's ignore them.

But note, that this will require to extend TableStatus (not extend, but
introduce new version), that will have is_readonly field.

Also before background INSERT into Distributed does not uses
getManyChecked() which means that they do not request TableStatus
packet, while now they would, though this is minor (just a note).

v2: Add a note about max_replica_delay_for_distributed_queries for INSERT
v3: Skip read-only replicas for async INSERT into Distributed
v4: Remove extra @insert parameter for ConnectionPool*::get*
    It make sense only when the table name had passed --
    ConnectionPoolWithFailover::getManyChecked()
v5: rebase on top LoggerPtr
v6: rebase
v7: rebase
v8: move TryResult::is_readonly into the end

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-03-26 11:21:38 +01:00
Azat Khuzhin
77de81f996 Simpler and less error prone PoolWithFailoverBase::TryResult::reset() 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-03-26 11:19:10 +01:00
Azat Khuzhin
b2945a5ad4 Mark Replicated table as readonly in case of static disk (read-only/write-once) 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-03-26 11:19:10 +01:00
Nikolai Kochetov
2f382ac8a8
Merge pull request #61787 from ClickHouse/fix-virtual-columns-storage-merge-analyzer 
Fix more tests with virtual columns in StorageMerge.
 2024-03-26 11:16:25 +01:00
Nikolai Kochetov
f2e9ea2417
Merge pull request #61875 from ClickHouse/try-to-fix-02901_parallel_replicas_rollup-with-analyzer 
Try to fix 02901_parallel_replicas_rollup with analyzer.
 2024-03-26 11:12:29 +01:00
vdimir
802d6a2dac
Merge pull request #59007 from ClickHouse/vdimir/using_alias_followup 
Analyzer: fixes for JOIN columns resolution
 2024-03-26 10:36:50 +01:00
Kseniia Sumarokova
fd8e34a0ba
Merge pull request #60452 from ClickHouse/revert-refert-of-broken-projections-handling 
Revert "Revert "Merge pull request #56864 from ClickHouse/broken-projections-better-handling""
 2024-03-26 10:34:48 +01:00
Alexey Milovidov
cc1ee02459
Merge pull request #61916 from ClickHouse/no-please 
No "please"
 2024-03-26 12:10:11 +03:00
Alexey Milovidov
ef397f9e37 Update changelog 2024-03-26 09:17:36 +01:00
Alexey Milovidov
6a225b4056
Merge pull request #61918 from ClickHouse/auto/v24.1.8.22-stable 
Update version_date.tsv and changelogs after v24.1.8.22-stable
 2024-03-26 11:07:00 +03:00
Alexey Milovidov
2222b6f444
Merge pull request #61917 from ClickHouse/auto/v23.12.6.19-stable 
Update version_date.tsv and changelogs after v23.12.6.19-stable
 2024-03-26 11:06:51 +03:00
robot-clickhouse
88665a1b5b Update version_date.tsv and changelogs after v24.1.8.22-stable 2024-03-26 08:05:23 +00:00
robot-clickhouse
6236d35ee7 Update version_date.tsv and changelogs after v23.12.6.19-stable 2024-03-26 08:03:44 +00:00
Alexey Milovidov
76ed7e40fe
Merge pull request #61866 from azat/pool-remove-AllocateNewBypassingPool 
Remove PoolBase::AllocateNewBypassingPool
 2024-03-26 11:02:44 +03:00
Alexey Milovidov
fb39589b95
Merge pull request #61915 from ClickHouse/auto/v23.8.12.13-lts 
Update version_date.tsv and changelogs after v23.8.12.13-lts
 2024-03-26 11:01:49 +03:00
Alexey Milovidov
f7fcd50894
Merge pull request #61914 from ClickHouse/auto/v23.3.22.3-lts 
Update version_date.tsv and changelogs after v23.3.22.3-lts
 2024-03-26 11:01:39 +03:00
Alexey Milovidov
9b052d059d No "please" 2024-03-26 09:00:20 +01:00
robot-clickhouse
bb83b17c6b Update version_date.tsv and changelogs after v23.8.12.13-lts 2024-03-26 07:55:23 +00:00
robot-clickhouse
c525436c76 Update version_date.tsv and changelogs after v23.3.22.3-lts 2024-03-26 07:53:46 +00:00
Alexey Milovidov
385f666172 Update Changelog 2024-03-26 08:30:47 +01:00
robot-ch-test-poll1
f9e67319b7
Merge pull request #61906 from ClickHouse/rfraposa-patch-2 
Modify cmake command for building clickhouse on MacOS
 2024-03-26 10:28:23 +04:00
Alexey Milovidov
83678bc014
Merge pull request #61909 from ClickHouse/changelog-24.3 
Changelog for 24.3
 2024-03-26 08:38:03 +03:00
Alexey Milovidov
2a820a14c5 Changelog for 24.3 2024-03-26 05:49:21 +01:00
Alexey Milovidov
2dca4678dd
Merge pull request #61903 from ClickHouse/move-kql-trash-in-its-place 
Move KQL trash where it is supposed to be
 2024-03-26 07:45:50 +03:00
Rich Raposa
12a619f388
Modify cmake command for building clickhouse on MacOS 
This seems subtle, but for some reason it makes a big difference. If you set the environment variables before running `cmake`, they get ignored. After many, many attempts I finally figured out this solution - which worked great on my Mac.
 2024-03-25 21:56:13 -06:00
Alexey Milovidov
b0c883ef15
Merge pull request #61879 from ClickHouse/add-test-fuzz 
Add test for  #57808
 2024-03-26 06:40:30 +03:00
Alexey Milovidov
94f1379677 Move KQL trash where it is supposed to be 2024-03-26 04:02:32 +01:00
pufit
cad66f3e68
Fix ALTER QUERY MODIFY SQL SECURITY (#61480) 2024-03-25 20:03:02 -04:00
Alexey Milovidov
7282c5dbf6
Merge pull request #61848 from ClickHouse/geodistance-double-precision 
Double precision of geoDistance if the arguments are Float64
 2024-03-26 02:58:07 +03:00
Max K
c7e4d97e5a
Merge pull request #61881 from ClickHouse/ci_prepare_for_merge_queue 
CI: merge queue support
 2024-03-25 22:12:02 +01:00
Yakov Olkhovskiy
6c4cd355e6
Merge pull request #61511 from jewelzqiu/existing-count 
Add docs for lwd-aware merge settings
 2024-03-25 16:59:58 -04:00
Max K
b4ed7ded9a
Merge pull request #61778 from ClickHouse/ci_disable_grpc_tests_on_arm 
CI: disable grpc tests on ARM
 2024-03-25 21:50:58 +01:00
Max K
6a852bfe71
Merge pull request #61877 from ClickHouse/ci_set_install_check_timeout 
CI: set timeout for install check
 2024-03-25 21:32:54 +01:00