Azat Khuzhin
aacf2a0838
Move ThreadGroupSwitcher to ThreadStatus.h (out from MergeTree code)
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-07 15:32:08 +02:00
Azat Khuzhin
5b2b20a0b0
Rename ThreadGroupStatus to ThreadGroup
...
There are methods like getThreadGroup() and ThreadGroupSwitcher class,
so seems that this is logical.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-07 15:31:48 +02:00
Sema Checherinda
554c928534
Merge branch 'master' into thead-group-for-merge
2023-04-05 21:09:38 +02:00
Sema Checherinda
b774310dc9
keep query id for logging when optimize query
2023-03-28 16:44:47 +02:00
Sema Checherinda
a6ab33a906
no use query, but storage context
2023-03-27 16:30:32 +02:00
Sema Checherinda
bc107c70fa
merge and mutation make thread group for setting memory trackers right
2023-03-24 19:53:16 +01:00
serxa
f3c12b8543
fix per-thread perf counters update
2023-03-22 13:51:07 +00:00
Sema Checherinda
e2af8f6ed6
add a comment, rename a field
2023-03-17 11:59:44 +01:00
Sema Checherinda
3c6deddd1d
work with comments on PR
2023-03-16 19:55:58 +01:00
Sema Checherinda
67ac858a52
remove counters for threads, fix negative counters
2023-03-15 22:22:22 +01:00
Sema Checherinda
a6c2473518
do flushUntrackedMemory when context swith
2023-03-02 19:21:03 +01:00
vdimir
1b715a3388
Allow scope override in ThreadStatus::attachProfileCountersScope
2023-02-14 14:11:13 +00:00
vdimir
4c1aeb7972
Use overload of PartLog::addNewPart with profile_events
2023-02-14 14:11:12 +00:00
vdimir
fa08f72bba
Move subthread_profile_events to ThreadStatus
2023-02-14 14:11:11 +00:00
vdimir
a228f7f419
[wip] ProfileCounters for each part
2023-02-14 14:11:09 +00:00
Sergei Trifonov
0fbfa17863
Merge branch 'master' into cancellable-mutex-integration
2023-01-23 12:44:09 +01:00
Azat Khuzhin
2a8f116c18
Forward declaration of ConcurrentBoundedQueue in ThreadStatus
...
ThreadStatus is the header that recomplies almost all ClickHouse
modules.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-01-21 16:02:09 +01:00
serxa
693489a8ad
review fixes
2023-01-12 15:51:04 +00:00
serxa
15bb127b01
replace every std::shared_mutex with DB::FastSharedMutex
2023-01-06 23:35:38 +00:00
Raúl Marín
4d3217cb18
Merge branch 'master' into perf_experiment
2022-11-24 10:32:12 +01:00
Azat Khuzhin
ccde92f855
Fix incorrect UserTimeMicroseconds/SystemTimeMicroseconds accounting
...
After #40732 it became possible that getrusage() (from detachQuery(),
from buildPushingToViewsChain()) will be called for incorrect thread,
and so when the difference will be calculated it will be simply garbage.
But actually the root of this problem is #25714 , after which it became
possible to have multiple ThreadStatus for one thread, and this is very
tricky (sigh).
Here are some other thoughts about it:
- Make ThreadStatus nested - decided that complexity does not worth it,
at least only for this case
- Move some members into ThreadGroupStatus - will break per-thread
statistics (and hence query_thread_log, BTW does somebody uses it?)
- Move some members into a separate structure
But decided to fix the issue w/o any refactoring, to make easy for
backport.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-18 21:10:43 +01:00
Raúl Marín
227af9a074
Optimizations around ThreadStatus
2022-10-13 21:49:21 +02:00
Alexey Milovidov
ec5a32f534
Make thread_ids unique
2022-10-08 02:05:36 +02:00
Alexey Milovidov
dbca269ec7
Merge pull request #40321 from azat/mem/untracked_memory_limit_increase
...
Remove ThreadStatus::untracked_memory_limit_increase
2022-09-04 04:42:24 +03:00
Azat Khuzhin
ec2e671d20
Remove ThreadStatus::untracked_memory_limit_increase
...
It looks useless nowadays, because operator new cannot throw
MEMORY_LIMIT_EXCEEDED today, and so any code that works on Exception is
likely safe.
Refs: #40249
Refs: #24483
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-08-22 13:26:18 +03:00
Frank Chen
a3b6ad2a65
Merge branch 'master' into tracing_context_propagation
2022-08-18 20:59:07 +08:00
Nikolai Kochetov
8e4c967fc9
Try to account untracked memory (per thread) more correctly.
2022-08-16 18:09:05 +02:00
Raúl Marín
11a274e990
Clean up constinit usage and add a comment
2022-08-11 13:27:53 +02:00
Raúl Marín
d7a545e30d
Try to optimize CurrentMemoryTracker alloc and free
2022-08-10 22:05:09 +02:00
Frank Chen
57dde8c250
Clean up header inclusion
...
Signed-off-by: Frank Chen <frank.chen021@outlook.com>
2022-08-02 15:43:19 +08:00
Frank Chen
40c6e4c0d6
Merge remote-tracking branch 'origin/master' into tracing_context_propagation
2022-08-02 10:02:09 +08:00
Robert Schulze
13482af4ee
First try at reducing the use of StringRef
...
- to be replaced by std::string_view
- suggested in #39262
2022-07-17 17:26:02 +00:00
Frank Chen
57a7e4a7c9
Remove old API reference
2022-07-07 17:42:35 +08:00
Frank Chen
2e8c530bed
Move thread trace context out of ThreadStatus
2022-07-07 17:41:10 +08:00
Azat Khuzhin
c29768325c
Print query in one line on fatal errors
...
executeQuery() logging query without new lines in SQL, and it is useful,
since you can grep and see the whole query (usually).
So let's use the same in fatal error handler to make CI reports more
informative.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-06-03 18:55:53 +03:00
kssenii
f0e0d97752
Fix lask of query id in merges
2022-03-29 19:49:42 +02:00
Azat Khuzhin
6aebc3e94c
Do not loose ProfileEvents in case of thread destroyed before
...
v2: drop std::move and add copy ctor for ProfileEvents::Counter::Snapshot
v2: remove std::move
2021-12-19 23:43:05 +03:00
Azat Khuzhin
ee0258e128
Add sanity check into ThreadStatus::disableProfiling()
2021-11-26 01:13:55 +03:00
Azat Khuzhin
2840405c8a
Fix typo in ThreadStatus::query_profiler_enabled
2021-11-26 01:13:55 +03:00
Azat Khuzhin
8a209a78d7
Set query_id for mutations/merges
...
This will allow to distinguish allocations in trace_log.
2021-10-15 01:43:28 +03:00
Dmitry Novik
356723427d
WIP on ProfileEvents forwarding
2021-10-11 17:39:23 +03:00
Dmitry Novik
e9b1e05461
Send profile events from all threads of current group
2021-10-11 17:29:50 +03:00
Alexey Milovidov
fe6b7c77c7
Rename "common" to "base"
2021-10-02 10:13:14 +03:00
Nikolai Kochetov
f569a3e3f7
Merge branch 'master' into rewrite-pushing-to-views
2021-09-09 20:30:23 +03:00
Nikolai Kochetov
4d821efa15
Rewrite PushingToViewsBlockOutputStream part 2.
2021-08-26 11:01:26 +03:00
Alexey Milovidov
53ca1ebca6
Be in style
2021-08-25 03:58:49 +03:00
Nikolai Kochetov
6b1030c9b8
Rewrite PushingToViewsBIS part 1.
2021-08-13 19:32:29 +03:00
Raúl Marín
820a6e0987
Refactor MV stage metric setup and teardown
2021-08-10 10:49:12 +02:00
Raúl Marín
0d9bf0a08e
Avoid havin multiple profilers in the same thread
2021-07-27 16:29:34 +02:00
Raúl Marín
7c1fcc94b0
View log: Make sure to only profile events during view execution
2021-07-27 16:29:33 +02:00
