Azat Khuzhin
ff324fe81a
Fix fault injection in copier (wrong query syntax)
...
There are very frequent flakiness of `test_cluster_copier` test, here is
an example of copier failures on CI [1]:
AssertionError: Instance: s0_1_0 (172.16.29.9). Info: {'ID': '5d68dcb46fdb4b0c54b7c7ba1ddde83b8f34d483bbb32abcb0c52b966444ce82', 'Running': False, 'ExitCode': 85, 'ProcessConfig': {'tty': False, 'entrypoint': '/usr/bin/clickhouse', 'arguments': ['copier', '--config', '/etc/clickhouse-server/config-copier.xml', '--task-path', '/clickhouse-copier/task_simple_4DFWYTDD49', '--task-file', '/task0_description.xml', '--task-upload-force', 'true', '--base-dir', '/var/log/clickhouse-server/copier', '--copy-fault-probability', '0.2', '--experimental-use-sample-offset', '1'], 'privileged': False, 'user': '0'}, 'OpenStdin': False, 'OpenStderr': True, 'OpenStdout': True, 'CanRemove': False, 'ContainerID': 'f356df6694b3cc09ee9830c623681626f8e8d999677c188b9fe911aa702784ca', 'DetachKeys': '', 'Pid': 84332}
assert 85 == 0
But let's look what the error it is, apparently it is UNFINISHED:
SELECT
name,
code
FROM system.errors
WHERE ((code % 256) = 85) AND (NOT remote)
SETTINGS system_events_show_zero_values = 1
┌─name─────────────────────────────┬─code─┐
│ FORMAT_IS_NOT_SUITABLE_FOR_INPUT │ 85 │
│ UNFINISHED │ 341 │
│ NO_SUCH_ERROR_CODE │ 597 │
└──────────────────────────────────┴──────┘
Let's verify:
$ grep -r UNFINISHED ./test_cluster_copier/_instances_0/s0_1_0/logs/copier/clickhouse-copier_*
./test_cluster_copier/_instances_0/s0_1_0/logs/copier/clickhouse-copier_20230206220846_368/log.log:2023.02.06 22:09:19.015251 [ 368 ] {} <Error> : virtual int DB::ClusterCopierApp::main(const std::vector<std::string> &): Code: 341. DB::Exception: Too many tries to process table cluster1.default.hits. Abort remaining execution. (UNFINISHED), Stack trace (when copying this message, always include the lines below):
And apparently that it is due to query error with fault injection:
2023.02.06 22:09:15.654724 [ 368 ] {} <Error> Application: An error occurred while processing partition 0: Code: 62. DB::Exception: Syntax error (Query): failed at position 168 ('Native'): Native. Expected one of: token, Dot, OR, AND, BETWEEN, NOT BETWEEN, LIKE, ILIKE, NOT LIKE, NOT ILIKE, IN, NOT IN, GLOBAL IN, GLOBAL NOT IN, MOD, DIV, IS NULL, IS NOT NULL, alias, AS, Comma, OFFSET, WITH TIES, BY, LIMIT, SETTINGS, UNION, EXCEPT, INTERSECT, INTO OUTFILE, FORMAT, end of query. (SYNTAX_ERROR), Stack trace (when copying this message, always include the lines below):
Example:
select x from x limit 1FORMAT Native
Syntax error: failed at position 32 ('Native'):
So fixing this should fix test_cluster_copier flakiness.
[1]: https://s3.amazonaws.com/clickhouse-test-reports/46045/bd4170e03c6af583a51d12d2c39fa775dcb9997b/integration_tests__release__[4/4].html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 17:01:06 +01:00
Azat Khuzhin
18d2a99761
Use comments for variables that clang can parse
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 16:53:45 +01:00
Yatsishin Ilya
1baa15d603
Merge remote-tracking branch 'origin/master' into clickhouse-help
2023-02-07 15:46:59 +00:00
Han Fei
0f7defb87f
Merge branch 'master' into hanfei/gwp-asan
2023-02-07 14:55:55 +01:00
Robert Schulze
08c1f8346e
Merge remote-tracking branch 'origin/master' into rs/fix-fragile-linking
2023-02-07 11:22:00 +00:00
Robert Schulze
84b9ff450f
Fix terribly broken, fragile and potentially cyclic linking
...
Sorry for the clickbaity title. This is about static method
ConnectionTimeouts::getHTTPTimeouts(). It was be declared in header
IO/ConnectionTimeouts.h, and defined in header
IO/ConnectionTimeoutsContext.h (!). This is weird and caused issues with
linking on s390x (##45520). There was an attempt to fix some
inconsistencies (#45848 ) but neither did @Algunenano nor me at first
really understand why the definition is in the header.
Turns out that ConnectionTimeoutsContext.h is only #include'd from
source files which are part of the normal server build BUT NOT part of
the keeper standalone build (which must be enabled via CMake
-DBUILD_STANDALONE_KEEPER=1). This dependency was not documented and as
a result, some misguided workarounds were introduced earlier, e.g.
0341c6c54b
2023-02-05 20:49:34 +00:00
Robert Schulze
9b841d67e8
Merge remote-tracking branch 'origin/master' into qc-max_cache_size
2023-02-05 16:47:02 +00:00
Antonio Andelic
12569da984
Merge branch 'master' into add-support-for-settings-alias
2023-02-05 16:08:57 +00:00
Boris Kuschel
1d4cf4fe69
Add encryption support with openssl
2023-02-04 14:59:34 -05:00
Alexey Milovidov
22bd0b6f69
Merge pull request #38983 from CurtizJ/randomize-mt-settings
...
Allow to randomize merge tree settings in tests
2023-02-04 02:59:52 +01:00
Mikhail f. Shiryaev
cd2e1cfada
Merge pull request #45568 from ClickHouse/keeper-systemd
...
Add systemd.service for clickhouse-keeper
2023-02-03 23:08:02 +01:00
Yatsishin Ilya
f4cfd8a2d9
Merge remote-tracking branch 'origin' into clickhouse-help
2023-02-03 20:08:23 +00:00
Antonio Andelic
8929838fcc
Merge branch 'master' into add-support-for-settings-alias
2023-02-03 17:47:00 +00:00
Nikita Mikhaylov
33877b5e00
Parallel replicas. Part [2] ( #43772 )
2023-02-03 14:34:18 +01:00
Anton Popov
cdbe145bc1
Merge pull request #45796 from CurtizJ/fix-leak-in-azure-sdk
...
Fix test `test_azure_blob_storage_zero_copy_replication ` (memory leak in azure sdk)
2023-02-03 14:16:19 +01:00
Mikhail f. Shiryaev
a42d20e19d
Create "coordination" directory in keeper if does not exist
2023-02-03 12:16:19 +01:00
Robert Schulze
f72286c8f3
Merge branch 'master' into qc-max_cache_size
2023-02-03 10:54:35 +01:00
Robert Schulze
b1889b0284
Make the naming a little less confusing
2023-02-02 19:18:39 +00:00
Kevin Zhang
45e8020768
remove host used for dev
2023-02-02 09:16:39 -05:00
Antonio Andelic
f613bfd8d2
Merge branch 'master' into add-support-for-settings-alias
2023-02-02 11:15:39 +00:00
Robert Schulze
53e1c9cd08
Merge branch 'master' into qc-max_cache_size
2023-02-02 11:45:29 +01:00
Kevin Zhang
28a20f8de9
fix charts not clearing previous plot when editing after deleting charts
2023-02-01 16:49:58 -05:00
Kevin Zhang
698c819ea9
show authentication error message in dashboard when credentials invalid
2023-02-01 16:45:40 -05:00
Vladimir C
0d48eed68f
Merge pull request #45848 from Algunenano/fix_connection_timeouts_context_include
2023-02-01 12:53:50 +01:00
Robert Schulze
216636f984
Make query cache global settings re-configurable
2023-02-01 10:35:19 +00:00
Robert Schulze
b512316586
Merge pull request #45682 from ClickHouse/rename-qrc-to-qc
...
Rename "Query Result Cache" to "Query Cache"
2023-02-01 11:23:29 +01:00
Antonio Andelic
ec04cf6876
Merge branch 'master' into add-support-for-settings-alias
2023-02-01 09:01:01 +00:00
Raúl Marín
7c31cb7adc
Proper includes for ConnectionTimeoutsContext.h
2023-01-31 16:11:32 +01:00
Han Fei
716518f143
Merge branch 'master' into hanfei/gwp-asan
2023-01-31 15:01:25 +01:00
Yatsishin Ilya
f7b6de9fa6
I like style check
2023-01-31 13:14:24 +00:00
Yatsishin Ilya
ce553a2888
I like style check
2023-01-31 12:51:33 +00:00
Yatsishin Ilya
98edb9f06b
Update help for clickhouse tools and add test
2023-01-31 12:19:37 +00:00
Kseniia Sumarokova
7d53f8bbf6
Merge pull request #45591 from bharatnc/ncb/odbc-connection-pool-fixes
...
fixes to use the odbc_bridge_use_connection_pooling setting correctly
2023-01-31 11:31:59 +01:00
Robert Schulze
325c6bdf3d
Renaming: "Query Result Cache" --> "Query Cache"
...
Reasons:
- The cache will at some point store intermediate results as opposed to
only query results. We should change the terminology now without
having to worry about backward compat.
- Equivalent caches in MySQL (1) and Starrocks (2) are called "query
cache".
- The new name is ca. 13.8% more catchy.
(1) https://dev.mysql.com/doc/refman/5.6/en/query-cache.html
(2) https://docs.starrocks.io/en-us/2.5/using_starrocks/query_cache
2023-01-31 09:54:34 +00:00
Alexey Milovidov
7aa10a430a
Merge branch 'master' into hanfei/gwp-asan
2023-01-31 04:13:59 +03:00
Anton Popov
839cd614fb
fix memory leak in azure sdk
2023-01-31 01:01:10 +00:00
Bharat Nallan
f1d6e3b908
Merge branch 'master' into ncb/odbc-connection-pool-fixes
2023-01-30 15:49:04 -08:00
Han Fei
4971358de5
fix init
2023-01-30 17:07:01 +01:00
Azat Khuzhin
4564a1ef29
Add ability to override connection settings based on connection names
...
This is somehow analog of .netrc [1].
[1]: https://www.gnu.org/software/inetutils/manual/html_node/The-_002enetrc-file.html
The follow options can be overwritten on a per-hostname/connection
basis:
- hostname
- port
- secure
- user
- password
- database
- history_file
Also note, that you can have multiple settings for one hostname, can be
useful to distinguish readonly from non-readonly for example.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-01-28 17:01:12 +01:00
Anton Popov
d8fe2bcbaa
Merge branch 'master' into randomize-mt-settings
2023-01-27 16:03:00 +01:00
Antonio Andelic
defc9108f0
Extend support for aliases to constraints and profiles
2023-01-27 09:39:10 +00:00
Alexander Tokmakov
067b1f5f13
Merge branch 'master' into exception_message_patterns4
2023-01-26 15:20:58 +01:00
Antonio Andelic
714fad1529
Add support for settings alias
2023-01-26 14:06:46 +00:00
Anton Popov
92fa39798b
Merge remote-tracking branch 'upstream/master' into HEAD
2023-01-26 13:29:23 +00:00
Azat Khuzhin
5729ff6043
Add example of background_*_pool_size into config.xml
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-01-25 19:53:45 +01:00
Bharat Nallan
2ef8fcb318
Merge branch 'master' into ncb/odbc-connection-pool-fixes
2023-01-24 21:27:20 -08:00
Alexander Tokmakov
31e16c4b4d
fix
2023-01-24 15:29:19 +01:00
Alexander Tokmakov
6ecae8388e
Merge branch 'master' into exception_message_patterns4
2023-01-24 14:42:36 +01:00
Alexey Milovidov
cb1e8afda6
Merge pull request #45524 from kssenii/fix-cache-policies-getter
...
Add proper default to cache policy getter
2023-01-24 12:46:33 +03:00
Alexander Tokmakov
3f6594f4c6
forbid old ctor of Exception
2023-01-23 22:18:05 +01:00
Alexander Tokmakov
70d1adfe4b
Better formatting for exception messages ( #45449 )
...
* save format string for NetException
* format exceptions
* format exceptions 2
* format exceptions 3
* format exceptions 4
* format exceptions 5
* format exceptions 6
* fix
* format exceptions 7
* format exceptions 8
* Update MergeTreeIndexGin.cpp
* Update AggregateFunctionMap.cpp
* Update AggregateFunctionMap.cpp
* fix
2023-01-24 00:13:58 +03:00
kssenii
3a4d5ba07d
Fix cache policy getter
2023-01-23 22:07:06 +01:00
Anton Popov
08b2e524c7
Merge remote-tracking branch 'upstream/master' into HEAD
2023-01-23 15:34:53 +00:00
Robert Schulze
340f406553
Merge branch 'master' into query-result-cache
2023-01-22 13:21:36 +01:00
Han Fei
8b29f8406b
Merge branch 'master' into hanfei/gwp-asan
2023-01-20 11:03:12 +01:00
Stig Bakken
420c179b55
Add <storage_policy> config parameter for system logs
2023-01-19 10:25:28 +01:00
Bharat Nallan Chakravarthy
16a2585d55
fixes to odbc connection pooling
2023-01-18 16:38:56 -08:00
Robert Schulze
4f90824347
Merge remote-tracking branch 'origin/master' into query-result-cache
2023-01-17 22:49:53 +00:00
Nikolay Degterinsky
d414d4aa7a
Merge remote-tracking branch 'upstream/master' into bcrypt
2023-01-16 22:14:03 +00:00
Nikolay Degterinsky
09558003c2
Make workfactor changeable
2023-01-16 22:11:15 +00:00
Smita Kulkarni
09241150a0
Updated recording of startup time till after starting last listener and added stopping the StopWatch - Record server startup time in ProfileEvents
2023-01-16 08:32:25 +01:00
Smita Kulkarni
a0fe26f506
Addressed review comments and updated name to ServerStartupMilliseconds - Record server startup time in ProfileEvents
2023-01-13 14:38:54 +01:00
Smita Kulkarni
cf5cb0da97
Record server startup time in ProfileEvents
...
Implementation:
* Added ProfileEvents::ServerStartupTime.
* Recorded time from start of main till listening to sockets.
Testing:
* Added a test 02532_profileevents_server_startup_time.sql
2023-01-13 13:47:54 +01:00
Robert Schulze
843264ae3e
Add QRC settings to default config.xml
2023-01-13 10:32:22 +00:00
Robert Schulze
475bb31f33
Make server configuratio hierarchical
2023-01-12 21:24:40 +00:00
Han Fei
f5e736e240
introduce llvm/gwp-asan
2023-01-12 15:00:26 +01:00
Anton Popov
ca80240d84
Merge remote-tracking branch 'upstream/master' into HEAD
2023-01-12 12:13:45 +00:00
Robert Schulze
923fa2c15a
Fix review comments, pt. II
2023-01-10 10:21:08 +00:00
Robert Schulze
45dbcf88e5
Merge remote-tracking branch 'origin/master' into query-result-cache
2023-01-06 20:42:48 +00:00
Kseniia Sumarokova
573d3283b0
Merge pull request #44327 from kssenii/use-new-named-collections-code-2
...
Replace old named collections code with new (from #43147 ) part 2
2023-01-06 13:06:26 +01:00
Alexey Milovidov
3a027d285f
Merge pull request #44828 from ClickHouse/remove-two-lines-of-code
...
What if I will remove two lines of code?
2023-01-04 04:50:52 +03:00
Robert Schulze
27f5aad49e
What happens if I remove 156 lines of code?
2023-01-03 18:51:16 +00:00
Robert Schulze
cfb6feffde
What happens if I remove these 139 lines of code?
2023-01-03 18:35:31 +00:00
kssenii
67509aa2d5
Merge remote-tracking branch 'upstream/master' into use-new-named-collections-code-2
2023-01-03 16:41:30 +01:00
Robert Schulze
e9e04166d9
Merge remote-tracking branch 'origin/master' into query-result-cache
2023-01-02 08:20:27 +00:00
Alexey Milovidov
b859cc2ddc
Fix build
2023-01-02 03:27:21 +01:00
Alexey Milovidov
47ae8c5c79
Remove more lines
2023-01-02 02:06:11 +01:00
Alexey Milovidov
6e946cc757
Less OOM in stress test
2023-01-01 23:22:26 +01:00
Nikolay Degterinsky
dfe93b5d82
Merge pull request #42284 from Algunenano/perf_experiment
...
Performance experiment
2022-12-30 03:14:22 +01:00
Raúl Marín
e915ce1e95
Merge remote-tracking branch 'blessed/master' into perf_experiment
2022-12-28 20:15:43 +01:00
Nikolay Degterinsky
e814179663
Add default password type
2022-12-28 13:26:23 +00:00
李扬
56b6378c12
Update programs/server/Server.cpp
...
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
2022-12-28 15:08:50 +08:00
李扬
2405291612
Update programs/copier/ClusterCopierApp.cpp
...
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
2022-12-28 15:07:06 +08:00
李扬
4e3098bbc2
Update programs/extract-from-config/ExtractFromConfig.cpp
...
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
2022-12-28 15:06:57 +08:00
taiyang-li
437c31eca3
merge master and fix conflicts
2022-12-28 15:02:37 +08:00
Azat Khuzhin
b7f92454bf
Move LineReader/ReplxxLineReader out from base
...
This will simplify linking dependencies, and anyway this classes are not
base in any sense.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 14:23:51 +01:00
Alexey Milovidov
514ff2ba20
Merge pull request #44570 from ClickHouse/clickhouse-benchmark-better-arguments
...
Better command line argument name in `clickhouse-benchmark`
2022-12-27 16:10:21 +03:00
Alexey Milovidov
e1115828d0
Merge pull request #44593 from ClickHouse/better-diagnostic-in-stress-test
...
Better diagnostics on server stop for the stress test
2022-12-27 16:07:43 +03:00
Alexey Milovidov
1c8fa6eb26
Merge pull request #44595 from ClickHouse/wrong-place-of-log-message
...
The position of the log message about the server environment was wrong
2022-12-27 16:00:37 +03:00
Alexey Milovidov
1b21cc018e
Merge pull request #44342 from ClickHouse/add-test-29883
...
Add a test for #29883
2022-12-27 14:55:14 +03:00
Raúl Marín
fc1fa82a39
Merge branch 'master' into perf_experiment
2022-12-27 10:51:58 +01:00
Alexey Milovidov
b218d549bf
Fix bad log message
2022-12-26 13:56:09 +01:00
Alexey Milovidov
d08e7e5f2d
The position of the log message about the server environment was wrong
2022-12-26 13:30:13 +01:00
Alexey Milovidov
e98f217b87
Better diagnostics on stop
2022-12-26 12:15:58 +01:00
Alexey Milovidov
d4864c7d38
Better command line argument name in clickhouse-benchmark
2022-12-24 20:40:23 +01:00
kssenii
8308177361
Merge remote-tracking branch 'upstream/master' into use-new-named-collections-code-2
2022-12-23 12:14:46 +01:00
vdimir
511e8d698d
Rename config param tmp_cache -> temporary_data_in_cache
2022-12-22 10:22:56 +00:00
vdimir
d30d25dbbe
Temporary files evict fs cache
2022-12-22 10:22:49 +00:00
Alexey Milovidov
a6f50edde3
Merge branch 'master' into add-test-29883
2022-12-21 01:45:18 +03:00
kssenii
6bd4f8c029
Merge remote-tracking branch 'upstream/master' into use-new-named-collections-code-2
2022-12-20 21:17:28 +01:00
Anton Popov
56187c5f0e
Merge remote-tracking branch 'upstream/master' into HEAD
2022-12-20 13:37:23 +00:00
Raúl Marín
45d27f461b
Merge branch 'master' into perf_experiment
2022-12-20 09:07:48 +00:00
Sergei Trifonov
6f7bba159f
Merge pull request #41840 from ClickHouse/io-scheduler
...
IO scheduling subsystem
2022-12-19 15:15:19 +01:00
Robert Schulze
b93c56323c
Merge remote-tracking branch 'origin/master' into query-result-cache
2022-12-19 09:18:36 +00:00
Alexey Milovidov
1795c583a1
Add a test for #29883
2022-12-18 08:00:32 +01:00
Alexey Milovidov
30fd9b8317
Merge pull request #43597 from ClickHouse/sd_notify_followup_fixes
...
Followup fixes for systemd notification (#43400 )
2022-12-17 04:35:05 +03:00
kssenii
30547d2dcd
Replace old named collections code for url
2022-12-17 00:24:05 +01:00
Boris Kuschel
b1e401eb93
Merge branch 'ClickHouse:master' into openssl_support
2022-12-16 16:40:08 -05:00
Boris Kuschel
1b7c5758d2
Fix openssl Bug
2022-12-16 12:31:17 -08:00
Sergei Trifonov
f61a98b5dc
Merge branch 'master' into io-scheduler
2022-12-16 15:55:08 +01:00
Anton Popov
b6f2754afb
Merge remote-tracking branch 'upstream/master' into HEAD
2022-12-16 14:37:34 +00:00
Robert Schulze
4db33f16e3
Make DoS attack on cache less likely
2022-12-15 21:42:51 +00:00
Robert Schulze
537c64aad2
Merge remote-tracking branch 'origin/master' into query-result-cache
...
Conflicts:
- tests/queries/0_stateless/02117_show_create_table_system.reference
2022-12-15 12:17:58 +00:00
Anton Popov
87e02a1744
Merge remote-tracking branch 'upstream/master' into HEAD
2022-12-14 02:08:10 +00:00
kssenii
9aa6d31bce
Merge remote-tracking branch 'upstream/master' into use-new-named-collections-code
2022-12-13 22:25:10 +01:00
kssenii
fae817863c
Apply new code of named collections to s3
2022-12-13 22:19:09 +01:00
Nikolay Degterinsky
443bc3e656
Merge pull request #43719 from evillique/password_complexity_rules
...
Add password complexity rules
2022-12-13 17:56:45 +01:00
Nikolay Degterinsky
9b6d31b95d
Merge branch 'master' into perf_experiment
2022-12-13 17:15:07 +01:00
Robert Schulze
b78652e138
Query result cache
2022-12-12 10:37:10 +00:00
Nikolay Degterinsky
19e95e8cd8
Better implementation of password rules
2022-12-11 23:59:04 +00:00
Boris Kuschel
592c73e2c3
Merge branch 'master' into openssl_support
2022-12-09 20:21:22 -05:00
Nikolay Degterinsky
f2c07c0337
Merge remote-tracking branch 'upstream/master' into password_complexity_rules
2022-12-10 00:46:05 +00:00
alesapin
7a9d5a5818
Return pragma
2022-12-08 18:54:24 +01:00
alesapin
965e3519e9
Remove unused includes
2022-12-08 18:53:05 +01:00
alesapin
350bacec60
Followup
2022-12-08 18:43:54 +01:00
alesapin
7a223f4956
Slightly better clickhouse disks and remove DiskMemory
2022-12-08 18:20:54 +01:00
Boris Kuschel
cc3314acbe
Merge branch 'master' into openssl_support
2022-12-08 07:40:43 -05:00
Alexey Milovidov
9c81fd7afc
Merge pull request #43517 from ClickHouse/password-reset-message
...
Move password reset message from client to server
2022-12-07 23:26:58 +03:00
Boris Kuschel
b7698dc609
Fix style issues
2022-12-07 13:22:46 -05:00
Boris Kuschel
f03f95044e
OpenSSL code changes
2022-12-07 13:22:46 -05:00
Azat Khuzhin
a8faf196c4
Add --max-consecutive-errors for clickhouse-benchmark ( #43344 )
...
* Align Benchmark::Benchmark()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
* Add --max-consecutive-errors for clickhouse-benchmark
Unlike --continue_on_errors, it will not leave the benchmark forever if
server is unavailable.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Co-authored-by: Nikita Taranov <nikita.taranov@clickhouse.com>
2022-12-07 14:51:16 +01:00
Kruglov Pavel
d4cd53ccea
Merge pull request #43602 from lzydmxy/fix_bug_in_copier
...
Ensure consistency when copier update `status` and `attach_is_done`
2022-12-07 13:47:56 +01:00
Alexander Gololobov
3608763a30
Wait for parent process to send MAINPID=... notification to the service manager
2022-12-06 16:14:46 +01:00
Alexander Gololobov
688e6fe714
Send MAINPID= notification from the parent (watchdog) process to make systemd handle READY=1 notifiaction from the child
2022-12-05 23:03:40 +01:00
Alexander Gololobov
58fcf0fdb0
Merge branch 'master' into sd_notify_followup_fixes
2022-12-05 15:03:44 +01:00
kssenii
dca3444283
Merge remote-tracking branch 'upstream/master' into named-collections-sql-commands
2022-12-04 15:56:02 +01:00
Vladimir C
7d6950d397
Revert "Temporary files evict fs cache"
2022-12-02 14:50:56 +01:00
Anton Popov
5d9077cdb6
Merge remote-tracking branch 'upstream/master' into HEAD
2022-12-02 12:06:45 +00:00
Vladimir C
117d01f2ac
Merge pull request #43457 from ClickHouse/vdimir/tmp-data-in-fs-cache
2022-12-01 13:41:40 +01:00
vdimir
98fe3c6c02
Temporary files evict fs cache
2022-12-01 11:49:17 +00:00
Antonio Andelic
1f93183dc7
Merge pull request #43087 from ClickHouse/keeper-prometheus
...
Add support for embedded Prometheus endpoint in Keeper
2022-12-01 12:46:47 +01:00
Kruglov Pavel
f6f71ac5f1
Merge branch 'master' into fix_bug_in_copier
2022-12-01 12:29:50 +01:00
Nikolay Degterinsky
a7eed2fd6d
Throw an exception if something is broken
2022-12-01 02:59:35 +00:00
Vladimir C
53dc70a2d0
Merge pull request #38191 from BigRedEye/grace_hash_join
...
Closes https://github.com/ClickHouse/ClickHouse/issues/11596
2022-11-30 17:01:00 +01:00
Antonio Andelic
2f501d5327
Merge branch 'master' into keeper-prometheus
2022-11-30 13:24:37 +01:00
Antonio Andelic
fbda86ddc8
PR fixes
2022-11-30 13:24:08 +01:00
Alexey Milovidov
72bf1115e9
Merge branch 'master' into password-reset-message
2022-11-29 23:51:46 +01:00
Nikolay Degterinsky
b675898d37
Small naming fix
2022-11-29 16:36:05 +00:00
Sema Checherinda
7feea8fd9b
Merge pull request #43278 from mdelapenya/bump-testcontainers-go
...
chore: bump testcontainers-go to latest released version
2022-11-29 14:23:15 +01:00
Antonio Andelic
678958603b
Merge branch 'master' into keeper-prometheus
2022-11-28 09:48:57 +01:00
Manuel de la Peña
0cd49e84c6
Merge branch 'master' into bump-testcontainers-go
2022-11-28 08:32:17 +01:00
Azat Khuzhin
c35eb86a37
Fix example of colored prompt in client
...
After switching to replxx you don't need the following anymore:
- RL_PROMPT_START_IGNORE (\001)
- RL_PROMPT_END_IGNORE (\002)
And those symbols also breaks the client prompt (the text length
calculated incorrectly, it does not interpret "\x01" as an escape
sequence but instead just a bunch of bytes and shows extra whitespaces
after prompt).
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-27 20:30:00 +01:00
Azat Khuzhin
6381feb46d
Add ability to increase timeout for clickhouse start/stop/restart
...
Increasing timeout may help in case of slow server (debug, sanitizers).
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-27 09:40:39 +01:00
Nikolay Degterinsky
3fd10e0011
Better solution
2022-11-25 22:38:28 +00:00
Nikolay Degterinsky
6825d85daa
Add complexity rules for passwords
2022-11-25 22:38:05 +00:00
Alexey Milovidov
cf27a0cdeb
Fix log messages in clickhouse-copier
2022-11-25 22:29:02 +01:00
Alexey Milovidov
f0a3196fa8
xMerge branch 'master' into password-reset-message
2022-11-25 22:26:23 +01:00
Anton Popov
c811f34a41
Simplify AsynchronousInsertQueue and fix race ( #43233 )
2022-11-25 15:02:22 +01:00
Manuel de la Peña
d651b97bbb
fix: typo
2022-11-25 10:09:32 +01:00
Manuel de la Peña
6a5ffabecf
chore: create container for each test
2022-11-25 08:52:49 +01:00
Manuel de la Peña
8a957e904d
fix: read frame columns properly
2022-11-25 08:52:01 +01:00
Manuel de la Peña
73dd5102d6
chore: run clickhouse container only for the duration of the test
2022-11-25 08:23:35 +01:00
Manuel de la Peña
9be878aae2
Merge branch 'master' into bump-testcontainers-go
...
* master: (331 commits)
Revert "Fix endian issue in integer hex string conversion"
Update sparse-primary-indexes.md to correct typo
to MaterializeMySQL_support_drop_mulit_table-change ParserIdentifier
to MaterializeMySQL_support_drop_mulit_table-clean up unnecessary code
Make insertRangeFrom() more exception safe (#43338 )
Update docs/en/sql-reference/statements/create/view.md
Update docs/en/sql-reference/statements/alter/projection.md
Analyzer table functions untuple fix
Revert "Add table_uuid to system.parts"
Update 00176_bson_parallel_parsing.sh
Update test.py
doc fix
bump lib for diag
Update kafka.md
check ast limits for create_parser_fuzzer
Disable compressed marks and index in stress tests
add a test with weird strings
Update .reference
Add information about written rows in progress indicator
Avoid possible DROP hung due to attached web disk
...
2022-11-25 08:17:17 +01:00
Igor Nikonov
20e67b7140
Merge remote-tracking branch 'origin/master' into HEAD
2022-11-24 13:10:37 +00:00
Antonio Andelic
a6f38cb1cc
Merge branch 'master' into keeper-prometheus
2022-11-24 12:12:08 +01:00
Sergei Trifonov
8186a06c28
Merge branch 'master' into io-scheduler
2022-11-24 12:02:52 +01:00
Raúl Marín
4d3217cb18
Merge branch 'master' into perf_experiment
2022-11-24 10:32:12 +01:00
lzydmxy
0462132dd6
Ensure consistency when copier update status and current_partition_attach_is_done after partition attach is done
2022-11-24 11:15:44 +08:00
Alexander Gololobov
7b4e0e5bd8
Properly handle EINTR; some more comments
2022-11-23 23:37:02 +01:00
kssenii
6044a9257c
Merge remote-tracking branch 'upstream/master' into named-collections-sql-commands
2022-11-23 12:00:55 +01:00
Dale McDiarmid
60f7a40c0b
bump lib for diag
2022-11-23 09:25:58 +00:00
Alexey Milovidov
c20dbb7770
Move password reset message from client to server
2022-11-22 19:34:38 +01:00
Raúl Marín
4aa29b6a63
Merge remote-tracking branch 'blessed/master' into perf_experiment
2022-11-22 19:09:00 +01:00
Alexander Gololobov
c636c323ea
Merge pull request #43400 from socketpair/sd_notify
...
Fix #8685 - added systemd sd_notify implementation
2022-11-22 18:07:50 +01:00
Alexander Gololobov
32d66659e5
Merge pull request #43364 from azat/server-stacktrace-on-fail
...
Provide full stacktrace in case of uncaught exception during server startup
2022-11-22 15:07:57 +01:00
Raúl Marín
ad95846b2b
AST fuzzer: Print data of INSERT VALUES
2022-11-22 13:10:53 +01:00
kssenii
a279bac767
Merge remote-tracking branch 'upstream/master' into named-collections-sql-commands
2022-11-21 21:49:34 +01:00
Dmitry Novik
b17dc24a94
Do not reuse jemalloc memory in test
2022-11-21 16:10:47 +00:00
Alexander Gololobov
63196a1e9e
Close the socket; some cleanups
2022-11-21 16:05:47 +01:00
Antonio Andelic
e78761b66c
Merge branch 'master' into keeper-prometheus
2022-11-21 09:10:10 +01:00
Коренберг ☢️ Марк
6dbeee69d6
Fix ##8685 - added systemd sd_notify implementation
2022-11-20 19:34:12 +02:00
Azat Khuzhin
44f23c2568
Make disks checks only for clickhouse-server
...
This will fix clickhouse-disks
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-20 16:28:35 +01:00
Vitaly Baranov
a348332eab
Merge pull request #43227 from vitlibar/improve-masking-sensitive-info
...
Improve masking sensitive info
2022-11-18 15:37:50 +01:00
Azat Khuzhin
eb3d21831d
Provide full stacktrace in case of uncaught exception during server start
...
Without it, it is hard to understand where the problem is.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-18 13:24:57 +01:00
kssenii
5d9b34b59d
More tests
2022-11-17 15:34:35 +01:00
kssenii
f0ce28349d
Better
2022-11-16 17:58:21 +01:00
Manuel de la Peña
00204d296c
chore: check process in the container, not in the host
2022-11-16 08:20:40 +01:00
Manuel de la Peña
cb91c2f682
chore: bump testcontainer-go to latest released version
2022-11-16 08:14:58 +01:00
Alexey Milovidov
b4165f95a9
Merge branch 'master' into build/poco-leftovers
2022-11-16 06:09:58 +01:00
Vitaly Baranov
8d72f75556
Make the password wiping an option of IAST::format().
2022-11-16 01:35:06 +01:00
Antonio Andelic
96838f5be7
Merge branch 'master' into keeper-prometheus
2022-11-15 12:00:02 +00:00
李扬
fc7fcafe40
Merge branch 'master' into alternative_keeper
2022-11-15 10:34:07 +08:00
taiyang-li
64d7087084
merge master and fix conflict
2022-11-15 10:33:10 +08:00
Alexey Milovidov
2c7377be92
Merge pull request #43129 from Algunenano/skip_hash_in_sanitizer
...
Skip hash logging on sanitizer builds
2022-11-15 02:16:27 +01:00
Alexey Milovidov
372059fe87
Merge pull request #43191 from ClickHouse/fix-git-import-indent
...
Fix the `indent` field in the `git-import` tool
2022-11-15 01:14:15 +01:00
Kseniia Sumarokova
e58a7140be
Merge pull request #43194 from ClickHouse/async-metrics-documentation
...
Add documentation for `system.asynchronous_metrics`.
2022-11-14 12:21:34 +01:00
Raúl Marín
65f00cc246
Skip binary hash calculation if there isn't a checksum reference
2022-11-14 12:17:21 +01:00
Alexander Tokmakov
87550e33bb
Merge pull request #43092 from ClickHouse/make-clickhouse-local-progress-off-by-default
...
Disable clickhouse local and client non-interactive progress by default.
2022-11-14 14:14:29 +03:00
Antonio Andelic
1635d120a0
Merge pull request #43201 from ClickHouse/fix-tsan-race-config-reload
...
Stop `ConfigReloader` first to avoid data race
2022-11-14 11:58:43 +01:00
Kseniia Sumarokova
79206c6eb0
Merge pull request #43147 from kssenii/named-collections-refactoring
...
Add generic implementation for arbitrary structured named collections, access type and system.named_collections
2022-11-14 11:57:17 +01:00
Antonio Andelic
38ee1a81a3
Stop config reloader before anything else
2022-11-13 19:17:41 +00:00
Alexey Milovidov
ba05b7dd2c
Add documentation for AsynchronousMetrics
2022-11-13 03:36:20 +01:00
Alexey Milovidov
e4a6f2a8e1
Fix the indent field in the git-import tool
2022-11-12 18:54:48 +01:00
Yakov Olkhovskiy
60d116729c
adjustments for progress option
2022-11-12 02:55:26 +00:00
kssenii
63de577172
Better, add tests
2022-11-10 22:47:30 +01:00
Azat Khuzhin
953457de28
Remove POCO_CLICKHOUSE_PATCH
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-10 22:41:26 +01:00
kssenii
bed7ac9442
Support arbitrary structure collections
2022-11-10 17:05:24 +01:00
Antonio Andelic
8aeb406d82
Fix standalone build
2022-11-10 10:49:00 +01:00
Antonio Andelic
f2a9b5933d
Merge branch 'master' into keeper-prometheus
2022-11-10 09:28:06 +01:00
Antonio Andelic
36d763011b
Compile standalone keeper
2022-11-10 09:23:52 +01:00
Nikolai Kochetov
3eb6c03b47
Disable clickhouse local and clickhouse client non-interactive progress by default.
2022-11-09 19:46:47 +00:00
Antonio Andelic
a0c12c2428
Define LOGICAL_ERROR
2022-11-09 16:06:25 +01:00
Antonio Andelic
1ed3930809
Add more metrics for Keeper
2022-11-09 15:51:41 +01:00
vdimir
e3f211a943
dashboard.html: add debug mode to add add_http_cors_header
2022-11-09 15:13:22 +01:00
vdimir
a977ea3071
dashboard.html: scroll and focus to new chart
2022-11-09 15:13:22 +01:00
vdimir
6d59fcaec6
dashboard.html: show reload button on connection params change
2022-11-09 15:13:22 +01:00
Antonio Andelic
c92ae5a385
Add suport for AsyncMetrics in standalone Keeper
2022-11-09 13:46:03 +01:00
Antonio Andelic
e82a5d43b5
Extract HTTPContext for HTTPServer
2022-11-09 09:02:04 +01:00
Robert Schulze
cdaf0becfe
Merge branch 'master' into bitcast
2022-11-07 09:24:52 +01:00
Alexey Milovidov
641f8576c6
Merge pull request #42003 from ClickHouse/write-progress-to-tty
...
Write progress directly to terminal
2022-11-05 16:51:37 +01:00
Robert Schulze
9c066e964d
Less use of CH-specific bit_cast()
...
Converted usage of CH-custom bit_cast to std::bit_cast if possible, i.e.
when
sizeof(From) == sizeof(To).
(The CH-custom bit_cast is able to deal with sizeof(From) != sizeof(To).)
Motivation for this came from #42847 where it is not clear how the
internal bit_cast should behave on big endian systems, so we better
avoid that situation as much as possible.
2022-11-04 15:52:48 +00:00
Yakov Olkhovskiy
b30f2ac12d
allow '--progress err' to preserve old behavior, adjust tests
2022-11-03 03:16:55 +00:00
vdimir
6a4247ca32
Merge branch 'master' into grace_hash_join
2022-10-31 09:54:37 +00:00
Vitaly Baranov
842e40082f
Remove query_masking_rules for encrypt() function from the default config (now it's always masked).
2022-10-31 10:50:33 +01:00
Anton Popov
d09039418f
Merge remote-tracking branch 'upstream/master' into HEAD
2022-10-28 14:35:45 +00:00
Robert Schulze
31ef6c66cb
Merge pull request #42513 from ClickHouse/update-libcxx-to-15
...
Build with libcxx(abi) 15
2022-10-27 10:30:36 +02:00
vdimir
506bf2d225
Merge branch 'master' into grace_hash_join
2022-10-26 12:25:50 +00:00
Robert Schulze
e996e2ff15
Fix clang-tidy
2022-10-26 07:48:37 +00:00
Alexey Milovidov
47c32678ce
Merge pull request #42477 from AlfVII/enable-compiled-expressions-cache-in-local
...
Enable CompiledExpressionCache in clickhouse-local
2022-10-25 04:57:48 +02:00
Robert Schulze
c119cd2f00
Merge branch 'master' into update-libcxx-to-15
2022-10-24 08:29:37 +02:00
Alexey Milovidov
cd43595ea9
Merge branch 'master' into write-progress-to-tty
2022-10-23 01:41:17 +02:00
Azat Khuzhin
dbb4f8216f
Merge remote-tracking branch 'upstream/master' into build/shorten-64-to-32
...
Conflicts:
- src/Functions/GregorianDate.h
2022-10-22 08:20:05 +02:00
Azat Khuzhin
905a95e166
Review fixes
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 22:40:13 +02:00
Azat Khuzhin
4e76629aaf
Fixes for -Wshorten-64-to-32
...
- lots of static_cast
- add safe_cast
- types adjustments
- config
- IStorage::read/watch
- ...
- some TODO's (to convert types in future)
P.S. That was quite a journey...
v2: fixes after rebase
v3: fix conflicts after #42308 merged
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:19 +02:00
Nikolay Degterinsky
d7d0794d2f
Better logs in clickhouse-disks
2022-10-20 23:17:29 +00:00
Alexey Milovidov
58f238007a
Merge pull request #42508 from ClickHouse/remove-database-macro-from-server-prompt
...
Remove support for the `{database}` macro from the client's prompt
2022-10-20 21:14:06 +02:00
Robert Schulze
f435e4fbe2
Un-clusterf$ck incomplete type errors
2022-10-20 14:48:46 +00:00
Robert Schulze
50c932e566
Separate TaskShard and TaskTable
2022-10-20 14:00:20 +00:00
Robert Schulze
df318d8719
Un-inline TaskTableAndShard
2022-10-20 13:43:15 +00:00
Robert Schulze
f6de964eaa
Fix static_assert in random generator
2022-10-20 11:20:18 +00:00
Robert Schulze
cdae7082a3
Up-inline ShardPartition, ShardPartitionPiece and TaskCluster
2022-10-20 11:16:05 +00:00
Alexey Milovidov
fabc8f5a18
Remove support for {database} macro from the client's prompt
2022-10-19 23:27:12 +02:00
Alfonso Martinez
168df7d9ba
Removed trailing whitespace
2022-10-19 13:34:31 +02:00
Alfonso Martinez
0aa26db64c
Added end of line co comply with Clangformat
2022-10-19 12:38:20 +02:00
Alfonso Martinez
c0be79f26c
CompiledExpressionCache enabled
2022-10-19 12:27:00 +02:00
Antonio Andelic
ee2f5977d5
Merge branch 'master' into keeper-upload-snapshot-to-s3
2022-10-18 10:02:50 +02:00
Alexey Milovidov
ddfaadeea4
Merge pull request #42325 from gingerwizard/go_update_diagnostics
...
go update for diagnostics tool
2022-10-17 19:30:16 +02:00
Yakov Olkhovskiy
3ce1fa09d6
Merge pull request #41198 from ClickHouse/composable-protocol
...
Composable protocol
2022-10-17 11:23:12 -04:00
vdimir
adb63a5583
Merge branch 'master' into grace_hash_join
2022-10-17 12:32:56 +00:00
Antonio Andelic
7c7395575f
Merge branch 'master' into keeper-upload-snapshot-to-s3
2022-10-17 11:02:36 +00:00
