Commit Graph

4677 Commits

Author SHA1 Message Date
Nikita Mikhailov
e78fc3109c better ubsan testing 2021-03-11 15:08:18 +03:00
Nikita Mikhailov
05cf1b5bc5 better 2021-03-11 15:08:18 +03:00
Nikita Mikhailov
6a51ad425e add tests + improvements 2021-03-11 15:08:18 +03:00
Nikita Mikhailov
10d22e9db1 fix empty polygon 2021-03-11 15:08:17 +03:00
Nikita Mikhailov
2475143ed3 fix style 2021-03-11 15:08:17 +03:00
Nikita Mikhailov
155d392d31 fix tests 2021-03-11 15:08:17 +03:00
Nikita Mikhailov
cfee417ce0 better 2021-03-11 15:08:17 +03:00
Nikita Mikhaylov
db9dbfa528 Update 01304_polygons_sym_difference.sql 2021-03-11 15:08:17 +03:00
Nikita Mikhailov
0425d566d3 better 2021-03-11 15:08:17 +03:00
Alexey Ilyukhov
373b429e61 Add more tests 2021-03-11 15:08:17 +03:00
DoomzD
f7019cf589 Add tests 2021-03-11 15:08:17 +03:00
Maksim Kita
583b25b68e
Merge pull request #21513 from kitaisreal/direct-dictionary-fix
DirectDictionary updated
2021-03-11 00:01:01 +03:00
tavplubix
2b2c61346c
Update skip_list.json 2021-03-10 20:03:44 +03:00
Vladimir
33dce1296b
Merge pull request #20392 from vdimir/cross-to-inner-join-rewrite 2021-03-10 09:53:55 +03:00
Azat Khuzhin
61d40c3600 Fix optimize_skip_unused_shards for zero shards case
v2: move check to the beginning of the StorageDistributed::read()
2021-03-10 09:05:14 +03:00
Azat Khuzhin
2099e5a661 Fix syntax in arcadia_skip_list 2021-03-10 08:50:32 +03:00
alexey-milovidov
2159fb8481
Merge branch 'master' into governance/query_log 2021-03-10 05:29:56 +03:00
Alexander Tokmakov
ba3d51383c fix 2021-03-10 00:41:04 +03:00
Maksim Kita
b5f51e0ca6 Fixed style check 2021-03-09 23:50:06 +03:00
Maksim Kita
45879472d3 DirectDictionary updated 2021-03-09 23:49:34 +03:00
Alexander Tokmakov
4d19c84d90 Merge branch 'master' into distributed_ddl_improvements 2021-03-09 20:06:41 +03:00
Alexander Tokmakov
83b3e4e0f5 allow to use Cluster from Replicated db 2021-03-09 20:05:24 +03:00
Maksim Kita
43ba554191
Merge pull request #20595 from kitaisreal/cache-dictionaries-lru-cache
Cache dictionaries lru cache
2021-03-09 19:14:30 +03:00
Vasily Nemkov
93a00cde5d
Update skip_list.json 2021-03-09 16:56:23 +03:00
Alexander Kuzmenkov
0de89e2925
Merge pull request #19401 from CurtizJ/aggregating-in-order
Try improve performance of aggregation in order of sorting key
2021-03-09 16:53:32 +03:00
Alexander Tokmakov
00b939e5a3 fix 2021-03-09 13:24:08 +03:00
alesapin
90d019a281
Merge pull request #21508 from ClickHouse/fix_stop_merges_global
Fix global stop merges in test
2021-03-09 11:37:13 +03:00
Azat Khuzhin
3474ea044e Avoid processing optimize_skip_unused_shards twice 2021-03-09 10:05:56 +03:00
vdimir
36006a7e96
Merge branch 'master' into cross-to-inner-join-rewrite 2021-03-09 09:36:15 +03:00
Vladimir
6ec19b2632
Merge pull request #19885 from ClickHouse/vdimir/join-cast-types-v2 2021-03-09 09:30:50 +03:00
Alexander Tokmakov
5c5d11cfce enable some tests 2021-03-09 03:48:37 +03:00
Kruglov Pavel
c464e3c57b
Merge pull request #21311 from ucasFL/fix-format
improve clickhouse-format
2021-03-09 02:16:05 +03:00
Pavel Kruglov
c3ddb1e337 Fix tests 2021-03-09 01:29:40 +03:00
Vasily Nemkov
ada200fa3d
Update skip_list.json 2021-03-09 01:03:40 +03:00
Alexander Tokmakov
2022b90919 configurable output mode for distributed DDL 2021-03-08 23:35:09 +03:00
vdimir
cc770ad441
Fixes for join key inferring
Fix error with wrong right column type in aggregate with nulls

Add logging inferred type for join keys

Add test for join_use_nulls
2021-03-08 17:21:50 +03:00
Vasily Nemkov
1711761459
Merge branch 'master' into governance/query_log 2021-03-08 10:52:27 +03:00
Alexey Milovidov
460658aeab Update tests 2021-03-08 03:18:55 +03:00
Alexey Milovidov
6b309dcc5c Update tests 2021-03-08 03:14:39 +03:00
Alexey Milovidov
355411dfa8 Merge branch 'master' into DateTime64_extended_range 2021-03-08 02:55:14 +03:00
Maksim Kita
492c3d0899
Merge pull request #21321 from kitaisreal/dictionary-source-executable-pool
Added ExecutablePool dictionary source
2021-03-08 01:36:33 +03:00
Vasily Nemkov
8874d2e063 Avoid running 01702_system_query_log.sql in parallel
Shouldn't be run in parallel with itself, since it relies on content of system.query_log
2021-03-07 23:15:15 +02:00
alesapin
914fa48700 Fix global stop merges in test 2021-03-07 17:46:13 +03:00
Alexey Milovidov
d3b422a336 Update test 2021-03-07 10:10:15 +03:00
Alexey Milovidov
5cf42e87be Update test 2021-03-07 09:31:01 +03:00
Maksim Kita
aa1a16d2b9 Updated tests skiplists 2021-03-06 22:17:24 +03:00
feng lv
ba16896162 add --backslash option for clickhouse-format
fix

fix

fix
2021-03-06 12:29:16 +00:00
Nikita Mikhaylov
98707613b8 bump 2021-03-06 14:38:27 +03:00
Maksim Kita
8ea6c4b852 Updated Dictionaries default value handling 2021-03-06 14:37:56 +03:00
Maksim Kita
717a9b048a Fixed tests 2021-03-06 14:37:36 +03:00
Maksim Kita
6ab451d41d Updated tests 2021-03-06 14:36:37 +03:00
Maksim Kita
92b79420a4 Fixed ubsan test 2021-03-06 14:36:37 +03:00
Maksim Kita
e64b18fbac Added dictGet with multiple requested attributes 2021-03-06 14:36:37 +03:00
Maksim Kita
a22ec65e8a Fixed minor issues 2021-03-06 14:36:37 +03:00
Maksim Kita
2a5a9c6ca4 Fixed hierarchy tests 2021-03-06 14:36:37 +03:00
Maksim Kita
1460d57f97 Fixed segfault because of member order of destruction 2021-03-06 14:36:37 +03:00
Maksim Kita
dc0bb7485d Updated CacheDictionary 2021-03-06 14:36:37 +03:00
feng lv
d208013161 add test
fix

fix

fix
2021-03-06 05:03:53 +00:00
Alexey Milovidov
2b1ab0f927 Merge branch 'master' into DateTime64_extended_range 2021-03-06 02:25:43 +03:00
alexey-milovidov
af2135ef9d
Merge pull request #21477 from ClickHouse/fix_mutation_deadlock
Fix deadlock in delete mutations when predicate contains table itself
2021-03-06 02:08:00 +03:00
alexey-milovidov
af90658369
Merge pull request #21432 from azat/flaky-distributed-tests
Fix flaky tests with distributed queries
2021-03-06 02:04:07 +03:00
alexey-milovidov
5a100e246c
Merge pull request #21455 from den-crane/tests/issue_21413
test for #21413
2021-03-06 01:56:15 +03:00
vdimir
3da3794c7e
Add test for cast join on keys with second analyze 2021-03-05 17:58:46 +03:00
Anton Popov
562065732d Merge remote-tracking branch 'upstream/master' into HEAD 2021-03-05 17:30:05 +03:00
alesapin
aff86b1da2 Fix deadlock in delete mutations when predicate contains table itself 2021-03-05 15:32:55 +03:00
Maksim Kita
d3615aca67 Added tests 2021-03-05 13:17:46 +03:00
Vasily Nemkov
4a26e5cd43 Fixed tests + added DROP TABLE to see if it shows up in logs 2021-03-05 12:06:09 +02:00
Alexey Milovidov
c3110a611e Skip Arcadia 2021-03-05 05:06:49 +03:00
Alexey Milovidov
0f52c62ab0 Merge branch 'master' into dict-name-dot 2021-03-05 05:06:25 +03:00
Alexey Milovidov
3e77c9b1c5 Merge branch 'master' into DateTime64_extended_range 2021-03-05 03:07:19 +03:00
Nikita Mikhaylov
37d4c69d3a
Merge pull request #21433 from azat/parsing-exception-message-fix
Fix ParsingException::displayText()
2021-03-05 01:59:06 +03:00
Denis Zhuravlev
c0eefb644e test for #21413 2021-03-04 16:58:12 -04:00
Azat Khuzhin
7794ac66d4 Fix flaky tests with distributed queries
There was few attempts to fix this [1] and [2], but it still pops up
sometimes, for example here [3].

  [1]: 009f57fc2f / #11211
  [2]: cdb6bed8b9 / #14198
  [3]: https://clickhouse-test-reports.s3.yandex.net/21318/38be9ff43ac4c46ce6e803fc125d910bde1d4c71/functional_stateless_tests_(release,_databasereplicated).html#fail1

Let's use more generic approach, and do not hide any errors (and see
does increasing timeout will be enough).
2021-03-04 22:48:04 +03:00
Denis Zhuravlev
102a0b2c5d test for #21413 2021-03-04 10:46:01 -04:00
Ivan
218542589a
Merge pull request #19673 from azat/distributed-bytes_to_throw_insert
Add ability to throttle INSERT into Distributed
2021-03-04 13:28:23 +03:00
Nikolai Kochetov
b985e33294
Merge pull request #21434 from azat/dist-query-SIGSEGV-on-exception-fix
Fix SIGSEGV for distributed queries on failures
2021-03-04 11:32:17 +03:00
Azat Khuzhin
45ca803973 Fix logging for optimize_aggregation_in_order=1 (with small max_block_size) 2021-03-04 10:34:41 +03:00
Alexey Milovidov
78cc708816 Fix bad whitespaces in test 2021-03-04 02:15:33 +03:00
Azat Khuzhin
e858dae187 Fix SIGSEGV for distributed queries on failures
Since after pull(), cancel() will be called, and this will lead to
SIGSEGV, since there is no exception, but has_exception was not reseted
in pull()
2021-03-04 00:42:49 +03:00
Azat Khuzhin
e7948819f9 Fix ParsingException::displayText()
Before it was silently try-catched for messages with additional {}, and
it is very easy to trigger, i.e.:

    SELECT toDateTime(format('{}-{}-01 00:00:00', '2021', '1'))

Will print:

    Code: 41. DB::Exception: Received from localhost:9000. DB::Exception: Cannot parse datetime 2021-1-01 00:00:00{}: Cannot parse DateTime from String: while executing 'FUNCTION toDateTime(format('{}-{}-01 00:00:00', '2021', '1') :: 3) -> toDateTime(format('{}-{}-01 00:00:00', '2021', '1')) DateTime : 2'.
2021-03-03 23:44:51 +03:00
Alexey Milovidov
4e8239e098 Merge branch 'master' into DateTime64_extended_range 2021-03-03 23:43:20 +03:00
Azat Khuzhin
a57c646467 Fix 01293_system_distribution_queue flakiness 2021-03-03 23:30:24 +03:00
Azat Khuzhin
9a4f469a38 Fix 00753_distributed_system_columns_and_system_tables flakiness 2021-03-03 23:30:24 +03:00
Azat Khuzhin
6965ac26c3 Distributed: Add ability to delay/throttle INSERT until pending data will be reduced
Add two new settings for the Distributed engine:
- bytes_to_delay_insert
- max_delay_to_insert

If at the beginning of INSERT there will be too much pending data, more
then bytes_to_delay_insert, then the INSERT will wait until it will be
shrinked, and not more then max_delay_to_insert seconds.

If after this there will be still too much pending, it will throw an
exception.

Also new profile events were added (by analogy to the MergeTree):
- DistributedDelayedInserts (although you can use system.errors instead
  of this, but still)
- DistributedRejectedInserts
- DistributedDelayedInsertsMilliseconds
2021-03-03 23:30:23 +03:00
Azat Khuzhin
cabe4ca1bb tests: split 00753_system_columns_and_system_tables (to disable Distributed part for arcadia) 2021-03-03 23:30:03 +03:00
Azat Khuzhin
3102835d56 tests: Use total_bytes>0 for Distributed engine in 00753_system_columns_and_system_tables 2021-03-03 23:30:03 +03:00
Azat Khuzhin
b43046ba06 Distributed: More accurate distribution_queue counters
So now system.distribution_queue will show accurate statistics, so tests
does not requires sleep anymore.

But note that with too much distributed pending this will iterate over
all directories.
2021-03-03 23:30:03 +03:00
Azat Khuzhin
b5a5778589 Distributed: Add ability to limit amount of pending bytes for async INSERT
Right now with distributed_directory_monitor_batch_inserts=1 and
insert_distributed_sync=0 INSERT into Distributed table will store
blocks that should be sent to remote (and in case of
prefer_localhost_replica=0 to the localhost too) on the local
filesystem, and sent it in background.

However there is no limit for this storage, and if the remote is
unavailable (or some other error), these pending blocks may take
significant space, and this is not always desired behaviour.

Add new Distributed setting - bytes_to_throw_insert, that will set the
limit for how much pending bytes is allowed, if the limit will be
reached an exception will be throw.

By default was set to 0, to avoid surprises.
2021-03-03 23:30:00 +03:00
Azat Khuzhin
ce09b7ff89 Distributed: Implement totalBytes() (system.tables.total_bytes) 2021-03-03 23:29:11 +03:00
Alexey Milovidov
e8df9971f1 Fix Arcadia 2021-03-03 18:12:39 +03:00
alesapin
6b1005aea5
Merge pull request #21334 from ClickHouse/fix_alter_partition_key
Fix alter modify query for partition key and other metadata fields
2021-03-03 10:15:11 +03:00
alexey-milovidov
36c5fd840b
Merge pull request #21392 from ClickHouse/add-test-14740
Add a test for #14740
2021-03-03 06:33:18 +03:00
Alexey Milovidov
71b52542d9 Add to skip list for parallel runs 2021-03-03 04:37:11 +03:00
Alexey Milovidov
8f45ed5117 Add a test for #15469 2021-03-03 04:35:43 +03:00
alexey-milovidov
9092bc3b85
Merge pull request #21387 from den-crane/tests/issue21369
test for issue#21369
2021-03-03 03:05:01 +03:00
Anton Popov
a4c00ab5dc
Merge pull request #21303 from ucasFL/forbid
Forbid to drop a column if it's referenced by materialized view
2021-03-03 02:55:06 +03:00
Alexey Milovidov
a93e29ef4a Add a test for #14740 2021-03-03 02:00:19 +03:00
Denis Zhuravlev
1278b5c71a test for issue#21369 2021-03-02 16:29:11 -04:00
Nikolai Kochetov
8e6fa404c4
Merge pull request #21246 from ucasFL/union-distinct-improve
Improve Normalization of ASTSelectWithUnionQuery
2021-03-02 21:37:07 +03:00
Vasily Nemkov
f4b2cbc30f Fixed tests 2021-03-02 15:55:17 +02:00
ikarishinjieva
6fb68cd454 add functional test on fix #21170 2021-03-02 16:28:34 +03:00
Vasily Nemkov
bfc5cb47cc Fix tests 2021-03-02 15:21:13 +02:00
alesapin
06678d650d Merge branch 'master' into fix_alter_partition_key 2021-03-02 13:43:41 +03:00
alesapin
9ebf1b4fad Get rid of separate minmax index fields 2021-03-02 13:33:54 +03:00
Vasily Nemkov
6af4d06dff Added Grant, Revoke and System query_kind for system.query_log
Also some tests to ensure that all queries are logged
2021-03-02 12:27:39 +02:00
feng lv
a26c9e64a9 fix
fix
2021-03-02 03:20:03 +00:00
Nikolai Kochetov
f82e00ff3c Fix inconsistent column type for Values input format. 2021-03-01 23:10:50 +03:00
Alexander Kuzmenkov
977b98ad69
Merge pull request #21094 from den-crane/tests/window_functions
test for window functions
2021-03-01 19:00:45 +03:00
Alexander Kuzmenkov
366fba4b04
Update 01592_long_window_functions1.sql 2021-03-01 16:06:44 +03:00
Anton Popov
c98e6bb1ad
Merge pull request #20550 from ClickHouse/fix-number-of-threads-in-subqueries
Fix number of threads in subqueries
2021-03-01 15:49:38 +03:00
alesapin
9c8afbeb53 Fix alter modify query for partition key and other metadata fields 2021-03-01 12:59:19 +03:00
Nikolai Kochetov
976dbe8077
Merge pull request #20341 from ClickHouse/filter-push-down
Filter push down
2021-03-01 12:35:06 +03:00
vdimir
b7c7c97d10
Merge branch 'master' into join-cast-types-v2 2021-03-01 11:42:21 +03:00
Nikolai Kochetov
eb42896e26 Merge branch 'master' into ucasFL-union-distinct-improve 2021-03-01 10:43:39 +03:00
alexey-milovidov
3bd180c416
Merge pull request #20149 from keen-wolf/timezone_about
fix toMinute function to handle special timezone
2021-02-28 21:53:51 +03:00
feng lv
51021c1164 forbid to drop a column if it's referenced by materialized view 2021-02-28 05:24:39 +00:00
Alexey Milovidov
107d8ec811 Merge branch 'master' into extract-text-from-html 2021-02-28 04:03:32 +03:00
alexey-milovidov
470bc2b01b
Merge pull request #21279 from kssenii/add-tests
Add tests for zstd and zlib http compression
2021-02-28 01:33:21 +03:00
Alexey Milovidov
0ab4afeeed Tests and documentation 2021-02-28 00:55:56 +03:00
Alexey Milovidov
2ac673b12a Update logic and tests 2021-02-27 22:33:55 +03:00
Alexey Milovidov
fd1cf49e92 Rewrite extractTextFromHTML function 2021-02-27 22:22:38 +03:00
kssenii
4f61ef3099 Tests for zstd and zlib 2021-02-27 14:12:45 +00:00
alexey-milovidov
56af09891b
Merge pull request #20991 from kssenii/brotli
Fix Brotli http compression issue
2021-02-27 16:39:49 +03:00
Maksim Kita
9996f68160
Merge pull request #20990 from kitaisreal/constraints-complex-type-support
Constraints complex types support
2021-02-27 13:16:29 +03:00
Vladimir
df728dc4ba
Merge pull request #21248 from vdimir/fix-join-totals-nullable
Convert columns to nullable for totals in join
2021-02-27 11:31:02 +03:00
feng lv
4ac5b62f19 Merge branch 'master' of github.com:ClickHouse/ClickHouse into union-distinct-improve 2021-02-27 08:02:41 +00:00
Alexander Tokmakov
fb42dec355 fix 2021-02-27 01:20:49 +03:00
Nikolai Kochetov
d91b8a3acb
Merge branch 'master' into filter-push-down 2021-02-26 19:33:27 +03:00
Nikolai Kochetov
d328bfa41f Review fixes. Add setting max_optimizations_to_apply. 2021-02-26 19:29:56 +03:00
Maksim Kita
2679613503
Added test to skip list DatabaseReplicated 2021-02-26 18:37:57 +03:00
kssenii
991718d459 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into brotli 2021-02-26 14:31:24 +00:00
vdimir
932286df1f
Convert columns to nullable for totals in join 2021-02-26 16:32:34 +03:00
feng lv
4c30c10092 add test
fix
2021-02-26 12:14:57 +00:00
Anton Popov
6ed3cf5511 Merge remote-tracking branch 'upstream/master' into HEAD 2021-02-26 15:10:52 +03:00
Alexander Tokmakov
422e083c96 move more code 2021-02-26 14:43:58 +03:00
Vladimir
78024ae2d6
Merge pull request #21009 from vdimir/fix-race-storage-join 2021-02-26 14:26:10 +03:00
Maksim Kita
c51773d2b3 Updated test 2021-02-26 12:11:30 +03:00
Nikolai Kochetov
f63d7b45ce Merge branch 'master' into fix-number-of-threads-in-subqueries 2021-02-26 11:15:03 +03:00
Anton Popov
5482a82342 skip test 2021-02-26 00:34:35 +03:00
Alexander Tokmakov
d46fee0f04 Merge branch 'master' into stress_test_results 2021-02-26 00:24:22 +03:00
vdimir
9c1ba71416
Merge remote-tracking branch 'upstream/master' into fix-race-storage-join 2021-02-25 19:13:49 +03:00
Alexander Tokmakov
fbbb0c4b69 fix 2021-02-25 19:11:43 +03:00
vdimir
4c6cde4d53
Merge remote-tracking branch 'upstream/master' into join-cast-types-v2 2021-02-25 16:24:28 +03:00
Maksim Kita
23af53067d Updated support for Nullable column 2021-02-25 14:27:46 +03:00
Maksim Kita
8fec34af12 Constraints complex types support 2021-02-25 14:27:46 +03:00
alesapin
5c6c318737 Restrict mutations for engines which doesn't support them 2021-02-25 13:07:48 +03:00
vdimir
2f70e895fc
Update StorageJoin locking
Move joinGet into StorageJoin

Protect JoinSource with lock, add test

Add comments about locking logic
2021-02-25 12:31:22 +03:00
Vladimir
36c178c023
Merge pull request #21117 from amosbird/joingetlc 2021-02-25 10:06:57 +03:00
Vitaly Baranov
8601b2f3e7
Merge pull request #21148 from vitlibar/protobuf-format-better-tests-2
Better tests for protobuf format #2.
2021-02-25 06:01:47 +03:00
Anton Popov
94156986bf add test for map with integer keys 2021-02-24 21:15:42 +03:00