Commit Graph

10367 Commits

Author SHA1 Message Date
Robert Schulze
cc24fcd6d5
Merge pull request #41873 from ClickHouse/generated-file-cleanup
Consolidate CMake-generated config headers
2022-10-06 14:31:03 +02:00
Raúl Marín
adbaaca2f5
QOL log improvements (#41947)
* Uniformize disk reservation logs

* Remove log about destroying stuff that appears all the time

* More tweaks on disk reservation logs

* Reorder logs in hash join

* Remove log that provides little information

* Collapse part removal logs

Co-authored-by: Sergei Trifonov <sergei@clickhouse.com>
2022-10-06 14:22:44 +02:00
Robert Schulze
78be400ac0
Merge remote-tracking branch 'origin/master' into generated-file-cleanup 2022-10-06 12:22:43 +00:00
Nikita Mikhaylov
860e34e760
Resurrect parallel distributed insert select with s3Cluster (#41535) 2022-10-06 13:47:32 +02:00
Nikita Mikhaylov
766107df0a
Fixed the restriction on maximum size of replicated fetches (#42090) 2022-10-06 13:18:46 +02:00
Anton Popov
aabec50988
Merge pull request #42040 from CurtizJ/async-inserts-log
Add system table `asynchronous_insert_log`
2022-10-06 13:14:41 +02:00
alesapin
adb34f6eae
Merge branch 'master' into fix_one_more_no_such_key 2022-10-06 12:42:16 +02:00
alesapin
6d24e16fda
Merge pull request #42067 from ClickHouse/fix_drop_of_completely_dropped_table
Fix drop of completely dropped table
2022-10-06 12:40:38 +02:00
Kseniia Sumarokova
3cff776109
Merge pull request #41254 from filimonov/system_disks_unreserved_space
Add unreserved_space column to system.disks
2022-10-06 12:28:23 +02:00
Vladimir C
97fb381255
Merge pull request #41813 from zhongyuankai/fix_dist_msg 2022-10-06 11:19:56 +02:00
Vladimir C
3f24c904ad
Merge pull request #41842 from amosbird/index_analysis_1 2022-10-06 11:14:21 +02:00
Robert Schulze
da5a2e2db0
Merge remote-tracking branch 'origin/master' into generated-file-cleanup
Physical merge conflicts:
- src/Common/ZooKeeper/ZooKeeperImpl.cpp
- src/Core/config_core.h.in
- src/Functions/FunctionsAES.h
- src/Functions/config_functions.h.in
- src/configure_config.cmake

Logical merge conflicts:
- Functions/tryDecrypt.cpp
2022-10-06 08:43:25 +00:00
Anton Popov
190e1f6830
Merge branch 'master' into async-inserts-log 2022-10-06 01:59:27 +02:00
alesapin
1541d68607 Better exception 2022-10-05 20:40:35 +02:00
alesapin
4ed522d2a0 Fix 2022-10-05 20:36:55 +02:00
alesapin
cf145910e3 Revert first fix 2022-10-05 20:34:48 +02:00
alesapin
644376aa2c Better fix 2022-10-05 20:32:43 +02:00
Anton Popov
f7cf35d1dd
Merge pull request #42072 from CurtizJ/fix-fuzzer-4
Fix assertion in bloom filter index
2022-10-05 16:38:13 +02:00
alesapin
e6fe71b385
Update src/Storages/StorageReplicatedMergeTree.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2022-10-05 16:12:08 +02:00
alesapin
63be310441
Update src/Storages/StorageReplicatedMergeTree.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2022-10-05 16:12:03 +02:00
Anton Popov
f61e98f0e8
Merge pull request #40668 from ClickHouse/async-insert-max-data-size-fix
Use settings from query context for async INSERTs
2022-10-05 15:15:19 +02:00
Anton Popov
02cdc20d5d
Merge pull request #40096 from CurtizJ/fuzz-table-definitions
Add fuzzer for table definitions
2022-10-05 14:53:48 +02:00
Anton Popov
2f423071f2 fix assertion in bloom filter index 2022-10-04 19:27:56 +00:00
Nikita Mikhaylov
2933a28a5d
Add log message and lower the retry timeout in MergeTreeRestartingThread (#42026) 2022-10-04 20:07:11 +02:00
alesapin
425b296928 Revert "Revert "Merge pull request #41832 from ClickHouse/make_copy_instead_of_hardlink""
This reverts commit f50d46fb8c.
2022-10-04 17:40:23 +02:00
alesapin
6f185333ff Fix drop completely dropped table one more time 2022-10-04 17:39:28 +02:00
alesapin
f50d46fb8c Revert "Merge pull request #41832 from ClickHouse/make_copy_instead_of_hardlink"
This reverts commit 0097f15ee7, reversing
changes made to 4e422b8046.
2022-10-04 17:33:01 +02:00
alesapin
2bfae244cc Add comments 2022-10-04 17:30:25 +02:00
alesapin
4a6fa10e71
Merge branch 'master' into fix_one_more_no_such_key 2022-10-04 15:19:05 +02:00
Anton Popov
9a2cabd3a1
Merge branch 'master' into async-inserts-log 2022-10-04 15:10:50 +02:00
Anton Popov
8ca73eab03
Merge branch 'master' into fuzz-table-definitions 2022-10-04 15:10:31 +02:00
Kseniia Sumarokova
6d02fa3c5f
Merge pull request #42022 from kssenii/better-exception-merge-tree-data-load-parts
More detailed exception message
2022-10-04 11:20:35 +02:00
Anton Popov
148995894f add system table asynchronous_inserts_log 2022-10-03 21:35:55 +00:00
alesapin
210882b9c4 Better fix 2022-10-03 23:30:50 +02:00
Anton Popov
5cb6357549 fix style check 2022-10-03 19:37:27 +00:00
Sergei Trifonov
4b4fae5bb1
Merge branch 'master' into remove-table-is-dropped-exception-when-not-needed 2022-10-03 19:52:08 +02:00
alesapin
71e1b1df73 add comment 2022-10-03 19:09:24 +02:00
alesapin
3114ddcad2 Fix failure during table drop 2022-10-03 19:06:12 +02:00
Alexey Milovidov
c8872fe96d
Merge pull request #42001 from ClickHouse/part-thresholds-override-more-sane
More sane behavior of part number thresholds override in query level settings
2022-10-03 17:25:39 +03:00
Anton Popov
6e61cf92f5 Merge remote-tracking branch 'upstream/master' into HEAD 2022-10-03 13:16:57 +00:00
Kseniia Sumarokova
0bfbb5c38a
Merge branch 'master' into system_disks_unreserved_space 2022-10-03 14:25:47 +02:00
kssenii
0dc71e9883 More detailed exception message 2022-10-03 14:21:53 +02:00
Alexander Tokmakov
00914a174d
Merge pull request #41410 from ClickHouse/keeper-multiread
Add MultiRead support in Keeper and internal ZK client
2022-10-03 14:17:57 +03:00
Alexander Tokmakov
a2c29076d6 avoid detached broken part duplicates 2022-10-03 12:27:17 +02:00
Alexander Tokmakov
3f9c9c9a77 fix intersecting part if session expired during queue initialization 2022-10-03 12:27:17 +02:00
Alexander Tokmakov
7b5b7e4963
Merge pull request #41945 from ClickHouse/enable_more_s3_tests
Enable some disabled S3 tests
2022-10-03 13:25:50 +03:00
Robert Schulze
db5ef7b3cb
Merge branch 'master' into generated-file-cleanup 2022-10-02 23:13:18 +02:00
Alexey Milovidov
0da9ed8a18
Merge branch 'master' into part-thresholds-override-more-sane 2022-10-02 02:26:21 +03:00
Alexander Tokmakov
e40917a9c5 fix 2022-10-02 00:44:46 +02:00
Alexey Milovidov
7b71524109 More sane behavior of part number thresholds override in query level settings 2022-10-01 20:18:12 +02:00
Vitaly Baranov
c16ae1b916
Merge pull request #41980 from vitlibar/remove-warning-when-perform-ttl-move-on-insert-false
Remove confusing warning when perform_ttl_move_on_insert is false
2022-10-01 15:32:34 +02:00
Kseniia Sumarokova
59596e9067
Merge pull request #41970 from kssenii/fix-use-env-credentials-s3
Fix use_environment_credentials for s3 table function
2022-10-01 13:54:58 +02:00
Vitaly Baranov
7be9744bab Remove confusing warning when inserting with perform_ttl_move_on_insert=false. 2022-09-30 20:51:48 +02:00
alesapin
00bf90186a Better 2022-09-30 19:03:54 +02:00
alesapin
350ff96628 Fix potential race condition with broken parts 2022-09-30 19:01:06 +02:00
avogar
c74b5c8126 Fix schema inference in s3Cluster and improve in hdfsCluster 2022-09-30 16:59:17 +00:00
Anton Popov
9916e35b3f
Merge pull request #41701 from CurtizJ/fix-monotonic-order-by
Fix `ORDER BY` monotonic functions
2022-09-30 17:32:37 +02:00
kssenii
fb3bcd2fe9 Fix use_environment_credentials 2022-09-30 12:25:39 +02:00
Vladimir C
895afdec45
Merge pull request #40893 from ClickHouse/vdimir/track-tmp-disk 2022-09-30 11:27:24 +02:00
Robert Schulze
cc92a2d174
Merge branch 'master' into generated-file-cleanup 2022-09-30 09:56:31 +02:00
Daniil Rubin
97dd75194a Remove unused error code 2022-09-29 20:36:54 +00:00
Daniil Rubin
9f626585aa Merge branch 'hudi' of github.com:rubin-do/ClickHouse into hudi 2022-09-29 20:15:59 +00:00
Daniil Rubin
74f026ba65 Change logic error, add format argument to Hudi engine 2022-09-29 20:15:27 +00:00
alesapin
0097f15ee7
Merge pull request #41832 from ClickHouse/make_copy_instead_of_hardlink
Use copy for some operations instead of hardlinks
2022-09-29 17:12:08 +02:00
Alexander Tokmakov
4e422b8046
Merge pull request #41741 from ClickHouse/fix_intersecting_parts
Fix intersecting parts
2022-09-29 18:00:22 +03:00
Amos Bird
44eaa9583b
Merge branch 'master' into index_analysis_1 2022-09-29 20:25:03 +08:00
Antonio Andelic
94f1fe39bb Add support for exists in multiread 2022-09-29 10:39:33 +00:00
vdimir
c0898ce289
Use abstraction for temporary data on disk in Sort and Aggregation 2022-09-29 09:51:41 +00:00
Antonio Andelic
fcc54104a4 Define methods for multi read requests 2022-09-29 09:19:47 +00:00
Antonio Andelic
3109ce51c6 Merge branch 'master' into keeper-multiread 2022-09-29 06:50:49 +00:00
Alfonso Martinez
981f2e119f Forgot to add function to header 2022-09-29 08:44:10 +02:00
Daniil Rubin
0d3670d516 Fix typo 2022-09-28 17:30:15 +00:00
Alfonso Martinez
261ab8e1d0 Fixed style 2022-09-28 18:59:07 +02:00
Alfonso Martinez
65b161341c Replaced changed functions for tryLockForShare 2022-09-28 18:08:10 +02:00
Anton Popov
34bc16cd5b avoid more useless errors 2022-09-28 15:55:39 +00:00
Alfonso Martinez
6bb166b79b exception replaced by nullptr 2022-09-28 17:41:51 +02:00
alesapin
905d4585ac
Merge branch 'master' into make_copy_instead_of_hardlink 2022-09-28 16:47:45 +02:00
Robert Schulze
f24fab7747
Fix some #include atrocities 2022-09-28 13:49:28 +00:00
alesapin
072c19ba96
Merge pull request #41838 from tbsal/tbsal_34798
Improve feedback when replacing partition with different primary key
2022-09-28 15:33:11 +02:00
Robert Schulze
fd86829824
Consolidate config_core.h into config.h
Less duplication, less confusion ...
2022-09-28 13:31:57 +00:00
alesapin
1d9e126f94
Merge pull request #41856 from ClickHouse/fix_possible_no_such_key
Remove two redundant lines
2022-09-28 15:05:55 +02:00
Robert Schulze
09c62f6728
Consolidate config_formats.h into config.h
Less duplication, less confusion ...
2022-09-28 12:59:05 +00:00
Kruglov Pavel
6340369c2a
Merge branch 'master' into improve-combinators 2022-09-28 14:55:30 +02:00
Robert Schulze
0753fd1c77
Consolidate config_functions.h into config.h
Less duplication, less confusion ...
2022-09-28 12:48:26 +00:00
Robert Schulze
6d70b4a1f6
Generate config_version.h into ${CONFIG_INCLUDE_PATH}
This makes the target location consistent with other auto-generated
files like config_formats.h, config_core.h, and config_functions.h and
simplifies the build of clickhouse_common.
2022-09-28 12:48:26 +00:00
Robert Schulze
78fc36ca49
Generate config.h into ${CONFIG_INCLUDE_PATH}
This makes the target location consistent with other auto-generated
files like config_formats.h, config_core.h, and config_functions.h and
simplifies the build of clickhouse_common.
2022-09-28 12:48:26 +00:00
Daniil Rubin
95b5d2d29d
Merge branch 'master' into hudi 2022-09-28 14:24:55 +03:00
Daniil Rubin
db7cb4e9b5 apply clang-format 2022-09-28 11:21:32 +00:00
alesapin
2eef384807 Add comments and test 2022-09-28 13:09:48 +02:00
Alexey Milovidov
1653482406
Merge pull request #41823 from ClickHouse/trying_to_fix_compressed_marks
Fix compressed marks read for compact parts
2022-09-28 14:06:56 +03:00
Daniil Rubin
13e50c771c Fix bug, use static method 2022-09-28 11:03:43 +00:00
alesapin
9e77d520d4 Merge branch 'master' into make_copy_instead_of_hardlink 2022-09-28 12:10:00 +02:00
Kseniia Sumarokova
b0a362e403
Merge pull request #41839 from ClickHouse/kssenii-patch-5
Remove unused variable in registerStorageMergeTree.cpp
2022-09-28 11:58:01 +02:00
Antonio Andelic
a9f73d344d
Merge pull request #41784 from ClickHouse/fix-drop-keeper-map-again
Possible fix for KeeperMap drop
2022-09-28 10:28:50 +02:00
Robert Schulze
1885bb0524
Make comment consistent accross generated files 2022-09-28 08:11:09 +00:00
Robert Schulze
de3264691c
Merge pull request #41790 from ClickHouse/print-git-hash
Log git hash during startup
2022-09-28 09:43:17 +02:00
Alexey Milovidov
e5ffd74a56
Merge branch 'master' into trying_to_fix_compressed_marks 2022-09-28 02:30:10 +03:00
alesapin
57614b6869 Remove two redundant lines 2022-09-27 23:16:16 +02:00
Alexander Tokmakov
127fc9ce3c
Merge branch 'master' into fix_metadata_version_creation 2022-09-27 23:09:23 +03:00
alesapin
a75ab3c74d
Merge pull request #41789 from ClickHouse/fix_drop_completely_dropped_table
Fix drop of completely dropped table
2022-09-27 18:24:40 +02:00
Kseniia Sumarokova
85b44c909a
Update MergeTreeDataPartCompact.cpp 2022-09-27 18:16:58 +02:00
Alexander Tokmakov
287fe40173 Merge branch 'master' into fix_intersecting_parts 2022-09-27 16:55:39 +02:00
Salvatore Mesoraca
fc73b74379 Improve feedback when replacing partition with different primary key 2022-09-27 16:31:47 +02:00
Amos Bird
c39c138416
Better index analysis with NULL literal 2022-09-27 22:00:50 +08:00
Antonio Andelic
728fe5d06f
Change log level 2022-09-27 16:00:44 +02:00
alesapin
a20a9242a1 Fix order of arguments 2022-09-27 15:50:25 +02:00
Kseniia Sumarokova
2f237a8a2c
Update registerStorageMergeTree.cpp 2022-09-27 15:30:18 +02:00
alesapin
695133cc5b Better mutations 2022-09-27 15:23:02 +02:00
alesapin
d4d4f92976 Use copy for some operations instead of hardlinks 2022-09-27 14:38:13 +02:00
Antonio Andelic
265c8b3d26 Merge branch 'master' into keeper-multiread 2022-09-27 12:37:22 +00:00
kssenii
ce422052b0 Fix CANNOT_READ_ALL_DATA for compact parts in case compressed_marks=1 2022-09-27 14:27:56 +02:00
Alexander Tokmakov
19062e9d97
Update src/Storages/MergeTree/ReplicatedMergeTreeAttachThread.cpp
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
2022-09-27 14:26:45 +03:00
Alexander Gololobov
1719e000ea
Merge pull request #41763 from zhangjmruc/fix/disable_mergetree_table_with_lwd_virtual_column
Disable merge tree table with lightweight delete virtual column name _row_exists
2022-09-27 12:20:19 +02:00
Kseniia Sumarokova
caf6a99f41
Merge pull request #41011 from kssenii/fix-thread-status
Fix incorrect attach query in threadpool readers, get rid of static threadpools for reads/writes, make threadpool size for reads/writes configurable
2022-09-27 11:35:07 +02:00
Robert Schulze
588a5e5a42
Simplify a bit 2022-09-27 07:47:18 +00:00
Antonio Andelic
655bde8e3f Merge branch 'master' into keeper-upload-snapshot-to-s3 2022-09-27 07:28:26 +00:00
zhongyuankai
d497b72f80
Update DirectoryMonitor.cpp 2022-09-27 11:00:38 +08:00
Alexander Gololobov
f21f933da7
Merge branch 'master' into fix/disable_mergetree_table_with_lwd_virtual_column 2022-09-26 23:44:45 +02:00
Alexander Tokmakov
0f6a44efef fix missing metadata_version for old tables 2022-09-26 20:11:30 +02:00
Alexander Tokmakov
9501f88f8c
Merge branch 'master' into fix_intersecting_parts 2022-09-26 19:53:59 +03:00
Alexander Tokmakov
49983dafeb fix 2022-09-26 17:13:10 +02:00
alesapin
31f6636a47 Fix endless remove 2022-09-26 16:33:25 +02:00
Antonio Andelic
5c8ce2f543 More correct 2022-09-26 14:30:29 +00:00
Robert Schulze
ec35ff9cd6
Log git hash during startup
We currently only log a compiler-generated "build id" at startup which
is different for each build. That makes it useless to determine the
exact source code state in tests (e.g. BC test) and from user log files
(e.g. if someone compiled an intermediate version of ClickHouse).

Current log message:
  Starting ClickHouse 22.10.1.1 with revision 54467, build id: 6F35820328F89C9F36E91C447FF9E61CAF0EF019, PID 42633

New log message:
  Starting ClickHouse 22.10.1.1 (revision 54467, git hash: b6b1f7f763f94ffa12133679a6f80342dd1c3afe, build id: 47B12BE61151926FBBD230DE42F3B7A6652AC482), PID 981813
2022-09-26 14:12:36 +00:00
alesapin
e20d3803c4 Better fix 2022-09-26 15:40:25 +02:00
alesapin
2384761063 Fix drop of completely dropped table 2022-09-26 15:38:10 +02:00
Antonio Andelic
287d1e68b1 Fix KeeperMap drop again 2022-09-26 12:23:41 +00:00
Alexander Tokmakov
fdc10a9b39
Merge pull request #41728 from ClickHouse/fix_part_removal_retries
Fix part removal retries
2022-09-26 15:02:28 +03:00
Kruglov Pavel
3dc54272ed
Merge branch 'master' into improve-combinators 2022-09-26 13:03:32 +02:00
Nikita Mikhaylov
852d084950 Save 2022-09-26 10:24:39 +00:00
Nikita Mikhaylov
a089ab9238 Style 2022-09-26 10:24:39 +00:00
Nikita Mikhaylov
636cedf488 Better 2022-09-26 10:24:39 +00:00
Antonio Andelic
97385ca861 Format 2022-09-26 09:33:50 +00:00
Antonio Andelic
cc3719e463 Use multiread 2022-09-26 09:07:34 +00:00
jianmei zhang
cf40c57562 Disable mergetree table with lightweight delete column name 2022-09-26 15:33:43 +08:00
Igor Nikonov
c721c6dc0c
Merge pull request #41014 from ClickHouse/distinct_in_order_wo_order_by
Reading in order for DISTINCT without ORDER BY
2022-09-24 18:49:52 +02:00
Kseniia Sumarokova
50f7ce6107
Merge branch 'master' into fix-thread-status 2022-09-24 17:22:45 +02:00
alesapin
5852df7f65
Merge branch 'master' into fix_part_removal_retries 2022-09-24 17:06:32 +02:00
alesapin
ce2c2b5310 Merge branch 'master' into fix_intersecting_parts 2022-09-24 17:00:54 +02:00
alesapin
34d9794ab7
Merge pull request #41653 from ClickHouse/investigating_more_bugs
Add very explicit logging on disk choice for fetch
2022-09-24 16:15:02 +02:00
Alexander Tokmakov
a2b8c4926e fix intersecting parts 2022-09-23 20:51:44 +02:00
kssenii
0a801dad2a Merge remote-tracking branch 'upstream/master' into fix-thread-status 2022-09-23 19:39:07 +02:00
Igor Nikonov
f77660ed2a
Merge branch 'master' into distinct_in_order_wo_order_by 2022-09-23 18:39:20 +02:00
Anton Popov
41fc531ac6
Merge branch 'master' into fix-monotonic-order-by 2022-09-23 17:12:36 +02:00
kssenii
ab702e43fc Merge remote-tracking branch 'upstream/master' into fix-thread-status 2022-09-23 15:21:33 +02:00
Alexander Tokmakov
0eeb2de074
Merge pull request #41699 from ClickHouse/tavplubix-patch-5
Check if part mutation is cancelled
2022-09-23 15:46:28 +03:00
Nikita Mikhaylov
dbcba1490c
Try to make MergeTreeRestartingThread more reactive in case of expired sessions (#41092) 2022-09-23 14:40:04 +02:00
Alexander Tokmakov
2c16232b02 fix part removal retries 2022-09-23 14:39:05 +02:00
alesapin
148f018eae Fix style: 2022-09-23 14:32:19 +02:00
alesapin
dff61267b4 More explicit logs 2022-09-23 14:31:05 +02:00
Kseniia Sumarokova
ea43cb5648
Merge pull request #41261 from kssenii/s3-header-auth
Support s3 authorisation headers from ast arguments
2022-09-23 12:48:08 +02:00
Igor Nikonov
6f7d0fec52 Merge remote-tracking branch 'origin/master' into distinct_in_order_wo_order_by 2022-09-22 19:38:34 +00:00
Anton Popov
4c7a820685 fix order by monotonic functions 2022-09-22 16:21:28 +00:00
Kseniia Sumarokova
9e97ca1df7
Update src/Storages/StorageS3.h
Co-authored-by: Nikolay Degterinsky <43110995+evillique@users.noreply.github.com>
2022-09-22 17:59:26 +02:00
Alexander Tokmakov
981c1e95c6
Update MutateTask.cpp 2022-09-22 18:51:27 +03:00
Antonio Andelic
e36a53a762
Merge pull request #41616 from ClickHouse/fix-keeper-map-drop
Fix drop for KeeperMap
2022-09-22 15:43:23 +02:00
Nikolai Kochetov
63e757a659
Merge pull request #36379 from amosbird/projection-compatibility-fix
Make minmax_count projection backward compatible
2022-09-22 14:15:35 +02:00
Nikolai Kochetov
3b63719ece
Merge pull request #41619 from den-crane/patch-50
increase default max_suspicious_broken_parts to 100
2022-09-22 13:25:22 +02:00
alesapin
ca410b7a0b
Merge pull request #41147 from ClickHouse/enable_projections_and_zero_copy
Enable projections and zero copy replication
2022-09-22 13:05:09 +02:00
alesapin
a95e291474
Merge branch 'master' into investigating_more_bugs 2022-09-22 12:51:55 +02:00
alesapin
57be648984
Merge pull request #41649 from ClickHouse/supress_one_more_key_doesnt_exists
Release AWS SDK log level + replace one exception
2022-09-22 12:38:03 +02:00
Igor Nikonov
8c93a9adda Merge remote-tracking branch 'origin/master' into distinct_in_order_wo_order_by 2022-09-22 07:40:14 +00:00
Alexey Milovidov
93ed8e0c7b Update version to 22.10.1.1 2022-09-22 09:32:38 +02:00
Alexey Milovidov
2a75e025f2
Merge pull request #40715 from ClickHouse/compress-marks
Merging #37693: Compress marks and primary key
2022-09-22 07:30:34 +03:00
Alexey Milovidov
45afacdae4
Merge pull request #41186 from ClickHouse/fix-three-fourth-of-trash
Fix more than half of the trash
2022-09-22 07:28:26 +03:00
alesapin
9c433c14d1 Add very explicit logging on disk choice for fetch 2022-09-21 21:33:28 +02:00
alesapin
499f678112 Release AWS SDK log level + replace one exception 2022-09-21 19:56:42 +02:00
Nikita Taranov
100c055510
Prefetching in aggregation (#39304)
* impl

* stash

* clean up

* do not apply when HT is small

* make branch static

* also in merge

* do not hardcode look ahead value

* fix

* apply to methods with cheap key calculation

* more tests

* silence tidy

* fix build

* support HashMethodKeysFixed

* apply during merge only for cheap

* stash

* fixes

* rename method

* add feature flag

* cache prefetch threshold value

* fix

* fix

* Update HashMap.h

* fix typo

* 256KB as default l2 size

Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
2022-09-21 18:59:07 +02:00
Daniil Rubin
4d1abdc808 Remove unneeded logging, add comment, better 2022-09-21 16:54:02 +00:00
Daniil Rubin
3f7779e874 Rename method, change parsing method 2022-09-21 16:14:51 +00:00
kssenii
e34101456a Fix 2022-09-21 17:11:37 +02:00
Denny Crane
75cf53c06e
increase default max_suspicious_broken_parts to 100 2022-09-21 11:10:19 -03:00
Antonio Andelic
1d0ae8ae88
Update src/Storages/StorageKeeperMap.cpp 2022-09-21 15:17:44 +02:00
Antonio Andelic
0e063e6724 Fix drop for KeeperMap 2022-09-21 13:08:15 +00:00
Robert Schulze
186d4e4140
Merge pull request #40818 from Vector-Similarity-Search-for-ClickHouse/annoy
Add annoy index
2022-09-21 13:42:43 +02:00
Kseniia Sumarokova
1e7308832c
Merge branch 'master' into system_disks_unreserved_space 2022-09-21 13:04:39 +02:00
kssenii
f917b268b3 Merge remote-tracking branch 'upstream/master' into s3-header-auth 2022-09-21 12:56:25 +02:00
alesapin
3e74b783c2
Merge pull request #41530 from ClickHouse/fix_parts_removal_on_drop
Slightly better parts removal on drop + add unrelated test
2022-09-21 12:42:41 +02:00
alesapin
e91fae627c
Merge pull request #41569 from ClickHouse/fix_lost_table_shared_id
Fix lost table shared id
2022-09-21 12:36:12 +02:00
Antonio Andelic
fc6c1faa57 Merge branch 'master' into keeper-upload-snapshot-to-s3 2022-09-21 06:57:58 +00:00
Alexey Milovidov
45bd3cfc30 Merge branch 'master' into fix-three-fourth-of-trash 2022-09-20 21:27:41 +02:00
alesapin
4bd667c6b7 Drop all WALs 2022-09-20 18:28:15 +02:00
alesapin
acde29e314 Nasty code 2022-09-20 17:55:06 +02:00
Daniil Rubin
8fe4485ee8 Change JSON parsing 2022-09-20 14:16:27 +00:00
alesapin
ffa9ab1d1c
Merge branch 'master' into enable_projections_and_zero_copy 2022-09-20 14:58:03 +02:00
alesapin
35e7287471 Revert "Fix parts removal on drop + add unrelated test"
This reverts commit 0027934d27.
2022-09-20 14:53:05 +02:00
alesapin
cfe398cbbc Fix lost table shared id during server restart 2022-09-20 14:51:16 +02:00
alesapin
0027934d27 Fix parts removal on drop + add unrelated test 2022-09-20 14:29:56 +02:00
Filatenkov Artur
2139d5be17
Merge branch 'master' into annoy 2022-09-20 15:28:08 +03:00
alesapin
8ba74d8655 Fix bugs found by CI 2022-09-20 14:00:57 +02:00
Daniil Rubin
745331a3f3 Add format argument with default value to storage 2022-09-20 11:43:20 +00:00
Igor Nikonov
9c995b9e2a Merge remote-tracking branch 'origin/master' into distinct_in_order_wo_order_by 2022-09-20 11:29:23 +00:00
kssenii
6d75f9c0bb Add has_lightweight_delete to system.parts 2022-09-20 13:17:00 +02:00
alesapin
8d88b68a85
Merge pull request #41415 from ClickHouse/revert_prefixes_s3
Revert prefixes s3 + add retries on write requests unexpected errors
2022-09-20 12:55:04 +02:00
alesapin
66dc1e5597 Merge branch 'master' into fix_parts_removal_on_drop 2022-09-20 12:35:03 +02:00
alesapin
740b0b5cc0 Fix parts removal on drop + add unrelated test 2022-09-20 12:32:05 +02:00
alesapin
e9d31977f3
Merge branch 'master' into enable_projections_and_zero_copy 2022-09-20 12:25:10 +02:00
Daniil Rubin
3fb26aefa3 Remove unneeded logging, better 2022-09-20 10:24:47 +00:00
Kseniia Sumarokova
fb93ca7ca8
Merge pull request #41510 from kssenii/maybe-fix-storage-nats-tests
Try fix flaky test_storage_nats
2022-09-20 11:32:10 +02:00
Filatenkov Artur
be8221fae1
Correct work with negative distance 2022-09-20 09:48:33 +03:00
Alexey Milovidov
03bbf0676f
Merge branch 'master' into revert_prefixes_s3 2022-09-20 06:14:07 +03:00
Alexey Milovidov
7c299dc561
Update src/Storages/MergeTree/MergeTreeDataMergerMutator.cpp
Co-authored-by: Robert Schulze <robert@clickhouse.com>
2022-09-20 05:16:12 +03:00
Alexey Milovidov
e7525da88f
Update src/Storages/MergeTree/MergeTreePartsMover.cpp
Co-authored-by: Robert Schulze <robert@clickhouse.com>
2022-09-20 05:16:02 +03:00
Alexey Milovidov
4fcfcf282a
Update src/Storages/examples/merge_selector2.cpp
Co-authored-by: Robert Schulze <robert@clickhouse.com>
2022-09-20 05:15:47 +03:00
Sergei Trifonov
cf2db48c29
Merge pull request #40631 from ClickHouse/readonly-settings-allow
Allow to modify constrained settings in readonly mode
2022-09-20 02:18:14 +02:00
Filatenkov Artur
3598a7e680
Fix query type information 2022-09-20 01:03:55 +03:00
alesapin
ee24b21aaf Fix revert order 2022-09-19 21:19:36 +02:00
Sergei Trifonov
7902922ae4
Merge branch 'master' into readonly-settings-allow 2022-09-19 21:00:12 +02:00
serxa
2ef696ffe1 fix issues 2022-09-19 18:40:32 +00:00
Igor Nikonov
aca810ba62 Merge remote-tracking branch 'origin/master' into distinct_in_order_wo_order_by 2022-09-19 18:34:38 +00:00
alesapin
f67e23183f Fix parts removal on drop + add unrelated test 2022-09-19 20:19:49 +02:00
serxa
f8aa738511 more conventional profile events names 2022-09-19 17:23:22 +00:00
Daniil Rubin
0a1734bb69 Fix clang-tidy errors 2022-09-19 15:23:07 +00:00
Amos Bird
1a21f0a0f0
normalize ast for replicated metadata 2022-09-19 22:06:41 +08:00
Amos Bird
0bb70d4378
Make minmax_count projection backward compatible 2022-09-19 22:06:40 +08:00
Sergei Trifonov
ff2e1ff8d8
Merge branch 'master' into support_s3_api_event_metrics 2022-09-19 14:35:45 +02:00
Kruglov Pavel
47f6f09ce0
Merge branch 'master' into improve-combinators 2022-09-19 14:31:12 +02:00
kssenii
f8665c83da Add retries for nats 2022-09-19 14:27:11 +02:00
Sergei Trifonov
f7a1ed3141
Merge branch 'master' into readonly-settings-allow 2022-09-19 12:52:36 +02:00
Alexey Milovidov
45b6052b20 Merge branch 'master' into compress-marks 2022-09-19 10:57:05 +02:00
Alexey Milovidov
b87d12494e Fix build 2022-09-19 08:53:20 +02:00
Alexey Milovidov
730655d4fd Fix 8/9 of trash 2022-09-19 08:53:20 +02:00
Alexey Milovidov
ab4db2d0c4 Fix 5/6 of trash 2022-09-19 08:50:53 +02:00
Alexey Milovidov
d4b9fe41be
Merge pull request #41457 from ClickHouse/remove-trash-5
Remove trash from Field
2022-09-19 06:36:48 +03:00
Igor Nikonov
785c33bf7d Updating sort description for ReadFromMergeTree correctly 2022-09-18 23:35:21 +00:00
alesapin
a5a9d89fb9
Merge branch 'master' into enable_projections_and_zero_copy 2022-09-18 17:20:08 +02:00
alesapin
560bc2bc22
Merge pull request #41386 from ClickHouse/fix_redundant_fetch
Fix redundant fetch in zero copy replication
2022-09-18 15:57:27 +02:00
Alexey Milovidov
6b752bff3a
Merge branch 'master' into revert_prefixes_s3 2022-09-18 07:10:57 +03:00
Alexey Milovidov
791de6592b Remove trash from Field 2022-09-18 05:16:08 +02:00
Alexey Milovidov
f4a48cd4d6 Remove cruft 2022-09-17 22:16:31 +02:00
alesapin
33216dedf9
Merge pull request #41323 from ClickHouse/remove_bad_exception
Fix parts removal in case of connection loss
2022-09-17 19:14:53 +02:00
alesapin
dcb1586977 Add comment 2022-09-17 19:11:58 +02:00
alesapin
db30a3041e
Update src/Storages/MergeTree/MutateFromLogEntryTask.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2022-09-17 19:10:23 +02:00
Igor Nikonov
475443c10c
Merge pull request #41257 from ClickHouse/igor/mixed_improvements_along_the_way
Tiny improvements along the code
2022-09-17 10:43:46 +02:00
Alexey Milovidov
c09604bef2
Merge pull request #41363 from kitaisreal/small-style-fixes
Small style fixes
2022-09-17 00:19:00 +03:00
avogar
0101cc2e56 Support complex combinators in window transform, arrayReduce*, initializeAggregation and Aggregate functons versionning 2022-09-16 19:07:36 +00:00
Nikolai Kochetov
16f78eb804
Merge pull request #41281 from ClickHouse/fix-key-condition-with-actions-dag-literal-name
Fix wrong literal name in KeyCondition using ActionsDAG.
2022-09-16 16:06:38 +02:00
alesapin
d9c3549cc8 Revert s3 prefixes + add retries on write requests unexpected errors 2022-09-16 14:43:43 +02:00
alesapin
b4d2d217f4
Merge branch 'master' into enable_projections_and_zero_copy 2022-09-16 13:53:17 +02:00
alesapin
06ccdb1ecf Fix nasty bug 2022-09-16 13:49:39 +02:00
Alexander Tokmakov
9597a47016
Merge pull request #41379 from ClickHouse/tavplubix-patch-5
Fix an assertion in `wasInvolvedInTransaction`
2022-09-16 14:24:26 +03:00
Robert Schulze
b32b02d844
Merge pull request #40897 from ClickHouse/catboost-bridge-resurrected
Move CatBoost evaluation into clickhouse-library-bridge
2022-09-16 13:12:09 +02:00
alesapin
af259a2a68
Update src/Storages/MergeTree/MergeFromLogEntryTask.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2022-09-16 11:50:07 +02:00
Antonio Andelic
296fe01fb8 Merge branch 'master' into keeper-upload-snapshot-to-s3 2022-09-16 08:00:15 +00:00
Alexey Milovidov
da01982652
Merge pull request #41046 from azat/build/llvm-15
Switch to llvm/clang 15
2022-09-16 07:31:06 +03:00
Alexander Tokmakov
8301f5758b Update IMergeTreeDataPart.cpp 2022-09-15 21:32:57 +02:00
alesapin
be81d653e1 Fix comment 2022-09-15 18:56:16 +02:00
alesapin
b098c1be36 Fix data duplication in zero copy replication 2022-09-15 18:54:27 +02:00
Antonio Andelic
32a297339b Fix build 2022-09-15 13:36:16 +00:00
alesapin
7570c5cf67 Remove recursive without blobs 2022-09-15 15:31:19 +02:00
alesapin
c585ed47fc Forget to remove 2022-09-15 15:15:28 +02:00
alesapin
e127c8b4a9 Add kringe 2022-09-15 14:49:31 +02:00
alesapin
c04f7afb2a Delete kringe 2022-09-15 14:48:59 +02:00
Alexander Tokmakov
b26cc5a1ba
Merge pull request #41296 from young-scott/fix_issuse_41096
fix issue #41096
2022-09-15 15:44:05 +03:00
serxa
4971c1f04d review fixes 2022-09-15 11:34:14 +00:00
Maksim Kita
276d3628e9 Small style fixes 2022-09-15 13:05:18 +02:00
Antonio Andelic
9fdd2f2e61 Basic implementation for S3 snapshot upload 2022-09-15 09:11:55 +00:00
Alexander Tokmakov
173df9a73a
Update StorageSystemDDLWorkerQueue.cpp 2022-09-14 20:38:50 +03:00
alesapin
63213465ef Fix comment 2022-09-14 17:28:12 +02:00
alesapin
ad279940d6 Trying print less scary messages in case No such key for outdated parts 2022-09-14 17:25:58 +02:00
alesapin
d8c14ebcf6 Fixup 2022-09-14 16:44:40 +02:00
alesapin
9d3ab9a7f7 Merge branch 'master' into enable_projections_and_zero_copy 2022-09-14 15:16:16 +02:00
Anton Popov
3623807527
Merge pull request #41290 from CurtizJ/dynamic-columns-20
Fix `ALTER ADD COLUMN`  with columns of type `Object`
2022-09-14 14:15:29 +02:00
mateng0915
f7f976e94e remove extra space 2022-09-14 19:19:47 +08:00
mateng0915
5badb1b186 resolve the review comments 2022-09-14 19:19:40 +08:00
young scott
b6888022cd
Merge branch 'master' into fix_issuse_41096 2022-09-14 17:38:22 +08:00
young scott
bc111b5680 fix issuse#41096 2022-09-14 09:15:40 +00:00
Vladimir C
00d0b37cd0
Merge pull request #41263 from ClickHouse/vdimir/quorum-log-msg-fix 2022-09-14 10:54:21 +02:00
Anton Popov
ee54451741 fix adding of columns of type Object 2022-09-13 22:43:59 +00:00
Robert Schulze
e8e6dddc76
Merge pull request #41034 from FrankChen021/distributed
Improve the observability of INSERT on distributed table
2022-09-13 20:55:11 +02:00
Nikolai Kochetov
3f0bc94d25 Comment. 2022-09-13 18:50:01 +00:00
Nikolai Kochetov
66d9d92de4 Fix wrong literal name in KeyCondition using ActionsDAG. 2022-09-13 18:47:29 +00:00
alesapin
2cecf9e55f Fix bug 2022-09-13 18:30:55 +02:00
kssenii
52ef3758c4 Merge remote-tracking branch 'upstream/master' into fix-thread-status 2022-09-13 16:34:31 +02:00
Kseniia Sumarokova
2cd6ceb203
Update StorageS3.h 2022-09-13 16:30:28 +02:00
vdimir
f2acb53887
Better log message for replicas number in StorageReplicatedMerge 2022-09-13 13:49:51 +00:00
kssenii
420ac4eb43 s3 header auth in ast 2022-09-13 15:13:28 +02:00
alesapin
7a1ae1f316 Fix for stateless test 2022-09-13 15:10:49 +02:00
Antonio Andelic
baf7255cff
Merge pull request #39976 from ClickHouse/keeper-storage
KeeperMap storage engine
2022-09-13 14:15:09 +02:00
Igor Nikonov
d8acb0e7ad Tiny improvements along the code
- less allocations (potentially)
2022-09-13 12:06:56 +00:00
zhongyuankai
f36d70e9dd
Merge branch 'master' into compress_marks_and_primary_key 2022-09-13 20:05:39 +08:00
Alexander Tokmakov
4d146b05a9
Merge pull request #38262 from PolyProgrammist/fix-ordinary-system-unfreeze
Fix SYSTEM UNFREEZE for ordinary database
2022-09-13 14:55:11 +03:00
Mikhail Filimonov
d2d8c179b6
Add unreserved_space column to system.disks 2022-09-13 13:16:18 +02:00
Vladimir C
cc7292df74
Merge pull request #41105 from ClickHouse/vdimir/upd_storage_rdb_sample_block 2022-09-13 12:37:12 +02:00
alesapin
cc9f6d47be Merge branch 'master' into enable_projections_and_zero_copy 2022-09-13 12:34:22 +02:00
Kseniia Sumarokova
b2c9c04c7b
Merge pull request #40821 from kssenii/improve-marks-cache-loading
Allow to load marks in threadpool in advance
2022-09-13 12:31:58 +02:00
Kseniia Sumarokova
651d850652
Merge pull request #41230 from kssenii/minor-change
minor change in MergeTreeDataPartCompact
2022-09-13 12:23:18 +02:00
zhongyuankai
75c0854a78 fix test 2022-09-13 11:18:25 +08:00
zhongyuankai
1477bb132f
Merge branch 'master' into compress_marks_and_primary_key 2022-09-13 11:05:57 +08:00
Robert Schulze
fac1be9700
chore: restore SYSTEM RELOAD MODEL(S) and moniting view SYSTEM.MODELS
- This commit restores statements "SYSTEM RELOAD MODEL(S)" which provide
  a mechanism to update a model explicitly. It also saves potentially
  unnecessary reloads of a model from disk after it's initial load.

  To keep the complexity low, the semantics of "SYSTEM RELOAD MODEL(S)
  was changed from eager to lazy. This means that both statements
  previously immedately reloaded the specified/all models, whereas now
  the statements only trigger an unload and the first call to
  catboostEvaluate() does the actual load.

- Monitoring view SYSTEM.MODELS is also restored but with some obsolete
  fields removed. The view was not documented in the past and for now it
  remains undocumented. The commit is thus not considered a breach of
  ClickHouse's public interface.
2022-09-12 19:33:02 +00:00
Sergei Trifonov
c31818260f renames and refactoring 2022-09-12 21:03:06 +02:00
kssenii
06f80d78f8 Fix 2022-09-12 18:16:53 +02:00
Alexander Tokmakov
da4fbb552d
Merge branch 'master' into fix_parts_removal 2022-09-12 17:49:29 +03:00
Antonio Andelic
deee0d639f Address PR comments 2022-09-12 14:43:52 +00:00
Sergei Trifonov
fe88a7991d
Merge branch 'master' into readonly-settings-allow 2022-09-12 16:20:40 +02:00
Antonio Andelic
1cd43d8e5c Merge branch 'master' into keeper-storage 2022-09-12 13:42:51 +00:00
alesapin
e3e2c76606 FIX STYLE KEK 2022-09-12 13:52:57 +02:00
Sergei Trifonov
4810a59866 fix uninitialized variables 2022-09-12 13:27:06 +02:00
Kseniia Sumarokova
df22e8d30c
Merge pull request #41190 from kssenii/fix-clean-up-thread
Fix cleaning up broken detached part after timeout
2022-09-12 13:21:45 +02:00
Alexander Tokmakov
7f462a8762
Update src/Storages/StorageReplicatedMergeTree.cpp 2022-09-12 13:22:08 +03:00
kssenii
02c3d8b0a0 Fix 2022-09-11 16:42:56 +02:00
alesapin
6eead4ea1e Fix fasttest build 2022-09-11 15:16:54 +02:00
alesapin
21ab379026 Fix comment 2022-09-11 13:47:04 +02:00
alesapin
ac53830000 Fix hung check 2022-09-11 13:37:39 +02:00
kssenii
b7d751b782 Merge remote-tracking branch 'upstream/master' into improve-marks-cache-loading 2022-09-11 13:23:30 +02:00
Alexey Milovidov
7f1e7b5967 Merge branch 'master' into fix-half-of-trash 2022-09-11 06:20:47 +02:00
Azat Khuzhin
4e3135383b Fix clang-tidy warnings (from clang-15)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-10 21:38:35 +02:00
Alexey Milovidov
fd235919aa Remove some methods 2022-09-10 05:04:40 +02:00
Alexey Milovidov
fa62c7e982 Fix half of trash 2022-09-10 04:08:16 +02:00
Anton Popov
d1fa2148de
Merge branch 'master' into dynamic-columns-14 2022-09-09 19:32:07 +02:00
Anton Popov
a1b5582a7c
Merge pull request #37152 from CurtizJ/fix-filling-of-missed-nested
Fix filling of missed Nested columns with multiple levels
2022-09-09 19:29:01 +02:00
alesapin
50121e42f3 Enable projections and zero copy replication 2022-09-09 18:38:02 +02:00
Nikolay Degterinsky
12e7cd6b19
Merge pull request #41068 from jthmath/bugfix
fix ignore projection logic error
2022-09-09 17:10:03 +02:00
alesapin
86a3719bef
Merge pull request #41128 from ClickHouse/less_errors
Fix bad warnings in part fetches
2022-09-09 16:58:09 +02:00
Alexander Tokmakov
98509e62e8
Update src/Storages/Freeze.cpp 2022-09-09 16:20:24 +03:00
Antonio Andelic
32483aeec8 Merge branch 'master' into keeper-storage 2022-09-09 12:24:01 +00:00
alesapin
01e745bbbf Fix parts removal 2022-09-09 13:26:13 +02:00
Alexander Tokmakov
48927ba0ac
Merge branch 'master' into no-hardlinks-while-making-backup-of-mergetree-in-atomic-db 2022-09-09 14:24:44 +03:00
alesapin
23d95e6723 Fix parts removal in case of failures 2022-09-09 13:24:22 +02:00
alesapin
e3fc78aa5f Fix bad warnings in part fetches 2022-09-09 12:14:42 +02:00
Vitaly Baranov
9acc73d811
Update src/Storages/StorageReplicatedMergeTree.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@gmail.com>
2022-09-08 17:51:29 +02:00
Sergei Trifonov
f92b6a6176
Merge branch 'master' into readonly-settings-allow 2022-09-08 17:44:32 +02:00
Anton Popov
ba41239ecd Merge remote-tracking branch 'upstream/master' into HEAD 2022-09-08 15:20:29 +00:00
Anton Popov
86b29b7f1a fix serilization of Object inside other types 2022-09-08 15:16:39 +00:00
alesapin
62c911924b
Merge pull request #41108 from ClickHouse/more_logging
More logging for S3
2022-09-08 17:10:55 +02:00
alesapin
5e00124f8a More logging for S3 2022-09-08 16:18:21 +02:00
Antonio Andelic
b6f8e06708
Typo fix 2022-09-08 14:57:34 +02:00
Alexander Tokmakov
507ad0c4d9
Merge pull request #40691 from azat/mergetree/transaction-wal-fix
Move committing InMemory parts to WAL out of NOEXCEPT_SCOPE()
2022-09-08 15:55:30 +03:00
Antonio Andelic
b99996961d Address PR comments 2022-09-08 12:45:36 +00:00
vdimir
8121904dc4
Minor update StorageEmbeddedRocksDB::getSampleBlock 2022-09-08 12:43:38 +00:00
Vitaly Baranov
122009a2bd Use table lock if database is ordinary and zero-copy-replication is enabled. 2022-09-08 13:54:59 +02:00
alesapin
6da37b92e1 Improve logging one time 2022-09-08 13:11:53 +02:00
Vladimir C
90647cb0c5
Merge pull request #39970 from SachinSetiya/majority_quorum
Add majority_insert_quorum setting
2022-09-08 11:31:33 +02:00
Frank Chen
a986380522
Update src/Storages/Distributed/DirectoryMonitor.cpp
Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
2022-09-08 17:25:29 +08:00
Robert Schulze
c16707ff00
chore: delete obsolete modelEvaluate() function + SYSTEM.MODELS view
- The deleted function modelEvaluate() was superseded by
  catboostEvaluate().

- Also delete the external model repository, as modelEvaluate() was it's
  last user. Additionally remove the system view SYSTEM.MODELS for
  inspecting the repository.

- SYSTEM RELOAD MODELS is also obsolete. HOWEVER, it was retained and
  made a no-op instead of deleted.

  Why?
  The reason is that RBAC in distributed setups works by storing
  privileges (granted and revoked) as plain SQL statements in Keeper.
  Nodes read these statements at startup and parse them. If a privilege
  for SYSTEM RELOAD MODELS exists but parser doesn't recognize it
  nodes would fail to come up.

  Considered but rejected alternatives:
  - Ignore SYSTEM RELOAD MODELS during parsing RBAC privileges and
    return an error for regular SYSTEM RELOAD MODELS SQL. Special-case
    of no-op behavior, too brittle.
  - Remove SYSTEM RELOAD MODELS manually from Keeper via command-line
    manipulation of Keeper nodes or via SQL by dropping the privileges.
    Needs user intervention during upgrade.
2022-09-08 09:10:11 +00:00
Frank Chen
329f31e7ab Address review comments
Signed-off-by: Frank Chen <frank.chen021@outlook.com>
2022-09-08 11:38:10 +08:00
Anton Popov
7c12b448b8 Merge remote-tracking branch 'upstream/master' into HEAD 2022-09-08 01:52:52 +00:00
Anton Popov
5a790b15b4 try to fix filling of missed Nested columns with multiple levels 2022-09-08 00:20:11 +00:00
Kseniia Sumarokova
a270eeef91
Merge pull request #41008 from kssenii/refactor-merge-tree-read
Small refactoring around merge tree readers (get rid of data part ptr)
2022-09-07 18:27:33 +02:00
kssenii
e51313b6b3 Get rid of static threadpools 2022-09-07 17:48:11 +02:00
alesapin
365438d617
Merge pull request #41016 from ClickHouse/one_more_logging
Slightly improve diagnostics and remove assertions
2022-09-07 15:23:17 +02:00
vdimir
6234d564d1
Fix ReplicatedMergeTreeSink, add more info to logs 2022-09-07 11:19:28 +00:00
vdimir
000ba8a60d
Use insert_qurum = auto instead of majority_insert_quorum 2022-09-07 11:19:27 +00:00
Sachin
ade4337978
Add majority_insert_quorum setting
majority_insert_quorum is defined as (number_of_replicas/2)+1. Insert
will be successful only if majority of quorum have applied it. If
insert_quorum and majority_insert_quorum both are specified, max of
both will be used.
2022-09-07 11:19:24 +00:00
Kruglov Pavel
8513af5c1b
Merge pull request #40638 from azat/mergetree/insert-perf
Do not obtain storage snapshot for each INSERT block (slightly improves performance)
2022-09-07 12:53:09 +02:00
Daniil Rubin
3f9022bc7f Fix createClientConfiguration arguments 2022-09-07 10:48:11 +00:00
Vitaly Baranov
9c847ceec9 No hardlinks while making backup of MergeTree in atomic database. 2022-09-07 11:44:50 +02:00
Antonio Andelic
d15fdae8dc
Merge pull request #40853 from ClickHouse/embeddedrocksdb-delete-update-support
Support for `UPDATE` and `DELETE` in `EmbeddedRocksDB`
2022-09-07 11:03:49 +02:00
alesapin
81c98dadd2 Remove redundant change 2022-09-07 11:01:06 +02:00
Daniil Rubin
152da1a034 Fix build 2022-09-07 08:14:44 +00:00
Daniil Rubin
ba08366af1 Fix fasttest build 2022-09-07 11:05:40 +03:00
Daniil Rubin
07d12338ca Fix ErrorCodes style 2022-09-07 11:05:40 +03:00
Daniil Rubin
a77aa6b2b0 Remove unneeded comments, format 2022-09-07 11:05:40 +03:00
Daniil Rubin
616b72d665 Fix bug 2022-09-07 11:05:40 +03:00
Daniil Rubin
c68257d711 Implement StorageDelta 2022-09-07 11:05:40 +03:00
Daniil Rubin
fc2c8f37b1 Add DeltaLake storage template, file downlad from s3 2022-09-07 11:05:40 +03:00
Daniil Rubin
2abe284859 Fix engine bug 2022-09-07 11:05:40 +03:00
Daniil Rubin
e82c4800f2 Better 2022-09-07 11:05:40 +03:00
Daniil Rubin
66c9305668 Add Hudi engine 2022-09-07 11:05:40 +03:00
Daniil Rubin
842c636354 Undone hudi 2022-09-07 11:05:40 +03:00
Daniil Rubin
c5ae712651 Add list files on s3 2022-09-07 11:05:40 +03:00
Daniil Rubin
7f46b6a48b Add Hudi engine template 2022-09-07 11:05:40 +03:00
jthmath
478d2ad06a fix ignore projection 2022-09-07 10:23:52 +08:00
alesapin
6ded03c000 Disable fetch shortcut for zero copy replication 2022-09-07 00:00:10 +02:00
Sergei Trifonov
77ee4c04aa fix stateless tests 2022-09-06 20:28:50 +02:00
alesapin
43493389b9 Merge branch 'master' into one_more_logging 2022-09-06 19:40:24 +02:00
Anton Popov
9def867795 fix reading of subcolumns from in-memory parts 2022-09-06 17:38:51 +00:00
alesapin
b778b9f37f Improve logging better 2022-09-06 19:25:58 +02:00
zhongyuankai
d286214c4a fix typos 2022-09-07 00:24:06 +08:00
Anton Popov
f0a404e2c8 Merge remote-tracking branch 'upstream/master' into HEAD 2022-09-06 15:51:16 +00:00
zhongyuankai
e83b0788af Merge branch 'master' into compress_marks_and_primary_key 2022-09-06 23:45:19 +08:00
zhongyuankai
c7b2f719c6 batter 2022-09-06 23:41:39 +08:00
Anton Popov
ce9b76f416 fix Nested in in-memory parts 2022-09-06 15:01:47 +00:00
Sergei Trifonov
6217559175
Merge branch 'master' into readonly-settings-allow 2022-09-06 16:10:48 +02:00
Kseniia Sumarokova
3558361a05
Merge branch 'master' into refactor-merge-tree-read 2022-09-06 16:00:43 +02:00
Anton Popov
f76c1482bd try to fix filling of missed Nested columns with multiple levels 2022-09-06 13:56:32 +00:00
alesapin
6ea7f1e011 Better exception handling for ReadBufferFromS3 2022-09-06 13:59:55 +02:00
Sergei Trifonov
f77809ddbc
Merge pull request #40900 from ClickHouse/s3-detailed-metrics
S3 detailed metrics
2022-09-06 13:20:57 +02:00
Filatenkov Artur
7949b3fb74
Merge branch 'master' into annoy 2022-09-06 11:23:15 +03:00
Frank Chen
2067096035 Optimize span log for SYNC insert 2022-09-06 16:06:30 +08:00
Frank Chen
8365e7bfac Remove extra attribute 2022-09-06 15:41:21 +08:00
zhongyuankai
0bf76fe642 Merge branch 'compress-marks' into compress_marks_and_primary_key 2022-09-06 08:01:43 +08:00
zhongyuankai
d232d7e904 Merge branch 'master' into compress_marks_and_primary_key 2022-09-06 07:59:59 +08:00
Alexey Milovidov
940a53e519
Merge pull request #40984 from Lucky-Chang/typo_fix
Fix some typos and clang-tidy warnings
2022-09-06 02:37:50 +03:00
Kseniia Sumarokova
33f541042a
Fix clang tidy 2022-09-06 00:04:50 +02:00
alesapin
8977af5150 Remove some outdated assertions 2022-09-05 22:59:25 +02:00
Kruglov Pavel
cadae5a2f6
Merge pull request #40896 from kssenii/fix-memory-usage-for-remote
Fix extra memory allocation for remote read buffers
2022-09-05 20:38:57 +02:00
kssenii
4c8aa04b73 Revert "Fix"
This reverts commit ec55c90f36.
2022-09-05 20:12:40 +02:00
kssenii
83514fa2ef Refactor 2022-09-05 20:08:22 +02:00
ianton-ru
39e1fc7a0f
Merge branch 'master' into fix-ordinary-system-unfreeze 2022-09-05 17:10:59 +03:00
Anton Ivashkin
15b0b8ff06 Fix FreezeMetaData::load 2022-09-05 17:01:19 +03:00
Sergei Trifonov
1c247308f1
Merge branch 'master' into s3-detailed-metrics 2022-09-05 15:55:41 +02:00
Kseniia Sumarokova
e12858dca5
Merge pull request #36837 from ClickHouse/stress_s3
Trying stress on top of S3
2022-09-05 15:12:55 +02:00
Anton Popov
f11b7499d1
Merge pull request #40592 from azat/inmemory-WAL-cleanup
Remove completely processed WAL files
2022-09-05 14:15:19 +02:00
Antonio Andelic
e07539d1b9 Merge branch 'master' into keeper-storage 2022-09-05 09:54:13 +00:00
Frank Chen
6ab1549d6c Update writeToLocal to record related info 2022-09-05 16:40:48 +08:00
Frank Chen
a17bc51d5b Save cluster/distributed/table to log 2022-09-05 16:39:47 +08:00
Frank Chen
3d65e3f2ee Add cluster/distributed/remote to file 2022-09-05 16:37:55 +08:00
Antonio Andelic
3a0581e990
Merge pull request #40543 from Lloyd-Pottiger/feat/support-read-only-for-embeddedrocksdb
Add read-only support for EmbeddedRocksDB
2022-09-05 09:31:07 +02:00
Antonio Andelic
569f0abfb7 Change error code 2022-09-05 07:03:23 +00:00
Alexey Milovidov
ad9ae84e76 Fix error 2022-09-05 07:34:44 +02:00
Alexey Milovidov
fd2be1f041 Fix error 2022-09-05 07:31:29 +02:00
Alexey Milovidov
d7127e4b2d Make it slightly more sane 2022-09-05 07:26:58 +02:00
Alexey Milovidov
b4eec0e6f4 Fix strange code 2022-09-05 06:31:19 +02:00
Alexey Milovidov
6bc814a860 Renaming 2022-09-05 04:47:32 +02:00
Alexey Milovidov
b6ab997ca0 Merge branch 'compress_marks_and_primary_key' of github.com:zhongyuankai/ClickHouse into compress-marks 2022-09-05 04:30:08 +02:00
Alexey Milovidov
79f0d12f39 Merge branch 'master' into compress-marks 2022-09-05 04:29:46 +02:00
Luck-Chang
1ac8e739c9 fix some typos and clang-tidy warnings 2022-09-05 09:50:24 +08:00
Alexey Milovidov
d20d49f39f
Merge pull request #40958 from arenadata/ADQM-566
stylecheck renewed and version in docker set explicitely
2022-09-05 03:23:38 +03:00
kssenii
48dc32faf8 Better test 2022-09-04 19:54:34 +02:00
Azat Khuzhin
2e85f9f0ad Remove completely processed WAL files
Previously all WAL files had been stored, though with the time of use
this can take too much space on disk, and also the startup time will be
increased.

But it is pretty easy to prune old WAL files (the one parts from which
had been completely written to disk already).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-04 14:18:14 +02:00
alesapin
a67703b76b
Merge branch 'master' into stress_s3 2022-09-04 13:00:28 +02:00
Alexey Milovidov
193cd1b3b2
Merge pull request #39138 from nickitat/control_block_size_in_aggregator
Control block size in aggregator
2022-09-04 04:51:00 +03:00
Alexey Milovidov
097221a3af
Merge pull request #40726 from amosbird/projection-fix-1
Disable projection when grouping set is used.
2022-09-04 04:23:30 +03:00
Yakov Olkhovskiy
fdcced8962
Merge pull request #40850 from canhld94/ch_canh_fix_set
Fix tryGetPreparedSet crash when same set expression built from different column(s)
2022-09-02 14:40:35 -04:00
Anton Popov
464818c142 try to fix filling of missed Nested columns with multiple levels 2022-09-02 15:05:58 +00:00
Sergei Trifonov
067e712fdf
Merge branch 'master' into s3-detailed-metrics 2022-09-02 16:59:52 +02:00
Ilya Golshtein
74561b40ae stylecheck renewed 2022-09-02 17:42:18 +03:00
Lloyd-Pottiger
5db220c7fb Merge branch 'master' of github.com:ClickHouse/ClickHouse into feat/support-read-only-for-embeddedrocksdb 2022-09-02 22:40:28 +08:00
Sergei Trifonov
005b2588d8
Merge branch 'master' into readonly-settings-allow 2022-09-02 16:37:43 +02:00
Sergei Trifonov
014d109175 fix build, fix docs, fix comments, logical fixes, test are still to be fixed and new test are to be added 2022-09-02 16:20:09 +02:00
Anton Popov
9dda9658a8 Merge remote-tracking branch 'upstream/master' into HEAD 2022-09-02 12:48:27 +00:00
alesapin
3f02995161 Better exceptions handling 2022-09-02 13:54:41 +02:00
Antonio Andelic
9ca20b97c2
Merge branch 'master' into keeper-storage 2022-09-02 12:13:07 +02:00
Lloyd-Pottiger
5a6b2106b5 Merge branch 'master' of github.com:ClickHouse/ClickHouse into feat/support-read-only-for-embeddedrocksdb 2022-09-02 18:10:00 +08:00
Antonio Andelic
e64436fef3 Fix typos with new codespell 2022-09-02 08:54:48 +00:00
Antonio Andelic
f5fc3db0dd Small fix 2022-09-02 07:42:22 +00:00
Antonio Andelic
1a48beec30 Use server UUID 2022-09-02 07:40:39 +00:00
Antonio Andelic
dbf67f26d8 Add prefix path 2022-09-02 07:24:26 +00:00
Duc Canh Le
65b64010a0 move out-of-bound check into set::areTypesEqual 2022-09-02 11:56:13 +08:00
Duc Canh Le
763328ef53 Merge branch 'master' into ch_canh_fix_set 2022-09-02 11:45:13 +08:00
Lloyd-Pottiger
59dccd6e49 fix test
Signed-off-by: Lloyd-Pottiger <yan1579196623@gamil.com>
2022-09-02 11:14:49 +08:00
Sergei Trifonov
7fec55eea4 work in progress 2022-09-02 04:12:05 +02:00
Sergei Trifonov
ac9dc53c73 Merge branch 'master' into s3-detailed-metrics 2022-09-01 18:31:02 +02:00
Sergei Trifonov
bcb6475c4a add separate s3 profile events for disk s3 2022-09-01 18:30:55 +02:00
Frank Chen
9d63cbe811 Merge 'origin/master' into tracing_context_propagation to resolve conflicts 2022-09-01 23:18:59 +08:00
kssenii
ec55c90f36 Fix 2022-09-01 17:04:34 +02:00
kssenii
4fa291cf59 Fix hdfs read buffer too 2022-09-01 16:46:46 +02:00
Antonio Andelic
a0c1ce5eb7 Merge branch 'master' into embeddedrocksdb-delete-update-support 2022-09-01 14:40:24 +00:00
Vladimir C
f2cf7d7762
Merge pull request #40334 from ClickHouse/vdimir/analyze-stuck-limit
Limit number of analyze for one query, att. 2
2022-09-01 14:40:20 +02:00
Antonio Andelic
62ff61404f Improve remove recursive 2022-09-01 12:16:13 +00:00
alesapin
f2bcd63618
Merge pull request #40844 from ClickHouse/fix_incorrect_remove_in_zero_copy
Fix incorrect directory remove in zero copy replication
2022-09-01 13:21:58 +02:00
Vitaly Baranov
6dcca686cb
Merge pull request #40827 from vitlibar/fix-incremental-backups-for-log-family
Fix incremental backups for Log family.
2022-09-01 13:13:32 +02:00
kssenii
82879543d3 Merge remote-tracking branch 'upstream/master' into improve-marks-cache-loading 2022-09-01 13:13:01 +02:00
Anton Popov
f7bdf07adc
Merge pull request #38715 from CurtizJ/fix-read-in-order-fixed-prefix
Better support of `optimize_read_in_order` in case of fixed prefix of sorting key
2022-09-01 12:59:18 +02:00
Antonio Andelic
6442824da8 Fix KeeperMap with Replicated database 2022-09-01 10:47:05 +00:00
Kseniia Sumarokova
849262bd99
Merge pull request #40858 from kssenii/move-cache-files
Move cache files from Common
2022-09-01 12:28:00 +02:00
Duc Canh Le
018f4118bb
Fix view with merge table function (#40734) 2022-09-01 12:20:00 +02:00
Antonio Andelic
c7d1dd942c Address PR comments 2022-09-01 07:56:06 +00:00
zhongyuankai
228e984856
Merge branch 'master' into compress_marks_and_primary_key 2022-09-01 11:07:21 +08:00
Robert Schulze
912663b719
Revert "Move CatBoost evaluation into clickhouse-library-bridge" 2022-08-31 20:54:43 +02:00
alesapin
251bdab9a0 Better grep 2022-08-31 20:08:47 +02:00
Kruglov Pavel
86516d3bb4
Merge pull request #40740 from amosbird/row-policy-index-fix-1
Use index when row_policy_filter is always false
2022-08-31 18:46:14 +02:00
kssenii
0f747e7987 Move cache files 2022-08-31 17:50:55 +02:00
Antonio Andelic
f043790e6d Add support for update 2022-08-31 14:33:53 +00:00
Robert Schulze
ca01286028
Merge pull request #39629 from ClickHouse/catboost-bridge
Move CatBoost evaluation into clickhouse-library-bridge
2022-08-31 16:16:11 +02:00
Duc Canh Le
55c20ce45b fix tryGetPreparedSet crash when same set expression built from different columns 2022-08-31 21:43:08 +08:00
kssenii
3a183236a2 Fix 2022-08-31 15:39:53 +02:00
Filatenkov Artur
9a231cf49a
fix out-of-bounds
Co-authored-by: Alexander Tokmakov <tavplubix@gmail.com>
2022-08-31 16:28:10 +03:00
Antonio Andelic
0e6b3b870a Add support for delete in RocksDB 2022-08-31 13:08:27 +00:00
alesapin
c427491bcb Better 2022-08-31 15:05:45 +02:00
alesapin
a4f71ba6b8 Fix one more bug 2022-08-31 14:53:33 +02:00
alesapin
2d976753e1 Fix incorrect directory remove in zero copy replication 2022-08-31 13:50:59 +02:00
Vitaly Baranov
007ae0e6cc Fix incremental backups for Log family. 2022-08-31 12:57:28 +02:00
Antonio Andelic
7d5e13c6ba Use async exist for write 2022-08-31 10:40:32 +00:00
Antonio Andelic
9dd1a9859d Merge branch 'master' into keeper-storage 2022-08-31 10:12:11 +00:00
vdimir
473c9106a5 Revert "Create new query context in StorageRabbitMQ/Nat"
This reverts commit 2d6ac7344a25134a625e879da63b9a4aa20d9a69.
2022-08-31 11:57:41 +02:00
vdimir
63f7301ee0 Create new query context in StorageRabbitMQ/Nat 2022-08-31 11:57:41 +02:00
vdimir
c829a1914d Disable max_analyze_depth for StorageRabbitMQ/NATS 2022-08-31 11:57:41 +02:00
Antonio Andelic
1af9a81297 Sync after reconnect 2022-08-31 08:29:40 +00:00
Antonio Andelic
1ff14aed02 Fix dropping table 2022-08-31 08:23:44 +00:00
Antonio Andelic
5ef4c52290 Add support for keys limit 2022-08-31 08:14:28 +00:00
FArthur-cmd
941cceda7f fix build 2022-08-30 23:09:22 +00:00
Anton Popov
3504781529
Merge branch 'master' into fix-read-in-order-fixed-prefix 2022-08-30 23:32:43 +02:00
kssenii
a5f69517ae Allow to load marks in threadpool 2022-08-30 20:20:05 +02:00
FArthur-cmd
dadc29fb73 add checks for sizes 2022-08-30 15:46:55 +00:00
FArthur-cmd
c7d31c3a90 fix indexes for ColumnArray 2022-08-30 15:32:05 +00:00
FArthur-cmd
e7abc06c89 Revert "Revert "Add Annoy index""
This reverts commit 6fdfb964d0.
2022-08-30 15:26:56 +00:00
zhongyuankai
0fe79942be
Merge branch 'master' into compress_marks_and_primary_key 2022-08-30 22:10:19 +08:00
zhongyuankai
7cd8079c75 fix test 2022-08-30 22:08:27 +08:00
Antonio Andelic
d498213973 Style fixes 2022-08-30 13:50:02 +00:00
Antonio Andelic
bf03dfc661 Fix create 2022-08-30 13:41:13 +00:00
Alexander Tokmakov
6fdfb964d0
Revert "Add Annoy index" 2022-08-30 15:10:10 +03:00
Anton Popov
ee691961d9 fix build 2022-08-30 11:43:27 +00:00
Kruglov Pavel
624af5bffd
Update src/Storages/MergeTree/KeyCondition.cpp 2022-08-30 13:18:05 +02:00
Antonio Andelic
53da469147 Merge branch 'master' into keeper-storage 2022-08-30 10:22:04 +00:00
Kseniia Sumarokova
c88db2ef97
Merge pull request #40751 from kssenii/fix-mysql-timeouts
Fix issue with mysql db / table function timeouts
2022-08-30 11:59:01 +02:00
Antonio Andelic
80365e0448 Simplify drop and create 2022-08-30 09:19:59 +00:00
Frank Chen
f17d56b528 Merge branch 'master' into tracing_context_propagation 2022-08-30 14:24:36 +08:00
zhongyuankai
5992cbeaa1 Merge branch 'master' into compress_marks_and_primary_key 2022-08-30 08:51:21 +08:00
zhongyuankai
c1d7f60064 fix test 2022-08-30 08:50:27 +08:00
Robert Schulze
4d511332c4
chore: delete obsolete modelEvaluate() function
- superseded by catboostEvaluate() which no longer uses the internal
  repository for external models

- also removed was statement SYSTEM RELOAD MODELS and the monitoring view
  SYSTEM.SYSTEMMODELS
2022-08-29 20:27:06 +00:00
Kseniia Sumarokova
c5c48e44ea
Merge branch 'master' into fix-mysql-timeouts 2022-08-29 19:33:29 +02:00
FArthur-cmd
862b53b06f Merge branch 'annoy-2' of https://github.com/Vector-Similarity-Search-for-ClickHouse/ClickHouse into annoy-2 2022-08-29 16:43:39 +00:00
FArthur-cmd
3305af8db2 fix case when query is already matched 2022-08-29 16:43:24 +00:00
Filatenkov Artur
d73f661732
Merge branch 'master' into annoy-2 2022-08-29 17:33:13 +03:00
kssenii
0a6c4b9265 Fix 2022-08-29 16:20:53 +02:00
Sergei Trifonov
899bf99d44
Merge branch 'master' into readonly-settings-allow 2022-08-29 14:35:05 +02:00
Alexander Tokmakov
8d90d30d37
Merge pull request #40589 from ClickHouse/remove_wrong_code_from_mutations
Remove wrong code for skipping mutations in MergeTree
2022-08-29 14:18:59 +03:00
Anton Popov
2a3e012931
Merge branch 'master' into fix-read-in-order-fixed-prefix 2022-08-29 13:17:26 +02:00
Alexander Tokmakov
eda0582ec0
Merge pull request #40641 from ClickHouse/fix_startup_of_dropped_replica
Do not try to strartup dropped replica
2022-08-29 14:15:15 +03:00
alesapin
7ce0afc0df
Merge pull request #40670 from Avogar/kafka
Add setting to disable limit on kafka_num_consumers
2022-08-29 10:53:35 +02:00
Amos Bird
15a69bce84
Use index when row_policy_filter is always false 2022-08-29 16:44:32 +08:00
Amos Bird
abf51bccfd
Disable projection when grouping set is used. 2022-08-29 14:35:48 +08:00
Alexey Milovidov
5ab2413601
Merge branch 'master' into compress-marks 2022-08-29 04:50:35 +03:00
Alexey Milovidov
27782ceef8 Remove useless method 2022-08-28 22:33:42 +02:00
Alexey Milovidov
dd412f6145 Fix error 2022-08-28 20:42:11 +02:00
Alexey Milovidov
d648d62809 Merge remote-tracking branch 'origin/master' into compress-marks 2022-08-28 20:23:36 +02:00
Alexey Milovidov
5ee81598b5 Merge branch 'compress_marks_and_primary_key' of github.com:zhongyuankai/ClickHouse into compress-marks 2022-08-28 04:19:14 +02:00
Alexey Milovidov
6139cc8f7a Add Documentation to FunctionFactory 2022-08-27 22:06:57 +02:00
Alexey Milovidov
e7054debc1
Merge pull request #40649 from ClickHouse/embedded-documentation
A prototype for embedded documentation
2022-08-27 21:28:11 +03:00
Alexey Milovidov
6e564b18bf
Merge pull request #40600 from FrankChen021/check_url_arg
Validate the CompressionMethod parameter of URL table engine
2022-08-27 19:29:55 +03:00
Azat Khuzhin
3c478da003 Move committing InMemory parts to WAL out of NOEXCEPT_SCOPE()
Since this commit can definitelly throw (i.e. due to ENOSPC).

Note, that it should be safe, since rollback() will call dropPart() for
those parts.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-08-26 23:37:59 +02:00
Sergei Trifonov
c5d1bbf680 reimplement with <allow> tag 2022-08-26 21:20:00 +02:00
Alexey Milovidov
6940bdab3b
Merge branch 'master' into fix-recursive-buffer 2022-08-26 21:25:11 +03:00
FArthur-cmd
f3d0083e57 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into annoy-2 2022-08-26 13:53:53 +00:00
avogar
b8061532ac Add setting to disable limit on kafka_num_consumers 2022-08-26 12:49:39 +00:00
Kruglov Pavel
58538d3f90
Merge pull request #40636 from Avogar/fix-url-format-detection
Better format detection for url table function/engine
2022-08-26 12:25:55 +02:00
Vladimir C
e067629e0d
Merge pull request #40239 from vdimir/vdimir/tmp-file-metrics
More metrics for on-disk temporary data
2022-08-26 11:28:01 +02:00
Lloyd-Pottiger
0d33327eda
Merge branch 'master' into feat/support-read-only-for-embeddedrocksdb 2022-08-26 15:36:21 +08:00
Frank Chen
2e874b384d
Update src/Storages/StorageURL.cpp
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2022-08-26 10:34:46 +08:00
Alexey Milovidov
8afbfebd25 A prototype for embedded documentation 2022-08-26 03:41:52 +02:00
Alexey Milovidov
5b5a16320b Suggestions from @azat 2022-08-26 03:00:56 +02:00
Alexander Tokmakov
b8e3a582f7 do not try to strartup dropped replica 2022-08-25 22:14:39 +02:00
Alexey Milovidov
ebe7d2d25e Fix stack overflow on recursive Buffer tables and system.tables 2022-08-25 21:26:32 +02:00
Azat Khuzhin
09aaa2b5dd Do not obtain storage snapshot for each INSERT block (improves performance)
It depends on how much parts do you have, but for some workload with
InMemory only parts w/o merges, I got 5% increase.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-08-25 21:02:27 +02:00
Alexander Gololobov
6a69e08799
Merge pull request #40559 from ClickHouse/lwd_vertical_merge_fix
Fix vertical merge of parts with lightweight deleted rows
2022-08-25 20:47:44 +02:00
avogar
cef2972af4 Better format detection for url table function/engine 2022-08-25 18:31:06 +00:00
Alexander Tokmakov
eae2667a1c
Merge pull request #40148 from ClickHouse/replicate-tables-readonly
`ReplicatedMergeTree` tables as readonly until attach is finished
2022-08-25 19:39:19 +03:00
Sergei Trifonov
6af43e7676
Merge branch 'master' into readonly-settings-allow 2022-08-25 17:27:03 +02:00
Sergei Trifonov
856a2f5956 Allow to modify constrained settings in readonly mode 2022-08-25 17:24:24 +02:00
Alexander Tokmakov
a6f55b1430 fix 2022-08-25 16:27:12 +02:00
Antonio Andelic
7c668be23a Fix drop 2022-08-25 14:10:43 +00:00
Vladimir C
ddde5096ef
Merge branch 'master' into vdimir/tmp-file-metrics 2022-08-25 15:23:35 +02:00
Antonio Andelic
9964513155 Merge branch 'master' into keeper-storage 2022-08-25 12:57:03 +00:00
Frank Chen
92f7ca3616 Move TracingContextOnThread::current() out of class for simplicity
Signed-off-by: Frank Chen <frank.chen021@outlook.com>
2022-08-25 20:23:56 +08:00
Alexander Tokmakov
0aea4c7184 fix 2022-08-25 14:22:27 +02:00
Frank Chen
bb00dcc19b Remove using namespace from header
Signed-off-by: Frank Chen <frank.chen021@outlook.com>
2022-08-25 20:20:13 +08:00
Frank Chen
c9ea4f9f77 Change compression_method from String to CompressionMethod 2022-08-25 19:18:04 +08:00
alesapin
c4f8811701
Merge pull request #40395 from ClickHouse/data_source_description
Add copy shortcut for backups if dest and source support it
2022-08-25 12:36:30 +02:00
Kseniia Sumarokova
4b62d0f75f
Merge pull request #40511 from maks-buren630501/master
Fix bug (issues 40262)
2022-08-25 12:18:23 +02:00
Antonio Andelic
f90612f577 Remove shutdown assert 2022-08-25 07:07:54 +00:00
Frank Chen
4c1fe0d623 validate parameter
Signed-off-by: Frank Chen <frank.chen021@outlook.com>
2022-08-25 14:49:17 +08:00
Frank Chen
99c37ce6c6
Merge branch 'master' into tracing_context_propagation 2022-08-25 10:07:16 +08:00
Kseniia Sumarokova
ba4dfe8308
Update MaterializedPostgreSQLConsumer.cpp 2022-08-25 00:23:59 +02:00
Alexander Tokmakov
3cd26aafe4 remove wrong code for skipping mutations in MergeTree 2022-08-24 20:58:59 +02:00
Antonio Andelic
797e21761a Address PR comments 2022-08-24 18:32:03 +00:00
Nikita Taranov
ac34a17551
Merge branch 'master' into control_block_size_in_aggregator 2022-08-24 20:25:28 +02:00
Antonio Andelic
da0d6056f4 Merge branch 'master' into replicate-tables-readonly 2022-08-24 17:29:33 +00:00
Antonio Andelic
41dd49356b Table create better 2022-08-24 17:27:07 +00:00
vdimir
7194df1184
Move back TemporaryFile -> TemporaryFileOnDisk 2022-08-24 16:14:11 +00:00
vdimir
1e24a731f7
Move Disks/TemporaryFileOnDisk -> Common/TemporaryFile 2022-08-24 16:14:10 +00:00
vdimir
cd4038d511
Use TemporaryFileOnDisk instead of Poco::TemporaryFile 2022-08-24 16:14:08 +00:00
Lloyd-Pottiger
9d7ace3286
Merge branch 'master' into feat/support-read-only-for-embeddedrocksdb 2022-08-24 23:52:34 +08:00
Lloyd-Pottiger
dc64341876 add tests
Signed-off-by: Lloyd-Pottiger <yan1579196623@gamil.com>
2022-08-24 23:42:13 +08:00
alesapin
eeb0a3584e Merge branch 'master' into data_source_description 2022-08-24 15:26:18 +02:00
Alexander Gololobov
1c2dd50ca5 Fix vertical merge of parts with lightweight deleted rows 2022-08-24 15:18:33 +02:00
alesapin
cac3005f4d Merge branch 'master' into paranoid_check_for_s3_uploads 2022-08-24 14:43:11 +02:00
Alexander Tokmakov
f9f85a0e8b Revert "Parallel distributed insert select from *Cluster table functions (#39107)"
This reverts commit d3cc234986.
2022-08-24 15:17:15 +03:00
Kseniia Sumarokova
38c4094f89
Update MaterializedPostgreSQLConsumer.h 2022-08-24 12:25:03 +02:00
Kseniia Sumarokova
de9d254290
Update MaterializedPostgreSQLConsumer.cpp 2022-08-24 12:24:44 +02:00
Kseniia Sumarokova
4486f26d51
Update MaterializedPostgreSQLConsumer.cpp 2022-08-24 12:23:08 +02:00
Frank Chen
cd19366b44 Move classes into DB::OpenTelemetry namespace 2022-08-24 16:41:40 +08:00
Frank Chen
efc6a60a60 Clean code 2022-08-24 15:59:44 +08:00
Kruglov Pavel
72f02bd6eb
Merge pull request #40414 from Avogar/improve-schema-inference-cache
Improve schema inference cache, respect format settings that can change the schema
2022-08-23 17:04:58 +02:00
Lloyd-Pottiger
52ec268d75 format check
Signed-off-by: Lloyd-Pottiger <yan1579196623@gamil.com>
2022-08-23 21:26:15 +08:00
Antonio Andelic
fc33941959 Add support for shared drop/create 2022-08-23 13:15:31 +00:00
alesapin
07286dd042 Add paranoid option to check blobs to S3 after upload 2022-08-23 15:12:09 +02:00
Lloyd-Pottiger
ac3cf0beb4 add read_only option
Signed-off-by: Lloyd-Pottiger <yan1579196623@gamil.com>
2022-08-23 20:58:57 +08:00
Vadim Volodin
c2ba9eacd4 fix style 2022-08-23 14:43:10 +03:00
Maksim Buren
0827e87d45
delete miss log 2022-08-23 14:20:32 +03:00
maks-buren630501
b2b97e53ea Fix bug whith wrong postgresql answer 2022-08-23 14:13:16 +03:00
Vadim Volodin
4d081543bb fix underscore 2022-08-23 13:59:02 +03:00
Vadim Volodin
9c371d518f fix enable_unfreeze handler and sanitizer hints 2022-08-23 13:53:06 +03:00
Kseniia Sumarokova
4711f57763
Update PostgreSQLReplicationHandler.cpp 2022-08-23 10:43:12 +02:00
Maksim Buren
9e54792359
Troubleshooting racing
consumer_task use replication_handler_initialized in thread start in method assertInitialized(), by this sometimes assertInitialized throw error because replication_handler_initialized was still "false".
2022-08-23 09:34:03 +03:00
Antonio Andelic
0765495be1
Merge pull request #39986 from Lloyd-Pottiger/feat/support-ttl-for-embeddedrocksdb
Support TTL for EmbeddedRocksDB
2022-08-23 08:27:47 +02:00
Alexey Milovidov
0252695c6e
Merge pull request #40224 from ClickHouse/alexey-milovidov-patch-4
Check what will be if I enable `concurrency-mt-unsafe` in `clang-tidy`
2022-08-22 23:12:01 +03:00
Lloyd-Pottiger
85a1a36167 remove read_only option
Signed-off-by: Lloyd-Pottiger <yan1579196623@gamil.com>
2022-08-22 23:31:55 +08:00
alesapin
b4d6afd5b3 Black 2022-08-22 13:51:48 +02:00
Alexey Milovidov
e9d0c50486 Add a test for #24093 2022-08-22 02:32:45 +02:00
Alexey Milovidov
7cd4619d9f
Merge pull request #34551 from ClickHouse/xdbc-constraints
Allow constraints for ODBC and JDBC tables
2022-08-21 21:35:06 +03:00
Robert Schulze
e8b3f56733
Limit suppression to a specific warning 2022-08-21 18:24:17 +00:00
Robert Schulze
3aa5acdb35
Merge pull request #40391 from ClickHouse/reduce-StringRef
Reduce some usage of StringRef
2022-08-21 20:04:57 +02:00
Antonio Andelic
f29ef68936 Merge branch 'master' into keeper-storage 2022-08-21 17:09:36 +00:00
Alexey Milovidov
d157c6a7a0
Update StorageXDBC.cpp 2022-08-21 16:53:48 +03:00
FArthur-cmd
f59735d4f9 fix style 2022-08-21 12:45:35 +00:00
FArthur-cmd
fb7785c740 add support queries with parameters, add setting to avoid memory overflow 2022-08-21 11:07:03 +00:00
alesapin
78ba732b31 Merge branch 'master' into data_source_description 2022-08-21 12:11:21 +02:00
Robert Schulze
bba04db0b4
Try to fix tests 2022-08-21 09:23:37 +00:00
FArthur-cmd
1e8910f048 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into annoy-2 2022-08-21 08:45:03 +00:00
Alexey Milovidov
ab91c99495
Merge branch 'master' into control_block_size_in_aggregator 2022-08-20 21:28:27 +03:00
Alexey Milovidov
01700078d9
Merge branch 'master' into xdbc-constraints 2022-08-20 21:26:07 +03:00
Alexey Milovidov
0db45afb08
Merge branch 'master' into alexey-milovidov-patch-4 2022-08-20 19:58:31 +03:00
alesapin
e4d486fbba
Merge pull request #40346 from ClickHouse/fix_ttl_vertical_merge_bug
Fix bug with multiple TTL merges on expired column
2022-08-20 17:09:32 +02:00
Alexey Milovidov
74e1f4dc61 Fix clang-tidy 2022-08-20 17:09:20 +02:00
Alexey Milovidov
6f39e3e039
Merge pull request #40419 from ClickHouse/fix-parallel-replicas
Fix obvious trash in Parallel replicas
2022-08-20 14:10:14 +03:00
Frank Chen
024fef1aec
Merge branch 'master' into tracing_context_propagation 2022-08-20 14:23:36 +08:00
Nikita Mikhaylov
4a453f0776 Fix obvious trash 2022-08-19 18:08:13 +00:00
avogar
5ab87f1da4 Small refactoring 2022-08-19 16:42:23 +00:00