Commit Graph

130824 Commits

Author SHA1 Message Date
Igor Nikonov
1370a8c6c4 Merge remote-tracking branch 'origin/master' into pr-custom-key-failover 2023-12-14 18:29:38 +00:00
Igor Nikonov
f8dc6e127e Update tests 2023-12-14 18:28:25 +00:00
robot-ch-test-poll4
3091c30692
Merge pull request #57868 from cwurm/patch-1
Update clickhouse-benchmark.md: Remove json output
2023-12-14 18:16:22 +01:00
Duc Canh Le
93dd6b83e7
Do not allow creating replicated table with inconsistent merge params (#56833)
* save all merge params to zookeeper

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>

* calculate hash for graphite merge params

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>

* add graphite params hash to zookeeper + fix tests

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>

* install new graphite for testing

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>

* fix backward incompatibility

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>

* minor fix test

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>

* Update src/Storages/MergeTree/ReplicatedMergeTreeTableMetadata.cpp

Co-authored-by: Alexander Tokmakov <tavplubix@gmail.com>

* remove peekString and add more comments

- peekString doesn't always work even for ReadBufferFromString
- more comment re. backward compatibility

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>

---------

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
Co-authored-by: Alexander Tokmakov <tavplubix@gmail.com>
2023-12-14 17:26:35 +01:00
Christoph Wurm
64a58ee445
Update clickhouse-benchmark.md: Remove json output
Suppport for `--json` was removed in https://github.com/ClickHouse/ClickHouse/pull/53293.
2023-12-14 14:15:41 +00:00
Nikita Mikhaylov
a0af0392cd
Random changes in random files (#57642) 2023-12-14 12:47:11 +01:00
János Benjamin Antal
fdfd1481df
Merge pull request #57610 from kitaisreal/jit-add-assembly-printer
CHJIT add assembly printer
2023-12-14 12:39:20 +01:00
Igor Nikonov
42d0afef1f
Merge pull request #57749 from ClickHouse/pr-perf-improve-hope
Parallel replicas: announcement response handling improvement
2023-12-14 11:48:51 +01:00
Konstantin Bogdanov
808b4a0213
Merge pull request #57628 from azat/config-nodes-override
Allow nodes in config with from_env/from_zk and non empty element with replace=1
2023-12-14 13:20:46 +03:00
Alexey Milovidov
e4901323fd
Merge pull request #57836 from ClickHouse/remove-array-fold
Remove `arrayFold`
2023-12-14 07:15:29 +01:00
robot-ch-test-poll2
b721f027ae
Merge pull request #57835 from andrewzolotukhin/patch-1
Fixed typo in string-functions.md
2023-12-14 05:55:29 +01:00
Nikolay Degterinsky
4c8cc4e0bd
Update string-functions.md 2023-12-14 05:32:12 +01:00
Alexey Milovidov
7a2edb4804
Merge pull request #57822 from azat/kafka-disable-stat
Disable system.kafka_consumers by default (due to possible live memory leak)
2023-12-14 04:37:50 +01:00
Alexey Milovidov
15dc0ed610 Remove arrayFold 2023-12-14 04:34:32 +01:00
andrewzolotukhin
c29007beeb
Fixed typo in string-functions.md 2023-12-14 04:54:52 +02:00
Alexey Milovidov
1c6eefd7db
Merge pull request #57831 from ClickHouse/clickbench-better
ClickBench: slightly better
2023-12-14 00:56:00 +01:00
Anton Popov
82ebb5e2d1
Merge pull request #57790 from CurtizJ/fix-external-aggregation-with-projections
Fix result of external aggregation in case of partially materialized projection
2023-12-13 22:56:02 +01:00
Alexey Milovidov
781ba52376 ClickBench: slightly better 2023-12-13 22:12:53 +01:00
Julia Kartseva
b8d274d070
Add malformed output generation to JSON fuzzer (#57646)
Randomly modify structural characters of a valid JSON ('{', '}', '[', ']',
':', '"', ',') to generate output that cannot be parsed as JSON.

Follow-up to https://github.com/ClickHouse/ClickHouse/pull/56490
2023-12-13 19:59:31 +01:00
Alexey Milovidov
e989eb7bd2
Merge pull request #57787 from kitaisreal/serialization-string-reduce-memory-usage
SerializationString reduce memory usage
2023-12-13 19:56:56 +01:00
Alexey Milovidov
0bb267cf0b
Merge pull request #57824 from ClickHouse/auto/v23.11.2.11-stable
Update version_date.tsv and changelogs after v23.11.2.11-stable
2023-12-13 19:54:45 +01:00
Alexey Milovidov
bf4964b177
Merge pull request #57712 from ClickHouse/clickbench-ci
Add ClickBench to CI
2023-12-13 19:52:44 +01:00
Nikita Taranov
560e66f3ca
More respect to min_number_of_marks in ParallelReplicasReadingCoordinator (#57763) 2023-12-13 19:51:49 +01:00
jsc0218
78773157b6
Merge pull request #57436 from ryanmjacobs/fix_issue_43186_pg_quote_array_ndims
Fix several issues regarding PostgreSQL `array_ndims` usage.
2023-12-13 13:41:43 -05:00
robot-clickhouse
30e6797c7e Update version_date.tsv and changelogs after v23.11.2.11-stable 2023-12-13 17:19:14 +00:00
Azat Khuzhin
055c231438 Disable system.kafka_consumers by default (due to possible live memory leak)
It is not safe to use statistics because of how KafkaEngine works - it
pre-creates consumers, and this leads to the situation when this
statistics entries generated (RD_KAFKA_OP_STATS), but never consumed.

Which creates a live memory leak for a server with Kafka tables, but
without materialized view attached to it (and no SELECT).

Another problem is that this makes shutdown very slow, because of how
pending queue entries are handled in librdkafka, it uses
TAILQ_INSERT_SORTED, which is sorted insert into linked list, which
works incredibly slow (likely you will never wait till it ends and kill
the server)

For instance in my production setup the server was running for ~67 days
with such table, and it got 1'942'233 `TAILQ_INSERT_SORTED` entries
(which perfectly matches by the way - `67*86400/3` = 1'929'600), and it
moved only 289'806 entries for a few hours, though I'm not sure how much
time the process was in the running state, since most of the time it was
with debugger attached.

So for now let's disable it, to make this patch easy for backporting,
and I will think about long term fix - do not pre-create consumers in
Kafka engine.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-13 18:13:13 +01:00
Alexey Milovidov
1d70c9464e Add it to master checks 2023-12-13 18:01:18 +01:00
Alexey Milovidov
fa7190805a A timeout 2023-12-13 17:59:55 +01:00
alesapin
230e1fe6c7
Merge pull request #57809 from ClickHouse/fix-flaky-test_parallel_replicas_over_distributed
Fix flaky test_parallel_replicas_over_distributed
2023-12-13 17:11:41 +01:00
Alexey Milovidov
54698cd2de
Merge pull request #55876 from ClickHouse/keeper-http-readiness-endpoint
Keeper HTTP readiness endpoint
2023-12-13 17:07:57 +01:00
Robert Schulze
bbd7d0c057
Merge pull request #57277 from slvrtrn/substr-with-enums
Add Enums support to `substring` function
2023-12-13 17:03:03 +01:00
Raúl Marín
d4522ee088
Merge pull request #57811 from Algunenano/revert_negative_positional_arguments
Revert #57741
2023-12-13 16:39:23 +01:00
Igor Nikonov
72f1c415f1 Merge remote-tracking branch 'origin/master' into pr-custom-key-failover 2023-12-13 15:03:05 +00:00
Nikolay Degterinsky
dd91ce2a14
Merge pull request #57788 from ClickHouse/docs/append-or-truncate-when-into-outfile
Mentions that `APPEND` or `TRUNCATE` should be used with `INTO-OUTFILE`.
2023-12-13 14:59:57 +01:00
Igor Nikonov
c165be76ab
Parallel replicas: friendly settings (#57542) 2023-12-13 14:42:06 +01:00
Johnny
54abbf146d
Update into-outfile.md 2023-12-13 09:04:07 -04:00
Igor Nikonov
2a0a5f755c Comment to about possible query results 2023-12-13 12:29:57 +00:00
robot-clickhouse-ci-2
de4afd3b54
Merge pull request #57804 from mkmkme/mkmkme/fix-test
fix clickhouse-client invocation in 02327_capnproto_protobuf_empty_messages
2023-12-13 13:26:11 +01:00
Raúl Marín
090d412d7c Add tests for 46628 2023-12-13 13:14:00 +01:00
Raúl Marín
8c2137e0c6 Revert "Merge pull request #57741 from ucasfl/negtive-position"
This reverts commit 3d846800e0, reversing
changes made to b31b4c932f.
2023-12-13 13:09:36 +01:00
Vitaly Baranov
96bbff3af0
Merge pull request #57764 from vitlibar/fix-retries-for-disconnected-nodes-for-backup-on-cluster
Fix retries for disconnected nodes for BACKUP/RESTORE ON CLUSTER
2023-12-13 13:06:32 +01:00
robot-clickhouse
7d9e9fd42e Automatic style fix 2023-12-13 11:38:41 +00:00
Igor Nikonov
7762beaf6c Fix: w/o replicas sync query result can vary 2023-12-13 11:23:53 +00:00
Kseniia Sumarokova
b1325450e9
Merge pull request #57754 from ClickHouse/fix-loading-dependent-table-materialized-postgresql
Table engine MaterializedPostgreSQL fix dependency loading
2023-12-13 12:17:01 +01:00
János Benjamin Antal
ddb33d6e35
Merge pull request #57791 from ilejn/atomic_set_in_librdkafka
Fix ThreadSanitizer data race in librdkafka
2023-12-13 10:43:51 +01:00
Raúl Marín
a45c8bd7f1
Merge pull request #57315 from Algunenano/randomize_optimizations
Randomize disabled optimizations in CI
2023-12-13 10:42:11 +01:00
robot-ch-test-poll1
c2f32f5994
Merge pull request #57795 from CurtizJ/fix-totals-maxMap
Fix merge in aggregation functions with `*Map` combinator
2023-12-13 10:31:15 +01:00
Igor Nikonov
5abeadf20f Fix: stop merges, otherwise test can be flaky 2023-12-13 08:54:44 +00:00
Mikhail Koviazin
bb22ce6ec8
fix clickhouse-client invocation in 02327_capnproto_protobuf_empty_messages
The test relies on `clickhouse-client` to be in `$PATH`, which is a wrong
assumption. This commit makes it use `$CLICKHOUSE_CLIENT_BINARY` instead.
2023-12-13 07:29:37 +00:00
Alexey Milovidov
62b6d1ef5e iMerge branch 'master' of github.com:ClickHouse/ClickHouse into clickbench-ci 2023-12-13 01:41:27 +01:00