Antonio Andelic
7739dd7157
Fix integration tests
2023-08-31 14:52:42 +00:00
Mike Kot
ebcc97ad1b
change case for copy operation in clickhouse-disks
2023-08-31 13:39:32 +00:00
vdimir
b9bb4af6be
Support setting up fail points in config
2023-08-31 11:45:39 +00:00
Tiakon
8c21bd8342
Update ClusterCopierApp.cpp
...
Shows that the type of task-upload-force is Boolean.
2023-08-31 10:42:45 +08:00
Alexey Milovidov
bb47e2cc23
Remove CurrentStatusInfo
2023-08-30 20:56:14 +02:00
Alexander Tokmakov
4d70624ca3
Merge pull request #53907 from arenadata/ADQM-1126
...
Added validate_tcp_client_information server setting
2023-08-30 15:10:13 +02:00
Azat Khuzhin
51e8b16916
Fix IO throttling during copying whole directories
...
v2: pass local context during ALTER TABLE MOVE PARTITION TO VOLUME/DISK as well
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-08-29 23:13:46 +02:00
Alexey Milovidov
62747ea20f
Merge pull request #53739 from Hexta/arm-clocksource
...
Do not warn about arch_sys_counter clock
2023-08-29 21:57:39 +03:00
Mike Kot
061bbe13c0
add docs for clickhouse-disks
2023-08-29 12:25:04 +00:00
Alexey Gerasimchuck
de1ed97876
disabled validate_tcp_client_information
2023-08-29 08:59:49 +00:00
robot-ch-test-poll
5ccc75b0f7
Merge pull request #53769 from ClickHouse/pufit/keeper-client-node-from-config
...
KeeperClient auto-detection of keeper node from clickhouse configs
2023-08-29 09:33:11 +02:00
pufit
7f4fc3744d
resolve issues
2023-08-28 22:23:01 -04:00
Alexey Gerasimchuck
e9757abea6
Added validate_tcp_client_information setting
2023-08-29 00:15:55 +00:00
Sergei Trifonov
c10e42ca05
Merge branch 'master' into async-loader-integration
2023-08-28 20:20:31 +02:00
Artur Malchanau
41508e129d
Merge branch 'ClickHouse:master' into arm-clocksource
2023-08-28 10:50:57 +03:00
Yong Wang
e5f968b0d8
Kusto-phase2: enabled fuzzing test for dialect prql
2023-08-26 07:40:40 -07:00
Yong Wang
1ec574057a
Kusto-phase2: fixed some functional test
2023-08-26 07:40:40 -07:00
Larry Luo
4f02667861
Fix AST Fuzzer
2023-08-26 07:40:39 -07:00
Yong Wang
5cc3f4708c
Kusto-phase2: restore to kusto dialect only, fix some style issue
2023-08-26 07:40:39 -07:00
Yong Wang
523bcf550d
Kusto-phase2: fix operators, unit test and functional test.
2023-08-26 07:40:39 -07:00
HeenaBansal2009
2ddc6cec9b
removed unwanted file
2023-08-26 07:40:32 -07:00
HeenaBansal2009
a4d828e0cf
Fixed failed testescases
2023-08-26 07:40:32 -07:00
Victor Krasnov
921f0c8b5d
Merge branch 'master' into ADQM-987
2023-08-25 21:20:23 +03:00
pufit
091a27359a
More careful logs handling
2023-08-25 12:22:21 -04:00
Kruglov Pavel
d80be4673b
Merge pull request #53692 from Avogar/cache-count
...
Cache number of rows in files for count in file/s3/url/hdfs/azure functions
2023-08-25 09:08:52 +02:00
Yakov Olkhovskiy
415a993c91
fix fuzzers build
2023-08-24 23:22:39 +00:00
Yakov Olkhovskiy
bb1e3aaa29
fix
2023-08-24 23:21:37 +00:00
Alexander Tokmakov
1eff7bee5e
Merge pull request #53673 from arenadata/ADQM-1105
...
Added client_info validation to the query packet in TCPHandler.
2023-08-24 21:03:25 +03:00
Kruglov Pavel
44db5fa992
Merge branch 'master' into cache-count
2023-08-24 17:21:18 +02:00
Arthur Passos
2bade7db08
Add global proxy setting ( #51749 )
...
* initial impl
* fix env ut
* move ut directory
* make sure no null proxy resolver is returned by ProxyConfigurationResolverProvider
* minor adjustment
* add a few tests, still incomplete
* add proxy support for url table function
* use proxy for select from url as well
* remove optional from return type, just returns empty config
* fix style
* style
* black
* ohg boy
* rm in progress file
* god pls don't let me kill anyone
* ...
* add use_aws guards
* remove hard coded s3 proxy resolver
* add concurrency-mt-unsafe
* aa
* black
* add logging back
* revert change
* imrpove code a bit
* helper functions and separate tests
* for some reason, this env test is not working..
* formatting
* :)
* clangtidy
* lint
* revert some stupid things
* small test adjusmtments
* simplify tests
* rename test
* remove extra line
* freaking style change
* simplify a bit
* fix segfault & remove an extra call
* tightly couple proxy provider with context..
* remove useless include
* rename config prefix parameter
* simplify provider a bit
* organize provider a bit
* add a few comments
* comment out proxy env tests
* fix nullptr in unit tests
* make sure old storage proxy config is properly covered without global context instance
* move a few functions from class to anonymous namespace
* fix no fallback for specific storage conf
* change API to accept http method instead of bool
* implement http/https distinction in listresolver, any still not implemented
* implement http/https distinction in remote resolver
* progress on code, improve tests and add url function working test
* use protcol instead of method for http and https
* small fix
* few more adjustments
* fix style
* black
* move enum to proxyconfiguration
* wip
* fix build
* fix ut
* delete atomicroundrobin class
* remove stale include
* add some tests.. need to spend some more time on the design..
* change design a bit
* progress
* use existing context for tests
* rename aux function and fix ut
* ..
* rename test
* try to simplify tests a bit
* simplify tests a bit more
* attempt to fix tests, accept more than one remote resolver
* use proper log id
* try waiting for resolver
* proper wait logic
* black
* empty
* address a few comments
* refactor tests
* remove old tests
* baclk
* use RAII to set/unset env
* black
* clang tidy
* fix env proxy not respecting any
* use log trace
* fix wrong logic in getRemoteREsolver
* fix wrong logic in getRemoteREsolver
* fix test
* remove unwanted code
* remove ClientConfigurationperRequest and auxilary classes
* remove unwanted code
* remove adapter test
* few adjustments and add test for s3 storage conf with new proxy settings
* black
* use chassert for context
* Add getenv comment
2023-08-24 16:07:26 +03:00
pufit
8c1f0251e6
Get keeper node from clickhouse configs
2023-08-23 22:18:24 -04:00
Yakov Olkhovskiy
e9ccfb24f1
Merge branch 'master' into build-fuzzer-protocol
2023-08-23 17:13:35 -04:00
Kruglov Pavel
592fa77987
Merge branch 'master' into cache-count
2023-08-23 15:18:02 +02:00
Artur Malchanau
97cdd0c276
Fix clang-tidy warning
2023-08-23 15:35:30 +03:00
helifu
7154cb0ed1
Support dynamic adjustment of log level
2023-08-23 19:42:03 +08:00
Artur Malchanau
0fd26152e3
Do not warn about arch_sys_counter clock
2023-08-23 12:51:27 +03:00
Robert Schulze
b70f3dbe41
Same variable name in LocalServer.cpp as in Server.cpp
2023-08-22 15:44:26 +00:00
Victor Krasnov
258f9927b4
Merge branch 'master' into ADQM-987
2023-08-22 16:49:32 +03:00
avogar
7f9e81d504
Clean up
2023-08-22 12:55:00 +00:00
Robert Schulze
f2fb7365e6
Add settings for 1. size_ratio (all caches) and 2. policy (index caches)
...
1. is an expert-level setting, default is 0.5, applies only to SLRU.
Also, I noticed that we expose cache policy settings for the mark and
the uncompresed cache but not for the index mark and the index
uncompressed cache. Changed that as well, it simplifies the code a bit.
2023-08-22 11:04:29 +00:00
Robert Schulze
acaa2eee58
Merge pull request #53556 from ClibMouse/feature/big-endian-UUID-correction
...
Change Big Endian-UUID to work the same as Little Endian-UUID
2023-08-22 11:57:44 +02:00
Alexey Gerasimchuck
3140958132
Added client_info validation
2023-08-22 03:52:57 +00:00
Robert Schulze
583d9b33f0
Merge pull request #51446 from rschu1ze/recfgable-caches
...
Runtime-reconfigurable cache sizes
2023-08-21 23:27:21 +02:00
Nikita Mikhaylov
145c99ee94
Merge pull request #53280 from evillique/better-stop-listen
...
Add EXCEPT clause to SYSTEM STOP LISTEN query
2023-08-21 19:03:49 +02:00
Robert Schulze
96c8b250ce
Allow to configure cache sizes at runtime
2023-08-21 13:51:10 +00:00
Victor Krasnov
a7813260c0
Merge branch 'master' into ADQM-987
2023-08-21 14:45:13 +03:00
Alexey Milovidov
47b565861b
Add maximize and drag options for the dashboard
2023-08-21 06:23:58 +02:00
Alexey Milovidov
11757f6540
No Grammarly for SQL
2023-08-20 13:42:00 +02:00
Alexey Milovidov
6895f441bc
Include params in the editor
2023-08-20 09:32:42 +02:00
Alexey Milovidov
7dd0e1f888
Resolve TODO
2023-08-20 09:19:10 +02:00
Alexey Milovidov
1a4b54875a
Add mass editor
2023-08-20 09:17:22 +02:00
Alexey Milovidov
b2462a1bb7
Add mass editor
2023-08-20 09:16:38 +02:00
Alexey Milovidov
fe610d0394
Fix bad JavaScript
2023-08-20 08:07:11 +02:00
Alexey Milovidov
59fced8e99
Fix errors in dashboard
2023-08-20 08:00:04 +02:00
Kseniia Sumarokova
3d2fb2eced
Merge pull request #53124 from kssenii/allowed-caches-dir-for-dynamic-disks
...
Allow to restrict fs caches paths (mainly useful for dynamic disks)
2023-08-19 13:30:23 +04:00
kssenii
5382442da0
Merge remote-tracking branch 'upstream/master' into allowed-caches-dir-for-dynamic-disks
2023-08-19 08:44:36 +04:00
Alexey Milovidov
68e694815c
The dashboard just got better
2023-08-19 01:38:22 +02:00
kothiga
f33c585bc5
Addressing feedback.
2023-08-18 13:50:31 -07:00
kothiga
b905703909
Correct to-from pairing for transformEndianness.
2023-08-18 11:25:08 -07:00
Austin Kothig
6b42975d33
Change BE-UUID to work the same as LE-UUID. Included high and low getters to provide cleaner code when accessing undertype.
2023-08-18 08:19:46 -07:00
pufit
2e69a1d3a2
Fix keeper default path check
2023-08-17 22:07:39 -04:00
robot-ch-test-poll
ce58b90ea1
Merge pull request #53455 from rschu1ze/respect-changed-cgroups-limit
...
Respect cgroup memory limit when reloading configuration
2023-08-18 00:03:35 +02:00
Alexander Tokmakov
89c365803f
Merge pull request #53424 from ClickHouse/exception_message_patterns6
...
Less exceptions with runtime format string
2023-08-17 17:58:04 +03:00
Robert Schulze
ec7daed52f
Merge pull request #50276 from ClibMouse/feature/mergetree-checksum-big-endian-support
...
MergeTree & SipHash checksum big-endian support
2023-08-17 13:27:18 +02:00
Robert Schulze
5253a7f650
Respect cgroup memory limit when reloading configuration
...
Cgroups allows to change the amount of memory available to a process
while it runs. The previous logic calculated the amount of available
memory only once at server startup. As a result, memory thresholds set
via cgroups were not picked up when the settings changed. We now always
incorporate the current limits during re-configuraton.
Note 1: getMemoryAmount() opens/reads a file which is potentially
expensive. Should be fine though since that happens only when
the server configuration changes.
Note 2: An better approach would be to treat cgroup limit changes as
another trigger for ClickHouse server re-configuration (which
currently only happens when the config files change). Shied away
from that for now because of the case that when the cgroup limit
is lowered, there is no guarantee that ClickHouse can shrink the
memory amount accordingly in time (afaik, it does so only lazily
by denying new allocations). As a result, the OOM killer would
kill the server. The same will happen with this PR but at a
lower implementation complexity.
2023-08-17 09:22:13 +00:00
Nikolay Degterinsky
a893f75884
Merge remote-tracking branch 'upstream/master' into better-stop-listen
2023-08-16 23:06:18 +00:00
Alexander Tokmakov
ba44d7260e
fix
2023-08-16 00:20:28 +02:00
kssenii
164b4f0ae3
Merge remote-tracking branch 'upstream/master' into allowed-caches-dir-for-dynamic-disks
2023-08-15 20:30:01 +04:00
Robert Schulze
8343ebd4ec
Clarify comment
2023-08-15 14:44:13 +00:00
Alexander Tokmakov
83c10dad18
Merge branch 'master' into exception_message_patterns6
2023-08-15 15:20:09 +02:00
Robert Schulze
f317903073
Merge branch 'ClickHouse:master' into consistency-fixes-for-caches
2023-08-15 10:25:08 +02:00
Alexander Tokmakov
894ec8e0d0
less exceptions with runtime format string
2023-08-14 21:45:59 +02:00
ltrk2
2846ea49b4
Merge branch 'master' into feature/mergetree-checksum-big-endian-support
2023-08-14 13:02:30 -04:00
Robert Schulze
7ed5166c8a
Cosmetics: Make re-cfg of query cache similar to re-cfg of other caches
...
This doesn't change semantics, it only changes in which places the
configuration is parsed. This makes the logic more consistent across
caches.
2023-08-14 15:42:32 +00:00
Robert Schulze
ed90463888
Add comment
2023-08-14 15:42:32 +00:00
Robert Schulze
bb53d635df
More consistency: Run same mark cache size check in ch-local
...
Server.cpp had a check that the configured mark cache size is not 0. Run
the same check in LocalServer.cpp.
2023-08-14 15:42:32 +00:00
Robert Schulze
f126e54b0d
Respect max_cache_size for all caches
...
So far, max_cache_size was only respected in Server.cpp, and in this
file only for the mark cache and the uncompressed cache. This commit
respects it also for the other cache types in Server.cpp, as well for
all caches in LocalServer.cpp.
2023-08-14 15:42:32 +00:00
Robert Schulze
54e54aed74
Cosmetics: Introduce constants for default cache sizes and policies
2023-08-14 15:42:32 +00:00
Mikhail f. Shiryaev
3655df0f40
Attempt to address reset ENV in init.d script
2023-08-14 16:32:52 +02:00
Victor Krasnov
247cd63ca1
Merge branch 'master' into ADQM-987
...
# Conflicts:
# src/Interpreters/Context.cpp
# src/Interpreters/InterpreterSystemQuery.cpp
2023-08-14 10:33:56 +03:00
kssenii
c3b8bc0267
Merge remote-tracking branch 'upstream/master' into allowed-caches-dir-for-dynamic-disks
2023-08-13 21:14:42 +04:00
Alexey Milovidov
38a391ef57
Fix tidy
2023-08-12 16:34:35 +02:00
Alexey Milovidov
435cbb44a5
Merge branch 'master' of github.com:ClickHouse/ClickHouse into benchmark-connect-in-parallel
2023-08-12 02:43:03 +02:00
Alexey Milovidov
97ec6a0e42
Merge pull request #35263 from sunny19930321/copier-check-drop-partition
...
clickhouse-copier add check drop partition
2023-08-12 03:37:42 +03:00
Alexey Milovidov
46c606b678
Merge pull request #53072 from ClickHouse/fix-comment
...
Fix a comment
2023-08-12 03:06:15 +03:00
Kseniia Sumarokova
ceb74ad3cb
Merge branch 'master' into allowed-caches-dir-for-dynamic-disks
2023-08-11 16:49:02 +02:00
Alexey Milovidov
a55f9eae84
Merge branch 'master' of github.com:ClickHouse/ClickHouse into allow-creating-system-tables-at-startup
2023-08-11 14:45:03 +02:00
Nikita Mikhaylov
dbe13e3016
Merge pull request #53110 from rmarduga/master
...
Add hints for HTTP handlers
2023-08-11 14:09:33 +02:00
ltrk2
1dc1b54c68
Merge branch 'master' into feature/mergetree-checksum-big-endian-support
2023-08-11 07:48:49 -04:00
robot-ch-test-poll
58cfede9f9
Merge pull request #53285 from ClickHouse/better-concurrency
...
Change the default of `max_concurrent_queries` from 100 to 1000
2023-08-11 13:01:48 +02:00
Alexey Milovidov
aae35f3b1c
Merge pull request #53184 from ClickHouse/better-ccache
...
Better usage of ccache
2023-08-11 04:43:45 +03:00
Alexey Milovidov
3b9d2c7080
Simplification
2023-08-11 03:06:07 +02:00
Alexey Milovidov
736ff1c127
Merge branch 'master' into allow-creating-system-tables-at-startup
2023-08-11 01:25:49 +02:00
Alexey Milovidov
45655928d1
clickhouse-benchmark: connect in parallel
2023-08-10 23:39:06 +02:00
Kseniia Sumarokova
99f7a83385
Merge branch 'master' into allowed-caches-dir-for-dynamic-disks
2023-08-10 22:26:33 +02:00
Alexey Milovidov
3aca240854
Change the default of max_concurrent_queries from 100 to 1000
2023-08-10 20:59:57 +02:00
Nikolay Degterinsky
bcc0fbbf91
Add EXCEPT clause to SYSTEM STOP LISTEN query
2023-08-10 16:10:33 +00:00
ltrk2
a2054c04dd
Merge branch 'master' into feature/mergetree-checksum-big-endian-support
2023-08-10 10:21:34 -04:00
Alexey Milovidov
c89c966d61
Merge branch 'master' into fix-comment
2023-08-10 17:03:31 +03:00
Alexey Milovidov
bb57caa83e
Merge pull request #53180 from ClickHouse/ditch-tons-of-garbage
...
Ditch tons of garbage
2023-08-10 16:59:51 +03:00
Alexey Milovidov
f35df23974
Merge branch 'master' into better-ccache
2023-08-10 16:52:32 +03:00
Victor Krasnov
9c34ef899e
Add backup_log table
2023-08-10 15:46:04 +03:00
Ruslan Mardugalliamov
5cdeacf4cf
Add hints for HTTP handlers
...
Add hints to HTTP handlers to help users avoid
misspellings. For example, if a user mistakenly writes
`/dashboad` instead of `/dashboard`, they will now get a
hint that /dashboard is the correct handler.
This change will improve the user experience by making it
easier for users to find the correct handlers.
#47662
2023-08-10 06:23:20 -04:00
Alexey Milovidov
07b59ed3d0
Merge branch 'master' into copier-check-drop-partition
2023-08-10 03:59:09 +03:00
Alexey Milovidov
68976c03b6
Merge branch 'master' into fix-comment
2023-08-10 03:45:32 +03:00
ltrk2
139e9433a8
Merge branch 'master' into feature/mergetree-checksum-big-endian-support
2023-08-09 09:48:00 -04:00
kssenii
2cfb4c0264
Merge remote-tracking branch 'upstream/master' into allowed-caches-dir-for-dynamic-disks
2023-08-09 11:09:34 +02:00
Alexey Milovidov
fa9abc5038
Better usage of ccache
2023-08-09 05:02:50 +02:00
Alexey Milovidov
aa757490bd
Ditch tons of garbage
2023-08-09 02:19:02 +02:00
Alexey Milovidov
06f557a62b
Merge branch 'master' of github.com:ClickHouse/ClickHouse into allow-creating-system-tables-at-startup
2023-08-07 18:58:18 +02:00
Alexey Milovidov
e1206dbaab
Add a comment from @tavplubix
2023-08-07 18:57:30 +02:00
pufit
30700996f0
Merge branch 'master' into pufit/keeper-client-improvements
...
# Conflicts:
# docs/en/operations/utilities/clickhouse-keeper-client.md
# programs/keeper-client/Commands.cpp
# programs/keeper-client/Commands.h
# programs/keeper-client/KeeperClient.cpp
# tests/integration/test_keeper_client/test.py
2023-08-07 12:26:08 -04:00
pufit
8e6f7b4d0b
Fix typo, fix tests, touch
command.
2023-08-07 12:08:31 -04:00
kssenii
0c174a7ec1
Allow to restrict fs caches paths
2023-08-07 18:00:26 +02:00
pufit
dc347d3dcb
Merge pull request #53010 from ClickHouse/pufit/keeper-client-fix-defaults
...
Fix default port for Keeper Client
2023-08-07 10:48:52 -04:00
Sergei Trifonov
f35c68623d
Merge branch 'master' into async-loader-integration
2023-08-07 11:24:19 +02:00
Alexey Milovidov
f1f983a92b
Add clusters for running tests locally easily
2023-08-06 13:34:11 +02:00
Alexey Milovidov
167f90e7f6
Maybe better
2023-08-06 13:28:21 +02:00
Alexey Milovidov
292a5de816
Create them in tests
2023-08-06 01:51:23 +02:00
Alexey Milovidov
06d45cfa81
Allow creating system logs at startup
2023-08-06 01:29:31 +02:00
Vitaly Baranov
80254c4034
Merge pull request #52861 from vitlibar/clickhouse-keeper-same-default-paths
...
Use the same default paths for clickhouse_keeper (symlink) as for clickhouse_keeper (executable)
2023-08-05 13:49:02 +02:00
Alexey Milovidov
5722557391
Merge branch 'master' into fix-comment
2023-08-05 13:36:59 +03:00
Alexey Milovidov
fa49607073
Merge pull request #52159 from ClickHouse/add-test-for-throw
...
Add a test that clickhouse-client or local do not throw/catch on startup
2023-08-05 03:24:32 +03:00
Alexey Milovidov
264bff8c9f
Fix a comment
2023-08-05 01:44:16 +02:00
Sergei Trifonov
432d359a2b
Merge branch 'master' into async-loader-integration
2023-08-04 18:51:06 +02:00
Vitaly Baranov
f55fe91d8b
Throw an exception if wrong default path is going to be used.
2023-08-04 16:13:27 +02:00
Vitaly Baranov
89c99e4a6d
Revert extracting the root keeper path from the 'path' key in the configuration ('path' must be reserved for clickhouse-server).
2023-08-04 15:55:26 +02:00
pufit
d916601717
Merge branch 'master' into pufit/keeper-client-fix-defaults
2023-08-04 09:04:14 -04:00
pufit
30a7bda91a
Merge branch 'master' into clickhouse-keeper-client-completion-fix
2023-08-04 08:52:56 -04:00
Vitaly Baranov
552331fd54
Use the same default paths for clickhouse_keeper (symlink) as for clickhouse_keeper (executable),
...
i.e. "/var/lib/clickhouse-keeper/.."
2023-08-04 13:38:21 +02:00
Azat Khuzhin
94fcae58b9
clickhouse-keeper-client: fix version parsing for set command
...
Previously:
/ :) set /test foo 1
DB::Exception: Bad get: has UInt64, requested Int64
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-08-04 09:50:45 +02:00
Azat Khuzhin
eda396eb7c
Fix completion for clickhouse-keeper-client
...
Previously some symbols had been counted as word breakers, and this
breaks the completion since after such symbol the completion will start
from scratch.
One of the most annoying was the "-" sign.
But actually all those word breakers that is used for SQL completion is
not required for keeper client, so let's leave only necessary.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-08-04 09:24:32 +02:00
Alexey Milovidov
eb546dd6b3
Merge branch 'master' into add-test-for-throw
2023-08-03 23:02:21 +03:00
pufit
14a8ced906
Fix default port
2023-08-03 12:29:31 -04:00
Alexander Tokmakov
968c79cf3f
Merge pull request #52956 from ClickHouse/fixes_for_databases
...
Fix some issues with databases
2023-08-03 19:13:41 +03:00
ltrk2
a29b36612b
Merge branch 'master' into feature/mergetree-checksum-big-endian-support
2023-08-03 09:41:25 -04:00
Alexey Milovidov
3e6ea96d8a
Merge branch 'master' into copier-check-drop-partition
2023-08-03 15:20:10 +03:00
Alexey Milovidov
3a9f9e1297
Revert "Implementing new commands for keeper-client"
2023-08-03 15:05:52 +03:00
Alexander Tokmakov
67d8f1c1c5
fix data race
2023-08-02 18:42:38 +02:00
ltrk2
27a2d4d1c7
Merge branch 'master' into feature/mergetree-checksum-big-endian-support
2023-08-02 11:36:43 -04:00
Alexey Milovidov
e223ca495c
Merge branch 'master' into copier-check-drop-partition
2023-08-01 23:26:53 +03:00
Yarik Briukhovetskyi
104a4aaee5
Merge pull request #51117 from ClickHouse/pufit/keeper-client-improvements
...
Implementing new commands for keeper-client
2023-08-01 17:47:33 +02:00
Alexey Milovidov
67e355558e
Merge branch 'master' into copier-check-drop-partition
2023-08-01 16:02:42 +03:00
Sergei Trifonov
e4ae2ece7c
Merge branch 'master' into async-loader-integration
2023-08-01 13:04:11 +02:00
Alexey Milovidov
a7b4a29ed9
Merge branch 'master' into fixes-start-stop-listen
2023-07-31 08:34:17 +03:00
alesapin
aba291ca68
Revert "Revert "Add an ability to specify allocations size for sampling memory profiler""
2023-07-30 14:01:34 +02:00
Alexey Milovidov
abf058c87d
Merge branch 'master' into no-export-dynamic
2023-07-30 01:49:12 +02:00
Alexey Milovidov
5d2fb786f6
Merge branch 'master' into fixes-start-stop-listen
2023-07-29 00:39:58 +03:00
ltrk2
6c9a1b14ef
Merge branch 'master' into feature/mergetree-checksum-big-endian-support
2023-07-28 16:18:46 -04:00
pufit
1e77c7c73f
Deterministic delete_stable_backups
2023-07-28 10:48:22 -04:00
pufit
4e8f7f06af
Merge branch 'master' into pufit/keeper-client-improvements
2023-07-28 10:32:27 -04:00
pufit
6211845ef0
Merge pull request #51303 from ClickHouse/deprecate-metadata-cache
...
Deprecate the `metadata_cache` feature
2023-07-28 10:31:02 -04:00
Alexander Tokmakov
39200606ec
Merge pull request #52174 from arenadata/ADQM-988
...
Added possibility to save logs on crash and options to configure logs buffer
2023-07-28 16:55:00 +03:00
Nikolay Degterinsky
0e30b9651a
Merge branch 'master' into fixes-start-stop-listen
2023-07-28 11:35:31 +02:00
Alexey Gerasimchuck
63b05da1f2
System logs improvements
2023-07-28 07:23:34 +00:00
Alexey Milovidov
a465dba311
Merge pull request #52628 from ClickHouse/load-suggestion-only-with-clickhouse-dialect
...
Load suggestion only with `clickhouse` dialect
2023-07-28 10:21:53 +03:00
robot-clickhouse-ci-1
ac2de3c79f
Merge pull request #52643 from ClickHouse/fix-local-udf-settings
...
UDF: allow positional options for clickhouse-local and populate global udf settings
2023-07-28 09:21:04 +02:00
pufit
0e15f098d1
Yet another fix test
2023-07-28 02:22:44 -04:00
Nikolay Degterinsky
b5160c8072
Fix bugs and better test for SYSTEM STOP LISTEN
2023-07-27 14:16:19 +00:00
Yakov Olkhovskiy
d35c87c1bd
allow positional options for clickhouse-local and populate global udf settings
2023-07-27 05:06:16 +00:00
Alexey Milovidov
a43bcbef44
Merge branch 'database-filesystem-remove-catch' into add-test-for-throw
2023-07-27 06:34:40 +02:00
Kruglov Pavel
fab77783f1
Merge pull request #49367 from ClickHouse/enc
...
Partially reimplement Parquet encoder to make it faster and parallelizable
2023-07-27 00:48:54 +02:00
Nikolay Degterinsky
d89e2e6a27
Add SYSTEM STOP LISTEN query ( #51016 )
...
Co-authored-by: Nikita Mikhaylov <nikitamikhaylov@clickhouse.com>
Co-authored-by: Nikita Mikhaylov <mikhaylovnikitka@gmail.com>
2023-07-26 19:58:41 +02:00
János Benjamin Antal
3a6aaa29c9
Do not load suggestions in case not ClickHouse dialects
2023-07-26 15:26:21 +00:00
pufit
ea672ba618
Add docs, add tests, fix small issues.
2023-07-26 11:15:27 -04:00
pufit
3a838f09d1
Update programs/keeper-client/Commands.h
...
Co-authored-by: Yarik Briukhovetskyi <114298166+yariks5s@users.noreply.github.com>
2023-07-26 11:15:27 -04:00
pufit
bb2a749b94
Update programs/keeper-client/Commands.cpp
...
Co-authored-by: Yarik Briukhovetskyi <114298166+yariks5s@users.noreply.github.com>
2023-07-26 11:15:27 -04:00
pufit
68b78f52ec
Add DeleteStableBackups, FindBigFamily
2023-07-26 11:15:27 -04:00
pufit
10a8a8dd74
Implementing new commands for keeper-client
2023-07-26 11:15:27 -04:00
Robert Schulze
d4737ca033
Merge pull request #50986 from arenadata/ADQM-822
...
Implement support of encrypted elements in configuration file
2023-07-26 12:27:04 +02:00
Alexander Tokmakov
6bbed6262e
Merge branch 'master' into add_delay_for_replicated
2023-07-26 12:48:48 +03:00
Anton Popov
4531b105ac
Merge branch 'master' into flush-async-insert-queue
2023-07-25 15:48:01 +02:00
Michael Kolupaev
dfdf5de972
Fixes
2023-07-25 10:16:28 +00:00
Alexey Milovidov
9036fe8749
Merge branch 'master' into no-export-dynamic
2023-07-24 17:42:59 +02:00
Alexander Tokmakov
faca49a905
Merge branch 'master' into add_delay_for_replicated
2023-07-24 16:07:38 +02:00
Anton Popov
347f442f84
Merge remote-tracking branch 'upstream/master' into HEAD
2023-07-24 10:55:31 +00:00
Roman Vasin
0af869ff0f
Merge branch 'master' into ADQM-822
2023-07-24 12:23:11 +03:00
Alexey Milovidov
75efee9675
Fix errors
2023-07-24 05:34:00 +02:00
Alexey Milovidov
a17652a422
Merge branch 'master' into incbin
2023-07-24 05:33:52 +02:00
Alexey Milovidov
10aa12d3b3
Merge branch 'master' into no-export-dynamic
2023-07-24 02:20:33 +02:00
robot-ch-test-poll4
fb045b0d86
Merge pull request #52498 from ClickHouse/dont_shutdown_interserver_before_tables
...
Don't shutdown interserver before tables
2023-07-24 01:45:25 +02:00
Alexey Milovidov
c60553ae70
Merge branch 'incbin' into no-export-dynamic
2023-07-24 00:12:53 +02:00
Alexey Milovidov
1e467867e6
Attempt to fix LTO
2023-07-24 00:03:40 +02:00
alesapin
753a8d0a43
Merge branch 'dont_shutdown_interserver_before_tables' into add_delay_for_replicated
2023-07-23 22:41:15 +02:00
alesapin
e02948580b
Don't shutdown interserver before tables
2023-07-23 22:38:59 +02:00
Alexey Milovidov
63659c55a1
Merge branch 'incbin' into no-export-dynamic
2023-07-23 21:34:12 +02:00
Alexey Milovidov
0f66d161d6
Merge branch 'master' of github.com:ClickHouse/ClickHouse into no-export-dynamic
2023-07-23 21:33:51 +02:00
Alexey Milovidov
43bd6d1b83
Revert "Add an ability to specify allocations size for sampling memory profiler"
2023-07-23 19:00:49 +03:00
Alexey Milovidov
43cf31a98e
Merge branch 'master' into no-export-dynamic
2023-07-23 07:26:33 +03:00
Alexey Milovidov
00d6f2ee08
Use incbin for resources, part 1
2023-07-23 06:11:03 +02:00
alesapin
d1fa105d60
Merge branch 'master' into add_delay_for_replicated
2023-07-23 00:12:29 +02:00
alesapin
835c36cbf3
Merge pull request #52419 from ClickHouse/implement_borders_for_sampling_memory_profiler
...
Add an ability to specify allocations size for sampling memory profiler
2023-07-22 18:13:26 +02:00
alesapin
6416fb6eed
Merge branch 'master' into add_delay_for_replicated
2023-07-22 12:11:39 +02:00
robot-ch-test-poll2
69b897d726
Merge pull request #52113 from arenadata/ADQM-996
...
Collect logs for the system.text_log table even before it is initialized, to record the server startup
2023-07-22 00:01:45 +02:00
Sergei Trifonov
8eaf3b6d94
Merge branch 'master' into async-loader-integration
2023-07-21 21:46:06 +02:00
Alexander Sapin
4695ec6802
Add an ability to specify allocations size for sampling memory profiler
2023-07-21 14:56:29 +02:00
ltrk2
90a2c460c6
Merge branch 'master' into feature/mergetree-checksum-big-endian-support
2023-07-21 08:07:18 -04:00
Antonio Andelic
10c2d5dade
Merge branch 'master' into feature/keeper-dyn-reconf
2023-07-21 13:24:18 +02:00
Dmitry Kardymon
5124f74fcc
Merge remote-tracking branch 'origin/master' into ADQM-996
2023-07-21 05:54:36 +00:00
Nikita Mikhaylov
668062dc29
Merge branch 'master' into no-keep-context-lock-while-calculating-access
2023-07-20 14:42:13 +02:00
alesapin
cbcd48979c
Fix race one more time
2023-07-20 13:04:43 +02:00
serxa
02fc66db10
avoid using bg pool during non-async start
2023-07-19 17:37:53 +00:00
ltrk2
967be3e13c
Correct a line commented out by mistake
2023-07-19 10:01:58 -07:00
ltrk2
51e2c58a53
Implement endianness-independent SipHash and MergeTree checksum serialization
2023-07-19 10:01:55 -07:00
Sergei Trifonov
b8a46ff822
Merge branch 'master' into async-loader-integration
2023-07-19 18:45:41 +02:00
serxa
6bca79fdff
add auto-resolution for all resolvable deadlock types
2023-07-19 16:19:28 +00:00
alesapin
8be1454b28
Fix race
2023-07-18 16:06:03 +02:00
Sergei Trifonov
850ab23991
Merge branch 'master' into async-loader-integration
2023-07-17 19:14:54 +02:00
Nikita Mikhaylov
ee0bbc0e54
Merge branch 'master' into headers-blacklist
2023-07-17 19:08:52 +02:00
Nikita Mikhaylov
11cc8b4adf
Merge branch 'master' into add_delay_for_replicated
2023-07-17 19:04:29 +02:00
Vitaly Baranov
815a3857de
Remove non-const function Context::getClientInfo().
2023-07-17 15:02:07 +02:00
Nikita Mikhaylov
d5b97e4cc1
Merge branch 'master' into deprecate-metadata-cache
2023-07-17 15:00:27 +02:00
Antonio Andelic
61dc020b4d
Merge branch 'master' into feature/keeper-dyn-reconf
2023-07-17 12:50:17 +02:00
Alexey Milovidov
e4384e104b
Add a test that clickhouse-client or local do not throw/catch on startup
2023-07-17 00:06:58 +02:00
Dmitry Kardymon
fe6918a9d5
Merge remote-tracking branch 'origin/master' into ADQM-996
2023-07-14 06:56:06 +00:00
Dmitry Kardymon
771b1f8f47
Prototype (working)
2023-07-12 15:48:09 +00:00
pufit
e87e3f8678
Merge branch 'master' into keeper-client-fix-parser
2023-07-11 20:13:51 -04:00
robot-ch-test-poll3
ea7ff2f37e
Merge pull request #51723 from arenadata/ADQM-956
...
Added ASK_PASSWORD client constant instead of hardcoded '\n'
2023-07-12 00:37:59 +02:00
Mike Kot
d0f81fb1cd
fix
2023-07-11 13:33:07 +00:00
Mike Kot
3e8906e5a2
fix build for non-ssl systems
2023-07-11 12:23:10 +00:00
Mike Kot
471e5a056d
fix
2023-07-11 10:40:55 +00:00
Roman Vasin
b6023d9f62
Merge branch 'master' of github.com:ClickHouse/ClickHouse into ADQM-822
2023-07-11 10:35:31 +00:00
Mike Kot
23e3c57a6a
reload certificates for Keeper
2023-07-11 10:13:30 +00:00
Mike Kot
062b1c464c
watch for certificate file updates in configreloader
2023-07-11 10:04:43 +00:00
Alexey Gerasimchuck
8f882b270e
Merge branch 'master' into ADQM-956
2023-07-11 16:02:14 +10:00
Azat Khuzhin
2db092f9d8
Cleanup remote_servers in dist config.xml
...
At first, there was no such amount of clusters in dist config, they
added when someone need to write some new cluster for tests.
So let's move them to the clusters.xml that is deployed only for tests,
and leave only default cluster.
And cleanup also some configs that had been copied from dist config in
the repo (about test_config_* integration tests, this should be OK,
since there are more_clusters.xml as well, that covers additional
cases).
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-09 16:55:27 +02:00
Azat Khuzhin
a10aa9ad50
Force libunwind usage (removes gcc_eh support)
...
libunwind is reentrant and signal safe, and works faster then then
gcc_eh (plus it has some custom patches for problems that have been
found during it's usage in ClickHouse).
gcc_eh may be missing in the system (if gcc was not installed), and
even if it exists clickhouse uses -nodefaultlibs, so some care should be
made to make it work.
Also this library is tiny and there shouln't be any problem to require
it always (there is already tendency to require some contrib libraries,
i.e. poco).
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-08 20:55:50 +02:00
Alexey Milovidov
52277d6252
Merge pull request #51363 from azat/clickhouse-local-default-settings
...
Use separate default settings for clickhouse-local
2023-07-08 19:37:27 +03:00
Alexey Milovidov
e4dd603919
Merge pull request #51497 from ClickHouse/fix-shutdown-race
...
Fix possible race on shutdown wait
2023-07-08 03:03:45 +03:00
Alexander Sapin
e618dd05cc
Fix clang tidy and race
2023-07-07 13:03:44 +02:00
Alexey Milovidov
e303afbffb
Merge branch 'master' into fix-incorrect-warning
2023-07-07 13:44:21 +03:00
Nikolay Degterinsky
e98d136243
Merge branch 'master' into headers-blacklist
2023-07-07 04:44:06 +02:00
Alexey Milovidov
3ec617b184
Fix build
2023-07-07 01:31:52 +02:00
Alexander Tokmakov
fdbd59ec6c
Merge pull request #51135 from ClickHouse/fix_trash_in_disks
...
Try to fix some trash in Disks and part moves
2023-07-07 02:02:17 +03:00
Mike Kot
8b6376005a
"reconfig" support for CH Keeper
2023-07-07 00:20:54 +03:00
Alexander Sapin
30bcc73c63
Merge branch 'master' into add_delay_for_replicated
2023-07-06 14:29:15 +02:00
Alexey Milovidov
5416b7b6df
Fix incorrect log level = warning
2023-07-06 03:04:58 +02:00
Alexey Milovidov
0ae7f6bc80
Merge branch 'master' into fix-text_log
2023-07-06 03:33:35 +03:00
Alexey Milovidov
1a24bface0
Merge branch 'master' into clickhouse-local-default-settings
2023-07-06 03:30:11 +03:00
Kseniia Sumarokova
998e038c9d
Merge pull request #51208 from kssenii/resubmit-51149
...
Resubmit #48821
2023-07-05 23:26:20 +02:00
alesapin
88d3e1723a
Fixes and comments
2023-07-05 18:31:47 +02:00
alesapin
baee73fd96
Make shutdown of replicated tables softer
2023-07-05 18:11:25 +02:00
Alexey Milovidov
31f68c2c67
Merge branch 'master' into deprecate-metadata-cache
2023-07-04 22:28:14 +02:00
Alexey Milovidov
1eaa2e9d30
Merge branch 'master' into no-export-dynamic
2023-07-04 22:37:46 +03:00
Alexey Gerasimchuck
3218624461
Merge branch 'master' into ADQM-956
2023-07-04 11:47:24 +10:00
Sergei Trifonov
bbb5850dec
Merge branch 'master' into async-loader-integration
2023-07-03 20:21:26 +02:00
Zach Naimon
edeef107f0
fix authError behavior, fix overlapping chart behavior
2023-07-03 12:42:51 -04:00
Nikolay Degterinsky
82e0237e67
Merge branch 'master' into headers-blacklist
2023-07-03 16:54:50 +02:00
Kseniia Sumarokova
19508a01a5
Merge branch 'master' into resubmit-51149
2023-07-03 13:12:53 +02:00
Sergei Trifonov
4e099086cd
Merge branch 'master' into fix-shutdown-race
2023-07-03 11:15:34 +02:00
Antonio Andelic
eba60dd81e
Merge branch 'master' into keeper-with-disks
2023-07-01 20:59:16 +02:00
Nikolay Degterinsky
8dfa773f44
Merge branch 'master' into headers-blacklist
2023-06-30 23:40:17 +02:00
Antonio Andelic
2058b1346e
Merge branch 'master' into keeper-with-disks
2023-06-30 13:22:33 +00:00
Sergei Trifonov
c8d6aa8b90
Merge branch 'master' into fix-shutdown-race
2023-06-30 15:12:21 +02:00
Sema Checherinda
d0d12bbf3b
Merge branch 'master' into no-finalize-WriteBufferFromOStream
2023-06-30 12:15:17 +02:00
Alexey Milovidov
6f655bbc06
Merge branch 'master' into fix-text_log
2023-06-29 14:30:30 +03:00
Antonio Andelic
6e1aec6e0b
Merge branch 'master' into keeper-add-api-version-config
2023-06-29 11:36:49 +02:00
Alexey Milovidov
a4d7e48bc9
Merge branch 'master' into resubmit-51149
2023-06-29 11:07:01 +03:00
Sema Checherinda
1596b09dc2
add missing finalize calls
2023-06-28 10:51:54 +02:00
serxa
6515d52f60
fix2
2023-06-27 18:50:40 +00:00
Sergei Trifonov
b9b007691c
Merge branch 'master' into async-loader-integration
2023-06-27 19:44:52 +02:00
serxa
40f721ae4f
fix possible race on shutdown wait
2023-06-27 17:14:33 +00:00
Sema Checherinda
d6f1e4b527
Merge branch 'master' into no-finalize-WriteBufferFromOStream
2023-06-27 19:02:27 +02:00
Nikita Mikhaylov
4b0b4fad7c
Merge branch 'master' into keeper-client-fix-parser
2023-06-27 14:17:33 +02:00
Antonio Andelic
efbe01b6bb
Merge branch 'master' into keeper-add-api-version-config
2023-06-27 10:11:04 +00:00
Sergei Trifonov
e2798b5221
Merge branch 'master' into async-loader-integration
2023-06-26 19:18:23 +02:00
Sema Checherinda
d4d85d9fe9
add explicit finalize calls
2023-06-26 16:03:47 +02:00
Alexey Milovidov
c4ea7ab5b1
Attempt to fix test_ssl_cert_authentication
2023-06-25 09:31:09 +02:00
Azat Khuzhin
59f11863d7
Simplify settings overrides or clickhouse-local
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-06-24 23:42:31 +03:00
Azat Khuzhin
5d43a64112
Initialize text_log earlier to capture table startup messages
...
While I was investigating some issues, I noticed that messages from
table startup are not appears in system.text_log due to too late
initialization.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-06-24 13:16:16 +02:00
Azat Khuzhin
0f02d473d9
Improve parsing of path in clickhouse-keeper-client
...
Before this patch:
/ :) get /tables/default/data/block_numbers/0-7
Syntax error: failed at position 40 ('0'):
get /tables/default/data/block_numbers/0-7
Expected end of query
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-06-24 12:56:48 +02:00
Robert Schulze
43c97d76bf
Merge pull request #44149 from zvonand/zvonand-implicit-tz
...
Session time zones
2023-06-23 14:28:49 +02:00
Robert Schulze
f367ced809
Merge pull request #51294 from rschu1ze/qc-remove-dflts
...
Query Cache: Un-comment settings in server cfg
2023-06-23 09:55:48 +02:00
Alexey Milovidov
a92513048d
Add a warning
2023-06-23 02:36:00 +02:00
Alexey Milovidov
8b1cd9fcec
Remove metadata_cache from config
2023-06-23 02:27:10 +02:00
Robert Schulze
bfb2debca9
Restore settings
2023-06-22 21:31:05 +00:00
Robert Schulze
506d52358a
Query Cache: Remove confusing defaults in server cfg
2023-06-22 20:52:50 +00:00
Alexander Tokmakov
3afb0933a5
Merge branch 'master' into fix_trash_in_disks
2023-06-22 20:27:57 +02:00
Andrey Zvonov
d4316c7189
Merge branch 'master' into zvonand-implicit-tz
2023-06-22 17:23:20 +02:00
Alexander Tokmakov
318ac807c7
Merge branch 'master' into fix_trash_in_disks
2023-06-21 14:04:01 +02:00
Andrey Zvonov
b4f2e4020d
Merge branch 'master' into zvonand-implicit-tz
2023-06-21 13:41:35 +02:00
Mikhail f. Shiryaev
4fb2dc8384
Decrease default settings for http headers name and value to 128K
2023-06-21 12:59:27 +02:00
kssenii
0efaecab51
Revert "Merge pull request #51149 from ClickHouse/revert-48821-localfilefunction"
...
This reverts commit a09e6bbb8e
, reversing
changes made to ce38d64c5a
.
2023-06-21 00:29:46 +02:00
Sergei Trifonov
02e0d7e204
Merge branch 'master' into async-loader-integration
2023-06-20 12:03:29 +02:00
Maksim Kita
7e5017dd31
Fixed tests
2023-06-20 11:42:22 +03:00
Andrey Zvonov
07191ce10d
Merge branch 'master' into zvonand-implicit-tz
2023-06-20 00:24:53 +02:00
Alexander Tokmakov
caceb7c862
Revert "Added ability to implicitly use file/hdfs/s3 table functions in clickhouse-local"
2023-06-19 13:21:09 +03:00
Alexey Gerasimchuck
25948cdd9e
Added ASK_PASSWORD client constant
2023-06-19 03:57:38 +00:00
Alexander Tokmakov
76faacd23c
try to fix some trash in Disks
2023-06-18 14:59:10 +02:00
Alexey Milovidov
9fc5b9c2c5
Merge branch 'master' into relax-too-many-parts
2023-06-17 16:14:34 +03:00
Alexey Milovidov
df9abccfaa
Merge branch 'master' into localfilefunction
2023-06-17 00:45:54 +03:00
Alexey Milovidov
688d5d59af
Merge branch 'master' into relax-too-many-parts
2023-06-16 23:08:29 +02:00
Roman Vasin
d55878d587
Merge branch 'master' into ADQM-822
2023-06-16 18:57:51 +03:00
Roman Vasin
f026cf17a3
Fix building with BUILD_STANDALONE_KEEPER
2023-06-16 15:26:58 +00:00
zvonand
112a3e6aca
revert tz validation optimization
2023-06-16 12:19:01 +02:00
Antonio Andelic
56a48037ba
Merge pull request #50964 from ClickHouse/pufit/embedded-keeper-client
...
Add embedded keeper-client to keeper standalone binary
2023-06-16 10:08:41 +02:00
zvonand
4155d13d69
merge master and resolve conflict
2023-06-16 02:20:32 +02:00
zvonand
e60506f41b
changes requested in review
2023-06-16 02:16:04 +02:00
pufit
e01e0d53a9
Add embedded keeper-client to keeper standalone binary
2023-06-15 12:08:20 -04:00
Nikolay Degterinsky
9a25958be8
Add HTTP header filtering
2023-06-15 13:49:49 +00:00
Robert Schulze
946e1a8c6f
Merge pull request #50966 from arenadata/ADQM-934
...
clickhouse-client: Force that `--password` is specified at most once
2023-06-15 11:14:26 +02:00
pufit
e2b9f59e1e
Merge pull request #50965 from ClickHouse/pufit/keeper-client-better-help-message
...
Fix keeper-client help message
2023-06-14 18:42:26 -04:00
Alexey Gerasimchuck
75e6b4475d
corrections after review
2023-06-14 22:35:38 +00:00
Alexey Gerasimchuck
a6420ee338
Merge branch 'master' into ADQM-934
2023-06-15 08:25:24 +10:00
Antonio Andelic
f9f1e870c8
Fix build
2023-06-14 10:09:01 +00:00
Antonio Andelic
4825286b0c
Merge branch 'master' into keeper-with-disks
2023-06-14 10:48:53 +02:00
Alexey Gerasimchuck
1f76d08743
fixed --password "" --password issue
2023-06-14 02:24:45 +00:00
Alexey Gerasimchuck
f1b5d47ce2
corrections after second review iteration
2023-06-14 01:26:39 +00:00
pufit
c05bcf5605
Fix keeper-client help message
2023-06-13 21:09:30 -04:00
Antonio Andelic
bf0260bf5e
Merge branch 'master' into keeper-add-api-version-config
2023-06-13 21:27:51 +02:00
Alexey Gerasimchuck
e3a13111ae
Merge branch 'master' into ADQM-871
2023-06-13 14:05:13 +10:00
Antonio Andelic
a7e6264d56
Add backward compatibility
2023-06-12 13:12:05 +00:00
Alexey Milovidov
fef63351bb
Merge branch 'master' into no-export-dynamic
2023-06-11 19:56:00 +03:00
Alexey Milovidov
598501011f
Relax "too many parts" further
2023-06-11 17:51:54 +02:00
Alexey Milovidov
818e081162
Fill gaps on the dashboard
2023-06-10 14:30:36 +02:00
Antonio Andelic
b8b70d78e1
Build fix
2023-06-09 13:34:27 +00:00
Alexey Gerasimchuck
d0938e95e6
prohibited to use --connection
2023-06-09 06:40:57 +00:00
Alexey Gerasimchuck
7578203b46
Changes after review
2023-06-09 03:44:43 +00:00
Andrey Zvonov
d95be4162f
Merge branch 'master' into zvonand-implicit-tz
2023-06-08 18:34:45 +03:00
Sergei Trifonov
0cbcff958a
Merge branch 'master' into async-loader-integration
2023-06-07 18:55:04 +02:00
Anton Popov
9cd0d5e6db
move settings to server_settings
2023-06-07 11:49:41 +00:00
Anton Popov
c980771c22
Merge remote-tracking branch 'upstream/master' into HEAD
2023-06-07 11:23:13 +00:00
Antonio Andelic
bea4e8e81f
Add new files
2023-06-07 06:45:14 +00:00
Alexey Gerasimchuck
23a3026836
Implemented connection string
2023-06-07 03:16:29 +00:00
Antonio Andelic
42798e446b
Merge branch 'master' into keeper-with-disks
2023-06-06 14:55:47 +00:00
Nikita Mikhaylov
e87348010d
Rework loading and removing of data parts for MergeTree tables. ( #49474 )
...
Co-authored-by: Sergei Trifonov <sergei@clickhouse.com>
2023-06-06 14:42:56 +02:00
Antonio Andelic
c4873027c3
Merge branch 'master' into keeper-with-disks
2023-06-05 07:08:33 +00:00
Sergei Trifonov
6aadcffe59
Merge branch 'master' into async-loader-integration
2023-06-03 12:52:47 +02:00
Nikita Mikhaylov
362055ce60
Merge branch 'master' into 46229-repl-clickhouse-keeper
2023-06-02 23:58:07 +02:00
Sergei Trifonov
3ee782a0ec
Merge branch 'master' into async-loader-integration
2023-06-02 18:27:19 +02:00
serxa
866c9df70b
fix clickhouse-local
2023-06-02 16:26:55 +00:00
serxa
aceca2e210
fix server
2023-06-02 16:24:56 +00:00
Nikita Mikhaylov
73db383727
Limit the number of in-flight tasks for loading outdated parts ( #50450 )
...
* Done
* Update programs/local/LocalServer.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
* Bump
---------
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-06-02 14:10:26 +02:00
Andrey Zvonov
2e427ee028
Merge branch 'master' into zvonand-implicit-tz
2023-06-02 01:15:56 +03:00
Antonio Andelic
514beb783b
Merge branch 'master' into keeper-with-disks
2023-06-01 12:19:43 +00:00
Robert Schulze
73fb2081c1
Merge pull request #50210 from arenadata/ADQM-880
...
clickhouse-client: disallow usage of `--query` and `--queries-file` at the same time
2023-06-01 14:16:20 +02:00
Nikita Mikhaylov
3543d95980
Parallel replicas always skip unavailable ones ( #50293 )
2023-05-31 22:10:33 +02:00
serxa
5048050085
use pool ids instead of priorities in load jobs
2023-05-31 16:53:10 +00:00
serxa
e1045f76de
rework async loader initialization and reconfiguration for bg/fg pools
2023-05-31 16:23:41 +00:00
Sergei Trifonov
9b64c6b9f3
Merge branch 'master' into async-loader-integration
2023-05-31 17:17:13 +02:00
Nikita Mikhaylov
31829f7cfc
Merge branch 'master' into 46229-repl-clickhouse-keeper
2023-05-31 02:29:08 +02:00
Andrey Zvonov
87fc780c14
Merge branch 'master' into zvonand-implicit-tz
2023-05-30 13:13:46 +03:00
Antonio Andelic
67746bfff2
Merge branch 'master' into keeper-with-disks
2023-05-30 09:50:12 +00:00
zvonand
d4cec1f0e0
fix client thread attachment + make better tests
2023-05-30 01:30:01 +02:00
Alexey Gerasimchuk
9714fa011e
Merge branch 'master' into ADQM-880
2023-05-30 07:45:09 +10:00
Alexey Gerasimchuck
8574559e23
Disallow usage of --query and --queries-file
2023-05-28 22:25:40 +00:00
helifu
03e11b6e16
Remove the duplicate pair of parentheses
2023-05-28 12:59:34 +08:00
Sergei Trifonov
fe172f59db
Merge branch 'master' into async-loader-integration
2023-05-26 18:56:08 +02:00
Antonio Andelic
0740bfbe4b
Better disks moving
2023-05-26 14:31:09 +00:00
Nikita Mikhaylov
cf6ff7ab32
Merge branch 'master' of github.com:ClickHouse/ClickHouse into 46229-repl-clickhouse-keeper
2023-05-25 13:41:25 +00:00
Antonio Andelic
7e68f61df1
Fix snapshot recovery
2023-05-25 08:43:11 +00:00
Antonio Andelic
092cf99147
Fix build
2023-05-24 13:45:14 +00:00
Antonio Andelic
fa3fb49d33
Merge branch 'master' into keeper-with-disks
2023-05-24 09:04:47 +00:00
Antonio Andelic
5db2160762
Fix build
2023-05-24 09:04:12 +00:00
Antonio Andelic
161afea266
Add support for changelog
2023-05-24 07:43:57 +00:00
alekseygolub
34fe8ba5cd
Merge branch 'ClickHouse:master' into localfilefunction
2023-05-24 09:49:03 +03:00
Alexey Gerasimchuk
df751f1bca
Merge branch 'master' into ADQM-808
2023-05-23 13:43:18 +10:00
Alexey Gerasimchuck
ab5e16a713
Changes after second review iteration
2023-05-23 00:27:17 +00:00
Alexey Milovidov
afc823032c
Merge pull request #50114 from ClickHouse/bump-go-mod
...
Update github.com/distribution/distribution
2023-05-23 01:48:46 +03:00
Mikhail f. Shiryaev
d103e9adec
Update github.com/distribution/distribution
2023-05-22 23:36:39 +02:00
Sergei Trifonov
994cfaf15b
Merge branch 'master' into async-loader-integration
2023-05-22 19:03:11 +02:00
Kseniia Sumarokova
c6e4db969f
Merge pull request #50028 from kssenii/some-minor-changes
...
Move some common code to common
2023-05-22 18:25:24 +02:00
Antonio Andelic
bde2cf96b1
Better
2023-05-22 12:24:16 +00:00
kssenii
5c48f96347
Fix build
2023-05-22 12:35:57 +02:00
Antonio Andelic
dc31396035
Merge branch 'master' into keeper-with-disks
2023-05-22 08:10:24 +00:00
alekseygolub
70b9077bb2
Merge branch 'ClickHouse:master' into localfilefunction
2023-05-21 17:49:29 +03:00
Alexey Milovidov
2c8c412835
Merge pull request #50013 from ClickHouse/mysql-compatibility-setting
...
Allow some settings for MySQL compatibility
2023-05-20 02:04:02 +03:00
zvonand
7dccb51bc0
fix conflict and update
2023-05-19 23:40:51 +02:00
kssenii
791bb6cd4c
Fix style check
2023-05-19 17:35:01 +02:00
kssenii
0eab528f9f
Move common code
2023-05-19 16:23:56 +02:00
Alexey Milovidov
70c83f5133
Merge pull request #49991 from amosbird/clickhouse_as_library
...
Use PROJECT_*_DIR instead of CMAKE_*_DIR.
2023-05-19 12:37:18 +03:00
Alexey Milovidov
f47375d16c
Support Tableau
2023-05-19 10:28:13 +02:00
Amos Bird
6b4dcbd3ed
Use PROJECT_*_DIR instead of CMAKE_*_DIR.
2023-05-18 23:23:39 +08:00
Antonio Andelic
bf6afd27a6
build with disks
2023-05-18 07:39:22 +00:00
Alexey Gerasimchuck
4a6c7254e8
--multiquery <sql> -> -n -q <sql> syntax sugar
2023-05-17 03:43:35 +00:00
Anton Popov
69ec65ab33
Merge remote-tracking branch 'upstream/master' into HEAD
2023-05-16 10:30:47 +00:00
Antonio Andelic
465123fa1b
Merge branch 'master' into keeper-with-disks
2023-05-16 08:07:06 +00:00
Azat Khuzhin
424a20ee1c
Log with warning if the server was terminated forcefully
...
In case of it is terminated forcefully it will not be terminated
gracefully (i.e. run dtors and stuff), and by using warning log level
those messages will go to clickhouse-server.err.log, in which messages
are kept for a longer period then in clickhouse-server.log (at least
because it contains only warnings, errors and fatals only).
This will help with investigating some obscure issues.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-15 14:20:42 +02:00
Sergei Trifonov
e2c1581fd0
Merge branch 'master' into async-loader-integration
2023-05-14 15:20:03 +02:00
Alexey Milovidov
5a44dc26e7
Fixes for clang-17
2023-05-13 02:57:31 +02:00
serxa
9bf5292415
refact
2023-05-12 19:49:47 +00:00
Alexey Milovidov
ddb3e3c39e
Merge pull request #49812 from ClickHouse/udf-yaml
...
Allow loading dicrionaries and functions from YAML by default
2023-05-12 21:16:16 +03:00
Sergei Trifonov
426184ef73
Merge branch 'master' into async-loader-integration
2023-05-12 19:55:24 +02:00
serxa
4d31051bb9
add async_load_databases server setting
2023-05-12 17:54:51 +00:00
Alexey Milovidov
5bb1db0fa8
Allow loading dicrionaries and functions from YAML by default
2023-05-12 05:19:01 +02:00
serxa
529a702391
fix LocalServer fast-tests
2023-05-11 13:23:53 +00:00
Sema Checherinda
8470aa8fbb
Merge branch 'master' into convertations_to_timespan
2023-05-11 08:24:40 +02:00
serxa
6bbc061ba0
start loader, fix helpers, fix deadlock
2023-05-10 19:56:48 +00:00
Sema Checherinda
f2ad1122a1
fix convertation
2023-05-10 17:50:42 +00:00
Andrey Zvonov
9237b904be
Merge branch 'master' into zvonand-implicit-tz
2023-05-10 01:25:33 +02:00
Nikolay Degterinsky
7886353ed0
Merge pull request #49696 from evillique/ubsan-fuzzer
...
Fix member call on null pointer in fuzzer
2023-05-10 00:03:50 +02:00
Nikolay Degterinsky
b7d8c99fbe
Fix member call on null pointer in fuzzer
2023-05-09 13:12:11 +00:00
Sergei Trifonov
b479637e2c
Merge branch 'master' into async-loader-integration
2023-05-09 13:04:36 +02:00
Alexey Milovidov
a8bdb20fc4
Merge pull request #48787 from ClickHouse/background-memory-tracker
...
Add MemoryTracker for the background tasks [Resubmit]
2023-05-09 07:58:36 +03:00
Kseniia Sumarokova
bfe9537012
Merge pull request #49426 from kssenii/remove-dependency-from-context
...
Remove dependency from DB::Context in remote/cache readers
2023-05-08 23:25:12 +02:00
Kseniia Sumarokova
336bb41c5d
Merge branch 'master' into remove-dependency-from-context
2023-05-08 12:46:10 +02:00
Alexander Tokmakov
abf6c60ad2
Merge branch 'master' into fix_dictionaries_loading_order
2023-05-08 00:31:03 +02:00
Alexey Milovidov
cfb35cb251
Fix typo: "as much slots" -> "as many slots"
2023-05-07 04:42:46 +02:00
Alexey Milovidov
d3c3d8b8e4
Remove export of dynamic symbols
2023-05-06 23:52:16 +02:00
Alexey Milovidov
5e2221bc5d
Update play.html
2023-05-05 21:36:10 +03:00
zvonand
8338d54c34
Merge branch 'master' of github.com:ClickHouse/ClickHouse into zvonand-implicit-tz
2023-05-05 15:50:26 +02:00
Alexander Tokmakov
6cf3e5b77a
fix race on loading dictionaries
2023-05-05 15:25:18 +02:00
Alexey Milovidov
5cf3863e7e
Update play.html
2023-05-05 03:37:13 +03:00
Mike Kot
291bcc0e54
allow passing password in URL
2023-05-04 12:49:59 +00:00
kssenii
1433f5ffc9
Merge remote-tracking branch 'upstream/master' into remove-dependency-from-context
2023-05-04 13:24:02 +02:00
johanngan
731823b873
Add support for SSE-KMS configuration with S3
...
https://docs.aws.amazon.com/AmazonS3/latest/userguide/UsingKMSEncryption.html
Similar to the server_side_encryption_customer_key_base64 option for
configuring SSE-C with S3, add the following settings to configure
SSE-KMS on a per-endpoint/disk basis:
- server_side_encryption_kms_key_id
- server_side_encryption_kms_encryption_context
- server_side_encryption_kms_bucket_key_enabled
2023-05-03 21:35:38 -05:00
johanngan
1bc52977a7
Support "header" setting in S3 disk config
...
The S3 table engine supports specifying extra HTTP headers in S3
requests to certain endpoints, via the "headers" setting. This commit
adds the same setting to S3 disk config.
2023-05-03 21:32:58 -05:00
Konstantin Bogdanov
9d2a27cb7b
Invert shutdown_wait_unfinished_queries ( #49427 )
...
Co-authored-by: Nikita Mikhaylov <mikhaylovnikitka@gmail.com>
2023-05-03 19:04:48 +02:00
Nikita Mikhaylov
954e3b724c
Speedup outdated parts loading ( #49317 )
2023-05-03 18:56:45 +02:00
alekseygolub
58cb6c7837
S3, HDFS only for explicit creation
2023-05-02 19:57:36 +00:00
kssenii
ecfbf1e304
Remove dependency from DB::Context in readers
2023-05-02 21:45:27 +02:00
serxa
6eda6e8585
implement async loading interface in database engines
2023-05-02 09:18:50 +00:00
alekseygolub
95522ad7a6
Added DatabaseHDFS
2023-05-01 21:46:17 +00:00
serxa
85d66984b2
cleanup
2023-05-01 12:50:07 +00:00
Sergei Trifonov
8dab49f328
Merge branch 'master' into async-loader-integration
2023-05-01 14:04:39 +02:00
serxa
abaf73268b
integrate with Server and TablesLoader
2023-05-01 11:56:00 +00:00
Aleksei Golub
1846b76982
Added DatabaseS3 with test
2023-05-01 11:46:55 +03:00
Nikolay Degterinsky
f64ef88197
Merge remote-tracking branch 'upstream/master' into bcrypt
2023-04-30 21:39:16 +00:00
Nikolay Degterinsky
54c8f63a33
Fixes
2023-04-28 15:12:06 +00:00
Aleksei Golub
e20f92ce0f
Fixed exceptions handling; Fixed style;
2023-04-27 21:26:36 +03:00
Nikolay Degterinsky
df1e56b985
Merge remote-tracking branch 'upstream/master' into bcrypt
2023-04-27 17:01:58 +00:00
kssenii
641b64c4e8
Merge remote-tracking branch 'upstream/master' into cache-better-locks
2023-04-27 13:31:41 +02:00
kssenii
3d4413183f
Merge remote-tracking branch 'upstream/master' into cache-better-locks
2023-04-27 13:16:36 +02:00
pufit
d235fdd572
Produce help message
2023-04-26 20:39:33 -04:00
pufit
9204e2e3de
Better completion
2023-04-26 20:11:45 -04:00
pufit
2426c445b0
Improve set
command
2023-04-26 20:10:32 -04:00
serxa
86122409e2
more work
2023-04-26 18:27:23 +00:00
Nikolay Degterinsky
a8d124ac0f
Merge branch 'master' into add_default_password_type
2023-04-26 12:53:23 +02:00
alekseygolub
dfddc25389
Merge branch 'ClickHouse:master' into localfilefunction
2023-04-26 10:41:50 +03:00
pufit
a20f8e74a0
Fix cd
command. Style consistency
2023-04-26 01:05:51 -04:00
pufit
8bef8fc1de
Parsing Keeper commands via ClickHouse Parser
2023-04-26 00:54:28 -04:00
刘浩林
4eb83a9421
fix: add slash for close tag
2023-04-26 09:43:46 +08:00
Anton Popov
125e5c50b8
allow to flush async insert queue
2023-04-25 21:30:03 +00:00
kssenii
cbf0b98102
Merge remote-tracking branch 'upstream/master' into cache-better-locks
2023-04-25 15:15:22 +02:00
Nikolay Degterinsky
2fe3a69ba1
Merge remote-tracking branch 'upstream/master' into add_default_password_type
2023-04-24 18:51:32 +00:00
Robert Schulze
ded8eca041
Merge pull request #48284 from ClickHouse/rs/qc-quota
...
Query Cache: Allow per-user quotas
2023-04-24 11:32:32 +02:00
Robert Schulze
7fe0562de5
Make the cfg parameter naming more consistent
2023-04-23 14:00:22 +00:00
Alexey Milovidov
3621a4d7ac
Merge branch 'master' into fix-ibm
2023-04-23 14:26:15 +02:00
Alexey Milovidov
5ca15fcdff
Merge pull request #49036 from Kinzeng/dashboard-fixes
...
tweak styling, show charts on initial load if credentials are correct
2023-04-23 09:07:16 +03:00
kssenii
1fbaaf0445
Merge remote-tracking branch 'upstream/master' into cache-better-locks
2023-04-22 17:14:50 +02:00
Nikolay Degterinsky
b599d0bd01
Better
2023-04-21 22:03:56 +00:00
Kevin Zhang
edefde83f4
tweak styling, show charts on initial load if credentials are correct
2023-04-21 16:06:12 -04:00
Alexey Milovidov
252c755323
Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-ibm
2023-04-21 12:39:13 +02:00
Alexey Milovidov
530b764953
Fix IBM
2023-04-21 12:38:45 +02:00
Kruglov Pavel
9749448eb0
Merge pull request #47229 from Avogar/non-blocking-connect
...
Improve async reading from socket
2023-04-21 10:38:50 +02:00
Alexey Milovidov
98ae9be734
Revert "Added tests for ClickHouse apps help and fixed help issues"
2023-04-21 01:54:34 +03:00
Andrey Zvonov
984e8fde41
Merge branch 'master' into zvonand-implicit-tz
2023-04-20 23:13:17 +02:00
zvonand
e37745811c
style
2023-04-20 12:04:12 +02:00
zvonand
f4af76ab8b
cleanup cmakelists
2023-04-20 11:58:51 +02:00
zvonand
daae5025e8
small updates due to review
2023-04-19 14:45:51 +02:00
Kruglov Pavel
2ad161d2b7
Merge branch 'master' into non-blocking-connect
2023-04-19 13:39:40 +02:00
Kruglov Pavel
58b973fa91
Update programs/copier/ClusterCopier.cpp
...
Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
2023-04-19 13:30:46 +02:00
zvonand
542c09cb51
fix keeper standalone linking
2023-04-19 01:35:49 +02:00
zvonand
1e8c0a2db9
Lighter timezone validation
...
Reused external variable from src/Storages/System/StorageSystemTimeZones.generated.cpp
Required changes to CMakeLists of some standalone modules to link
properly
2023-04-19 00:06:15 +02:00
Ilya Yatsishin
ebb1b990f2
Merge pull request #45819 from qoega/clickhouse-help
2023-04-18 21:46:36 +02:00
kssenii
1322ad53b8
Merge remote-tracking branch 'upstream/master' into cache-better-locks
2023-04-17 18:22:21 +02:00
Aleksei Golub
267bbcab00
Added ability to implicitly use file table function in clickhouse-local
2023-04-16 15:48:55 +03:00
Dmitry Novik
cf5d9a175a
Revert "Merge pull request #48760 from ClickHouse/revert-46089-background-memory-tracker"
...
This reverts commit a61ed33223
, reversing
changes made to 5f01b8a2b5
.
2023-04-14 16:34:19 +02:00
zvonand
089306820f
Merge branch 'master' of github.com:ClickHouse/ClickHouse into zvonand-implicit-tz
2023-04-14 13:21:49 +02:00
Yatsishin Ilya
206781cc4e
Fix abort on small terminal window
2023-04-14 08:26:58 +00:00
kssenii
599a02ca0d
Fix
2023-04-13 18:53:16 +02:00
Robert Schulze
7a21d5888c
Remove -Wshadow suppression which leaked into global namespace
2023-04-13 08:46:40 +00:00
zvonand
daef5d818a
fix according to updates in ThreadStatus.h
2023-04-12 15:31:58 +02:00
zvonand
2a9f28b73b
resolve
2023-04-12 12:54:39 +02:00
zvonand
a9499eed79
moved getting server TZ DateLUT to separate place, upd tests and fix
2023-04-12 12:47:05 +02:00
Nikolay Degterinsky
7606336fd8
Merge remote-tracking branch 'upstream/master' into add_default_password_type
2023-04-11 11:59:45 +00:00
Yatsishin Ilya
b5b65d2149
Merge remote-tracking branch 'origin' into clickhouse-help
2023-04-11 11:24:48 +00:00
Vasily Nemkov
e36addb96a
Hackish way of setting up timezone on the client
...
Warning: lots of debug logging
2023-04-11 13:03:03 +02:00
Nikolay Degterinsky
7957752128
Merge remote-tracking branch 'upstream/master' into add_default_password_type
2023-04-10 02:25:46 +00:00
Nikolay Degterinsky
64dc60a8d1
Better version, introduce ASTAuthenticationData
2023-04-10 02:20:57 +00:00
Alexey Milovidov
345b33dc1f
Slightly optimize Install
2023-04-10 04:15:13 +02:00
Alexey Milovidov
09ea79aaf7
Add support for {server_uuid} macro
2023-04-09 03:04:26 +02:00
Nikolay Degterinsky
715ef4da6e
Merge pull request #48440 from evillique/user-password-precedence
...
Override user and password environment variables with client parameters
2023-04-07 12:19:56 +02:00
Nikolay Degterinsky
3b9e8a8630
Override user and password environment variables with client parameters
2023-04-05 19:40:43 +00:00
Antonio Andelic
f5e97fbb66
Merge branch 'master' into alternative-keeper-configs
2023-04-03 15:06:52 +00:00
pufit
892e436046
Move host and port to options
2023-04-02 16:51:10 -04:00
Azat Khuzhin
c64f9e6f07
Use StrongTypedef for ProfileEvents
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-01 16:01:33 +02:00
Azat Khuzhin
8d0e516310
Use StrongTypedef for CurrentMetrics to avoid possible incorrect usage
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-01 16:01:33 +02:00
pufit
3380e467d9
fix typo
2023-03-31 12:41:22 +00:00
pufit
ef9f66e36f
style fix
2023-03-31 12:41:22 +00:00
pufit
7dc6ff02c3
use keeper-client in integration tests
2023-03-31 12:41:22 +00:00
pufit
bfdc2b58b4
style fix
2023-03-31 12:41:22 +00:00
pufit
7adc442fed
support run in non-interactive mode
2023-03-31 12:41:22 +00:00
pufit
752eab501c
default host to connect
2023-03-31 12:41:22 +00:00
pufit
18fada7028
fix duplication
2023-03-31 12:41:22 +00:00
pufit
72769d468e
comment fix
2023-03-31 12:41:22 +00:00
pufit
dfea87d248
Added confirmation for rmr operation.
...
Implemented support for four-letter-word commands.
2023-03-31 12:41:22 +00:00
pufit
9051ddb174
Style fix
2023-03-31 12:41:22 +00:00
pufit
c93202cca4
Keeper Client MVP
2023-03-31 12:41:22 +00:00
filimonov
fbb22348ea
Refactor reading the pool setting & from server config. ( #48055 )
...
After #36425 there was a lot of confusions/problems with configuring pools - when the message was confusing, and settings need to be ajusted in several places.
See some examples in #44251 , #43351 , #47900 , #46515 .
The commit includes the following changes:
1) Introduced a unified mechanism for reading pool sizes from the configuration file(s). Previously, pool sizes were read from the Context.cpp with fallbacks to profiles, whereas main_config_reloader in Server.cpp read them directly without fallbacks.
2) Corrected the data type for background_merges_mutations_concurrency_ratio. It should be float instead of int.
3) Refactored the default values for settings. Previously, they were defined in multiple places throughout the codebase, but they are now defined in one place (or two, to be exact: Settings.h and ServerSettings.h).
4) Improved documentation, including the correct message in system.settings.
Additionally make the code more conform with #46550 .
2023-03-30 16:44:11 +02:00
Alexey Milovidov
e982fb9f1c
Merge pull request #47880 from azat/threadpool-introspection
...
ThreadPool metrics introspection
2023-03-30 01:27:31 +03:00
Antonio Andelic
3163e777dc
Merge pull request #48108 from ClickHouse/fix-keeper-timeouts
...
Correctly set TCP/HTTP socket timeouts in Keeper
2023-03-29 15:28:09 +02:00
Azat Khuzhin
f38a7aeabe
ThreadPool metrics introspection
...
There are lots of thread pools and simple local-vs-global is not enough
already, it is good to know which one in particular uses threads.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-29 10:46:59 +02:00
Antonio Andelic
32cfc983b5
Fix clang-tidy build
2023-03-29 07:38:37 +00:00
Yatsishin Ilya
26aacd3d2d
Merge remote-tracking branch 'origin/master' into clickhouse-help
2023-03-28 16:57:58 +00:00
Antonio Andelic
3b73f94eb8
Correctly set socket timeouts
2023-03-28 12:18:13 +00:00
Mikhail f. Shiryaev
652bf04e8a
Merge remote-tracking branch 'origin/master' into obfuscator-readme
2023-03-28 10:56:16 +02:00
Antonio Andelic
4aa8c5fe49
Merge branch 'master' into alternative-keeper-configs
2023-03-28 07:23:24 +00:00
Alexey Milovidov
c7c9d8a92a
Update README.md
2023-03-28 01:05:10 +03:00
Kruglov Pavel
bc92e3184e
Merge branch 'master' into non-blocking-connect
2023-03-27 13:50:50 +02:00
Nikolay Degterinsky
a71454f8ec
Fix automatic indentation in the built-in UI SQL editor
2023-03-27 12:53:31 +02:00
Antonio Andelic
93f5920e02
Merge branch 'master' into alternative-keeper-configs
2023-03-27 10:00:21 +02:00
Robert Schulze
0712627c05
Query cache: Fix config naming ambiguity
...
Add 'max_' prefix to 'size' setting to make it more clear that the cache
consumes no space if not used.
2023-03-24 12:52:09 +00:00
Kruglov Pavel
3ee12e21fb
Merge branch 'master' into non-blocking-connect
2023-03-23 20:53:44 +01:00
Antonio Andelic
d6cbc5d05b
Fix tests
2023-03-23 15:01:51 +00:00
Nikolay Degterinsky
fac45f1955
Merge pull request #47887 from evillique/new-install-options
...
Add options `--link` and `-y` to clickhouse install
2023-03-23 15:34:39 +01:00
Vitaly Baranov
f49cab91c0
Merge pull request #47002 from ilejn/orphaned_role
...
Tests for orphaned role fix
2023-03-23 14:09:34 +01:00
Antonio Andelic
a4d1cd514d
Refactor
2023-03-23 08:58:56 +00:00
Yatsishin Ilya
5786aba5eb
Merge remote-tracking branch 'origin/master' into clickhouse-help
2023-03-22 14:08:22 +00:00
Nikolay Degterinsky
8851b2b8f6
Add options --link and -y to clickhouse install
2023-03-22 12:53:22 +00:00
Antonio Andelic
65b99ec6a7
Merge branch 'master' into alternative-keeper-configs
2023-03-22 12:22:57 +00:00
avogar
a8ea305a5a
Fix build
2023-03-21 17:25:37 +00:00
Ilya Golshtein
5091b4e224
orphaned role - expiration_time => expiration_time_seconds
2023-03-21 08:44:08 +01:00
Ilya Golshtein
e1d1ead941
orphaned role - tests only
2023-03-20 23:21:25 +01:00
Robert Schulze
3b7f929001
Merge branch 'master' into rs/qc-cachebase
2023-03-20 17:08:47 +01:00
Vitaly Baranov
198409e12a
Merge pull request #46085 from aalexfvk/alexfvk/store_udf_in_zookeeper
...
Replication of user-defined SQL functions using ZooKeeper
2023-03-20 13:41:29 +01:00
Alexey Milovidov
e805d75756
ClickHouse Obfuscator: add README
2023-03-20 07:10:47 +01:00
Robert Schulze
c4664c70a1
Merge branch 'master' into rs/qc-cachebase
2023-03-19 15:23:24 +01:00
Alexey Milovidov
7bcf2c6ff4
Merge branch 'master' of github.com:ClickHouse/ClickHouse into concurrency
2023-03-17 21:35:11 +01:00
Robert Schulze
23281c7348
Merge pull request #47669 from ClickHouse/rs/more-gold-removal
...
Follow-up to #47660 : Further removal of gold linker support
2023-03-17 14:58:23 +01:00
Robert Schulze
f8980c582e
CMake: More removal of gold linker (follow-up to #47660 )
...
+ fix a linker warning
2023-03-17 11:01:46 +00:00
Aleksei Filatov
f84aa2f4ca
Add classes for replication UDF to ZooKeeper
2023-03-17 13:56:04 +03:00
Alexey Milovidov
69ae1bd060
Merge remote-tracking branch 'origin/master' into concurrency
2023-03-17 00:57:03 +01:00
Kruglov Pavel
a3510a2ffe
Merge pull request #47271 from Avogar/codecs-better
...
Add optional parameters to some codecs, fix aborts in clickhouse-compressor with some codecs.
2023-03-16 12:20:23 +01:00
Robert Schulze
7d7052350c
Merge branch 'master' into rs/qc-cachebase
2023-03-16 10:42:17 +01:00
robot-ch-test-poll3
9d14c14a54
Merge pull request #47573 from azat/odbc-fix
...
Change error code in case of columns definitions was empty in ODBC
2023-03-15 12:31:54 +01:00
Robert Schulze
75ca2dd0e2
Merge remote-tracking branch 'origin/master' into rs/qc-cachebase
2023-03-15 10:55:53 +00:00
Yatsishin Ilya
45c5275bfb
Merge remote-tracking branch 'origin/master' into clickhouse-help
2023-03-14 17:27:25 +00:00
Azat Khuzhin
a72647690d
Change error code in case of columns definitions was empty in ODBC
...
CI reports [1]:
2023.03.14 00:29:07.031349 [ 166170 ] {110f8654-7d7d-4b47-b6b0-3ce83414a80f} <Error> ReadWriteBufferFromHTTP: HTTP request to `http://127.0.0.1:9018/columns_info?use_connection_pooling=1&version=1&connection_string=DSN%3D%7BClickHouse%20DSN%20%28ANSI%29%7D&schema=test_15&table=t&external_table_functions_use_nulls=1 ` failed at try 1/1 with bytes read: 0/unknown. Error: DB::HTTPException: Received error from remote server /columns_info?use_connection_pooling=1&version=1&connection_string=DSN%3D%7BClickHouse%20DSN%20%28ANSI%29%7D&schema=test_15&table=t&external_table_functions_use_nulls=1. HTTP status code: 500 Internal Server Error, body: Error getting columns from ODBC 'Code: 49. DB::Exception: Columns definition was not returned. (LOGICAL_ERROR) (version 23.2.4.12 (official build))'
[1]: https://s3.amazonaws.com/clickhouse-test-reports/47541/3d247b8635da44bccfdeb5fcd53be7130b8d0a32/upgrade_check__msan_.html
Here the problem is that system.columns has cached value for number of
total table to iterate, and so it can skip something.
But anyway, this should be LOGICAL_ERROR, since ODBC bridge does two
queries:
- to system.tables and
- to system.columns
And if between this two queries the table will be removed, them there
will be no columns
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-14 14:24:11 +01:00
Robert Schulze
657aa65446
Cleanup: Untangle CacheBase's constructors
...
This prepares for the custom TTLCachePolicy which users should not be
able to configure explicitly.
2023-03-13 15:11:12 +00:00
Alexander Tokmakov
7b1b238d0b
Revert "Merge pull request #25674 from amosbird/distributedreturnconnection"
...
This reverts commit 5ffd99dfd4
, reversing
changes made to 2796aa333f
.
2023-03-11 19:09:47 +01:00
Alexander Tokmakov
bd124a24ea
Revert "Merge pull request #31965 from azat/connection-drain-pull"
...
This reverts commit 6cb54b4092
, reversing
changes made to 42d938ffa0
.
2023-03-11 17:24:38 +01:00
Clayton McClure
b0931c8967
Update copier to use group by to find partitions ( #47386 )
2023-03-09 15:49:00 +01:00
Yatsishin Ilya
6cde37093a
Merge remote-tracking branch 'origin/master' into clickhouse-help
2023-03-08 13:34:18 +00:00
Mike Kot
9920a52c51
use std::lerp, constexpr hex.h
2023-03-07 22:50:17 +00:00
Kruglov Pavel
5e1eec48fe
Merge branch 'master' into codecs-better
2023-03-07 12:51:46 +01:00
avogar
b5f19ee12c
Make better
2023-03-06 19:34:36 +00:00
avogar
8847561fc2
Add optional parameters to some codecs, fix aborts in clickhouse-compressor with some codecs
2023-03-06 16:49:28 +00:00
Antonio Andelic
c38d820d0f
Add 4LW for cleaning resource
2023-03-05 16:57:18 +00:00
Alexey Milovidov
62c37b3e37
Merge branch 'master' into concurrency
2023-03-04 09:15:59 +01:00
Nikita Mikhaylov
5c4da5aa4a
Use separate thread pool for IO operations for backups ( #47174 )
2023-03-03 20:05:42 +01:00
Robert Schulze
851b256a9c
Merge pull request #47136 from phil-88/patch-1
...
External dictionaries / library-bridge: Fix error "unknown library method 'extDict_libClone'"
2023-03-03 11:07:37 +01:00
Nikolay Degterinsky
d6798e412a
Merge pull request #47113 from alexkorep/feature/editor-tabs-on-enter
...
Automatic indentation in the built-in UI SQL editor
2023-03-02 22:39:31 +01:00
Alexey Milovidov
9c01c6cc25
Add Cloud
2023-03-02 22:30:52 +01:00
Yatsishin Ilya
d4304d2028
Merge remote-tracking branch 'origin/master' into clickhouse-help
2023-03-02 16:16:18 +00:00
alex filatov
bafd9773bc
fix Unknown library method 'extDict_libClone'
...
We have an issue when using external dictionary. Occasionally library bridge called with extDict_libClone and fails with Unknown library method 'extDict_libClone'. And it looks like it is because of at some point `else if (method == "extDict_libNew")` was changed to if (lib_new) with no handling for extDict_libClone inside this new if else statement and reporing an error that extDict_libClone is an unknown method.
So there is a two-line fix to handle extDict_libClone properly.
Error logs that we have:
```
2022.12.16 14:17:44.285088 [ 393573 ] {} <Error> ExternalDictionaries: Could not update cache dictionary 'dict.vhash_s', next update is scheduled at 2022-12-16 14:18:00: Code: 86. DB::Exception: Received error from remote server /extdict_request?version=1&dictionary_id=be2b2cd1-ba57-4658-8d1b-35ef40ab005b&method=extDict_libClone&from_dictionary_id=c3537142-eaa9-4deb-9b65-47eb8ea1dee6. HTTP status code: 500 Internal Server Error, body: Unknown library method 'extDict_libClone'
2022.12.16 14:17:44.387049 [ 399133 ] {} <Error> ExternalDictionaries: Could not update cache dictionary 'dict.vhash_s', next update is scheduled at 2022-12-16 14:17:51: Code: 86. DB::Exception: Received error from remote server /extdict_request?version=1&dictionary_id=0df866ac-6c94-4974-a76c-3940522091b9&method=extDict_libClone&from_dictionary_id=c3537142-eaa9-4deb-9b65-47eb8ea1dee6. HTTP status code: 500 Internal Server Error, body: Unknown library method 'extDict_libClone'
2022.12.16 14:17:44.488468 [ 397769 ] {} <Error> ExternalDictionaries: Could not update cache dictionary 'dict.vhash_s', next update is scheduled at 2022-12-16 14:19:38: Code: 86. DB::Exception: Received error from remote server /extdict_request?version=1&dictionary_id=2d8af321-b669-4526-982b-42c0fabf0e8d&method=extDict_libClone&from_dictionary_id=c3537142-eaa9-4deb-9b65-47eb8ea1dee6. HTTP status code: 500 Internal Server Error, body: Unknown library method 'extDict_libClone'
2022.12.16 14:17:44.489935 [ 398226 ] {datamarts_v_dwh_node0032-241534:0x552da2_1_11} <Error> executeQuery: Code: 510. DB::Exception: Update failed for dictionary 'dict.vhash_s': Code: 510. DB::Exception: Update failed for dictionary dict.vhash_s : Code: 86. DB::Exception: Received error from remote server /extdict_request?version=1&dictionary_id=be2b2cd1-ba57-4658-8d1b-35ef40ab005b&method=extDict_libClone&from_dictionary_id=c3537142-eaa9-4deb-9b65-47eb8ea1dee6. HTTP status code: 500 Internal Server Error, body: Unknown library method 'extDict_libClone'
```
2023-03-02 15:53:09 +03:00
Alexey Korepanov
169398ec07
Add check for empty leading spaces
2023-03-01 21:57:51 +01:00
Alexey Korepanov
67b271b1fa
Keep indentation on Enter in the web UI
2023-03-01 12:20:49 +01:00
pufit
29296cb004
Merge pull request #46550 from ClickHouse/46231-systerm-server-settings
...
Implement `system.server_settings`
2023-02-28 11:23:15 -05:00
bkuschel
77607ba0d4
Fix setenv string call
2023-02-27 08:01:15 -05:00
Alexey Milovidov
8ad8e32f23
Tune the concurrency settings
2023-02-27 05:26:38 +01:00
Alexey Milovidov
83c41755ed
Remove unused header
2023-02-25 03:21:14 +01:00
Alexey Milovidov
4134e56ef0
Increase the limit for opened files in clickhouse-local
2023-02-25 03:20:47 +01:00
pufit
1157bf2d9f
Removed unnecessary ifs
2023-02-22 15:15:09 -05:00
Nikolay Degterinsky
af992ca2db
Better
2023-02-22 16:51:36 +01:00
Nikolay Degterinsky
cdbff57e6c
Ask for password interactively
2023-02-22 15:58:06 +01:00
Antonio Andelic
7f5fb77ed5
Increase table retries in cluster copier tests ( #46590 )
2023-02-22 15:09:48 +01:00
Yatsishin Ilya
80857638c1
Merge remote-tracking branch 'origin/master' into clickhouse-help
2023-02-22 13:58:17 +00:00
Kruglov Pavel
3ba3fdbfa3
Merge pull request #46607 from kssenii/delay-loading-of-named-collections
...
Do not load named collections on server startup (on first access instead)
2023-02-22 13:22:34 +01:00
Kevin Zhang
d9cff3a5e8
fix layout issues in dashboard.html
2023-02-21 13:52:28 -05:00
Kseniia Sumarokova
24d0490ef3
Merge branch 'master' into delay-loading-of-named-collections
2023-02-21 00:24:18 +01:00
kssenii
9d16205c8a
Load named collections on first access
2023-02-20 16:33:45 +01:00
pufit
ff4e23aca8
Update programs/server/Server.cpp
...
Co-authored-by: Sergei Trifonov <sergei@clickhouse.com>
2023-02-19 16:48:55 -05:00
Alexey Milovidov
f073cd470f
Merge pull request #46478 from ClickHouse/fix_test_store_cleanup
...
Fix some flaky integration tests
2023-02-18 17:33:02 +03:00
pufit
4496db66b2
Implement system.server_settings
2023-02-17 23:46:09 -05:00
Alexander Tokmakov
3457b68dcc
fix
2023-02-17 17:57:49 +01:00
Alexey Milovidov
ecf893ea0d
Merge pull request #46518 from mdelapenya/tc-go-0.18.0
...
chore: bump testcontainers-go to 0.18.0
2023-02-17 18:23:23 +03:00
Alexander Tokmakov
fb3574d2cf
Merge branch 'master' into fix_test_store_cleanup
2023-02-17 13:59:22 +01:00
Kseniia Sumarokova
094a03b4c8
Merge pull request #46480 from azat/client-connections
...
Allow to override host for client connection credentials
2023-02-17 13:40:39 +01:00
Manuel de la Peña
79781aa024
chore: bump testcontainers-go to 0.18.0
2023-02-17 11:03:26 +01:00
Alexander Tokmakov
9feb448a5e
fix a race condition
2023-02-16 14:41:18 +01:00
Azat Khuzhin
2dbcfdbe15
Allow to override host for client connection credentials
...
Introduce new `--connection` option, by default as a connection name
`--host` will be used.
And using --connection you also can specify --host and it will be
overwritten.
Follow-up for: #45715
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-16 14:26:24 +01:00
alesapin
d08b2753e4
Merge pull request #46367 from ClickHouse/reduce-keeper-build-time
...
Do not build libclickhouse-keeper-lib.a for standalone keeper
2023-02-16 13:56:27 +01:00
robot-clickhouse-ci-1
2fbed70029
Merge pull request #46433 from ClickHouse/fix-cluster-copier
...
Another fix for cluster copier
2023-02-16 09:40:51 +01:00
Sergei Trifonov
3ad41b29ec
Merge pull request #46247 from ClickHouse/round-robin-merge-scheduler
2023-02-16 08:03:22 +01:00
Kevin Zhang
c8d7b72e5d
move database credential inputs to the center on initial load
2023-02-15 15:09:36 -05:00
Antonio Andelic
8cdafcc2d0
Correctly check if there were failures
2023-02-15 11:45:57 +00:00
Mikhail f. Shiryaev
08ffb8f93d
Install only "programs" directory during build
2023-02-15 11:49:19 +01:00
Nikolay Degterinsky
3075656e1d
Merge remote-tracking branch 'upstream/master' into HEAD
2023-02-15 10:06:44 +00:00
Sergei Trifonov
b7a4fa8bd9
Merge branch 'master' into round-robin-merge-scheduler
2023-02-14 20:39:02 +01:00
Antonio Andelic
8d16fe5793
Merge branch 'master' into add-support-for-settings-alias
2023-02-13 08:46:00 +01:00
serxa
c58b165b0f
add config option to select scheduling policy
2023-02-11 16:18:42 +00:00
Antonio Andelic
f96d480563
Merge branch 'master' into add-support-for-settings-alias
2023-02-09 16:07:45 +01:00
Robert Schulze
e490ec91d9
Merge branch 'master' into rs/fix-fragile-linking
2023-02-09 11:33:59 +01:00
Alexey Milovidov
d9fbf643bc
Merge pull request #45226 from hanfei1991/hanfei/gwp-asan
...
Introduce llvm/gwp-asan
2023-02-09 09:24:52 +03:00
Yatsishin Ilya
c5103ae469
Merge remote-tracking branch 'origin/master' into clickhouse-help
2023-02-08 14:09:34 +00:00
Yatsishin Ilya
200e50b8e1
more changes in apps help
2023-02-08 12:55:56 +00:00
Alexander Gololobov
a7c30eecf4
Merge pull request #46141 from ClickHouse/fix-assertion-in-statistics
...
Fix assertion in statistical functions
2023-02-08 13:42:02 +01:00
Robert Schulze
6ff232d782
Merge branch 'master' into rs/fix-fragile-linking
2023-02-08 12:51:12 +01:00
Alexey Milovidov
55c3bbb739
Fix assertion in statistical functions
2023-02-08 00:09:41 +01:00
Azat Khuzhin
ff324fe81a
Fix fault injection in copier (wrong query syntax)
...
There are very frequent flakiness of `test_cluster_copier` test, here is
an example of copier failures on CI [1]:
AssertionError: Instance: s0_1_0 (172.16.29.9). Info: {'ID': '5d68dcb46fdb4b0c54b7c7ba1ddde83b8f34d483bbb32abcb0c52b966444ce82', 'Running': False, 'ExitCode': 85, 'ProcessConfig': {'tty': False, 'entrypoint': '/usr/bin/clickhouse', 'arguments': ['copier', '--config', '/etc/clickhouse-server/config-copier.xml', '--task-path', '/clickhouse-copier/task_simple_4DFWYTDD49', '--task-file', '/task0_description.xml', '--task-upload-force', 'true', '--base-dir', '/var/log/clickhouse-server/copier', '--copy-fault-probability', '0.2', '--experimental-use-sample-offset', '1'], 'privileged': False, 'user': '0'}, 'OpenStdin': False, 'OpenStderr': True, 'OpenStdout': True, 'CanRemove': False, 'ContainerID': 'f356df6694b3cc09ee9830c623681626f8e8d999677c188b9fe911aa702784ca', 'DetachKeys': '', 'Pid': 84332}
assert 85 == 0
But let's look what the error it is, apparently it is UNFINISHED:
SELECT
name,
code
FROM system.errors
WHERE ((code % 256) = 85) AND (NOT remote)
SETTINGS system_events_show_zero_values = 1
┌─name─────────────────────────────┬─code─┐
│ FORMAT_IS_NOT_SUITABLE_FOR_INPUT │ 85 │
│ UNFINISHED │ 341 │
│ NO_SUCH_ERROR_CODE │ 597 │
└──────────────────────────────────┴──────┘
Let's verify:
$ grep -r UNFINISHED ./test_cluster_copier/_instances_0/s0_1_0/logs/copier/clickhouse-copier_*
./test_cluster_copier/_instances_0/s0_1_0/logs/copier/clickhouse-copier_20230206220846_368/log.log:2023.02.06 22:09:19.015251 [ 368 ] {} <Error> : virtual int DB::ClusterCopierApp::main(const std::vector<std::string> &): Code: 341. DB::Exception: Too many tries to process table cluster1.default.hits. Abort remaining execution. (UNFINISHED), Stack trace (when copying this message, always include the lines below):
And apparently that it is due to query error with fault injection:
2023.02.06 22:09:15.654724 [ 368 ] {} <Error> Application: An error occurred while processing partition 0: Code: 62. DB::Exception: Syntax error (Query): failed at position 168 ('Native'): Native. Expected one of: token, Dot, OR, AND, BETWEEN, NOT BETWEEN, LIKE, ILIKE, NOT LIKE, NOT ILIKE, IN, NOT IN, GLOBAL IN, GLOBAL NOT IN, MOD, DIV, IS NULL, IS NOT NULL, alias, AS, Comma, OFFSET, WITH TIES, BY, LIMIT, SETTINGS, UNION, EXCEPT, INTERSECT, INTO OUTFILE, FORMAT, end of query. (SYNTAX_ERROR), Stack trace (when copying this message, always include the lines below):
Example:
select x from x limit 1FORMAT Native
Syntax error: failed at position 32 ('Native'):
So fixing this should fix test_cluster_copier flakiness.
[1]: https://s3.amazonaws.com/clickhouse-test-reports/46045/bd4170e03c6af583a51d12d2c39fa775dcb9997b/integration_tests__release__[4/4].html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 17:01:06 +01:00
Azat Khuzhin
18d2a99761
Use comments for variables that clang can parse
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 16:53:45 +01:00
Yatsishin Ilya
1baa15d603
Merge remote-tracking branch 'origin/master' into clickhouse-help
2023-02-07 15:46:59 +00:00
Han Fei
0f7defb87f
Merge branch 'master' into hanfei/gwp-asan
2023-02-07 14:55:55 +01:00
Robert Schulze
08c1f8346e
Merge remote-tracking branch 'origin/master' into rs/fix-fragile-linking
2023-02-07 11:22:00 +00:00
Robert Schulze
84b9ff450f
Fix terribly broken, fragile and potentially cyclic linking
...
Sorry for the clickbaity title. This is about static method
ConnectionTimeouts::getHTTPTimeouts(). It was be declared in header
IO/ConnectionTimeouts.h, and defined in header
IO/ConnectionTimeoutsContext.h (!). This is weird and caused issues with
linking on s390x (##45520). There was an attempt to fix some
inconsistencies (#45848 ) but neither did @Algunenano nor me at first
really understand why the definition is in the header.
Turns out that ConnectionTimeoutsContext.h is only #include'd from
source files which are part of the normal server build BUT NOT part of
the keeper standalone build (which must be enabled via CMake
-DBUILD_STANDALONE_KEEPER=1). This dependency was not documented and as
a result, some misguided workarounds were introduced earlier, e.g.
0341c6c54b
The deeper cause was that getHTTPTimeouts() is passed a "Context". This
class is part of the "dbms" libary which is deliberately not linked by
the standalone build of clickhouse-keeper. The context is only used to
read the settings and the "Settings" class is part of the
clickhouse_common library which is linked by clickhouse-keeper already.
To resolve this mess, this PR
- creates source file IO/ConnectionTimeouts.cpp and moves all
ConnectionTimeouts definitions into it, including getHTTPTimeouts().
- breaks the wrong dependency by passing "Settings" instead of "Context"
into getHTTPTimeouts().
- resolves the previous hacks
2023-02-05 20:49:34 +00:00
Robert Schulze
9b841d67e8
Merge remote-tracking branch 'origin/master' into qc-max_cache_size
2023-02-05 16:47:02 +00:00
Antonio Andelic
12569da984
Merge branch 'master' into add-support-for-settings-alias
2023-02-05 16:08:57 +00:00
Boris Kuschel
1d4cf4fe69
Add encryption support with openssl
2023-02-04 14:59:34 -05:00
Alexey Milovidov
22bd0b6f69
Merge pull request #38983 from CurtizJ/randomize-mt-settings
...
Allow to randomize merge tree settings in tests
2023-02-04 02:59:52 +01:00