SmitaRKulkarni
a55d344898
Merge branch 'master' into Clear_marks_cache_for_outdated_parts
2023-04-11 17:00:31 +02:00
Anton Popov
5b8db57fe8
Merge branch 'master' into retry-loading-of-parts
2023-04-11 15:51:40 +02:00
SmitaRKulkarni
e2010c0257
Merge branch 'master' into zk_retry_timeout
2023-04-11 14:05:52 +02:00
Sergei Trifonov
ca6e253fa6
Merge pull request #48526 from ClickHouse/lost-part-count
2023-04-11 13:11:42 +02:00
Sema Checherinda
4dd86a406a
Merge pull request #48543 from azat/mv-uniq-thread-group
...
Use one ThreadGroup while pushing to materialized views (and some refactoring for ThreadGroup)
2023-04-11 11:47:46 +02:00
Azat Khuzhin
79b83c4fd2
Remove superfluous includes of logger_userful.h from headers
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-10 17:59:30 +02:00
Raúl Marín
45ad555c39
Merge branch 'master' into zk_retry_timeout
2023-04-10 10:04:16 +02:00
Sergei Trifonov
b319271d59
Remove misleading comment
...
It is no longer "significant" after `NOEXCEPT_SCOPE` macro rework #39229
2023-04-08 22:50:24 +02:00
robot-clickhouse-ci-1
3302f1ff90
Merge pull request #48299 from CurtizJ/do-not-build-unnecessary-sets
...
Do not build sets for skip indexes if they are not used
2023-04-08 21:25:06 +02:00
Alexander Tokmakov
bf20e6bfc6
Merge pull request #48550 from ClickHouse/fix_sync_replica
...
Fix some tests
2023-04-08 14:41:10 +03:00
Alexander Tokmakov
e39ee3f0af
suppress a bug in filesystem cache
2023-04-07 22:54:49 +02:00
Alexander Tokmakov
18a2eb355e
fix a bug in sync replica
2023-04-07 20:16:25 +02:00
Azat Khuzhin
aacf2a0838
Move ThreadGroupSwitcher to ThreadStatus.h (out from MergeTree code)
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-07 15:32:08 +02:00
Azat Khuzhin
5b2b20a0b0
Rename ThreadGroupStatus to ThreadGroup
...
There are methods like getThreadGroup() and ThreadGroupSwitcher class,
so seems that this is logical.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-07 15:31:48 +02:00
Azat Khuzhin
011480924a
Use forward declaration of ThreadPool
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-07 11:25:35 +02:00
serxa
343a071798
add lost_part_count column to system.replicas
2023-04-06 22:38:58 +00:00
Smita Kulkarni
7b33744618
Added a check to clear and not load marks asynchronously from outdated parts
2023-04-06 20:11:40 +02:00
Sema Checherinda
b8729be97a
Merge pull request #47104 from CheSema/thead-group-for-merge
...
merge and mutation make thread group for setting memory trackers right
2023-04-06 15:46:56 +02:00
Vladimir C
e7a5c96353
Merge pull request #48219 from ClickHouse/vdimir/lock_order_47072
2023-04-06 11:54:33 +02:00
robot-ch-test-poll3
3ad0a6ac18
Merge pull request #48433 from ClickHouse/some-fixes-for-parallel-replicas
...
Some fixes for parallel replicas
2023-04-06 02:00:06 +02:00
Anton Popov
4fb7e0ec3c
add retries to loading of data parts
2023-04-05 21:23:57 +00:00
Sema Checherinda
554c928534
Merge branch 'master' into thead-group-for-merge
2023-04-05 21:09:38 +02:00
Sema Checherinda
c1adbb7aa6
transfer counters to the query directly
2023-04-05 19:51:36 +02:00
robot-clickhouse
3d2c279859
Merge pull request #48242 from azat/better-throttling
...
Per-query/per-server throttling for remote IO/local IO/BACKUPs
2023-04-05 19:32:37 +02:00
Nikita Mikhaylov
3f44c6d936
Better
2023-04-05 15:19:45 +00:00
vdimir
01ce3baf0f
Rename Context::getTemporaryVolume to getGlobalTemporaryVolume
2023-04-05 13:42:13 +00:00
Alexander Tokmakov
3b5ed9242c
Merge pull request #48391 from azat/fix-sync-replica-stuck
...
Fix possible SYSTEM SYNC REPLICA stuck in case of DROP/REPLACE PARTITION
2023-04-05 15:20:46 +03:00
Nikita Mikhaylov
7b526d3df9
Always communicate with local replica through loopback interface for parallel replicas ( #48246 )
2023-04-05 13:32:46 +02:00
Sema Checherinda
f504cd5fed
avoid race, do not set thread_group.counters.parent from query
2023-04-05 12:36:55 +02:00
Azat Khuzhin
218b1f9c29
Add ability to throttle BACKUPs on per-server/backup basis
...
Server settings:
- backup_read_bandwidth_for_server
- backup_write_bandwidth_for_server
Query settings:
- backup_read_bandwidth
- backup_write_bandwidth
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 09:39:48 +02:00
Raúl Marín
0e17b3b147
Merge remote-tracking branch 'blessed/master' into zk_retry_timeout
2023-04-04 18:53:55 +02:00
Nikita Mikhaylov
fa5b2bd4a5
Added Keeper retries for backups operations ( #47224 )
2023-04-04 18:12:08 +02:00
Azat Khuzhin
353434f8f1
Fix possible SYSTEM SYNC REPLICA stuck in case of DROP/REPLACE PARTITION
...
In case of DROP/REPLACE PARTITION the entries from the queue will be
removed without notifying the subscribes.
CI: https://s3.amazonaws.com/clickhouse-test-reports/48242/4a315cd0d17bc12edd934fd25663b0119880f207/stress_test__asan_.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-04 17:16:04 +02:00
Yakov Olkhovskiy
35e9e45249
Merge pull request #48062 from Algunenano/unnecessary_alter_checks
...
Only check MV on ALTER when necessary
2023-04-03 17:23:11 -04:00
Sema Checherinda
6d5edc0315
rename fake_query_context to task_context
2023-04-03 22:01:18 +02:00
Anton Popov
207a4c6166
Merge branch 'master' into do-not-build-unnecessary-sets
2023-04-03 14:29:33 +02:00
Raúl Marín
8fdf87982c
Merge remote-tracking branch 'blessed/master' into zk_retry_timeout
2023-04-03 10:26:18 +02:00
Alexey Milovidov
ef1e282d4c
Merge branch 'master' into compress-marks-primary-key-by-default
2023-04-03 06:28:48 +03:00
Alexey Milovidov
5ebf66819b
Merge pull request #47617 from ClickHouse/cnf-new-analyzer
...
CNF/Constraint optimizer in new analyzer
2023-04-02 20:09:34 +03:00
Anton Popov
cdf9cf2fd4
do not build sets for indexes if they are not used
2023-03-31 16:06:20 +00:00
Alexander Tokmakov
75ffc8451b
fix
2023-03-31 16:09:00 +02:00
Alexander Tokmakov
caf00b5968
Merge branch 'master' into sync_replica_lightweight
2023-03-31 14:52:55 +02:00
Alexey Milovidov
17c2678675
Merge branch 'master' into compress-marks-primary-key-by-default
2023-03-31 15:15:38 +03:00
Azat Khuzhin
f38a7aeabe
ThreadPool metrics introspection
...
There are lots of thread pools and simple local-vs-global is not enough
already, it is good to know which one in particular uses threads.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-29 10:46:59 +02:00
Antonio Andelic
50ed205aa0
Merge pull request #47303 from ClickHouse/avoid-merging-partition
...
Skip merged partitions for `min_age_to_force_merge_seconds` merges
2023-03-29 09:31:00 +02:00
Sema Checherinda
1031e2001b
fix build
2023-03-29 07:41:31 +02:00
HarryLeeIBM
47b31c39d1
Fix partition id issue for s390x
2023-03-28 15:31:26 -07:00
Robert Schulze
622d1dfadd
Merge pull request #46252 from ClibMouse/feature/hastokencaseinsensitive-index-utilization
...
Implement tokenbf_v1 index utilization for hasTokenCaseInsensitive
2023-03-28 22:38:21 +02:00
Sema Checherinda
b774310dc9
keep query id for logging when optimize query
2023-03-28 16:44:47 +02:00
Kruglov Pavel
292539b90e
Merge pull request #47981 from kssenii/better-delegate-disks-handle-mutual-path
...
Fix case when (optional) path is not added to encrypted disk configuration
2023-03-28 13:52:50 +02:00
Raúl Marín
bffde5e476
Merge remote-tracking branch 'blessed/master' into unnecessary_alter_checks
2023-03-28 13:17:36 +02:00
Vladimir C
5fa519d043
Merge pull request #48047 from ClickHouse/vdimir/max_number_of_mutatuins_for_replica
2023-03-28 10:50:35 +02:00
Antonio Andelic
0b5fd2140a
Merge branch 'master' into cnf-new-analyzer
2023-03-28 07:57:12 +00:00
Antonio Andelic
30e4ee705a
Better
2023-03-28 07:54:23 +00:00
Antonio Andelic
a3b6d43212
Merge branch 'master' into avoid-merging-partition
2023-03-28 09:40:36 +02:00
Alexander Tokmakov
b5fe1ada0b
more options for sync replica
2023-03-28 01:39:36 +02:00
kssenii
314ee12442
Fix checks
2023-03-27 19:20:11 +02:00
Igor Nikonov
c2c7895b82
Merge pull request #47770 from ClickHouse/stop_wait_for_quorum_retries_on_shutdown
...
Stop `wait for quorum` retries on shutdown
2023-03-27 18:27:14 +02:00
Raúl Marín
d1a6c1991a
Only check MV on ALTER when necessary
2023-03-27 17:45:15 +02:00
Sema Checherinda
a6ab33a906
no use query, but storage context
2023-03-27 16:30:32 +02:00
Raúl Marín
83b68caccc
Do not continue retrying to connect to ZK if the query is killed or over limits
2023-03-27 16:01:15 +02:00
vdimir
08fa1846b1
Add merge tree setting max_number_of_mutations_for_replica
2023-03-27 11:56:48 +00:00
Antonio Andelic
e4a78a982f
Merge branch 'master' into cnf-new-analyzer
2023-03-27 07:43:21 +00:00
Smita Kulkarni
eabcefe452
Fixed issue with reserving vector size
2023-03-26 14:52:08 +02:00
SmitaRKulkarni
f0b724497f
Merge branch 'master' into 47200_Fix_for_index_file_cidx_is_unexpectedly_long
2023-03-26 14:02:56 +02:00
Smita Kulkarni
decdf0c507
Updated to delete added keys if there is an exception during update of metadata cache
2023-03-26 10:35:44 +02:00
Nikolai Kochetov
327674f56d
Merge pull request #46537 from ClickHouse/aggregate-projections-analysis-query-plan
...
Projections analysis from query plan
2023-03-25 13:23:30 +01:00
Sema Checherinda
aeb8766ad5
adjust after rebase
2023-03-24 19:53:16 +01:00
Sema Checherinda
da3e744405
set context from the master thread
2023-03-24 19:53:16 +01:00
Sema Checherinda
0fcf7c0363
std::optional instead shared_ptr
2023-03-24 19:53:16 +01:00
Sema Checherinda
6a6d45e6e7
set up performance_counters for thread group
2023-03-24 19:53:16 +01:00
Sema Checherinda
da4f2bd923
do not attach empty thread group
2023-03-24 19:53:16 +01:00
Sema Checherinda
bc107c70fa
merge and mutation make thread group for setting memory trackers right
2023-03-24 19:53:16 +01:00
kssenii
16ebfcc3f8
Better delegate disks handle mutual path
2023-03-24 16:21:19 +01:00
Nikolai Kochetov
a2182f2659
Merge pull request #47874 from amosbird/correct_exact_rows_before_limit
...
Correct `exact_rows_before_limit` in some scenarios
2023-03-24 15:09:42 +01:00
Alexander Tokmakov
4dde73c3eb
Merge pull request #47917 from ClickHouse/fix_terminate_in_check_thread
...
Fix terminate in parts check thread
2023-03-24 04:22:00 +03:00
Nikolai Kochetov
73e98de46d
Merge branch 'master' into aggregate-projections-analysis-query-plan
2023-03-23 21:28:36 +01:00
ltrk2
f46970671d
Implement tokenbf_v1 index utilization for hasTokenCaseInsensitive
2023-03-23 12:24:13 -07:00
Maksim Kita
24b9e5103f
Merge pull request #47748 from ClickHouse/revert-47721-revert-47622-analyzer-planner-fixes-before-enable-by-default
...
Revert "Revert "Analyzer planner fixes before enable by default""
2023-03-23 22:20:34 +03:00
Alexander Tokmakov
5b263b9ffe
fix
2023-03-23 15:36:17 +01:00
Maksim Kita
7da53bf7e8
Fixed tests
2023-03-23 12:34:23 +01:00
robot-ch-test-poll3
a31c0d8eee
Merge pull request #47883 from ClickHouse/drop-column-with-projections
...
Fix DROP COLUMN with ReplicatedMergeTree containing projections
2023-03-22 23:55:16 +01:00
Alexander Tokmakov
e3c798bae5
fix terminate in parts check thread
2023-03-22 23:46:15 +01:00
Maksim Kita
f45dac99c2
Revert "Revert "Analyzer planner fixes before enable by default""
2023-03-22 17:19:32 +01:00
Nikolai Kochetov
d7d3722b76
Revert analyzer till later.
2023-03-22 15:41:54 +00:00
Amos Bird
02c5d1f364
Correct exact_rows_before_limit in all senarios
2023-03-22 23:26:31 +08:00
Antonio Andelic
b832840cf3
Recalculate always projections on mutations in ReplicatedMergeTree
2023-03-22 11:21:23 +00:00
Alexander Tokmakov
c114361879
Update MergeTreeData.h
2023-03-21 23:15:59 +03:00
Alexander Tokmakov
8a71e42f08
Merge pull request #47769 from HarryLeeIBM/hlee-s390x-partid
...
Fix partition ID byte order for s390x
2023-03-21 23:01:36 +03:00
Alexander Tokmakov
0989dd837a
Merge pull request #47802 from ClickHouse/fix_some_tests
...
Fix 993 and two other tests
2023-03-21 22:20:06 +03:00
Nikolai Kochetov
b432fa1122
Attempt to use new analyzer.
2023-03-21 17:56:58 +00:00
Antonio Andelic
ed3f51d9b3
Merge branch 'master' into avoid-merging-partition
2023-03-21 10:46:03 +00:00
Vladimir C
5add1e1b2e
Merge pull request #47684 from ClickHouse/vdimir/improve_log_queries_cut
2023-03-21 11:17:54 +01:00
Alexander Tokmakov
d5a561a2ef
fix 993 and two other tests
2023-03-20 22:51:32 +01:00
Robert Schulze
595796e63d
Merge branch 'master' into rs/more-llvm-16-preparation
2023-03-20 21:16:27 +01:00
HarryLeeIBM
ed1ff02114
Fix partition ID byte order for s390x
2023-03-20 14:19:27 -04:00
vdimir
bb7a8ed862
Apply log_queries_cut_to_length in MergeTreeWhereOptimizer
2023-03-20 15:38:09 +00:00
Igor Nikonov
1073c7f3c9
Revert "Actually stop retries in case of storage shutdown"
...
This was unnecessary since, as for exceptions, retries done only on
zkutil::KeeperException
This reverts commit 795a1c84e1
2023-03-20 13:54:25 +00:00
Igor Nikonov
795a1c84e1
Actually stop retries in case of storage shutdown
2023-03-20 13:48:04 +00:00
Igor Nikonov
1098055409
Stop wait for quorum retries on shutdown
2023-03-20 13:21:10 +00:00
Robert Schulze
5b036a1a3b
More preparation for libcxx(abi), llvm, clang-tidy 16 (follow-up to #47722 )
2023-03-20 12:55:03 +00:00
Raúl Marín
fb6ce35ea2
Fix ZK exception error message
2023-03-20 13:00:24 +01:00
Alexey Milovidov
ddf29b69f9
Merge branch 'master' into fuzzer-of-data-formats
2023-03-20 03:26:51 +03:00
Alexey Milovidov
e788bf0712
Merge pull request #47721 from ClickHouse/revert-47622-analyzer-planner-fixes-before-enable-by-default
...
Revert "Analyzer planner fixes before enable by default"
2023-03-20 03:24:03 +03:00
Robert Schulze
0e01e912fe
Preparation for libcxx(abi), llvm, clang-tidy 16
2023-03-19 17:25:41 +00:00
Alexey Milovidov
ef5e8462da
Revert "Analyzer planner fixes before enable by default"
2023-03-19 19:25:37 +03:00
Alexey Milovidov
a99f10e16f
Better error messages
2023-03-19 05:34:44 +01:00
Alexander Tokmakov
f1df91cd09
Merge pull request #47659 from ClickHouse/fix_993
...
Fixes for 993 and friends
2023-03-18 14:46:43 +03:00
Maksim Kita
5187138510
Merge pull request #47622 from kitaisreal/analyzer-planner-fixes-before-enable-by-default
...
Analyzer planner fixes before enable by default
2023-03-18 13:11:40 +03:00
Sema Checherinda
0b641fcead
Merge pull request #47564 from CheSema/remove-redundant
...
remove counters for threads, fix negative counters
2023-03-18 02:23:52 +01:00
Han Fei
722e6bb2e8
Merge pull request #47680 from ClickHouse/rs/uncruftify-build
...
CMake: Remove further cruft from build
2023-03-17 22:58:46 +01:00
Alexander Tokmakov
d11aee2b0c
Merge branch 'master' into fix_993
2023-03-17 21:28:23 +03:00
alesapin
e45b558a86
Merge pull request #47676 from ClickHouse/fix_zero_copy_lock_check
...
Fix zero copy lock check
2023-03-17 17:51:14 +01:00
alesapin
1022c47421
Review fixes
2023-03-17 17:45:02 +01:00
Antonio Andelic
79cff0a14b
Merge branch 'master' into cnf-new-analyzer
2023-03-17 14:37:40 +00:00
Robert Schulze
f72a337074
Remove cruft from build
...
No need to check compiler flags, clang >= 15 supports all of them.
2023-03-17 13:44:04 +00:00
Antonio Andelic
0fb9f9ffe6
Add support for substitute column
2023-03-17 13:38:01 +00:00
Maksim Kita
2d2696bc20
Fixed code review issues
2023-03-17 14:34:23 +01:00
alesapin
e44fca8bb9
Add test
2023-03-17 12:56:31 +01:00
Sergei Trifonov
1a84203c7f
Merge pull request #47656 from ClickHouse/background_pool_limit_metric
...
Add background pools size metrics
2023-03-17 11:49:53 +01:00
alesapin
4a80197f16
Merge branch 'master' into fix_zero_copy_lock_check
2023-03-17 11:18:51 +01:00
alesapin
efa0622a84
Merge pull request #47631 from ClickHouse/fix_wait_for_zero_copy_lock
...
Fix wait for zero copy lock during move
2023-03-17 11:15:55 +01:00
Sergei Trifonov
2cbd91b852
Merge branch 'master' into background_pool_limit_metric
2023-03-16 23:23:42 +01:00
alesapin
3731567b6a
Bad code
2023-03-16 21:48:47 +01:00
Robert Schulze
02a2c73bae
Merge pull request #47607 from save-my-heart/inverted_index
...
checksum: do not check inverted index files
2023-03-16 21:34:17 +01:00
Alexander Tokmakov
d621b2c4ad
fix intersecting parts, better fault injections
2023-03-16 21:28:07 +01:00
alesapin
92eb6685c6
Fix lock check
2023-03-16 20:17:29 +01:00
Sema Checherinda
3c6deddd1d
work with comments on PR
2023-03-16 19:55:58 +01:00
serxa
3ad7194e31
add pool size metrics
2023-03-16 17:31:41 +00:00
Antonio Andelic
985a0285c7
Merge branch 'master' into cnf-new-analyzer
2023-03-16 16:00:51 +00:00
Alexander Tokmakov
8b8215f91a
fix some other tests, add logs for further debugging
2023-03-16 16:40:08 +01:00
Antonio Andelic
0f6e4d3934
Start implementing constraint optimizer
2023-03-16 09:30:55 +00:00
alesapin
fc913649cf
Check only for interactive moves
2023-03-15 22:51:53 +01:00
alesapin
ef7508469c
Fix wait for zero-copy replication move during manual move
2023-03-15 22:29:24 +01:00
Maksim Kita
c102adb728
Analyzer added PREWHERE support
2023-03-15 15:21:49 +01:00
save-my-heart
b7d9d721fb
add test
2023-03-15 21:01:12 +08:00
Vitaly Baranov
00c05f7f8b
Merge pull request #47546 from vitlibar/use-server-side-copy-for-restore
...
Use server-side copy for restore from S3 to S3.
2023-03-15 11:28:29 +01:00
save-my-heart
d70c352313
checksum: do not check inverted index files
2023-03-15 16:43:59 +08:00
Alexander Tokmakov
5a1ee881f8
Merge pull request #47547 from ClickHouse/filter_too_frequent_logs
...
Hide too noisy log messages, fix some tests
2023-03-14 13:53:21 +03:00
Michael Kolupaev
d3a514d221
Compress marks in memory
2023-03-13 16:29:00 -07:00
Alexander Tokmakov
ba6c6255a3
hide too noisy log messages, fix some tests
2023-03-14 00:23:36 +01:00
Vitaly Baranov
1cf1ce07fe
Use server-side copy during restore from S3 to S3.
2023-03-13 23:50:13 +01:00
Nikolai Kochetov
669a92bae0
Merge branch 'master' into aggregate-projections-analysis-query-plan
2023-03-13 19:55:49 +01:00
alesapin
8db0d26519
Merge branch 'master' into revert-46909-revert-45911-mutations_rename_hang
2023-03-13 14:48:20 +01:00
Alexey Milovidov
218ac10425
More detailed error messages on too many parts
2023-03-11 21:44:38 +01:00
Maksim Kita
114d30d2bb
Merge pull request #47383 from kitaisreal/analyzer-planner-fixes-before-enable-by-default
...
Analyzer planner fixes before enable by default
2023-03-11 22:09:04 +03:00
Maksim Kita
3d34247998
Fixed tests
2023-03-11 11:51:54 +01:00
Maksim Kita
0358cb36d8
Fixed tests
2023-03-11 11:51:54 +01:00
Alexander Tokmakov
6e7ffd9a7b
Update ReplicatedMergeTreeAttachThread.cpp
2023-03-11 00:45:09 +03:00
Dmitry Novik
4f24a7bd11
Merge remote-tracking branch 'origin/master' into background-memory-tracker
2023-03-10 18:57:45 +00:00
Anton Popov
66a113ca61
Merge pull request #47384 from CurtizJ/fix-clear-column-with-sparse
...
Fix `ALTER CLEAR COLUMN` with sparse columns
2023-03-09 16:57:23 +01:00
alesapin
588cc0f159
Merge branch 'master' into revert-46909-revert-45911-mutations_rename_hang
2023-03-09 14:54:10 +01:00
Anton Popov
c3b9af96c4
fix ALTER CLEAR COLUMN with sparse columns
2023-03-08 17:19:04 +00:00
Antonio Andelic
a04b38db90
Merge pull request #45108 from ClickHouse/custom-key-parallel-replicas
...
Add support for custom key in parallel replicas
2023-03-08 17:46:11 +01:00
Alexander Tokmakov
38f9f08e1a
Merge pull request #47268 from myrrc/improvement/more-to-base-3
...
use std::lerp, constexpr hex.h
2023-03-08 19:07:34 +03:00
alesapin
4423be8332
Merge branch 'master' into revert-46909-revert-45911-mutations_rename_hang
2023-03-08 12:59:07 +01:00
Antonio Andelic
816a9c1099
Merge branch 'master' into custom-key-parallel-replicas
2023-03-08 11:06:30 +01:00
Alexey Milovidov
e8cdb0c8b1
Merge pull request #46839 from CurtizJ/fix-crash-in-skip-index
...
Do not allow const and non-deterministic secondary indexes
2023-03-08 03:03:09 +03:00
Alexey Milovidov
e2aff59a2d
Merge pull request #47106 from kssenii/allow-nested-disks-in-custom-disks
...
Allow nested custom disks
2023-03-08 03:00:55 +03:00
Mike Kot
9920a52c51
use std::lerp, constexpr hex.h
2023-03-07 22:50:17 +00:00
Antonio Andelic
d098891185
Skip merges if no need
2023-03-07 13:08:56 +00:00
Antonio Andelic
35c15e6ef8
Merge branch 'master' into custom-key-parallel-replicas
2023-03-07 09:37:38 +00:00
Vladimir C
1455e7602d
Merge pull request #47154 from azat/prewhere-columns-fix
2023-03-06 10:03:31 +01:00
Anton Popov
6f3e4d4137
Merge pull request #46118 from CurtizJ/fix-issues-with-sparse
...
Randomize setting `ratio_of_defaults_for_sparse_serialization`
2023-03-05 22:28:18 +01:00
Robert Schulze
10753481f9
Merge pull request #47242 from ClickHouse/rs/docs-index-support-has-hasall-hasany
...
Docs: Update index support of has(), hasAny(), hasAll()
2023-03-04 18:49:24 +01:00
Robert Schulze
11930ad685
Docs: Update index support of has(), hasAny(), hasAll()
2023-03-04 17:27:47 +00:00
Anton Popov
9389cc29da
better mutations of sparse columns
2023-03-03 16:52:01 +00:00
Antonio Andelic
737cf8e149
Better
2023-03-03 15:14:49 +00:00
Sema Checherinda
7a9f4aab8e
do not call adjustWithUntrackedMemory when untracked_memory is 0
2023-03-02 19:21:03 +01:00
alesapin
63f615cdcd
Fix metadata version
2023-03-02 19:17:18 +01:00
Azat Khuzhin
167e4903a8
Fix concrete columns PREWHERE support
...
This is the fix for the IStorage::supportedPrewhereColumns() API.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-02 18:51:23 +01:00
Anton Popov
fdf8a418f5
better interface
2023-03-02 14:46:26 +00:00
Antonio Andelic
01cf9c94f4
Merge branch 'master' into custom-key-parallel-replicas
2023-03-02 14:28:42 +00:00
Robert Schulze
740aeaba1f
Apply some CTAD
2023-03-02 13:36:47 +00:00
kssenii
2883861795
Merge remote-tracking branch 'upstream/master' into allow-nested-disks-in-custom-disks
2023-03-02 14:30:58 +01:00
alesapin
915b4ea56a
Merge branch 'master' into revert-46909-revert-45911-mutations_rename_hang
2023-03-02 14:29:21 +01:00
alesapin
db0f9b6578
Fix one more bug
2023-03-02 14:26:07 +01:00
alesapin
189836307c
Merge branch 'revert-46909-revert-45911-mutations_rename_hang' of github.com:ClickHouse/ClickHouse into revert-46909-revert-45911-mutations_rename_hang
2023-03-02 12:49:06 +01:00
Alexey Milovidov
97c0f8a0e0
Merge pull request #47027 from amosbird/clang16
...
Prepare to build with clang 16
2023-03-02 02:10:03 +03:00
Anton Popov
c4a999ce29
Merge remote-tracking branch 'upstream/master' into HEAD
2023-03-01 19:33:16 +00:00
alesapin
46f25d53b3
Merge branch 'master' into revert-46909-revert-45911-mutations_rename_hang
2023-03-01 20:09:12 +01:00
kssenii
f3e3b916c9
Allow nested custom disks
2023-03-01 19:55:59 +01:00
alesapin
ebba37b18f
Merge pull request #47010 from ClickHouse/zero_copy_fetch
...
Fix bug in zero-copy replication disk choice during fetch
2023-03-01 15:55:00 +01:00
alesapin
b7370865a7
Merge pull request #47032 from ClickHouse/fix_message_for_zero_copy
...
Better exception message when move was unseccessful
2023-03-01 15:26:53 +01:00
alesapin
d72c310faa
Update src/Storages/MergeTree/MergeTreeData.cpp
...
Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>
2023-03-01 11:54:22 +01:00
alesapin
8ff77c89eb
Update src/Storages/MergeTree/MergeTreeData.cpp
...
Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>
2023-03-01 11:50:35 +01:00
alesapin
be5ef666ba
Update src/Storages/MergeTree/MergeTreeData.cpp
...
Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>
2023-03-01 11:50:29 +01:00
alesapin
5de8a8e776
Update src/Storages/MergeTree/MergeTreeData.cpp
...
Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>
2023-03-01 11:50:23 +01:00
Alexey Milovidov
fe446afb7d
Increase max_replicated_merges_in_queue
2023-03-01 06:02:59 +01:00
Amos Bird
c0fb4ddc3e
Make thread analyzer happy
2023-03-01 11:07:36 +08:00
alesapin
c0f28ace51
Better
2023-02-28 17:52:21 +01:00
alesapin
abd6500ee3
Better exception message when move was unseccessful
2023-02-28 17:49:16 +01:00
alesapin
bb7571427b
Fix bug in zero-copy replica disk choice during fetch
2023-02-28 14:48:46 +01:00
alesapin
967a47d870
Fix bug with readonly storages
2023-02-28 12:17:43 +01:00
Alexey Milovidov
29da7fc965
Decrease log level in "disks"
2023-02-27 17:48:38 +01:00
Anton Popov
caa1d22759
Merge branch 'master' into fix-issues-with-sparse
2023-02-27 15:25:19 +01:00
alesapin
7adbe93105
Remove strange part
2023-02-27 14:48:47 +01:00
Robert Schulze
6f0709032d
Merge pull request #46921 from ClickHouse/rs/inv-idx-checksum
...
A better alternative to #46344
2023-02-27 14:44:44 +01:00
alesapin
9dec64c94c
Choose correct version for mutation
2023-02-27 14:35:26 +01:00
Nikolai Kochetov
3392b96cc3
Merge branch 'master' into aggregate-projections-analysis-query-plan
2023-02-27 14:07:04 +01:00
alesapin
e3961c118a
Revert "Revert "Fix several RENAME COLUMN bugs.""
2023-02-27 12:27:57 +01:00
Robert Schulze
4c9b9b362c
Replace dynamic_cast by typeid_cast
2023-02-27 10:01:21 +00:00
Robert Schulze
cc0c0c6133
A better alternative to #46344
...
The (experimental) inverted index writes/reads files different from the
standard files written by the other skip indexes. The original problem
was that with database engine "ordinary", DROP TABLE of a table with
inverted index finds unknown files in persistence and complains. The
same will happen with engine "atomic" but deferred. As a hotfix, the
error was silenced by explicitly adding the four files created in a
specific test to the deletion code.
This PR tries a cleaner solution where all needed files are provided via
the normal checksum structure. One drawback remains which is that the
affected files were written earlier and we don't have their checksums
available. Therefore, the inverted index is currently excluded from
CHECK TABLE.
Minimal repro:
SET allow_experimental_inverted_index = 1;
DROP TABLE IF EXISTS tab;
CREATE TABLE tab(s String, INDEX af(s) TYPE inverted(2)) ENGINE = MergeTree() ORDER BY s;
INSERT INTO tab VALUES ('Alick a01');
CHECK TABLE tab;
DROP TABLE IF EXISTS tab;
run ./clickhouse-test with --db-engine Ordinary
2023-02-26 21:06:38 +00:00
Alexey Milovidov
73aec86f5a
Change exception message
2023-02-26 21:36:26 +01:00
Alexey Milovidov
8f40bbd5b4
Revert "Fix several RENAME COLUMN bugs."
2023-02-26 05:47:05 +03:00
Alexey Milovidov
eb89ab471f
Merge pull request #45911 from ClickHouse/mutations_rename_hang
...
Fix several `RENAME COLUMN` bugs.
2023-02-26 01:56:40 +03:00
Alexey Milovidov
656af55831
Merge pull request #46384 from ClickHouse/fixes_for_993
...
Fixes for 993
2023-02-26 01:55:20 +03:00
Anton Popov
3a947ecddc
do not allow const and non-deterministic secondary indexes
2023-02-24 19:17:44 +00:00
Alexander Tokmakov
ca1c793cac
Merge pull request #46820 from Algunenano/avoid_KeeperMultiException_system_errors
...
Don't report ZK node exists to system.errors when a block was created concurrently by a different replica
2023-02-24 19:42:32 +03:00
Alexander Gololobov
b43b98f7c0
Merge pull request #46785 from ClickHouse/fix_combined_prewhere_column
...
Fix combined PREWHERE column accumulated from multiple steps
2023-02-24 14:00:17 +01:00
Raúl Marín
7ff8d2d3d5
Don't report ZK node exists to system.errors
2023-02-24 12:36:29 +01:00
Anton Popov
d926713cf5
Merge remote-tracking branch 'upstream/master' into HEAD
2023-02-23 23:04:22 +00:00
Anton Popov
5e5e802348
return back optimization for ALTER MODIFY Nullable
2023-02-23 22:55:47 +00:00
Alexander Gololobov
47f51fe187
Merge pull request #46771 from ClickHouse/fix_prewhere_logging
...
More concise logging at trace level for PREWHERE steps
2023-02-23 20:20:30 +01:00
Alexander Gololobov
8b22373488
Apply filter at last step if it has been accumulated from multiple steps
2023-02-23 16:58:28 +01:00
Alexander Gololobov
cbcb1a7852
More concise logging at trace level
2023-02-23 13:31:56 +01:00
Kseniia Sumarokova
30a8eb0c2f
Merge pull request #46670 from kssenii/hide-disk-setting
...
Hide arguments of custom disk merge tree setting
2023-02-23 11:42:53 +01:00
Alexey Milovidov
c0bc549e77
Merge pull request #46709 from azat/bg-pool-no-query
...
BackgroundSchedulePool should not have any query context
2023-02-23 10:24:46 +03:00
Alexander Gololobov
67dcd9694c
Remove unused MergeTreeReadTask::remove_prewhere_column
2023-02-22 17:49:22 +01:00
kssenii
c4761d6cc6
Fix checks
2023-02-22 14:27:43 +01:00
Azat Khuzhin
2ca47a6eb6
BackgroundSchedulePool should not have any query context
...
BackgroundSchedulePool is used for some peridic jobs, not from the query
context, i.e. flush of Buffer table.
And for such jobs there cannot be any query context, and more
importantly it will not work correctly since that query_context will
eventually expires.
And this is the reason of this failures [1].
[1]: https://s3.amazonaws.com/clickhouse-test-reports/46668/015991bc5e20c787851050c2eaa13f0fef3aac00/stateless_tests_flaky_check__asan_.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-22 10:50:51 +01:00
Alexander Gololobov
b61bb56a5a
Merge pull request #46611 from ClickHouse/prewhere_progress
...
Fix reporting progress when rows are filtered in PREWHERE
2023-02-21 21:27:56 +01:00
Alexey Milovidov
848286eca7
Merge pull request #40945 from arthurpassos/add_select_final_mt_setting
...
Add user setting to force select final at query level
2023-02-21 19:58:45 +03:00
Nikolai Kochetov
c5f93eb108
Fix more tests.
2023-02-21 15:44:50 +00:00
Anton Popov
b66a5bdcf0
fix mutations with sparse columns
2023-02-21 15:13:29 +00:00
Alexander Gololobov
5354b0d069
Merge pull request #46140 from ClickHouse/split_prewhere_dag
...
Split PREWHERE DAG into multiple read steps
2023-02-21 14:37:09 +01:00
Vladimir C
a791250a4a
Merge pull request #38614 from bharatnc/ncb/profile-events-partlog
2023-02-21 11:06:44 +01:00
Kruglov Pavel
b0424c1021
Merge pull request #46171 from Avogar/insert-null-as-default
...
Use default of column type in `insert_null_as_default` if column DEFAULT values is not specified
2023-02-20 21:45:02 +01:00
Nikolai Kochetov
ee597b939f
Merge branch 'master' into aggregate-projections-analysis-query-plan
2023-02-20 19:46:52 +00:00
Arthur Passos
4f2fcf763b
Merge branch 'master' into add_select_final_mt_setting
2023-02-20 16:22:14 -03:00
Alexander Gololobov
c84a64d22f
Return chunks with 0 rows from MergeTreeSource to report progress when rows are filtered in PREWHERE
2023-02-20 17:35:01 +01:00
Nikolai Kochetov
84e442e620
Fixing build and style.
2023-02-20 14:21:20 +00:00
Nikolai Kochetov
2a8460d962
Merge branch 'master' into aggregate-projections-analysis-query-plan
2023-02-20 13:54:05 +01:00
Alexey Milovidov
d8cda3dbb8
Remove PVS-Studio
2023-02-19 23:30:05 +01:00
Arthur Passos
3d9b23e5f3
Merge branch 'master' into add_select_final_mt_setting
2023-02-19 15:01:41 -03:00
Alexander Gololobov
520b381675
Fixes for executing actions on block with unknown row count
2023-02-19 12:14:23 +01:00
Maksim Kita
6dffe52e68
Merge pull request #46471 from kitaisreal/analyzer-planner-fixes-before-enable-by-default
...
Analyzer planner fixes before enable by default
2023-02-19 13:49:18 +03:00
Alexander Gololobov
0ed0b191f8
Fix for Nullable step filter column
2023-02-18 19:12:32 +01:00
Alexander Gololobov
88fb6c3c25
Fix for incorrect combined PREWHERE column
2023-02-18 18:29:16 +01:00
Kseniia Sumarokova
b0ea047e76
Merge pull request #46533 from kssenii/fix-disk-setting
...
Allow `disk` merge tree setting in query to override config merge tree setting `storage_policy`
2023-02-18 12:36:54 +01:00
kssenii
afb36dd120
Allow disk setting to override storage_policy from config merge tree settings insteaf of exception
2023-02-17 17:11:29 +01:00
Antonio Andelic
ab51c1d975
Merge branch 'master' into custom-key-parallel-replicas
2023-02-17 15:06:41 +01:00
kssenii
bae85c50e9
Fix stress test
2023-02-17 12:40:17 +01:00
Alexander Tokmakov
9a664efeb6
Merge branch 'master' into fixes_for_993
2023-02-17 14:17:08 +03:00
Sema Checherinda
b551b9fb3a
Merge pull request #46452 from CheSema/resolve-race-get-csn
...
resolve race in getCSNAndAssert
2023-02-17 11:31:58 +01:00
Dmitry Novik
0336f0d8cc
Merge branch 'master' into background-memory-tracker
2023-02-16 20:57:44 +01:00
Arthur Passos
ba6b7b1610
fix test_alias_column
2023-02-16 16:01:25 -03:00
Alexander Gololobov
a6061e022e
Merge branch 'master' into split_prewhere_dag
2023-02-16 14:43:58 +01:00
youennL-cs
6526c2a8ab
[RFC] Replacing merge tree new engine ( #41005 )
...
* Add new engine to ReplacingMergeTree corresponding to the ReplacingCollapsingMergeTree
* Add new test for the new ReplacingMergeTree engine
* Limit sign value to -1/1
* Add new engine to ReplacingMergeTree corresponding to the ReplacingCollapsingMergeTree
* Add new test for the new ReplacingMergeTree engine
* Limit sign value to -1/1
* Replace sign column(Int8) by is_deleted(UInt8)
* Add new engine to ReplacingMergeTree corresponding to the ReplacingCollapsingMergeTree
* Add new test for the new ReplacingMergeTree engine
* Limit sign value to -1/1
* Replace sign column(Int8) by is_deleted(UInt8)
* Add new engine to ReplacingMergeTree corresponding to the ReplacingCollapsingMergeTree
* Add new test for the new ReplacingMergeTree engine
* Limit sign value to -1/1
* Replace sign column(Int8) by is_deleted(UInt8)
* Add keyword 'CLEANUP' when OPTIMIZE
* Cleanup uniquely when it's a replacingMergeTree
* Propagate CLEANUP information and change from 'with_cleanup' to 'cleanup'
* Cleanup data flagged as 'is_deleted'
* Fix merge when optimize and add a test
* Fix OPTIMIZE and INSERT + add tests
* New fix for cleanup at the merge
* Cleanup debug logs
* Add the SETTINGS option 'clean_deleted_rows' that can be 'never' or 'always'
* Fix regression bug; Now REplicatedMergeTree can be called as before without 'is_deleted'
* Add Replicated tests
* Disable tag 'long' for our test and cleanup some white spaces
* Update tests
* Fix tests and remove additional useless whitespace
* Fix replica test
* Style clean && add condition check for is_deleted values
* clean_deleted_rows settings is nom an enum
* Add valid default value to the clean_deleted_rows settings
* Update cleanup checkers to use the enum and fix typos in the test
* Fix submodule contrib/AMQP-CPP pointer
* Add missing messages in test reference and remove a print with non derterministic order
* fix replica test reference
* Fix edge case
* Fix a typo for the spell checker
* Fix reference
* Fix a condition to raise an error if is_deleted differ from 0/1 and cleanup
* Change tests file name and update number
* This should fix the ReplacingMergeTree parameter set
* Fix replicated parameters
* Disable allow_deprecated_syntax_for_merge_tree for our new column
* Fix a test
* Remove non deterministic order print in the test
* Test on replicas
* Remove a condition, when checking optional parameters, that should not be sueful since we disabled the deprected_syntaxe
* Revert "Remove a condition, when checking optional parameters, that should not be useful since we disabled the deprected_syntaxe"
This reverts commit b65d64c05e
2023-02-16 16:03:16 +03:00
Dmitry Novik
728434821a
Merge remote-tracking branch 'origin/master' into background-memory-tracker
2023-02-16 12:35:07 +00:00
Maksim Kita
b72ea982b0
Remove unnecessary includes of InterpreterSelectQuery header
2023-02-16 12:17:03 +01:00
Maksim Kita
0fe3ba36c4
Analyzer added ParitionPruner support
2023-02-16 12:17:02 +01:00
Maksim Kita
bb56af0e2b
MergeTreeIndexGin crash fix
2023-02-16 12:17:02 +01:00
Maksim Kita
77fee97705
MergeTreeIndexFullText fix prepared set index analysis
2023-02-16 12:17:02 +01:00
Kseniia Sumarokova
947753bd4c
Merge pull request #46409 from kssenii/follow-up-to-46168
...
Follow-up to #46168
2023-02-16 11:26:54 +01:00
Sergei Trifonov
3ad41b29ec
Merge pull request #46247 from ClickHouse/round-robin-merge-scheduler
2023-02-16 08:03:22 +01:00
Alexander Gololobov
cdf3828575
Removed unneeded default value for enable_multiple_prewhere_read_steps
2023-02-15 22:41:55 +01:00
Alexander Gololobov
6936471150
fix include
...
Co-authored-by: Nikita Taranov <nikita.taranov@clickhouse.com>
2023-02-15 22:37:40 +01:00
Alexander Gololobov
8b528739c1
fix typo
...
Co-authored-by: Nikita Taranov <nikita.taranov@clickhouse.com>
2023-02-15 22:37:18 +01:00
Alexander Gololobov
3ff0c7edcc
fix typo
...
Co-authored-by: Nikita Taranov <nikita.taranov@clickhouse.com>
2023-02-15 22:37:04 +01:00
Nikolai Kochetov
f524dae924
Fix more tests.
2023-02-15 19:17:24 +00:00
Dmitry Novik
e7a94a28ee
Merge branch 'master' into background-memory-tracker
2023-02-15 19:39:28 +01:00
Sema Checherinda
dd1b509637
resolve race in getCSNAndAssert
2023-02-15 18:16:39 +01:00
Han Fei
5458d4216f
Merge branch 'master' into dev-prewhere
2023-02-15 17:59:44 +01:00
Alexey Milovidov
77f60311da
Merge branch 'master' into add_select_final_mt_setting
2023-02-15 15:35:37 +03:00
Antonio Andelic
4dd4aac125
Merge branch 'master' into custom-key-parallel-replicas
2023-02-15 11:02:37 +01:00
Robert Schulze
ec33204c05
Merge pull request #46344 from ClickHouse/rs/stabilize-full_text_seaerch_test
...
Try to stabilize test 02346_full_text_search.sql
2023-02-15 10:47:00 +01:00
Alexander Tokmakov
e96340e183
Merge pull request #46410 from ClickHouse/fix_noisy_log_messages
...
Fix noisy log messages
2023-02-15 01:22:42 +03:00
Alexander Tokmakov
8ddbc85919
Merge branch 'master' into followup_revert_39737
2023-02-15 01:15:17 +03:00
Sergei Trifonov
b7a4fa8bd9
Merge branch 'master' into round-robin-merge-scheduler
2023-02-14 20:39:02 +01:00
serxa
a7bbf02bac
fix possible deadlock
2023-02-14 19:37:09 +00:00
Han Fei
937fade982
clean up
2023-02-14 18:54:19 +01:00
Han Fei
86fda9bd22
some clean up
2023-02-14 18:52:09 +01:00
Han Fei
32050acde5
Merge branch 'master' into dev-prewhere
2023-02-14 18:39:13 +01:00
Kseniia Sumarokova
fe155bb210
Merge branch 'master' into follow-up-to-46168
2023-02-14 18:28:46 +01:00
Anton Popov
ecc6ff707b
Merge pull request #46387 from CurtizJ/fix-update-from-empty-nested
...
Fix `ALTER UPDATE` of empty `Nested` columns
2023-02-14 16:28:32 +01:00
kssenii
5bda358fb7
Follow-up to #46168
2023-02-14 15:45:38 +01:00
Alexander Tokmakov
1bf3735ca9
fix noisy log messages
2023-02-14 15:33:27 +01:00
vdimir
abd9119583
Remove unnecessary ProfileEventsScope
2023-02-14 14:11:12 +00:00
vdimir
4c1aeb7972
Use overload of PartLog::addNewPart with profile_events
2023-02-14 14:11:12 +00:00
vdimir
07d7478bc7
wip
2023-02-14 14:11:10 +00:00
vdimir
994dcb93f9
Rename ScopedProfileEvents -> ProfileEventsScope
2023-02-14 14:11:10 +00:00
vdimir
a228f7f419
[wip] ProfileCounters for each part
2023-02-14 14:11:09 +00:00
Alexey Milovidov
f554ff9d99
Remove trash
2023-02-14 14:11:08 +00:00
Nicolae Vartolomei
96e4411694
Fix style
2023-02-14 14:11:07 +00:00
John Skopis
f7604cc686
[feat] Add ProfileEvents map to PartLog
...
closes #10316
2023-02-14 14:11:02 +00:00
Antonio Andelic
adde580756
Merge branch 'master' into custom-key-parallel-replicas
2023-02-14 14:09:12 +01:00
Nikita Taranov
cbd10c4493
Fix mbm with aio on top of query plan ( #45892 )
2023-02-14 14:02:54 +01:00
Robert Schulze
95c50b8653
Address the actual problem (not an optimal approach yet ...)
2023-02-14 12:32:09 +00:00
Sema Checherinda
fba7ee6332
Merge pull request #46347 from CheSema/fix-select-candite-to-check
...
fix candidate selection
2023-02-14 11:18:42 +01:00
Anton Popov
1ab37ad5ed
fix update of empty Nested columns
2023-02-14 02:31:42 +00:00
Alexander Gololobov
d76e4f60a8
Fix for combined node for condition group not found
2023-02-13 23:14:18 +01:00
Nikolai Kochetov
1c0c662fe1
Merge pull request #46275 from ClickHouse/less-mem-usage-for-vertical-merge
...
Less memory usage for vertical merge (non-remote disk)
2023-02-13 21:10:43 +01:00
Alexander Tokmakov
a4d9688775
fix 'Directory not empty after drop' with zero copy replication
2023-02-13 19:35:07 +01:00
Alexander Gololobov
0fe080cc6f
Logger instead of debug prints
2023-02-13 17:43:41 +01:00
Alexander Gololobov
18a29e81fc
Better formatting in PrewhereExprInfo::dump()
2023-02-13 17:42:27 +01:00
Alexander Gololobov
f0011862a9
Move prewhere splitting logic into a separate file
2023-02-13 16:00:03 +01:00
Antonio Andelic
95db6fb1a6
Merge pull request #45659 from ClickHouse/add-support-for-settings-alias
...
Add support for settings aliases/Rename `replication_alter_partitions_sync` to `alter_sync`
2023-02-13 15:31:12 +01:00
Sema Checherinda
a48b6ec612
fix candidate selection
2023-02-13 14:52:55 +01:00
Alexander Tokmakov
69f579b8ec
remove an unused argument
2023-02-13 14:46:46 +01:00
