Robert Schulze
5b036a1a3b
More preparation for libcxx(abi), llvm, clang-tidy 16 (follow-up to #47722 )
2023-03-20 12:55:03 +00:00
Raúl Marín
fb6ce35ea2
Fix ZK exception error message
2023-03-20 13:00:24 +01:00
Alexey Milovidov
ddf29b69f9
Merge branch 'master' into fuzzer-of-data-formats
2023-03-20 03:26:51 +03:00
Alexey Milovidov
e788bf0712
Merge pull request #47721 from ClickHouse/revert-47622-analyzer-planner-fixes-before-enable-by-default
...
Revert "Analyzer planner fixes before enable by default"
2023-03-20 03:24:03 +03:00
Robert Schulze
0e01e912fe
Preparation for libcxx(abi), llvm, clang-tidy 16
2023-03-19 17:25:41 +00:00
Alexey Milovidov
ef5e8462da
Revert "Analyzer planner fixes before enable by default"
2023-03-19 19:25:37 +03:00
Alexey Milovidov
a99f10e16f
Better error messages
2023-03-19 05:34:44 +01:00
Alexander Tokmakov
f1df91cd09
Merge pull request #47659 from ClickHouse/fix_993
...
Fixes for 993 and friends
2023-03-18 14:46:43 +03:00
Maksim Kita
5187138510
Merge pull request #47622 from kitaisreal/analyzer-planner-fixes-before-enable-by-default
...
Analyzer planner fixes before enable by default
2023-03-18 13:11:40 +03:00
Sema Checherinda
0b641fcead
Merge pull request #47564 from CheSema/remove-redundant
...
remove counters for threads, fix negative counters
2023-03-18 02:23:52 +01:00
Han Fei
722e6bb2e8
Merge pull request #47680 from ClickHouse/rs/uncruftify-build
...
CMake: Remove further cruft from build
2023-03-17 22:58:46 +01:00
Alexander Tokmakov
d11aee2b0c
Merge branch 'master' into fix_993
2023-03-17 21:28:23 +03:00
alesapin
e45b558a86
Merge pull request #47676 from ClickHouse/fix_zero_copy_lock_check
...
Fix zero copy lock check
2023-03-17 17:51:14 +01:00
alesapin
1022c47421
Review fixes
2023-03-17 17:45:02 +01:00
Antonio Andelic
79cff0a14b
Merge branch 'master' into cnf-new-analyzer
2023-03-17 14:37:40 +00:00
Robert Schulze
f72a337074
Remove cruft from build
...
No need to check compiler flags, clang >= 15 supports all of them.
2023-03-17 13:44:04 +00:00
Antonio Andelic
0fb9f9ffe6
Add support for substitute column
2023-03-17 13:38:01 +00:00
Maksim Kita
2d2696bc20
Fixed code review issues
2023-03-17 14:34:23 +01:00
alesapin
e44fca8bb9
Add test
2023-03-17 12:56:31 +01:00
Sergei Trifonov
1a84203c7f
Merge pull request #47656 from ClickHouse/background_pool_limit_metric
...
Add background pools size metrics
2023-03-17 11:49:53 +01:00
alesapin
4a80197f16
Merge branch 'master' into fix_zero_copy_lock_check
2023-03-17 11:18:51 +01:00
alesapin
efa0622a84
Merge pull request #47631 from ClickHouse/fix_wait_for_zero_copy_lock
...
Fix wait for zero copy lock during move
2023-03-17 11:15:55 +01:00
Sergei Trifonov
2cbd91b852
Merge branch 'master' into background_pool_limit_metric
2023-03-16 23:23:42 +01:00
alesapin
3731567b6a
Bad code
2023-03-16 21:48:47 +01:00
Robert Schulze
02a2c73bae
Merge pull request #47607 from save-my-heart/inverted_index
...
checksum: do not check inverted index files
2023-03-16 21:34:17 +01:00
Alexander Tokmakov
d621b2c4ad
fix intersecting parts, better fault injections
2023-03-16 21:28:07 +01:00
alesapin
92eb6685c6
Fix lock check
2023-03-16 20:17:29 +01:00
Sema Checherinda
3c6deddd1d
work with comments on PR
2023-03-16 19:55:58 +01:00
serxa
3ad7194e31
add pool size metrics
2023-03-16 17:31:41 +00:00
Antonio Andelic
985a0285c7
Merge branch 'master' into cnf-new-analyzer
2023-03-16 16:00:51 +00:00
Alexander Tokmakov
8b8215f91a
fix some other tests, add logs for further debugging
2023-03-16 16:40:08 +01:00
Antonio Andelic
0f6e4d3934
Start implementing constraint optimizer
2023-03-16 09:30:55 +00:00
alesapin
fc913649cf
Check only for interactive moves
2023-03-15 22:51:53 +01:00
alesapin
ef7508469c
Fix wait for zero-copy replication move during manual move
2023-03-15 22:29:24 +01:00
Maksim Kita
c102adb728
Analyzer added PREWHERE support
2023-03-15 15:21:49 +01:00
save-my-heart
b7d9d721fb
add test
2023-03-15 21:01:12 +08:00
Vitaly Baranov
00c05f7f8b
Merge pull request #47546 from vitlibar/use-server-side-copy-for-restore
...
Use server-side copy for restore from S3 to S3.
2023-03-15 11:28:29 +01:00
save-my-heart
d70c352313
checksum: do not check inverted index files
2023-03-15 16:43:59 +08:00
Alexander Tokmakov
5a1ee881f8
Merge pull request #47547 from ClickHouse/filter_too_frequent_logs
...
Hide too noisy log messages, fix some tests
2023-03-14 13:53:21 +03:00
Michael Kolupaev
d3a514d221
Compress marks in memory
2023-03-13 16:29:00 -07:00
Alexander Tokmakov
ba6c6255a3
hide too noisy log messages, fix some tests
2023-03-14 00:23:36 +01:00
Vitaly Baranov
1cf1ce07fe
Use server-side copy during restore from S3 to S3.
2023-03-13 23:50:13 +01:00
Nikolai Kochetov
669a92bae0
Merge branch 'master' into aggregate-projections-analysis-query-plan
2023-03-13 19:55:49 +01:00
alesapin
8db0d26519
Merge branch 'master' into revert-46909-revert-45911-mutations_rename_hang
2023-03-13 14:48:20 +01:00
Alexey Milovidov
218ac10425
More detailed error messages on too many parts
2023-03-11 21:44:38 +01:00
Maksim Kita
114d30d2bb
Merge pull request #47383 from kitaisreal/analyzer-planner-fixes-before-enable-by-default
...
Analyzer planner fixes before enable by default
2023-03-11 22:09:04 +03:00
Maksim Kita
3d34247998
Fixed tests
2023-03-11 11:51:54 +01:00
Maksim Kita
0358cb36d8
Fixed tests
2023-03-11 11:51:54 +01:00
Alexander Tokmakov
6e7ffd9a7b
Update ReplicatedMergeTreeAttachThread.cpp
2023-03-11 00:45:09 +03:00
Dmitry Novik
4f24a7bd11
Merge remote-tracking branch 'origin/master' into background-memory-tracker
2023-03-10 18:57:45 +00:00
Anton Popov
66a113ca61
Merge pull request #47384 from CurtizJ/fix-clear-column-with-sparse
...
Fix `ALTER CLEAR COLUMN` with sparse columns
2023-03-09 16:57:23 +01:00
alesapin
588cc0f159
Merge branch 'master' into revert-46909-revert-45911-mutations_rename_hang
2023-03-09 14:54:10 +01:00
Anton Popov
c3b9af96c4
fix ALTER CLEAR COLUMN with sparse columns
2023-03-08 17:19:04 +00:00
Antonio Andelic
a04b38db90
Merge pull request #45108 from ClickHouse/custom-key-parallel-replicas
...
Add support for custom key in parallel replicas
2023-03-08 17:46:11 +01:00
Alexander Tokmakov
38f9f08e1a
Merge pull request #47268 from myrrc/improvement/more-to-base-3
...
use std::lerp, constexpr hex.h
2023-03-08 19:07:34 +03:00
alesapin
4423be8332
Merge branch 'master' into revert-46909-revert-45911-mutations_rename_hang
2023-03-08 12:59:07 +01:00
Antonio Andelic
816a9c1099
Merge branch 'master' into custom-key-parallel-replicas
2023-03-08 11:06:30 +01:00
Alexey Milovidov
e8cdb0c8b1
Merge pull request #46839 from CurtizJ/fix-crash-in-skip-index
...
Do not allow const and non-deterministic secondary indexes
2023-03-08 03:03:09 +03:00
Alexey Milovidov
e2aff59a2d
Merge pull request #47106 from kssenii/allow-nested-disks-in-custom-disks
...
Allow nested custom disks
2023-03-08 03:00:55 +03:00
Mike Kot
9920a52c51
use std::lerp, constexpr hex.h
2023-03-07 22:50:17 +00:00
Antonio Andelic
d098891185
Skip merges if no need
2023-03-07 13:08:56 +00:00
Antonio Andelic
35c15e6ef8
Merge branch 'master' into custom-key-parallel-replicas
2023-03-07 09:37:38 +00:00
Vladimir C
1455e7602d
Merge pull request #47154 from azat/prewhere-columns-fix
2023-03-06 10:03:31 +01:00
Anton Popov
6f3e4d4137
Merge pull request #46118 from CurtizJ/fix-issues-with-sparse
...
Randomize setting `ratio_of_defaults_for_sparse_serialization`
2023-03-05 22:28:18 +01:00
Robert Schulze
10753481f9
Merge pull request #47242 from ClickHouse/rs/docs-index-support-has-hasall-hasany
...
Docs: Update index support of has(), hasAny(), hasAll()
2023-03-04 18:49:24 +01:00
Robert Schulze
11930ad685
Docs: Update index support of has(), hasAny(), hasAll()
2023-03-04 17:27:47 +00:00
Anton Popov
9389cc29da
better mutations of sparse columns
2023-03-03 16:52:01 +00:00
Antonio Andelic
737cf8e149
Better
2023-03-03 15:14:49 +00:00
Sema Checherinda
7a9f4aab8e
do not call adjustWithUntrackedMemory when untracked_memory is 0
2023-03-02 19:21:03 +01:00
alesapin
63f615cdcd
Fix metadata version
2023-03-02 19:17:18 +01:00
Azat Khuzhin
167e4903a8
Fix concrete columns PREWHERE support
...
This is the fix for the IStorage::supportedPrewhereColumns() API.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-02 18:51:23 +01:00
Anton Popov
fdf8a418f5
better interface
2023-03-02 14:46:26 +00:00
Antonio Andelic
01cf9c94f4
Merge branch 'master' into custom-key-parallel-replicas
2023-03-02 14:28:42 +00:00
Robert Schulze
740aeaba1f
Apply some CTAD
2023-03-02 13:36:47 +00:00
kssenii
2883861795
Merge remote-tracking branch 'upstream/master' into allow-nested-disks-in-custom-disks
2023-03-02 14:30:58 +01:00
alesapin
915b4ea56a
Merge branch 'master' into revert-46909-revert-45911-mutations_rename_hang
2023-03-02 14:29:21 +01:00
alesapin
db0f9b6578
Fix one more bug
2023-03-02 14:26:07 +01:00
alesapin
189836307c
Merge branch 'revert-46909-revert-45911-mutations_rename_hang' of github.com:ClickHouse/ClickHouse into revert-46909-revert-45911-mutations_rename_hang
2023-03-02 12:49:06 +01:00
Alexey Milovidov
97c0f8a0e0
Merge pull request #47027 from amosbird/clang16
...
Prepare to build with clang 16
2023-03-02 02:10:03 +03:00
Anton Popov
c4a999ce29
Merge remote-tracking branch 'upstream/master' into HEAD
2023-03-01 19:33:16 +00:00
alesapin
46f25d53b3
Merge branch 'master' into revert-46909-revert-45911-mutations_rename_hang
2023-03-01 20:09:12 +01:00
kssenii
f3e3b916c9
Allow nested custom disks
2023-03-01 19:55:59 +01:00
alesapin
ebba37b18f
Merge pull request #47010 from ClickHouse/zero_copy_fetch
...
Fix bug in zero-copy replication disk choice during fetch
2023-03-01 15:55:00 +01:00
alesapin
b7370865a7
Merge pull request #47032 from ClickHouse/fix_message_for_zero_copy
...
Better exception message when move was unseccessful
2023-03-01 15:26:53 +01:00
alesapin
d72c310faa
Update src/Storages/MergeTree/MergeTreeData.cpp
...
Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>
2023-03-01 11:54:22 +01:00
alesapin
8ff77c89eb
Update src/Storages/MergeTree/MergeTreeData.cpp
...
Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>
2023-03-01 11:50:35 +01:00
alesapin
be5ef666ba
Update src/Storages/MergeTree/MergeTreeData.cpp
...
Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>
2023-03-01 11:50:29 +01:00
alesapin
5de8a8e776
Update src/Storages/MergeTree/MergeTreeData.cpp
...
Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>
2023-03-01 11:50:23 +01:00
Alexey Milovidov
fe446afb7d
Increase max_replicated_merges_in_queue
2023-03-01 06:02:59 +01:00
Amos Bird
c0fb4ddc3e
Make thread analyzer happy
2023-03-01 11:07:36 +08:00
alesapin
c0f28ace51
Better
2023-02-28 17:52:21 +01:00
alesapin
abd6500ee3
Better exception message when move was unseccessful
2023-02-28 17:49:16 +01:00
alesapin
bb7571427b
Fix bug in zero-copy replica disk choice during fetch
2023-02-28 14:48:46 +01:00
alesapin
967a47d870
Fix bug with readonly storages
2023-02-28 12:17:43 +01:00
Alexey Milovidov
29da7fc965
Decrease log level in "disks"
2023-02-27 17:48:38 +01:00
Anton Popov
caa1d22759
Merge branch 'master' into fix-issues-with-sparse
2023-02-27 15:25:19 +01:00
alesapin
7adbe93105
Remove strange part
2023-02-27 14:48:47 +01:00
Robert Schulze
6f0709032d
Merge pull request #46921 from ClickHouse/rs/inv-idx-checksum
...
A better alternative to #46344
2023-02-27 14:44:44 +01:00
alesapin
9dec64c94c
Choose correct version for mutation
2023-02-27 14:35:26 +01:00
Nikolai Kochetov
3392b96cc3
Merge branch 'master' into aggregate-projections-analysis-query-plan
2023-02-27 14:07:04 +01:00
alesapin
e3961c118a
Revert "Revert "Fix several RENAME COLUMN bugs.""
2023-02-27 12:27:57 +01:00
Robert Schulze
4c9b9b362c
Replace dynamic_cast by typeid_cast
2023-02-27 10:01:21 +00:00
Robert Schulze
cc0c0c6133
A better alternative to #46344
...
The (experimental) inverted index writes/reads files different from the
standard files written by the other skip indexes. The original problem
was that with database engine "ordinary", DROP TABLE of a table with
inverted index finds unknown files in persistence and complains. The
same will happen with engine "atomic" but deferred. As a hotfix, the
error was silenced by explicitly adding the four files created in a
specific test to the deletion code.
This PR tries a cleaner solution where all needed files are provided via
the normal checksum structure. One drawback remains which is that the
affected files were written earlier and we don't have their checksums
available. Therefore, the inverted index is currently excluded from
CHECK TABLE.
Minimal repro:
SET allow_experimental_inverted_index = 1;
DROP TABLE IF EXISTS tab;
CREATE TABLE tab(s String, INDEX af(s) TYPE inverted(2)) ENGINE = MergeTree() ORDER BY s;
INSERT INTO tab VALUES ('Alick a01');
CHECK TABLE tab;
DROP TABLE IF EXISTS tab;
run ./clickhouse-test with --db-engine Ordinary
2023-02-26 21:06:38 +00:00
Alexey Milovidov
73aec86f5a
Change exception message
2023-02-26 21:36:26 +01:00
Alexey Milovidov
8f40bbd5b4
Revert "Fix several RENAME COLUMN bugs."
2023-02-26 05:47:05 +03:00
Alexey Milovidov
eb89ab471f
Merge pull request #45911 from ClickHouse/mutations_rename_hang
...
Fix several `RENAME COLUMN` bugs.
2023-02-26 01:56:40 +03:00
Alexey Milovidov
656af55831
Merge pull request #46384 from ClickHouse/fixes_for_993
...
Fixes for 993
2023-02-26 01:55:20 +03:00
Anton Popov
3a947ecddc
do not allow const and non-deterministic secondary indexes
2023-02-24 19:17:44 +00:00
Alexander Tokmakov
ca1c793cac
Merge pull request #46820 from Algunenano/avoid_KeeperMultiException_system_errors
...
Don't report ZK node exists to system.errors when a block was created concurrently by a different replica
2023-02-24 19:42:32 +03:00
Alexander Gololobov
b43b98f7c0
Merge pull request #46785 from ClickHouse/fix_combined_prewhere_column
...
Fix combined PREWHERE column accumulated from multiple steps
2023-02-24 14:00:17 +01:00
Raúl Marín
7ff8d2d3d5
Don't report ZK node exists to system.errors
2023-02-24 12:36:29 +01:00
Anton Popov
d926713cf5
Merge remote-tracking branch 'upstream/master' into HEAD
2023-02-23 23:04:22 +00:00
Anton Popov
5e5e802348
return back optimization for ALTER MODIFY Nullable
2023-02-23 22:55:47 +00:00
Alexander Gololobov
47f51fe187
Merge pull request #46771 from ClickHouse/fix_prewhere_logging
...
More concise logging at trace level for PREWHERE steps
2023-02-23 20:20:30 +01:00
Alexander Gololobov
8b22373488
Apply filter at last step if it has been accumulated from multiple steps
2023-02-23 16:58:28 +01:00
Alexander Gololobov
cbcb1a7852
More concise logging at trace level
2023-02-23 13:31:56 +01:00
Kseniia Sumarokova
30a8eb0c2f
Merge pull request #46670 from kssenii/hide-disk-setting
...
Hide arguments of custom disk merge tree setting
2023-02-23 11:42:53 +01:00
Alexey Milovidov
c0bc549e77
Merge pull request #46709 from azat/bg-pool-no-query
...
BackgroundSchedulePool should not have any query context
2023-02-23 10:24:46 +03:00
Alexander Gololobov
67dcd9694c
Remove unused MergeTreeReadTask::remove_prewhere_column
2023-02-22 17:49:22 +01:00
kssenii
c4761d6cc6
Fix checks
2023-02-22 14:27:43 +01:00
Azat Khuzhin
2ca47a6eb6
BackgroundSchedulePool should not have any query context
...
BackgroundSchedulePool is used for some peridic jobs, not from the query
context, i.e. flush of Buffer table.
And for such jobs there cannot be any query context, and more
importantly it will not work correctly since that query_context will
eventually expires.
And this is the reason of this failures [1].
[1]: https://s3.amazonaws.com/clickhouse-test-reports/46668/015991bc5e20c787851050c2eaa13f0fef3aac00/stateless_tests_flaky_check__asan_.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-22 10:50:51 +01:00
Alexander Gololobov
b61bb56a5a
Merge pull request #46611 from ClickHouse/prewhere_progress
...
Fix reporting progress when rows are filtered in PREWHERE
2023-02-21 21:27:56 +01:00
Alexey Milovidov
848286eca7
Merge pull request #40945 from arthurpassos/add_select_final_mt_setting
...
Add user setting to force select final at query level
2023-02-21 19:58:45 +03:00
Nikolai Kochetov
c5f93eb108
Fix more tests.
2023-02-21 15:44:50 +00:00
Anton Popov
b66a5bdcf0
fix mutations with sparse columns
2023-02-21 15:13:29 +00:00
Alexander Gololobov
5354b0d069
Merge pull request #46140 from ClickHouse/split_prewhere_dag
...
Split PREWHERE DAG into multiple read steps
2023-02-21 14:37:09 +01:00
Vladimir C
a791250a4a
Merge pull request #38614 from bharatnc/ncb/profile-events-partlog
2023-02-21 11:06:44 +01:00
Kruglov Pavel
b0424c1021
Merge pull request #46171 from Avogar/insert-null-as-default
...
Use default of column type in `insert_null_as_default` if column DEFAULT values is not specified
2023-02-20 21:45:02 +01:00
Nikolai Kochetov
ee597b939f
Merge branch 'master' into aggregate-projections-analysis-query-plan
2023-02-20 19:46:52 +00:00
Arthur Passos
4f2fcf763b
Merge branch 'master' into add_select_final_mt_setting
2023-02-20 16:22:14 -03:00
Alexander Gololobov
c84a64d22f
Return chunks with 0 rows from MergeTreeSource to report progress when rows are filtered in PREWHERE
2023-02-20 17:35:01 +01:00
Nikolai Kochetov
84e442e620
Fixing build and style.
2023-02-20 14:21:20 +00:00
Nikolai Kochetov
2a8460d962
Merge branch 'master' into aggregate-projections-analysis-query-plan
2023-02-20 13:54:05 +01:00
Alexey Milovidov
d8cda3dbb8
Remove PVS-Studio
2023-02-19 23:30:05 +01:00
Arthur Passos
3d9b23e5f3
Merge branch 'master' into add_select_final_mt_setting
2023-02-19 15:01:41 -03:00
Alexander Gololobov
520b381675
Fixes for executing actions on block with unknown row count
2023-02-19 12:14:23 +01:00
Maksim Kita
6dffe52e68
Merge pull request #46471 from kitaisreal/analyzer-planner-fixes-before-enable-by-default
...
Analyzer planner fixes before enable by default
2023-02-19 13:49:18 +03:00
Alexander Gololobov
0ed0b191f8
Fix for Nullable step filter column
2023-02-18 19:12:32 +01:00
Alexander Gololobov
88fb6c3c25
Fix for incorrect combined PREWHERE column
2023-02-18 18:29:16 +01:00
Kseniia Sumarokova
b0ea047e76
Merge pull request #46533 from kssenii/fix-disk-setting
...
Allow `disk` merge tree setting in query to override config merge tree setting `storage_policy`
2023-02-18 12:36:54 +01:00
kssenii
afb36dd120
Allow disk setting to override storage_policy from config merge tree settings insteaf of exception
2023-02-17 17:11:29 +01:00
Antonio Andelic
ab51c1d975
Merge branch 'master' into custom-key-parallel-replicas
2023-02-17 15:06:41 +01:00
kssenii
bae85c50e9
Fix stress test
2023-02-17 12:40:17 +01:00
Alexander Tokmakov
9a664efeb6
Merge branch 'master' into fixes_for_993
2023-02-17 14:17:08 +03:00
Sema Checherinda
b551b9fb3a
Merge pull request #46452 from CheSema/resolve-race-get-csn
...
resolve race in getCSNAndAssert
2023-02-17 11:31:58 +01:00
Dmitry Novik
0336f0d8cc
Merge branch 'master' into background-memory-tracker
2023-02-16 20:57:44 +01:00
Arthur Passos
ba6b7b1610
fix test_alias_column
2023-02-16 16:01:25 -03:00
Alexander Gololobov
a6061e022e
Merge branch 'master' into split_prewhere_dag
2023-02-16 14:43:58 +01:00
youennL-cs
6526c2a8ab
[RFC] Replacing merge tree new engine ( #41005 )
...
* Add new engine to ReplacingMergeTree corresponding to the ReplacingCollapsingMergeTree
* Add new test for the new ReplacingMergeTree engine
* Limit sign value to -1/1
* Add new engine to ReplacingMergeTree corresponding to the ReplacingCollapsingMergeTree
* Add new test for the new ReplacingMergeTree engine
* Limit sign value to -1/1
* Replace sign column(Int8) by is_deleted(UInt8)
* Add new engine to ReplacingMergeTree corresponding to the ReplacingCollapsingMergeTree
* Add new test for the new ReplacingMergeTree engine
* Limit sign value to -1/1
* Replace sign column(Int8) by is_deleted(UInt8)
* Add new engine to ReplacingMergeTree corresponding to the ReplacingCollapsingMergeTree
* Add new test for the new ReplacingMergeTree engine
* Limit sign value to -1/1
* Replace sign column(Int8) by is_deleted(UInt8)
* Add keyword 'CLEANUP' when OPTIMIZE
* Cleanup uniquely when it's a replacingMergeTree
* Propagate CLEANUP information and change from 'with_cleanup' to 'cleanup'
* Cleanup data flagged as 'is_deleted'
* Fix merge when optimize and add a test
* Fix OPTIMIZE and INSERT + add tests
* New fix for cleanup at the merge
* Cleanup debug logs
* Add the SETTINGS option 'clean_deleted_rows' that can be 'never' or 'always'
* Fix regression bug; Now REplicatedMergeTree can be called as before without 'is_deleted'
* Add Replicated tests
* Disable tag 'long' for our test and cleanup some white spaces
* Update tests
* Fix tests and remove additional useless whitespace
* Fix replica test
* Style clean && add condition check for is_deleted values
* clean_deleted_rows settings is nom an enum
* Add valid default value to the clean_deleted_rows settings
* Update cleanup checkers to use the enum and fix typos in the test
* Fix submodule contrib/AMQP-CPP pointer
* Add missing messages in test reference and remove a print with non derterministic order
* fix replica test reference
* Fix edge case
* Fix a typo for the spell checker
* Fix reference
* Fix a condition to raise an error if is_deleted differ from 0/1 and cleanup
* Change tests file name and update number
* This should fix the ReplacingMergeTree parameter set
* Fix replicated parameters
* Disable allow_deprecated_syntax_for_merge_tree for our new column
* Fix a test
* Remove non deterministic order print in the test
* Test on replicas
* Remove a condition, when checking optional parameters, that should not be sueful since we disabled the deprected_syntaxe
* Revert "Remove a condition, when checking optional parameters, that should not be useful since we disabled the deprected_syntaxe"
This reverts commit b65d64c05e
2023-02-16 16:03:16 +03:00
Dmitry Novik
728434821a
Merge remote-tracking branch 'origin/master' into background-memory-tracker
2023-02-16 12:35:07 +00:00
Maksim Kita
b72ea982b0
Remove unnecessary includes of InterpreterSelectQuery header
2023-02-16 12:17:03 +01:00
Maksim Kita
0fe3ba36c4
Analyzer added ParitionPruner support
2023-02-16 12:17:02 +01:00
Maksim Kita
bb56af0e2b
MergeTreeIndexGin crash fix
2023-02-16 12:17:02 +01:00
Maksim Kita
77fee97705
MergeTreeIndexFullText fix prepared set index analysis
2023-02-16 12:17:02 +01:00
Kseniia Sumarokova
947753bd4c
Merge pull request #46409 from kssenii/follow-up-to-46168
...
Follow-up to #46168
2023-02-16 11:26:54 +01:00
Sergei Trifonov
3ad41b29ec
Merge pull request #46247 from ClickHouse/round-robin-merge-scheduler
2023-02-16 08:03:22 +01:00
Alexander Gololobov
cdf3828575
Removed unneeded default value for enable_multiple_prewhere_read_steps
2023-02-15 22:41:55 +01:00
Alexander Gololobov
6936471150
fix include
...
Co-authored-by: Nikita Taranov <nikita.taranov@clickhouse.com>
2023-02-15 22:37:40 +01:00
Alexander Gololobov
8b528739c1
fix typo
...
Co-authored-by: Nikita Taranov <nikita.taranov@clickhouse.com>
2023-02-15 22:37:18 +01:00
Alexander Gololobov
3ff0c7edcc
fix typo
...
Co-authored-by: Nikita Taranov <nikita.taranov@clickhouse.com>
2023-02-15 22:37:04 +01:00
Nikolai Kochetov
f524dae924
Fix more tests.
2023-02-15 19:17:24 +00:00
Dmitry Novik
e7a94a28ee
Merge branch 'master' into background-memory-tracker
2023-02-15 19:39:28 +01:00
Sema Checherinda
dd1b509637
resolve race in getCSNAndAssert
2023-02-15 18:16:39 +01:00
Han Fei
5458d4216f
Merge branch 'master' into dev-prewhere
2023-02-15 17:59:44 +01:00
Alexey Milovidov
77f60311da
Merge branch 'master' into add_select_final_mt_setting
2023-02-15 15:35:37 +03:00
Antonio Andelic
4dd4aac125
Merge branch 'master' into custom-key-parallel-replicas
2023-02-15 11:02:37 +01:00
Robert Schulze
ec33204c05
Merge pull request #46344 from ClickHouse/rs/stabilize-full_text_seaerch_test
...
Try to stabilize test 02346_full_text_search.sql
2023-02-15 10:47:00 +01:00
Alexander Tokmakov
e96340e183
Merge pull request #46410 from ClickHouse/fix_noisy_log_messages
...
Fix noisy log messages
2023-02-15 01:22:42 +03:00
Alexander Tokmakov
8ddbc85919
Merge branch 'master' into followup_revert_39737
2023-02-15 01:15:17 +03:00
Sergei Trifonov
b7a4fa8bd9
Merge branch 'master' into round-robin-merge-scheduler
2023-02-14 20:39:02 +01:00
serxa
a7bbf02bac
fix possible deadlock
2023-02-14 19:37:09 +00:00
Han Fei
937fade982
clean up
2023-02-14 18:54:19 +01:00
Han Fei
86fda9bd22
some clean up
2023-02-14 18:52:09 +01:00
Han Fei
32050acde5
Merge branch 'master' into dev-prewhere
2023-02-14 18:39:13 +01:00
Kseniia Sumarokova
fe155bb210
Merge branch 'master' into follow-up-to-46168
2023-02-14 18:28:46 +01:00
Anton Popov
ecc6ff707b
Merge pull request #46387 from CurtizJ/fix-update-from-empty-nested
...
Fix `ALTER UPDATE` of empty `Nested` columns
2023-02-14 16:28:32 +01:00
kssenii
5bda358fb7
Follow-up to #46168
2023-02-14 15:45:38 +01:00
Alexander Tokmakov
1bf3735ca9
fix noisy log messages
2023-02-14 15:33:27 +01:00
vdimir
abd9119583
Remove unnecessary ProfileEventsScope
2023-02-14 14:11:12 +00:00
vdimir
4c1aeb7972
Use overload of PartLog::addNewPart with profile_events
2023-02-14 14:11:12 +00:00
vdimir
07d7478bc7
wip
2023-02-14 14:11:10 +00:00
vdimir
994dcb93f9
Rename ScopedProfileEvents -> ProfileEventsScope
2023-02-14 14:11:10 +00:00
vdimir
a228f7f419
[wip] ProfileCounters for each part
2023-02-14 14:11:09 +00:00
Alexey Milovidov
f554ff9d99
Remove trash
2023-02-14 14:11:08 +00:00
Nicolae Vartolomei
96e4411694
Fix style
2023-02-14 14:11:07 +00:00
John Skopis
f7604cc686
[feat] Add ProfileEvents map to PartLog
...
closes #10316
2023-02-14 14:11:02 +00:00
Antonio Andelic
adde580756
Merge branch 'master' into custom-key-parallel-replicas
2023-02-14 14:09:12 +01:00
Nikita Taranov
cbd10c4493
Fix mbm with aio on top of query plan ( #45892 )
2023-02-14 14:02:54 +01:00
Robert Schulze
95c50b8653
Address the actual problem (not an optimal approach yet ...)
2023-02-14 12:32:09 +00:00
Sema Checherinda
fba7ee6332
Merge pull request #46347 from CheSema/fix-select-candite-to-check
...
fix candidate selection
2023-02-14 11:18:42 +01:00
Anton Popov
1ab37ad5ed
fix update of empty Nested columns
2023-02-14 02:31:42 +00:00
Alexander Gololobov
d76e4f60a8
Fix for combined node for condition group not found
2023-02-13 23:14:18 +01:00
Nikolai Kochetov
1c0c662fe1
Merge pull request #46275 from ClickHouse/less-mem-usage-for-vertical-merge
...
Less memory usage for vertical merge (non-remote disk)
2023-02-13 21:10:43 +01:00
Alexander Tokmakov
a4d9688775
fix 'Directory not empty after drop' with zero copy replication
2023-02-13 19:35:07 +01:00
Alexander Gololobov
0fe080cc6f
Logger instead of debug prints
2023-02-13 17:43:41 +01:00
Alexander Gololobov
18a29e81fc
Better formatting in PrewhereExprInfo::dump()
2023-02-13 17:42:27 +01:00
Alexander Gololobov
f0011862a9
Move prewhere splitting logic into a separate file
2023-02-13 16:00:03 +01:00
Antonio Andelic
95db6fb1a6
Merge pull request #45659 from ClickHouse/add-support-for-settings-alias
...
Add support for settings aliases/Rename `replication_alter_partitions_sync` to `alter_sync`
2023-02-13 15:31:12 +01:00
Sema Checherinda
a48b6ec612
fix candidate selection
2023-02-13 14:52:55 +01:00
Alexander Tokmakov
69f579b8ec
remove an unused argument
2023-02-13 14:46:46 +01:00
Alexander Gololobov
39e4ca9850
Cleanup
2023-02-13 14:40:54 +01:00
Alexander Gololobov
c39cfee954
Properly set "remove" flag for step prewhere_columns when they are used in futher steps
2023-02-13 14:11:18 +01:00
Alexander Gololobov
3060bee18a
Properly handle constants in multiple steps
2023-02-13 12:58:33 +01:00
Alexey Milovidov
9be1bba92f
Merge pull request #46310 from ClickHouse/replicas_status_remove_mutex
...
Remove mutex from replicas_status
2023-02-13 13:36:11 +03:00
Antonio Andelic
8d16fe5793
Merge branch 'master' into add-support-for-settings-alias
2023-02-13 08:46:00 +01:00
Alexander Gololobov
a89465d1cb
Fix build after merge
2023-02-12 22:48:28 +01:00
Alexander Gololobov
3ad0683de9
Refactor DAG splitting into steps
2023-02-12 21:55:53 +01:00
Alexander Gololobov
12e576cddb
Slight refactoring
2023-02-12 21:55:53 +01:00
Alexander Gololobov
8fc08c74f0
Pass action_settings to getReadTaskColumns()
2023-02-12 21:55:53 +01:00
Alexander Gololobov
e460d53619
Use different name when filter column is CASTed to UInt8
2023-02-12 21:55:41 +01:00
Alexander Gololobov
7634b9f56e
Added settings to enable the new logic
2023-02-12 21:54:23 +01:00
Alexander Gololobov
120b112743
Cleanup
2023-02-12 21:54:23 +01:00
Alexander Gololobov
31f5dbe2a3
Cast intermediate step result to Bool if needed
2023-02-12 21:54:23 +01:00
Alexander Gololobov
1b207d9fa0
Fix for overwritten row level filter step
2023-02-12 21:54:23 +01:00
Alexander Gololobov
249e670c9f
Properly preserve columns that are required by next steps
2023-02-12 21:54:23 +01:00
Alexander Gololobov
45ef2f6d60
Split prewhere actions into separate conjuctive steps
2023-02-12 21:54:23 +01:00
alesapin
1683cd5d6f
Merge branch 'master' into mutations_rename_hang
2023-02-12 13:06:48 +01:00
Alexey Milovidov
b8cbc947ce
Remove mutex from replicas_status
2023-02-12 07:39:16 +01:00
Alexey Milovidov
5f00bc49f8
Merge branch 'master' into addParts
2023-02-12 05:55:18 +03:00
Alexey Milovidov
a97f9b2caf
Update MergeTreeData.cpp
2023-02-12 05:55:07 +03:00
Alexey Milovidov
395d6b6bd5
Merge pull request #46282 from CurtizJ/return-back-vertical-merges
...
Allow vertical merges from compact to wide parts [2]
2023-02-12 05:51:12 +03:00
serxa
df6b4c4372
fix typo
2023-02-11 20:18:19 +00:00
serxa
9a7f70f595
fix comment
2023-02-11 16:54:57 +00:00
serxa
eb8cf6f816
Merge branch 'round-robin-merge-scheduler' of github.com:ClickHouse/ClickHouse into round-robin-merge-scheduler
2023-02-11 16:45:55 +00:00
serxa
d2f8377c47
fix check
2023-02-11 16:45:45 +00:00
Sergei Trifonov
297587531b
Merge branch 'master' into round-robin-merge-scheduler
2023-02-11 17:19:27 +01:00
serxa
c58b165b0f
add config option to select scheduling policy
2023-02-11 16:18:42 +00:00
alesapin
5c83ddabf9
Merge branch 'master' into mutations_rename_hang
2023-02-11 12:18:58 +01:00
kssenii
3067c1d723
Merge remote-tracking branch 'upstream/master' into resubmit-prefetches
2023-02-11 11:36:23 +01:00
Sergei Trifonov
fbedf4d520
Merge branch 'master' into round-robin-merge-scheduler
2023-02-11 10:30:26 +01:00
kssenii
3545568440
Fix build
2023-02-10 22:15:44 +01:00
Kseniia Sumarokova
3be36c7979
Merge pull request #41976 from kssenii/allow-single-disk-instead-of-storage-policy
...
Allow configuring storage as `SETTINGS disk='<disk_name>'` (instead of `storage_policy`) and explicit disk creation `SETTINGS disk=disk(<disk_configuration>)`
2023-02-10 21:38:50 +01:00
Anton Popov
1205932a19
add setting to disable vertical merges from compact parts
2023-02-10 16:33:46 +00:00
kssenii
468d5216da
Remove logging because of test 00002_log_and_exception_messages_formatting
2023-02-10 17:25:26 +01:00
Anton Popov
a252d3a139
Revert "Merge pull request #46236 from ClickHouse/revert-45681-compact-parts-vertical-merge"
...
This reverts commit 27bc317ef9ccf7b6f4c1
2023-02-10 14:13:29 +00:00
Anton Popov
27bc317ef9
Merge pull request #46236 from ClickHouse/revert-45681-compact-parts-vertical-merge
...
Revert "Allow vertical merges from compact to wide parts"
2023-02-10 14:31:33 +01:00
alesapin
808a939ad2
Small rehacktoing
2023-02-10 14:25:19 +01:00
KitKatKKK
d31457de44
Update src/Storages/MergeTree/MergeTreeData.cpp
...
Co-authored-by: flynn <fenglv15@mails.ucas.ac.cn>
2023-02-10 21:14:42 +08:00
KitKatKKK
7664114349
Update src/Storages/MergeTree/MergeTreeData.cpp
...
Co-authored-by: flynn <fenglv15@mails.ucas.ac.cn>
2023-02-10 21:14:33 +08:00
kssenii
571aabdb69
Fix clang-tidy
2023-02-10 12:39:05 +01:00
Nikolai Kochetov
8c22c740a4
Merge pull request #46205 from ClickHouse/fix-write-buffer-destruction-order-for-vertical-merge
...
Fix write buffer destruction order for vertical merge.
2023-02-10 11:47:23 +01:00
KitKatKKK
ea300ce13b
Merge branch 'master' into addParts
2023-02-10 16:48:04 +08:00
KitKatKKK
fa73b00a66
Update src/Storages/MergeTree/MergeTreeData.h
...
Co-authored-by: flynn <fenglv15@mails.ucas.ac.cn>
2023-02-10 16:46:57 +08:00
attack204
7f41173a1f
rename API
2023-02-10 16:24:10 +08:00
attack204
93e92dab3b
rename API
2023-02-10 16:05:50 +08:00
attack204
52960d4e7d
add API to MergeTreeData
2023-02-10 11:00:11 +08:00
Nikolai Kochetov
4aa6e4d683
Revert "Add return flag for preFinalize."
...
This reverts commit 3261378ef8
2023-02-09 19:51:09 +00:00
Nikolai Kochetov
3261378ef8
Add return flag for preFinalize.
2023-02-09 19:50:54 +00:00
Nikolai Kochetov
98765cc20b
Disable delayed streams for Vertical merges for non-remote disks.
2023-02-09 19:39:34 +00:00
serxa
bf299b6696
Merge branch 'round-robin-merge-scheduler' of github.com:ClickHouse/ClickHouse into round-robin-merge-scheduler
2023-02-09 19:33:17 +00:00
serxa
cc3c76944b
remove redundant code
2023-02-09 19:31:54 +00:00
Sergei Trifonov
e3727d9b0e
Merge branch 'master' into round-robin-merge-scheduler
2023-02-09 20:04:59 +01:00
serxa
f61f95fcec
Replace background executor scheduler merges and mutations with round-robin
2023-02-09 18:54:15 +00:00
Antonio Andelic
f96d480563
Merge branch 'master' into add-support-for-settings-alias
2023-02-09 16:07:45 +01:00
Anton Popov
612fe0bd00
Revert "Allow vertical merges from compact to wide parts"
2023-02-09 15:42:46 +01:00
alesapin
9b23068d5e
Merge pull request #45821 from ClickHouse/explicit_drop_part_entry_type
...
Make separate DROP_PART log entry type
2023-02-09 15:11:13 +01:00
Vitaly Baranov
39bacfb9dc
Merge branch 'master' into allow-single-disk-instead-of-storage-policy
2023-02-09 13:16:55 +01:00
kssenii
2a48a96f83
Fix tests
2023-02-09 12:26:15 +01:00
Nikolai Kochetov
65ec9bd7d0
Fix write buffer destruction order for vertical merge.
2023-02-09 10:58:49 +00:00
alesapin
859f528fe1
Merge pull request #45648 from ClickHouse/45508_Update_strategy_for_system_sync_replica
...
Updated checking of SYSTEM SYNC REPLICA
2023-02-09 11:51:05 +01:00
kssenii
b0b865c32e
Resubmit prefetches
2023-02-08 21:26:24 +01:00
avogar
c3e8dd8984
Fix low cardinality case
2023-02-08 19:14:28 +00:00
alesapin
a28d10a810
Fxi
2023-02-08 14:50:30 +01:00
Smita Kulkarni
87ec32f235
Updated to use znode_name instead of log_entry_id - Updated checking of SYSTEM SYNC REPLICA
2023-02-08 14:07:06 +01:00
Azat Khuzhin
151ba92a2e
Fix reading of non existing nested columns with multiple level in compact parts
...
Consider the following example:
CREATE TABLE data (root.array_str Array(UInt8)) ENGINE = MergeTree() ORDER BY tuple();
INSERT INTO data VALUES ([]);
ALTER TABLE data ADD COLUMN root.nested_array Array(Array(UInt8));
In this case the first part will not have data for root.nested_array,
and thanks to #37152 it will simply read offsets column from
root.array_str, however since root.nested_array is a nested array, it
will try to read elements from the same offsets stream and if you are
lucky enough you will get one of the following errors:
- Cannot read all data. Bytes read: 1. Bytes expected: 8.: (while reading column root.nested_array): While executing MergeTreeInOrder. (CANNOT_READ_ALL_DATA)
- DB::Exception: Array size is too large: 8233460228287709730: (while reading column serp.serp_features): While executing MergeTreeInOrder.
So to address this, findColumnForOffsets() had been changed to return
the level of the column too, to allow to read only up to this level.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-08 10:21:40 +01:00
alesapin
bbf044f477
Fxi
2023-02-07 22:30:38 +01:00
Smita Kulkarni
8c9d994fd7
Extended scope of state_mutex while adding subscriber - Updated checking of SYSTEM SYNC REPLICA
2023-02-07 22:04:17 +01:00
alesapin
bc58fd156b
Merge remote-tracking branch 'origin' into mutations_rename_hang
2023-02-07 20:53:04 +01:00
alesapin
36f41da6e0
One more bugfix
2023-02-07 18:53:47 +01:00
Smita Kulkarni
ecea28a832
Fixed style check - Updated checking of SYSTEM SYNC REPLICA
2023-02-07 17:27:34 +01:00
Nikolai Kochetov
3912f5a333
Merge pull request #45681 from CurtizJ/compact-parts-vertical-merge
...
Allow vertical merges from compact to wide parts
2023-02-07 17:09:17 +01:00
Smita Kulkarni
34341ddabe
Updated locks and removed getLogEntryIds function - Updated checking of SYSTEM SYNC REPLICA
2023-02-07 16:57:58 +01:00
Sema Checherinda
52d4e78b7f
Merge pull request #45907 from CheSema/forbid-wal-on-s3
...
do not run wal on remote disks
2023-02-07 14:48:00 +01:00
Yakov Olkhovskiy
4e7dffafe4
Merge pull request #46087 from ClickHouse/fix-ip-bloom
...
Allow bloom filter for IPv4 and IPv6
2023-02-07 08:29:28 -05:00
alesapin
1fd9baa3f3
Fix fetch:
2023-02-07 12:49:51 +01:00
Smita Kulkarni
fb765696b6
Removed state_mutex lock from addSubscriber - Updated checking of SYSTEM SYNC REPLICA
2023-02-07 12:19:58 +01:00
Vitaly Baranov
f021c0eab6
Merge pull request #46058 from vitlibar/remove-unnecessary-execute-for-const-expr
...
Remove unnecessary execute() while evaluating a constant expression.
2023-02-07 12:09:37 +01:00
Smita Kulkarni
ef29b61786
Updated callback to return log entry ids - Updated checking of SYSTEM SYNC REPLICA
2023-02-07 10:02:38 +01:00
Anton Popov
7dfea59267
remove an assertion
2023-02-07 00:50:41 +00:00
alesapin
dd3a98e88d
Fixes
2023-02-06 22:30:31 +01:00
alesapin
aac5da77e8
fix stupid bug
2023-02-06 21:32:40 +01:00
Nikolai Kochetov
b2cc2332f5
Fix 01710_force_use_projection.
2023-02-06 19:20:03 +00:00
Dmitry Novik
1e065b32f3
Add MemoryTracker for the background tasks
2023-02-06 17:25:58 +00:00
kssenii
6cea67d58b
Cleanup
2023-02-06 18:11:33 +01:00
alesapin
2a0484ca41
Add commnents, fix bugs
2023-02-06 18:06:14 +01:00
Yakov Olkhovskiy
e433c26cf9
allow bloom filter for IPv4 and IPv6
2023-02-06 16:30:18 +00:00
Alexander Tokmakov
98a4e1ab2c
better comment
2023-02-06 15:08:30 +01:00
alesapin
30a7198411
Update src/Storages/MergeTree/ReplicatedMergeTreeQueue.cpp
2023-02-06 15:06:28 +01:00
alesapin
bd4a3ce2d5
Update src/Storages/MergeTree/DataPartsExchange.cpp
2023-02-06 15:05:13 +01:00
Alexander Tokmakov
86feaae253
Merge branch 'master' into explicit_drop_part_entry_type
2023-02-06 14:59:59 +01:00
alesapin
e51e385017
fix style
2023-02-06 14:16:17 +01:00
Alexander Tokmakov
e9f770d89d
fix
2023-02-06 14:03:14 +01:00
alesapin
b94f9f8006
Merge branch 'master' into 45508_Update_strategy_for_system_sync_replica
2023-02-06 12:38:39 +01:00
alesapin
b265300a19
Merge branch 'master' into mutations_rename_hang
2023-02-06 12:25:29 +01:00
Antonio Andelic
f67e5505ab
Merge branch 'master' into custom-key-parallel-replicas
2023-02-06 11:12:39 +00:00
Sema Checherinda
734d3a318b
const auto ref in the loop
2023-02-06 12:09:33 +01:00
Vitaly Baranov
a3423ce196
Remove unnecessary execute() while evaluating a constant expression.
2023-02-05 20:26:34 +01:00
Han Fei
532b341de9
Merge pull request #45975 from ucasfl/_part
...
use LowCardnality for _part and _partition_id virtual column
2023-02-05 18:00:46 +01:00
Antonio Andelic
12569da984
Merge branch 'master' into add-support-for-settings-alias
2023-02-05 16:08:57 +00:00
kssenii
a7eb1b1419
Fix integration test
2023-02-04 22:57:30 +01:00
kssenii
5abbc7cad6
Cleanup
2023-02-04 19:41:41 +01:00
kssenii
1cbff88a7c
Fix integration test
2023-02-04 19:31:19 +01:00
Alexey Milovidov
22bd0b6f69
Merge pull request #38983 from CurtizJ/randomize-mt-settings
...
Allow to randomize merge tree settings in tests
2023-02-04 02:59:52 +01:00
alesapin
fd4ae0990b
Tiny fix
2023-02-03 21:07:34 +01:00
kssenii
5f124263a6
Revert changes with complex SettingsChanges
2023-02-03 21:04:45 +01:00
alesapin
9416401406
Fix
2023-02-03 20:52:10 +01:00
alesapin
f91c10d09d
Initial support for version
2023-02-03 20:49:07 +01:00
Nikolai Kochetov
310a4c69af
Aggregate Projections analysis using query plan [In progress]
2023-02-03 18:30:06 +00:00
alesapin
7a0d0f0c53
Some code which doesn't work
2023-02-03 19:14:49 +01:00
Antonio Andelic
8929838fcc
Merge branch 'master' into add-support-for-settings-alias
2023-02-03 17:47:00 +00:00
Alexander Tokmakov
3f11948bb0
Merge branch 'master' into stack_trace_in_part_log
2023-02-03 20:05:00 +03:00
Alexander Tokmakov
7e6f7c79f2
Merge pull request #45457 from FrankChen021/exception_time
...
Add last_exception_time to replication_queue
2023-02-03 20:00:15 +03:00
Nikita Mikhaylov
33877b5e00
Parallel replicas. Part [2] ( #43772 )
2023-02-03 14:34:18 +01:00
Alexey Milovidov
3e3df376c0
Merge pull request #45995 from CurtizJ/check-dynamic-columns
...
Check dynamic columns of part before its commit
2023-02-03 15:39:54 +03:00
alesapin
4a3277b1fd
Merge branch 'master' into mutations_rename_hang
2023-02-03 12:35:37 +01:00
Smita Kulkarni
123f3cfe1f
Used unordered_set for log entries and fixed the callback function - Updated checking of SYSTEM SYNC REPLICA
2023-02-03 08:48:16 +01:00
Frank Chen
d38adfab30
Merge two overridden functions as one
2023-02-03 15:27:45 +08:00
flynn
d119367d7d
fix
2023-02-03 07:06:58 +00:00
Frank Chen
d3a05a11da
Merge remote-tracking branch 'remotes/github/master' into stack_trace_in_part_log
2023-02-03 11:39:43 +08:00
Frank Chen
7af5ae7f2e
Merge branch 'master' into better_postpone_reason
2023-02-03 11:20:37 +08:00
Anton Popov
8ca602a148
check dynamic columns of part before its commit
2023-02-03 02:58:28 +00:00
alesapin
b8b0f1c3d3
Make RENAME COLUMN barrier
2023-02-02 21:11:19 +01:00
kssenii
a391de18a1
Merge remote-tracking branch 'upstream/master' into allow-single-disk-instead-of-storage-policy
2023-02-02 20:49:41 +01:00
alesapin
fc6c62e2ff
Add comment
2023-02-02 17:41:36 +01:00
alesapin
bdc530dead
Fix style
2023-02-02 17:30:38 +01:00
flynn
bc38ebaf52
use LowCardnality for _part and _partition_id virtual column
...
fix
2023-02-02 16:20:29 +00:00
alesapin
dea46e58fb
Fixes for ordinary merge tree
2023-02-02 17:03:24 +01:00
alesapin
174bdba912
Fix bugs in alter rename column
2023-02-02 16:57:46 +01:00
Alexander Gololobov
ec3bb0c04e
Merge pull request #45794 from ClickHouse/parallelize_is_storage_touched_by_mutations
...
Do not restrict count() query to 1 thread in isStorageTouchedByMutations()
2023-02-02 16:44:11 +01:00
Antonio Andelic
f613bfd8d2
Merge branch 'master' into add-support-for-settings-alias
2023-02-02 11:15:39 +00:00
Sema Checherinda
7c416477ac
do not run wal on remote disks
2023-02-01 20:03:45 +01:00
Nikolai Kochetov
ae420b30e5
Aggregate Projections analysis using query plan [In progress]
2023-02-01 17:55:06 +00:00
Sema Checherinda
3e1b17e4cf
fix build
2023-02-01 17:09:43 +01:00
Anton Popov
9f26e16963
loose the assertion
2023-02-01 15:31:06 +00:00
Sema Checherinda
41a1dddc7a
Merge branch 'master' into better_postpone_reason
2023-02-01 15:16:34 +01:00
Antonio Andelic
85cfee4bb9
Better alias definition
2023-02-01 13:54:03 +00:00
Alexander Tokmakov
aba4a00a17
fix
2023-02-01 14:47:57 +01:00
Antonio Andelic
ec04cf6876
Merge branch 'master' into add-support-for-settings-alias
2023-02-01 09:01:01 +00:00
Nikolai Kochetov
e2c32ccbca
Aggregate Projections analysis using query plan [In progress]
2023-01-31 20:33:01 +00:00
Anton Popov
1c4174750d
fix mistake after refactoring
2023-01-31 15:48:14 +00:00
Alexander Tokmakov
7862990721
Merge branch 'master' into explicit_drop_part_entry_type
2023-01-31 13:49:04 +01:00
Alexander Tokmakov
2e8100b6e4
make separate DROP_PART log entry type
2023-01-31 13:37:56 +01:00
Alexander Tokmakov
51b0f66e6b
Merge pull request #45793 from ClickHouse/fix_part_check_cancellation
...
Fix race condition on a part check cancellation
2023-01-31 14:15:17 +03:00
Antonio Andelic
c99efa75b7
Merge branch 'master' into custom-key-parallel-replicas
2023-01-31 11:58:30 +01:00
Alexander Gololobov
4eea3de654
Do not restrict count() query to 1 thread in isStorageTouchedByMutations()
2023-01-30 22:29:28 +01:00
Alexander Tokmakov
e42cd3163f
fix race condition on a part check cancellation
2023-01-30 18:48:20 +01:00
Arthur Passos
48e5211454
Merge branch 'ClickHouse:master' into add_select_final_mt_setting
2023-01-30 13:01:36 -03:00
alesapin
be58d5d1af
Fix bug in tables drop which can lead to potential query hung
2023-01-30 17:00:28 +01:00
Smita Kulkarni
6cf2498609
Fixed clang-tidy build for comparing strings and updated to notify after adding subscriber if queue is already empty- Updated checking of SYSTEM SYNC REPLICA
2023-01-30 08:18:20 +01:00
SmitaRKulkarni
809354dc30
Merge branch 'master' into 45508_Update_strategy_for_system_sync_replica
2023-01-29 11:28:21 +01:00
Alexey Milovidov
49a59ff9bd
Fix bad comment
2023-01-29 03:57:59 +01:00
Smita Kulkarni
9b457a57a9
Fixed clang-tidy build - Updated checking of SYSTEM SYNC REPLICA
2023-01-28 21:43:41 +01:00
Smita Kulkarni
2bbe08ce8b
Updated destructor to notify even when queue empty - Updated checking of SYSTEM SYNC REPLICA
2023-01-27 22:37:42 +01:00
Anton Popov
d8fe2bcbaa
Merge branch 'master' into randomize-mt-settings
2023-01-27 16:03:00 +01:00
Anton Popov
3f1db52d51
Merge remote-tracking branch 'upstream/master' into compact-parts-vertical-merge
2023-01-27 14:38:37 +00:00
Nikolai Kochetov
313947e0b0
Merge branch 'master' into issue_45590
2023-01-27 15:08:28 +01:00
SmitaRKulkarni
b22fd40d92
Merge branch 'master' into 45508_Update_strategy_for_system_sync_replica
2023-01-27 15:00:47 +01:00
Anton Popov
f10e82355e
Merge pull request #45630 from CurtizJ/fix-performance-columns-description
...
Fix performance of short queries with `Array` columns
2023-01-27 14:59:55 +01:00
Anton Popov
9c1717b42d
fix computation of granularity in vertical merges
2023-01-27 13:35:04 +00:00
Nikolai Kochetov
f6ad6296ba
Restore.
2023-01-27 12:45:41 +00:00
Alexander Tokmakov
1494262a38
Update DataPartStorageOnDiskFull.cpp
2023-01-27 15:42:41 +03:00
Nikolai Kochetov
b716e2d754
A bit cleaner fix.
2023-01-27 12:37:23 +00:00
alesapin
716d25c33f
Merge pull request #45619 from CurtizJ/refactoring-merge-tree-parts
...
Refactoring of code near merge tree parts
2023-01-27 13:36:33 +01:00
Smita Kulkarni
a95609e0bc
Updated to validate & remove each element instead of just last element - Updated checking of SYSTEM SYNC REPLICA
2023-01-27 10:35:12 +01:00
Amos Bird
716516f84a
Fix test
2023-01-27 16:58:41 +08:00
Amos Bird
fd60954081
Fix key description on duplicate primary keys
...
This can happen in projections. See
https://github.com/ClickHouse/ClickHouse/issues/45590 for details.
2023-01-27 13:01:36 +08:00
Anton Popov
fb3f7409fa
allow vertical merges from compact to wide parts
2023-01-26 22:18:04 +00:00
Alexander Tokmakov
061026c307
fix
2023-01-26 19:01:29 +01:00
Alexander Tokmakov
067b1f5f13
Merge branch 'master' into exception_message_patterns4
2023-01-26 15:20:58 +01:00
Antonio Andelic
714fad1529
Add support for settings alias
2023-01-26 14:06:46 +00:00
Alexander Tokmakov
f676e9eaff
Merge pull request #45613 from azat/replicated-improve-log
...
Improve "at least part X is missing" error message
2023-01-26 16:48:18 +03:00
Anton Popov
92fa39798b
Merge remote-tracking branch 'upstream/master' into HEAD
2023-01-26 13:29:23 +00:00
Anton Popov
87af86e9a3
fix projections
2023-01-26 13:11:31 +00:00
Alexander Tokmakov
14db798191
fix
2023-01-26 13:56:16 +01:00
Antonio Andelic
07b2c5ce0f
Merge branch 'master' into custom-key-parallel-replicas
2023-01-26 12:42:04 +01:00
Anton Popov
b52cf17fa6
Merge pull request #45612 from ClickHouse/CurtizJ-patch-7
...
Remove useless code
2023-01-26 12:38:52 +01:00
Smita Kulkarni
8c885ffeae
Updated checking of SYSTEM SYNC REPLICA
...
Implementation:
* Updated to wait for current last entry to be processed (after pulling shared log) instead of queue size becoming 0.
* Updated Subscriber to notify both queue size and removed log_entry_id.
2023-01-26 11:40:09 +01:00
Alexander Tokmakov
a584ad0eb1
forbid runtime strings
2023-01-26 10:52:47 +01:00
Antonio Andelic
6fe9e9a67f
Merge pull request #45617 from ClickHouse/fix-bfngram-index
...
Correctly check types when using N-gram bloom filter index
2023-01-26 09:05:56 +01:00
Alexander Tokmakov
9b670946db
Merge branch 'master' into exception_message_patterns5
2023-01-26 00:41:32 +01:00
Anton Popov
79ea6a1c9c
fix performance of short queries
2023-01-25 22:20:01 +00:00
Han Fei
0221b50028
Merge pull request #45601 from hanfei1991/hanfei/async-cache-conflict
...
fix race of async-insert-blockids-cache
2023-01-25 22:28:42 +01:00
Alexander Tokmakov
3744fa2c63
format more messages
2023-01-25 21:16:42 +01:00
Anton Popov
0f46c1ecc6
fix build
2023-01-25 20:13:54 +00:00
Azat Khuzhin
00c341850f
Improve "at least part X is missing" error message
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-01-25 19:53:45 +01:00
Anton Popov
a455083b87
Merge remote-tracking branch 'upstream/master' into refactoring-merge-tree-parts
2023-01-25 18:01:12 +00:00
Kruglov Pavel
83a212a128
Merge branch 'master' into more-fsync-fixes
2023-01-25 18:40:41 +01:00
Anton Popov
8e3698c91f
refactoring of code near merge tree parts
2023-01-25 17:34:09 +00:00
Antonio Andelic
7fa906487c
Fix ngram index with null
2023-01-25 16:40:04 +00:00
Anton Popov
d9aabb48c3
remove useless code
2023-01-25 16:11:15 +00:00
Alexander Tokmakov
6eb557b2ba
Merge branch 'master' into exception_message_patterns4
2023-01-25 13:49:17 +01:00
Robert Schulze
59528cfca0
Merge pull request #45460 from ClickHouse/inv-index-cleanup
...
Cleanup of inverted index
2023-01-25 13:23:38 +01:00
Han Fei
8c4bbcd0fc
fix race of async-insert-blockids-cache
2023-01-25 12:41:01 +01:00
Sergei Trifonov
0d1ea05ff6
Merge pull request #45007 from ClickHouse/cancellable-mutex-integration
...
Fast shared mutex integration
2023-01-25 11:15:46 +01:00
Kseniia Sumarokova
2b8b1ad5d4
Additional check in MergeTreeReadPool ( #45515 )
...
* Check ranges
* Check equality just in case
* Check under ndebug
2023-01-24 23:56:26 +01:00
Azat Khuzhin
54ef885a61
Fsync all small files at once after mutation
...
Everything else is handled in MergedBlockOutputStream::finalizePart()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-01-24 14:08:37 +01:00
Azat Khuzhin
4b775ccdd5
Do fsync all files at once for fetched parts to decrease latency
...
For filessystems like ext4, fsync of one file will handle all operations
before, so this can be pretty time consuming.
And in case of you write multiple files in a loop, and at the end of
each iteration sync each file, then during writing of this file there
can be other operations in journal, and hence more work for fsync.
Let's call fsync for all files at once instead, like
MergedBlockOutputStream does.
Hope that keeping all file buffers till the end, will not cause troubles
(buffering and so forth).
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-01-24 14:08:37 +01:00
Azat Khuzhin
b370e3faa5
Move fsync inside transaction callback in DataPartStorageOnDisk::rename()
...
Otherwise, it is useless.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-01-24 14:08:37 +01:00
Antonio Andelic
95853af459
Merge branch 'master' into custom-key-parallel-replicas
2023-01-24 10:49:40 +00:00
Robert Schulze
9ff2bfcbf5
Merge remote-tracking branch 'origin/master' into inv-index-cleanup
...
src/Interpreters/GinFilter.cpp
src/Interpreters/InterpreterCreateQuery.cpp
src/Storages/MergeTree/MergeTreeData.cpp
src/Storages/MergeTree/MergeTreeDataPartWriterOnDisk.cpp
src/Storages/MergeTree/MergeTreeIndexInverted.cpp
2023-01-24 10:09:42 +00:00
