Vitaly Baranov
b1199878ad
Merge pull request #39977 from vitlibar/improve-recovery-of-replicated-access-storage
...
Improve recovery of ReplicatedAccessStorage after errors.
2022-09-20 00:36:30 +02:00
Filatenkov Artur
3598a7e680
Fix query type information
2022-09-20 01:03:55 +03:00
alesapin
ee24b21aaf
Fix revert order
2022-09-19 21:19:36 +02:00
kssenii
e40ced28fd
Done
2022-09-19 21:05:30 +02:00
Sergei Trifonov
7902922ae4
Merge branch 'master' into readonly-settings-allow
2022-09-19 21:00:12 +02:00
serxa
2ef696ffe1
fix issues
2022-09-19 18:40:32 +00:00
alesapin
f67e23183f
Fix parts removal on drop + add unrelated test
2022-09-19 20:19:49 +02:00
serxa
7a1d4a404a
add DiskS3* profile events per S3 API calls
2022-09-19 18:10:47 +00:00
serxa
f8aa738511
more conventional profile events names
2022-09-19 17:23:22 +00:00
serxa
6ed53585ab
rearrange and fix profile event descriptions
2022-09-19 17:03:48 +00:00
Igor Nikonov
5de8298ca1
Merge branch 'master' into fix_sort_desc_when_read_in_order
2022-09-19 18:54:42 +02:00
Azat Khuzhin
f76f14a99c
Fix possible hung/deadlock on query cancellation
...
Right due to graceful cancellation of the query, it is possible to hung
accepting new queries or even have a deadlock, this is because
cancellation is done while acquiring ProcessListBase::mutex.
So this patch makes query cancellation lock-free, and now the lock will
be acquired only for preparing the query and after cancel is done.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-19 17:31:21 +02:00
Vitaly Baranov
052ecaa211
Merge branch 'master' into improve-recovery-of-replicated-access-storage
2022-09-19 15:26:21 +02:00
Vitaly Baranov
f75dd93965
Mask some information in logs.
2022-09-19 15:00:06 +02:00
Sergei Trifonov
ff2e1ff8d8
Merge branch 'master' into support_s3_api_event_metrics
2022-09-19 14:35:45 +02:00
Raúl Marín
e89dffbb95
Fix AggregateFunctionNullVariadic batch with null_is_skipped=false
2022-09-19 14:34:08 +02:00
Kruglov Pavel
712aebc077
Merge pull request #41083 from Avogar/fix-map-combinator
...
Fix possible segfaults, use-heap-after-free and memory leak in aggregate function combinators
2022-09-19 14:29:17 +02:00
kssenii
f8665c83da
Add retries for nats
2022-09-19 14:27:11 +02:00
Alexander Tokmakov
c6efb1773e
Merge branch 'master' into fix_drop_partition_on_cluster
2022-09-19 15:18:05 +03:00
Kruglov Pavel
4c3194eefe
Merge pull request #41286 from azat/utf8-fix
...
Do not allow invalid sequences influence other rows in lowerUTF8/upperUTF8
2022-09-19 14:07:10 +02:00
Sergei Trifonov
f7a1ed3141
Merge branch 'master' into readonly-settings-allow
2022-09-19 12:52:36 +02:00
serxa
a0bfa801e5
explicit ctor
2022-09-19 10:52:08 +00:00
Kseniia Sumarokova
631aad1671
Merge branch 'master' into fix-logical-error-write-through-cache
2022-09-19 12:29:55 +02:00
Antonio Andelic
1763af37b9
Merge pull request #41403 from ClickHouse/keeper-fix-shutdown-without-server
...
Fix Keeper segfault during shutdown when RAFT server failed to start
2022-09-19 12:03:58 +02:00
Igor Nikonov
81a46b6346
Merge remote-tracking branch 'origin/master' into fix_sort_desc_when_read_in_order
2022-09-19 09:40:23 +00:00
Igor Nikonov
54c2fed9cc
Update: use type explicitly
2022-09-19 09:31:45 +00:00
vdimir
a6dc99983d
Fix tidy build
2022-09-19 08:42:23 +00:00
vdimir
5c9bfbc116
Fix incorrect result in case of decimal precision loss in IN operator
2022-09-19 08:42:22 +00:00
vdimir
c2634c9fae
Revert "Throw exception on precision lost during decimal to decimal convertion"
...
This reverts commit d4233cf3c658adf2541070b1bbba678ad7c769db.
2022-09-19 08:42:22 +00:00
vdimir
c33e231ce9
Throw exception on precision lost during decimal to decimal convertion
2022-09-19 08:42:18 +00:00
Vladimir C
b6b5932efc
Merge pull request #41223 from ClickHouse/vdimir/exponential_rewrite_21557
2022-09-19 10:07:24 +02:00
Alexey Milovidov
b9bd2c8373
Merge pull request #41458 from ClickHouse/fix-bug-orc
...
Fix very strange behavior of Apache ORC
2022-09-19 10:43:17 +03:00
Amos Bird
d2601b8192
Add a comment
2022-09-19 14:41:34 +08:00
Alexey Milovidov
3c0961c48b
Merge branch 'master' into fix-map-combinator
2022-09-19 09:32:16 +03:00
Alexey Milovidov
b01f5bdca8
Merge pull request #39354 from ClickHouse/window-order-by
...
Respect ORDER BY clause in window functions
2022-09-19 09:22:37 +03:00
Amos Bird
09b75901f0
Fix nullptr deref
2022-09-19 14:07:31 +08:00
Alexey Milovidov
6a09340f11
Merge pull request #41459 from azat/io/threadpoolreader-elapsed
...
Account any IO that is done from ThreadPoolReader
2022-09-19 09:04:20 +03:00
Alexey Milovidov
81e8cb4be6
Merge branch 'master' into fix-bug-orc
2022-09-19 06:38:17 +03:00
Alexey Milovidov
d4b9fe41be
Merge pull request #41457 from ClickHouse/remove-trash-5
...
Remove trash from Field
2022-09-19 06:36:48 +03:00
Alexey Milovidov
57a1f47972
Merge pull request #41441 from ClickHouse/pod-array-overflow
...
Fix overflow in `PODArray`
2022-09-19 06:34:21 +03:00
Alexey Milovidov
ac193facde
Merge branch 'master' into add_missed_throw
2022-09-19 06:31:12 +03:00
Alexey Milovidov
df52df83f9
Merge pull request #41463 from ClickHouse/add-test-38383
...
Add a test for #38383
2022-09-19 06:27:38 +03:00
Alexey Milovidov
790cb730d6
Fix clang-tidy
2022-09-19 00:34:41 +02:00
Alexey Milovidov
cc28120761
Merge branch 'master' into pod-array-overflow
2022-09-19 00:34:38 +02:00
Alexey Milovidov
f3fd5ef845
Fix clang-tidy
2022-09-19 00:32:52 +02:00
Alexey Milovidov
36aaeecc2f
Fix clang-tidy
2022-09-19 00:32:11 +02:00
Alexey Milovidov
5d9e125c71
Fix clang-tidy
2022-09-19 00:28:32 +02:00
Igor Nikonov
e888859396
Fix: correct sort description for ReadFromMergeTree with read in order
...
optimization
2022-09-18 22:21:13 +00:00
alesapin
e4c120742e
Add missed throw expression
2022-09-18 16:56:19 +02:00
alesapin
560bc2bc22
Merge pull request #41386 from ClickHouse/fix_redundant_fetch
...
Fix redundant fetch in zero copy replication
2022-09-18 15:57:27 +02:00
alesapin
1d0dbfb112
Merge pull request #41444 from ClickHouse/one_wrong_config_assert
...
One more validation for broken config in keeper
2022-09-18 15:56:48 +02:00
Kruglov Pavel
519bcbb3be
Merge pull request #41236 from Avogar/fix-totals-extremes
...
Don't output totals/extremes in all row formats, update docs
2022-09-18 14:55:07 +02:00
Kseniia Sumarokova
d6748b182f
Update CachedOnDiskWriteBufferFromFile.cpp
2022-09-18 14:48:24 +02:00
Vitaly Baranov
e7e51ab2d9
Add comments.
2022-09-18 12:44:05 +02:00
Vitaly Baranov
69996c960c
Add retries for the initialization of ReplicatedAccessStorage.
2022-09-18 12:44:05 +02:00
Vitaly Baranov
5365b105cc
Add SYSTEM RELOAD USERS command.
2022-09-18 12:44:00 +02:00
Vitaly Baranov
1b40f94c6b
Move common code from MemoryAccessStorage and DiskAccessStorage to IAccessStorage.
2022-09-18 12:17:15 +02:00
Azat Khuzhin
64b44be513
Account any IO that is done from ThreadPoolReader
...
In case of some issues with the disk it is possible that
preadv2(RWF_NOWAIT)==EAGAIN can take a lot of time, so let's measure
even this case.
I've verified with a simple (almost) loop of preadv2(RWF_NOWAIT), and
got this:
EAGAIN: 8565670 (out of 17148317)
EAGAIN: 8565670 (out of 17148317)
EAGAIN: 8565670 (out of 17148317)
too long at offset=8691694, ret=18446744073709551615 (14.5016)
too long at offset=8694766, ret=18446744073709551615 (14.4338)
too long at offset=8694766, ret=18446744073709551615 (16.2144)
So here you can see that preadv2(RWF_NOWAIT) took 14-16 seconds in case
of failure.
Complete code can be found here [1].
[1]: https://gist.github.com/azat/f4a6b0750316c42bec021064e0a7627c
I came up with this patch because I saw some stranginess in
ProfileEvents, that does not show all the time that was spend in IO when
pread_threadpool method was used.
Also there was some stranginess with trace_log too.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-18 10:05:21 +02:00
Alexey Milovidov
7e6da853cd
Merge branch 'master' into pod-array-overflow
2022-09-18 09:24:23 +02:00
Alexey Milovidov
a6e3ab5515
Fix error
2022-09-18 09:21:57 +02:00
Alexey Milovidov
5c75a7d661
Fix error
2022-09-18 09:20:48 +02:00
Alexey Milovidov
c41e37fa8e
Code simplification
2022-09-18 08:58:32 +02:00
Alexey Milovidov
3c43d6516b
Fix style
2022-09-18 08:56:52 +02:00
Alexey Milovidov
bafc5f24c7
Merge branch 'master' into remove-trash-5
2022-09-18 08:56:02 +02:00
Alexey Milovidov
8764fa4439
Fix very strange behavior of Apache ORC
2022-09-18 08:25:25 +02:00
Alexey Milovidov
a958751c98
Merge pull request #40219 from den-crane/test/zvonand-monotonic
...
test for datetime64 monotonic #39864
2022-09-18 07:48:49 +03:00
Alexey Milovidov
6b752bff3a
Merge branch 'master' into revert_prefixes_s3
2022-09-18 07:10:57 +03:00
Alexey Milovidov
32efe6952e
Merge pull request #41429 from ClickHouse/forbid-dlopen-2
...
Forbid invocations of `dlopen`
2022-09-18 07:05:56 +03:00
Alexey Milovidov
791de6592b
Remove trash from Field
2022-09-18 05:16:08 +02:00
Alexey Milovidov
c8c728e740
Merge pull request #41449 from ClickHouse/fix-categorial-information
...
Fix incorrect properties of `categorialInformationValue` function
2022-09-18 05:26:26 +03:00
Alexey Milovidov
7f68f2c7df
Remove trash from LowCardinality
2022-09-18 04:13:21 +02:00
Alexey Milovidov
15e5fc96a1
Add a trap
2022-09-18 02:24:56 +02:00
Alexey Milovidov
dc76677eb2
Merge pull request #41440 from ClickHouse/remove-cruft
...
Remove cruft about gcc
2022-09-18 03:15:26 +03:00
Alexey Milovidov
e3dafdb865
More hardening
2022-09-18 02:10:06 +02:00
Alexey Milovidov
e5e3bca3ae
More hardening and tests
2022-09-18 02:05:13 +02:00
Alexey Milovidov
6c74c54cb5
Merge branch 'master' into pod-array-overflow
2022-09-18 01:24:52 +02:00
Alexey Milovidov
6f1878b12a
Fix error
2022-09-18 01:17:22 +02:00
Alexey Milovidov
c424ad12aa
Simplification
2022-09-18 00:09:21 +02:00
alesapin
b6d61318d0
One more validation for broken config in keeper
2022-09-18 00:04:16 +02:00
Alexey Milovidov
e2d434ea18
Start with code removal
2022-09-17 23:37:57 +02:00
Alexey Milovidov
2f0684b97c
Fix trash in schema inference
2022-09-17 23:11:33 +02:00
Alexey Milovidov
bac578b23a
Merge pull request #41428 from ClickHouse/remove-dlopen
...
Remove `dlopen`
2022-09-18 00:09:57 +03:00
Alexey Milovidov
e3d75b0933
Merge branch 'fix-trash-schema-inference' into pod-array-overflow
2022-09-17 22:56:06 +02:00
Alexey Milovidov
47167494d9
Fix trash in schema inference
2022-09-17 22:53:41 +02:00
Alexey Milovidov
9ca4e2ec7c
Fix overflow in PODArray
2022-09-17 22:26:39 +02:00
Alexey Milovidov
f4a48cd4d6
Remove cruft
2022-09-17 22:16:31 +02:00
kssenii
51745dcb43
Fix assertion in write-through cache
2022-09-17 20:20:32 +02:00
Alexander Tokmakov
49a9c9e5fa
Merge pull request #41436 from ClickHouse/revert_38200
...
Revert "Keeper faster linearizable reads"
2022-09-17 20:25:43 +03:00
Robert Schulze
38aecc15a2
Merge pull request #41214 from arenadata/ADQM-528-B
...
Add enable_extended_results_for_datetime_functions option to return results of type Date32
2022-09-17 19:25:11 +02:00
Alexander Tokmakov
42dab6dc02
Revert "Merge pull request #38200 from ClickHouse/keeper-linearizable-reads"
...
This reverts commit 222b964070da01982652
2022-09-17 19:22:58 +02:00
alesapin
33216dedf9
Merge pull request #41323 from ClickHouse/remove_bad_exception
...
Fix parts removal in case of connection loss
2022-09-17 19:14:53 +02:00
alesapin
dcb1586977
Add comment
2022-09-17 19:11:58 +02:00
alesapin
db30a3041e
Update src/Storages/MergeTree/MutateFromLogEntryTask.cpp
...
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2022-09-17 19:10:23 +02:00
alesapin
84828874e0
Change log level
2022-09-17 19:06:54 +02:00
Anton Popov
07cfb0cba4
Merge branch 'master' into dynamic-columns-21
2022-09-17 19:02:58 +02:00
Alexey Milovidov
9ce0c5f738
Merge pull request #41431 from ClickHouse/remove-method-simplification
...
Remove `-WithTerminatingZero` methods
2022-09-17 19:48:35 +03:00
Azat Khuzhin
01b5b9ceba
Do not allow invalid sequences influence other rows in lowerUTF8/upperUTF8
...
Right now lowerUTF8() and upperUTF8() does not respect row boundaries,
and so one row may break another.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-17 11:16:45 +02:00
Igor Nikonov
475443c10c
Merge pull request #41257 from ClickHouse/igor/mixed_improvements_along_the_way
...
Tiny improvements along the code
2022-09-17 10:43:46 +02:00
Alexey Milovidov
ada7a44ae4
Remove -WithTerminatingZero methods
2022-09-17 05:34:18 +02:00
Alexey Milovidov
0c3835240b
Fix error with multidimensional arrays
2022-09-17 04:16:24 +02:00
