Commit Graph

73125 Commits

Author SHA1 Message Date
tavplubix
1c9778603f
Update clickhouse-test 2021-09-27 11:43:00 +03:00
Maksim Kita
f7aed5aab8
Merge pull request #29393 from azat/rocksdb-fix-data-race
rocksdb: fix race condition during multiple DB opening
2021-09-27 11:32:59 +03:00
Nikolai Kochetov
841ef13dee
Merge pull request #29338 from ClickHouse/less-sleeps-in-integratin-tests
Less sleeps in integration tests.
2021-09-27 10:35:31 +03:00
alexey-milovidov
5a7f30171a
Merge pull request #29355 from ClickHouse/remove-trash-db-regexp
Fix assert in table function `merge` with database regexp
2021-09-27 05:50:13 +03:00
alexey-milovidov
3609d4adad
Merge pull request #29164 from azat/test_send_crash_reports-fix
test_send_crash_reports: suppress Fatal messages check (due to explicit SIGSEGV)
2021-09-27 03:54:10 +03:00
alexey-milovidov
319e0c1f91
Merge pull request #29229 from azat/send-UNKNOWN_DATABASE-to-client
Send UNKNOWN_DATABASE to the client (via TCP)
2021-09-27 02:46:01 +03:00
Alexey Milovidov
1227a383e3 Merge branch 'remove-trash-db-regexp' of github.com:yandex/ClickHouse into remove-trash-db-regexp 2021-09-27 02:17:19 +03:00
Alexey Milovidov
8493b014cd Improve test 2021-09-27 02:16:58 +03:00
Alexey Milovidov
16f0f0af7f Merge remote-tracking branch 'origin/master' into remove-trash-db-regexp 2021-09-27 02:12:13 +03:00
alexey-milovidov
1c1e2e6b28
Merge pull request #29289 from vdimir/issue-29227-rocksdb-truncate
Fix race in StorageSystemRocksDB
2021-09-27 01:55:07 +03:00
Azat Khuzhin
b3d1bfc67a Send UNKNOWN_DATABASE to the client (via TCP)
Before this patch:

    $ clickhouse-client --database foo -q 'select 1'
    Code: 32. DB::Exception: Attempt to read after eof: while receiving packet from localhost:9000. (ATTEMPT_TO_READ_AFTER_EOF)

After:

    $ clickhouse-client --database foo -q 'select 1'
    Received exception from server (version 21.11.1):
    Code: 81. DB::Exception: Received from localhost:9000. DB::Exception: Database foo doesn't exist. (UNKNOWN_DATABASE)
    (query: select 1)

Fixes: #26864 (cc @vitlibar)
2021-09-26 23:45:29 +03:00
Azat Khuzhin
42af45b2ba rocksdb: fix race condition during multiple DB opening
This should fix the following SIGSEGV, that was found on CI [1]:

    <Fatal> BaseDaemon: Address: NULL pointer. Access: read. Unknown si_code.
    <Fatal> BaseDaemon: 4.4. inlined from ../contrib/rocksdb/utilities/object_registry.cc:19: rocksdb::ObjectLibrary::FindEntry() const
    ...
    <Fatal> BaseDaemon: 7.3. inlined from ../contrib/rocksdb/options/cf_options.cc:678: rocksdb::$_7::operator()()

  [1]: https://clickhouse-test-reports.s3.yandex.net/29341/2b2bec3679df7965af908ce3f1e8e17e39bd12fe/integration_tests_flaky_check_(asan).html#fail1

And also I checked manually with TSan binary, and here is a data race
reported by TSan:

    WARNING: ThreadSanitizer: data race (pid=3356)
      Read of size 8 at 0x7b0c0008cca8 by thread T40:
        2 rocksdb::ObjectLibrary::FindEntry() const obj-x86_64-linux-gnu/../contrib/rocksdb/utilities/object_registry.cc:18:27 (clickhouse-tsan+0x1b839a6c)
        ...
        6 rocksdb::$_7::operator()() const obj-x86_64-linux-gnu/../contrib/rocksdb/options/cf_options.cc:676:32 (clickhouse-tsan+0x1b6bfa63)
        ...
        28 rocksdb::GetColumnFamilyOptionsFromMap() obj-x86_64-linux-gnu/../contrib/rocksdb/options/options_helper.cc:727:10 (clickhouse-tsan+0x1b6fffd2)
        29 DB::StorageEmbeddedRocksDB::initDb() obj-x86_64-linux-gnu/../src/Storages/RocksDB/StorageEmbeddedRocksDB.cpp:359:26 (clickhouse-tsan+0x14195e31)
        ...

      Previous write of size 8 at 0x7b0c0008cca8 by thread T41:
        ...
        9 rocksdb::ObjectLibrary::AddEntry() obj-x86_64-linux-gnu/../contrib/rocksdb/utilities/object_registry.cc:31:19 (clickhouse-tsan+0x1b8392fc)
        ...
        11 rocksdb::RegisterTableFactories()::$_0::operator()() const obj-x86_64-linux-gnu/../contrib/rocksdb/table/table_factory.cc:23:14 (clickhouse-tsan+0x1b7ea94c)
        ...
        43 rocksdb::GetColumnFamilyOptionsFromMap() obj-x86_64-linux-gnu/../contrib/rocksdb/options/options_helper.cc:727:10 (clickhouse-tsan+0x1b6fffd2)
        44 DB::StorageEmbeddedRocksDB::initDb() obj-x86_64-linux-gnu/../src/Storages/RocksDB/StorageEmbeddedRocksDB.cpp:359:26 (clickhouse-tsan+0x14195e31)

Refs: https://github.com/ClickHouse-Extras/rocksdb/pull/13
Fixes: #29341
2021-09-26 23:41:43 +03:00
alexey-milovidov
aa48698613
Merge pull request #29368 from bharatnc/ncb/fix-name-h3isResClassIII
Fix H3 function name (h3ResIsClassIII to h3IsResClassIII)
2021-09-26 20:36:36 +03:00
alexey-milovidov
5474ce01f1
Merge pull request #29380 from bharatnc/ncb/agg-func-fix-comment
Fix comments in AggregateFunctionFactory
2021-09-26 20:27:09 +03:00
alexey-milovidov
1f3117f1a2
Merge pull request #29387 from sdil/patch-1
Add GraphCDN in adopter list
2021-09-26 20:17:35 +03:00
Nikolai Kochetov
3c9e6a04bf A little bit better 2021-09-26 18:06:32 +03:00
Mohamad Fadhil
b05a03660b
Add GraphCDN in adopter list 2021-09-26 21:54:55 +08:00
Anton Popov
01757a85a7
temporarily fix tests 2021-09-26 14:59:39 +03:00
Anton Popov
332a2ac990
temporarily fix tests 2021-09-26 14:58:55 +03:00
Azat Khuzhin
ad1e9e42fc Restore test_rocksdb_options::test_table_invalid_column_family_options test
This reverts commit e40a13bd1f.
2021-09-26 08:24:22 +03:00
Azat Khuzhin
d9e3419197 Restore test_rocksdb_options::test_invalid_column_family_options test
This reverts commit 1881c67eff.
2021-09-26 08:24:18 +03:00
alexey-milovidov
b0d45b8638
Merge pull request #29367 from MaxWk/fix-keeper-data-dumper-build-error
fix build error in keeper data dumper
2021-09-26 08:00:42 +03:00
万康
3ef5d13a4a add parameter 2021-09-26 10:12:54 +08:00
alexey-milovidov
6995d4d2b5
Merge pull request #29379 from ClickHouse/fix-ugly-typo
Fix ugly typo
2021-09-26 05:02:27 +03:00
bharatnc
0e9af142df Fix one more comment 2021-09-25 18:21:47 -07:00
bharatnc
23b6ac82a7 Fix comments in AggregateFunctionFactory 2021-09-25 18:21:06 -07:00
alexey-milovidov
0476022d71
Merge pull request #29290 from mrk-andreev/patch-2
Fix table schema for hits_100m_obfuscated
2021-09-26 03:38:21 +03:00
Alexey Milovidov
dc7eb5c1ae Fix ugly typo 2021-09-26 03:29:32 +03:00
alexey-milovidov
07eef92c16
Merge pull request #29364 from azat/benchmark-fix-query_id
Pass through initial query_id for clickhouse-benchmark
2021-09-26 03:27:27 +03:00
mergify[bot]
15e5204a7c
Merge branch 'master' into issue-29227-rocksdb-truncate 2021-09-26 00:10:30 +00:00
alexey-milovidov
0bd962630e
Merge pull request #29341 from ClickHouse/fix-rocksdb-test
Fix integration test for RocksDB
2021-09-26 01:06:55 +03:00
alexey-milovidov
6107e262aa
Merge pull request #29361 from ClickHouse/remove-useless-files
Remove useless files related to pytest
2021-09-26 01:06:20 +03:00
Kseniia Sumarokova
a7809d3d63
Merge pull request #29365 from kssenii/fix-mysql
Fix integration test
2021-09-26 00:52:10 +03:00
alexey-milovidov
9261498e2b
Merge pull request #29375 from azat/tests-purge-unused-conf
RFC: tests: purge unused configs
2021-09-26 00:29:40 +03:00
bharatnc
cd17849607 fix test - rename reference file 2021-09-25 13:11:23 -07:00
Azat Khuzhin
7ec4f3339f tests: purge unused configs 2021-09-25 21:04:40 +03:00
bharatnc
59dfc87113 Merge remote-tracking branch 'upstream/master' into ncb/fix-name-h3isResClassIII 2021-09-25 10:19:00 -07:00
alexey-milovidov
77ab62c821
Update CHANGELOG.md 2021-09-25 20:16:57 +03:00
bharatnc
a5a8d132d0 Fix doc references 2021-09-25 10:15:12 -07:00
bharatnc
79473f2edc Fix tests 2021-09-25 10:13:42 -07:00
bharatnc
2deb9643af Rename h3ResIsClassIII -> h3IsResClassIII 2021-09-25 10:12:32 -07:00
alexey-milovidov
e40a13bd1f
Remove trash 2021-09-25 19:47:29 +03:00
alexey-milovidov
08e395bbcd
Merge pull request #29342 from ClickHouse/fix-typo-in-comment
Fix typo in comment
2021-09-25 19:44:59 +03:00
alexey-milovidov
c96a73f4ca
Merge pull request #29344 from ClickHouse/azat-apply-install-patch
Apply a patch from Azat
2021-09-25 19:43:54 +03:00
alexey-milovidov
85fc160eb4
Merge pull request #29346 from ClickHouse/remove-ya-make
Remove ya.make
2021-09-25 19:43:40 +03:00
alexey-milovidov
87d9506bb0
Merge pull request #29348 from ClickHouse/remove-nth-value
Remove window function 'nth_value'
2021-09-25 19:43:02 +03:00
alexey-milovidov
9dac348893
Update StorageMerge.cpp 2021-09-25 19:41:50 +03:00
mergify[bot]
4bfc82d00e
Merge branch 'master' into remove-useless-files 2021-09-25 16:41:03 +00:00
alexey-milovidov
7eddf2664e
Merge pull request #29362 from ClickHouse/remove-obsolete-non-automated-tests
Remove obsolete non-automated tests
2021-09-25 19:40:03 +03:00
Azat Khuzhin
fb584715e1 Pass through initial query_id for clickhouse-benchmark 2021-09-25 18:05:55 +03:00