Commit Graph

90962 Commits

Author SHA1 Message Date
Azat Khuzhin
20f0602c20 tests/integration: add ability to query specific host
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-06-16 11:59:01 +03:00
Azat Khuzhin
b3bf7589ef Fix possible concurrent access in ProgressIndication
In case of all of the above:
- clickhouse-local
- input_format_parallel_parsing=true
- write_progress_on_update=true

It is possible concurrent access to the following:
- writeProgress() (class properties) (guarded with progress_mutex)
- thread_data/host_cpu_usage (guarded with profile_events_mutex)

v2: decrease number of rows for INSERT ProfileEvents test (10 times)
    CI: https://s3.amazonaws.com/clickhouse-test-reports/37391/4bd5c335182279dcc5020aa081b13c3044135951/stateless_tests__debug__actions__[1/3].html
v3: decrease number of rows for INSERT ProfileEvents test (10 times) and add a comment
    CI: https://s3.amazonaws.com/clickhouse-test-reports/37391/026d7f732cb166c90d6c287b02824b6c7fdebf0c/stateless_tests_flaky_check__address__actions_/runlog.log
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

f
2022-06-16 11:59:01 +03:00
Azat Khuzhin
4baa7690ae Send profile events for INSERT queries (previously only SELECT was supported)
Reproducer:

    echo "1" | clickhouse-client --query="insert into function null('foo String') format TSV" --print-profile-events --profile-events-delay-ms=-1

However, clickhouse-local is differnt, it does sent the periodically,
but only if query was long enough, i.e.:

    # yes | head -n100000 | clickhouse-local --query="insert into function null('foo String') format TSV" --print-profile-events --profile-events-delay-ms=-1
    [s1.ch] 2022.05.20 15:20:27 [ 0 ] ContextLock: 10 (increment)
    [s1.ch] 2022.05.20 15:20:27 [ 0 ] DiskReadElapsedMicroseconds: 29 (increment)
    [s1.ch] 2022.05.20 15:20:27 [ 0 ] IOBufferAllocBytes: 200000 (increment)
    [s1.ch] 2022.05.20 15:20:27 [ 0 ] IOBufferAllocs: 1 (increment)
    [s1.ch] 2022.05.20 15:20:27 [ 0 ] InsertQuery: 1 (increment)
    [s1.ch] 2022.05.20 15:20:27 [ 0 ] InsertedBytes: 1000000 (increment)
    [s1.ch] 2022.05.20 15:20:27 [ 0 ] InsertedRows: 100000 (increment)
    [s1.ch] 2022.05.20 15:20:27 [ 0 ] MemoryTrackerUsage: 1521975 (gauge)
    [s1.ch] 2022.05.20 15:20:27 [ 0 ] OSCPUVirtualTimeMicroseconds: 102148 (increment)
    [s1.ch] 2022.05.20 15:20:27 [ 0 ] OSReadChars: 135700 (increment)
    [s1.ch] 2022.05.20 15:20:27 [ 0 ] OSWriteChars: 8 (increment)
    [s1.ch] 2022.05.20 15:20:27 [ 0 ] Query: 1 (increment)
    [s1.ch] 2022.05.20 15:20:27 [ 0 ] RWLockAcquiredReadLocks: 2 (increment)
    [s1.ch] 2022.05.20 15:20:27 [ 0 ] ReadBufferFromFileDescriptorRead: 5 (increment)
    [s1.ch] 2022.05.20 15:20:27 [ 0 ] ReadBufferFromFileDescriptorReadBytes: 134464 (increment)
    [s1.ch] 2022.05.20 15:20:27 [ 0 ] RealTimeMicroseconds: 293747 (increment)
    [s1.ch] 2022.05.20 15:20:27 [ 0 ] SoftPageFaults: 382 (increment)
    [s1.ch] 2022.05.20 15:20:27 [ 0 ] TableFunctionExecute: 1 (increment)
    [s1.ch] 2022.05.20 15:20:27 [ 0 ] UserTimeMicroseconds: 102148 (increment)

v2: Proper support ProfileEvents in INSERTs (with protocol change)
v3: Receive profile events on INSERT queries
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-06-16 11:59:01 +03:00
Azat Khuzhin
3b29db6e9f LocalServer: remove superfluous ProgressIndicator.h
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-06-16 11:59:01 +03:00
Alexey Milovidov
f2b665a799
Merge pull request #38120 from wangdh15/delete-unused-field-fix-build-error
Remove unused class member
2022-06-16 11:11:26 +03:00
Alexey Milovidov
01fd592dda
Update CHANGELOG.md 2022-06-16 10:55:17 +03:00
Alexey Milovidov
bbdbfd9f01 Add a comment 2022-06-16 08:13:49 +02:00
Alexey Milovidov
11b31d1b10 Add a comment 2022-06-16 08:12:30 +02:00
Alexey Milovidov
ce2b4d78e4 Add one more item to the changelog 2022-06-16 07:38:28 +02:00
Alexey Milovidov
c26abbfdc5
Merge pull request #38093 from danlark1/master
Optimize most important parts with NEON SIMD
2022-06-16 08:26:56 +03:00
Alexey Milovidov
a904dab372
Update CHANGELOG.md 2022-06-16 08:12:42 +03:00
Alexey Milovidov
8547bbcbce
Merge pull request #38122 from ClickHouse/changelog-22.6
Changelog for 22.6
2022-06-16 08:02:27 +03:00
Alexey Milovidov
5107c9dc50 Changelog for 22.6, edits 2022-06-16 07:01:47 +02:00
Alexey Milovidov
b2736b15fe Changelog for 22.6 2022-06-16 07:00:07 +02:00
Alexey Milovidov
7dd849bcf6
Merge pull request #38117 from ClickHouse/CurtizJ-patch-6
Try to fix fpc codec
2022-06-16 07:44:13 +03:00
wangdh15
02cce40b3a when using clang12 compile, the unused filed shard_count will cause compile error. So delete it. 2022-06-16 10:43:31 +08:00
Anton Popov
92b7b9789a
try to fix fpc codec 2022-06-16 03:41:09 +02:00
Mikhail f. Shiryaev
6fdba20b13
Merge pull request #38098 from ClickHouse/clang-tidy-warning-fix
Fix: build error
2022-06-16 01:11:39 +02:00
Robert Schulze
b39b963733
Merge pull request #37993 from ClickHouse/stripping
Strip less aggressively to make the embedded hash survive
2022-06-16 00:08:36 +02:00
Robert Schulze
b936abe813
+ comments about keeping stuff in sync 2022-06-16 00:07:59 +02:00
Maksim Kita
3eea38f078
Merge pull request #38028 from kitaisreal/background-schedule-pool-refactoring
BackgroundSchedulePool remove Poco::NotificationQueue
2022-06-15 23:10:49 +02:00
Danila Kutenin
e34994331f Restart checks, DockerHubPush failed for some reason 2022-06-15 20:58:35 +00:00
Maksim Kita
7d5af1a79f
Merge pull request #37992 from kitaisreal/partial-sorting-transform-refactoring
PartialSortingTransform refactoring
2022-06-15 22:55:04 +02:00
Dan Roscigno
b9ef1c4ebb
Merge pull request #38035 from DanRoscigno/docs-max-suspicious-broken-parts-setting
add docs for MergeTree settings
2022-06-15 16:09:07 -04:00
DanRoscigno
d07753aa20 add more description 2022-06-15 14:59:47 -04:00
Robert Schulze
61709a674d
Merge pull request #38089 from ClickHouse/fpc-follow-up
Small follow-up for FPC codec
2022-06-15 20:33:41 +02:00
Danila Kutenin
607dd8d6ca Restart the pipeline, I guess 2022-06-15 18:16:56 +00:00
Robert Schulze
42cdf1f56e
Merge pull request #38087 from ClickHouse/fix-compile-of-self-extracting-executable
Fix a compile errors in self-extracting-executable (de)compressor
2022-06-15 20:15:45 +02:00
Daniel Kutenin
a769dea8ef
Merge branch 'ClickHouse:master' into master 2022-06-15 19:12:10 +01:00
Maksim Kita
5729210f22
Merge pull request #37797 from kitaisreal/libunwind-update-version
libunwind update version
2022-06-15 19:32:42 +02:00
Alexey Milovidov
7fce1d54fe
Merge pull request #38026 from ClickHouse/decimal_noexcept_move_constructor
Decimal: noexcept move constructor/assignment operator
2022-06-15 19:34:27 +03:00
Alexey Milovidov
7baa54f92f
Merge pull request #37697 from zvonand/dt64-neg-subseconds
Fix DateTime64 negative fractional seconds
2022-06-15 19:30:42 +03:00
Alexey Milovidov
d1cf7a52cc
Merge pull request #37721 from HarryLeeIBM/grpc_update_to_PR9
Update grpc submodule to PR 9
2022-06-15 19:29:11 +03:00
Alexander Tokmakov
2ac72319bd
Merge pull request #37185 from amosbird/projection-fix-three
Fix possible heap-use-after-free error when reading system.projection_parts and system.projection_parts_columns
2022-06-15 19:00:10 +03:00
Alexander Tokmakov
f6f4d785ca
Merge pull request #38030 from azat/tests-fix-parser
tests: avoid "_csv.Error: field larger than field limit (131072)" error
2022-06-15 18:39:42 +03:00
Igor Nikonov
b1137c9cba Fix: build error
+ clang tidy warning fixed
2022-06-15 15:21:05 +00:00
Mikhail f. Shiryaev
8ef1f851f6
Merge pull request #38095 from ClickHouse/cherry-pick-dispatch
Add dispatch to CherryPick action
2022-06-15 16:53:36 +02:00
Danila Kutenin
048f56bf4d Fix some tests and comments 2022-06-15 14:40:21 +00:00
Mikhail f. Shiryaev
14df282406
Add dispatch to CherryPick action 2022-06-15 16:37:44 +02:00
Alexander Tokmakov
581342eb31
Merge pull request #38094 from ClickHouse/revert-36396-glorious_final
Revert "More parallel execution for queries with `FINAL`"
2022-06-15 17:25:56 +03:00
Alexander Tokmakov
5bfb15262c Revert "More parallel execution for queries with FINAL (#36396)"
This reverts commit c8afeafe0e.
2022-06-15 17:25:38 +03:00
mergify[bot]
c2afc2f6c6
Merge branch 'master' into background-schedule-pool-refactoring 2022-06-15 13:43:31 +00:00
Danila Kutenin
08e3f77a9c Optimize most important parts with NEON SIMD
First part, updated most UTF8, hashing, memory and codecs. Except
utf8lower and upper, maybe a little later.

That includes huge amount of research with movemask dealing. Exact
details and blog post TBD.
2022-06-15 13:19:29 +00:00
Robert Schulze
1ff6218996
Revert "(Temporary / to be reverted) Force an official build."
This reverts commit 45d3091087.
2022-06-15 15:01:47 +02:00
Robert Schulze
8fef6e7fa3
Add missing ":" to error msg 2022-06-15 14:37:58 +02:00
Robert Schulze
a0d936cc9f
Small follow-up for FPC codec
- add paper reference + doxygen

- remove endianness handling (ClickHouse assumes little endian)

- documentation

- other minor stuff
2022-06-15 14:21:28 +02:00
Yakov Olkhovskiy
e604d31feb
Merge pull request #38074 from ClickHouse/bug-with-fill-extra
Inconsistency in ORDER BY ... WITH FILL feature.
2022-06-15 08:19:55 -04:00
mergify[bot]
68d043869c
Merge branch 'master' into libunwind-update-version 2022-06-15 11:43:01 +00:00
Robert Schulze
50748a94bd
Fix a compile errors in self-extracting-executable (de)compressor
E.g.

utils/self-extracting-executable/compressor.cpp:257:31: format specifies type 'ptrdiff_t' (aka 'long') but the argument has type 'off_t' (aka 'long long') [-Werror,-Wformat]
        printf("Size: %td\n", info_in.st_size);
                      ~~~     ^~~~~~~~~~~~~~~
                      %lld

Not sure though if it's a hard requirement to use only C.

Avoided usage of fmt::format() to keep link dependencies to a minimum.
Also not using C++20 std::format() as it's only available in Clang >=14.
2022-06-15 13:41:28 +02:00
Nikita Taranov
c8afeafe0e
More parallel execution for queries with FINAL (#36396) 2022-06-15 12:44:20 +02:00