Commit Graph

667 Commits

Author SHA1 Message Date
Azat Khuzhin
4e76629aaf Fixes for -Wshorten-64-to-32
- lots of static_cast
- add safe_cast
- types adjustments
  - config
  - IStorage::read/watch
  - ...
- some TODO's (to convert types in future)

P.S. That was quite a journey...

v2: fixes after rebase
v3: fix conflicts after #42308 merged
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:19 +02:00
Alexey Milovidov
fabc8f5a18 Remove support for {database} macro from the client's prompt 2022-10-19 23:27:12 +02:00
Robert Schulze
da5a2e2db0
Merge remote-tracking branch 'origin/master' into generated-file-cleanup
Physical merge conflicts:
- src/Common/ZooKeeper/ZooKeeperImpl.cpp
- src/Core/config_core.h.in
- src/Functions/FunctionsAES.h
- src/Functions/config_functions.h.in
- src/configure_config.cmake

Logical merge conflicts:
- Functions/tryDecrypt.cpp
2022-10-06 08:43:25 +00:00
Anton Popov
8ca73eab03
Merge branch 'master' into fuzz-table-definitions 2022-10-04 15:10:31 +02:00
Alexey Milovidov
5d710e21f1 Render progress directly in tty 2022-10-01 23:19:36 +02:00
Robert Schulze
cc92a2d174
Merge branch 'master' into generated-file-cleanup 2022-09-30 09:56:31 +02:00
Anton Popov
c97bec829a slightly better 2022-09-28 21:47:10 +00:00
Anton Popov
34bc16cd5b avoid more useless errors 2022-09-28 15:55:39 +00:00
Anton Popov
4ac5df2540 drop all fuzzed tables 2022-09-28 14:52:10 +00:00
Robert Schulze
6d70b4a1f6
Generate config_version.h into ${CONFIG_INCLUDE_PATH}
This makes the target location consistent with other auto-generated
files like config_formats.h, config_core.h, and config_functions.h and
simplifies the build of clickhouse_common.
2022-09-28 12:48:26 +00:00
Anton Popov
c8beae8237 Merge remote-tracking branch 'upstream/master' into HEAD 2022-09-28 12:47:02 +00:00
Yakov Olkhovskiy
1d6c6c7144
change to --accept-invalid-certificate 2022-09-25 20:54:04 -04:00
Yakov Olkhovskiy
57e875d08c add parameter --accept-certificate, set appropriate invalid certificate handling 2022-09-24 04:46:19 +00:00
Alexey Milovidov
bac578b23a
Merge pull request #41428 from ClickHouse/remove-dlopen
Remove `dlopen`
2022-09-18 00:09:57 +03:00
Alexey Milovidov
ada7a44ae4 Remove -WithTerminatingZero methods 2022-09-17 05:34:18 +02:00
Alexey Milovidov
35cce03125 Remove dlopen 2022-09-17 03:02:34 +02:00
Antonio Andelic
e64436fef3 Fix typos with new codespell 2022-09-02 08:54:48 +00:00
Robert Schulze
e8b3f56733
Limit suppression to a specific warning 2022-08-21 18:24:17 +00:00
Alexey Milovidov
74e1f4dc61 Fix clang-tidy 2022-08-20 17:09:20 +02:00
Nikita Taranov
17956cb668
Extend protocol with query parameters (#39906) 2022-08-12 14:28:35 +02:00
Anton Popov
0383250383 execute DROP queries for fuzzed tables 2022-08-12 00:32:21 +00:00
Anton Popov
e347fa2f45 add fuzzer for table definition 2022-08-11 02:34:10 +00:00
Anton Popov
4f2c73f9f6 Merge remote-tracking branch 'upstream/master' into HEAD 2022-08-04 23:08:15 +00:00
Vitaly Baranov
da0bdd474b Fix code style. 2022-07-21 10:48:53 +02:00
Vitaly Baranov
8873d16afe Fix interactive client with older server after https://github.com/ClickHouse/ClickHouse/pull/38970 2022-07-20 11:51:55 +02:00
Vitaly Baranov
fbb2e14d54 Add new table function viewIfPermitted(). 2022-07-15 15:44:29 +02:00
Anton Popov
14a3c7b8cf print changed MergeTree settings on fail 2022-07-13 20:57:24 +00:00
Anton Popov
499262dba9 allow to randomize merge tree settings 2022-07-07 22:16:01 +00:00
Alexey Milovidov
7e9a3796e9 Fix wrong docs 2022-06-21 00:09:55 +02:00
Azat Khuzhin
29a8a00656 Add ability to pass QueryKind via clickhouse-client/local (useful for debugging)
v2: fix LocalConnection::sendQuery() for Suggest (comes w/o client_info) [1]
    [1]: https://s3.amazonaws.com/clickhouse-test-reports/37290/7c85175963226ff78eec542efafcff4e650aa0f0/stateless_tests__ubsan__actions_.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-05-19 07:19:27 +03:00
Robert Schulze
e3cfec5b09
Merge remote-tracking branch 'origin/master' into clangtidies 2022-05-16 10:12:50 +02:00
kssenii
61f2737e17 Merge master 2022-05-10 19:31:22 +02:00
kssenii
0feda67ec4 Fix progress for insert select 2022-05-10 15:04:08 +02:00
Robert Schulze
1b81bb49b4
Enable clang-tidy modernize-deprecated-headers & hicpp-deprecated-headers
Official docs:

  Some headers from C library were deprecated in C++ and are no longer
  welcome in C++ codebases. Some have no effect in C++. For more details
  refer to the C++ 14 Standard [depr.c.headers] section. This check
  replaces C standard library headers with their C++ alternatives and
  removes redundant ones.
2022-05-09 08:23:33 +02:00
Alexey Milovidov
a121155f0a Fix conflict 2022-05-07 12:38:30 +02:00
Alexey Milovidov
1bdc51a496 Merge branch 'remind_for_external_option' of github.com:bigo-sg/ClickHouse into bigo-sg-remind_for_external_option 2022-05-07 12:36:57 +02:00
Robert Schulze
89aa9ae00f
Fixed clang-tidy check "bugprone-branch-clone"
The check is currently *not* part of .clang-tidy. It complains about:
(1) "switch has multiple consecutive identical branches"
(2) "repeated branch in conditional chain"

About (1): Lots of findings in switches were about redundant
"[[fallthrough]]" in places where the compiler would not warn anyways. I
have cleaned these up.

About (2): In if-else_if-else chains, fixing the warning would usually
mean concatenating multiple if-conditions. As this would reduce
readability in most cases, I did not fix these places.

Because of (2), I also refrained from adding "bugprone-branch-clone" to
.clang-tidy.
2022-04-30 19:40:28 +02:00
Amos Bird
4a5e4274f0
base should not depend on Common 2022-04-29 10:26:35 +08:00
Suzy Wang
59f0e83c4b
fix clang tidy warning, add nullptr check (#35540)
update passing reference instead of pointer in queryHasWithClause based on recommandation

Co-authored-by: larryluogit <larry.luo@ca.ibm.com>
2022-04-20 11:26:44 +02:00
Anton Popov
13cb564d1e
Merge pull request #35716 from kssenii/fix-local-logs-level
Fix send_logs_level for clickhouse local
2022-04-06 18:52:47 +02:00
Kseniia Sumarokova
d3763c4a62 Update ClientBase.h 2022-04-06 12:13:34 +02:00
Alexey Milovidov
3c0c1a1176 Add a comment #35919 2022-04-05 18:35:23 +02:00
Alexey Milovidov
e452949334
Merge pull request #35919 from DevTeamBK/clang-tidy-issues
Clang tidy issues
2022-04-05 19:31:09 +03:00
Meena Renganathan
cf71b18472 Modified the code to fix the getenv() call issue idenitified in the clang-tidy 2022-04-04 07:23:31 -07:00
Denny Crane
0722beca0c
Update Client.cpp 2022-03-30 08:45:30 -03:00
李扬
b84904b8a6
Update Client.cpp 2022-03-23 22:01:29 +08:00
taiyang-li
1114c54899 merge master and fix conflict 2022-03-23 11:03:25 +08:00
mergify[bot]
5295dd0ef2
Merge branch 'master' into stress-test 2022-03-17 11:10:37 +00:00
Kruglov Pavel
ea5ace7b18
Merge pull request #35309 from Avogar/fix-client-host-help
Fix disappeared host and port from client help message
2022-03-16 12:24:07 +01:00
Vladimir C
e022245a33
Merge pull request #35193 from vdimir/issue-34776 2022-03-15 19:56:09 +01:00
avogar
96c6a4b401 Fix disappeared host and port from client help message 2022-03-15 18:36:54 +00:00
vdimir
db46c2ada8
Fix reading port from config 2022-03-14 11:58:47 +00:00
kssenii
199188be08 Support test mode for clickhouse-local 2022-03-14 12:02:06 +01:00
taiyang-li
4f15955670 fix conflicts 2022-03-08 11:32:22 +08:00
taiyang-li
2283513fc8 merge master and solve conflict 2022-03-08 11:29:00 +08:00
Kruglov Pavel
dbba752398
Merge branch 'master' into stress-test 2022-03-04 18:33:37 +03:00
mergify[bot]
c90d24e10b
Merge branch 'master' into random-settings 2022-03-03 13:07:12 +00:00
avogar
d25d83580a Fix tests 2022-03-02 16:33:21 +00:00
freedomDR
43ac214dc5 get credentials from environment variables for clickhouse-client
include CLICKHOUSE_USER, CLICKHOUSE_PASSWORD
2022-03-02 00:54:51 +00:00
李扬
f2ce7cbc8f
Update Client.cpp 2022-03-01 19:29:59 +08:00
taiyang-li
7f69507c95 finish dev 2022-03-01 17:22:12 +08:00
mergify[bot]
8014cdf9d3
Merge branch 'master' into random-settings 2022-02-28 14:06:22 +00:00
vdimir
dfc990aed4
Fix using host/port from config for client 2022-02-21 12:08:23 +00:00
avogar
ba7f723961 Fix comments 2022-02-18 13:54:21 +00:00
Kruglov Pavel
e77319bf01
Merge branch 'master' into stress-test 2022-02-17 20:28:46 +03:00
avogar
1e797c1a8f Fix some tests 2022-02-16 15:10:02 +00:00
Kruglov Pavel
e8d855ef4c
Update description 2022-02-15 15:12:21 +03:00
Kruglov Pavel
767bcabd5b
Fix style 2022-02-10 14:21:41 +03:00
Kruglov Pavel
8947c5de11
Update description
Co-authored-by: Vladimir C <vdimir@clickhouse.com>
2022-02-10 14:07:21 +03:00
avogar
75c56163a0 Refactor client fault tolerant connection 2022-02-10 12:43:08 +03:00
DF5HSE
e657219e01 Delete not used include 2022-02-08 12:40:44 +03:00
DF5HSE
c08bc7ad65 Merge branch 'master' of github.com:ClickHouse/ClickHouse into client-fault-tolerant-connection 2022-02-08 11:37:31 +03:00
DF5HSE
b035ad7843 Fix error with IPv6 in host param and impove HostPort reading from input stream 2022-02-08 02:03:39 +03:00
DF5HSE
3cb433762b Fix errors in build check 2022-02-08 02:03:39 +03:00
DF5HSE
3343a22788 Merge branch 'client-fault-tolerant-connection' of github.com:ManagedDatabases/ClickHouse into client-fault-tolerant-connection 2022-02-08 02:03:38 +03:00
Filippov Denis
226759b674 Update programs/client/Client.cpp
Fix `--host` parameter description

Co-authored-by: Kruglov Pavel <48961922+Avogar@users.noreply.github.com>
2022-02-08 02:03:38 +03:00
DF5HSE
18a777cc8b Add function which gets port from configuration 2022-02-08 02:03:37 +03:00
DF5HSE
a9ff296960 Fix codestyle 2022-02-08 02:03:36 +03:00
DF5HSE
e780c1292d Add tests, remove saving host in config 2022-02-08 02:03:35 +03:00
DF5HSE
19cf4e6dec round robin connection on fail 2022-02-08 02:03:25 +03:00
Anton Popov
5bb1b3ce77 support async inserts in clickhouse-client for queries with inlined data 2022-02-02 20:59:37 +03:00
Kruglov Pavel
b54bf18b27
Merge branch 'master' into stress-test 2022-01-25 14:35:42 +03:00
DF5HSE
fb2a45009a Fix formatting 2022-01-20 00:44:37 +03:00
DF5HSE
c126afa93b Fix formatting 2022-01-20 00:44:12 +03:00
DF5HSE
76769ac133 Fix formatting 2022-01-20 00:43:40 +03:00
DF5HSE
aa328fa4d8 Fix formatting 2022-01-20 00:42:29 +03:00
DF5HSE
a4a46be697 Revert changes in Client.h 2022-01-20 00:37:42 +03:00
DF5HSE
0d7e853614 Delete extra includes 2022-01-20 00:36:18 +03:00
DF5HSE
b46af3e0c4 Add list of '<host>:[<port>]' reading in --host param 2022-01-20 00:36:18 +03:00
DF5HSE
f6d50f6fd3 Add list of hosts reading 2022-01-20 00:15:11 +03:00
avogar
0ae0aa712b Don't print exception twice in client in case of exception in parallel parsing 2022-01-11 18:37:07 +03:00
Azat Khuzhin
0685fd9985 clickhouse-local: track memory under --max_memory_usage_in_client option 2021-12-31 11:06:15 +03:00
Kruglov Pavel
ffb6c5b37b
Merge branch 'master' into stress-test 2021-12-23 20:14:15 +03:00
Azat Khuzhin
57c027be0e Remove arcadia build support 2021-12-11 21:25:23 +03:00
avogar
81d45dbf66 Fix possible crash in fuzzer 2021-12-08 21:29:50 +03:00
mergify[bot]
ce0c112586
Merge branch 'master' into stress-test 2021-11-25 11:09:26 +00:00
Azat Khuzhin
bbbbd261b8 Add --pager support for clickhouse-local 2021-11-16 22:25:32 +03:00
mergify[bot]
923874060a
Merge branch 'master' into stress-test 2021-11-16 16:42:50 +00:00
Kseniia Sumarokova
846fbd059b
Merge pull request #31403 from kssenii/fix-client-output
Fix client
2021-11-14 15:01:30 +03:00
kssenii
ad1b7c83cd Fix 2021-11-14 07:19:59 +00:00
Kseniia Sumarokova
2313981fd7
Merge pull request #31260 from azat/external-cleanup
Cleanup extern ProfileEvents/CurrentMetrics and add a style check
2021-11-12 00:02:57 +03:00
Azat Khuzhin
baf14444e6 Cleanup ProfileEvents and CurrentMetrics 2021-11-10 21:15:27 +03:00
Alexander Tokmakov
9d83832bde show warning if some obsolete setting changed 2021-11-10 18:49:13 +03:00
kssenii
26c4affc18 Fixes 2021-11-04 11:00:35 +00:00
mergify[bot]
8ef9e61e36
Merge branch 'master' into stress-test 2021-11-03 08:28:43 +00:00
kssenii
feb3d8bc75 Merge branch 'master' of github.com:ClickHouse/ClickHouse into clickhouse-local-improve 2021-11-02 20:01:15 +00:00
kssenii
e97233f33d Fix --verbose in local and logging 2021-10-30 17:23:24 +03:00
kssenii
07bab5193f Delayed interactive 2021-10-29 16:23:53 +03:00
mergify[bot]
d9d9d38e4f
Merge branch 'master' into stress-test 2021-10-27 19:00:31 +00:00
Kseniia Sumarokova
15bdfdc9f6
Update Client.cpp 2021-10-25 10:47:22 +03:00
mergify[bot]
943a1cbba0
Merge branch 'master' into stress-test 2021-10-21 04:41:23 +00:00
kssenii
ec7c93728b Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into fix-local-exceptions 2021-10-20 23:42:27 +00:00
Kruglov Pavel
003955b59f
Merge branch 'master' into clickhouse-local 2021-10-18 14:24:08 +03:00
kssenii
91e9ab7760 Fix tests 2021-10-16 19:30:35 +00:00
kssenii
5db75f9e77 Better exception 2021-10-16 11:30:24 +00:00
avogar
be4fc79d32 Better handling exceptions, update tests 2021-10-15 18:30:32 +03:00
Kruglov Pavel
8d1c51c422
Update Client.cpp 2021-10-14 18:18:04 +03:00
avogar
ba7b784646 Remove catching boost::program_options error in Client 2021-10-14 16:36:32 +03:00
avogar
a1a4df2501 Fix handling exception 'unrecognised option' in clickhouse-local and client 2021-10-14 16:34:05 +03:00
Nikolai Kochetov
3d3e143c29
Merge pull request #30001 from ClickHouse/remove-streams-from-formats
Remove streams from formats.
2021-10-14 12:39:07 +03:00
Nikolai Kochetov
ec18340351 Remove streams from formats. 2021-10-11 19:11:50 +03:00
Dmitry Novik
362bcb2f66 Introduce ProfileEvents packet 2021-10-11 17:29:50 +03:00
mergify[bot]
0910a8ec74
Merge branch 'master' into stress-test 2021-10-05 09:46:18 +00:00
Azat Khuzhin
bbee102e58 Fix --stage for clickhouse-local
This also fixes UBsan error, since query_processing_stage was not
initialized before for clickhouse-local.
2021-10-04 21:00:48 +03:00
Pavel Kruglov
2db11bc6c5 Add backward compatibility check in stress test 2021-10-04 16:34:14 +03:00
Kseniia Sumarokova
ddc775b1c8
Merge pull request #29626 from kssenii/fix-signals
Follow-up for #26231
2021-10-03 22:13:54 +03:00
alexey-milovidov
921c5ce4c3
Merge pull request #29660 from azat/client-fuzzer-fixes
Do not try to fuzz `USE`/`SET` queries and print stacktrace
2021-10-02 22:01:33 +03:00
Azat Khuzhin
4d5ca0f409 client: do not try to fuzz USE queries 2021-10-02 11:17:17 +03:00
Azat Khuzhin
a419fe6633 client: don not try to fuzz SET queries
They were forbidden in QueryFuzzer.cpp anyway, this is just a patch to
avoid trying to do this and update comment.
2021-10-02 11:16:53 +03:00
kssenii
e10255bba3 Fix 2021-10-02 08:10:34 +00:00
Alexey Milovidov
fe6b7c77c7 Rename "common" to "base" 2021-10-02 10:13:14 +03:00
kssenii
dabab85c60 Fix 2021-10-01 17:31:00 +00:00
kssenii
05181c6900 Fix 2021-10-01 14:13:02 +00:00
kssenii
f3784780fd Fixes 2021-09-25 08:46:57 +00:00
kssenii
04575eb12b Review fixes, fix style check and clang-tidy 2021-09-22 21:35:29 +00:00
kssenii
8d19ed5ee7 Fix remaining tests 2021-09-20 05:39:13 +00:00
kssenii
55619dcc1b Correct merge 2021-09-16 16:14:17 +00:00
kssenii
c88dc460d4 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into interactive-mode-for-clickhouse-local 2021-09-16 16:13:04 +00:00
mergify[bot]
d731bf6c4d
Merge branch 'master' into compressed_output_formats_3473 2021-09-13 09:14:35 +00:00
Azat Khuzhin
1c18118ee4 client/TestTags.cpp: add missing <cstring> 2021-09-13 09:44:14 +03:00
Vitaly Baranov
512786346c
Merge pull request #28909 from vitlibar/convert-skip-list-into-first-line-comments
Convert skip_list .json into first line comments
2021-09-13 03:37:39 +03:00
Vitaly Baranov
bbb192ee85 Convert skip_list.json into first line comments. 2021-09-12 17:15:23 +03:00
kssenii
ec0a43dcd5 Correct merge with master 2021-09-11 17:14:32 +00:00
Azat Khuzhin
baac2e561c Add query to the exception message in case of error during processing INSERT block on client
Since client process the INSERT block itself, and only after, send it
to the client, for example:

    clickhouse-client --stacktrace --input_format_null_as_default=1 --query="INSERT INTO FUNCTION null('k Int, v Tuple(Int,Int)') VALUES ()"
    Code: 62. DB::Exception: Cannot parse expression of type Int32 here: ): While executing ValuesBlockInputFormat: (in query: INSERT INTO FUNCTION null('k Int, v Tuple(Int,Int)') VALUES ()): data for INSERT was parsed from query. (SYNTAX_ERROR), Stack trace (when copying this message, always include the lines below):
2021-09-11 16:02:01 +03:00
kssenii
ca81c13775 Move readArguments to base 2021-09-11 11:49:42 +00:00
kssenii
ddfe1e4d64 Some fixes 2021-09-11 11:34:22 +00:00
Azat Khuzhin
09f43d21a8 client: print query on client exception only in non-interactive mode 2021-09-10 21:02:55 +03:00
Azat Khuzhin
f0f31ab8f3 client: print full query in case of server exception 2021-09-10 21:02:54 +03:00
Azat Khuzhin
af5072db50 client: print full query in case of test hints failures 2021-09-10 21:02:54 +03:00
Filatenkov Artur
c92a096d2d
Update Client.cpp 2021-09-10 19:58:52 +03:00