thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-04 13:32:13 +00:00
Code Issues Packages Projects Releases Wiki Activity
49,449 Commits 9,179 Branches 1,782 Tags 2.3 GiB
21c1a2e44d
Commit Graph

6013 Commits

Author SHA1 Message Date
Amos Bird
ca7a5ccd0d
More resize 2020-10-13 09:56:35 +08:00
Vitaly Baranov
eddd26cf3a Fix deadlock in InterpreterGrantQuery. 2020-10-13 01:03:47 +03:00
Azat Khuzhin
2947eff878 Fix query hang with connections_with_failover_max_tries = 0 (endless loop) 2020-10-12 22:07:26 +03:00
Azat Khuzhin
bba44d0f0e Add IF EXISTS for removing inner table of the materialized view 
Instead of playing with has_inner_table flag, which looks a bit icky.
 2020-10-12 21:46:07 +03:00
Azat Khuzhin
d16adddb41 Fix drop of materialized view with inner table in Atomic database 
Materialized view drop the inner table (if any) drop the drop() method,
and this will lead to essure recursive drop() from the drop worker
thread, which will hang:

    3  std::__1::condition_variable::wait<> ()
    4  DB::DatabaseCatalog::waitTableFinallyDropped (this=0x7ffff7831500, uuid=...) at ../src/Interpreters/DatabaseCatalog.cpp:828
    5  DB::InterpreterDropQuery::executeToTable (this=this@entry=0x7fff16ff88a0, table_id_=..., query=...) at ../src/Interpreters/InterpreterDropQuery.cpp:135
    6  DB::InterpreterDropQuery::execute (this=this@entry=0x7fff16ff88a0) at ../contrib/libcxx/include/string:1474
    7  DB::executeDropQuery (kind=kind@entry=DB::ASTDropQuery::Drop, global_context=..., target_table_id=...) at ../src/Storages/StorageMaterializedView.cpp:156
    8  DB::StorageMaterializedView::drop (this=0x7ffefc348f40) at ../src/Storages/StorageMaterializedView.cpp:169
    9  DB::DatabaseCatalog::dropTableFinally (this=this@entry=0x7ffff7831500, table=...) at ../src/Interpreters/DatabaseCatalog.cpp:775
    10 DB::DatabaseCatalog::dropTableDataTask (this=0x7ffff7831500) at ../src/Interpreters/DatabaseCatalog.cpp:745

Fix this by dropping the inner table just before scheduling job the the
drop worker thread.
 2020-10-12 21:46:07 +03:00
Vitaly Baranov
b8019f2bc7 Fix deadlocks in RoleCache. 2020-10-12 21:40:05 +03:00
tavplubix
748b75ab1b
Merge pull request #15767 from ClickHouse/fix_materialize_mysql_count_v2 
Try fix select count() for MaterializeMySQL (another way)
 2020-10-12 14:41:38 +03:00
Nikolai Kochetov
2a62a91af4
Merge pull request #15662 from ClickHouse/fix-15529 
Fix read from Buffer table with empty nested table with different types.
 2020-10-12 14:12:11 +03:00
alesapin
6732e5c217 Fix alter default validation 2020-10-12 14:02:35 +03:00
Amos Bird
47fcd8bffb
Fix some problems introduced by refactoring. 2020-10-12 17:58:09 +08:00
Amos Bird
d2dcfc3f0d
Refactor processors. 2020-10-12 17:30:05 +08:00
hexiaoting
39367be57a Add Support for OFFSET_FETCH_CLAUSE 2020-10-12 16:46:49 +08:00
alesapin
5b5dd4fb28 Fix order by desc after alter 2020-10-12 11:28:47 +03:00
Nikolai Kochetov
190fd88af9
Merge pull request #15785 from amosbird/e1 
Code refactor.
 2020-10-12 00:36:36 +03:00
Nikolai Kochetov
9b42bfdc36
Merge pull request #15817 from ClickHouse/new-block-for-functions-2 
Use `ColumnsWithTypeAndName` instead of `Block` for function calls [part 2]
 2020-10-12 00:32:58 +03:00
Nikolai Kochetov
23aec1f954 Fix build. 2020-10-11 22:44:20 +03:00
alexey-milovidov
760e2ca29c
Update formatReadableTimeDelta.cpp 2020-10-11 22:43:04 +03:00
Nikolai Kochetov
3a17c2a7ac Rename FunctionArguments to ColumnsWithTypeAndName 2020-10-11 22:20:20 +03:00
Nikolai Kochetov
0df08dcb36 Rename columns() to size(). 2020-10-11 21:11:39 +03:00
Alexey Milovidov
c8ae1d097a Add comments 2020-10-11 18:24:20 +03:00
Alexey Milovidov
8a252ebef8 Merge remote-tracking branch 'origin/master' into filipecaixeta-master 2020-10-11 17:29:50 +03:00
alexey-milovidov
a8708338f2
Merge pull request #15809 from amosbird/c1 
add print_query_id support for native client
 2020-10-11 13:29:35 +03:00
alexey-milovidov
10e9d14466
Merge pull request #15818 from ClickHouse/style-pragma-once 
Check for #pragma once in headers
 2020-10-11 13:14:09 +03:00
alexey-milovidov
e16c1c781e
Merge pull request #15816 from ClickHouse/change-level-of-some-log-messages 
Change level of some log messages
 2020-10-11 13:13:13 +03:00
Amos Bird
ff665c362f
Add print query id support to client 2020-10-11 10:09:08 +08:00
alexey-milovidov
39e58128cd
Merge pull request #15812 from ClickHouse/bigint-hash 
Minor changes in BigInt hash
 2020-10-11 01:11:30 +03:00
alexey-milovidov
1187903b44
Merge pull request #15813 from ClickHouse/remove-useless-metrics 
Remove useless metrics to avoid confusion
 2020-10-11 01:11:17 +03:00
alexey-milovidov
717c48cbf3
Merge pull request #15814 from ClickHouse/cleanups 
Cleanups
 2020-10-11 01:11:03 +03:00
Alexey Milovidov
452a1b5218 Simplifications 2020-10-11 01:03:03 +03:00
Alexey Milovidov
7541be86cd Fix "Arcadia" 2020-10-10 23:26:36 +03:00
Nikolai Kochetov
3f446b9713 Fix build. 2020-10-10 22:19:46 +03:00
Nikolai Kochetov
780bd424ad Fix build. 2020-10-10 22:11:39 +03:00
Nikolai Kochetov
3099d44a96 Merge branch 'master' into new-block-for-functions-2 2020-10-10 22:09:50 +03:00
Nikolai Kochetov
6d8dc1f8ed Fix style. 2020-10-10 21:44:51 +03:00
Alexey Milovidov
269b6383f5 Check for #pragma once in headers 2020-10-10 21:37:02 +03:00
Nikolai Kochetov
d28325a353 Replace getByPosition to [] 2020-10-10 21:24:57 +03:00
Alexey Milovidov
f42b471de8 Moved functions to separate files; remove copy-paste 2020-10-10 21:23:54 +03:00
Alexey Milovidov
9ca9855f96 Merge branch 'master' into filipecaixeta-master 2020-10-10 20:52:34 +03:00
Alexey Milovidov
7502fad77c Change level of some log messages 2020-10-10 20:47:34 +03:00
alexey-milovidov
1f6c2c8efc
Merge pull request #15803 from ucasFL/tid-function 
Add `tid` and `logTrace` function
 2020-10-10 19:37:04 +03:00
Alexey Milovidov
5b482f4191 Cleanups 2020-10-10 19:31:10 +03:00
Alexey Milovidov
06fcf437fe Addition to prev. revision 2020-10-10 19:02:13 +03:00
Alexey Milovidov
09a31e01e4 Addition to prev. revision 2020-10-10 18:55:42 +03:00
Alexey Milovidov
9f15daf45c Remove useless metrics to avoid confusion 2020-10-10 18:52:44 +03:00
Alexey Milovidov
a2ef0f6cba Minor changes in BigInt hash 2020-10-10 18:46:41 +03:00
robot-clickhouse
554fa482e6 Auto version update to [20.11.1.1] [54442] 2020-10-10 18:39:58 +03:00
Amos Bird
8e0862a0c3
BlockIO can be empty. 2020-10-10 23:25:50 +08:00
feng lv
9438f2f4d2 fix 
fix

fix
 2020-10-10 19:21:11 +08:00
Alexey Milovidov
4f2d4988c6 Fix build on Mac OS 2020-10-10 13:51:57 +03:00
Amos Bird
dbc14655fc
Code refactoring. 2020-10-10 18:22:33 +08:00
Alexey Milovidov
2c71327ff5 Fix build on Mac OS 2020-10-10 11:02:02 +03:00
alexey-milovidov
59cfb87a96
Merge pull request #15799 from ClickHouse/fix-links-in-docs 
Fix ugliness in docs
 2020-10-10 10:48:11 +03:00
Nikolai Kochetov
76a04fb4b4
Merge pull request #15762 from ClickHouse/new-block-for-functions 
Use `ColumnsWithTypeAndName` instead of `Block` for function calls
 2020-10-10 08:50:38 +03:00
feng lv
45925f60c7 fix 2020-10-10 11:20:45 +08:00
feng lv
d39868b853 fix 2020-10-10 10:56:21 +08:00
feng lv
ec87254abe add test 2020-10-10 10:48:15 +08:00
Nikita Mikhaylov
6ac5431804
Merge pull request #15783 from nikitamikhaylov/copier-backquotes 
Merging  #14939
 2020-10-10 02:32:27 +03:00
alexey-milovidov
9d02347e2e
Update FunctionsFormatting.h 2020-10-09 22:55:02 +03:00
alexey-milovidov
0fd007ad9e
Merge pull request #15601 from alexelex/alexelex-master 
Improvement of Quorum Inserts in ClickHouse
 2020-10-09 22:43:53 +03:00
Alexey Milovidov
bd805300bb Whitespace 2020-10-09 22:33:23 +03:00
Azat Khuzhin
064f901ea8 Add ability to preallocate hashtables for hashed/sparsehashed dictionaries 
preallocation can be used only when we know number of rows, and for this
we need:
- source clickhouse
- no filtering (i.e. lack of <where>), since filtering can filter
  too much rows and eventually it may allocate memory that will
  never be used.

For sparse_hash the difference is quite significant, preallocated
sparse_hash hashtable allocates ~33% faster (7.5 seconds vs 5 seconds
for insert, and the difference is more significant for higher number of
elements):

    $ ninja bench-sparse_hash-run
    [1/1] cd /src/ch/hashtable-bench/.cmake && ...ch/hashtable-bench/.cmake/bench-sparse_hash
    sparse_hash/insert: 7.574 <!--
    sparse_hash/find  : 2.14426
    sparse_hash/maxrss: 174MiB
    sparse_hash/time:   9710.51 msec (user+sys)

    $ time ninja bench-sparse_hash-preallocate-run
    [1/1] cd /src/ch/hashtable-bench/.cmake && ...-bench/.cmake/bench-sparse_hash-preallocate
    sparse_hash/insert: 5.0522 <!--
    sparse_hash/find  : 2.14024
    sparse_hash/maxrss: 174MiB
    sparse_hash/time:   7192.06 msec (user+sys)

P.S. the difference for sparse_hashed dictionary with 4e9 elements
(uint64, uint16) is ~18% (4975.905 vs 4103.569 sec)

v2: do not reallocate the dictionary from the progress callback
    Since this will access hashtable in parallel.
v3: drop PREALLOCATE() and do this only for source=clickhouse and empty
    <where>
 2020-10-09 22:28:14 +03:00
Nikolai Kochetov
ef3640c3f7
Merge pull request #15451 from amosbird/scopewith 
Global WITH and WITH propagation.
 2020-10-09 22:16:45 +03:00
Azat Khuzhin
f4f79aa84a Add HashTable::reserve() (for preallocated hashed/sparse_hashed dictionaries) 2020-10-09 21:53:57 +03:00
filipe
09b5e1dbc3 fix FunctionsFormatting error for ARM 2020-10-09 13:46:59 -03:00
Nikolai Kochetov
3898a8ac5f Try fix tests. 2020-10-09 19:05:11 +03:00
feng lv
8a1a41f77b add tid function 2020-10-09 23:49:14 +08:00
alesapin
35165c8ea4
Merge pull request #15756 from CurtizJ/fix-prewhere-with-virtuals 
Fix prewhere with virtual columns
 2020-10-09 18:07:41 +03:00
nikitamikhaylov
88a5302759 Merge branch 'master' of github.com:ClickHouse/ClickHouse into copier-backquotes 2020-10-09 16:26:31 +03:00
Alexandra Latysheva
f6f33168aa fix compilation error 2020-10-09 12:11:21 +00:00
Nikolai Kochetov
9328cea4f1 Supress pvs 2020-10-09 14:35:58 +03:00
Alexandra Latysheva
0594a77b57 fix thread restart for parallel quorum inserts 2020-10-09 11:20:20 +00:00
Nikolai Kochetov
a7fb2e38a5 Use ColumnWithTypeAndName as function argument instead of Block. 2020-10-09 10:41:28 +03:00
filipe
3861a03927 fix pvs check 2020-10-08 20:14:54 -03:00
Alexander Tokmakov
a6178cc876 try fix select count() for MaterializeMySQL 2020-10-08 23:39:24 +03:00
tavplubix
7b5f2b2bb0
Merge pull request #15701 from ClickHouse/better_clone_replica 
Improvements in lost replica recovery
 2020-10-08 23:19:23 +03:00
alexey-milovidov
c693c653a5
Merge pull request #15639 from GrigoryPervakov/tmp-s3-merge 
Use tmp disk for vertical merge files
 2020-10-08 20:58:07 +03:00
Alexandra Latysheva
6877f4aa9c for parallel and non-parallel quorum insertion at the same time 2020-10-08 15:35:41 +00:00
tavplubix
6065a5b65c
Update StorageReplicatedMergeTree.cpp 2020-10-08 16:37:32 +03:00
alexey-milovidov
8ae2bc06a1
Merge pull request #15378 from amosbird/realfix 
Fix multiple column transformers.
 2020-10-08 16:26:48 +03:00
Anton Popov
4bc40421e2
Merge pull request #15731 from CurtizJ/fix-tranform-null-in 
Fix assertion with setting transform_null_in
 2020-10-08 16:12:56 +03:00
Anton Popov
1a6d2bc538 fix prewhere with virtuals columns 2020-10-08 15:59:47 +03:00
Pervakov Grigorii
3a2068f19d Use tmp disk for vertical merge files 2020-10-08 13:49:41 +03:00
alexey-milovidov
9b9a5d9dc8
Merge pull request #15643 from azat/remove-obsolete-settings 
Remove obsolete settings
 2020-10-08 13:30:36 +03:00
alexey-milovidov
342f3b07dc
Merge pull request #15737 from azat/profile-events-fixes 
Fix RealTimeMicroseconds ProfileEvents
 2020-10-08 13:14:15 +03:00
alexey-milovidov
c0cb18b445
Merge pull request #15740 from azat/kafka-memory-accounting 
Take memory allocations from librdkafka threads into account
 2020-10-08 13:12:54 +03:00
Amos Bird
c9ab87ed17
Fix explain syntax 2020-10-08 17:06:04 +08:00
Amos Bird
ac102540d0
Global WITH and WITH propagation. 2020-10-08 15:03:34 +08:00
Azat Khuzhin
1f51de362f Take memory allocations from librdkafka threads into account 2020-10-07 23:18:20 +03:00
alexey-milovidov
e465ce3d49
Merge pull request #15642 from azat/force_data_skipping_indices 
Implement force_data_skipping_indices setting
 2020-10-07 23:14:51 +03:00
Alexander Tokmakov
ffb19fa4bc fix 2020-10-07 22:47:31 +03:00
Azat Khuzhin
3cd71f3357 Cleanup interceptors for librdkafka in StorageKafka 
Wrap them into StorageKafkaInterceptors to allow access to private
fields and add logging inside interceptors if something fails.

This is also preparation for ThreadStatus interceptor.
 2020-10-07 21:42:13 +03:00
Azat Khuzhin
c0e15ba348 Fix RealTimeMicroseconds ProfileEvents 
RUsageCounters::real_time (RealTimeMicroseconds) was constructed from
CLOCK_REALTIME (or similar) in the ThreadStatus::initPerformanceCounters()
(ThreadStatusExt.cpp), while the intention is to store CLOCK_MONOTONIC
(time from boot, i.e. /proc/uptime) values there (in ThreadProfileEvents.h)
 2020-10-07 21:32:36 +03:00
Azat Khuzhin
553f6aa4cd Remove unused functions 2020-10-07 21:30:53 +03:00
alesapin
d093d4c535
Merge pull request #15675 from ClickHouse/fix_races_in_hdfs 
Fix races in libhdfs
 2020-10-07 20:39:40 +03:00
Artem Zuikov
eb1cb506c9
minor code improvement (#15668) 2020-10-07 20:20:07 +03:00
Nikolai Kochetov
54e77e906e
Merge pull request #15717 from ClickHouse/fix-array-join-optimisation-for-mv 
Fix array join optimisation for MV
 2020-10-07 20:19:35 +03:00
Anton Popov
cc451e41f5 fix assertion with transform_null_in 2020-10-07 18:36:34 +03:00
Latysheva Alexandra
f43ad338ed
Merge pull request #12 from alexelex/quorum_inserts_2 
style check
 2020-10-07 18:56:14 +06:00
Alexandra Latysheva
8f8872dc42 style check 2020-10-07 12:24:46 +00:00
Latysheva Alexandra
6c26f77380
Merge pull request #11 from alexelex/quorum_inserts_2 
changing the condition for updateQuorum, specialized it and reduced t…
 2020-10-07 17:49:20 +06:00