Commit Graph

82266 Commits

Author SHA1 Message Date
Azat Khuzhin
08f4f45fd9 Fix Context leak (recursive context reference) in StorageSQLite
CI founds after LSan had been fixed [1]:

    01889_sqlite_read_write:                                                [ FAIL ] 8.32 sec. - return code: 1

    =================================================================
    ==20649==ERROR: LeakSanitizer: detected memory leaks

    Indirect leak of 1968 byte(s) in 1 object(s) allocated from:
        0 0xc5c1ffd in operator new(unsigned long) (/usr/bin/clickhouse+0xc5c1ffd)
        1 0x25e32d0d in std::__1::__unique_if<DB::StorageInMemoryMetadata>::__unique_single std::__1::make_unique<DB::StorageInMemoryMetadata, DB::StorageInMemoryMetadata const&>(DB::StorageInMemoryMetadata c>
        2 0x25e32d0d in DB::IStorage::setInMemoryMetadata(DB::StorageInMemoryMetadata const&) obj-x86_64-linux-gnu/../src/Storages/IStorage.h:194:22
        3 0x29bdee98 in DB::StorageSQLite::StorageSQLite(DB::StorageID const&, std::__1::shared_ptr<sqlite3>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std:>
        4 0x25ee61d6 in std::__1::shared_ptr<DB::StorageSQLite> shared_ptr_helper<DB::StorageSQLite>::create<DB::StorageID, std::__1::shared_ptr<sqlite3> const&, std::__1::basic_string<char, std::__1::char_tr>
        5 0x25ee61d6 in DB::TableFunctionSQLite::executeImpl(std::__1::shared_ptr<DB::IAST> const&, std::__1::shared_ptr<DB::Context const>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1:>

    SUMMARY: AddressSanitizer: 171256 byte(s) leaked in 130 allocation(s).

  [1]: https://github.com/ClickHouse/ClickHouse/runs/4929706698?check_suite_focus=true

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-01-26 12:56:27 +03:00
Azat Khuzhin
0fe1f070fa Fix getauxval() in glibc-compatibility
getauxval() from glibc-compatibility did not work always correctly:

- it does not work after setenv(), and this breaks vsyscalls,
  like sched_getcpu() [1] (and BaseDaemon.cpp always set TZ if timezone
  is defined, which is true for CI [2]).

  [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1163404
  [2]: https://github.com/ClickHouse/ClickHouse/pull/32928#issuecomment-1015762717

- another think that is definitely broken is LSan (Leak Sanitizer), it
  relies on worked getauxval() but it does not work if __environ is not
  initialized yet (there is even a commit about this).

  And because of, at least, one leak had been introduced [3]:

    [3]: https://github.com/ClickHouse/ClickHouse/pull/33840

Fix this by using /proc/self/auxv.

And let's see how many issues will LSan find...

I've verified this patch manually by printing AT_BASE and compared it
with output of LD_SHOW_AUXV.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-01-26 12:56:27 +03:00
zvonand
3879137994 Merge branch 'master' of github.com:ClickHouse/ClickHouse into issue_14648 2022-01-26 12:33:21 +03:00
mergify[bot]
1c0af06011
Merge branch 'master' into PF202201261620 2022-01-26 08:32:38 +00:00
cnmade
532c3b98ef Translate zh/faq/general/mapreduce: translate adjust 2022-01-26 16:30:30 +08:00
tavplubix
9e91a9dfd1
Merge pull request #33429 from zzsmdfj/MaterializeMySQL_support_set_and_other_dataType
MaterializeMySQL support SET YEAR TIME GEOMETRY dataType
2022-01-26 11:29:46 +03:00
cnmade
f8b3f76104 Translate zh/faq/general/mapreduce: remove bak file 2022-01-26 16:27:42 +08:00
cnmade
bb1760537b Translate zh/faq/general/mapreduce: translate to zh 2022-01-26 16:27:14 +08:00
cnmade
57658a1654 Translate zh/faq/general/mapreduce: reimport file 2022-01-26 16:22:03 +08:00
cnmade
fa894f4041 Translate zh/faq/general/mapreduce: remove bak 2022-01-26 16:21:06 +08:00
mergify[bot]
d6c9c61cff
Merge branch 'master' into PF202201261010 2022-01-26 08:11:15 +00:00
alesapin
677a7f1133
Merge pull request #33990 from ClickHouse/cancel-lambda
Cancel lambda
2022-01-26 10:51:21 +03:00
cnmade
56939cedfb Translate zh/faq/general/index: remove bak 2022-01-26 10:16:24 +08:00
cnmade
2136a33733 Translate zh/faq/general/index: translate to zh 2022-01-26 10:15:59 +08:00
cnmade
c689dec7ad Translate zh/faq/general/index: reimport file 2022-01-26 10:05:21 +08:00
cnmade
dc52dc2f45 Translate zh/faq/general/index: rename old to bak 2022-01-26 10:03:23 +08:00
Anton Popov
9a34f195bd add comments 2022-01-26 02:24:22 +03:00
Maksim Kita
43604a2e8f Fixed tests 2022-01-25 21:56:29 +00:00
Maksim Kita
bf768a94e8
Merge pull request #33971 from Avogar/fix-ipv6
Fix parsing IPv6 from query parameter and fix IPv6 to string conversion
2022-01-25 22:45:11 +01:00
mergify[bot]
8b9940f295
Merge branch 'master' into patch-6 2022-01-25 21:43:43 +00:00
Maksim Kita
2c7a5e4d4e
Merge pull request #33967 from cnmade/PF202201250933
Translate to zh: use-case/time-serial: remove bak file
2022-01-25 22:24:23 +01:00
alesapin
0105f7e0bc
Merge pull request #33988 from ClickHouse/keeper_and_access
Fix clickhouse server start when replicated access storage depend on keeper
2022-01-25 22:54:43 +03:00
alexey-milovidov
0d6032f0fe
Merge pull request #33962 from ClickHouse/cpp-expr-script
add c++expr script for C++ one-liners
2022-01-25 22:50:18 +03:00
mergify[bot]
00d728a9d2
Merge branch 'master' into PF202201250933 2022-01-25 18:56:50 +00:00
HarryLeeIBM
8b24688afb Issue 7334: Fixed utf8 string case-insensitive searching issue 2022-01-25 13:56:05 -05:00
Mikhail f. Shiryaev
62ddfbe4ab
Use workflow names instead of ID 2022-01-25 18:32:13 +01:00
Mikhail f. Shiryaev
604af8d3b8
Apply black to cancel lambda 2022-01-25 18:28:17 +01:00
Maksim Kita
0cc8b9462b
Merge pull request #33977 from vitlibar/fix-checking-access-for-system-command
Fix checking access for the SYSTEM command.
2022-01-25 17:07:36 +01:00
tavplubix
9f1da9b8b8
Update MaterializedMySQLSyncThread.cpp 2022-01-25 17:25:34 +03:00
Maksim Kita
4507f883e6
Merge pull request #33976 from azat/fix-00985_merge_stack_overflow
Disable parallel run for 00985_merge_stack_overflow
2022-01-25 15:12:47 +01:00
tavplubix
35534a4b92
Update Types.h 2022-01-25 16:42:55 +03:00
alesapin
b8c6481d4c Fix clickhouse server start when replicated access storage depend on keeper 2022-01-25 16:40:12 +03:00
Tiaonmmn
e3b4cef072
Update requirements.md 2022-01-25 20:38:15 +08:00
Vitaly Baranov
cc38fe3fb6 Fix checking access for the SYSTEM command. 2022-01-25 18:54:59 +07:00
Ilya Yatsishin
fe84167c99
Merge pull request #33983 from ClickHouse/docker-green-on-retry
Fix dependencies tree for docker image check
2022-01-25 14:43:00 +03:00
Kruglov Pavel
1b19139f74
Merge pull request #31862 from Avogar/fix-lz4
Try to fix lz4 compression
2022-01-25 14:34:45 +03:00
avogar
356de038ae Fix segfault while parsing corrupted file 2022-01-25 14:31:49 +03:00
Maksim Kita
702ad6e2c8
Merge pull request #33966 from battle-test/patch-2
Removed line break for correct table display
2022-01-25 12:20:14 +01:00
Maksim Kita
ca77f652e2 Fixed style check 2022-01-25 11:13:37 +00:00
Maksim Kita
d9e079da4e Added tests 2022-01-25 11:13:37 +00:00
Maksim Kita
e27332ce10 RangeHashedDictionary added options range_lookup_strategy, convert_null_range_bound_to_open 2022-01-25 11:13:37 +00:00
Maksim Kita
4e7e67e330 Fixed tests 2022-01-25 11:13:37 +00:00
Maksim Kita
c72f7f2147 RangeHashedDictionary added support for range values that extend Int64 type 2022-01-25 11:13:37 +00:00
Maksim Kita
bcbd956b83 RangeHashedDictionary change layout structure 2022-01-25 11:13:37 +00:00
Kruglov Pavel
aa49a826b5
Try to fix tests 2022-01-25 14:11:02 +03:00
Mikhail f. Shiryaev
fb908a31e2
Fix dependencies tree for docker image check 2022-01-25 12:09:10 +01:00
Filatenkov Artur
a30c3d1772
Merge pull request #31645 from karnevil13/karnevil-DOCSUP-18631
* DOCSUP-18631: Edit and translate
2022-01-25 14:02:51 +03:00
Amos Bird
385caa3e0a
Separate base parts out of SystemLog 2022-01-25 18:48:43 +08:00
Nikolay Degterinsky
5edbae6734 Merge branch 'master' into classification 2022-01-25 10:22:47 +00:00
Azat Khuzhin
7111f411df check-style: ignore comments for currentDatabase() check
Inaccurate, but should OK for check-style scripts.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-01-25 13:16:45 +03:00