Commit Graph

39227 Commits

Author SHA1 Message Date
Antonio Andelic
6c3765c8b6 Small fix 2023-03-24 20:40:45 +00:00
Antonio Andelic
e38aa298f4 Merge branch 'master' into more-batching-keeper 2023-03-24 19:44:29 +00:00
kssenii
47d91b63ae Fix 2023-03-24 20:34:42 +01:00
avogar
d00587202d Make better 2023-03-24 19:25:07 +00:00
Dmitry Novik
0638f31a09
Merge pull request #47727 from ClickHouse/const-aggregation-key-fix
Fix aggregation with constant key in planner
2023-03-24 19:47:20 +01:00
Nikolai Kochetov
82f7c60e38
Merge pull request #47726 from k-morozov/feature/add_SourceStep_optimize
Add optimization for MemoryStorageStep
2023-03-24 17:56:10 +01:00
Maksim Kita
5cb2d30563
Merge pull request #47316 from ClickHouse/vdimir/transform_external_query_analyzer
Support transformQueryForExternalDatabase for analyzer
2023-03-24 17:53:00 +01:00
Vitaly Baranov
1badc3cba0
Move information about current hosts and list of all hosts to BackupCoordination (#47971)
to simplify the code and help implementing other features.

Co-authored-by: Nikita Mikhaylov <mikhaylovnikitka@gmail.com>
2023-03-24 17:38:19 +01:00
kssenii
9dc9f67f93 Get rid of metadata references 2023-03-24 17:18:41 +01:00
Raúl Marín
bf7b0c5cfe Different approach to inject timeouts 2023-03-24 17:12:14 +01:00
Sema Checherinda
1e462e02ed add ut 2023-03-24 17:00:04 +01:00
kssenii
16ebfcc3f8 Better delegate disks handle mutual path 2023-03-24 16:21:19 +01:00
avogar
ee0fd39f2a Fix data-race 2023-03-24 15:20:19 +00:00
Nikita Taranov
42cafb4872 clearer 2023-03-24 16:04:48 +01:00
Arthur Passos
ef4f860b62 namespace fix 2023-03-24 11:51:22 -03:00
Antonio Andelic
f353561204 Avoid breaking batches with read requests 2023-03-24 14:37:40 +00:00
Anton Popov
fd567e03a5
Merge pull request #47796 from CurtizJ/fix-zlib-mmap
Fix reading from storage `File` compressed files with `zlib` and `gzip` compression
2023-03-24 15:36:21 +01:00
Nikolai Kochetov
a2182f2659
Merge pull request #47874 from amosbird/correct_exact_rows_before_limit
Correct `exact_rows_before_limit` in some scenarios
2023-03-24 15:09:42 +01:00
kssenii
0d89be20b0 Review fixes 2023-03-24 14:45:03 +01:00
Alexander Gololobov
afe3af230f Limit keeper request batching by size in bytes 2023-03-24 14:41:09 +01:00
Коренберг Марк
6df169dce3 Fix #36971: Watchdog: exit with non-zero code if child process exits 2023-03-24 16:04:09 +03:00
Robert Schulze
0712627c05
Query cache: Fix config naming ambiguity
Add 'max_' prefix to 'size' setting to make it more clear that the cache
consumes no space if not used.
2023-03-24 12:52:09 +00:00
Kruglov Pavel
97592cfdfd
Merge branch 'master' into Avogar-patch-2 2023-03-24 13:44:28 +01:00
zvonand
3f2afd6f6e fix 2023-03-24 13:35:09 +01:00
MikhailBurdukov
cc92eacb3e Merged several tests into one and rm unnecessary func 2023-03-24 11:51:09 +00:00
Robert Schulze
3628d11405
Fix "Field value too long" in catboostEvaluate()
Fixes #47616
2023-03-24 11:02:55 +00:00
Nikolai Kochetov
46e50b17e4 Fixing test 2023-03-24 10:35:47 +00:00
Nikolai Kochetov
8917e1ad57 Fixing test 2023-03-24 09:40:12 +00:00
Antonio Andelic
52541e5e23
Merge pull request #47885 from ClickHouse/more-s3-events
Add more S3 write profile events
2023-03-24 09:48:34 +01:00
MikhailBurdukov
68118388e6 Rename opt key, added test and refactored code. 2023-03-24 08:23:22 +00:00
Alexander Tokmakov
4c9b63ccc0
Merge pull request #47916 from ClickHouse/fix_logical_error_in_distributed
Fix logical error in DistributedSink
2023-03-24 04:43:45 +03:00
Alexander Tokmakov
cd7d1fb990
Revert "Revert "Revert "Backup_Restore_concurrency_check_node""" 2023-03-24 04:35:50 +03:00
Alexander Tokmakov
4dde73c3eb
Merge pull request #47917 from ClickHouse/fix_terminate_in_check_thread
Fix terminate in parts check thread
2023-03-24 04:22:00 +03:00
Alexander Tokmakov
ef57253518
Merge pull request #47950 from ClickHouse/fix_http_warning
Set content-length for empty POST requests
2023-03-24 04:19:04 +03:00
pufit
a9089da350 Remove debug comment 2023-03-23 20:36:33 -04:00
pufit
fd1d8d5c55 Third attempt to fix crash. 2023-03-23 19:00:20 -04:00
Robert Schulze
bd02627869
Update docs for parseDateTime() (follow-up to #46815) 2023-03-23 21:28:03 +00:00
Robert Schulze
e84764f4e1
Merge pull request #46815 from bigo-sg/to_timestamp
Add new function parseDateTime/parseDateTimeInJodaSyntax
2023-03-23 22:20:18 +01:00
Nikolai Kochetov
81bef1cb4b Fixing build. 2023-03-23 21:18:30 +00:00
Nikolai Kochetov
a4771812cb Fixing build. 2023-03-23 20:46:42 +00:00
Arthur Passos
d13aa3c029 missing change 2023-03-23 17:42:55 -03:00
Arthur Passos
2491128b08 Add unit test to assert arrow lib does not abort on fatal logs 2023-03-23 17:40:04 -03:00
Nikolai Kochetov
73e98de46d Merge branch 'master' into aggregate-projections-analysis-query-plan 2023-03-23 21:28:36 +01:00
ltrk2
f46970671d Implement tokenbf_v1 index utilization for hasTokenCaseInsensitive 2023-03-23 12:24:13 -07:00
Maksim Kita
24b9e5103f
Merge pull request #47748 from ClickHouse/revert-47721-revert-47622-analyzer-planner-fixes-before-enable-by-default
Revert "Revert "Analyzer planner fixes before enable by default""
2023-03-23 22:20:34 +03:00
Kruglov Pavel
9003b7d789
Fix tsan error lock-order-inversion 2023-03-23 20:14:32 +01:00
Nikolai Kochetov
ed4a5b2be8 Fix test. Pre-build index for query dag in projection. 2023-03-23 18:39:41 +00:00
Nikolai Kochetov
e9bb7efef6 Fix fuzzed test. 2023-03-23 18:27:30 +00:00
Antonio Andelic
3ae09c6ce8
Merge branch 'master' into more-s3-events 2023-03-23 18:23:53 +01:00
Alexander Tokmakov
9bf4f0108e set content-length for empty POST requests 2023-03-23 18:02:31 +01:00
Nikolai Kochetov
0f01725d8b
Merge pull request #45689 from alexX512/master
Add an option to show the partial result on query cancellation
2023-03-23 17:34:15 +01:00
vdimir
c2a3679959
Add buildSelectQueryInfo to Planner/Utils, use in unit tests 2023-03-23 15:53:22 +00:00
Anton Popov
49079ee85c fix build 2023-03-23 15:31:36 +00:00
Nikolay Degterinsky
531068df16
Fix exception type in arrayElement (#47909) 2023-03-23 16:01:04 +01:00
ltrk2
3bf2411be1 Make tiny improvements 2023-03-23 10:59:07 -04:00
Azat Khuzhin
2b439f079e
Make backup_threads/restore_threads server settings (#47881)
Those settings can be applied only at start, so it is better to have
them in configuration file instead of user profile settings.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-23 15:44:15 +01:00
Alexander Tokmakov
5b263b9ffe fix 2023-03-23 15:36:17 +01:00
Nikita Taranov
4b635afe49
Set max_final_threads to number of cores by default (#47915) 2023-03-23 15:18:37 +01:00
Alexander Tokmakov
13cd72d2cb
Merge pull request #47903 from ClickHouse/tavplubix-patch-6
Hotfix for too verbose warnings in HTTP
2023-03-23 16:48:35 +03:00
Vitaly Baranov
f49cab91c0
Merge pull request #47002 from ilejn/orphaned_role
Tests for orphaned role fix
2023-03-23 14:09:34 +01:00
Vitaly Baranov
1d9bfca68d
Merge pull request #47919 from vitlibar/improve-replicated-used-defined-functions
Improve replicated user defined functions
2023-03-23 14:07:08 +01:00
kssenii
fcd535124a Better 2023-03-23 14:00:14 +01:00
Alexander Tokmakov
4599707e0b
Merge pull request #47901 from ClickHouse/fix_replicated_db_recovery
Fix for Replicated database recovery
2023-03-23 15:49:12 +03:00
kssenii
3f1d0fa14c Simplify cache loading 2023-03-23 13:46:38 +01:00
Alexander Tokmakov
54314061ab fix logical error on cancellation 2023-03-23 13:13:16 +01:00
kssenii
6dc08b2768 Review fixes 2023-03-23 13:02:16 +01:00
Maksim Kita
7da53bf7e8 Fixed tests 2023-03-23 12:34:23 +01:00
kssenii
b4837af20f Fix race 2023-03-23 12:21:58 +01:00
flynn
02c666d06d fix 2023-03-23 11:14:12 +00:00
Antonio Andelic
b57e82ded6 Add S3 write profile events 2023-03-23 09:05:41 +00:00
SmitaRKulkarni
04822a63e1
Merge pull request #47586 from ClickHouse/revert-47581-revert-47216-Backup_Restore_concurrency_check_node
Revert "Revert "Backup_Restore_concurrency_check_node""
2023-03-23 10:02:00 +01:00
Amos Bird
a41ba1e6a7
Fix more cases 2023-03-23 14:52:33 +08:00
李扬
88d430a8f0
Merge branch 'master' into to_timestamp 2023-03-23 14:35:45 +08:00
flynn
b5e17cc2c0 fix 2023-03-23 06:24:58 +00:00
robot-clickhouse
1aeba53b92
Merge pull request #47908 from evillique/fix-grant-query-formatting
Fix GRANT query formatting
2023-03-23 05:47:43 +01:00
taiyang-li
e07114a6e3 fix overflow issue of readNumberWithVariableLength 2023-03-23 12:13:51 +08:00
robot-ch-test-poll1
e57ad91940
Merge pull request #47902 from CheSema/fix_retry_exhaust
throw exception when all retries exhausted
2023-03-23 05:10:37 +01:00
flynn
e7afe0f60f fix 2023-03-23 04:08:36 +00:00
Vitaly Baranov
b0fb8fecee Make names in ZooKeeper consistent with non-replicated storage. 2023-03-23 02:50:18 +01:00
Vitaly Baranov
14cae25bd3 Allow start without ZooKeeper. 2023-03-23 02:47:50 +01:00
zvonand
b9bbda3a6f add test + fix 2023-03-23 01:42:00 +01:00
robot-ch-test-poll3
a31c0d8eee
Merge pull request #47883 from ClickHouse/drop-column-with-projections
Fix DROP COLUMN with ReplicatedMergeTree containing projections
2023-03-22 23:55:16 +01:00
Alexander Tokmakov
e3c798bae5 fix terminate in parts check thread 2023-03-22 23:46:15 +01:00
pufit
f69c432f5f Second attempt to fix crash. 2023-03-22 18:23:11 -04:00
Alexander Tokmakov
89c43bec3e
Update HTTPServerRequest.cpp 2023-03-22 23:56:42 +03:00
MikhailBurdukov
62c8eeb25c Ignoring inaccessible tables for attaching to the materilized view 2023-03-22 20:13:30 +00:00
Nikolay Degterinsky
577130a9f6 Fix GRANT query formatting 2023-03-22 19:17:47 +00:00
Alexander Tokmakov
ef647d602b
Update HTTPServerRequest.cpp 2023-03-22 21:43:23 +03:00
Nikolai Kochetov
8139d7d4b3 Fix match for constants with same values but different types. 2023-03-22 18:24:20 +00:00
Sema Checherinda
e514723256 throw exception when all retries exhausted 2023-03-22 19:11:47 +01:00
Alexander Tokmakov
b70216f9f1 fix for Replicated database recovery 2023-03-22 18:12:42 +01:00
vdimir
426f4ec233
Better transformQueryForExternalDatabase for analyzer 2023-03-22 16:58:34 +00:00
Antonio Andelic
b0aab0d8ca
Merge pull request #47860 from ClickHouse/fix-datetime-lc
Fix DateTime monotonicity check for LowCardinality
2023-03-22 17:56:07 +01:00
Han Fei
02de4ad6df address comments 2023-03-22 17:50:19 +01:00
Han Fei
575c4263a3 address comments 2023-03-22 17:47:25 +01:00
kssenii
5ee5e2c339 Remove fixme 2023-03-22 17:37:49 +01:00
kssenii
5b7f214ea9 Better names for some methods 2023-03-22 17:34:29 +01:00
Maksim Kita
f45dac99c2 Revert "Revert "Analyzer planner fixes before enable by default"" 2023-03-22 17:19:32 +01:00
kssenii
9b9cf13607 Add comment 2023-03-22 17:01:31 +01:00
Nikolai Kochetov
04a1e41233 Review fixes. 2023-03-22 16:01:28 +00:00
kssenii
876fb55156 Remove redundant code 2023-03-22 16:51:30 +01:00
kssenii
c35deb8094 Review fixes 2023-03-22 16:49:33 +01:00
Kseniia Sumarokova
48bba254ad
Merge pull request #47854 from azat/psql-fix-empty-query
Improve empty query detection for PostgreSQL (for pgx golang driver)
2023-03-22 16:45:50 +01:00
Nikolai Kochetov
d7d3722b76 Revert analyzer till later. 2023-03-22 15:41:54 +00:00
Amos Bird
02c5d1f364
Correct exact_rows_before_limit in all senarios 2023-03-22 23:26:31 +08:00
kssenii
419d9a4887 Fix typo from previous commit 2023-03-22 15:11:14 +01:00
Vitaly Baranov
e70577a46e
Merge pull request #47861 from azat/restore-correct-pool
Use restore_threads (not backup_threads) for RESTORE ASYNC
2023-03-22 14:14:23 +01:00
Vitaly Baranov
7515af0be1
Merge pull request #47657 from vitlibar/improve-thread_pool
Improve ThreadPool
2023-03-22 13:31:01 +01:00
Nikita Mikhaylov
301e26b23d
Parallel replicas. Part 2.5 (#47858) 2023-03-22 13:05:38 +01:00
Antonio Andelic
b832840cf3 Recalculate always projections on mutations in ReplicatedMergeTree 2023-03-22 11:21:23 +00:00
Robert Schulze
784b34f5d8
Merge pull request #47869 from ClickHouse/rs/bug-47530
Add REGEXP operator
2023-03-22 10:31:25 +01:00
taiyang-li
db6efaa339 fix failed uts 2023-03-22 16:53:47 +08:00
taiyang-li
94175b79a7 Merge branch 'master' into to_timestamp 2023-03-22 16:46:44 +08:00
taiyang-li
d850c5a526 change as request 2023-03-22 16:45:46 +08:00
Maksim Kita
4dc5a629c3
Merge pull request #47758 from ClickHouse/vdimir/comparsion_tuple_elimination_ast
Add ComparisonTupleEliminationVisitor
2023-03-22 11:22:25 +03:00
Maksim Kita
40b077c22b
Merge pull request #47506 from CurtizJ/get-subcolumn
Better support of identifiers from compound expressions in analyzer
2023-03-22 11:19:25 +03:00
SmitaRKulkarni
464b166e91
Merge pull request #47725 from ClickHouse/46741_Parameterized_view_support_subquery
Support for subquery in parameterized views
2023-03-22 09:05:26 +01:00
flynn
dba352274c fix 2023-03-22 08:05:00 +00:00
vdimir
6919db3d46 Fix test_mysql_protocol 2023-03-22 08:59:04 +01:00
vdimir
a5cca40cf0 Pass ConvertToASTOptions by constref 2023-03-22 08:59:04 +01:00
vdimir
ebd71f226c Support SETTINGS argument of table functions 2023-03-22 08:59:04 +01:00
vdimir
023d14a894 Support transformQueryForExternalDatabase for analyzer 2023-03-22 08:59:04 +01:00
Antonio Andelic
ad2f5ba0d6 Fix datetime monotonicity check for LC 2023-03-22 07:41:31 +00:00
flynn
ef6b891f28 fix 2023-03-22 02:47:04 +00:00
kssenii
da05e63f2e Simplify code 2023-03-21 23:14:25 +01:00
kssenii
2376f3a298 Review fixes 2023-03-21 22:50:16 +01:00
Robert Schulze
5091bd42f0
Add REGEXP operator (Bug: 47530) 2023-03-21 21:29:19 +00:00
Nikolay Degterinsky
ccb0d7df00
Merge branch 'master' into evillique-patch-1 2023-03-21 22:13:12 +01:00
Vitaly Baranov
4318212c73 Make a condition more clear. 2023-03-21 21:52:59 +01:00
Vitaly Baranov
096d0132af More corrections. 2023-03-21 21:52:59 +01:00
Vitaly Baranov
0a0e9d060f Corrections after review. 2023-03-21 21:52:59 +01:00
Vitaly Baranov
85d38493f6 Improve ThreadPool
ThreadPool::setMaxThreads() can now start new threads (if there are scheduled jobs in the queue for them);
ThreadPool::setMaxFreeThreads() can now finish free threads.
2023-03-21 21:52:59 +01:00
Alexander Tokmakov
c114361879
Update MergeTreeData.h 2023-03-21 23:15:59 +03:00
Nikolay Degterinsky
3a8314c13e
Merge pull request #47576 from HarryLeeIBM/hlee-s390x-storage-gen
Fix SipHash hashing and byte order in GenerateRandom for s389x
2023-03-21 21:06:08 +01:00
Alexander Tokmakov
8a71e42f08
Merge pull request #47769 from HarryLeeIBM/hlee-s390x-partid
Fix partition ID byte order for s390x
2023-03-21 23:01:36 +03:00
Alexander Tokmakov
7adb1e296c
Merge pull request #47839 from vitlibar/remove-wrong-assert
[FixTests] Remove wrong chassert() in UserDefinedSQLObjectsLoaderFromZooKeeper.cpp
2023-03-21 23:00:53 +03:00
Alexander Tokmakov
0989dd837a
Merge pull request #47802 from ClickHouse/fix_some_tests
Fix 993 and two other tests
2023-03-21 22:20:06 +03:00
Azat Khuzhin
1ebbfac721 Use restore_threads (not backup_threads) for RESTORE ASYNC
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-21 20:35:00 +02:00
Nikolai Kochetov
b432fa1122 Attempt to use new analyzer. 2023-03-21 17:56:58 +00:00
Smita Kulkarni
aa079efbb7 Addressed review comments 2023-03-21 18:29:26 +01:00
vdimir
c25170381c
Better ComparisonTupleEliminationVisitor 2023-03-21 16:23:09 +00:00
vdimir
030ee3a525
Add ComparisonTupleEliminationVisitor 2023-03-21 16:11:06 +00:00
Azat Khuzhin
d45d55969a Improve empty query detection for PostgreSQL (for pgx golang driver)
From PostgreSQL documentation [1]:

    If a completely empty (no contents other than whitespace) query string
    is received, the response is EmptyQueryResponse followed by
    ReadyForQuery.

  [1]: https://www.postgresql.org/docs/current/protocol-flow.html

So without it it will try to process the query and send "Empty query"
instead, that's why it is important.

Refs: 9ae852eb58/conn.go (L388)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-21 17:48:55 +02:00
zvonand
83ee185fce upd 2023-03-21 16:33:19 +01:00
flynn
db31af84c3 fix build 2023-03-21 15:09:10 +00:00
Alexander Tokmakov
9c4c7948e5
Update src/Interpreters/Session.cpp
Co-authored-by: alesapin <alesapin@clickhouse.com>
2023-03-21 17:39:45 +03:00
Alexander Tokmakov
be4884d07a
Update src/Interpreters/Session.cpp
Co-authored-by: alesapin <alesapin@clickhouse.com>
2023-03-21 17:39:40 +03:00
Antonio Andelic
85641a1bf8
Merge pull request #47820 from ClickHouse/odbc-roundtrip-flaky
Make 01086_odbc_roundtrip less flaky
2023-03-21 15:37:02 +01:00
flynn
db7582e060 AST fuzzer support fuzzing SELECT query to EXPLAIN query randomly 2023-03-21 14:26:39 +00:00
Alexander Tokmakov
17e1c6be8e fix race condition on session close 2023-03-21 15:01:39 +01:00