Commit Graph

6753 Commits

Author SHA1 Message Date
Denis Zhuravlev
66e775ef88 test for decimal ( p , s) in dictionaries 2021-02-19 14:53:34 -04:00
alexey-milovidov
2299930c31
Merge pull request #20545 from kssenii/rabbit-format-settings
rabbitmq: add missing format factory settings
2021-02-19 20:24:17 +03:00
alexey-milovidov
91de5628f0
Merge pull request #20866 from CurtizJ/fix-distinct-state
Fix usage of 'distinct' combinator with 'state' combinator
2021-02-19 20:22:53 +03:00
tavplubix
3509fe88d8
Merge pull request #20878 from ClickHouse/fix_18926
Fix COM_FIELD_LIST response in MySQL protocol
2021-02-19 19:25:54 +03:00
Maksim Kita
b84112a603 Function sumMap decimal fix 2021-02-19 19:25:50 +03:00
Denis Glazachev
8cc72b8fe0 Merge branch 'master' into row-policy-with-prewhere
* master: (160 commits)
  Make Poco HTTP Server zero-copy again (#19516)
  Fixed documentation
  ccache 4.2+ does not requires any quirks for SOURCE_DATE_EPOCH
  Add a function `htmlOrXmlCoarseParse` to extract content from html or xml format string. (#19600)
  Reinterpret function added Decimal, DateTim64 support
  Add test
  Update InterpreterSelectQuery.cpp
  Improved serialization for data types combined of Arrays and Tuples. Improved matching enum data types to protobuf enum type. Fixed serialization of the Map data type. Omitted values are now set by default.
  Log stdout and stderr when failed to start docker in integration tests.
  Added comment
  Don't backport base commit of branch in the same branch (#20628)
  Fix fasttest retry for failed tests
  Dictionary create source with functions crash fix
  Added error reinterpretation tests
  Update run.sh
  Updated documentation
  fix subquery with limit
  Rename untyped function reinterpretAs into reinterpret
  ignore data store files
  Support vhost
  ...
2021-02-19 19:49:37 +04:00
Denis Glazachev
bfccfd9eec Fix tests
Add tests
WIP: Failures are legit!
2021-02-19 19:32:35 +04:00
kssenii
30f0e48777 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into fix-postgres-numeric 2021-02-19 14:53:27 +00:00
Ivan
414f470c79
Make Poco HTTP Server zero-copy again (#19516)
* Refactoring: part 1

* Refactoring: part 2

* Handle request using ReadBuffer interface

* Struggles with ReadBuffer's

* Fix URI parsing

* Implement parsing of multipart/form-data

* Check HTTP_LENGTH_REQUIRED before eof() or will hang

* Fix HTTPChunkedReadBuffer

* Fix build and style

* Fix test

* Resist double-eof

* Fix arcadian build
2021-02-19 15:51:26 +03:00
Nikolai Kochetov
866dfaec79
Update 01731_async_task_queue_wait.sh 2021-02-19 15:25:22 +03:00
Maksim Kita
71c65b5d82
Merge pull request #20611 from kitaisreal/rename-untyped-function-reinterpret-as
Rename untyped function reinterpretAs into reinterpret
2021-02-19 14:35:00 +03:00
Nikolai Kochetov
df1cf481cf
Update 01731_async_task_queue_wait.sh 2021-02-19 14:14:31 +03:00
Nikolai Kochetov
8f8a4f6423
Update 01731_async_task_queue_wait.sh 2021-02-19 13:59:38 +03:00
Amos Bird
fc1885ea9b
Try fixing flaky tests 2021-02-19 17:28:01 +08:00
Alexey Milovidov
a9d9a6d56f Merge branch 'master' into in-memory-compression 2021-02-19 12:01:33 +03:00
Alexey Milovidov
8e8a81883e Merge branch 'master' into in-memory-compression 2021-02-19 11:59:11 +03:00
Denis Glazachev
879d9206c1 Add tests for row-level security with prewhere 2021-02-19 02:47:28 +04:00
Nikolai Kochetov
f4b0b1110c Fix test. 2021-02-18 23:53:40 +03:00
Azat Khuzhin
7bcfe92cd7 Mark 01730_distributed_group_by_no_merge_order_by as long
https://clickhouse-test-reports.s3.yandex.net/20882/af660140c320ca45bca0edfd89000b3c6da8ee6a/functional_stateless_tests_flaky_check_(address).html#fail1
2021-02-18 23:29:38 +03:00
Azat Khuzhin
9c01869090 Fix 'Empty task was returned from async task queue' on query cancellation 2021-02-18 22:15:21 +03:00
Azat Khuzhin
af660140c3 Do only merging of sorted blocks on initiator with distributed_group_by_no_merge=2
When distributed_group_by_no_merge=2 is used (or when
optimize_distributed_group_by_sharding_key takes place), remote servers
will do full ORDER BY, so initiator can skip this step and do only merge
of ordered blocks.
2021-02-18 21:43:27 +03:00
Alexander Tokmakov
8097532cb7 Merge branch 'master' into database_replicated 2021-02-18 17:42:06 +03:00
Alexander Tokmakov
97f4c457ec fix MySQL COMM_FIELD_LIST response 2021-02-18 16:27:51 +03:00
Nikolai Kochetov
0449546bca Support TotalsHaving. Update test. 2021-02-18 16:13:09 +03:00
alesapin
1245710aed Merge branch 'master' into persistent_nukeeper_log_storage 2021-02-18 15:27:01 +03:00
Amos Bird
cac9c7fc07
Fix tests 2021-02-18 20:20:28 +08:00
Amos Bird
2dc7ba160a
Better 2021-02-18 20:20:28 +08:00
Amos Bird
77fd060665
Normalize function names 2021-02-18 20:20:28 +08:00
kssenii
2aad067e7c Support conversion for postgres numeric without precision and scale 2021-02-18 12:16:58 +00:00
zlx19950903
c92e613b82
Add a function htmlOrXmlCoarseParse to extract content from html or xml format string. (#19600)
* add html and xml coarse parse

* add test file

* add conditional check: hyperscan

* fix style error

* add conditional check

* bug fix

* delete unit

* typos check fix

* add unit test

* style check fix

* fix build error: case style

* acradis_skip test fix

* LINT error fix

* Remove comments

Co-authored-by: guojiantao <guojiantao15@mails.ucas.ac.cn>
Co-authored-by: Ivan <5627721+abyss7@users.noreply.github.com>
Co-authored-by: Ivan Lezhankin <ilezhankin@yandex-team.ru>
2021-02-18 15:05:55 +03:00
alesapin
7f815325ba More tests for broken changelog read 2021-02-18 14:42:09 +03:00
Kruglov Pavel
419962dbfb
Merge pull request #20712 from kssenii/add-test
Add test for already fixed odbc Postgres date type conversion
2021-02-18 13:43:17 +03:00
alesapin
5b597fdf44 Force sync setting and ability to start with broken log 2021-02-18 13:23:48 +03:00
Maksim Kita
4278098f9a Reinterpret function added Decimal, DateTim64 support 2021-02-18 13:09:01 +03:00
Maksim Kita
dcabbc95ed
Merge pull request #20623 from kitaisreal/dictionary-create-source-with-functions-fix
Dictionary create source with functions crash fix
2021-02-18 11:50:20 +03:00
Vitaly Baranov
3cbb325913
Merge pull request #20506 from vitlibar/refactor-protobuf-format-io
Improved serialization in Protobuf format.
2021-02-18 11:31:37 +03:00
Nikolai Kochetov
d582160af4 Merge branch 'master' into filter-push-down 2021-02-18 10:58:27 +03:00
M0r64n
1ce9570fcb Fix 01721_engine_file_truncate_on_insert.reference 2021-02-18 07:50:15 +00:00
M0r64n
adf5d24177 Correct file engine settings tests 2021-02-18 11:36:17 +04:00
Ilya Yatsishin
bc1f564d55
Merge pull request #20631 from vitlibar/verbose-message-on-fail-to-start-docker
Log stdout and stderr when failed to start docker in integration tests
2021-02-18 07:54:58 +03:00
Anton Popov
dcba99f4b1 fix usage of 'distinct' combinator with 'state' combinator 2021-02-18 02:19:58 +03:00
Alexey Milovidov
9069318fa6 Merge branch 'master' into in-memory-compression 2021-02-18 00:48:39 +03:00
kssenii
732a1d9ceb Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into add-test 2021-02-17 21:29:04 +00:00
kssenii
62486d6e06 Add test 2021-02-17 19:02:57 +00:00
alexey-milovidov
80e6ad7aae
Merge pull request #20610 from ucasFL/fix-union-distinct-limit
fix subquery with limit
2021-02-17 21:24:10 +03:00
Vitaly Baranov
18e036d19b Improved serialization for data types combined of Arrays and Tuples.
Improved matching enum data types to protobuf enum type.
Fixed serialization of the Map data type.
Omitted values are now set by default.
2021-02-17 20:50:09 +03:00
Vitaly Baranov
c704a8cc45 Log stdout and stderr when failed to start docker in integration tests. 2021-02-17 20:07:03 +03:00
Nikolai Kochetov
e5b9c42860 Update test. 2021-02-17 19:54:37 +03:00
Kseniia Sumarokova
20ff183549
Merge branch 'master' into rabbit-format-settings 2021-02-17 19:01:53 +03:00
alesapin
2de201dd5f Merge branch 'fix_fast_test_retry' into persistent_nukeeper_log_storage 2021-02-17 17:51:50 +03:00
alesapin
499c100b12 Better test 2021-02-17 16:41:43 +03:00
Nikita Mikhaylov
d15bac31ff
Merge pull request #20399 from nikitamikhaylov/keen-wolf-filefuncwithreadbuf
Merging #19204
2021-02-17 16:11:22 +03:00
alesapin
e82bd824d7 Fix restart replica in test 2021-02-17 16:07:59 +03:00
Maksim Kita
b2c09f002f Dictionary create source with functions crash fix 2021-02-17 15:26:00 +03:00
alesapin
9396bae2e2 More reliable test keeper tests 2021-02-17 14:53:47 +03:00
Vladimir
2c99a36228
Merge pull request #19685 from hexiaoting/dev_joinon 2021-02-17 13:22:55 +03:00
Maksim Kita
c608fa1e6a Added error reinterpretation tests 2021-02-17 12:53:12 +03:00
Vitaly Baranov
753f5b84d9
Merge pull request #20106 from vitlibar/fix-quota-consuming
Fix quota consuming
2021-02-17 12:52:43 +03:00
Anton Popov
e5cef576e5
Update subqueries.xml 2021-02-17 12:39:40 +03:00
feng lv
3b40099578 fix subquery with limit 2021-02-17 08:26:52 +00:00
Maksim Kita
5f88f5817f Rename untyped function reinterpretAs into reinterpret 2021-02-17 11:23:24 +03:00
alexey-milovidov
6363d44488
Merge pull request #20498 from azat/dist-parse-dirs-sigsegv-fix
Add proper checks while parsing directory names for async INSERT (fixes SIGSEGV)
2021-02-17 09:43:11 +03:00
kssenii
d79f7c04f6 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into rabbit-format-settings 2021-02-17 06:03:19 +00:00
Alexander Tokmakov
1aac7b3471 Merge branch 'master' into database_replicated 2021-02-17 00:39:56 +03:00
Vitaly Baranov
298130402e SYSTEM queries now consume quota. 2021-02-16 23:54:05 +03:00
Vitaly Baranov
f83be158ba SHOW TABLES is now considered as one query in the quota calculations, not two queries. 2021-02-16 23:53:58 +03:00
alesapin
8717dbd0e2 Missed configs 2021-02-16 22:29:09 +03:00
alesapin
d3e87701d4 Persistent storage 2021-02-16 22:02:18 +03:00
tavplubix
68b427a99d
Merge pull request #20448 from ClickHouse/better_ddl_queue_cleanup
Better distributed DDL queue cleanup
2021-02-16 19:29:50 +03:00
M0r64n
75117389ec Add a couple of QOL file engine settings 2021-02-16 18:50:11 +04:00
vdimir
3e2c9ad011
Merge remote-tracking branch 'origin/master' into dev_joinon 2021-02-16 17:08:10 +03:00
Alexander Tokmakov
7b54b892b5 fix 2021-02-16 17:05:58 +03:00
Nikolai Kochetov
0b315fccc2 Merge branch 'master' into fix-number-of-threads-in-subqueries 2021-02-16 16:29:30 +03:00
Nikita Mikhailov
b404fea18d better 2021-02-16 15:40:09 +03:00
Nikita Mikhailov
6ee98ead05 Merge branch 'master' of github.com:ClickHouse/ClickHouse into keen-wolf-filefuncwithreadbuf 2021-02-16 15:38:03 +03:00
Nikita Mikhailov
7c5d845866 refactor function 2021-02-16 15:37:49 +03:00
vdimir
3d19d0644e
Update join on associativity in some tests 2021-02-16 13:46:25 +03:00
tavplubix
d4b2a37393
Merge pull request #20350 from amosbird/tviewf
Disable table function view in expression
2021-02-16 13:01:13 +03:00
Nikita Mikhaylov
87615c53f6
Merge pull request #20511 from nikitamikhaylov/dictionary-flaky-test
Reduce test scale
2021-02-16 12:36:00 +03:00
Nikolai Kochetov
10f1432c5c Added perftest. 2021-02-16 11:31:17 +03:00
Alexander Tokmakov
bf6f64a3fb Merge branch 'master' into database_replicated 2021-02-16 01:28:19 +03:00
kssenii
2a887b9772 Add missing format factory settings 2021-02-15 22:06:10 +00:00
Alexander Tokmakov
cf57c3b4a2 update comments 2021-02-15 23:01:21 +03:00
Azat Khuzhin
8d11d09615 Add a test for malformed directores for Distributed async INSERT 2021-02-15 21:00:50 +03:00
alesapin
4f919261bd
Merge pull request #20501 from ClickHouse/reset_session_in_test
Fix non-zero session reconnect in integration test
2021-02-15 21:00:41 +03:00
alesapin
d9a0af5a27
Merge pull request #20496 from ClickHouse/disable_snapshots_in_tests
Disable testkeeper snapshots for tests
2021-02-15 19:10:44 +03:00
Nikita Mikhailov
812641f5a7 add test to arcadia skip list 2021-02-15 16:38:31 +03:00
Nikita Mikhailov
d41b2a4d06 Merge branch 'master' of github.com:ClickHouse/ClickHouse into keen-wolf-filefuncwithreadbuf 2021-02-15 16:15:52 +03:00
Anton Popov
b67b16cdf3
Merge pull request #20476 from amosbird/ctefix2
Fix global-with with subqueries
2021-02-15 16:14:50 +03:00
alexey-milovidov
3429925338
Merge pull request #20492 from ClickHouse/add-test-8654
Add a test for #8654
2021-02-15 15:43:48 +03:00
alexey-milovidov
b75d9a09bd
Merge pull request #20493 from ClickHouse/add-test-10893
Add a test for #10893
2021-02-15 15:36:30 +03:00
alexey-milovidov
c7ab86b8c3
Merge pull request #20472 from ClickHouse/improve-performance-group-by-multiple-fixed-keys
Improve performance of GROUP BY multiple fixed size keys
2021-02-15 15:27:39 +03:00
Nikita Mikhaylov
92e13d76d3
Merge pull request #18508 from depressed-pho/runningConcurrency
Add function runningConcurrency()
2021-02-15 14:39:38 +03:00
Nikita Mikhailov
ac476ad83e done 2021-02-15 14:27:16 +03:00
Alexander Tokmakov
9c7cf9e92e remove some debug code 2021-02-15 13:26:34 +03:00
alesapin
9686649b02 Fix non-zero session reconnect in integration test 2021-02-15 12:42:50 +03:00
Nikita Mikhaylov
a77b740a7c
Merge pull request #20286 from nikitamikhaylov/json-import-bugfix
Error from allocator on JSON import
2021-02-15 12:40:09 +03:00
alesapin
c1550814ca Disable snapshots for tests 2021-02-15 10:30:08 +03:00
Alexey Milovidov
4c7923e6df Add a test for #10893 2021-02-15 05:17:30 +03:00
Alexey Milovidov
c5b96a522e Add a test for #8654 2021-02-15 04:57:34 +03:00
Alexey Milovidov
bc3b0d61f9 Merge branch 'master' into in-memory-compression 2021-02-15 04:12:22 +03:00
Alexey Milovidov
8b7063acf4 Merge branch 'master' into improve-performance-group-by-multiple-fixed-keys 2021-02-15 04:11:01 +03:00
alexey-milovidov
71acb2ffda
Merge pull request #20475 from ClickHouse/intdiv-ubsan-2
Fix UBSan report in intDiv
2021-02-15 04:05:16 +03:00
Alexander Tokmakov
320fd6b264 startup without zk 2021-02-15 03:04:46 +03:00
Alexey Milovidov
459ea4132d Merge branch 'master' into in-memory-compression 2021-02-15 00:00:47 +03:00
Alexey Milovidov
d529db5498 Adjustments 2021-02-14 23:57:25 +03:00
alexey-milovidov
8be8746643
Merge pull request #20461 from azat/join_use_nulls-logical-error-fix
Fix LOGICAL_ERROR for join_use_nulls=1 when JOIN contains const from SELECT
2021-02-14 23:28:50 +03:00
Alexey Milovidov
3bba2cc8b7 Merge branch 'master' into improve-performance-group-by-multiple-fixed-keys 2021-02-14 19:00:04 +03:00
tavplubix
89f2cf52f3
Update skip_list.json 2021-02-14 14:24:54 +03:00
alesapin
17dce00136 Temporary disable 00992_system_parts_race_condition_zookeeper 2021-02-14 10:45:52 +03:00
Amos Bird
ed49367fc7
Fix global-with with subqueries 2021-02-14 14:20:23 +08:00
Alexey Milovidov
55c17ac93f Fix UBSan report in intDiv 2021-02-14 06:11:12 +03:00
Alexey Milovidov
b13d1f3142 Fix integration test 2021-02-14 04:34:42 +03:00
alexey-milovidov
9db6f4a452
Merge pull request #20466 from azat/mt-logging
Improve logging during reading from MergeTree
2021-02-14 04:30:31 +03:00
alexey-milovidov
a0fbc0656b
Merge pull request #20206 from ClickHouse/tavplubix-patch-3
Suppress signed overflow in AggregateFunctionGroupArrayMoving
2021-02-14 03:32:16 +03:00
Alexey Milovidov
5bdc570046 Improve performance of GROUP BY multiple fixed size keys 2021-02-14 01:56:04 +03:00
Denis Glazachev
99a04b6c64 Merge branch 'master' into row-policy-with-prewhere
* master: (759 commits)
  Suppress UBSan report in Decimal comparison
  Suppress UBSan report in Decimal comparison
  Fix UBSan report in arrayDifference
  Update README.md
  Non significant change in AggregationCommon
  Print stack trace on SIGTRAP
  Fix dependent test
  Fix tests for better parallel run
  Add test for already working code
  Revert "Fix access control manager destruction order"
  Update index.md
  Update index.md
  Update index.md
  Bit more complicated example for isIPv4String - ru
  Bit more complicated example for isIPv4String
  cleanup
  Replace database with ordinary
  Added comments
  Split tests to make them stable
  Fixes
  ...

# Conflicts:
#	src/Storages/MergeTree/MergeTreeRangeReader.cpp
2021-02-14 02:24:00 +04:00
Alexander Tokmakov
b0f2a84306 fix bad test 2021-02-14 01:12:10 +03:00
Alexander Tokmakov
96cc01926c Merge branch 'master' into better_ddl_queue_cleanup 2021-02-14 00:22:09 +03:00
Alexander Tokmakov
652ede5af9 add test 2021-02-14 00:06:40 +03:00
Azat Khuzhin
790c210e51 Mark 01508_partition_pruning as long
https://clickhouse-test-reports.s3.yandex.net/20466/ff647ad176ad32718fcfc87677effa0ab37e3f10/functional_stateless_tests_flaky_check_(address).html#fail1
2021-02-13 20:33:03 +03:00
alexey-milovidov
3e9f1dc83b
Merge pull request #20458 from ClickHouse/array-difference-ubsan
Fix UBSan report in arrayDifference
2021-02-13 19:34:44 +03:00
Azat Khuzhin
ff647ad176 Update 01508_partition_pruning expectations 2021-02-13 18:08:55 +03:00
Amos Bird
a551edd8d6
Do not parse view function in expression 2021-02-13 22:12:44 +08:00
Amos Bird
69d4120982
Disable table function view in expression 2021-02-13 21:39:37 +08:00
Ilya Yatsishin
8ff458a2bf
Merge pull request #20459 from ClickHouse/decimal-comparison-ubsan 2021-02-13 12:34:40 +03:00
Azat Khuzhin
4aa46ce3d6 More tests for join_use_nulls
All of them already works, but just in case
2021-02-13 11:05:25 +03:00
Azat Khuzhin
cbeda6c60e Fix LOGICAL_ERROR for join_use_nulls=1 when JOIN contains const from SELECT 2021-02-13 11:05:25 +03:00
alesapin
f80137626a
Merge pull request #19580 from ClickHouse/in_memory_raft
In memory coordination inside ClickHouse
2021-02-13 10:19:23 +03:00
alesapin
2e010bffc8
Merge pull request #20398 from ClickHouse/test_for_alredy_working_code
Add test for sign column drop
2021-02-13 10:17:48 +03:00
Alexey Milovidov
1546f5bcb9 Suppress UBSan report in Decimal comparison 2021-02-13 03:54:38 +03:00
Alexey Milovidov
1c55be261c Fix UBSan report in arrayDifference 2021-02-13 03:45:06 +03:00
Alexander Kuzmenkov
716a3df6eb
Merge pull request #20337 from ClickHouse/aku/window-prototype
window function rank() and friends
2021-02-13 03:03:49 +03:00
alexey-milovidov
2fe2190a20
Merge pull request #19721 from azat/buffer-profile
Add separate config directive for Buffer profile
2021-02-13 02:43:41 +03:00
alexey-milovidov
04701376ac
Merge pull request #20232 from ClickHouse/fix_int_field_to_decimal_conversion
Fix integer Field to Decimal conversion
2021-02-13 02:22:32 +03:00
alexey-milovidov
371e84957a
Merge pull request #20303 from azat/constant-folding-fixes
Do not allow early constant folding of explicitly forbidden functions
2021-02-13 02:20:06 +03:00
alesapin
051c9533b9 Fix dependent test 2021-02-12 22:42:20 +03:00
alesapin
939a3e9555 Fix tests for better parallel run 2021-02-12 22:28:00 +03:00
Alexander Tokmakov
184ec67dac better ddl queue cleanup 2021-02-12 22:23:50 +03:00
Nikita Mikhailov
801d109234 fix 2021-02-12 22:05:31 +03:00
Nikita Mikhailov
2a52aa8ca3 fix test 2021-02-12 20:25:40 +03:00
alesapin
9cbda346bb Add test for already working code 2021-02-12 19:49:27 +03:00
Alexander Tokmakov
f64f9b672b fix 2021-02-12 19:22:01 +03:00
Nikolai Kochetov
5fd80555aa Update test. 2021-02-12 19:06:18 +03:00
Nikolai Kochetov
f1c32c4690 Merge branch 'master' into filter-push-down 2021-02-12 18:26:08 +03:00
Nikita Mikhailov
fcd080631f Merge branch 'master' of github.com:ClickHouse/ClickHouse into keen-wolf-filefuncwithreadbuf 2021-02-12 17:53:18 +03:00
Nikita Mikhaylov
7d02d58390
bump CI 2021-02-12 16:14:34 +03:00
Nikolai Kochetov
683d793cc2 Update test. 2021-02-12 14:31:14 +03:00
Nikita Mikhailov
999062e926 fix test 2021-02-12 13:45:18 +03:00
Alexander Kuzmenkov
824475b224 cleanup 2021-02-12 13:37:27 +03:00
alesapin
a94e223cee
Merge pull request #20344 from azat/join_use_nulls-fix
Fix null dereference with join_use_nulls=1
2021-02-12 12:48:53 +03:00
alesapin
9aadbde86c
Merge pull request #20339 from kitaisreal/decimal-binary-operation-constants-fix
Decimal binary operation constants fix
2021-02-12 12:32:58 +03:00
alesapin
6aecb62416 Replace database with ordinary 2021-02-12 12:17:10 +03:00
alesapin
c883b7d154 Split tests to make them stable 2021-02-12 11:50:20 +03:00
Maksim Kita
e141367bcf
Merge pull request #20345 from azat/RANGE_HASHED-dict-fix
Avoid invalid dereference in RANGE_HASHED() dictionary
2021-02-12 11:05:10 +03:00
alesapin
a2bb586170
Merge pull request #20335 from ClickHouse/fix_scheduling_of_non_successful_background_tasks
Fix backoff for failed background tasks in replicated merge tree
2021-02-12 10:06:04 +03:00
alexey-milovidov
4e32dbd024
Merge pull request #19317 from abyss7/dwarf-folly
Print inline frames for fatal stacktraces
2021-02-12 02:38:50 +03:00
Alexander Tokmakov
c9cf63e958 fix 2021-02-12 01:23:40 +03:00
alesapin
df181b534e Better connection reset 2021-02-11 23:29:01 +03:00
alesapin
5f32f65211 Merge branch 'master' into in_memory_raft 2021-02-11 23:09:29 +03:00
Azat Khuzhin
3993ad6f01 Fix test_system_merges by using mutations_sync=1
After early_constant_folding started to ignore not only ignore(), but
all functions with isSuitableForConstantFolding() == false, there became
more sleep(2) calls for this test:
- MergeTreeDataSelectExecutor::readFromParts -> DB::KeyCondition::KeyCondition
- MergeTreeDataMergerMutator::mutatePartToTemporaryPart -> DB::isStorageTouchedByMutations -> FilterTransform::transform
- MergeTreeDataMergerMutator::mutatePartToTemporaryPart -> DB::MergeTreeDataMergerMutator::mutateAllPartColumns -> FilterTransform::transform

While before it was optimized to 0 during WHERE analysis.
2021-02-11 22:46:56 +03:00
Azat Khuzhin
f6cfcd4da9 Fix null dereference with join_use_nulls=1
Found with MSan [1], the following query triggers null dereference:

```sql
SELECT
    Y.id - 1
FROM X
RIGHT JOIN Y ON (X.id + 1) = Y.id
SETTINGS join_use_nulls=1; -- { serverError 53 }
```

```
Received signal 11
(version 21.3.1.5916, build id: 2E9E84AA32AEAAC7C8B6EB45DA3EC0B4F15E9ED4) (from thread 100) (query_id: 9ab8cb0d-be8d-445e-8498-930a7268488b) Received signal Segmentation fault (11)
Address: 0x10 Access: read. Address not mapped to object.
Stack trace: 0x2d079d65 0x29bf1f30 0x12b12220 0x12b13098 0x12b17b08 0x12b20459 0x2ae37913 0x2ae352d9 0x2c746072 0x2c7585dd 0x2c7483e3 0x2c74e63d 0x2c7483e3 0x2c74e63d 0x2c7483e3 0x2c74e63d 0x2c7483e3 0x2c74e63d 0x2c7483e3 0x2c74e63d 0x2c7483e3 0x2c74e63d 0x2c7483e3 0x2c74e63d 0x2c7483e3 0x2c74e63d 0x2c7483e3 0x2c74e63d
4. ./obj-x86_64-linux-gnu/../contrib/boost/boost/smart_ptr/intrusive_ptr.hpp:0: DB::ColumnConst::ColumnConst(COW<DB::IColumn>::immutable_ptr<DB::IColumn> const&, unsigned long) @ 0x2d079d65 in /workspace/clickhouse
5. ./obj-x86_64-linux-gnu/../src/Common/COW.h:0: DB::createBlockWithNestedColumns(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > const&) @ 0x29bf1f30 in /workspace/clickhouse
6. DB::FunctionOverloadResolverAdaptor::getReturnTypeDefaultImplementationForNulls(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > const&, std::__1::function<std::__1::shared_ptr<DB::IDataType const> (std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > const&)> const&) @ 0x12b12220 in /workspace/clickhouse
7. DB::FunctionOverloadResolverAdaptor::getReturnTypeWithoutLowCardinality(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > const&) const @ 0x12b13098 in /workspace/clickhouse
8. DB::FunctionOverloadResolverAdaptor::getReturnType(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > const&) const @ 0x12b17b08 in /workspace/clickhouse
9. DB::FunctionOverloadResolverAdaptor::build(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > const&) const @ 0x12b20459 in /workspace/clickhouse
```

  [1]: https://clickhouse-test-reports.s3.yandex.net/19451/64c0bf98290362fa216c05b070aa122a12af3c25/fuzzer_msan/report.html#fail1
2021-02-11 21:30:05 +03:00
Azat Khuzhin
2907385400 Avoid invalid dereference in RANGE_HASHED() dictionary
UBsan report the following [1], when query does not contains any columns
from the dictionary:

```sql
SELECT
    toUInt32(toUInt32(NULL, toUInt32(NULL, inf, NULL), NULL)),
    toUInt32(toUInt32(toUInt32(toUInt32(toUInt32(NULL, 1., NULL)), toUInt32(toUInt32(NULL, 0.5, NULL)), toUInt32(NULL, NULL)), toUInt32(toUInt32(NULL, 1., NULL)), toUInt32(NULL, NULL)), toUInt32(toUInt32(toUInt32(toUInt32(NULL, 1000.0001220703125, NULL)), toUInt32(toUInt32(NULL, 10.000100135803223, NULL)), toUInt32(NULL, NULL)), NULL, NULL, NULL))
FROM somedict
```

```
std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> >::back() @ 0x128c07a6 in /workspace/clickhouse
./obj-x86_64-linux-gnu/../src/Dictionaries/RangeDictionaryBlockInputStream.h:0: DB::RangeDictionaryBlockInputStream<DB::RangeHashedDictionary, unsigned short, unsigned long>::fillBlock(DB::PODArray<unsigned long, 4096ul, Allocator<false, false>, 15ul, 16ul> const&, DB::PODArray<unsigned short, 4096ul, Allocator<false, false>, 15ul, 16ul> const&, DB::PODArray<unsigned short, 4096ul, Allocator<false, false>, 15ul, 16ul> const&) const @ 0x1692335e in /workspace/clickhouse
./obj-x86_64-linux-gnu/../src/Dictionaries/RangeDictionaryBlockInputStream.h:0: DB::RangeDictionaryBlockInputStream<DB::RangeHashedDictionary, unsigned short, unsigned long>::getBlock(unsigned long, unsigned long) const @ 0x16922f96 in /workspace/clickhouse
./obj-x86_64-linux-gnu/../src/Dictionaries/DictionaryBlockInputStreamBase.cpp:23: DB::DictionaryBlockInputStreamBase::getHeader() const @ 0x166ab57c in /workspace/clickhouse
```

  [1]: https://clickhouse-test-reports.s3.yandex.net/19451/64c0bf98290362fa216c05b070aa122a12af3c25/fuzzer_ubsan/report.html#fail1
2021-02-11 21:07:37 +03:00
alexey-milovidov
7b55eb8c58
Merge pull request #20178 from amosbird/delayinactive
Delay or throw insertion when too many inactive parts
2021-02-11 20:52:04 +03:00
alexey-milovidov
ac707f7165
Merge pull request #20305 from azat/fix-flaky-tests
Fix 00738_lock_for_inner_table flakiness
2021-02-11 20:46:42 +03:00
alexey-milovidov
d15d340691
Merge pull request #20301 from azat/numbers-numeric-limit
Accept arbitrary numeric types for numbers() arguments (for scientific notation)
2021-02-11 20:41:15 +03:00
Alexander Kuzmenkov
1275be58bf Merge remote-tracking branch 'origin/master' into HEAD 2021-02-11 19:49:37 +03:00
Alexander Kuzmenkov
ebb47595aa
Merge pull request #20293 from ClickHouse/aku/window-prototype-3
make window functions faster
2021-02-11 19:49:02 +03:00
Alexander Kuzmenkov
62b3bf7b57 some tests and speedup 2021-02-11 19:20:57 +03:00
Maksim Kita
248a06f930 Added test 2021-02-11 19:11:07 +03:00
Alexander Kuzmenkov
d8f9a8d3cd first_value and last_value 2021-02-11 18:41:54 +03:00
alesapin
bf4af9713c Fix tests 2021-02-11 18:29:08 +03:00
Alexander Kuzmenkov
ecbcf47f28 lag/lead stubs + cleanup 2021-02-11 18:07:42 +03:00
alexey-milovidov
263d751d64
Merge pull request #20169 from ClickHouse/no-excessive-squash-memory
Disable excessive squashing of blocks for StorageMemory #13052
2021-02-11 16:38:24 +03:00
Alexey Milovidov
c32ed77976 Some queries become too fast 2021-02-11 16:37:46 +03:00
Alexander Kuzmenkov
525400bc41 window function rank() and friends 2021-02-11 16:29:30 +03:00
Nikita Mikhailov
e325ab2538 fix test 2021-02-11 15:00:14 +03:00
alesapin
3253638969 Fix backoff for failed background tasks in replicated merge tree 2021-02-11 14:46:18 +03:00
Nikita Mikhailov
d7dccb8d2c better 2021-02-11 13:43:12 +03:00
alesapin
99a471e047 Add ability to start as follower 2021-02-11 13:25:10 +03:00
alesapin
0acd018361 Fix typo 2021-02-11 12:58:02 +03:00
alesapin
74630acff5 More debug in test 2021-02-11 12:49:49 +03:00
alesapin
b49b7f859d Simplify startup with fixed config 2021-02-11 12:17:57 +03:00
Alexander Kuzmenkov
363007b964 fixes 2021-02-11 11:39:39 +03:00
alesapin
56453256b7
Merge pull request #20300 from ClickHouse/restrict_to_drop_version_column
Don't allow to drop or rename version column
2021-02-11 11:04:00 +03:00
alesapin
121c5c9605
Merge pull request #20279 from ClickHouse/relax_check_in_data_writer
Relax check in data writer for non adaptive tables
2021-02-11 10:57:07 +03:00
Alexander Kuzmenkov
38678ff484 Merge remote-tracking branch 'origin/master' into HEAD 2021-02-11 10:40:05 +03:00
Alexander Kuzmenkov
2571dac984
Merge pull request #20111 from ClickHouse/aku/window-prototype
RANGE OFFSET window frame
2021-02-11 10:39:21 +03:00
Azat Khuzhin
222a0db3f4 Update tests expectations for early_constant_folding 2021-02-11 10:31:58 +03:00
Azat Khuzhin
6845eb36fa Generate query_id based on current database in 00738_lock_for_inner_table
For flaky checker
2021-02-11 10:23:23 +03:00
Azat Khuzhin
ed7e5a26be Generate UUID based on random current database in 00738_lock_for_inner_table 2021-02-11 10:23:23 +03:00
Azat Khuzhin
064deaf3c1 Fix 00738_lock_for_inner_table flakiness
It is possible to execute DROP just before an INSERT will acquire the
lock for the underlying table, and then the test will fail [1]:

    2021-02-09 13:03:27 00738_lock_for_inner_table:                                             [ FAIL ] 3.18 sec. - having stderror:
    2021-02-09 13:03:27 [3eff0fc65d1a] 2021.02.09 13:03:27.440841 [ 220384 ] {test_00738} <Error> executeQuery: Code: 60, e.displayText() = DB::Exception: Table default.`.inner_id.00000738-1000-4000-8000-000000000001` (9647fbaa-a80d-420e-9240-30f5719a84e7) doesn't exist (version 21.3.1.5956) (from [::1]:56964) (comment: '/usr/share/clickhouse-test/queries/0_stateless/01701_if_tuple_segfault.sql') (in query: INSERT INTO tab_00738 SELECT number FROM numbers(10000000)), Stack trace (when copying this message, always include the lines below):
    2021-02-09 13:03:27
    2021-02-09 13:03:27 0. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/exception:133: std::exception::capture() @ 0x10d0a908 in /usr/bin/clickhouse
    2021-02-09 13:03:27 1. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/exception:111: std::exception::exception() @ 0x10d0a8d5 in /usr/bin/clickhouse
    2021-02-09 13:03:27 2. ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Exception.cpp:27: Poco::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0x1e5b4943 in /usr/bin/clickhouse
    2021-02-09 13:03:27 3. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:54: DB::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, bool) @ 0x10cec720 in /usr/bin/clickhouse
    2021-02-09 13:03:27 4. ./obj-x86_64-linux-gnu/../src/Common/Exception.h:38: DB::Exception::Exception<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&&) @ 0x10e82041 in /usr/bin/clickhouse
    2021-02-09 13:03:27 5. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/optional:324: void std::__1::__optional_storage_base<DB::Exception, false>::__construct<int const&, char const (&) [23], std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(int const&, char const (&) [23], std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&&) @ 0x19940df9 in /usr/bin/clickhouse
    2021-02-09 13:03:27 6. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/optional:830: DB::Exception& std::__1::optional<DB::Exception>::emplace<int const&, char const (&) [23], std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, void>(int const&, char const (&) [23], std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&&) @ 0x19939b7a in /usr/bin/clickhouse
    2021-02-09 13:03:27 7. ./obj-x86_64-linux-gnu/../src/Interpreters/DatabaseCatalog.cpp:233: DB::DatabaseCatalog::getTableImpl(DB::StorageID const&, DB::Context const&, std::__1::optional<DB::Exception>*) const @ 0x1992efcf in /usr/bin/clickhouse
    2021-02-09 13:03:27 8. ./obj-x86_64-linux-gnu/../src/Interpreters/DatabaseCatalog.cpp:641: DB::DatabaseCatalog::getTable(DB::StorageID const&, DB::Context const&) const @ 0x19932fba in /usr/bin/clickhouse
    2021-02-09 13:03:27 9. ./obj-x86_64-linux-gnu/../src/Storages/StorageMaterializedView.cpp:376: DB::StorageMaterializedView::getTargetTable() const @ 0x1a5fe2bf in /usr/bin/clickhouse
    2021-02-09 13:03:27 10. ./obj-x86_64-linux-gnu/../src/DataStreams/PushingToViewsBlockOutputStream.cpp:88: DB::PushingToViewsBlockOutputStream::PushingToViewsBlockOutputStream(std::__1::shared_ptr<DB::IStorage> const&, std::__1::shared_ptr<DB::StorageInMemoryMetadata const> const&, DB::Context const&, std::__1::shared_ptr<DB::IAST> const&, bool) @ 0x19e26530 in /usr/bin/clickhouse

And if you will take a look at the 88 line, you will see that this is
just a timing issue.

  [1]: https://clickhouse-test-reports.s3.yandex.net/19673/7bddaba9208232f54095712f0cbfa44c6a5e2564/functional_stateless_tests_(antlr_debug).html#fail1
2021-02-11 10:23:23 +03:00
Azat Khuzhin
dac0c0fa95 Mark 01641_memory_tracking_insert_optimize as long
https://clickhouse-test-reports.s3.yandex.net/20301/3adadeb12bb7d2f4c9405927a28f9f7a49617d46/functional_stateless_tests_flaky_check_(address).html#fail1
2021-02-11 09:56:20 +03:00
Vladimir Ch
73a0e2961b
Merge pull request #20175 from amosbird/countrewrite 2021-02-11 09:38:12 +03:00
Alexey Milovidov
e73a6c9660 Temporary disable LIVE VIEW test 2021-02-11 03:03:21 +03:00
Azat Khuzhin
3adadeb12b Mark 01513_optimize_aggregation_in_order_memory as long
https://clickhouse-test-reports.s3.yandex.net/20301/b6dc721e332e30c7e6dde40282441dd59cfa276e/functional_stateless_tests_flaky_check_(address).html#fail1
2021-02-11 00:46:38 +03:00
alexey-milovidov
e33477a16e
Merge pull request #20282 from ClickHouse/dont_allow_ttl_for_old_syntax
Don't allow TTL in old syntax
2021-02-11 00:46:30 +03:00
Azat Khuzhin
53ea58810e Do not allow constant folding of explicitly forbidden functions 2021-02-11 00:38:47 +03:00
Alexey Milovidov
d3dba0e52a Merge branch 'master' into no-excessive-squash-memory 2021-02-10 23:45:12 +03:00
Alexander Tokmakov
15256d86e5 better replica recovery and queue cleanup 2021-02-10 23:30:40 +03:00