Commit Graph

131352 Commits

Author SHA1 Message Date
Igor Nikonov
2894ad06fd Merge remote-tracking branch 'origin/master' into parallel-replicas-in-subquery 2023-12-23 11:44:45 +00:00
Igor Nikonov
701c8ac9ba Cleanup & comments 2023-12-23 11:44:02 +00:00
Alexey Milovidov
a400657155
Merge pull request #58165 from azat/s3-passthrough-exception
Pass through exceptions for reading from S3
2023-12-23 11:35:23 +01:00
Alexey Milovidov
ff6419361a
Merge pull request #58181 from ClickHouse/remove-parallel-parsing-json-compact-each-row
Remove parallel parsing for JSONCompactEachRow
2023-12-23 10:16:40 +01:00
Alexey Milovidov
d4c7462eef
Merge pull request #58182 from ClickHouse/use-after-move
Fix use-after-move
2023-12-23 10:05:04 +01:00
Azat Khuzhin
896cbb6a75 Retry on poco exceptions while reading from S3 as well
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-23 09:07:43 +01:00
Alexey Milovidov
0ff216534b
Merge pull request #58179 from ClickHouse/obfuscate-query-more-words
Obfuscator: keep settings and timezones
2023-12-23 08:36:33 +01:00
Alexey Milovidov
e4ea1f89d1 Fix FastTest 2023-12-23 08:28:19 +01:00
Alexey Milovidov
468b5e2813 Fix use-after-move 2023-12-23 08:23:15 +01:00
Alexey Milovidov
1c26bae241 Revert wrong changes 2023-12-23 06:39:16 +01:00
Alexey Milovidov
6a23fe034f Remove parallel parsing for JSONCompactEachRow 2023-12-23 06:17:47 +01:00
Alexey Milovidov
ad697a0eac
Merge pull request #58176 from ClickHouse/fix-test-2
Fix flaky test `02719_aggregate_with_empty_string_key`
2023-12-23 05:34:34 +01:00
Alexey Milovidov
490440bde8
Merge pull request #58177 from ClickHouse/fix-data-race-turbo
Fix #58171
2023-12-23 05:33:48 +01:00
Alexey Milovidov
11ca0b7b44
Merge pull request #58137 from ClickHouse/thomoco-patch-4
Update from.md
2023-12-23 05:22:15 +01:00
Alexey Milovidov
bcda9b9d6f
Update from.md 2023-12-23 07:21:43 +03:00
Alexey Milovidov
dc4b9a1013 Obfuscator: keep settings and timezones 2023-12-23 04:55:55 +01:00
Alexey Milovidov
b061535b4a
Merge pull request #58166 from azat/poco-safe-ios
[RFC] Adjust all std::ios implementations in poco to set failbit/badbit by default
2023-12-23 02:11:15 +01:00
Alexey Milovidov
ffca9bc564 Fix #58171 2023-12-23 02:04:35 +01:00
Alexey Milovidov
c91aa27668
Merge pull request #58169 from ClickHouse/tavplubix-patch-11
Update 00165_jit_aggregate_functions.sql
2023-12-23 01:55:17 +01:00
Alexey Milovidov
5dbc7d3184 Fix flaky test 2023-12-23 01:42:29 +01:00
Alexey Milovidov
dcc1f0c428
Merge pull request #58168 from ClickHouse/udpate-statefull-run-sh
Update docker/test/stateful/run.sh
2023-12-23 01:40:53 +01:00
Alexey Milovidov
1c31bb110e
Merge pull request #58170 from ClickHouse/tavplubix-patch-12-1
Update clickhouse-test
2023-12-23 01:39:29 +01:00
Mikhail f. Shiryaev
f06330dd88
Merge pull request #58164 from ClickHouse/helper-improvements
Helper improvements
2023-12-23 00:23:59 +01:00
Azat Khuzhin
17e21aa21e Pass throught exceptions for reading from S3
Reading from S3 has retries on almost any exception, except for
CANNOT_ALLOCATE_MEMORY, but the problem is that this exception may not
be even delivered to ReadBufferFromS3::processException(), due to
std::istream will hide it (see [1]).

  [1]: 1834e42289/libcxx/include/istream (L1059)

So let's pass throught them to see at least some information instead of
just:

    Message: Cannot read from istream at offset 0

And here as an example of exception:

<details>

    (lldb) bt
    * thread 244, name = 'MergeMutate', stop reason = breakpoint 6.1
      * frame 0: 0x000000001aa9c791 clickhouse`::__cxa_throw(thrown_object=0x00007fc3b68fdb00, tinfo=0x000000000548af50, dest=(clickhouse`Poco::Net::NetException::~NetException() at NetException.cpp:26))(void *)) at cxa_exception.cpp:258:33
        frame 1: 0x0000000017c55b2b clickhouse`Poco::Net::SocketImpl::error(code=-1232086272, arg=0x00007fc3be4f4d30) at SocketImpl.cpp:985:3
        frame 2: 0x0000000017c1f7ff clickhouse`Poco::Net::SecureSocketImpl::handleError(int) [inlined] Poco::Net::SocketImpl::error(code=<unavailable>) at SocketImpl.cpp:923:2
        frame 3: 0x0000000017c1f7e4 clickhouse`Poco::Net::SecureSocketImpl::handleError(this=0x00007fc35ae42b30, rc=-1) at SecureSocketImpl.cpp:531
        frame 4: 0x0000000017c208f9 clickhouse`Poco::Net::SecureSocketImpl::receiveBytes(this=0x00007fc35ae42b30, buffer=0x00007fc346e402c4, length=131068, flags=<unavailable>) at SecureSocketImpl.cpp:353:10
        frame 5: 0x0000000017c3b388 clickhouse`Poco::Net::HTTPSession::read(char*, long) [inlined] Poco::Net::StreamSocket::receiveBytes(buffer=<unavailable>, length=<unavailable>, flags=0) at StreamSocket.cpp:130:17
        frame 6: 0x0000000017c3b379 clickhouse`Poco::Net::HTTPSession::read(char*, long) [inlined] Poco::Net::HTTPSession::receive(this=<unavailable>, buffer=<unavailable>, length=<unavailable>) at HTTPSession.cpp:166
        frame 7: 0x0000000017c3b379 clickhouse`Poco::Net::HTTPSession::read(this=0x00007fc3973e9098, buffer=<unavailable>, length=<unavailable>) at HTTPSession.cpp:144
        frame 8: 0x0000000017c0f706 clickhouse`Poco::Net::HTTPSClientSession::read(this=<unavailable>, buffer=<unavailable>, length=<unavailable>) at HTTPSClientSession.cpp:195:23
        frame 9: 0x0000000017c32eb4 clickhouse`Poco::Net::HTTPFixedLengthStreamBuf::readFromDevice(this=0x00007fc361bd6708, buffer=<unavailable>, length=<unavailable>) at HTTPFixedLengthStream.cpp:53:16
        frame 10: 0x0000000017c2a368 clickhouse`Poco::BasicBufferedStreamBuf<char, std::__1::char_traits<char>, Poco::Net::HTTPBufferAllocator>::underflow(this=0x00007fc361bd6708) at BufferedStreamBuf.h:97:17
        frame 11: 0x0000000008b2abca clickhouse`std::__1::basic_streambuf<char, std::__1::char_traits<char> >::uflow(this=0x00007fc361bd6708) at streambuf:445:9
        frame 12: 0x0000000008b2ab5a clickhouse`std::__1::basic_streambuf<char, std::__1::char_traits<char> >::xsgetn(this=0x00007fc361bd6708, __s="P, __n=1048576) at streambuf:422:25
        frame 13: 0x0000000008b2ca0e clickhouse`std::__1::basic_istream<char, std::__1::char_traits<char> >::read(char*, long) [inlined] std::__1::basic_streambuf<char, std::__1::char_traits<char> >::sgetn[abi:v15000](this=<unavailable>, __s="!P, __n=1048576) at streambuf:204:14
        frame 14: 0x0000000008b2ca02 clickhouse`std::__1::basic_istream<char, std::__1::char_traits<char> >::read(this=0x00007fc35ae42d40, __s="!P, __n=1048576) at istream:1052
        frame 15: 0x0000000010de0b9f clickhouse`DB::ReadBufferFromIStream::nextImpl(this=0x00007fc3663d2380) at ReadBufferFromIStream.cpp:15:10

</details>

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-22 23:29:28 +01:00
Mikhail f. Shiryaev
74dd63f956
Add a hack to un-/mark PR as a draft
#job_package_debug
2023-12-22 22:26:38 +01:00
Mikhail f. Shiryaev
e7c22fef7b
Rename ccache_utils to cache_utils 2023-12-22 22:26:37 +01:00
Mikhail f. Shiryaev
b386674ede
Add GitHubCache class, generalize Cache class 2023-12-22 22:26:36 +01:00
Alexander Tokmakov
499984e57a
Merge pull request #58051 from ClickHouse/tavplubix-patch-10
Small improvement for SystemLogBase
2023-12-22 20:24:08 +01:00
Alexander Tokmakov
555128aed6
Merge pull request #58078 from ClickHouse/tavplubix-patch-9
Fix Tests Bugfix Validate Check
2023-12-22 20:01:50 +01:00
Alexander Tokmakov
8f9dff8c88
Update clickhouse-test 2023-12-22 19:54:15 +01:00
Alexander Tokmakov
026ba566e3
Update 00165_jit_aggregate_functions.sql 2023-12-22 19:35:05 +01:00
Igor Nikonov
d3a0869119 Merge remote-tracking branch 'origin/master' into parallel-replicas-in-subquery 2023-12-22 17:54:45 +00:00
Igor Nikonov
ca1ddf0608 Fix style 2023-12-22 17:54:21 +00:00
kssenii
1e19d84811 Update stateful/run.sh 2023-12-22 18:43:29 +01:00
Azat Khuzhin
f066f31514 Adjust all std::ios implementations in poco to set failbit/badbit by default
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-22 18:34:34 +01:00
Igor Nikonov
6f68696c14 Fix: for joins with old analyzer 2023-12-22 17:26:31 +00:00
Mikhail f. Shiryaev
a54dfabf0e
Add full repo name to the PR cache name 2023-12-22 17:52:15 +01:00
Robert Schulze
316970474b
Merge pull request #58075 from rschu1ze/bump-azure-further
Bump Azure to 1.7.2
2023-12-22 16:57:37 +01:00
Alexey Milovidov
08ff37f64e
Merge pull request #57682 from azat/system.stack_trace/analyzer
Add support for system.stack_trace filtering optimizations for analyzer
2023-12-22 16:28:28 +01:00
robot-ch-test-poll2
97c85e6e41
Merge pull request #58147 from cwurm/patch-3
Update insert-into.md: Clarify position of SETTINGS clause
2023-12-22 15:59:17 +01:00
Raúl Marín
c6fe84d3fe
Merge pull request #58073 from anfedotoff/fix-poco-intoverflow
Fix Integer overflow in Poco::UTF32Encoding
2023-12-22 15:19:29 +01:00
Nikolai Kochetov
3cbd895ce1
Merge pull request #57827 from ClickHouse/vdimir/merge_join_array_lowcard
Fix low-cardinality keys support in MergeJoin
2023-12-22 13:34:06 +01:00
vdimir
b06ae8bcee
Merge pull request #57139 from ClickHouse/vdimir/fix_logical_error_analyzer_and_optimize
Analyzer: Fix assert in tryReplaceAndEqualsChainsWithConstant
2023-12-22 13:15:24 +01:00
Yarik Briukhovetskyi
483a377834
Merge pull request #57995 from yariks5s/paste_join
Implementing PASTE JOIN
2023-12-22 12:56:06 +01:00
Christoph Wurm
5d8e5ee5d2
Update insert-into.md: Clarify position of SETTINGS clause
I've recently stumbled several times trying to figure out where to put the `SETTINGS` when inserting `VALUES` and `FROM INFILE`, so I'm clarifying it here in the docs.
2023-12-22 11:40:46 +00:00
Igor Nikonov
17e3e567fa
Merge pull request #58081 from ClickHouse/parallel-replicas-remote
Test for parallel replicas with remote()
2023-12-22 11:18:02 +01:00
Raúl Marín
24f952b2b8
Merge pull request #57986 from Algunenano/zk_retries_quorum
Support keeper failures in quorum check
2023-12-22 11:10:04 +01:00
Alexey Milovidov
7f7e80ea56
Merge pull request #58130 from ClickHouse/integration-tests-images
Use the single images list for integration tests everywhere
2023-12-22 06:04:43 +01:00
Max K
8774f8097f
Run build report check job on build failures, fix (#58135)
* run build report check on build failures #no-merge-commit

* Always run post action in reusable_build

 #no-merge-commit
2023-12-21 21:30:40 +01:00
Alexey Milovidov
dc82aaef06
Merge pull request #58134 from Algunenano/clang_tidy_fix
Fix clang-tidy
2023-12-21 20:25:01 +01:00