Commit Graph

49975 Commits

Author SHA1 Message Date
Alexey Milovidov
2efd740dc7 Added a test 2020-10-25 05:07:52 +03:00
Alexey Milovidov
4bf32cb15b Fix destruction order of Suggest #16035 2020-10-25 05:07:52 +03:00
alexey-milovidov
abb9b25fa0
Merge pull request #16343 from ClickHouse/fix-perf-test-functions-logical
Fix performance test "functions logical" after move to clang
2020-10-25 04:04:24 +03:00
alexey-milovidov
6a8d9b2681
Merge pull request #16341 from ClickHouse/remove-flaky-live-view-test
Remove flaky LIVE VIEW test
2020-10-25 04:01:00 +03:00
alexey-milovidov
c13ab94f91
Merge pull request #16344 from ClickHouse/exclamation-marks
Remove excessive exclamation marks
2020-10-25 03:13:57 +03:00
alexey-milovidov
74b37f37fb
Merge pull request #16329 from ClickHouse/better-diagnostics-when-client-dropped-connection
Better diagnostics when client has dropped connection
2020-10-25 01:01:12 +03:00
Alexey Milovidov
942828f4d5 Check style 2020-10-25 00:54:17 +03:00
Alexey Milovidov
8b21ef5d4f Remove excessive exclamation marks 2020-10-25 00:50:52 +03:00
Alexey Milovidov
9d50921e52 Fix performance test "functions logical" after move to clang 2020-10-24 23:55:17 +03:00
Alexey Milovidov
2e23fc242f Remove flaky LIVE VIEW test 2020-10-24 22:48:16 +03:00
Ivan
1d170f5745
ASTTableIdentifier Part #1: improve internal representation of ASTIdentifier name (#16149)
* Use only |name_parts| as primary name source

* Restore legacy logic for table restoration

* Fix build

* Fix tests

* Add pytest server config

* Fix tests

* Fixes due to review
2020-10-24 21:46:10 +03:00
alexey-milovidov
70427bfa63
Merge pull request #16335 from kexianda/fix
minor fix.
2020-10-24 21:41:35 +03:00
alexey-milovidov
b19311339f
Merge pull request #16121 from azat/total_memory_tracker-by-default
Significantly decrease MemoryTracking drift
2020-10-24 21:36:38 +03:00
alexey-milovidov
34b9d15b66
Update ThreadStatusExt.cpp 2020-10-24 21:34:54 +03:00
alexey-milovidov
e00f6c4a0d
Merge branch 'master' into total_memory_tracker-by-default 2020-10-24 21:17:53 +03:00
Nikita Mikhaylov
58b4342998
Merge pull request #15874 from nikitamikhaylov/welch-t-test
Student and Welch t-test
2020-10-24 15:13:12 +03:00
Xianda Ke
97d84dd855 minor fix.
redundant variable, duplicated defination of the variable aad_data
compiler error: variable ‘aad_value’ set but not used [-Werror=unused-but-set-variable]
2020-10-24 17:37:51 +08:00
alexey-milovidov
1a1a6350aa
Merge pull request #16285 from sundy-li/cmake-roaring
try use cmake version for croaring instead of amalgamation.sh
2020-10-24 11:07:32 +03:00
alexey-milovidov
1b3604e855
Merge pull request #16334 from ClickHouse/check-bom
Add check for BOM
2020-10-24 10:20:03 +03:00
Alexey Milovidov
85c69aad7f Add check for BOM 2020-10-24 09:23:54 +03:00
Azat Khuzhin
c3c6ac39e0 Tune TTL of the background query in 01541_max_memory_usage_for_user 2020-10-24 09:07:28 +03:00
alexey-milovidov
f116679be9
Merge pull request #16333 from ClickHouse/revert-16288-upload_binary_in_fasttest
Revert "Optionally upload clickhouse binary in fast test"
2020-10-24 07:59:18 +03:00
alexey-milovidov
0748377ab1
Revert "Optionally upload clickhouse binary in fast test" 2020-10-24 07:59:08 +03:00
alexey-milovidov
d3294fe8dd
Merge pull request #15849 from olgarev/revolg-DOCS-engine-template
Database or Table Engine description template update
2020-10-24 07:52:28 +03:00
alexey-milovidov
32e0de5121
Merge pull request #16071 from hczhcz/patch-1
Change error message in function if & ifNull
2020-10-24 07:40:22 +03:00
alexey-milovidov
7e4079dca1
Merge pull request #16286 from ClickHouse/aku/error-context
Add more context to error messages
2020-10-24 07:28:36 +03:00
alexey-milovidov
fe0f6a9e01
Merge pull request #16288 from ClickHouse/upload_binary_in_fasttest
Optionally upload clickhouse binary in fast test
2020-10-24 07:27:32 +03:00
alexey-milovidov
c579611420
Merge pull request #16306 from azat/Set-Join-total-rows-bytes
Add total_rows/total_bytes support for Set/Join
2020-10-24 07:26:32 +03:00
Alexey Milovidov
74558a4e27 Better diagnostics when client has dropped connection 2020-10-24 06:41:47 +03:00
alexey-milovidov
6037982343
Merge pull request #16284 from ClickHouse/primary_key_without_order_by
Add ability to specify PRIMARY KEY without ORDER BY
2020-10-24 06:05:04 +03:00
sundy-li
21315127a0 remove unused codes in AggregateFunctionGroupBitmapData 2020-10-24 10:05:54 +08:00
Azat Khuzhin
96da5f6534 Disable syncing MemoryTracking with RSS for test_MemoryTracking 2020-10-24 02:33:16 +03:00
Azat Khuzhin
6e5b04fad8 Make 01540_MemoryTracking integration
01540_MemoryTracking is failing on CI for the following reasons:
- log_queries (fixed, by adding log_queries=0)
- profilers (fixed)
- but what can't be fixed is metric_log and so on, so we need separate
  instance with separate configuration (sigh).
2020-10-24 02:27:29 +03:00
alexey-milovidov
d350d864e6
Merge pull request #16297 from alex-karo/patch-2
Fix broken link in replication docs
2020-10-24 01:20:26 +03:00
alexey-milovidov
91dc8d4cb3
Merge pull request #16264 from amosbird/ssmfix
Fix TwoLevelStringHashTable bug
2020-10-24 01:00:27 +03:00
Alexey Milovidov
13b8dce792 Update contributors 2020-10-24 00:26:22 +03:00
tavplubix
790950ea56
Merge pull request #15934 from ClickHouse/ddl_queries_fixes
Fixes for DDL queries
2020-10-23 23:52:13 +03:00
nikitamikhaylov
a949293f95 better 2020-10-23 23:27:38 +03:00
nikitamikhaylov
0064a75916 Merge branch 'master' of github.com:ClickHouse/ClickHouse into welch-t-test 2020-10-23 23:06:15 +03:00
tavplubix
380786882b
Merge pull request #16127 from azat/atomic-drop-database-sync
Atomic DROP DATABASE SYNC
2020-10-23 23:00:25 +03:00
Azat Khuzhin
3f594ed3ad Add a test for memory drift in user memory tracker (max_memory_usage_for_user) 2020-10-23 22:13:34 +03:00
tavplubix
587f83b2ef
Merge branch 'master' into atomic-drop-database-sync 2020-10-23 21:54:26 +03:00
tavplubix
d6f1056951
Update arcadia_skip_list.txt 2020-10-23 21:53:50 +03:00
Azat Khuzhin
4d1385ef19 Add total_rows/total_bytes support for Set/Join 2020-10-23 21:11:55 +03:00
Azat Khuzhin
6c42ad564c Add a test for MemoryTracking drift
v2: disable query profiling and logging in 01540_MemoryTracking
    (This should make MemoryTracker drift zero).
2020-10-23 21:11:22 +03:00
Azat Khuzhin
0cccf3049a Fix parent memory tracker during query detaching 2020-10-23 21:07:53 +03:00
Azat Khuzhin
114ea9b1eb Fix accounting for new/delete from different threads for VariableContext::Thread
MemoryTracker assumes that for VariableContext::Thread new/delete may be
called from different threads, hence the amount of memory can go
negative.

However the MemoryTracker is nested, so even if the negative amount is
allowed for VariableContext::Thread it does not allowed for anything
upper, and hence the MemoryTracking will not be decremented properly.

Fix this, by passing initial size to the parent free.

This should fix memory drift for HTTP queries.
2020-10-23 21:07:52 +03:00
Azat Khuzhin
72d7b6117e Use total_memory_tracker when there is no other MemoryTracker object.
This should significantly reduce the MemoryTracking drift, test shows
that there is 0 drift after query storm (100 queries, via http/tcp/tcp
in one session).

TL;DR;

To track memory, clickhouse creates memory tracker object for each
thread **explicitly**, but until it is not created the memory
allocations are not under account.
There should not be lot of allocations w/o memory tracker, since most of
the time it is created early enough, but even this maybe enough to
trigger some problems.

Plus sometimes it is not possible to create it, for example some 3d
party library does not allow to do this explicitly:
- for example before #15740 allocations from librdkafka threads,
- or even worse, poco threads, they don't have any routines to do this.
This won't be a problem for `MemoryTracking` metric if the deallocation
will be done from the same thread w/o memory tracker (or vise versa),
but this is not always true.

NOTE, that this will slow down per-thread allocations w/o memory
tracker, since before this patch there were no memory tracking for them
while now they will be accounted in total_memory_tracker, and for
total_memory_tracker max_untracked_memory is always reached.
But this should not be significant.
2020-10-23 21:07:52 +03:00
alexey-milovidov
840d96255e
Merge pull request #16199 from azat/clang10-build-fix
Link dbms w/ atomic to fix undefined reference in unbundled build
2020-10-23 20:17:37 +03:00
alesapin
bc331a8029 Better set 2020-10-23 19:34:41 +03:00