Commit Graph

329 Commits

Author SHA1 Message Date
Alexey Milovidov
55a02c391d Style 2020-05-26 01:06:02 +03:00
Vitaly Baranov
58a2172154 Improve build scripts related to protobuf and gRPC. 2020-05-25 18:46:57 +03:00
Alexander Kuzmenkov
8d5bbed2de Merge remote-tracking branch 'origin/master' into HEAD 2020-05-25 06:44:11 +03:00
alexey-milovidov
bee5849c6a
Merge pull request #11137 from ClickHouse/logger-fmt
fmt-style logging, part 1
2020-05-25 01:38:14 +03:00
Alexey Milovidov
01be2dadb3 Various comments 2020-05-24 21:05:06 +03:00
Alexey Milovidov
d0c0a0aed6 Unrolled histogram calculation 8 times 2020-05-24 18:51:23 +03:00
Alexey Milovidov
e99ed19586 Unrolled histogram calculation 2020-05-24 18:48:11 +03:00
Alexey Milovidov
04022f71b4 Added comment 2020-05-24 18:35:48 +03:00
Alexey Milovidov
4748de9c85 Fix partial radix sort: it was not working at all 2020-05-24 18:26:07 +03:00
Alexey Milovidov
5e7ea6500c Fix error 2020-05-24 17:48:53 +03:00
Alexey Milovidov
32158d9aee Trying to understand and fix the code of RadixSortMSD 2020-05-24 17:42:20 +03:00
Alexey Milovidov
a8e8bc4298 Added a comment 2020-05-24 13:49:43 +03:00
alexey-milovidov
aa8f385085
Merge pull request #11159 from ClickHouse/fix-radix-sort
Fix radix sort after #10981
2020-05-24 02:31:45 +03:00
Alexey Milovidov
7e1813825b Return old names of macros 2020-05-24 01:24:01 +03:00
Alexey Milovidov
61cc605ee7 Remove old method 2020-05-24 01:21:29 +03:00
Alexey Milovidov
f75587e562 Progress on task 2020-05-23 23:13:34 +03:00
Alexey Milovidov
7e2fb9ad65 Apply all transformations again 2020-05-23 22:38:30 +03:00
Alexey Milovidov
eacff92d0e Progress on task 2020-05-23 22:35:08 +03:00
Alexey Milovidov
29762240de Remove duplicate whitespaces (preparation) 2020-05-23 22:31:54 +03:00
Alexey Milovidov
7fed65cbe2 Remove duplicate whitespaces (preparation) 2020-05-23 22:14:58 +03:00
Alexey Milovidov
ab0562a574 Make all LOG in single line (preparation) 2020-05-23 22:05:41 +03:00
Alexey Milovidov
9d2a0d2dd7 Apply all transformations again 2020-05-23 21:59:49 +03:00
Alexey Milovidov
a2ad11897f Remove duplicate whitespaces (preparation) 2020-05-23 21:53:58 +03:00
Alexey Milovidov
1f13515a65 Make all LOG in single line (preparation) 2020-05-23 21:31:37 +03:00
Alexey Milovidov
241f8c5431 find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+" \+ [^+]+ \+ "[^"]+"\);' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+), "([^"]+)" \+ ([^+]+) \+ "([^"]+)"\);/\1_FORMATTED(\2, "\3{}\5", \4);/' 2020-05-23 20:10:21 +03:00
Alexey Milovidov
f69cbdcbfc find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+" \+ [^+]+\);' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+), "([^"]+)" \+ ([^+]+)\);/\1_FORMATTED(\2, "\3{}", \4);/' 2020-05-23 20:09:37 +03:00
Alexey Milovidov
533f86278a find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+" << [^<]+ << "[^"]+" << [^<]+ << "[^"]+"\);' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+), "([^"]+)" << ([^<]+) << "([^"]+)" << ([^<]+) << "([^"]+)"\);/\1_FORMATTED(\2, "\3{}\5{}\7", \4, \6);/' 2020-05-23 20:00:41 +03:00
Alexey Milovidov
8042e5febe find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+" << [^<]+ << "[^"]+" << [^<]+\);' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+), "([^"]+)" << ([^<]+) << "([^"]+)" << ([^<]+)\);/\1_FORMATTED(\2, "\3{}\5{}", \4, \6);/' 2020-05-23 19:58:15 +03:00
Alexey Milovidov
e391b77d81 find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+" << [^<]+ << "[^"]+"\);' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+), "([^"]+)" << ([^<]+) << "([^"]+)"\);/\1_FORMATTED(\2, "\3{}\5", \4);/' 2020-05-23 19:56:05 +03:00
Alexey Milovidov
ee4ffbc332 find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+" << [^<]+\);' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+), "([^"]+)" << ([^<]+)\);/\1_FORMATTED(\2, "\3{}", \4);/' 2020-05-23 19:47:56 +03:00
Alexey Milovidov
8d2e80a5e2 find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+"\)' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+, "[^"]+")\)/\1_FORMATTED(\2)/' 2020-05-23 19:42:39 +03:00
tavplubix
6ece9649f1
Merge pull request #11151 from naorlov/CLICKHOUSE-7224
Add `FailedQuery`, `FailedSelectQuery` and `FailedInsertQuery`
2020-05-23 18:47:44 +03:00
Alexey Milovidov
9c15e3ad92 Make it right 2020-05-23 18:29:43 +03:00
Alexey Milovidov
82f03fa8ce Fix loop unrolling 2020-05-23 18:22:04 +03:00
Alexey Milovidov
73a3394b3d Clarifications #10981 2020-05-23 17:28:22 +03:00
alexey-milovidov
34eb533842
Merge pull request #10981 from g-arslan/master
Try to remove redundant data move in radix sort
2020-05-23 15:55:35 +03:00
Alexey Milovidov
3e87b5fe72 Remove old TODO 2020-05-23 14:50:21 +03:00
Nikita Orlov
dffd15f643
issue-7224 Add failed Insert and Select query counters to ProfileEvents 2020-05-23 01:00:15 +03:00
Alexander Tokmakov
ac54d470da Merge branch 'master' into merging_external_source_cassandra 2020-05-22 17:27:40 +03:00
Andrey Skobtsov
806d2c9838 1 or 4 spaces in example values 2020-05-22 15:30:02 +03:00
Andrey Skobtsov
93d8e8c404 Removed perf page faults as they already exist in rusage 2020-05-22 14:09:14 +03:00
Dmitry
47778c0259 Merge branch 'master' of github.com:yandex/ClickHouse into group_by_in_order_optimization 2020-05-21 23:45:12 +03:00
Andrey Skobtsov
e3b756e65f Added cpu-clock to the list of supported events as it is included in perf and can be disabled if needed 2020-05-21 23:40:47 +03:00
Andrey Skobtsov
790d7c2000 Reverted ctime > sys/time.h include just to not show it in the pull request 2020-05-21 23:29:20 +03:00
Andrey Skobtsov
5217fd7952 Renamed counters_id to latest_counters_id to be more specific about what this variable holds 2020-05-21 23:27:33 +03:00
Andrey Skobtsov
713173a3a5 More precise number of total events 2020-05-21 23:21:42 +03:00
Andrey Skobtsov
72e5545c51 Logging warnings instead of infos and always as the user can select
what metrics he wants to measure and perf measurements will be disabled by default
2020-05-21 23:20:55 +03:00
Andrey Skobtsov
bf5c7c4411 Logging perf event settings name when event is not supported 2020-05-21 23:11:19 +03:00
Andrey Skobtsov
d00609cb70 Validating file descriptors for external modification 2020-05-21 17:14:01 +03:00
alexey-milovidov
765510d5c3
Merge pull request #10991 from ClickHouse/enable-clang-tidy-for-programs-and-utils
Enable clang-tidy for programs and utils
2020-05-21 15:12:07 +03:00
g-arslan
3267eaa498 fix style 2020-05-21 15:00:55 +03:00
g-arslan
b88d0dec1c some little improvements 2020-05-21 15:00:55 +03:00
g-arslan
c01a7ef0e2 Implement reverse in radix sort, fix style, fix build 2020-05-21 15:00:55 +03:00
g-arslan
95668def24 Try to remove redundant data move in radix sort 2020-05-21 15:00:55 +03:00
Andrey Skobtsov
8363ccb9b7 Fixed naming for lambda 2020-05-21 00:03:08 +03:00
Alexander Tokmakov
31b6f5f0d2 Merge branch 'master' into merging_external_source_cassandra 2020-05-20 23:44:53 +03:00
Alexander Kuzmenkov
50df893dc6 Assert that allocator & container are consistent wrt. inline memory
There are lots of places where HashTable is used with
AllocatorWithStackMemory, but the size of allocator inline memory is set
incorrectly, and it's less than the initial HashTable buffer size.
Because of this, HashTable is always allocated on the heap, and the
inline memory becomes a useless dead weight.

For PODArray, we have previously added a helper template that makes sure
these values are in sync, so there was only one such discrepancy left,
in the unit test.
2020-05-20 22:37:13 +03:00
Andrey Skobtsov
a329a6a86a Fixed compilation on non linux devices 2020-05-20 21:54:07 +03:00
Andrey Skobtsov
4151cf7ac8 Removed useless comment 2020-05-20 21:37:16 +03:00
Andrey Skobtsov
97043e588f Space 2020-05-20 21:30:09 +03:00
Andrey Skobtsov
4816abed28 Settings for measuring only particular metrics via perf events 2020-05-20 21:25:49 +03:00
Andrey Skobtsov
844aac40e5 typedef > using 2020-05-19 21:25:40 +03:00
Andrey Skobtsov
b6d6427748 Added file descriptors threshold 2020-05-19 21:22:30 +03:00
Andrey Skobtsov
483c78ba8f Fixed warnings 2020-05-19 17:01:51 +03:00
alesapin
a416813597
Merge pull request #10777 from NanoBjorn/refactor-reservations
VolumePtr instead of DiskPtr in MergeTreeData*
2020-05-19 13:27:11 +03:00
Alexander Tokmakov
175b7aedf3 Merge branch 'master' into merging_external_source_cassandra 2020-05-19 05:21:27 +03:00
Andrey Skobtsov
ef788758bf Revert "Fixed current counter id check"
This reverts commit f98c53e8
2020-05-19 01:30:40 +03:00
Andrey Skobtsov
f98c53e8d8 Fixed current counter id check 2020-05-19 01:29:46 +03:00
Andrey Skobtsov
04a902ba68 Reverted switch case indentation (v2) 2020-05-19 01:27:19 +03:00
Andrey Skobtsov
b8d447297b Reverted switch case indentation 2020-05-19 01:26:35 +03:00
Andrey Skobtsov
4103700aa6 Changed comments 2020-05-19 01:17:19 +03:00
Andrey Skobtsov
b0a3dc2b88 Moved static on top of thread_local 2020-05-19 01:15:04 +03:00
Andrey Skobtsov
e46cabe1d8 UInt64 numbers to track active counters instead of memory addresses 2020-05-19 01:13:55 +03:00
Andrey Skobtsov
979b357c05 Removed unused method 2020-05-19 00:46:46 +03:00
Artem Zuikov
97c7447130
Bitonic sort improvements (#10934) 2020-05-19 00:41:23 +03:00
Andrey Skobtsov
901f546aee Fixed 0 value of paranoid handling 2020-05-19 00:40:15 +03:00
Andrey Skobtsov
1edd29b3f8 Removed custom events as they don't work in an "increment" manner 2020-05-18 15:23:47 +03:00
Andrey Skobtsov
e7bea6e03a Renamed events 2020-05-18 14:44:40 +03:00
Andrey Skobtsov
182e4f2c0b Added running and enabled time for perf metrics 2020-05-18 13:40:01 +03:00
Artem Zuikov
0fe723acc9
Try to fix arcadia sync (#10959) 2020-05-18 13:26:23 +03:00
alesapin
07cb21ccb7
Merge branch 'master' into refactor-reservations 2020-05-18 11:43:48 +03:00
alexey-milovidov
a316184bef
Merge pull request #10990 from ClickHouse/odbc-bridge-wait-exp-backoff
Wait for odbc-bridge with exponential backoff
2020-05-18 10:17:59 +03:00
Nikolai Kochetov
cdb742dd4b Added comment. 2020-05-18 09:06:48 +03:00
Nikolai Kochetov
fcde0d36bd
Merge pull request #10978 from ClickHouse/static-mutate
Try fix performance after static mutate.
2020-05-18 09:02:24 +03:00
alexey-milovidov
7efd2a825f
Merge pull request #10463 from ClickHouse/parallel-final
Parallel final
2020-05-18 05:20:18 +03:00
Alexey Milovidov
b0a5ce7743 Enable clang-tidy for programs and utils 2020-05-18 04:19:50 +03:00
Alexey Milovidov
7b5dfd9c00 Wait for odbc-bridge with exponential backoff 2020-05-18 04:06:04 +03:00
Nikolai Kochetov
aab2599fad Fix build. 2020-05-17 23:26:53 +03:00
alexey-milovidov
6f1d522b6a
Merge pull request #10980 from azat/database-atomic-fixes
Database atomic fixes
2020-05-17 23:25:56 +03:00
alexey-milovidov
8d3c37992a
Merge pull request #10533 from ClickHouse/alter-key-column-better-exception-message
Better exception message and error code for ALTER of key column #9078
2020-05-17 22:21:14 +03:00
Nikolai Kochetov
c8e7ea0d6c Try fix performance. 2020-05-17 21:55:49 +03:00
Azat Khuzhin
31035a3cd1 Allow relative path for renameat2 by using AT_FDCWD
Otherwise this will trigger logical error on CREATE TABLE with default
config.d overrides (path=./).
2020-05-17 17:02:03 +03:00
Andrey Skobtsov
40ad18be8e Fixed compilation namespace issue and formatting 2020-05-17 16:56:17 +03:00
alexey-milovidov
a3346e9331
Merge pull request #10912 from ClickHouse/static-mutate
Static mutate
2020-05-17 09:05:35 +03:00
Alexey Milovidov
9fcfe5fb14 Better exception message and error code for ALTER of key column #9078 2020-05-17 07:46:25 +03:00
Andrey Skobtsov
cae41826a8 Merge branch 'master' into perf_events_metrics
# Conflicts:
#	src/Common/ThreadProfileEvents.cpp
#	src/Common/ThreadProfileEvents.h
#	src/Common/ThreadStatus.cpp
#	src/Common/ThreadStatus.h
2020-05-17 00:21:22 +03:00
Gleb Novikov
1a25ac6e1f Merge branch 'master' into refactor-reservations 2020-05-16 23:34:45 +03:00
Azat Khuzhin
c059ee0085 Use is_trivial+is_standard_layout over is_pod (later is deprecated) 2020-05-16 00:00:38 +03:00
Vitaly Baranov
d92ac9ea47
Merge branch 'master' into RBAC-10 2020-05-15 14:12:43 +03:00
Nikolai Kochetov
70ce0149b1 Try fix build. 2020-05-15 13:10:13 +03:00
alexey-milovidov
985b83a228
Merge pull request #10903 from ClickHouse/lexer-unicode-whitespaces
Support for unicode whitespaces in queries.
2020-05-15 10:31:59 +03:00
Artem Zuikov
8e8a2a17d6 build fixes 2020-05-15 03:01:31 +03:00
Ri
fc7afaa639
Bitonic sort on GPU (OpenCL) (#10232) 2020-05-15 03:01:14 +03:00
Alexey Milovidov
81a5d02628 Fix annoying "Arcadia" build 2020-05-14 20:05:55 +03:00
Nikolai Kochetov
4d22374f24 Merged with master. 2020-05-14 12:06:15 +03:00
Nikolai Kochetov
d68c385d35 Remove old code. 2020-05-14 11:59:15 +03:00
Nikolai Kochetov
4d0503f021 Make IColumn::mutate() static. 2020-05-14 11:30:18 +03:00
Alexey Milovidov
770cc9e863 Fix "Arcadia" build that is using obsolete version of C++ standard 2020-05-14 02:12:16 +03:00
Alexey Milovidov
c3cea85b10 Support for unicode whitespaces in Lexer 2020-05-14 00:31:57 +03:00
alexey-milovidov
623b2e5a43
Merge pull request #10849 from ClickHouse/fix_optimize_and_alter_hangs
Fix mutations and OPTIMIZE hangs when replica becomes inactive
2020-05-13 23:41:13 +03:00
alexey-milovidov
63c6eb1a37
Update ZooKeeper.h 2020-05-13 23:40:54 +03:00
Vitaly Baranov
dd8b29b4fb Use enum Type instead of std::type_index to represent the type of IAccessEntity.
This change simplifies handling of access entities in access storages.
2020-05-13 19:40:48 +03:00
tavplubix
39518fe725
trigger CI 2020-05-13 16:45:39 +03:00
Alexander Tokmakov
032197b015 fix alter and optimize hangs when replica becomes inactive 2020-05-13 10:06:57 +03:00
Azat Khuzhin
e102ad373a Fix SIGSEGV in StringHashTable if such key is not exists 2020-05-13 03:40:05 +03:00
Dmitry
c4295d97f9 Merge branch 'master' of github.com:yandex/ClickHouse into group_by_in_order_optimization 2020-05-12 17:57:32 +03:00
alexey-milovidov
40ef113503
Merge branch 'master' into parallel-final 2020-05-11 06:47:44 +03:00
Gleb Novikov
57b6fb6d80 Merge branch 'master' into refactor-reservations 2020-05-10 13:01:45 +03:00
Gleb Novikov
a961e049a2 VolumeType as class with enum member class 2020-05-10 09:26:33 +03:00
Alexey Milovidov
dda2151f71 Fix build 2020-05-10 02:35:20 +03:00
Alexey Milovidov
fb32dbe6ee Enable more warnings 2020-05-10 00:44:33 +03:00
Gleb Novikov
390b39b272 VolumePtr instead of DiskPtr in MergeTreeData* 2020-05-10 00:24:15 +03:00
Azat Khuzhin
150dd81e3b Fix build with unbundled Poco 2020-05-09 01:22:12 +03:00
Ivan
85d783c247
Poco contrib refactoring (#10396)
* Remove config_common.h
* Refactor libcpuid contrib
* Remove support for libcpuinfo
* Define USE_CPUID in Arcadia
* Refactor Poco libraries
2020-05-08 17:11:19 +03:00
Alexey Milovidov
dea8d366c9 Loose some limitation 2020-05-07 04:29:31 +03:00
alexey-milovidov
443c64abc0
Merge pull request #10638 from ClickHouse/fix-ubsan-hashtable
Fix UBSan report in HashTable
2020-05-04 04:50:25 +03:00
Alexey Milovidov
bb6eabd82d Fix HTTP response code for some parse errors #10636 2020-05-03 22:47:07 +03:00
Alexey Milovidov
8f7374c6de Fix another UBSan warning 2020-05-03 21:39:52 +03:00
Alexey Milovidov
9a344e681f Fix UBSan report in FixedHashTable 2020-05-03 21:24:11 +03:00
Alexey Milovidov
626b9a3ae9 Fix UBSan report in HashTable 2020-05-03 21:21:18 +03:00
Alexey Milovidov
600b396f1b Merge remote-tracking branch 'origin/master' into sampling-memory-profiler 2020-05-01 21:48:20 +03:00
Alexander Kazakov
e9baaa439b
Implementation of new system metrics provider (Procfs) (#10544)
* New metrics provider (Procfs) + Refactored TasksStatsCounters

* Trivial statless test that ProcFS is provided

* Trivial perf test for ProcfsMetricsProvider

Co-authored-by: alexey-milovidov <milovidov@yandex-team.ru>
2020-05-01 21:47:41 +03:00
Alexey Milovidov
c4b64edc14 Merge branch 'master' into sampling-memory-profiler 2020-05-01 16:47:10 +03:00
Alexander Kuzmenkov
2ac26bd3a5 Disable mremap under MemorySanitizer. 2020-05-01 10:38:05 +03:00
Alexey Milovidov
293ae88e7f Add sampling memory profiler 2020-04-30 16:25:17 +03:00
Nikolai Kochetov
19dadb8c2d Add parallel final. 2020-04-30 12:59:08 +03:00
Alexey Milovidov
a7d7dc5034 Fix some bad code 2020-04-26 20:34:36 +03:00
alexey-milovidov
378d73d477
Merge pull request #10449 from azat/metrics-for-new-bg-schedule-pools
Add tasks/memory metrics for distributed/buffer schedule pools
2020-04-26 20:16:02 +03:00
Dmitry
d9ac0e8fef Merge branch 'master' of github.com:yandex/ClickHouse into group_by_in_order_optimization 2020-04-26 14:44:06 +03:00
tavplubix
7928f2eaa1
Merge pull request #7512 from ClickHouse/database_atomic
DatabaseAtomic
2020-04-24 22:28:18 +03:00
Alexander Tokmakov
04d4130b0d update yamake 2020-04-24 20:14:10 +03:00
alexey-milovidov
79d531af87
Merge pull request #10466 from ClickHouse/aku/arena-infinite-loop
Work around a bug leading to an infinite loop in addressToLine
2020-04-24 10:38:07 +03:00
Alexander Kuzmenkov
2bedc82c18 Work around a bug leading to an infinite loop in addressToLine.
Fixing this is hopeless and would entail rewriting the entire
WriteBuffer thing, and also this hack is something we can backport.
2020-04-24 02:42:04 +03:00
Andrey Skobtsov
b6a5b1b12f Fix styling 2020-04-23 22:38:15 +03:00
Andrey Skobtsov
0cf949f1b5 A bit of reformatting code 2020-04-23 21:50:12 +03:00
Andrey Skobtsov
30a87a8a58 perf events' values are 64 bit unsigned; so, read them instead of the signed ones 2020-04-23 21:50:12 +03:00
Andrey Skobtsov
30e19c3abb Using the same file descriptors for all counters on the current thread (only one instance of PerfEventsCounters can be active at a given time for a thread) 2020-04-23 21:50:12 +03:00
Alexander Tokmakov
15e7ce0053 fixes 2020-04-23 21:00:43 +03:00
Alexander Tokmakov
04d6b59ac0 Merge branch 'master' into database_atomic 2020-04-23 17:31:37 +03:00
Alexander Kuzmenkov
9ed9475e46
boop the CI 2020-04-23 03:55:03 +03:00