thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-14 19:45:11 +00:00
Code Issues Packages Projects Releases Wiki Activity
78,465 Commits 9,131 Branches 1,774 Tags 2.1 GiB
3efb4038ca
Commit Graph

78465 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Tatiana Kirillova
3efb4038ca sparkbar description 2021-12-05 19:46:24 +03:00
Kseniia Sumarokova
ae214ffc5b
Merge pull request #32222 from kssenii/fix-remaining-window-tests 
Add missing timezones to some tests
 2021-12-04 12:29:06 +03:00
Maksim Kita
5dfd70530e
Merge pull request #32224 from den-crane/patch-45 
doc. fix typo
 2021-12-04 02:54:38 +03:00
Denny Crane
8e202d980a
fix typo 2021-12-03 18:03:07 -04:00
alexey-milovidov
d4c7f24744
Merge pull request #32203 from Algunenano/master_i32186 
Add test for #32186
 2021-12-04 00:54:21 +03:00
kssenii
1cc5dd7979 Fix 2021-12-03 23:36:35 +03:00
Kseniia Sumarokova
7984b246ff
Merge pull request #32209 from ClickHouse/kssenii-patch-3 
Fix flacky fileLog test (probably)
 2021-12-03 22:53:12 +03:00
Kseniia Sumarokova
52987d382b
Merge pull request #32208 from ClickHouse/kssenii-patch-2 
Update ASTCreateQuery.cpp
 2021-12-03 19:43:10 +03:00
alexey-milovidov
667f45af43
Merge pull request #31490 from flickerbox/crb-support-page 
Crb support page
 2021-12-03 19:13:05 +03:00
Maksim Kita
0372403ebd
Merge pull request #32112 from FrankChen021/content-type 
Returns Content-Type as application/json for JSONEachRow if output_format_json_array_of_rows is enabled
 2021-12-03 18:59:54 +03:00
Maksim Kita
e7b19da7bc
Merge pull request #32038 from FrankChen021/trace_finish_time_bug 
Fix a bug that opentelemetry span log duration is zero
 2021-12-03 18:59:22 +03:00
Kseniia Sumarokova
7b1d4631bf
Update FileLogSource.cpp 2021-12-03 18:56:29 +03:00
Kseniia Sumarokova
d38d2ba14f
Merge pull request #32178 from kssenii/fix-window-view-tests 
Fix window view tests
 2021-12-03 18:45:44 +03:00
Kseniia Sumarokova
738265eed2
Update ASTCreateQuery.cpp 2021-12-03 18:17:36 +03:00
Raúl Marín
d1f0b249d3 Fix style 2021-12-03 14:50:33 +01:00
Raúl Marín
0c1e89b043 Add test 2021-12-03 14:18:01 +01:00
kssenii
adaa32b41b Fix inner table name 2021-12-03 15:52:57 +03:00
alesapin
adde67358a
Merge pull request #32175 from ClickHouse/better_logs 
Better output for some actions
 2021-12-03 15:32:02 +03:00
alesapin
a625dd41e8
Merge branch 'master' into better_logs 2021-12-03 15:31:45 +03:00
alesapin
597c578809
Merge pull request #31263 from den-crane/Docs/alter-partition-verbose-result 
docs. alter-partition-verbose-result
 2021-12-03 14:15:30 +03:00
alesapin
4f30f69d54
Merge pull request #32177 from ClickHouse/use_ccache_in_fast_test 
Use ccache in fast test
 2021-12-03 13:57:22 +03:00
kssenii
0470525ea3 Fix 2021-12-03 13:39:27 +03:00
mergify[bot]
48ed754fab
Merge branch 'master' into use_ccache_in_fast_test 2021-12-03 10:28:03 +00:00
alesapin
d8604acb8e Bump 2021-12-03 13:18:24 +03:00
mergify[bot]
478c35538d
Merge branch 'master' into trace_finish_time_bug 2021-12-03 10:12:48 +00:00
Maksim Kita
ca2a70cd8d
Merge pull request #32080 from azat/cast-fix-ubsan 
Fix CAST from Nullable with cast_keep_nullable
 2021-12-03 13:05:38 +03:00
Maksim Kita
6ec559f103
Update JSONEachRowRowOutputFormat.h 2021-12-03 12:48:28 +03:00
tavplubix
17f8193435
Merge pull request #32157 from ClickHouse/fix_active_replicas_count_quorum 
Fix active replicas count in quorum inserts
 2021-12-03 12:39:36 +03:00
alesapin
caa481aba8 Use ccache in fast test 2021-12-03 12:28:17 +03:00
alesapin
99a5ca2646 Fix style (got tired of it) 2021-12-03 12:19:39 +03:00
Kruglov Pavel
17d6f539b3
Merge pull request #32019 from azat/dist-desc 
Fix excessive DESC TABLE for remote() over identifier
 2021-12-03 12:15:05 +03:00
Maksim Kita
74979a5f01
Merge pull request #31095 from amosbird/addprojection 
Function name normalization for ALTER queries
 2021-12-03 12:07:07 +03:00
SuperDJY
5d7dfc6eb9
fix storage join settings with persistency (#32066) 2021-12-03 12:06:58 +03:00
Kruglov Pavel
3d047747ed
Merge pull request #32123 from Avogar/fix-tests 
Change test 02117_custom_separated_with_names_and_types
 2021-12-03 12:06:50 +03:00
alesapin
ec0bfa7bcf Better output for some actions 2021-12-03 11:33:16 +03:00
alesapin
7699d3f35e
Merge pull request #32162 from azat/double-gz 
tests/ci: do not compress logs twice
 2021-12-03 10:20:35 +03:00
alesapin
83c086b051
Merge pull request #32120 from ClickHouse/add_one_more_group 
Move fuzzers and unit tests to another group
 2021-12-03 10:14:09 +03:00
Kseniia Sumarokova
03c7907b37
Merge pull request #32172 from ClickHouse/kssenii-patch-2 
Update materialized-postgresql.md
 2021-12-03 09:28:46 +03:00
Kseniia Sumarokova
9093ad6596
Update materialized-postgresql.md 2021-12-03 09:27:22 +03:00
Kseniia Sumarokova
a8dcbc988a
Merge pull request #32129 from kssenii/fix-postgres-tests 
fixing postgres tests
 2021-12-03 09:15:20 +03:00
alexey-milovidov
b7fb21e6f0
Merge pull request #32163 from azat/clickhouse-test-random 
clickhouse-test: do not use random generator with shared state
 2021-12-03 06:53:57 +03:00
alexey-milovidov
17fcf0a6d3
Merge pull request #32165 from azat/query-profiler-reset-fix 
Fix QueryProfiler (query_profiler_{cpu,real}_time_period_ns) reset
 2021-12-03 06:51:21 +03:00
Azat Khuzhin
344298f403 Fix CAST from Nullable with cast_keep_nullable 
UBsan report [1]:

    SELECT toUInt32OrDefault(toNullable(0)) SETTINGS cast_keep_nullable = 1

    ../src/Common/assert_cast.h:50:12: runtime error: downcast of address 0x000029461170 which does not point to an object of type 'const DB::ColumnNullable'
    0x000029461170: note: object is of type 'DB::ColumnVector<unsigned int>'
     00 00 00 00  a0 51 3d 09 00 00 00 00  01 00 00 00 00 00 00 00  a0 3f 4e 29 00 00 00 00  a4 3f 4e 29
                  ^~~~~~~~~~~~~~~~~~~~~~~
                  vptr for 'DB::ColumnVector<unsigned int>'
        0 0x1e3e279d in DB::ColumnNullable const& assert_cast<DB::ColumnNullable const&, DB::IColumn const&>(DB::IColumn const&) obj-x86_64-linux-gnu/../src/Common/assert_cast.h:50:12
        1 0x1e3e279d in DB::ColumnNullable::insertRangeFrom(DB::IColumn const&, unsigned long, unsigned long) obj-x86_64-linux-gnu/../src/Columns/ColumnNullable.cpp:167:43
        2 0x12db4507 in DB::FunctionCastOrDefault::executeImpl() const (/src/ch/tmp/32019/clickhouse-ubsan+0x12db4507)

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/32019/9e1222a50b1805f696f4205e451365f8acdbc8a5/fuzzer_astfuzzerubsan,actions//report.html

And w/o -fsanitize=undefined:

    SELECT toUInt32OrDefault(toNullable(1), toNullable(toUInt32(1))) SETTINGS cast_keep_nullable = 1

    Received exception:
    Code: 12. DB::Exception: Parameters start = 0, length = 1 are out of bound in ColumnVector<T>::insertRangeFrom method (data.size() = 0).: While processing toUInt32OrDefault(toNullable(1), toNullable(toUInt32(1))). (PARAMETER_OUT_OF_BOUND)
 2021-12-03 02:02:42 +03:00
Anton Popov
f6be3d16fd
Merge pull request #24820 from kssenii/versioning 
Versioning of aggregate function states
 2021-12-03 01:41:44 +03:00
Azat Khuzhin
0b2de32228 Fix QueryProfiler (query_profiler_{cpu,real}_time_period_ns) reset 
Even after timer_delete() the signal can be fired.
Reproducer:

    $ clickhouse-server & # with configured trace_log
    $ clickhouse-benchmark -c2 --query 'select * from numbers(1e6)' --query_profiler_cpu_time_period_ns=1 &
    ...
    2021.12.02 14:28:01.320288 [ 24885 ] {} <Debug> TCPHandler: Processed in 177.055205644 sec.
    User defined signal 2

CI failures:
- https://s3.amazonaws.com/clickhouse-test-reports/32067/8dbc7a8dae17090a18778f29629d8746a1bb9b72/stateful_tests__debug__actions_.html
- https://s3.amazonaws.com/clickhouse-test-reports/32064/c07450a7dce363b7a4c5ca3ab0e833c25e3d46c0/stateful_tests__debug__actions_.html

Fix this by do not reset the signal back, and introduce a flag to ignore
signals after disabling the timer.

Fixes: #31740
 2021-12-03 01:33:08 +03:00
Azat Khuzhin
96bd83c31e Do not reopen logs on USR1, HUP is enough 
USR1 is also used for query_profiler_real_time_period_ns, let's not
overlap.
 2021-12-03 01:32:57 +03:00
Azat Khuzhin
9276384977 clickhouse-test: do not use random generator with shared state 
Recently (#32094) test database had been overlapped, and random prefix
for database had been increased from 6 to 8.

But actually 6 bytes for random prefix should be enough (with existing
alphabet (0-9a-z) it is 36**6=2'176'782'336), and the real reason of
this overlap is that random generator by default uses shared state [1]:

    The functions supplied by this module are actually bound methods of
    a hidden instance of the random.Random class. You can instantiate your
    own instances of Random to get generators that don’t share state.

  [1]: https://docs.python.org/3/library/random.html

I've played a little bit with random in python, and using default random
generator it generates non-unique strings pretty fast, just in a few
runs, but using SystemRandom (that uses /dev/urandom) it takes ~1 minute.

Test:

```sh
    $ while /tmp/test.py | LANG=c sort -S5G | LANG=c uniq -d | tee /dev/stderr | wc -l | fgrep -q -x -c 0; do :; done
```

```python
    #!/usr/bin/env python3

    import multiprocessing
    import string
    import random

    def random_str(length=6):
        alphabet = string.ascii_lowercase + string.digits
        return ''.join(random.SystemRandom().choice(alphabet) for _ in range(length))

    def worker(_):
        print(random_str())

    with multiprocessing.Pool(processes=2) as pool:
        pool.map(worker, range(0, int(10e3)))
```

So let's switch to SystemRandom and use 6-byte prefix.
 2021-12-03 01:29:23 +03:00
Azat Khuzhin
bfaaa79cfc tests/ci: do not compress logs twice 
Cc: @alesapin
 2021-12-03 01:28:32 +03:00
Frank Chen
e895c85f49
Add exception/exception_code to trace span log (#32040) 2021-12-03 01:00:02 +03:00
kssenii
06312a2df9 Fix 2021-12-02 22:48:21 +03:00