Commit Graph

6737 Commits

Author SHA1 Message Date
Vxider
ab593d24f3 update code style 2022-01-10 02:16:07 +00:00
kssenii
1984a80750 Merge remote-tracking branch 'upstream/master' into materialized-postgresql-better-startup 2022-01-09 21:23:49 +03:00
Kseniia Sumarokova
d0a847befc
Merge pull request #33200 from kssenii/fix-materialized-postgresql-ddl-validation
materialized postgresql fix ddl validation
2022-01-09 21:12:13 +03:00
kssenii
bfaab1356f Merge remote-tracking branch 'upstream/master' into settings-changes-with-named-conf 2022-01-09 17:56:44 +03:00
kssenii
8f9920dd4d One more fix 2022-01-09 17:46:33 +03:00
kssenii
6639a93735 Better 2022-01-09 12:16:12 +03:00
kssenii
61f85e9afc More fixes 2022-01-08 20:44:17 +03:00
Kseniia Sumarokova
9b3493ba9a
Merge pull request #33468 from kssenii/fix-postgres-db-drop
Fix drop materialized postgres db
2022-01-08 19:41:24 +03:00
alesapin
733ed7cb54
Merge pull request #32061 from ianton-ru/MDB-15474
Change ZooKeeper path for zero-copy locks for shared data
2022-01-08 17:17:11 +03:00
kssenii
c94f4163f7 Merge remote-tracking branch 'upstream/master' into fix-materialized-postgresql-ddl-validation 2022-01-08 15:56:46 +03:00
kssenii
adaeb96b6d Fix 2022-01-08 15:46:22 +03:00
kssenii
64538cf20f Merge remote-tracking branch 'upstream/master' into materialized-postgresql-better-startup 2022-01-08 00:49:08 +03:00
kssenii
90972e3752 Fix race 2022-01-08 00:27:29 +03:00
Azat Khuzhin
28e64020bd Fix query cancellation in case of allow_experimental_parallel_reading_from_replicas
CI found one hanged query [1], where the problem was that becase of
allow_experimental_parallel_reading_from_replicas the Cancel packet was
read by receivePartitionMergeTreeReadTaskResponseAssumeLocked() and so
the executor was not cancelled, while the code in
MergeTreeBaseSelectProcessor was not ready for this:

<details>

    {
        "is_initial_query": 0,
        "elapsed": 1727.714379573,
        "is_cancelled": 0,
        "read_rows": "196577",
        "read_bytes": "1179462",
        "written_rows": "0",
        "written_bytes": "0",
        "query": "SELECT `CounterID`, `EventDate` FROM `test`.`hits` ORDER BY `CounterID` DESC, `EventDate` ASC LIMIT 50",
        ...
     }

In logs:

    2021.12.31 12:11:55.384735 [ 101532 ] {7e5f551e-5960-4fda-9447-9bfdae4660c1} <Debug> executeQuery: (from [::ffff:127.0.0.1]:58094, initial_query_id: e2966ca5-e836-44ef-8f8e-d1c1b32a>
    2021.12.31 12:11:55.454379 [ 101532 ] {7e5f551e-5960-4fda-9447-9bfdae4660c1} <Trace> ContextAccess (default): Access granted: SELECT(EventDate, CounterID) ON test.hits
    2021.12.31 12:11:55.457583 [ 101532 ] {7e5f551e-5960-4fda-9447-9bfdae4660c1} <Trace> datasets.hits_v1: Parallel reading from replicas enabled true
    2021.12.31 12:11:55.459739 [ 101532 ] {7e5f551e-5960-4fda-9447-9bfdae4660c1} <Trace> InterpreterSelectQuery: FetchColumns -> WithMergeableStateAfterAggregationAndLimit
    2021.12.31 12:11:55.471048 [ 101532 ] {7e5f551e-5960-4fda-9447-9bfdae4660c1} <Debug> datasets.hits_v1 (SelectExecutor): Key condition: unknown
    2021.12.31 12:11:55.476514 [ 101532 ] {7e5f551e-5960-4fda-9447-9bfdae4660c1} <Debug> datasets.hits_v1 (SelectExecutor): MinMax index condition: unknown
    2021.12.31 12:11:55.488302 [ 101532 ] {7e5f551e-5960-4fda-9447-9bfdae4660c1} <Debug> datasets.hits_v1 (SelectExecutor): Selected 2/2 parts by partition key, 2 parts by primary key, >
    2021.12.31 12:11:55.494020 [ 101532 ] {7e5f551e-5960-4fda-9447-9bfdae4660c1} <Debug> MergeTreeReverseSelectProcessor: Reading 1 ranges in reverse order from part 201403_20_20_0, app>
    2021.12.31 12:11:55.497644 [ 101532 ] {7e5f551e-5960-4fda-9447-9bfdae4660c1} <Debug> MergeTreeReverseSelectProcessor: Reading 138 ranges in reverse order from part 201403_19_19_2, a>
    2021.12.31 12:11:55.536372 [ 170601 ] {7e5f551e-5960-4fda-9447-9bfdae4660c1} <Test> MergeTreeBaseSelectProcessor: Reading from Compact part, average mark size is 83886080
    2021.12.31 12:11:55.558783 [ 171701 ] {7e5f551e-5960-4fda-9447-9bfdae4660c1} <Test> MergeTreeBaseSelectProcessor: Reading from Wide part, average mark size is 3069
    2021.12.31 12:11:55.563960 [ 171701 ] {7e5f551e-5960-4fda-9447-9bfdae4660c1} <Test> MergeTreeBaseSelectProcessor: Reading from Wide part, average mark size is 3069
    2021.12.31 12:11:55.577512 [ 171701 ] {7e5f551e-5960-4fda-9447-9bfdae4660c1} <Test> MergeTreeBaseSelectProcessor: Reading from Wide part, average mark size is 3069
    2021.12.31 12:11:55.585660 [ 171701 ] {7e5f551e-5960-4fda-9447-9bfdae4660c1} <Test> MergeTreeBaseSelectProcessor: Reading from Wide part, average mark size is 3069
    2021.12.31 12:11:55.613694 [ 170601 ] {7e5f551e-5960-4fda-9447-9bfdae4660c1} <Test> MergeTreeBaseSelectProcessor: Reading from Wide part, average mark size is 3069
    2021.12.31 12:11:55.730597 [ 170601 ] {7e5f551e-5960-4fda-9447-9bfdae4660c1} <Test> MergeTreeBaseSelectProcessor: Reading from Wide part, average mark size is 3069
    2021.12.31 12:11:55.743554 [ 171701 ] {7e5f551e-5960-4fda-9447-9bfdae4660c1} <Debug> MergingSortedTransform: Merge sorted 3 blocks, 65567 rows in 0.243999671 sec., 268717.5754429603>
    2021.12.31 12:11:55.744196 [ 170601 ] {7e5f551e-5960-4fda-9447-9bfdae4660c1} <Test> MergeTreeBaseSelectProcessor: Reading from Wide part, average mark size is 3069
    2021.12.31 12:11:55.890923 [ 170601 ] {7e5f551e-5960-4fda-9447-9bfdae4660c1} <Test> MergeTreeBaseSelectProcessor: Reading from Wide part, average mark size is 3069
    2021.12.31 12:11:55.891222 [ 170601 ] {7e5f551e-5960-4fda-9447-9bfdae4660c1} <Test> MergeTreeBaseSelectProcessor: Reading from Wide part, average mark size is 3069

</details>

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/33341/0685fd99855bacd0bce02507c00a3bd7709eea61/stress_test__address__actions_.html
2022-01-07 20:04:57 +03:00
mergify[bot]
6fcd5a7d41
Merge branch 'master' into MDB-15474 2022-01-07 10:12:25 +00:00
alesapin
b1d2bdf569
Merge pull request #33130 from kssenii/validate-config
Validate config keys for external dictionaries
2022-01-07 12:59:02 +03:00
Maksim Kita
4c1f61bd19
Merge pull request #33431 from bigo-sg/add_build_options
Add some building options in system.build_options
2022-01-07 00:02:57 +03:00
feng lv
90a61b84e5 fix misleading log message 2022-01-06 12:48:38 +00:00
taiyang-li
ede65e3b6e add some building options 2022-01-06 16:12:59 +08:00
lgbo-ustc
f78564491c code style 2022-01-05 14:40:02 +08:00
lgbo-ustc
624da11ee2 fix a bug : cache files are released in wrong way 2022-01-05 14:29:34 +08:00
Alexey Milovidov
ff779b6409 Fix error in #33124 2022-01-05 06:33:28 +03:00
lgbo-ustc
717871d9ce code style
1. remove unused error codes
2022-01-04 17:21:29 +08:00
李扬
2df2442ad0
Merge branch 'master' into hive_table 2022-01-04 01:26:16 -06:00
lgbo-ustc
45c86757bf change LRUCache to LRUResourceCache 2022-01-04 15:19:09 +08:00
taiyang-li
266ca90575 fix fast test 2022-01-04 15:17:43 +08:00
taiyang-li
8e675e9e0a fix building 2022-01-04 15:06:19 +08:00
taiyang-li
05e09e6061 fix typo 2022-01-04 14:30:01 +08:00
taiyang-li
1e102bc1b2 merge master 2022-01-01 09:01:06 +08:00
alexey-milovidov
3f1810c049
Merge pull request #33327 from ClickHouse/rename_committed_to_active
Rename Committed data part state to Active
2021-12-31 14:40:35 +03:00
Vxider
3761994f68 fix inner table parser in window view 2021-12-31 07:07:01 +00:00
Alexander Tokmakov
187c43eba8 rename Committed state to Active 2021-12-30 23:45:38 +03:00
Vladimir C
b46a1a3741
Merge pull request #33312 from zhongyuankai/optimize_system_tables 2021-12-30 17:40:39 +03:00
Vladimir C
794e906ffd
Merge pull request #33218 from amosbird/betternullablekey 2021-12-30 17:13:44 +03:00
vdimir
2686a189de
Apply suggestion for code review, changes in StorageSystemTables getFilteredTables
Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
2021-12-30 15:36:38 +03:00
kssenii
bfc705c098 Better 2021-12-30 15:19:17 +03:00
alesapin
91e1ac437e Tiny improvements 2021-12-30 12:57:38 +03:00
alesapin
cbdba89d65 Merge branch 'master' into ianton-ru-MDB-15474 2021-12-30 11:21:19 +03:00
OnePiece
0c714e8c7e
Update StorageSystemTables.cpp 2021-12-30 13:37:27 +08:00
OnePiece
b14f485f85
Update StorageSystemTables.cpp 2021-12-30 13:13:41 +08:00
OnePiece
f3f0ff0f23
Update StorageSystemTables.cpp 2021-12-30 10:12:37 +08:00
alesapin
8b331cd9bb Remove method from IStorage 2021-12-29 22:41:47 +03:00
avogar
131d49e6be Remove comments 2021-12-29 21:26:23 +03:00
avogar
97788b9c21 Allow to create new files on insert for File/S3/HDFS engines 2021-12-29 21:19:13 +03:00
Anton Popov
abcc48c1f6 Merge remote-tracking branch 'upstream/master' into support-prewhere-storage-merge 2021-12-29 21:07:35 +03:00
Anton Popov
7c6f7f6732 support 'optimize_move_to_prewhere' with storage 'Merge' 2021-12-29 20:49:10 +03:00
alesapin
7a3c874651 Merge branch 'master' into ianton-ru-MDB-15474 2021-12-29 19:01:43 +03:00
Kruglov Pavel
dd7f61b337
Merge branch 'master' into schema-inference 2021-12-29 12:59:05 +03:00
Maksim Kita
a5256e5b6e
Merge pull request #30957 from kitaisreal/executable-refactoring
Executable refactoring
2021-12-29 12:43:41 +03:00
avogar
8436638a89 Fix style 2021-12-29 12:21:01 +03:00
avogar
26abf7aa62 Remove code duplication, use simdjson and rapidjson instead of Poco 2021-12-29 12:21:01 +03:00
avogar
aaf9f85c67 Add more tests and fixes 2021-12-29 12:18:56 +03:00
avogar
8112a71233 Implement schema inference for most input formats 2021-12-29 12:18:56 +03:00
Anton Popov
4ebf61b809 proper checking of atomic flags 2021-12-29 01:03:55 +03:00
Maksim Kita
df95a40bbf Fixed tests 2021-12-28 23:50:48 +03:00
Maksim Kita
9ef359ce2c Dictionaries fix comment 2021-12-28 23:50:48 +03:00
Maksim Kita
d1db3c9f42 Updated ShellCommandSource 2021-12-28 22:55:31 +03:00
Maksim Kita
3386378050 Updated test_executable_table_function tests 2021-12-28 22:55:31 +03:00
Maksim Kita
c2977dbf58 Updated test_executable_table_function integration tests 2021-12-28 22:55:30 +03:00
Maksim Kita
5590cfa3aa Updated executable function integration tests 2021-12-28 22:55:30 +03:00
Maksim Kita
2ffd83ee83 Fix shell command source start 2021-12-28 22:55:30 +03:00
Maksim Kita
eb4e400c54 Executable refactoring 2021-12-28 22:55:30 +03:00
Kseniia Sumarokova
0c41b46e75
Merge pull request #33187 from kssenii/materialized-postgresql-fix-cleanup
materialized postgresql make sure temporary replication slots are deleted
2021-12-28 22:04:32 +03:00
alexey-milovidov
934c1b3e83
Merge pull request #33238 from kssenii/some-killing
Allow to cancel some sources which failed to cancel
2021-12-28 22:00:44 +03:00
kssenii
e9b4439a47 Fix 2021-12-28 15:08:40 +03:00
alesapin
ccbc0a8ea5
Merge pull request #33225 from zhongyuankai/optimize_merge_tree_parts_mover
Optimize MergeTreePartsMover
2021-12-28 14:35:43 +03:00
taiyang-li
2f0982d380 fix style 2021-12-28 19:04:23 +08:00
taiyang-li
aa97634d9b merge master 2021-12-28 18:38:50 +08:00
lgbo-ustc
26fcf1fbc7 fixed a bug in allocating local file cache 2021-12-28 16:57:07 +08:00
Anton Ivashkin
2d87f0a0e3 Fix debug build 2021-12-28 11:45:38 +03:00
kssenii
61a2516c8c Merge remote-tracking branch 'upstream/master' into validate-config 2021-12-28 11:30:30 +03:00
Vladimir C
bb6fc853e3
Merge pull request #31442 from vdimir/cluster-discovery 2021-12-28 10:53:30 +03:00
lgbo-ustc
1ac697cad2 some modifications 2021-12-28 11:26:39 +08:00
kssenii
1f6ca619b7 Allow some killing 2021-12-27 22:42:56 +03:00
Anton Ivashkin
0465aef15d Fixes by code review responces 2021-12-27 19:27:06 +03:00
Anton Popov
a83832c03e fix flushing of in-memory parts 2021-12-27 18:54:28 +03:00
Kseniia Sumarokova
0178fb5e0b
Merge pull request #33214 from kssenii/external-database-fix-where-false
Fix WHERE 1=0 for external databases query
2021-12-27 18:53:52 +03:00
kssenii
55dfaef4de Settings changes as key value 2021-12-27 17:45:00 +03:00
Kseniia Sumarokova
5fd952fe1b
Merge branch 'master' into materialized-postgresql-fix-cleanup 2021-12-27 17:25:51 +03:00
OnePiece
555b20bc2e
Update MergeTreePartsMover.cpp 2021-12-27 21:38:51 +08:00
OnePiece
47f0e3c72f
Update MergeTreePartsMover.cpp 2021-12-27 20:46:51 +08:00
kssenii
b90f53ffba Fix unit tests 2021-12-27 15:31:49 +03:00
vdimir
5c47229797
fix whitespace in StorageSystemClusters.cpp 2021-12-27 15:26:07 +03:00
Amos Bird
1cbd05ae9e
Correctly prevent nullable primary keys if necessary. 2021-12-27 17:32:37 +08:00
kssenii
a1aab3a82d Fix 2021-12-27 11:59:33 +03:00
Vladimir C
ea5f867289
Merge pull request #33179 from kssenii/materialized-postgresql-fix-detach-with-schema 2021-12-27 11:42:59 +03:00
Vladimir C
211a5a8d6b
Merge pull request #33159 from xuyatian/master 2021-12-27 11:40:59 +03:00
lgbo-ustc
0a39273fee fixed code style 2021-12-27 15:47:22 +08:00
taiyang-li
2d6eb40879 fix style 2021-12-27 15:31:24 +08:00
Ilya Yatsishin
a7cf7b4d6f
Merge pull request #33124 from bigo-sg/inject_gitinfo 2021-12-27 10:21:12 +03:00
taiyang-li
dd882085d0 Merge branch 'hive_table' of https://github.com/bigo-sg/ClickHouse into bigo_hive_table 2021-12-27 15:14:43 +08:00
taiyang-li
9036b18c2f merge master 2021-12-27 15:12:48 +08:00
lgbo-ustc
078521496a modifications based on pr review 2021-12-27 15:10:48 +08:00
kssenii
9f17e7bad0 Fix ddl validation 2021-12-26 20:56:31 +03:00
taiyang-li
8daeefeebe inject gitinfo 2021-12-26 15:46:38 +08:00
kssenii
2bcb122cd0 Clean up unused replication slots 2021-12-26 10:15:03 +03:00
kssenii
ef22ebad85 Better startup 2021-12-25 21:30:36 +03:00
kssenii
e663cb4574 Fix detaching-attaching table with schema 2021-12-25 19:51:55 +03:00
Kseniia Sumarokova
f8083450ab
Update ExternalDataSourceConfiguration.cpp 2021-12-25 17:43:00 +03:00
Kruglov Pavel
22dbaec11a
Merge pull request #33142 from Avogar/fix-s3-write
Don't allow to write into S3 if path contains globs
2021-12-25 16:07:38 +03:00
kssenii
59dd5ba063 Validate config keys for external dictionaries 2021-12-25 14:26:35 +03:00
taiyang-li
a88b2975c0 inject into system.build_options 2021-12-25 15:45:50 +08:00
Alexey Milovidov
f03cb4c762 Cleanup trash from Kafka and HDFS 2021-12-25 06:10:59 +03:00
Yatian Xu
565a38a2e3 fix incorrect metric: StorageBufferBytes 2021-12-24 17:49:59 -08:00
alexey-milovidov
888a5532a6
Merge pull request #33134 from ClickHouse/musl-check-2
Prepare ClickHouse to be built with musl-libc
2021-12-24 19:44:47 +03:00
avogar
58966e90e9 Don't allow to write into S3 if path contains globs 2021-12-24 17:13:35 +03:00
Nikita Mikhaylov
29fdc422d0
Merge pull request #32974 from nikitamikhaylov/hdfsCluster
Merging #32400
2021-12-24 16:02:54 +03:00
Alexey Milovidov
29d28c531f Move code around to avoid dlsym on Musl 2021-12-24 12:25:27 +03:00
Alexey Milovidov
204cc11e29 Fix incorrect include 2021-12-24 12:25:26 +03:00
lgbo-ustc
d29a4d0527 add trySet() in LRUCache 2021-12-23 16:16:33 +08:00
lgbo-ustc
ccc39bad80 move IRemoteFileMetadata info Storages/Cache 2021-12-23 15:56:33 +08:00
lgbo-ustc
a00ab6551b compile error 2021-12-23 15:43:42 +08:00
lgbo-ustc
f0b22d2882 fixed code-style 2021-12-23 15:15:39 +08:00
alexey-milovidov
0f8295de98
Merge pull request #33046 from ClickHouse/fix-prefetch-for-lc
Fix preferch for LowCardinality.
2021-12-23 08:56:16 +03:00
lgbo-ustc
e19fd5bc76 update some comments 2021-12-23 12:01:44 +08:00
lgbo-ustc
d205f9ecab codes refactor 2021-12-23 11:50:26 +08:00
Kseniia Sumarokova
639c2c1ce7
Merge pull request #32976 from Avogar/fix-hdfs-url-check
Fix hdfs url check
2021-12-22 23:57:49 +03:00
Kseniia Sumarokova
764bb1181f
Merge pull request #33017 from stigsb/table-overrides-drop-add-column-support
Remove the possibility of adding columns with table overrides
2021-12-22 22:30:21 +03:00
Dmitry Novik
1c83f31e51
Merge pull request #31885 from amosbird/optimizeprojectionmat
Optimize single part projection materialization
2021-12-22 19:36:40 +03:00
Nikolai Kochetov
bb24a494ca Fix preferch for LowCardinality. 2021-12-22 15:26:16 +03:00
Stig Bakken
1cc70ad524 Remove the possibility of adding columns with table overrides
(except ALIAS columns)

Supporting this properly requires more comprehensive changes.
2021-12-22 08:20:14 +01:00
Kseniia Sumarokova
484a4d62dd
Merge pull request #32835 from kssenii/fising-s3
Fix optimization with lazy seek for async reads from remote fs
2021-12-22 09:38:23 +03:00
Anton Ivashkin
e88b97dafb Fix typos 2021-12-21 19:56:29 +03:00
Amos Bird
f00cc3b944
optimize single part projection materialization 2021-12-21 22:39:06 +08:00
ianton-ru
e6fd4bfb50
Merge branch 'master' into MDB-15474 2021-12-21 17:38:36 +03:00
Anton Ivashkin
33cbfc89ef Move logic for replicated part to StorageReplicatedMergeTree class 2021-12-21 17:29:50 +03:00
Anton Ivashkin
0c0bf66334 Merge master 2021-12-21 17:27:54 +03:00
lgbo-ustc
1f59ce760c typo 2021-12-21 19:06:00 +08:00
kssenii
ebcb66a361 Fix 2021-12-21 10:58:02 +03:00
taiyang-li
2597925724 merge master 2021-12-21 15:55:39 +08:00
taiyang-li
cff3c20742 Merge branch 'hive_table' of https://github.com/bigo-sg/ClickHouse into bigo_hive_table 2021-12-21 15:01:23 +08:00
taiyang-li
2fd63f9381 rename some symboles 2021-12-21 15:00:47 +08:00
taiyang-li
40aa359201 refactor storage hive 2021-12-21 14:44:31 +08:00
mergify[bot]
649226853d
Merge branch 'master' into fix-clang-tidy 2021-12-21 06:05:57 +00:00
lgbo-ustc
2e2354be40 1. add tryDel and getOrTrySet in LRUCache
2. fixed bugs in LRUCache for evicting elements
2021-12-21 10:39:59 +08:00
lgbo-ustc
2c67516432 1. fixed code style
2. fixed bugs in lru cache
2021-12-21 09:44:04 +08:00
kssenii
30996b2448 Fix 2021-12-21 01:19:51 +03:00
mergify[bot]
e21c04ff9c
Merge branch 'master' into fix-data-part-modification-time 2021-12-20 18:58:47 +00:00
Anton Ivashkin
c724b074ae Remove zero-copy version converter 2021-12-20 20:23:25 +03:00
Maksim Kita
dd0d3de050
Merge pull request #32970 from kitaisreal/loops-remove-postfix-increment
Loops remove postfix increment
2021-12-20 19:51:07 +03:00
Nikita Mikhaylov
d9c13900f5 Fix build + style 2021-12-20 14:31:56 +00:00
Maksim Kita
ebff389701
Merge pull request #32972 from kitaisreal/containers-iteration-fix-erase
Containers iteration fix erase
2021-12-20 16:47:19 +03:00
Anton Ivashkin
f0b9a4327a Use table UUID in zero-copy shared label in ZooKeeper 2021-12-20 16:19:00 +03:00
Zhichang Yu
869cdbeb44 added table function hdfsCluster 2021-12-20 13:14:44 +00:00
avogar
e31c18e9f8 Fix hdfs url check 2021-12-20 16:09:48 +03:00
Maksim Kita
51477adf1b Updated additional cases 2021-12-20 15:55:07 +03:00
Nikolai Kochetov
2e62f086a1
Merge pull request #32751 from ClickHouse/fix-32668
Apply some more optimizations to NO_QUERY ast.
2021-12-20 15:47:25 +03:00
lgbo-ustc
71353ceede refactor metadata class factory 2021-12-20 20:33:41 +08:00
Maksim Kita
3feab5a975 Containers iteration fix erase 2021-12-20 13:42:31 +03:00
taiyang-li
7192458601 fix code typo 2021-12-20 18:10:15 +08:00