Since libtsan.a provides new/delete overrides too:
ld.lld: error: duplicate symbol: operator new[](unsigned long, std::nothrow_t const&)
>>> defined at new_delete.cpp:64 (../src/Common/new_delete.cpp:64)
>>> new_delete.cpp.o:(operator new[](unsigned long, std::nothrow_t const&)) in archive src/libclickhouse_new_delete.a
>>> defined at tsan_new_delete.o:(.text+0xE0) in archive /usr/lib/gcc/x86_64-linux-gnu/10/libtsan.a
v2: Fix order of src vs programs for clickhouse_new_delete target detection
This will fix undefined reference for __atomic_load under clang10 and
unbundled build (libstdc++ shared linkage):
clickhouse-server: symbol lookup error: /src/ch/clickhouse/.cmake/src/libclickhouse_disksd.so: undefined symbol: __atomic_load
From [1]:
"libatomic (GNU)
libgcc_s does not provide an implementation of an atomics library.
Instead, GCC’s libatomic library can be used to supply these when using
libgcc_s.
Note
Clang does not currently automatically link against libatomic when using
libgcc_s. You may need to manually add -latomic to support this
configuration when using non-native atomic operations (if you see link
errors referring to __atomic_* functions)."
[1]: https://clang.llvm.org/docs/Toolchain.html
squashed:
- sync FindArrow.cmake and FindParquet.cmake with arrow repo
- unbundled: add arrow to dbms link libraries
- cmake: fix-up unbundled Arrow support
Signed-off-by: Konstantin Podshumok <kpp.live+signed@gmail.com>
* master: (114 commits)
Update alter.md (#11823)
Update PODArray.h
Added a test for #6549
Update create.md
Update create.md
replacingmergetree translate into "替换合并树“ better (#11814)
Whitespace
Fix style
Added a test
Fix another 10% of bad code #11529
Update join.md (#11798)
Update memory.md (#11800)
Whitespace
Check for tests with "fail" in their names
Fix 10% of bad code #11756
Update PODArray.h
avoid duplicate short system name
adapt recent result as well
[website] tune benchmark pages styling + add extra checks
Added MSan suppression for Hyperscan
...
# Conflicts:
# src/Common/ErrorCodes.cpp
The following error reported:
FAILED: src/Interpreters/tests/hash_map
...
ld.lld: error: undefined symbol: typeinfo for DB::AggregateFunctionCount
>>> referenced by typeinfo:308 (../contrib/libcxx/include/typeinfo:308)
>>> InterpreterSelectQuery.cpp.o:(std::__1::enable_if<is_pointer_v<DB::AggregateFunctionCount*>, DB::AggregateFunctionCount*>::type typeid_cast<DB::AggregateFunctionCount*, DB::IAggregateFunction>(DB::IAggregateFunction*)) in archive src/libdbms.a
collect2: error: ld returned 1 exit status
And also this one with gold linker:
FAILED: programs/clickhouse-odbc-bridge
... src/AggregateFunctions/libclickhouse_aggregate_functions.a ... src/libdbms.a ...
../contrib/libcxx/include/typeinfo:308: error: undefined reference to 'typeinfo for DB::AggregateFunctionCount'
Due to order?
Introduced by 394fb64a9cda376ca8dfa8bac08a4fbcfa9bf3bf/#11661 I guess.
* master: (114 commits)
Update PushingToViewsBlockOutputStream.cpp
Update PushingToViewsBlockOutputStream.cpp
make clang-10 happy
Fix sync_async test (remove timeout)
CLICKHOUSEDOCS-631: temporary_files_codec, join_on_disk_max_files_to_merge settings. (#11242)
Suppress output of cancelled queries in clickhouse-client #9473
Better log messages in ConfigReloader
fix select from StorageJoin
Fix unit tests under MSan
Added test.
Fix build.
Fix arguments for AggregateFunctionQuantile/
Update style.md
Add a guide on error messages.
Report dictionary name on dictionary load errors.
more types in ASOF JOIN (#11301)
Fix part_log test
Update test.
Add perftest.
Parallel processing for PushingToViewsBlockOutputStream::writeSuffix
...
* master: (204 commits)
DOCS-289: randConstant (#10838)
Update performance_comparison.md
fix docs build
Adjust ld+json images, remove feather icons (#10843)
[docs] faster local/debug build (#10840)
CLICKHOUSE-4862: some markdown fixes @ ru mergetree.md (#10835)
CLICKHOUSE-4862: fix link (#10836)
Some fixes at ru merge-tree-settings.md (#10837)
Fix MSan failure in cache dictionary
Fix double whitespace
Additional assert in ColumnVector
Fix paths in compiler error messages #10434
Fix "Arcadia" build
Fix style check in Block::sortColumns() (sigh)
Sort iterators to avoid extra std::string creation in Block::sortColumns()
Optimize Block::sortColumns()
Better DNS exception message
Fix logical error in convertFieldToType
Make order of columns strict in Block::sortColumns()
Add a test for INSERT into Buffer() with different order of columns (via MV)
...
