Commit Graph

85631 Commits

Author SHA1 Message Date
Alexey Milovidov
475dec3809
Merge pull request #35814 from ClickHouse/merge_tree_arguments_error
Better error message for incorrect *MergeTree arguments
2022-04-01 03:04:43 +03:00
Alexey Milovidov
ab3fc5e514
Merge pull request #35815 from ClickHouse/filimonov-patch-cgroups
Fix cgroups cores detection
2022-04-01 03:02:07 +03:00
Alexey Milovidov
654271614c
Merge pull request #35822 from den-crane/patch-5
Doc. note about move_factor
2022-04-01 03:00:37 +03:00
Denny Crane
767c88689d
Update mergetree.md 2022-03-31 15:42:50 -03:00
Denny Crane
4f70876041
Update mergetree.md 2022-03-31 15:41:17 -03:00
Denny Crane
e53773d7c5
Update mergetree.md 2022-03-31 15:32:40 -03:00
filimonov
24d72a18d0
Update getNumberOfPhysicalCPUCores.cpp
In Kubernetes shares are calculated from resources.requests.cpu, quota & period - from limits.

When you configure only requests without limits - the container still can use all the cores. So you see all the cores the system has.
(because of requests the pod just can't be scheduled on the node which have less cpus)
So the effective CPU count is all the available cores if you don't have limits, or calculated from quota & period if you have the limits.
2022-03-31 17:21:54 +02:00
Alexander Tokmakov
63e8d73ba4 better message for incorrect *MergeTree arguments 2022-03-31 17:08:30 +02:00
Antonio Andelic
1d480178c4
Merge pull request #35785 from justnoise/remove-atomic-flag-init
remove ATOMIC_FLAG_INIT: depreciated in C++20 and warns in clang-14
2022-03-31 16:44:56 +02:00
Nikolay Degterinsky
d4722351b8
Merge pull request #35804 from evillique/fix-docs
Fix docs
2022-03-31 17:18:32 +03:00
Nikolay Degterinsky
13f464a468 Fix docs 2022-03-31 12:38:12 +00:00
tavplubix
f3f335d5bf
Merge pull request #35802 from ClickHouse/revert-35602-schema-inference-hdfs-cluster
Revert "Added support for schema inference for `hdfsCluster`"
2022-03-31 15:20:52 +03:00
Nikita Mikhaylov
5f27f690f4 Revert "Added support for schema inference for hdfsCluster (#35602)"
This reverts commit f6bfdcc0c9.
2022-03-31 14:19:56 +02:00
alesapin
bd2ab32e3f
Merge pull request #35772 from azat/keeper-eof
clickhouse-keeper: correctly handle closed client connection
2022-03-31 13:57:28 +02:00
Nikita Mikhaylov
f6bfdcc0c9
Added support for schema inference for hdfsCluster (#35602) 2022-03-31 12:47:36 +02:00
alesapin
8f0919d2a2
Merge pull request #35774 from ClickHouse/ressurect_build_hash_v2
One more try to resurrect build hash
2022-03-31 11:43:44 +02:00
alesapin
2365bbf0d3
Merge pull request #34566 from ClickHouse/startup-sanity-checks
add simple sanity checks for server startup
2022-03-31 11:33:59 +02:00
tavplubix
5680f53ed4
Merge pull request #35773 from azat/stateless-tests-artifacts
ci: replace directory system log tables artifacts with tsv
2022-03-31 12:16:48 +03:00
Kseniia Sumarokova
a711fc0402
Merge pull request #35572 from bigo-sg/hdfs_config_prefix
Deduce absolute hdfs config path
2022-03-31 10:08:32 +02:00
Kseniia Sumarokova
0b20329156
Merge pull request #35727 from kssenii/fix-any-all
Fix any/all(subquery)
2022-03-31 10:05:37 +02:00
Antonio Andelic
13b4fabee4
Merge pull request #35743 from bigo-sg/remote_filter_for_hive
Respect remote_url_allow_hosts for hive
2022-03-31 08:54:37 +02:00
Antonio Andelic
cdedcee0ce
Merge pull request #35746 from ClickHouse/use-common-io-thread-pool
Use common IOThreadPool for S3 and URL
2022-03-31 08:41:54 +02:00
Azat Khuzhin
ff0e46c394 clickhouse-keeper: finish session on client EOF (fixes heap-use-after-free)
CI founds [1]:

    WARNING: ThreadSanitizer: heap-use-after-free (pid=1)
      Read of size 8 at 0x7b48001e0088 by thread T7 (mutexes: write M2588):
        ...
        1 DB::KeeperTCPHandler::runImpl()::$_0::operator()() const build_docker/../src/Server/KeeperTCPHandler.cpp:384:14 (clickhouse+0x194f974f)
        ...
        8 DB::KeeperDispatcher::setResponse() build_docker/../src/Coordination/KeeperDispatcher.cpp:222:9 (clickhouse+0x1999de82)
        9 DB::KeeperDispatcher::responseThread() build_docker/../src/Coordination/KeeperDispatcher.cpp:161:18 (clickhouse+0x1999d7a7)
        10 DB::KeeperDispatcher::initialize()::$_1::operator()() const build_docker/../src/Coordination/KeeperDispatcher.cpp:273:54 (clickhouse+0x199a55d1)

      Previous write of size 8 at 0x7b48001e0088 by thread T3:
        0 operator delete(void*, unsigned long) <null> (clickhouse+0xa0dad50)
        1 DB::KeeperTCPHandler::~KeeperTCPHandler() build_docker/../src/Server/KeeperTCPHandler.cpp:648:1 (clickhouse+0x194f8ee6)

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/35772/38873d726d22b15d4c5a284410956927b2e2f95f/integration_tests__thread__actions__[4/4].html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-03-31 09:31:34 +03:00
Brendan Cox
87fff8b2d3 remove ATOMIC_FLAG_INIT: depreciated in C++20 and warns in clang-14 2022-03-30 21:45:48 -07:00
taiyang-li
f6ccda8097 Merge branch 'master' into hdfs_config_prefix 2022-03-31 12:16:05 +08:00
taiyang-li
c11f563d47 Merge branch 'master' into remote_filter_for_hive 2022-03-31 10:54:55 +08:00
alesapin
b078288709 Merge branch 'startup-sanity-checks' of github.com:ClickHouse/ClickHouse into startup-sanity-checks 2022-03-31 00:29:57 +02:00
alesapin
ae3bcbb99b Fix logs space check 2022-03-31 00:22:36 +02:00
Nikolay Degterinsky
f055d7b692
Merge pull request #34055 from palegre-tiny/groupSortedArray
Add groupSortedArray() function
2022-03-31 01:20:15 +03:00
alesapin
81ce991494 Merge branch 'master' into startup-sanity-checks 2022-03-31 00:08:43 +02:00
Kruglov Pavel
4ec3c35e14
Merge pull request #35755 from Avogar/fix-custom-to-string
Fix bug in conversion from custom types to string
2022-03-31 00:06:48 +02:00
alesapin
5a55913f45
Merge pull request #35720 from ClickHouse/parallel_stateful
Try to run stateful tests in parallel
2022-03-30 23:42:44 +02:00
alesapin
10db099d2f One more try to resurrect build hash 2022-03-30 23:27:46 +02:00
Alexander Gololobov
1d7059175b
Merge pull request #35681 from tonickkozlov/patch-2
[test] Adds clean-up for functional test 02167
2022-03-30 23:09:51 +02:00
Nikita Taranov
30f2a942c5
Predict size of hash table for GROUP BY (#33439)
* use AggregationMethod ctor with reserve

* add new settings

* add HashTablesStatistics

* support queries with limit

* support distributed and with external aggregation

* add new profile events

* add some tests

* add perf test

* export cache stats through AsynchronousMetrics

* rm redundant trace

* fix style

* fix 02122_parallel_formatting test

* review fixes

* fix 02122_parallel_formatting test

* apply also to two-level HTs

* try simpler strategy

* increase max_size_to_preallocate_for_aggregation for experiment

* fixes

* Revert "increase max_size_to_preallocate_for_aggregation for experiment"

This reverts commit 6cf6f75704.

* fix test

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2022-03-30 22:47:51 +02:00
Azat Khuzhin
8b84829e93 ci: replace directory system log tables artifacts with tsv
Changelog:
- remove query_thread_log (query_log should be enough)
- for s3 storage there /var/lib/clickhouse/data/system/*_log cannot be
  used, replace them with plain TSVWithNamesAndTypes, also note, that
  after schema inference it is even pretty easy to use
- support replicated database env correctly

Co-authored-by: tavplubix <tavplubix@clickhouse.com>
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-03-30 21:50:55 +03:00
Azat Khuzhin
38873d726d clickhouse-keeper: fix implementation of server with poll()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-03-30 21:30:12 +03:00
kssenii
ac4897f4f9 Fix 2022-03-30 20:16:41 +02:00
Alexander Gololobov
8f7329d7dd
Removed debug print 2022-03-30 20:10:25 +02:00
alesapin
02574bd05b
Merge pull request #35766 from ClickHouse/resurrect_official_flag
Resurrect build hash
2022-03-30 19:34:19 +02:00
Azat Khuzhin
9820230e95 clickhouse-keeper: correctly handle closed client connection
This will avoid noisy message like:

    DB::Exception: Cannot read all data. Bytes read: 0. Bytes expected: 4.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-03-30 20:29:04 +03:00
alesapin
b388bb8448
Merge pull request #35718 from ClickHouse/fail_build_check_in_error_status
Fail CI checks in case of errors in checks (not failed tests)
2022-03-30 19:28:22 +02:00
alesapin
fcd4e0be65 Black 2022-03-30 19:15:27 +02:00
mergify[bot]
78bcf2655f
Merge branch 'master' into startup-sanity-checks 2022-03-30 17:07:35 +00:00
tavplubix
82a32194bf
Merge pull request #35768 from ClickHouse/tavplubix-patch-2
Fix 00484_preferred_max_column_in_block_size_bytes
2022-03-30 19:17:12 +03:00
Dmitry Novik
597c1a6523
Merge pull request #35719 from ClickHouse/memory-overcommit-test-fix
Try to fix test_global_overcommit_tracker flakyness
2022-03-30 18:15:40 +02:00
kssenii
c1ae5814a7 Merge master 2022-03-30 17:59:36 +02:00
tavplubix
c34d512586
Update 00484_preferred_max_column_in_block_size_bytes.sql 2022-03-30 18:36:37 +03:00
tavplubix
60ecd49313
Merge pull request #35754 from ClickHouse/fix-ci-script-style-check
Fix stylecheck
2022-03-30 18:06:33 +03:00
alesapin
8980994faa Resurrect build hash 2022-03-30 16:29:13 +02:00