thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-02 12:32:04 +00:00
Code Issues Packages Projects Releases Wiki Activity
91,792 Commits 9,194 Branches 1,782 Tags 2.2 GiB
4a52d3f6b9
Commit Graph

91792 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Azat Khuzhin
4a52d3f6b9 tests: update reference for 00597_push_down_predicate_long 
CI: https://s3.amazonaws.com/clickhouse-test-reports/37887/6b4613c88056f3901f6d8a832c9e2bc15e22206d/stateless_tests__aarch64__actions_.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-06-28 22:53:03 +03:00
Azat Khuzhin
f86ddebada Add sanity check for UNION header 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-06-28 22:53:03 +03:00
Azat Khuzhin
d98336ad83 Fix incorrect columns order in subqueries of UNION 
Consider the following query:

    SELECT avgWeighted(x, y) FROM (SELECT NULL, 255 AS x, 1 AS y UNION ALL SELECT y, NULL AS x, 1 AS y)

Here is UNION from two SELECT queries
- `SELECT NULL, 255 AS x, 1 AS y`
- `SELECT y, NULL AS x, 1 AS y`

UNION queries matches columns by positions, not names, so the following
columns should be used by `avgWeighted()`:
- `255 AS x,  1 AS y`
- `NULL AS x, 1 AS y`

Result types of arguments should be:
- `x Nullable(UInt8)`
- `y UInt8`

And in case of UNION query is a subselect itself, it will return only
required columns, for the example above it needs only `x` and `y`.
For this it will get positions of these arguments from the first query,
and then use those positions to get required column names from the
second query (since there is no ability to get columns by positions
instead of names internally), and due to duplicated columns the second
query will return (`y`, `x`) not (`x`, `y`), and this will make the
result incorrect:

    EXPLAIN header = 1, optimize = 0, actions=1 SELECT avgWeighted(x, y) FROM (SELECT NULL, 255 AS x, 1 AS y UNION ALL SELECT y, NULL AS x, 1 AS y)

    Aggregates:
        avgWeighted(x, y)
          Function: avgWeighted(Nullable(UInt8), UInt8) → Nullable(Float64)
          Arguments: x, y
          Argument positions: 0, 1
      Expression (Before GROUP BY)
      Header: x UInt8
              y Nullable(UInt8)
      ...
      Union
      Header: x UInt8
              y Nullable(UInt8)
        Expression (Conversion before UNION)
        Header: x UInt8
                y Nullable(UInt8)
        Expression (Conversion before UNION)
        Header: x UInt8
                y Nullable(UInt8)

And the query itself fails with an error:

    Logical error: 'Bad cast from type DB::ColumnVector<char8_t> to DB::ColumnNullable'.

_NOTE: `avgWeighted()` here is required to trigger `LOGICAL_ERROR`_

CI: https://s3.amazonaws.com/clickhouse-test-reports/37796/e637489f81768df582fe7389e57f7ed12893087c/fuzzer_astfuzzerdebug,actions//report.html
Fixes: 02227_union_match_by_name
v2: fix untuple() (reserve space for output_columns_positions too)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-06-28 22:53:03 +03:00
Azat Khuzhin
563fac5333 tests: add a test for incorrect header in UNION queries 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-06-28 22:53:03 +03:00
Azat Khuzhin
ee0f2651ee Revert "Fix converting types for UNION queries (may produce LOGICAL_ERROR)" 
This fix is incorrect, and it introduce new issues, in particular it
may breaks UNION queries w/o column aliases, i.e.:

    SELECT a, b, c FROM (SELECT 3 AS a, 2147483647 AS b, 1048575 AS c UNION ALL SELECT -2, NULL, -2) AS js1 ORDER BY a

CI: https://s3.amazonaws.com/clickhouse-test-reports/37796/e637489f81768df582fe7389e57f7ed12893087c/fuzzer_astfuzzerdebug,actions//report.html
Reverts: #37593/#34775 (2613149f6b)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-06-28 22:50:01 +03:00
Alexander Tokmakov
0bb036dd21
Update Dockerfile 2022-06-28 20:35:20 +03:00
Ilya Yatsishin
400c8ad7a4
Merge pull request #38505 from jrdi/patch-1 
Specify that write quorum can be activated
 2022-06-28 18:11:09 +02:00
Alexander Tokmakov
66cf6da35c
Merge pull request #38518 from ClickHouse/tavplubix-patch-1 
Fix `_csv.Error: field larger than field limit`
 2022-06-28 18:46:43 +03:00
Alexander Tokmakov
e23f1fa774
Merge pull request #38269 from excitoon-favorites/integrationtestsfixes 
Don't try to kill empty list of containers in `integration/runner` II
 2022-06-28 17:35:48 +03:00
Kruglov Pavel
25100ad5e5
Merge pull request #38520 from ClickHouse/Avogar-patch-1 
Fix application errors grep in stress test
 2022-06-28 14:26:22 +02:00
Alexander Tokmakov
2386554746
Merge pull request #38490 from ClickHouse/test-handle-full-queue 
Handle full queue exception in tests
 2022-06-28 15:03:10 +03:00
Alexander Tokmakov
07cecd4e66
Merge pull request #38516 from ClickHouse/fix_flaky_store_cleanup 
Try to fix flaky test
 2022-06-28 14:56:54 +03:00
Miel Donkers
4e9f396a48
Small improvement of the error message to hint at possible issue (#38458) 2022-06-28 13:36:30 +02:00
Alexander Tokmakov
411512ed6f
Update run.sh 2022-06-28 14:28:06 +03:00
Kruglov Pavel
f7419e0703
Fix application errors grep in stress test 2022-06-28 13:12:21 +02:00
Kruglov Pavel
ccdeaea2f0
Update 01378_alter_rename_with_ttl_zookeeper.sql 2022-06-28 13:06:49 +02:00
Mikhail f. Shiryaev
575366e37d
Merge pull request #38507 from ClickHouse/report-logging 
A tiny improvement in report logging
 2022-06-28 12:56:51 +02:00
Alexander Tokmakov
456e03758b
Update process_functional_tests_result.py 2022-06-28 13:52:39 +03:00
Alexander Tokmakov
e82a375946
Update Settings.h 2022-06-28 13:47:22 +03:00
Alexander Tokmakov
0c51bd9c23 fix flaky test 2022-06-28 12:38:36 +02:00
Igor Nikonov
64490963fd
Merge pull request #38489 from ClickHouse/cleanup_local_clang_tidy_fixes 
Cleanup: local clang-tidy warnings founded during review
 2022-06-28 12:23:46 +02:00
Kseniia Sumarokova
4a6af1ba81
Merge pull request #38466 from kssenii/follow-uo-iobjectstorage 
Follow up for #38436
 2022-06-28 12:06:42 +02:00
Mikhail f. Shiryaev
94f932add1
A tiny improvement in logging 2022-06-28 10:27:25 +02:00
Jordi Villar
e8cdee73e1
Update architecture.md 2022-06-28 09:27:28 +02:00
Igor Nikonov
e41d612b1d Cleanup: local clang-tidy warnings founded during review 2022-06-27 20:57:18 +00:00
Dmitry Novik
c24c041b12 Handle full queue exception in tests 2022-06-27 20:54:52 +00:00
Vladimir Chebotarev
89dc2844db Fix for integration tests fix. 2022-06-27 23:13:40 +03:00
Alexey Milovidov
fb12267338
Merge pull request #38481 from yukotakagi/patch-2 
Add 22.7 release webinar.
 2022-06-27 22:58:00 +03:00
Dmitry Novik
b629d557ce
Merge pull request #38246 from ClickHouse/overcommit-deadlock-fix 
Fix deadlock in OvercommitTracker logging
 2022-06-27 21:57:31 +02:00
Yuko Takagi
83b87938e8
Add 22.7 release webinar. 2022-06-27 13:23:26 -06:00
Yakov Olkhovskiy
d5f65ece9b
Merge pull request #38105 from arenadata/ADQM-419 
Add kerberosInit function as a replacement for kinit executable calls in Kafka and HDFS
 2022-06-27 14:19:24 -04:00
Robert Schulze
53cd8820d3
Merge pull request #38434 from ClickHouse/multi-match-with-nonconst-patterns 
Refactoring to enable multi-match functions with non-const needles
 2022-06-27 19:35:48 +02:00
Dmitry Novik
118cbfbf94
Merge pull request #38327 from ClickHouse/backports-builds 
Checkout full repositories for performance tests
 2022-06-27 19:24:12 +02:00
alesapin
bed8ee556c
Merge pull request #38465 from ClickHouse/kssenii-patch-4 
Fix comment
 2022-06-27 18:44:17 +02:00
Alexander Tokmakov
2283436d24
Merge pull request #38344 from Algunenano/implicit_transactions 
Add implicit_transaction setting
 2022-06-27 18:50:37 +03:00
kssenii
c9faab4992 Fix 2022-06-27 16:48:06 +02:00
Kseniia Sumarokova
e515579cbe
Update IObjectStorage.h 2022-06-27 16:26:36 +02:00
Alexander Tokmakov
bec921c9d9
Merge pull request #38265 from ClickHouse/cleanup_garbage_in_store_dir 
Add background cleanup of store/ subdirs
 2022-06-27 16:53:13 +03:00
Kruglov Pavel
7ec83add46
Merge pull request #38454 from mdonkers/docs-clarify-datetime64-parsing 
Docs: clarify processing of DateTime64 values
 2022-06-27 15:09:09 +02:00
Alexander Tokmakov
c4d815c60b
Update test.py 2022-06-27 15:44:20 +03:00
Vladimir C
ad7c6de314
Merge pull request #38318 from laurieliyang/zh-docs-patch-20220622 2022-06-27 14:43:44 +02:00
Mikhail f. Shiryaev
1b945307ea
Merge pull request #38238 from ClickHouse/changelog-attrs 
Changelog attrs
 2022-06-27 14:30:19 +02:00
Anton Kozlov
5f81bcd84f
CLICKHOUSE-1331 Rewrite tuple functions as literals in backwards-compatibility mode (#38096) 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2022-06-27 14:13:21 +02:00
Nikita Taranov
2487ba7f00
Move updateInputStream to ITransformingStep (#37393) 2022-06-27 13:16:52 +02:00
Miel Donkers
674188bd7f
Docs: clarify processing of DateTime64 values 2022-06-27 12:19:30 +02:00
mergify[bot]
da52780cb5
Merge branch 'master' into implicit_transactions 2022-06-27 09:46:34 +00:00
alesapin
50eb364a56
Merge pull request #38436 from kssenii/remote-path-separation-in-object-storage 
more consistent work with paths in object storages
 2022-06-27 10:58:01 +02:00
Alexey Milovidov
020062f5c9
Merge pull request #38429 from xinhuitian/fix-some-wrong-links 
fix other wrong links in alter column and partition docs
 2022-06-27 07:38:13 +03:00
Alexey Milovidov
010efe4fa7
Merge pull request #38445 from santrancisco/master 
Update Security.md generation code before OSS Bugcrowd program
 2022-06-27 07:35:02 +03:00
Vladimir Chebotarev
2b19e69930 Don't try to kill empty list of containers in integration/runner. 2022-06-27 06:12:10 +03:00