Commit Graph

150264 Commits

Author SHA1 Message Date
Azat Khuzhin
4c043301e6 Avoid ignoring errors of execute_process() (set COMMAND_ERROR_IS_FATAL=ANY)
This will fix with issues like this [1]:

    Aug 12 09:58:44 '/usr/bin/cmake' '--build' '/build/build_docker/native' '--target' 'pre_compressor'
    Aug 12 09:58:44 sccache: error: Server startup failed: cache storage failed to read: Unexpected (temporary) at stat
    Aug 12 09:58:45 ninja: build stopped: subcommand failed.
    Aug 12 09:58:45 -- Configuring done (77.7s)
    Aug 12 09:58:47 -- Generating done (1.8s)
    Aug 12 09:58:47 -- Build files have been written to: /build/build_docker

So as you can see even if ninja fails it still wrote build files, while
it should fail.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/64955/0af41e32a5822d25ac3760f1ebb2313557474701/builds/report.html
  [2]: 0af41e32a5/binary_darwin_aarch64/build_log.log

Note, COMMAND_ERROR_IS_FATAL is 3.19+, and the requirement for now is
3.20

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-08-13 10:35:54 +02:00
Alexey Milovidov
0b1887eb65
Merge pull request #68138 from jsc0218/Fix01710
Fix01710 Timeout
2024-08-12 04:07:52 +00:00
Alexey Milovidov
c1c8e6dd8d
Merge pull request #68099 from GrahamCampbell/patch-2
Do not apply redundant sorting removal when there's an offset
2024-08-11 23:59:15 +00:00
Alexey Milovidov
d18a68f285
Merge pull request #68160 from azat/tests/02122_join_group_by_timeout
tests: fix 02122_join_group_by_timeout flakiness
2024-08-12 02:20:51 +02:00
Alexey Milovidov
c462f4639b
Merge pull request #68161 from narqo/patch-1
Fix typos in Prometheus protocol docs
2024-08-11 23:55:53 +00:00
Alexey Milovidov
d2a9eaaa01
Merge pull request #68157 from azat/local-fix-log
Remove "Processing configuration file" message from clickhouse-local
2024-08-11 23:07:43 +00:00
Alexey Milovidov
4de79653ea
Merge pull request #68134 from azat/tests/01246_buffer_flush
tests: fix 01246_buffer_flush flakiness due to slow trace_log flush
2024-08-11 17:56:05 +00:00
Azat Khuzhin
e384e2c38e tests: fix 02122_join_group_by_timeout flakiness
CI found [1] failure of the test:

    2024-08-11 21:06:07 /usr/share/clickhouse-test/queries/0_stateless/02122_join_group_by_timeout.sh: line 51: 52614 Killed                  timeout -s KILL $MAX_PROCESS_WAIT $CLICKHOUSE_CLIENT -q "SELECT a.name as n

And the problem is not the server, but the client, since query executed
for ~1 second:

    2024.08.11 21:06:02.284318 [ 49232 ] {ba989ee2-f615-49ca-bcd8-31b3916aeb2c} <Debug> executeQuery: (from [::1]:54144) (comment: 02122_join_group_by_timeout.sh) SELECT a.name as n FROM ( SELECT 'Name' as name, number FROM system.numbers LIMIT 2000000 ) AS a, ( SELECT 'Name' as name2, number FROM system.numbers LIMIT 2000000 ) as b FORMAT Null SETTINGS max_execution_time = 1, timeout_overflow_mode = 'break'  (stage: Complete)
    2024.08.11 21:06:03.331249 [ 49232 ] {ba989ee2-f615-49ca-bcd8-31b3916aeb2c} <Debug> executeQuery: Read 517104 rows, 3.95 MiB in 1.072023 sec., 482362.78512681165 rows/sec., 3.68 MiB/sec.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/67134/18da3f0ab63da1eef9396627d0dfd56cf5356f65/stateless_tests__msan__[1_4].html

So instead of using timeout, let's use time from the system.query_log
instead.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-08-11 18:39:09 +02:00
Vladimir Varankin
d314e5aa45
typos in prometheus.md 2024-08-11 18:37:29 +02:00
Igor Nikonov
4ef3fe416d Fix and simplify test 2024-08-11 13:08:53 +00:00
Igor Nikonov
fbf4baf47e Merge remote-tracking branch 'origin/master' into patch-2 2024-08-11 11:52:42 +00:00
Azat Khuzhin
29afd2de78 Remove "Processing configuration file" message from clickhouse-local
Make the behaviour identical to the clickhouse-client

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-08-11 13:26:45 +02:00
Alexander Tokmakov
7de1c4bfc3
Merge pull request #68051 from ClickHouse/tavplubix-patch-10
Update test_drop_is_lock_free/test.py
2024-08-11 11:21:38 +00:00
Alexander Tokmakov
459e34b7b8
Merge pull request #68156 from ClickHouse/revert-68034-stats-tests-refactoring
Revert "Refactor tests for (experimental) statistics"
2024-08-11 11:20:15 +00:00
Alexander Tokmakov
53bc1b7e35
Revert "Refactor tests for (experimental) statistics" 2024-08-11 13:19:36 +02:00
Robert Schulze
f7e7a884b5
Merge pull request #67962 from Blargian/docs_toDecimalXYZ
Docs:`toDecimal32/64/128/256` and variants
2024-08-11 09:23:40 +00:00
Robert Schulze
45db564354
Merge pull request #68034 from rschu1ze/stats-tests-refactoring
Refactor tests for (experimental) statistics
2024-08-11 08:43:31 +00:00
Azat Khuzhin
1142305b11 tests: fix 01246_buffer_flush flakiness due to slow trace_log flush
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-08-11 07:06:51 +02:00
Alexey Milovidov
80b18a8591
Merge pull request #68145 from ClickHouse/followup-68112
Remove the extra cell from reports when it is not necessary
2024-08-11 02:42:35 +00:00
Igor Nikonov
9ce97e918b
Merge branch 'master' into patch-2 2024-08-11 00:07:46 +02:00
János Benjamin Antal
613ebe367c Only add extra cell when necessary 2024-08-10 22:05:11 +00:00
Alexey Milovidov
639cfd3cc2
Merge pull request #68136 from azat/tests/01600_parts_states_metrics_long
tests: attempt to fix 01600_parts_states_metrics_long (by forbid parallel run)
2024-08-10 21:13:22 +00:00
János Benjamin Antal
7aaa038571
Merge pull request #67922 from ClickHouse/fix_trivial_count_non_deterministic_func
Fix wrong `count()` result when there is non-deterministic function in predicate
2024-08-10 21:13:12 +00:00
alesapin
c945209427
Merge pull request #68003 from ClickHouse/ignore_broken_projections_on_start
Ignore disappeared projections on start
2024-08-10 19:34:40 +00:00
Anton Popov
a925faf8f9
Merge pull request #68053 from CurtizJ/enable-optimize_functions_to_subcolumns_2
Enable setting `optimize_functions_to_subcolumns` by default
2024-08-10 18:32:47 +00:00
jsc0218
d53513a81a fix 2024-08-10 18:12:34 +00:00
Alexey Milovidov
4c4d1e8c65
Merge pull request #67233 from ClickHouse/debug_exec_dict
Debug logging for #67002
2024-08-10 17:41:21 +00:00
Alexey Milovidov
1abaf0c895
Merge pull request #68017 from ClickHouse/add-test-57420
Add a test for #57420
2024-08-10 17:40:17 +00:00
Antonio Andelic
3a2be13a93
Merge pull request #67975 from ClickHouse/update-minio-statless
Update minio in stateless tests
2024-08-10 16:15:14 +00:00
Antonio Andelic
16e52b547b
Merge pull request #68106 from ClickHouse/fix-with-retries-data-race
Fix race in `WithRetries`
2024-08-10 15:43:25 +00:00
Azat Khuzhin
eeda67042c tests: make 01600_parts_states_metrics_long faster
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-08-10 16:29:26 +02:00
Azat Khuzhin
18d9bb2ade tests: attempt to fix 01600_parts_states_metrics_long (by forbid parallel run)
CI: https://s3.amazonaws.com/clickhouse-test-reports/68134/8d4f822fee64d44440459b733c67dee5e9fb1e02/stateless_tests__tsan__s3_storage__[2_4].html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-08-10 16:29:26 +02:00
Blargian
e582118544 review changes 2024-08-10 13:09:40 +02:00
Nikita Fomichev
4a31ccd653
Merge pull request #68013 from ClickHouse/pass-job-timeout-to-tests
CI: Pass job timeout into tests config
2024-08-10 10:38:41 +00:00
Nikita Fomichev
9b9fff4232 Push CI 2024-08-10 08:48:08 +02:00
Alexey Milovidov
b4f256ac0b
Merge pull request #68008 from ClickHouse/clickhouse-local-remove-unused-command-line-option
Remove unused CLI option
2024-08-10 00:17:12 +00:00
Alexey Milovidov
e7215d1029
Merge pull request #67959 from jkartseva/fix-flaky-test-storage-s3-queue
Fix flaky `test_storage_s3_queue/test.py::test_multiple_tables_streaming_sync_distributed`
2024-08-10 00:12:09 +00:00
Alexey Milovidov
e6bbbaadaa
Merge pull request #68107 from ClickHouse/avoid-to-string-conversion-for-cast
Avoid converting type to string and back in _CAST
2024-08-10 00:08:44 +00:00
Alexey Milovidov
b65cc91ae6 Merge branch 'master' into add-test-57420 2024-08-10 01:47:50 +02:00
Alexey Milovidov
b583b4812f
Merge pull request #68130 from ClickHouse/fix-long-parquet-load
Fix test `00900_long_parquet_load`
2024-08-09 22:13:01 +00:00
Alexey Milovidov
e6e06af7bd
Merge pull request #64281 from bigo-sg/extend_inequal_join
`Any/Semi/Anti` join support mixed join conditions
2024-08-09 21:36:31 +00:00
Alexey Milovidov
a79eff9dcf
Merge pull request #67647 from jacobrec/multilinestring
Added support for reading MultiLineString WKTs
2024-08-09 21:35:55 +00:00
Anton Popov
b5afddb1af
Update optimize_functions_to_subcolumns.xml 2024-08-09 22:56:25 +02:00
Alexey Milovidov
c13d348d1e Fix test 00900_long_parquet_load 2024-08-09 19:56:50 +02:00
Alexey Milovidov
5881f28718
Merge pull request #68112 from ClickHouse/add-empty-cell-to-reports-when-time-is-missing
Add empty cell to reports when time is missing
2024-08-09 15:55:49 +00:00
Antonio Andelic
dc76d9899d
Merge pull request #68097 from ClickHouse/try-fix-02675_profile_events_from_query_log_and_client
Fix flaky `02675_profile_events_from_query_log_and_client`
2024-08-09 14:56:36 +00:00
Anton Popov
c682e35b59
Merge pull request #68052 from CurtizJ/fix-mutations-analyzer
Fix skip of parts in mutation with analyzer
2024-08-09 14:24:31 +00:00
Nikolai Kochetov
65ebcd6f21 Fixing test. 2024-08-09 13:55:47 +00:00
János Benjamin Antal
8cf5f6d616 Add empty cell to reports when time is missing 2024-08-09 13:20:05 +00:00
Sema Checherinda
1e67b46b57
Merge pull request #67684 from ClickHouse/chesema-rewrite-storage-policy
rework usage of custom table's disks
2024-08-09 12:36:29 +00:00