Azat Khuzhin
4cecc238d6
Fix SIGSEGV for external GROUP BY and overflow row
...
Overflow row is used for GROUP BY if all of the above is true:
- WITH TOTALS is requested
- max_rows_to_group_by > 0
- group_by_overflow_mode = any
- totals_mode != after_having_exclusive
And in case of overflow row and external GROUP BY, once the temporary
file dumps to disk it resets without_key data variant to nullptr, so any
subsequent dump to disk will cause SIGSEGV.
Fix this, by recreating without_key data variant after dumping to disk,
instead of reseting to nullptr.
And also add sanity check (LOGICAL_ERROR) to make error more
deterministic in case of such error.
Found with fuzzer [1].
[1]: https://clickhouse-test-reports.s3.yandex.net/23929/e7027e052998540ee660d186727e20f9555b729d/fuzzer_ubsan/report.html#fail1
2021-05-08 17:48:24 +03:00
alexey-milovidov
26dc6517c0
Merge pull request #23908 from ClickHouse/fix-bad-test-codecs
...
Fix bad test about compression codecs
2021-05-06 03:31:45 +03:00
Alexey Milovidov
d283870f3d
Fix test that depends on configuration too much
2021-05-06 01:14:32 +03:00
alexey-milovidov
1ca685da4a
Merge pull request #23886 from ClickHouse/remove-obsolete-code
...
Remove obsolete code
2021-05-06 01:11:25 +03:00
Alexey Milovidov
8827857fc3
Fix bad test
2021-05-06 01:09:50 +03:00
Alexey Milovidov
969649c4e5
Fix bad test (tabs)
2021-05-06 01:09:50 +03:00
alexey-milovidov
7ae8938b69
Merge pull request #23896 from ClickHouse/implement-todo
...
Minor code simplification (implemented TODO)
2021-05-05 19:31:52 +03:00
Maksim Kita
1a38b2ed9a
Merge pull request #23898 from ice1x/master
...
Add run options with default config path according to issues/23875
2021-05-05 18:41:02 +03:00
ice1x
577613b6ae
Merge pull request #2 from ice1x/feature/add-osx-build-run-item
...
Update build-osx.md
2021-05-05 19:57:47 +05:00
ice1x
d748560991
Update build-osx.md
2021-05-05 19:56:20 +05:00
ice1x
d6164d389d
Merge pull request #1 from ice1x/feature/add-osx-build-run-item
...
Add run options with default config path
2021-05-05 19:36:31 +05:00
ice1x
dc595f391e
Add run options with default config path
...
Add run options with default config path.
Checked on Catalina 10.15.7
2021-05-05 19:35:28 +05:00
Maksim Kita
6105a19357
Merge pull request #23869 from kirillikoff/kirillikoff-DOCSUP-8495
...
DOCSUP-8495: Documented http-max-uri-size
2021-05-05 15:27:42 +03:00
Alexey Milovidov
79beaae056
Shave off some lines of code
2021-05-05 15:01:01 +03:00
Alexey Milovidov
6473e956bb
Implement TODO
2021-05-05 14:58:17 +03:00
alexey-milovidov
542c940941
Merge pull request #23874 from filimonov/librdkafka161
...
Update librdkafka 1.6.0-RC3 to 1.6.1
2021-05-05 13:48:14 +03:00
alexey-milovidov
2e22cceffa
Merge pull request #23884 from azat/bash-completion
...
bash completion improvements
2021-05-05 13:43:44 +03:00
alexey-milovidov
bf8c28a17f
Merge pull request #23885 from azat/dist-broken-metrics
...
Add metrics for broken files during async distributed sends
2021-05-05 13:41:15 +03:00
alexey-milovidov
86e6ad17dc
Merge pull request #23893 from zifter/bugfix/fix-doc-link
...
Doc. Fix title link for send_crash_reports for en and ru
2021-05-05 13:39:21 +03:00
Alexey Milovidov
fd11d0a0ae
Merge branch 'master' of github.com:yandex/ClickHouse into remove-obsolete-code
2021-05-05 13:37:33 +03:00
Alexey Milovidov
75feb0c599
Fix clang-tidy
2021-05-05 13:37:14 +03:00
alexey-milovidov
3a5e95359a
Merge pull request #23883 from ClickHouse/delete-bad-test-in-memory-parts
...
@CurtizJ convinced me that this test has to be deleted
2021-05-05 13:27:57 +03:00
Oleg Strokachuk
04e3fa1834
Doc. Fix title link for send_crash_reports for en and ru
2021-05-05 11:33:38 +03:00
Alexey Milovidov
d585cfbe46
Addition to Remove unused obsolete code
2021-05-04 22:59:31 +03:00
Alexey Milovidov
c4723c0a4c
Remove unused obsolete code
2021-05-04 22:59:30 +03:00
alexey-milovidov
c607291042
Merge pull request #23877 from ClickHouse/pvs-studio-fixes-5
...
Fix some warnings by PVS-Studio
2021-05-04 22:57:19 +03:00
Azat Khuzhin
9c6e8e1462
Add BrokenDistributedFilesToInsert new metric
...
Number of files for asynchronous insertion into Distributed tables that
has been marked as broken. This metric will starts from 0 on start.
Number of files for every shard is summed.
2021-05-04 22:48:07 +03:00
Azat Khuzhin
74269882f7
Add broken_data_files/broken_data_compressed_bytes into distribution_queue
2021-05-04 22:48:07 +03:00
Azat Khuzhin
1639cc598d
bash-completion: add completion for --host
2021-05-04 22:23:08 +03:00
Azat Khuzhin
3e72d4186c
bash-completion: add completion for --stage
2021-05-04 22:23:08 +03:00
Azat Khuzhin
61e4c5af07
bash-completion: make some code more generic
2021-05-04 22:23:08 +03:00
Alexey Milovidov
af41344cf5
@CurtizJ convinced me that this test has to be deleted
2021-05-04 20:59:42 +03:00
Vladimir
164cad403c
Merge pull request #23879 from vdimir/fix-disks3-arcadia
...
Add Read/WriteBufferFromFileDecorator.cpp to ya.make
2021-05-04 16:12:07 +03:00
vdimir
657eda9288
Add Read/WriteBufferFromFileDecorator.cpp to ya.make
2021-05-04 16:07:56 +03:00
Tatiana Kirillova
cba158037e
Merge branch 'kirillikoff-DOCSUP-8495' of https://github.com/kirillikoff/ClickHouse into kirillikoff-DOCSUP-8495
2021-05-04 15:58:10 +03:00
Tatiana Kirillova
5bc025ecae
translation to ru
2021-05-04 15:54:13 +03:00
Alexey Milovidov
2b118f11b4
PVS-Studio
2021-05-04 15:14:55 +03:00
Alexey Milovidov
9cbdcc1ab5
PVS-Studio
2021-05-04 15:14:47 +03:00
Alexey Milovidov
eea47a65d2
PVS-Studio
2021-05-04 15:13:47 +03:00
kirillikoff
0e92cc06df
Update docs/en/operations/settings/settings.md
...
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
2021-05-04 15:09:15 +03:00
alexey-milovidov
4ebc0b79fc
Merge pull request #23868 from ClickHouse/fix-disks3-arcadia
...
Add DiskRestartProxy.cpp to ya.make
2021-05-04 14:57:18 +03:00
Maksim Kita
5fa3701540
Merge pull request #23873 from elevankoff/patch-1
...
Fix typo in the comment
2021-05-04 13:48:46 +03:00
Mikhail Filimonov
80065b08f8
Revert "avoid race in librdkafka"
...
This reverts commit bd8c3eb117
2021-05-04 10:06:33 +02:00
Mikhail Filimonov
ba7945367e
Update to librdkafka 1.6.1
2021-05-04 10:05:12 +02:00
Yegor Levankov
3c02a998c2
Fix typo in comment
2021-05-04 10:54:13 +03:00
Maksim Kita
ea7ea99512
Merge pull request #23856 from azat/dist-send-improve-logging
...
Add file paths into logs on failed distributed async sends
2021-05-03 22:18:14 +03:00
vdimir
465341eafd
Add DiskRestartProxy.cpp to ya.make
2021-05-03 20:50:17 +03:00
Tatiana Kirillova
c763a5c33f
max-uri-size
2021-05-03 20:16:44 +03:00
alexey-milovidov
1f23d95d81
Merge pull request #23855 from azat/replxx-bindings
...
replxx readline compatibility
2021-05-03 19:19:24 +03:00
alexey-milovidov
b868cabfa9
Update functions-for-nulls.md
2021-05-03 13:40:54 +03:00
