Commit Graph

24736 Commits

Author SHA1 Message Date
Azat Khuzhin
4e8370b0b0
Fix SimpleAggregateFunction for String longer MAX_SMALL_STRING_SIZE
SimpleAggregateFunction do not pass arena to the
add_function -> getAddressOfAddFunction(), hence next crash happens:
  (gdb) bt
  #0  DB::Arena::alloc (size=64, this=0x0) at ../dbms/src/Common/Arena.h:124
  #1  DB::SingleValueDataString::changeImpl (this=0x7f97424a27d8, value=..., arena=0x0) at ../dbms/src/AggregateFunctions/AggregateFunctionMinMaxAny.h:274
  #2  0x0000000005ea5319 in DB::AggregateFunctionNullUnary<true>::add (arena=<optimized out>, row_num=<optimized out>, columns=<optimized out>, place=<optimized out>, this=<optimized out>) at ../dbms/src/AggregateFunctions/AggregateFunctionNull.h:43
  #3  DB::IAggregateFunctionHelper<DB::AggregateFunctionNullUnary<true> >::addFree (that=<optimized out>, place=<optimized out>, columns=<optimized out>, row_num=<optimized out>, arena=<optimized out>) at ../dbms/src/AggregateFunctions/IAggregateFunction.h:131
  #4  0x000000000679772f in DB::AggregatingSortedBlockInputStream::addRow (this=this@entry=0x7f982de19c00, cursor=...) at ../dbms/src/Common/AlignedBuffer.h:31
  #5  0x0000000006797faa in DB::AggregatingSortedBlockInputStream::merge (this=this@entry=0x7f982de19c00, merged_columns=..., queue=...) at ../dbms/src/DataStreams/AggregatingSortedBlockInputStream.cpp:140
  #6  0x0000000006798979 in DB::AggregatingSortedBlockInputStream::readImpl (this=0x7f982de19c00) at ../dbms/src/DataStreams/AggregatingSortedBlockInputStream.cpp:78
  #7  0x000000000622db55 in DB::IBlockInputStream::read (this=0x7f982de19c00) at ../dbms/src/DataStreams/IBlockInputStream.cpp:56
  #8  0x0000000006613bee in DB::MergeTreeDataMergerMutator::mergePartsToTemporaryPart (this=this@entry=0x7f97ec65e1a0, future_part=..., merge_entry=..., time_of_merge=<optimized out>, disk_reservation=<optimized out>, deduplicate=<optimized out>) at /usr/include/c++/8/bits/shared_ptr_base.h:1018
  #9  0x000000000658f7a4 in DB::StorageReplicatedMergeTree::tryExecuteMerge (this=0x7f97ec65b810, entry=...) at /usr/include/c++/8/bits/unique_ptr.h:342
  #10 0x00000000065940ab in DB::StorageReplicatedMergeTree::executeLogEntry (this=0x7f97ec65b810, entry=...) at ../dbms/src/Storages/StorageReplicatedMergeTree.cpp:910
  <snip>

  (gdb) f 1
  (gdb) p MAX_SMALL_STRING_SIZE
  $1 = 48
  (gdb) p capacity
  $2 = 64
  (gdb) p value
  $3 = {data = 0x7f97242fcbd0 "HHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH", size = 61}

v2: avoid leaking of allocated by Arena memory on the intermediate step

Fixes: 8f8d2c048e ("Merge pull request #4629 from bgranvea/simple_aggregate_function")
2019-05-19 03:32:55 +03:00
stavrolia
7b34c1c418 Merge branch 'master' of https://github.com/yandex/ClickHouse 2019-05-16 16:43:40 +03:00
stavrolia
ff4d989918 Fixed help instruction of usage 2019-05-16 13:52:41 +03:00
alexey-milovidov
dcc88f3a0c
Merge pull request #5284 from 4ertus2/bugs
fix decimal quoted csv input
2019-05-16 00:07:23 +03:00
alexey-milovidov
34c7886b52
Merge pull request #5288 from yandex/perf_test_fixes
Fix incorrect performance tests
2019-05-15 23:55:57 +03:00
proller
51ca4cbaa4
Build fixes (#5278) 2019-05-15 20:19:39 +03:00
alesapin
d477cc0df4 Fix incorrect performance tests 2019-05-15 19:44:25 +03:00
proller
0dd29e7c5b clang-format of AggregateFunctions/AggregateFunctionTSGroupSum.* 2019-05-15 19:27:44 +03:00
Yangkuan Liu
0760a3436f add AggregateFunction TSgroup{Rate}Sum (#4542) 2019-05-15 19:16:25 +03:00
Ivan
1ea9e3019d
Freeze the Kafka buffer after first empty response (#5283)
* Check inside inferior streams for cancellation while reading.
* Stop reading from Kafka buffer after first empty read.
2019-05-15 19:11:50 +03:00
chertus
720f8667e4 fix decimal quoted csv input 2019-05-15 16:51:17 +03:00
Artem Zuikov
98359a6a09
Merge pull request #5267 from 4ertus2/row_ref_list
RowRefList improvements
2019-05-15 13:38:48 +03:00
proller
0da7463a6b
CLICKHOUSE-4519 Support dictionaries in clickhouse-copier (#5270) 2019-05-15 12:16:09 +03:00
Ivan Blinkov
150c8466d7
fix few typos 2019-05-15 12:04:24 +03:00
proller
8814e0cda5
server: informative listen error messages (#5268) 2019-05-14 22:55:10 +03:00
proller
7cb8d46338
Fix build (move code from AggregateFunctionMLMethod.h) (#5266) 2019-05-14 22:52:29 +03:00
alexey-milovidov
2cbbbba7c8
Merge pull request #5269 from vitlibar/fix-postfix-increment-in-settings
Fix postfix increment operator in Settings::iterator
2019-05-14 22:24:03 +03:00
alexey-milovidov
3ef1b21ab9
Merge pull request #5253 from abyss7/issue-2551
Link rdkafka with bundled SASL
2019-05-14 22:15:46 +03:00
alexey-milovidov
88b34999fe
Merge pull request #5247 from zhang2014/fix/rename_data_race
fix data race in rename query
2019-05-14 22:07:52 +03:00
Vitaly Baranov
9620e2e223
Merge pull request #5003 from Enmk/geohash_support
Implementation of geohashEncode and geohashDecode functions;
2019-05-14 20:01:22 +03:00
Ivan
4a5832b18a
Check the time limit every (flush_interval / poll_timeout) number of rows from Kafka (#5249) 2019-05-14 18:52:03 +03:00
Vitaly Baranov
4674ac2091 Fix postfix increment operator of Settings::iterator 2019-05-14 18:46:01 +03:00
chertus
b166791176 batched version of RowRefList 2019-05-14 17:40:43 +03:00
chertus
6200d20dc2 RowRefList refactoring 2019-05-14 17:39:03 +03:00
Artem Zuikov
aba710a70e
Merge pull request #5260 from 4ertus2/joins
Fix perf regression: do not add right join key to result if possible
2019-05-14 15:33:54 +03:00
proller
cc3de4115f
Build fixes (#5261) 2019-05-14 12:58:33 +03:00
chertus
ba202c2b06 fix whitespaces 2019-05-14 12:47:21 +03:00
Nikolai Kochetov
6165be54fc
Merge pull request #4943 from Quid37/master
Regression methods
2019-05-14 11:47:33 +03:00
alexey-milovidov
bfd255cc9f
Merge pull request #5255 from yandex/fix_perf_flaps
Fix bunch of flapping perf tests. Improve average speed calculation
2019-05-13 23:22:28 +03:00
Ivan Blinkov
e8cbf3d09e
Merge pull request #5096 from BayoNet/DOCAPI-3822-zookeeper-secure-connection
DOCAPI-3822: ZooKeeper settings. Oracle ODBC issue.
2019-05-13 22:14:25 +03:00
chertus
20e7de7cce fix perf regression: do not add right join key to result if possible 2019-05-13 21:58:15 +03:00
Alexander Kozhikhov
332a8a97ab style 2019-05-13 20:08:58 +03:00
Alexander Kozhikhov
003a0fbadf conflict fix 2019-05-13 17:43:47 +03:00
alesapin
5aec6dd011 Fix banch of flapping perf tests. Improve average speed calculation 2019-05-13 17:09:11 +03:00
Alexander Kozhikhov
9b4f322fd8 Merge branch 'master' of https://github.com/yandex/ClickHouse 2019-05-13 16:50:56 +03:00
Alexander Kozhikhov
79010b7c3c some review fixes 2019-05-13 16:49:53 +03:00
Ivan Blinkov
9498ba9679
Merge pull request #5252 from yandex/blinkov-patch-3
Update quick start on website front page
2019-05-13 14:03:04 +03:00
Ivan Blinkov
bf05218c9c
Update quick start on website front page
...as skipping parts that were marked as optional indeed fails the rest of it.
2019-05-13 14:02:17 +03:00
Ivan Blinkov
d1ad2a9bb5
Merge pull request #5251 from yandex/blinkov-patch-3
Add San Francisco meetup link
2019-05-13 13:57:03 +03:00
Ivan Blinkov
9aa4e8d168
Add San Francisco meetup link 2019-05-13 13:56:33 +03:00
Ivan Blinkov
06dd372a08
Add San Francisco meetup link 2019-05-13 13:54:39 +03:00
Ivan Lezhankin
67cf1bc48c Link rdkafka with bundled SASL
also enable SASL SCRAM support in the code.
2019-05-13 13:41:03 +03:00
alesapin
a8e8a37c04 Update pvs-studio version to beta 2019-05-13 13:06:51 +03:00
Ivan Blinkov
a4bbba9d95
Merge pull request #5248 from yandex/blinkov-patch-3
Remove past Meetup link
2019-05-13 11:52:04 +03:00
Ivan Blinkov
b96ec83c2a
Remove past Meetup link 2019-05-13 11:51:24 +03:00
Ivan Blinkov
2c43795f0e
Merge pull request #5210 from Enmk/IPv4_IPv6_domains_docs
IPv4 and IPv6 domain docs.
2019-05-13 10:58:59 +03:00
zhang2014
2206ba464f fix data race in rename query 2019-05-13 15:54:38 +08:00
alexey-milovidov
9ce2dd8803
Merge pull request #5238 from janplus/if-nullable-bug
Fix if, multiIf's nullable bug.
2019-05-12 11:47:37 +03:00
alexey-milovidov
f7343ecb6f
Merge pull request #4639 from IvanKush/feat/parallel-alter-modify
feat alter:  parallelize processing of parts in alter modify
2019-05-12 00:39:46 +03:00
ivan-kush
5f6ab5eb10 tsan? 2019-05-11 21:30:24 +03:00