Commit Graph

49452 Commits

Author SHA1 Message Date
alexey-milovidov
f3655fb9eb
Merge pull request #15945 from azat/tests-lv-fix-flackiness
Fix flackiness of LIVE VIEW tests by increasing timeout for HTTPConnection
2020-10-14 14:13:40 +03:00
tavplubix
f7991f4073
Merge pull request #15961 from ClickHouse/revert-14295-write_structure_of_table_functions
Revert "Write structure of table functions to metadata"
2020-10-14 13:59:53 +03:00
tavplubix
c65d1e5c70
Revert "Write structure of table functions to metadata" 2020-10-14 13:59:29 +03:00
tavplubix
6a0249bf91
Merge pull request #15954 from zhang2014/fix/ISSUES-15265
ISSUES-15265 try fix crash when create database failure
2020-10-14 13:49:20 +03:00
alesapin
d51deaeecf Fix flaky 01509_parallel_quorum_insert_no_replicas 2020-10-14 10:49:50 +03:00
hexiaoting
2c72cdef44 Fix error for offset_fetch without only/with ties 2020-10-14 15:05:02 +08:00
zhang2014
a00bcbb8ba ISSUES-15265 try fix crash when create failure 2020-10-14 13:26:28 +08:00
alexey-milovidov
4a6adac5db
Merge pull request #15879 from azat/client-optimize-history-save-v2
Avoid creating separate replxx instance
2020-10-14 02:05:17 +03:00
Azat Khuzhin
628e2b472c Fix flackiness of LIVE VIEW tests by increasing timeout for HTTPConnection
Trace from [1]:

    2020-10-13 01:37:06 00966_live_view_watch_events_http:                                      [ FAIL ] - return code 1
    2020-10-13 01:37:06 Exception in thread Thread-2:
    2020-10-13 01:37:06 Traceback (most recent call last):
    2020-10-13 01:37:06   File "/usr/lib/python3.7/threading.py", line 926, in _bootstrap_inner
    2020-10-13 01:37:06     self.run()
    2020-10-13 01:37:06   File "/usr/lib/python3.7/threading.py", line 870, in run
    2020-10-13 01:37:06     self._target(*self._args, **self._kwargs)
    2020-10-13 01:37:06   File "/usr/share/clickhouse-test/queries/0_stateless/helpers/httpexpect.py", line 48, in reader
    2020-10-13 01:37:06     data = response.read(1).decode()
    2020-10-13 01:37:06   File "/usr/lib/python3.7/http/client.py", line 457, in read
    2020-10-13 01:37:06     n = self.readinto(b)
    2020-10-13 01:37:06   File "/usr/lib/python3.7/http/client.py", line 491, in readinto
    2020-10-13 01:37:06     return self._readinto_chunked(b)
    2020-10-13 01:37:06   File "/usr/lib/python3.7/http/client.py", line 586, in _readinto_chunked
    2020-10-13 01:37:06     chunk_left = self._get_chunk_left()
    2020-10-13 01:37:06   File "/usr/lib/python3.7/http/client.py", line 554, in _get_chunk_left
    2020-10-13 01:37:06     chunk_left = self._read_next_chunk_size()
    2020-10-13 01:37:06   File "/usr/lib/python3.7/http/client.py", line 514, in _read_next_chunk_size
    2020-10-13 01:37:06     line = self.fp.readline(_MAXLINE + 1)
    2020-10-13 01:37:06   File "/usr/lib/python3.7/socket.py", line 589, in readinto
    2020-10-13 01:37:06     return self._sock.recv_into(b)
    2020-10-13 01:37:06 socket.timeout: timed out

  [1]: https://clickhouse-test-reports.s3.yandex.net/15879/f7bf94b5d361d0a54e85673c14e630cfdf8dbe01/functional_stateless_tests_(release,_polymorphic_parts_enabled)/test_run.txt.out.log
2020-10-14 01:21:51 +03:00
alexey-milovidov
56e7e6ed62
Merge pull request #15886 from zhang2014/fix/ISSUES-12513
ISSUES-12513 fix difference expressions with same alias when analyze queries again
2020-10-14 00:55:11 +03:00
alexey-milovidov
7d2f96ade9
Merge pull request #14508 from olgarev/revolg-DOCSUP-1675-Doc_the_cast_keep_nullable_setting
DOCSUP-1675 Docs for the cast_keep_nullable setting
2020-10-14 00:06:03 +03:00
alexey-milovidov
f60ccb4edf
Merge pull request #14295 from ClickHouse/write_structure_of_table_functions
Write structure of table functions to metadata
2020-10-13 23:56:09 +03:00
alexey-milovidov
3744547e2c
Merge pull request #15845 from kitaisreal/setting-date-time-output-format
Added OutputFormat setting date_time_output_format
2020-10-13 23:48:36 +03:00
alexey-milovidov
fc83bd1088
Merge branch 'master' into setting-date-time-output-format 2020-10-13 23:48:27 +03:00
alexey-milovidov
173ee78122
Merge pull request #15876 from azat/connections_with_failover_max_tries-endless-loop
Fix query hang with connections_with_failover_max_tries = 0 (endless loop)
2020-10-13 23:47:34 +03:00
Alexey Milovidov
dbd4366aa4 Merge branch 'master' of github.com:filipecaixeta/ClickHouse into filipecaixeta-master 2020-10-13 23:45:43 +03:00
Alexey Milovidov
da4e4c5cdb Merge branch 'master' into filipecaixeta-master 2020-10-13 23:44:48 +03:00
alexey-milovidov
c87cc24d65
Merge pull request #15937 from ClickHouse/fix-bad-docs
Fix broken links in docs
2020-10-13 23:05:39 +03:00
alexey-milovidov
b4701c9488
Update adopters.md 2020-10-13 23:02:51 +03:00
Alexey Milovidov
db4db42b65 Fix broken links in docs 2020-10-13 20:23:29 +03:00
alexey-milovidov
c30bcd79e3
Fix trash #15935 2020-10-13 19:17:04 +03:00
damozhaeva
e1fcbe749c
Edit and translate to Russian. (#15462)
Co-authored-by: Daria Mozhaeva <dmozhaeva@yandex-team.ru>
2020-10-13 18:29:28 +03:00
alexey-milovidov
37c2a57202
Update WriteHelpers.h 2020-10-13 15:23:50 +03:00
alesapin
f64344f7c5
Merge pull request #15890 from ClickHouse/fix_test_many_parallel_quorum_inserts
Fix test 01509_check_many_parallel_quorum_inserts
2020-10-13 14:29:55 +03:00
Maksim Kita
adaae8a12c Added OutputFormat setting date_time_output_format 2020-10-13 13:59:43 +03:00
Vitaly Baranov
13896cf4c9
Merge pull request #15875 from vitlibar/rbac-fix-deadlock
Fix possible deadlocks in RBAC
2020-10-13 12:58:57 +03:00
Nikita Mikhaylov
835c480056
Merge pull request #15858 from ClickHouse/fix_alter_default_validation
Fix alter default validation
2020-10-13 12:47:18 +03:00
tavplubix
6c1d59cd49
Merge pull request #15743 from azat/Atomic-DROP-TABLE-hang-fix
Fix DROP TABLE hangs with Atomic engine
2020-10-13 12:40:36 +03:00
alesapin
700b6b8a38 Fix test 01509_check_many_parallel_quorum_inserts 2020-10-13 10:14:31 +03:00
zhang2014
14ef354a16 ISSUES-12513 try fix test failure 2020-10-13 14:52:05 +08:00
alesapin
321a7ae6bf
Merge pull request #15852 from ClickHouse/fix_reverse_processor
Fix block structure mismatch after ALTER
2020-10-13 09:49:26 +03:00
zhang2014
72f8153f01 ISSUES-12513 add stateless test 2020-10-13 13:48:16 +08:00
zhang2014
d79d0127ad ISSUES-12513 try fix difference expressions with same alias 2020-10-13 13:30:56 +08:00
hexiaoting
dea965832a Fix error for previous offset test 2020-10-13 11:32:43 +08:00
Amos Bird
1c3fe943e0
Fix DelayedSource 2020-10-13 10:18:30 +08:00
Amos Bird
ca7a5ccd0d
More resize 2020-10-13 09:56:35 +08:00
Vitaly Baranov
6a58bb5c23 Enable rbac tests with thread sanitizer. 2020-10-13 01:03:51 +03:00
Vitaly Baranov
eddd26cf3a Fix deadlock in InterpreterGrantQuery. 2020-10-13 01:03:47 +03:00
Azat Khuzhin
f7bf94b5d3 Check return value of the history_save/history_load
The coding style is different and this is the intention, to make look
like surrounding code.
2020-10-12 23:57:00 +03:00
Azat Khuzhin
f211d33841 Avoid creating separate replxx instance
This replxx object is pretty heavy and in debug build may slow down [1]
(although I cannot confirm 0.5s delay for each query in debug build) the
client and besides it is not required since ClickHouse-Extras/replxx#10,
which changes the behaviour of history_save(), and now it will not
update current session anymore, only save the history to the disk.

  [1]: https://github.com/ClickHouse/ClickHouse/pull/13086#issuecomment-667719026
2020-10-12 23:56:29 +03:00
alexey-milovidov
4798234002
Merge pull request #15843 from ClickHouse/check-executable-files
Check for executable bit on non-executable files
2020-10-12 23:54:00 +03:00
Azat Khuzhin
9613144fa8 Move 01521_connections_with_failover_max_tries_0 to 01521_distributed_query_hang
This will fix style check error:

    /place/sandbox-data/tasks/4/8/795063184/ClickHouse/tests/queries/0_stateless/01521_connections_with_failover_max_tries_0.reference
    /place/sandbox-data/tasks/4/8/795063184/ClickHouse/tests/queries/0_stateless/01521_connections_with_failover_max_tries_0.sql
    Tests should not be named with "fail" in their names. It makes looking at the results less convenient when you search for "fail" substring in browser.
2020-10-12 23:30:37 +03:00
alexey-milovidov
03f8d59bfb
Merge pull request #15844 from azat/WEVERYTHING-exclude-zero-as-null-pointer-constant
Exclude zero-as-null-pointer-constant for libstdc++ under WEVERYTHING
2020-10-12 23:10:41 +03:00
Azat Khuzhin
2947eff878 Fix query hang with connections_with_failover_max_tries = 0 (endless loop) 2020-10-12 22:07:26 +03:00
Azat Khuzhin
8fbf50d672 Add 01509_dictionary_preallocate into arcadia_skip_list
An attempt to fix "Yandex synchronization check (only for Yandex employees)"
2020-10-12 21:50:56 +03:00
Azat Khuzhin
bba44d0f0e Add IF EXISTS for removing inner table of the materialized view
Instead of playing with has_inner_table flag, which looks a bit icky.
2020-10-12 21:46:07 +03:00
Azat Khuzhin
d16adddb41 Fix drop of materialized view with inner table in Atomic database
Materialized view drop the inner table (if any) drop the drop() method,
and this will lead to essure recursive drop() from the drop worker
thread, which will hang:

    3  std::__1::condition_variable::wait<> ()
    4  DB::DatabaseCatalog::waitTableFinallyDropped (this=0x7ffff7831500, uuid=...) at ../src/Interpreters/DatabaseCatalog.cpp:828
    5  DB::InterpreterDropQuery::executeToTable (this=this@entry=0x7fff16ff88a0, table_id_=..., query=...) at ../src/Interpreters/InterpreterDropQuery.cpp:135
    6  DB::InterpreterDropQuery::execute (this=this@entry=0x7fff16ff88a0) at ../contrib/libcxx/include/string:1474
    7  DB::executeDropQuery (kind=kind@entry=DB::ASTDropQuery::Drop, global_context=..., target_table_id=...) at ../src/Storages/StorageMaterializedView.cpp:156
    8  DB::StorageMaterializedView::drop (this=0x7ffefc348f40) at ../src/Storages/StorageMaterializedView.cpp:169
    9  DB::DatabaseCatalog::dropTableFinally (this=this@entry=0x7ffff7831500, table=...) at ../src/Interpreters/DatabaseCatalog.cpp:775
    10 DB::DatabaseCatalog::dropTableDataTask (this=0x7ffff7831500) at ../src/Interpreters/DatabaseCatalog.cpp:745

Fix this by dropping the inner table just before scheduling job the the
drop worker thread.
2020-10-12 21:46:07 +03:00
Azat Khuzhin
91787e6a7e Add a test with recursive DROP TABLE (mv w/o explicit inner table) 2020-10-12 21:46:07 +03:00
Azat Khuzhin
ea12ca42c7 Add a stress test for DROP TABLE 2020-10-12 21:46:07 +03:00
Vitaly Baranov
b8019f2bc7 Fix deadlocks in RoleCache. 2020-10-12 21:40:05 +03:00