Commit Graph

12931 Commits

Author SHA1 Message Date
Maksim Kita
8b5a049ca0
Merge pull request #23635 from kitaisreal/aggregate-functions-remove-unused-code
Aggregator remove unused code
2021-04-27 00:52:34 +03:00
Maksim Kita
f37599112a Added EXCHANGE DICTIONARIES query support 2021-04-26 23:36:15 +03:00
Maksim Kita
71bccfdea1 Fixed integration test 2021-04-26 23:35:56 +03:00
Alexey
283442e249 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into alexey-sm-DOCSUP-6702-document-timezoneOffset 2021-04-26 19:43:12 +00:00
Alexey
beca754aff Alias timeZoneOffset added to source code 2021-04-26 19:17:23 +00:00
Nikita Mikhaylov
223c6b4ac5 better 2021-04-26 21:26:55 +03:00
Nikita Mikhaylov
7dc0f27c88 done 2021-04-26 21:07:30 +03:00
Nikita Mikhaylov
9a70136bcf better 2021-04-26 18:50:40 +03:00
Maksim Kita
c93666e0de Fixed code review issues 2021-04-26 13:52:41 +03:00
Maksim Kita
375b77dbcb Fixed integration tests 2021-04-26 13:52:41 +03:00
Maksim Kita
cad6b5a590 Fixed tests 2021-04-26 13:52:41 +03:00
Maksim Kita
e69581d72f Fixed tests 2021-04-26 13:52:41 +03:00
Maksim Kita
43680d8ced Fixed tests 2021-04-26 13:52:41 +03:00
Maksim Kita
561b045991 Fixed tests 2021-04-26 13:52:41 +03:00
Maksim Kita
fa39c30b4b Fixed tests 2021-04-26 13:52:41 +03:00
Maksim Kita
64f49a981b Fixed tests 2021-04-26 13:52:41 +03:00
Maksim Kita
2e3e90b25b Fixed tests 2021-04-26 13:52:41 +03:00
Maksim Kita
6ba83eccd3 Added support for DETACH DICTIONARY PERMANENTLY 2021-04-26 13:52:41 +03:00
Maksim Kita
e5079c87db Added test 2021-04-26 13:52:41 +03:00
Maksim Kita
3cb4d1bdcb Fixed style check 2021-04-26 13:52:41 +03:00
Maksim Kita
a9917a6540 Refactored StorageDictionary 2021-04-26 13:52:41 +03:00
Maksim Kita
5bb263f535 Fixed tests 2021-04-26 13:44:59 +03:00
Alexander Kuzmenkov
fed35445d9
Merge pull request #23546 from ClickHouse/aku/window-distributed
fix window functions for Distributed tables
2021-04-26 12:34:46 +03:00
Nikolai Kochetov
092ff0faeb
Merge pull request #23524 from kssenii/insert-union-select
Allow to insert default instead of Null in insert-select / insert-select-union-all
2021-04-26 12:25:49 +03:00
tavplubix
1d5d69f651
Merge pull request #23637 from ClickHouse/fix-build-with-AMQP
Merging #22984
2021-04-26 11:33:52 +03:00
Kruglov Pavel
cb0bd3df5f
Merge pull request #21888 from rf/rf/deltasum-with-timestamp
add `deltaSumTimestamp` + docs, tests & minor improvement to `deltaSum`
2021-04-26 11:26:50 +03:00
tavplubix
81726de8fe
Merge pull request #23366 from amosbird/pid
Fix invalid virtual column expr
2021-04-26 11:10:24 +03:00
Vladimir
3c48b88929
Merge pull request #22208 from azat/s3-writer 2021-04-26 10:31:45 +03:00
Vladimir Chebotarev
523f8f1743 Added clarification. 2021-04-26 10:21:06 +03:00
Vladimir Chebotarev
1febe4071e Style fix. 2021-04-26 10:21:06 +03:00
Vladimir Chebotarev
a5ed193d93 Added singletons to quantilesTDigest. 2021-04-26 10:21:06 +03:00
Vladimir Chebotarev
3911ef40e1 Added singletons to quantileTDigest. 2021-04-26 10:21:05 +03:00
Vladimir Chebotarev
7cac69c9a2 Removed perfect aggregation in quantileTDigest. 2021-04-26 10:21:05 +03:00
tavplubix
fc2e2848bf
Merge pull request #23413 from TCeason/modify_MaterializeMySQL_var_check
modify MaterializeMySQL check MySQL var logical
2021-04-26 09:52:59 +03:00
Maksim Kita
6e3efee28c Updated HashMap functions 2021-04-26 01:36:47 +03:00
Maksim Kita
cac4a85286 Aggregator remove unused code 2021-04-26 01:17:24 +03:00
Azat Khuzhin
a4036a8199 Correctly stop ParallelFormattingOutputFormat from StorageS3BlockOutputStream 2021-04-25 12:49:57 +03:00
Azat Khuzhin
18575c4433 Avoid flushing of BlockOutputStream from destructor
That may lead to uncaught exception [1].

  [1]: https://github.com/ClickHouse/ClickHouse/pull/21624#issuecomment-808066747

v0: New method BlockOutputStream::finalize() -- bad (forgot some places
    and superfluous)
v2: Flush BlockOutputStream in QueryStatus::releaseQueryStreams()
    Safer query termination (report some uncaugh errors to user)
v3: Flush BlockOutputStream from TCPHandler only
    Other places uses different executeQuery() implementation
v4: Do not call writeSuffix() twice
2021-04-25 12:49:44 +03:00
Azat Khuzhin
6ebe4e7dbb Do not silently catch errors for writing to S3 2021-04-25 12:47:30 +03:00
Azat Khuzhin
7a8da84eee Respect lock_acquire_timeout_for_background_operations for OPTIMIZE 2021-04-25 10:12:15 +03:00
alexey-milovidov
3cf18d8a5f
Merge pull request #23610 from ClickHouse/bad-like
Fix error in LIKE (found by SQLancer)
2021-04-25 08:01:07 +03:00
alexey-milovidov
6191f30892
Merge pull request #23595 from azat/fuzzer-tupleElement-formatting
Fix inconsistent formatting for tupleElement (for fuzzer)
2021-04-25 04:03:39 +03:00
Alexey Milovidov
263378bb20 Fix error in LIKE (found by SQLancer) 2021-04-25 03:58:44 +03:00
alexey-milovidov
1ffa63b20a
Merge pull request #23598 from ClickHouse/paths-with-whitespaces
Somewhat better handling of paths in CMake (incomplete)
2021-04-25 01:58:28 +03:00
alexey-milovidov
d13d543811
Merge pull request #23600 from ClickHouse/reproducible-build-2
Avoid possible build dependency on locale and filesystem order
2021-04-25 01:55:28 +03:00
Azat Khuzhin
a5a8ecfe42 Fix inconsistent formatting for tupleElement (for fuzzer)
fuzzer sometimes [1] may inserts tupleElement() created from ASTLiteral:

    Function_tupleElement, 0xx
    -ExpressionList_, 0xx
    --Literal_Int64_255, 0xx
    --Literal_Int64_100, 0xx

And in this case it will be printed as "255.100", which
later will be parsed as float, and formatting will be
inconsistent.

So instead of printing it as regular tuple,
let's print it as ExpressionList instead (i.e. with ", " delimiter).

Simple reproducer:

    void ast()
    {
        auto arg1 = std::make_shared<ASTLiteral>(Field(255));
        auto arg2 = std::make_shared<ASTLiteral>(Field(100));

        auto func = makeASTFunction("tupleElement", arg1, arg2);

        auto ast = func;
        std::cerr << ast->formatForErrorMessage() << std::endl;
        std::cerr << ast->dumpTree() << std::endl;
    }

  [1]: https://clickhouse-test-reports.s3.yandex.net/23517/f1187aeb69109c88f0be978b8083080c7a843820/fuzzer_debug/report.html#fail1
2021-04-25 00:30:17 +03:00
Alexey Milovidov
2d3623b011 Remove build dependency on CMAKE_SYSTEM_NAME 2021-04-24 23:05:08 +03:00
Alexey Milovidov
3705dbfabc Avoid possible build dependency on locale and filesystem order 2021-04-24 23:01:07 +03:00
Alexey Milovidov
6f05c447ad Remove old trash 2021-04-24 22:54:44 +03:00
Alexey Milovidov
4ff812db7f Maybe better support for paths with whitespaces 2021-04-24 22:47:52 +03:00
alexey-milovidov
280c0666a5
Merge pull request #23559 from ClickHouse/reproducible-build
Reproducible build
2021-04-24 21:26:31 +03:00
alexey-milovidov
cae5260817
Update KeyCondition.cpp 2021-04-24 05:34:35 +03:00
alexey-milovidov
20e897bc5a
Merge pull request #23301 from ClickHouse/fix_race_in_deduplication
Deduplication: check block version on removal
2021-04-24 04:59:00 +03:00
alexey-milovidov
bcede10919
Merge pull request #23312 from vdimir/issue-23002
Correct sample_block in HashJoin for dict join with join_algorithm
2021-04-24 04:40:43 +03:00
alexey-milovidov
2cfc2c8825
Merge pull request #23397 from CurtizJ/better-move-to-prewhere
Allow to move more conditions to PREWHERE
2021-04-24 04:39:33 +03:00
mergify[bot]
a5da512e39
Merge branch 'master' into pid 2021-04-24 00:37:39 +00:00
alexey-milovidov
c66e715f49
Merge pull request #23433 from ClickHouse/tavplubix-patch-1
Fix `Cannot unlink file` in `dropIfEmpty()` with multidisk confuguration
2021-04-24 03:34:06 +03:00
alexey-milovidov
cd1f14ba61
Update MergeTreeData.cpp 2021-04-24 03:33:56 +03:00
alexey-milovidov
41ed8aab59
Merge pull request #23459 from CurtizJ/fix-replacing
Fix corner cases in vertical merges with ReplacingMergeTree
2021-04-24 03:30:44 +03:00
alexey-milovidov
ca230224cf
Merge pull request #23549 from vdimir/issue-17718
Remove clashed columns from totals for StorageJoin
2021-04-24 03:19:00 +03:00
Alexey Milovidov
4648782a05 Remove build date from system.build_options 2021-04-24 02:10:32 +03:00
kssenii
3a9b11e141 Add check for columns sizes match 2021-04-23 19:09:09 +00:00
kssenii
d032651aba Try fix 2021-04-23 17:29:22 +00:00
Alexander Kuzmenkov
9f50b1855f
Merge pull request #23520 from ClickHouse/aku/pvs
fix pvs warnings
2021-04-23 18:55:48 +03:00
Russ Frank
bc8581a4f0 fix style 2021-04-23 11:51:40 -04:00
Alexander Kuzmenkov
ab75f86ee9 add a comment 2021-04-23 18:45:45 +03:00
Alexander Kuzmenkov
6982ab5324 fix extra distinct 2021-04-23 15:44:46 +03:00
kssenii
7c3b074891 Better 2021-04-23 12:40:34 +00:00
vdimir
9460989721
Remove clashed columns from totals for StorageJoin 2021-04-23 15:37:05 +03:00
kssenii
8f34199538 Fixes 2021-04-23 12:36:40 +00:00
Alexander Kuzmenkov
9d95ac3d66 remove debug 2021-04-23 14:00:17 +03:00
Alexander Kuzmenkov
54ad086753 fix for distributed 2021-04-23 13:59:21 +03:00
kssenii
54a7a6ef0d Allow null to default convertion only if column has default 2021-04-23 09:55:57 +00:00
Alexander Kuzmenkov
1fe3fd864e Merge remote-tracking branch 'origin/master' into HEAD 2021-04-23 10:41:35 +03:00
Alexander Kuzmenkov
ce0a58f86f ignore empty input chunks generated by joins 2021-04-23 10:37:47 +03:00
Alexander Kuzmenkov
7ea5bd4a3f Merge remote-tracking branch 'origin/master' into HEAD 2021-04-23 09:26:43 +03:00
Kseniia Sumarokova
566db34cca
Merge pull request #23452 from kssenii/rabbitmq-allow-multiple-hosts
Allow rabbitmq vhost in table settings
2021-04-23 01:29:55 +03:00
kssenii
459612c895 Use a separate setting 2021-04-22 22:14:14 +00:00
kssenii
3176c24a8a Add test 2021-04-22 21:46:49 +00:00
kssenii
28c4436246 Better 2021-04-22 21:30:31 +00:00
Maksim Kita
2b822d896d
Merge pull request #23501 from kitaisreal/join-to-subqueries-columns-matcher-fix
JoinToSubqueriesVisitor ASTColumnsMatcher fix
2021-04-23 00:24:53 +03:00
Maksim Kita
f27002b1be
Merge pull request #23483 from hexiaoting/dev_alter_bugfix
Fix bug when modify column without type
2021-04-23 00:24:36 +03:00
Russ Frank
2e56bc2599 dont only add sum if edge difference is >0 2021-04-22 16:43:41 -04:00
Russ Frank
ce31a6e830 remove trailing whitespace 2021-04-22 16:41:20 -04:00
Alexander Kuzmenkov
59eb220886 fix 2021-04-22 23:27:51 +03:00
Alexander Kuzmenkov
06ca44a378 fix pvs warnings 2021-04-22 22:54:58 +03:00
Russ Frank
de0155cf27 finish merge 2021-04-22 15:46:22 -04:00
Alexander Kuzmenkov
35459a0228
Update FormatFactory.cpp 2021-04-22 21:48:06 +03:00
kssenii
ac55183d2e Null as default for insert select / with union 2021-04-22 18:11:36 +00:00
Russ Frank
41546e0d4f Merge branch 'master' of github.com:ClickHouse/ClickHouse into rf/deltasum-with-timestamp 2021-04-22 11:23:24 -04:00
Russ Frank
1041bce10f add allocates in arena method 2021-04-22 11:22:21 -04:00
Maksim Kita
7357c35197 Fixed code review issues 2021-04-22 17:19:47 +03:00
Maksim Kita
8fde34fc52 Updated tests 2021-04-22 16:23:42 +03:00
kssenii
5857abc844 Fix clang tidy 2021-04-22 12:46:03 +00:00
kssenii
b37479ce29 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into globs-for-url 2021-04-22 11:42:47 +00:00
Maksim Kita
ceaf6d57b7
Merge pull request #23393 from ClickHouse/revert-17359
Revert argMin/Max for single Tuple argument.
2021-04-22 13:32:04 +03:00
Maksim Kita
86ffa9fcfa JoinToSubqueriesVisitor ASTColumnsMatcher fix 2021-04-22 13:14:35 +03:00
Kruglov Pavel
f125db243e
Merge pull request #23437 from rf/rf/deltasum-condition-fix
`deltaSum` aggregate function counter reset bugfix & test
2021-04-22 10:37:41 +03:00
kssenii
06730743e6 Fix clang tidy 2021-04-22 07:37:20 +00:00
mergify[bot]
29b605b4ea
Merge branch 'master' into rabbitmq-allow-multiple-hosts 2021-04-22 07:32:43 +00:00
mergify[bot]
71bca99bbf
Merge branch 'master' into explain-output 2021-04-22 07:02:47 +00:00
hexiaoting
d24946f475 Fix bug when modify column without type 2021-04-22 14:48:57 +08:00
alexey-milovidov
3df3acc970
Merge pull request #23458 from kitaisreal/system-dictionaries-virtual-key-column
System dictionaries virtual key column
2021-04-22 08:42:15 +03:00
alexey-milovidov
8134c270a2
Merge pull request #23456 from kitaisreal/cast-to-array-from-empty-array
Cast to array from empty array
2021-04-22 08:41:35 +03:00
alexey-milovidov
1fcf198cec
Merge pull request #23415 from godliness/fix-kafka-with-arrow
Fix kafka storage does not work with arrow and arrowstream format messages
2021-04-22 04:59:31 +03:00
Anton Popov
3548e31afd fix corner cases in vertical merges with ReplacingMergeTree 2021-04-22 01:27:18 +03:00
Maksim Kita
7168b3a04c Table system.dictionaries added virtual key column 2021-04-22 01:16:03 +03:00
Maksim Kita
ddcffcb723 Fixed tests 2021-04-22 00:19:01 +03:00
kssenii
bb6bc61f22 Fix checks 2021-04-21 19:53:38 +00:00
Russ Frank
53f6a8f9a0 Merge remote-tracking branch 'origin/master' into rf/deltasum-with-timestamp 2021-04-21 13:52:50 -04:00
Maksim Kita
631d870ae3 Cast to array from empty array 2021-04-21 20:29:49 +03:00
kssenii
473903b396 Fix typos check 2021-04-21 17:09:01 +00:00
kssenii
b0bdb6b323 Fix build 2021-04-21 16:17:45 +00:00
kssenii
2e6c753add Allow separate vhost for each table 2021-04-21 15:51:05 +00:00
kssenii
8453c60200 Better check 2021-04-21 14:54:52 +00:00
kssenii
c1151cea23 Add failover 2021-04-21 14:39:51 +00:00
Russ Frank
822fc9b110 deltasum counter reset bugfix & test 2021-04-21 09:52:53 -04:00
Nikita Mikhaylov
d4e8f9676b
Merge pull request #21304 from amosbird/indexhint
Resurrect indexHint function.
2021-04-21 16:14:43 +03:00
mergify[bot]
7da7279390
Merge branch 'master' into fix_create_drop_replica_race 2021-04-21 13:03:29 +00:00
alexey-milovidov
34b30d80d4
Update StorageReplicatedMergeTree.cpp 2021-04-21 16:01:54 +03:00
tavplubix
1a776b47a7
Update MergeTreeData.cpp 2021-04-21 15:34:42 +03:00
kssenii
4c4f765aba Globs for url table function 2021-04-21 12:32:57 +00:00
alexey-milovidov
20a5fed53e
Merge pull request #23392 from ClickHouse/fix-4854
Keep default timezone on DateTime operations if it was not provided explicitly #4854
2021-04-21 15:00:59 +03:00
alexey-milovidov
9c649932bc
Merge pull request #23375 from ClickHouse/fix-read-in-order-with-collation
Fix read in order optimization of COLLATE is present #22379
2021-04-21 15:00:02 +03:00
Chao Ma
713eb9486c Fix kafka storage does not work with arrow and arrowstream format messages 2021-04-21 19:44:09 +08:00
Pavel Kovalenko
37c637cc34 Minor fixes. 2021-04-21 13:34:07 +03:00
Pavel Kovalenko
2ab8013455 DiskRestartProxy improvements and tests. 2021-04-21 12:53:46 +03:00
Nikolai Kochetov
9e943f4fad Fix ya.make 2021-04-21 08:50:42 +03:00
Nikolai Kochetov
44112587d4
Merge pull request #23309 from ClickHouse/try-fix-crash-with-unknown-packet
Fix crash in case of unknown packet
2021-04-21 08:47:17 +03:00
Nikolai Kochetov
9ec6fd1943
Merge pull request #23359 from ClickHouse/try-fix-23029
Fix #23029
2021-04-21 08:46:21 +03:00
Amos Bird
096d76627e
Skip unavaiable shards when writing to distributed tables 2021-04-21 10:30:40 +08:00
Amos Bird
50f2e488bd
Fix invalid virtual column expr 2021-04-21 10:29:03 +08:00
TCeason
51fe9fc771 modify MaterializeMySQL check MySQL var logical
Supprot for MySQL 5.7.9: https://github.com/ClickHouse/ClickHouse/issues/4006#issuecomment-817622685
2021-04-21 10:16:04 +08:00
Anton Popov
a83a07246e allow to move more conditions to PREWHERE 2021-04-21 01:03:58 +03:00
Maksim Kita
02515ff0a4
Merge pull request #23191 from kitaisreal/use-local-shard-if-no-remote-connections
Updated QueryAliasVisitor to prefer alias for aliases like _subquery
2021-04-21 00:58:47 +03:00
Alexey Milovidov
054da0ea34 Revert #17359 2021-04-21 00:23:47 +03:00
Alexey Milovidov
502bc3575c Revert #17359 2021-04-21 00:22:29 +03:00
Alexey Milovidov
416efbacbb Keep default timezone on DateTime operations if it was not provided explicitly #4854 2021-04-21 00:08:06 +03:00
Pavel Kovalenko
9272237c7e Update DiskRestartProxy.cpp 2021-04-20 23:47:21 +03:00
Pavel Kovalenko
10cf881a08 Add SYSTEM RESTART DISK command. 2021-04-20 22:23:54 +03:00
Pavel Kovalenko
016a9c674b DiskRestartProxy refactoring. 2021-04-20 21:58:34 +03:00
Pavel Kovalenko
98f8cbbdb2 DiskRestartProxy refactoring. 2021-04-20 21:58:34 +03:00
Pavel Kovalenko
e8b4dd1e4b Introduce DiskRestartProxy. 2021-04-20 21:55:57 +03:00
alexey-milovidov
4c1022ac03
Merge pull request #23318 from kssenii/fix-hdfs-with-spaces
Fix hdfs reading from files with spaces
2021-04-20 21:48:41 +03:00
Alexey Milovidov
9bc0706d2f Fix read in order optimization of COLLATE is present #22379 2021-04-20 21:20:45 +03:00
tavplubix
70c89eeff6
Merge pull request #23200 from ClickHouse/fix_prewhere_in_materialize_mysql
Fix prewhere in MaterializeMySQL
2021-04-20 20:05:07 +03:00
tavplubix
738d8a757b
Merge pull request #23189 from ClickHouse/minor_fixes_in_attach_query
Minor fixes in ATTACH query
2021-04-20 20:04:26 +03:00
Nikita Mikhaylov
16e7715039
Merge pull request #23202 from nikitamikhaylov/with_names_use_header_bug
`CSVWithNames` with `input_format_with_names_use_header=0`
2021-04-20 20:00:57 +03:00
alexey-milovidov
632a5288fa
Merge pull request #23348 from azat/zero-streams
Fix LOGICAL_ERROR for max_distributed_connections=0
2021-04-20 19:48:21 +03:00
alexey-milovidov
cbbff1bc4b
Merge pull request #23319 from ClickHouse/mysql-insert-without-database
Allow to INSERT into remote MySQL storage with empty database #19281
2021-04-20 19:30:44 +03:00