Commit Graph

110721 Commits

Author SHA1 Message Date
Arthur Passos
52e7a09de7 Use two functions extractKeyValuePairs and extractKeyValuePairsWithEscaping instead of boolean parameter 2023-04-06 12:17:14 -03:00
Arthur Passos
671f4b100c minor renaming 2023-04-06 11:28:40 -03:00
Arthur Passos
46bf0572cb =default for extractkvp constructor 2023-04-05 16:42:50 -03:00
Arthur Passos
a1446764a9 update docs to reflect new boolean argument 2023-04-05 13:27:38 -03:00
Arthur Passos
3c3c38d689 Use boolean column as escaping support argument instead of ColumnString 2023-04-05 13:20:32 -03:00
Arthur Passos
b7c34e4356 more docs 2023-04-05 12:33:30 -03:00
Arthur Passos
ebd22e92ce more docs / comments 2023-04-05 11:53:13 -03:00
Arthur Passos
09d00e1a36 remove stale test file 2023-04-05 11:07:22 -03:00
Arthur Passos
6dec537b3c more docs 2023-04-05 10:34:39 -03:00
Arthur Passos
b8d3b8523b update docs 2023-04-05 10:27:42 -03:00
Arthur Passos
5437b7dafa fix clangtidy build 2023-04-05 08:15:49 -03:00
Arthur Passos
34be1893fd fix unit tests 2023-04-04 20:31:12 -03:00
Arthur Passos
474377c16f remove debug find functions and replace SearchSymbols assertion with an exception, check with upstream preferred way 2023-04-04 16:14:56 -03:00
Arthur Passos
10b821fa2e remove big input test as it's outdated 2023-04-04 15:44:14 -03:00
Arthur Passos
e656ab685c fix sse42 not defined build 2023-04-04 08:16:55 -03:00
Arthur Passos
22367f84e6 fix undefined mm_is_in_prepare 2023-04-03 18:26:30 -03:00
Arthur Passos
fa1fdf7573 style 2023-04-03 15:28:17 -03:00
Arthur Passos
c1bcfbc57d extract configuration comparisons into meaningful methods 2023-04-03 15:25:18 -03:00
Arthur Passos
607b0c8880 Use different string writers strategies for escaping and non escaping 2023-04-03 15:16:06 -03:00
Arthur Passos
c7c96bfeab refactor state handlers so writer comes from them 2023-04-03 14:19:15 -03:00
Arthur Passos
c80ba3d52e unit tests passing 2023-04-03 13:48:58 -03:00
Arthur Passos
aee9ccb27a validated output against main test case, performance is not the same as before, but still good 2023-04-03 12:45:29 -03:00
Arthur Passos
e52a2982e0 fixed another stringwriter bug, where multi-row input would break because of prev_commit_offset=0 2023-03-31 15:01:42 -03:00
Arthur Passos
0b7792f7b7 fix string writer ub, escape sequence parsing failure and make state machine fully functional (remove extra if statements) 2023-03-31 10:44:39 -03:00
Arthur Passos
c02f883df6
Merge pull request #2 from Enmk/parsey_key_value_function-refactoring
Parsey key value function refactoring
2023-03-30 10:50:36 -03:00
Vasily Nemkov
89ebe61de8 Implemented writing to ColumnString directly via StringWriter 2023-03-30 15:21:22 +02:00
Vasily Nemkov
31a8a7b863 Fixed unit-tests 2023-03-30 09:25:10 +02:00
Vasily Nemkov
4b7005b8b1 Changes discussed with Arthur 2023-03-30 09:24:41 +02:00
Vasily Nemkov
73430b8d57 Minor adjustments 2023-03-29 18:37:44 +02:00
Vasily Nemkov
afc6b66eb3 Fused KeyStateHandler and ValueState togther
Removed some unneeded files and moved code around.
2023-03-29 18:28:14 +02:00
Vasily Nemkov
0a039a9601 Minor optimization of copying data into key 2023-03-29 08:43:03 +02:00
Vasily Nemkov
ee8209ca01 Updated test case
Invalid escape sequence is removed from key or value, while corresponding key or value are not discarded
2023-03-28 14:37:28 +02:00
Vasily Nemkov
6bc33670c7 It works 2023-03-28 14:34:36 +02:00
Vasily Nemkov
7854800517 Almost works 2023-03-27 19:35:22 +02:00
Vasily Nemkov
fa27ed9d41 Less noisy tests 2023-03-25 23:31:17 +01:00
Vasily Nemkov
ce608b135f Fixed implementation of find_first_symbols_sse42 run-time needle
Added some tests
2023-03-25 23:18:51 +01:00
Vasily Nemkov
e22eee8055 Updated implementation of find_first_symbols for run-time needle
Implemented compile-time and run-time dispatching between SSE4.2 and SSE2 implementations
Added find_first_symbols_sse2
Added tests
2023-03-24 15:45:12 +01:00
Arthur Passos
487296c1c3 style 2023-03-21 13:41:37 -03:00
Arthur Passos
41701d9baa remove isEscapeCharacter method 2023-03-21 12:28:15 -03:00
Arthur Passos
5952ed030c use standard parseComplexEscapedSequence instead of custom implementation. Drops support for 1 digit hex and octal digits 2023-03-21 12:21:09 -03:00
Arthur Passos
77419db791 add a few tests for runtime find_symbols, more are needed 2023-03-21 09:07:06 -03:00
Arthur Passos
cceb1b278c
Merge branch 'master' into parsey_key_value_function 2023-03-20 15:27:37 -03:00
Arthur Passos
c12869681b move runtime find_first_symbols to find_symbols.h 2023-03-20 15:26:00 -03:00
robot-clickhouse-ci-1
15893fa94e
Merge pull request #47789 from ClickHouse/proper-review-states
Only valid Reviews.STATES overwrite existing reviews
2023-03-20 19:05:24 +01:00
Anton Popov
158131053b
Merge pull request #47688 from ucasfl/fix-limit-offset
Fix limit offset
2023-03-20 18:47:41 +01:00
Mikhail f. Shiryaev
5eacb6b3be
Fix the keeping the latest review instead of the first 2023-03-20 18:40:39 +01:00
Mikhail f. Shiryaev
f881da249f
Only valid Reviews.STATES overwrite existing reviews 2023-03-20 18:39:58 +01:00
robot-ch-test-poll4
91f8901cd6
Merge pull request #47743 from ucasfl/remove
remove unused code
2023-03-20 17:43:41 +01:00
Arthur Passos
c3244d7f2d remove needles size check inside find_first_symbols 2023-03-20 13:25:48 -03:00
Arthur Passos
662848fe76 remove reading_empty state 2023-03-20 13:25:03 -03:00