Commit Graph

135254 Commits

Author SHA1 Message Date
Kruglov Pavel
58a53b42ac
Set max_entries to min(max_parallel_replicas, all available reolicas) 2024-02-27 14:31:35 +01:00
Kruglov Pavel
f264f0a036
Fix style 2024-02-26 22:06:10 +01:00
Kruglov Pavel
8aa9f36484
Fix style 2024-02-26 22:05:54 +01:00
avogar
ac4af6a4ad Don't allow to set max_parallel_replicas to 0 as it doesn't make sense 2024-02-26 19:58:49 +00:00
Sergei Trifonov
2c766cf75f
Merge pull request #59507 from ClickHouse/alter-table-forget-partition
Add `FORGET PARTITION` query to remove old partition nodes from ZooKeeper
2024-02-23 12:55:08 +01:00
Vitaly Baranov
db119eed49
Merge pull request #60002 from vitlibar/add-config-setting-remove-backup-files-after-failure
Add new config setting "backups.remove_backup_files_after_failure"
2024-02-23 12:42:55 +01:00
Nikolai Kochetov
dfccd521f3
Merge pull request #60221 from kitaisreal/backups-docs-id-setting
Backups documentation added id setting
2024-02-23 12:09:29 +01:00
Kseniia Sumarokova
6a7fef13ba
Merge pull request #60282 from ClickHouse/s3queue-fix-bug-and-flaky-test
s3queue: fix bug (also fixes flaky test_storage_s3_queue/test.py::test_shards_distributed)
2024-02-23 11:57:34 +01:00
kssenii
00f5eea0fa Ping CI 2024-02-23 11:54:57 +01:00
Robert Schulze
e325afa350
Merge pull request #59551 from jinjunzh/iaadeflate_upgrade_qpl_v1.4.0
Upgrade QPL to v1.4.0+Fix qpl_deflate codec bug for polling timeout
2024-02-23 11:24:06 +01:00
Raúl Marín
1a4b4d493f
Merge pull request #60228 from Algunenano/parallel_replicas_2
Treat 2+ in allow_experimental_parallel_reading_from_replicas as 2
2024-02-23 11:17:23 +01:00
Robert Schulze
38d4d1fb57
Merge remote-tracking branch 'ClickHouse/master' into iaadeflate_upgrade_qpl_v1.4.0 2024-02-23 10:01:01 +00:00
Raúl Marín
b7b16e5ff5
Merge pull request #60270 from Algunenano/no_such_key
Ignore valid 'No such key errors' in stress tests
2024-02-23 10:47:25 +01:00
Raúl Marín
a5b0b059a4 Merge remote-tracking branch 'blessed/master' into no_such_key 2024-02-23 10:25:12 +01:00
Antonio Andelic
7ea44f95e3
Merge pull request #60226 from ClickHouse/keeper-better-snapshot
Slightly better Keeper loading from snapshot
2024-02-23 08:49:15 +01:00
Alexey Milovidov
e83deb4410
Merge pull request #60178 from ClickHouse/fix-wrong-message-during-compilation
Fix wrong message during compilation
2024-02-23 00:00:41 +01:00
Alexey Milovidov
06d10fa14b
Merge pull request #60269 from ClickHouse/fix-test-backup-s3
Fix integration `test_backup_restore_s3`
2024-02-22 23:59:10 +01:00
Alexey Milovidov
7948babf15
Merge pull request #60256 from ClickHouse/counterexample
Tests from #60094
2024-02-22 23:57:35 +01:00
Max K
942eb05f5a
Merge pull request #60327 from ClickHouse/ci_remove_some_integratione_test_jobs_for_pr
CI: remove Integration tests asan and release from PR wf
2024-02-22 21:26:59 +01:00
Max Kainov
831fee9edb CI: remove Integration tests asan, release from PR wf
#do_not_test
2024-02-22 18:35:06 +00:00
Igor Nikonov
8f3ca99cfc
Merge pull request #60252 from ClibMouse/bugfix/http-exception-codes
Fix http exception codes.
2024-02-22 19:17:51 +01:00
János Benjamin Antal
7cad0050c0
Disambiguate alter commands list (#59532)
* Add optional parentheses to TTL element and alter command

* Add some basic tests

* Extend tests with more test cases

* Add one more test case

* Add server setting to control new formatting behavior

* Automatic style fix

* Fix segfault in `clickhouse-format` related to new server setting

* Remove format_ttl_expressions_with_parentheses

* Fix unit test compilation failures

* Introduce global flag to control the new formatting behavior

* Revert "Fix segfault in `clickhouse-format` related to new server setting"

This reverts commit d7131a3145.

* Revert accidental changes

* Revert accidental include reorder

* Revert accidental changes

* Enable new format in client and local server

---------

Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
2024-02-22 19:17:15 +01:00
Max K
0df33c94ba
Merge pull request #60224 from ClickHouse/ci_combine_analyzer_s3_replicated_tests
CI: combine analyzer, s3, dbreplicated into one job
2024-02-22 18:41:41 +01:00
Alexander Tokmakov
e56748a92c
Merge pull request #60044 from ClickHouse/fix_undead_sessions
Ability to detect undead ZooKeeper sessions
2024-02-22 18:13:15 +01:00
Max Kainov
edba794074 WA: 01023 test suppressed for replicated db
#job_Stateless_tests_release_analyzer_s3_DatabaseReplicated #batch_2
 #job_style_check
 #no_merge_commit
2024-02-22 17:10:56 +00:00
Vitaly Baranov
b130726a0c
Merge branch 'master' into add-config-setting-remove-backup-files-after-failure 2024-02-22 18:09:12 +01:00
pufit
57306706b3
Add definers for views (#54901) 2024-02-22 17:47:50 +01:00
Alexander Tokmakov
97ed2c05b0 Merge branch 'master' into fix_undead_sessions 2024-02-22 14:36:36 +01:00
Alexander Tokmakov
f83ddb1a70
Merge pull request #60303 from ClickHouse/tavplubix-patch-10
Update analyzer_tech_debt.txt
2024-02-22 14:34:35 +01:00
Alexander Tokmakov
0c8aab91e6
Update analyzer_tech_debt.txt 2024-02-22 14:32:30 +01:00
Alexey Milovidov
c6c09822e3 Merge branch 'counterexample' of github.com:ClickHouse/ClickHouse into counterexample 2024-02-22 14:29:37 +01:00
Alexey Milovidov
72b8880467 Make the reference correct 2024-02-22 14:29:24 +01:00
Nikolai Kochetov
c3f925da0a
Merge pull request #60164 from kitaisreal/copy-s3-file-gcp-fallback-to-buffer-copy
Copy S3 file GCP fallback to buffer copy
2024-02-22 12:53:15 +01:00
Nikolai Kochetov
0e6b55ad35
Merge pull request #60220 from kitaisreal/system-backups-system-backup-log-add-query-id-and-error-stacktrace
Tables system.backups and system.backup_log add query_id and error stacktrace
2024-02-22 12:43:52 +01:00
kssenii
222323f293 Fix 2024-02-22 12:38:13 +01:00
Alexey Milovidov
2a3c9b288a Merge branch 'master' of github.com:ClickHouse/ClickHouse into counterexample 2024-02-22 12:33:15 +01:00
Raúl Marín
5684a14160 Ignore valid 'No such key errors' in stress tests 2024-02-22 11:47:43 +01:00
Kseniia Sumarokova
fb7924cdb1
Merge pull request #60233 from ClickHouse/hide-sensitive-info-in-s3-queue
Hide sensitive info for s3queue
2024-02-22 11:37:15 +01:00
Robert Schulze
2d2acd6bf9
Merge pull request #60202 from rschu1ze/vector-dot-product
Vectorize `dotProduct`
2024-02-22 11:19:31 +01:00
Robert Schulze
ae597d86dd
Merge remote-tracking branch 'rschu1ze/master' into vector-dot-product 2024-02-22 10:16:28 +00:00
Robert Schulze
d638820478
Merge remote-tracking branch 'ClickHouse/master' into iaadeflate_upgrade_qpl_v1.4.0 2024-02-22 10:07:49 +00:00
Alexey Milovidov
330043af30 Fix integration test_backup_restore_s3 2024-02-22 10:58:05 +01:00
Alexey Milovidov
659d960990
Merge pull request #60245 from Algunenano/enforce_cloud_sync
Make cloud sync required
2024-02-22 10:11:01 +01:00
Azat Khuzhin
a4f765cae7
Improve performance of SELECTs with active mutations (#59531)
* Configure keeper for perf tests

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Improve performance of SELECTs with active mutations

getAlterMutationCommandsForPart() can be a hot path for query execution
when there are pending mutations.

- LOG_TEST - it is not only check one bool, but actually a bunch of
  atomics as well.

- Return std::vector over std::map (map is not required there) - no
  changes in performance.

- Copy only RENAME_COLUMN (since only this mutation is required by
  AlterConversions).

And here are results:

run|result
-|-
SELECT w/o ALTER|queries: 1565, QPS: 355.259, RPS: 355.259
SELECT w/ ALTER unpatched|queries: 2099, QPS: 220.623, RPS: 220.623
SELECT w/ ALTER and w/o LOG_TEST|queries: 2730, QPS: 235.859, RPS: 235.859
SELECT w/ ALTER and w/o LOG_TEST and w/ RENAME_COLUMN only|queries: 2995, QPS: 290.982, RPS: 290.982

But there are still room for improvements, at least MergeTree engines
could implement getStorageSnapshotForQuery().

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Add AlterConversions::supportsMutationCommandType(), flatten vector<vector<MutationCommand>>

* Work around what appears to be a clang static analysis bug

---------

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Co-authored-by: Michael Kolupaev <michael.kolupaev@clickhouse.com>
2024-02-22 08:51:10 +00:00
Antonio Andelic
1b238d1180
Merge pull request #59460 from ClickHouse/keeper-logs-cache
Keeper log cache
2024-02-22 09:03:41 +01:00
kothiga
0bc7c0a558
Addressing feedback. 2024-02-21 17:01:16 -08:00
Alexey Milovidov
0c113529f9
Update 02996_index_compaction_counterexample.sql 2024-02-21 22:51:26 +01:00
Michael Kolupaev
865ae80e7c Counterexample 2024-02-21 22:49:29 +01:00
Alexey Milovidov
ba157a10fd Add a long test that could find errors in index analysis
Add a long test that could find errors in index analysis

Update test
2024-02-21 22:49:24 +01:00
Raúl Marín
9f23f478c4 Merge remote-tracking branch 'blessed/master' into enforce_cloud_sync 2024-02-21 20:35:02 +01:00