Commit Graph

12666 Commits

Author SHA1 Message Date
Alexey Milovidov
75a2589a42
Merge branch 'master' into deprecate-in-memory-parts 2023-05-06 00:49:59 +03:00
Robert Schulze
3dfc0bd265
Merge pull request #49413 from azat/build/headers
Slightly reduce inter-header dependencies
2023-05-05 23:37:58 +02:00
Robert Schulze
45c28e1221
Introduce more fields for in-source function documentation 2023-05-05 21:30:21 +00:00
Nikolay Degterinsky
d29193da51 Also prohibit complex types with Object('json') 2023-05-05 18:45:00 +00:00
Nikolay Degterinsky
f361d96f21 Forbid the change of data type of Object('json') column 2023-05-05 15:51:17 +00:00
Sema Checherinda
efcf7fbe4f
Update src/Storages/StorageReplicatedMergeTree.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@gmail.com>
2023-05-05 17:49:12 +02:00
Sema Checherinda
36b028bc6b
Update src/Storages/StorageReplicatedMergeTree.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@gmail.com>
2023-05-05 17:48:57 +02:00
Robert Schulze
aba5db40a1
Merge remote-tracking branch 'origin/master' into rs/qc-totals-extremes2 2023-05-05 14:11:10 +00:00
Nikolay Degterinsky
7a727bbbe3
Merge pull request #49520 from IvanTakarlikov-st/it-grammar-fixes
Fix some grammar mistakes in documentation, code and tests
2023-05-05 15:45:58 +02:00
wangxiaobo
f704c0dfec
Implement SYSTEM DROP REPLICA from auxillary ZooKeeper clusters (#48932)
* multiple zookeeper drop replica bug fix.

* add an integration test.

* format code.

* set stay_alive=True for test.

* style check bug fix.

* add check for is_active

* format code

* remove table_settings and has_metadata_out param.
2023-05-05 14:11:11 +03:00
Kseniia Sumarokova
7c203dbcd2
Merge pull request #49481 from snikch/master
Fix postgres database setting
2023-05-05 12:53:51 +02:00
Anton Popov
c87a6e8e7d
Merge pull request #49117 from CurtizJ/limit-mutations
Add settings to delay or throw in case of too many mutations
2023-05-05 12:18:57 +02:00
Alexey Milovidov
09f171822e Merge branch 'master' into deprecate-in-memory-parts 2023-05-05 06:43:23 +02:00
Michael Kolupaev
3bd1489f18 Propagate input_format_parquet_preserve_order to parallelizeOutputAfterReading() 2023-05-05 04:20:27 +00:00
Alexey Milovidov
ab1a1ea5b7
Merge pull request #49490 from ClickHouse/fix-s3cluster-with-headers
Correctly handle s3Cluster arguments
2023-05-05 05:31:23 +03:00
Michael Kolupaev
0fa311ee38 Make INSERT do more things in parallel to avoid getting bottlenecked on one thread 2023-05-05 00:49:27 +00:00
Michael Kolupaev
eb3b774ad0 Better control over Parquet row group size 2023-05-04 14:59:55 -07:00
Sema Checherinda
9a0bc891e4 fix can_remove_callback for Temporary parts 2023-05-04 19:39:16 +02:00
Ivan Takarlikov
8873856ce5 Fix some grammar mistakes in documentation, code and tests 2023-05-04 13:35:18 -03:00
Anton Popov
e61d7baa54 Merge remote-tracking branch 'upstream/master' into HEAD 2023-05-04 14:03:53 +00:00
Alexander Tokmakov
36f8fcdfaf
Merge pull request #49458 from ClickHouse/tavplubix-patch-6
Follow-up to #48792
2023-05-04 14:32:18 +03:00
kssenii
1433f5ffc9 Merge remote-tracking branch 'upstream/master' into remove-dependency-from-context 2023-05-04 13:24:02 +02:00
Antonio Andelic
a68a023ca7
Merge pull request #48724 from johanngan/sse-kms
Support SSE-KMS configuration with S3 client
2023-05-04 13:20:54 +02:00
Alexander Gololobov
f77cc89464
Merge pull request #49470 from ClickHouse/remove_no_delay_flag
Replace `NO DELAY` with `SYNC` in tests
2023-05-04 11:57:01 +02:00
alesapin
412b161104
Merge pull request #48791 from kssenii/better-local-object-storage
Make local object storage work consistently with s3 object storage, fix problem with append, make it configurable as independent storage
2023-05-04 11:47:43 +02:00
alesapin
89caf40840
Merge pull request #46528 from myrrc/feature/show-secrets-option
Show secrets in `SHOW` and `SELECT` queries
2023-05-04 11:21:30 +02:00
Antonio Andelic
8769ac2187 Correctly append arguments 2023-05-04 08:30:45 +00:00
johanngan
731823b873 Add support for SSE-KMS configuration with S3
https://docs.aws.amazon.com/AmazonS3/latest/userguide/UsingKMSEncryption.html

Similar to the server_side_encryption_customer_key_base64 option for
configuring SSE-C with S3, add the following settings to configure
SSE-KMS on a per-endpoint/disk basis:
  - server_side_encryption_kms_key_id
  - server_side_encryption_kms_encryption_context
  - server_side_encryption_kms_bucket_key_enabled
2023-05-03 21:35:38 -05:00
Mal Curtis
5727585d95 s/use_tables_cache/use_table_cache 2023-05-03 23:40:12 +00:00
Alexey Milovidov
261907c143 Merge branch 'master' into deprecate-in-memory-parts 2023-05-04 01:07:38 +02:00
Alexander Gololobov
a90c2ec90d
Merge pull request #49425 from ClickHouse/fix_build_set_with_remote
Fix fuzz bug when subquery set is not built when reading from remote()
2023-05-03 21:47:29 +02:00
wangxiaobo
2924837c7e
Fix Attaching a table with non-existent ZK path does not increase the ReadonlyReplica metric (#48954)
* Attaching a table with non-existent ZK path does not increase the ReadonlyReplica metric bug fix.

* add integration test.

* add integration test.

* Update test.py

* format code

* format code
2023-05-03 22:41:20 +03:00
Alexander Tokmakov
83b12ec5ca replace NO DELAY with SYNC in tests 2023-05-03 20:08:49 +02:00
Anton Popov
c9705d6bf1
Merging #49066 (Better error handling during loading of parts) (#49430)
* catch filesystem error when loading parts

* better exception handling during part loading

---------

Co-authored-by: cangyin <excangyin@gmail.com>
Co-authored-by: Nikita Mikhaylov <mikhaylovnikitka@gmail.com>
2023-05-03 19:10:06 +02:00
Nikita Mikhaylov
954e3b724c
Speedup outdated parts loading (#49317) 2023-05-03 18:56:45 +02:00
Alexander Tokmakov
ff70d26c23
Update StorageMergeTree.cpp 2023-05-03 19:30:44 +03:00
Alexander Tokmakov
e399903030
Merge pull request #48548 from ClickHouse/clusters_is_active_column
Add some columns to system.clusters
2023-05-03 17:42:40 +03:00
Alexander Tokmakov
f3f6cfdcbb
Update StorageMergeTree.cpp 2023-05-03 17:39:31 +03:00
Anton Popov
7896d30737
Merge pull request #49122 from CurtizJ/add-async-insert-mt-setting
Add `MergeTree` setting `async_insert`
2023-05-03 16:01:13 +02:00
kssenii
35f437ac9c Address review comments 2023-05-03 14:37:18 +02:00
kssenii
189f276ff5 Fix 2023-05-03 13:16:08 +02:00
alesapin
6f3f202f7c
Merge branch 'master' into fix_zero_copy_not_atomic 2023-05-03 12:53:35 +02:00
Nikolai Kochetov
6388be2062
Merge pull request #49326 from k-morozov/refactoring/pipe-into-step
move pipe compute into initializePipeline
2023-05-03 12:43:21 +02:00
Alexey Milovidov
ee9fae6aa2
Merge pull request #49363 from tsolodov/master
Disallow configuring compression CODECs for alias columns
2023-05-03 03:37:48 +03:00
Alexey Milovidov
f449df85b6 Deprecate in-memory parts 2023-05-03 00:31:09 +02:00
kssenii
d8d0d78db8 Fix build 2023-05-03 00:09:52 +02:00
kssenii
ecfbf1e304 Remove dependency from DB::Context in readers 2023-05-02 21:45:27 +02:00
Alexander Gololobov
2e20f2a14d Do not skip building set even when reading from remote 2023-05-02 21:31:56 +02:00
Azat Khuzhin
2b21b83979 Reduce inter-header dependencies
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-02 21:15:18 +02:00
alesapin
a08225d9ea Fix typo 2023-05-02 15:34:57 +02:00
SmitaRKulkarni
997210c782
Merge pull request #48515 from ClickHouse/Clear_marks_cache_for_outdated_parts
MergeTreeMarksLoader holds DataPart instead of DataPartStorage
2023-05-02 15:11:14 +02:00
Konstantin Morozov
e4394debd4 forgot about query_plan 2023-05-02 14:59:41 +02:00
Konstantin Morozov
397a1700c7 apply comments 2023-05-02 14:59:41 +02:00
kst-morozov
f0619910d4 move pipe compute into initializePipeline 2023-05-02 14:59:41 +02:00
alesapin
24a744db4c Merge branch 'master' into fix_zero_copy_not_atomic 2023-05-02 14:57:55 +02:00
alesapin
619b6f2071 Fix typo 2023-05-02 14:57:52 +02:00
Nikita Mikhaylov
aa4c5fe958
Enhancements for background merges (#49313) 2023-05-02 13:43:59 +02:00
Anton Popov
bcdd2307fb add comments 2023-05-02 11:30:50 +00:00
Antonio Andelic
f695040a19
Merge pull request #48897 from ClickHouse/keeper-check-not-exists
Add `CheckNotExists` request to Keeper
2023-05-02 13:14:22 +02:00
Vladimir C
96d109c3db
Merge pull request #49137 from ClickHouse/vdimir/mutliple_storage_join 2023-05-02 11:40:16 +02:00
Timur Solodovnikov
e58a63b451 addressing PR comments 2023-05-01 16:13:45 -07:00
Han Fei
d608ba41e7 try to fix 2023-05-02 00:05:36 +02:00
Timur Solodovnikov
c7295db43e nit 2023-05-01 13:59:38 -07:00
Timur Solodovnikov
6566ed7863 removed loop & added tests 2023-05-01 13:51:46 -07:00
kssenii
fbdccbd25f Merge remote-tracking branch 'origin/better-local-object-storage' into better-local-object-storage 2023-05-01 22:25:28 +02:00
kssenii
f325ba1794 Better 2023-05-01 21:10:37 +02:00
alesapin
0f6a4b973e
Merge branch 'master' into ttl_on_insert 2023-05-01 21:02:04 +02:00
alesapin
a3f9a8b87b Fix bug in removal of existing part directory 2023-05-01 20:32:01 +02:00
Nikita Mikhaylov
503f099afe
Merge branch 'master' into master 2023-05-01 18:50:44 +02:00
Timur Solodovnikov
fc5b0783fd fix for linter 2023-05-01 09:40:56 -07:00
Timur Solodovnikov
e49842ff6c block setting codec for alias columns 2023-05-01 09:25:08 -07:00
Han Fei
4d18a4f8d3
Merge branch 'master' into hanfei/fiu 2023-05-01 17:51:41 +02:00
Han Fei
b701293d46 support named fault injection and add a simple test 2023-05-01 17:44:37 +02:00
alesapin
66847386df
Merge pull request #49146 from ClickHouse/don_t_write_version_file_on_start
Don't add metadata_version file if it doesn't exist
2023-05-01 17:04:47 +02:00
Anton Popov
36d53e0d6c
Merge branch 'master' into add-async-insert-mt-setting 2023-05-01 16:13:23 +02:00
Duc Canh Le
abe0cfd10f
fix wrong query result when using nullable primary key (#49172) 2023-05-01 12:51:22 +02:00
alesapin
f03e75971a Remove on detach 2023-04-30 19:06:31 +02:00
alesapin
a098298c0f Remove file for empty parts 2023-04-30 19:06:23 +02:00
alesapin
a95a5f6fb6 Fix two bugs and add test 2023-04-30 16:33:23 +02:00
alesapin
ec2c860a39 Merge branch 'fix_zero_copy_not_atomic' of github.com:ClickHouse/ClickHouse into fix_zero_copy_not_atomic 2023-04-30 15:02:27 +02:00
Smita Kulkarni
408db4a25b Updated to store IMergeTreeDataPartInfoForReader instead of DataPart in MergeTreeMarksLoader 2023-04-30 10:56:43 +02:00
alesapin
daa0b095ed Merge branch 'master' into fix_zero_copy_not_atomic 2023-04-29 21:26:26 +02:00
Alexey Milovidov
15d0379e2c
Merge pull request #48792 from ClickHouse/fix_some_tests3
Fix some tests
2023-04-29 22:04:11 +03:00
Nikita Taranov
f1ff2c0135
Fix oss-fuzz build errors (#49236) 2023-04-29 18:44:50 +02:00
Alexey Milovidov
5bd4fc9e90
Merge pull request #48492 from azat/s3-multipart-strict-size
Add ability to use strict parts size for S3 (compatibility with R2)
2023-04-28 23:34:45 +03:00
Kseniia Sumarokova
d4aa96e262
Merge branch 'master' into better-local-object-storage 2023-04-28 21:05:05 +02:00
Mike Kot
2d20658885
Merge branch 'master' into feature/show-secrets-option 2023-04-28 20:19:35 +03:00
alesapin
70ee02a3eb Add node holder 2023-04-28 17:39:32 +02:00
Alexey Milovidov
911d4e9977
Merge branch 'master' into fix_some_tests3 2023-04-28 17:23:46 +03:00
Alexander Tokmakov
691fdbf6a6
Update StorageReplicatedMergeTree.cpp (#49302) 2023-04-28 17:21:03 +03:00
Alexey Milovidov
6dcfdbfaf2
Merge branch 'master' into clusters_is_active_column 2023-04-28 16:16:25 +03:00
alesapin
ef49603432 Merge branch 'master' into fix_zero_copy_not_atomic 2023-04-28 14:42:30 +02:00
kssenii
e603adfd4c Merge remote-tracking branch 'upstream/master' into better-local-object-storage 2023-04-28 13:26:57 +02:00
kssenii
298ed454ce Merge remote-tracking branch 'upstream/master' into better-local-object-storage 2023-04-28 13:26:55 +02:00
Raúl Marín
bb4a7f65de
Slight improvements to coordinator logging (#49204) 2023-04-28 13:25:53 +02:00
Kseniia Sumarokova
107474a42f
Merge pull request #44985 from kssenii/cache-better-locks
Rework locking in fs cache
2023-04-28 12:24:55 +02:00
Azat Khuzhin
c8ec152f57 Add ability to use strict parts size for S3 (compatibility with R2)
The are some implementations that does not allow to use parts of
different size for multi-part upload:

- CouldFlare R2 [1] and also got help on discord
- AWS S3 Glacier [2]
- and I also know of one bug in Google Cloud Storage (GCS), but it
  should be fixed in a couple of months.

  [1]: https://developers.cloudflare.com/r2/reference/changelog/#2022-10-28
       > Multipart upload part sizes are always expected to be of the
       > same size, but this enforcement is now done when you complete
       > an upload instead of being done very time you upload a part

  [2]: https://docs.aws.amazon.com/amazonglacier/latest/dev/api-multipart-initiate-upload.html

On top of this I'm going to add auto detection of this issue for disks,
but not for S3 function, since those checks are quite costly, and they
need to write at least 5MB*3, which may be questionable.

v2: mark test as long [1]
    [1]: https://s3.amazonaws.com/clickhouse-test-reports/48492/d4a90880e947ab3a17b3eddeea274afed8ebceb4/stateless_tests_flaky_check__asan_.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-28 11:01:56 +02:00
Mike Kot
357cde95e9 Merge branch 'master' into feature/show-secrets-option 2023-04-27 20:19:40 +00:00
Robert Schulze
b6e65ddeff
Merge branch 'master' into add-examples-to-functions 2023-04-27 16:11:32 +02:00
Kseniia Sumarokova
45e2d296f9
Merge branch 'master' into better-local-object-storage 2023-04-27 14:54:04 +02:00