Commit Graph

55894 Commits

Author SHA1 Message Date
Nikolai Kochetov
fb235c0840 Fix optimize_arithmetic_operations_in_aggregate_functions optimization which could change result type. 2024-03-28 14:44:45 +00:00
vdimir
4b990e732c
Fix style 2024-03-28 15:22:26 +01:00
Kruglov Pavel
facde7541f
Merge pull request #61567 from Avogar/fix-analyzer-group-by-use-nulls
Fix logical error in group_by_use_nulls + grouping set + analyzer + materialize/constant
2024-03-28 14:38:11 +01:00
Kruglov Pavel
9b5b44dd5f
Merge pull request #61889 from Avogar/allow-to-save-bad-json-escape-sequences
Add a setting to allow saving bad escape sequences in JSON input formats
2024-03-28 14:34:02 +01:00
Kruglov Pavel
70bb85a754
Merge pull request #61999 from Avogar/variant-number-bool
Don't treat Bool and number variants as suspicious in Variant type
2024-03-28 14:33:24 +01:00
Kseniia Sumarokova
0244e0851a
Merge pull request #61954 from ClickHouse/follow-up-broken-projections
Follow up to #60452
2024-03-28 14:23:28 +01:00
Azat Khuzhin
f4c5be3bb4 Fix CREATE TABLE w/o columns definition for ReplicatedMergeTree
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-28 14:06:52 +01:00
Han Fei
a0d27e45b9
Merge branch 'master' into drop_tables 2024-03-28 13:56:50 +01:00
Yarik Briukhovetskyi
003d258ba1
Merge pull request #61862 from HowePa/truncate_all_tables
add TRUNCATE ALL TABLES
2024-03-28 13:32:46 +01:00
Kseniia Sumarokova
5ba2ad53b6
Merge pull request #61163 from ClickHouse/filecache-better-try-reserve
Less contention in cache, part 3
2024-03-28 13:24:22 +01:00
Maksim Kita
a376a7354f Fixed code review issues 2024-03-28 15:04:14 +03:00
zhongyuankai
7938a8e62b Merge branch 'master' into drop_tables 2024-03-28 20:00:56 +08:00
zhongyuankai
f1ae99b113 Support ALTER MODIFY SETTING for Memory tables 2024-03-28 19:55:22 +08:00
Alexander Tokmakov
a0b9b888ee
Merge pull request #61799 from ClickHouse/more_secondary_create
Skip more sanity checks for secondary create queries
2024-03-28 10:01:05 +01:00
Smita Kulkarni
afbb3f8a50 Added wait before commit blocks 2024-03-28 09:26:00 +01:00
Anton Popov
56b3c95d54 Merge remote-tracking branch 'upstream/master' into HEAD 2024-03-27 22:38:00 +00:00
avogar
75be74874e Fix include 2024-03-27 22:27:27 +00:00
avogar
c39cd75dff Support Variant in JSONExtract functions 2024-03-27 22:15:29 +00:00
Han Fei
b824e94e8c
Merge pull request #61936 from hanfei1991/hanfei/refreshable_view_race
fix a race in refreshable view
2024-03-27 22:55:22 +01:00
avogar
90144f7ae4 Fix style 2024-03-27 21:31:15 +00:00
Alexey Milovidov
795026af72
Merge pull request #61911 from ClickHouse/jamesweb
Make userspace page cache work with 'web' disks
2024-03-28 00:18:27 +03:00
avogar
df06619399 Better conversion from String to Variant 2024-03-27 20:40:26 +00:00
Han Fei
f3616f67aa Merge branch 'master' into hanfei/refreshable_view_race 2024-03-27 21:33:59 +01:00
Nikita Taranov
7b17b14aa0
Merge pull request #61671 from GrigoryPervakov/master
Reload certificate chain during certificate reload
2024-03-27 21:19:32 +01:00
Nikolai Kochetov
ce2e5a7d13 Fixing tests. 2024-03-27 19:25:07 +00:00
Nikolai Kochetov
3ce122ef20 Fixing tests. 2024-03-27 19:23:16 +00:00
avogar
043c625898 Don't treat Bool and number variants as suspicious 2024-03-27 19:19:08 +00:00
Nikolai Kochetov
920ba121fe Fix scalars for CREATE AS SELECT for analyzer. 2024-03-27 19:17:41 +00:00
Nikolai Kochetov
dc52b81f5d Merge branch 'master' into gb-use-null-analyzer-crashes 2024-03-27 18:37:27 +00:00
Alexander Tokmakov
2d36f6240e
Update src/Databases/DatabaseOnDisk.cpp 2024-03-27 19:25:04 +01:00
Han Fei
e849c48e21 add a test 2024-03-27 18:56:13 +01:00
Alexey Milovidov
4250c5fb19 Update autogenerated version to 24.4.1.1 and contributors 2024-03-27 18:48:14 +01:00
Nikolai Kochetov
6127b0b899 Revert "Fix broken only_analyze in QueryAnalysisPass"
This reverts commit c88cb6be9d.
2024-03-27 17:43:27 +00:00
Nikolai Kochetov
6a7d48b932 Fix aliases. 2024-03-27 17:26:12 +00:00
Maksim Kita
d8b06588b8 Aggregator parallel merge cancellation 2024-03-27 20:14:52 +03:00
Smita Kulkarni
42a27c5c87 Fix WriteBufferAzureBlobStorage destructor uncaught exception 2024-03-27 16:27:47 +01:00
János Benjamin Antal
2c5c589a88
Merge pull request #61779 from ClickHouse/revert-61774-revert-61479-61220_fix_read_system_parts
Revert "Revert "Fix bug when reading system.parts using UUID (issue 61220).""
2024-03-27 14:27:32 +01:00
Yakov Olkhovskiy
257cdd83d4
Merge pull request #60994 from bigo-sg/csv-tuple
fix csv format not support tuple
2024-03-27 09:07:46 -04:00
vdimir
3fa6d23730
Merge pull request #61364 from ClickHouse/vdimir/fix_crash_objson_array_null
Fix crash in ObjectJson parsing array with nulls
2024-03-27 13:41:09 +01:00
Igor Nikonov
15a0f5381f
Merge pull request #59176 from azat/dist/readonly-replicas
Add ability to skip read-only replicas for INSERT into Distributed engine
2024-03-27 13:19:12 +01:00
Yarik Briukhovetskyi
844bb4f06c
Merge pull request #61727 from yariks5s/fix_undrop_query
Revert "Revert "Un-flake test_undrop_query""
2024-03-27 13:12:50 +01:00
Dmitry Novik
39d99068c3
Merge pull request #61652 from ClickHouse/enable-analyzer
Enable `allow_experimental_analyzer` by default
2024-03-27 12:58:43 +01:00
vdimir
128c51c6fc
Fix storage join loading order 2024-03-27 11:27:30 +00:00
Nikita Mikhaylov
414bccc527
Revert "disallow LowCardinality input type for JSONExtract" (#61960) 2024-03-27 12:06:50 +01:00
Dmitry Novik
31df60be20 Merge remote-tracking branch 'origin/master' into enable-analyzer 2024-03-27 11:37:32 +01:00
Kseniia Sumarokova
af66e1f7c4
Fix style check 2024-03-27 11:25:58 +01:00
Han Fei
af2e86d72d make TSAN happy 2024-03-27 10:21:16 +01:00
Michael Kolupaev
d5da446d21 Tidy 2024-03-27 02:32:15 +00:00
Nikita Taranov
010fd38b71
Merge pull request #61664 from nickitat/db_on_disk_smth
Small change in `DatabaseOnDisk::iterateMetadataFiles()`
2024-03-27 00:06:43 +01:00
kssenii
0a5ce69880 Review fix 2024-03-26 22:02:50 +01:00
kssenii
dc83eb1ad6 Review fixes 2024-03-26 21:43:54 +01:00
Nikolai Kochetov
3b6ea659df Fixing 02535_analyzer_group_by_use_nulls 2024-03-26 19:10:34 +00:00
Dmitry Novik
65121b712e Merge remote-tracking branch 'origin/master' into enable-analyzer 2024-03-26 19:02:30 +01:00
Han Fei
2110bfd278 address comment 2024-03-26 18:53:54 +01:00
Han Fei
97fca6682e fix logical-error when undoing quorum insert transaction 2024-03-26 18:48:25 +01:00
kssenii
a777045dd3 Fix and more tests for broken projections handling 2024-03-26 18:47:48 +01:00
Dmitry Novik
c88cb6be9d Fix broken only_analyze in QueryAnalysisPass 2024-03-26 17:46:38 +01:00
shabroo
8e8bc83d36
Update Context.cpp
@alexey-milovidov please stop torturing me and accept this commit.
2024-03-26 17:37:27 +01:00
Nikita Mikhaylov
1b828ab6f6 Fix for ASync 2024-03-26 16:05:43 +00:00
Austin Kothig
c15993220f
Merge remote-tracking branch 'upstream' into feature/dateDiff-nanoseconds 2024-03-26 09:04:23 -07:00
avogar
98f99db6b2 Remove unneded change 2024-03-26 16:01:56 +00:00
Yarik Briukhovetskyi
d8bfdf040f
has_all -> has_all_tables 2024-03-26 16:58:36 +01:00
jsc0218
0eb12d2d27
Merge pull request #61888 from jsc0218/No_milli_micro_nanosecod_in_date_trunc
no smaller unit in date_trunc
2024-03-26 11:15:35 -04:00
Kruglov Pavel
50e667dd5b
Merge pull request #61667 from Avogar/fix-with-fill-invalid-chunk
Don't allow the same expression in ORDER BY with and without WITH FILL
2024-03-26 16:04:33 +01:00
Vitaly Baranov
83e006e372
Merge pull request #61734 from vitlibar/fix-columns-after-alter-table-modify-query
Fix columns after executing MODIFY QUERY for a materialized view with internal table
2024-03-26 15:35:22 +01:00
Kruglov Pavel
7220797637
Fix style 2024-03-26 15:26:42 +01:00
Han Fei
73deb9a24c fix a race in refreshable view 2024-03-26 14:20:54 +01:00
Nikolai Kochetov
2dee605d52 Merge branch 'master' into gb-use-null-analyzer-crashes 2024-03-26 13:05:03 +01:00
Nikolai Kochetov
277df60dc4 Fix some crashes with analyzer and group_by_use_nulls. 2024-03-26 12:01:17 +00:00
Alexander Gololobov
4e94510e32 Finish chunk if the size exceeds max_block_size 2024-03-26 12:49:19 +01:00
Alexander Gololobov
2bf1d118c7 Stream rows when reading from system.replicas 2024-03-26 12:49:19 +01:00
Arthur Passos
2ed53e309b
Reset part level upon attach from disk on MergeTree (#61536)
* hackish change to check how CI reacts

* remove unnecessary renameTo

* introduce separate metho

* remove unused arg

* rename meth od

* add simple test

* add current database

* set mutations sync

* Update tests/queries/0_stateless/03013_test_part_level_is_reset_attach_from_disk_mt.sql

---------

Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com>
Co-authored-by: János Benjamin Antal <benjamin.antal@clickhouse.com>
2024-03-26 11:44:55 +01:00
Azat Khuzhin
3481fd5191 Fix settings history for distributed_insert_skip_read_only_replicas
CI: https://s3.amazonaws.com/clickhouse-test-reports/59176/fa0c47a42f4187e8284e19d1cd008a0a76c38caf/fast_test.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:25:28 +01:00
Azat Khuzhin
1bb9cffb9b Remove distributed_insert_skip_read_only_replicas from settings history
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:24:59 +01:00
Azat Khuzhin
f86bb1e9e9 Rename to DistributedConnectionSkipReadOnlyReplica
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:24:59 +01:00
Azat Khuzhin
ac882c1e70 Simplify condition in PoolWithFailoverBase
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:24:59 +01:00
Azat Khuzhin
c7b919b19e Replace distributed_insert_replicas_preferences with distributed_insert_skip_read_only_replicas
v2: fix test
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:24:57 +01:00
Azat Khuzhin
a19b27bd7c Revert extra changed lines
That was the changes that looks OK for the initial patchset version, but
not now, after all review comments.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:24:16 +01:00
Azat Khuzhin
fe613ddd06 Convert distributed_insert_replicas_preferences into enum
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:24:14 +01:00
Azat Khuzhin
eb334d717a Remove superior check for empty pools
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:23:21 +01:00
Azat Khuzhin
dbdf080108 Remove insert argument for ConnectionPoolWithFailover
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:22:38 +01:00
Azat Khuzhin
d922bfb1b0 Introduce distributed_insert_prefer_non_readonly_replica setting
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:21:40 +01:00
Azat Khuzhin
0e99781686 Move insert flag from ConnectionEstablisher to TryResult
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:21:40 +01:00
Azat Khuzhin
b9469e2729 Do not try to INSERT into readonly replicas for Distributed engine
Sometimes replica may be readonly for a long time, and this will make
some INSERT queries fail, but it does not make sense to INSERT into
readonly replica, so let's ignore them.

But note, that this will require to extend TableStatus (not extend, but
introduce new version), that will have is_readonly field.

Also before background INSERT into Distributed does not uses
getManyChecked() which means that they do not request TableStatus
packet, while now they would, though this is minor (just a note).

v2: Add a note about max_replica_delay_for_distributed_queries for INSERT
v3: Skip read-only replicas for async INSERT into Distributed
v4: Remove extra @insert parameter for ConnectionPool*::get*
    It make sense only when the table name had passed --
    ConnectionPoolWithFailover::getManyChecked()
v5: rebase on top LoggerPtr
v6: rebase
v7: rebase
v8: move TryResult::is_readonly into the end

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:21:38 +01:00
Azat Khuzhin
77de81f996 Simpler and less error prone PoolWithFailoverBase::TryResult::reset()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:19:10 +01:00
Azat Khuzhin
b2945a5ad4 Mark Replicated table as readonly in case of static disk (read-only/write-once)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:19:10 +01:00
Nikolai Kochetov
2f382ac8a8
Merge pull request #61787 from ClickHouse/fix-virtual-columns-storage-merge-analyzer
Fix more tests with virtual columns in StorageMerge.
2024-03-26 11:16:25 +01:00
Nikolai Kochetov
f2e9ea2417
Merge pull request #61875 from ClickHouse/try-to-fix-02901_parallel_replicas_rollup-with-analyzer
Try to fix 02901_parallel_replicas_rollup with analyzer.
2024-03-26 11:12:29 +01:00
vdimir
802d6a2dac
Merge pull request #59007 from ClickHouse/vdimir/using_alias_followup
Analyzer: fixes for JOIN columns resolution
2024-03-26 10:36:50 +01:00
Kseniia Sumarokova
fd8e34a0ba
Merge pull request #60452 from ClickHouse/revert-refert-of-broken-projections-handling
Revert "Revert "Merge pull request #56864 from ClickHouse/broken-projections-better-handling""
2024-03-26 10:34:48 +01:00
Michael Kolupaev
899b856ad6 Add profile events for number of HTTP requests and bytes read 2024-03-26 09:14:55 +00:00
Michael Kolupaev
1fb902c5b7 Fix sending a new request every 2 MB 2024-03-26 09:14:55 +00:00
Michael Kolupaev
1f0de3de64 Add a test and remove unrelated unused profile events 2024-03-26 09:14:55 +00:00
Michael Kolupaev
ab0c601d63 Make userspace page cache work with 'web' disks 2024-03-26 09:14:55 +00:00
Alexey Milovidov
cc1ee02459
Merge pull request #61916 from ClickHouse/no-please
No "please"
2024-03-26 12:10:11 +03:00
Alexey Milovidov
76ed7e40fe
Merge pull request #61866 from azat/pool-remove-AllocateNewBypassingPool
Remove PoolBase::AllocateNewBypassingPool
2024-03-26 11:02:44 +03:00
Alexey Milovidov
9b052d059d No "please" 2024-03-26 09:00:20 +01:00
zhongyuankai
aa3830a3db Merge branch 'master' into drop_tables 2024-03-26 14:09:04 +08:00
zhongyuankai
8af5682395 batter 2024-03-26 13:02:12 +08:00
Alexey Milovidov
94f1379677 Move KQL trash where it is supposed to be 2024-03-26 04:02:32 +01:00
zhongyuankai
97d4fb01f4 fix test 2024-03-26 09:17:58 +08:00
pufit
cad66f3e68
Fix ALTER QUERY MODIFY SQL SECURITY (#61480) 2024-03-25 20:03:02 -04:00
Alexey Milovidov
7282c5dbf6
Merge pull request #61848 from ClickHouse/geodistance-double-precision
Double precision of geoDistance if the arguments are Float64
2024-03-26 02:58:07 +03:00
avogar
dc87c483dd Add a setting to allow saving bad escape sequences in JSON input formats 2024-03-25 21:58:53 +00:00
Yakov Olkhovskiy
6c4cd355e6
Merge pull request #61511 from jewelzqiu/existing-count
Add docs for lwd-aware merge settings
2024-03-25 16:59:58 -04:00
jsc0218
faf82d53b3 no smaller unit in date_trunc 2024-03-25 20:56:00 +00:00
avogar
e22c3f7bff Mark CANNOT_PARSE_ESCAPE_SEQUENCE error as parse error to be able to skip it in row input formats 2024-03-25 18:13:11 +00:00
Alexey Milovidov
1928e7d1f6
Merge pull request #60886 from ArctypeZach/master
Add support for `START TRANSACTION` syntax
2024-03-25 21:09:48 +03:00
Alexander Tokmakov
87dea7885f
Merge pull request #61675 from ClickHouse/replace_range_sucks
Fix actual_part_name for REPLACE_RANGE (`Entry actual part isn't empty yet`)
2024-03-25 18:59:49 +01:00
Alexander Tokmakov
071a8ff95f less unformatted exceptions 2024-03-25 18:55:46 +01:00
Julia Kartseva
a24b76c02e
Merge pull request #61617 from jkartseva/json-disallow-low-cardinality
disallow LowCardinality input type for JSONExtract
2024-03-25 10:21:36 -07:00
Pervakov Grigorii
a2ad832dfe fix error handling 2024-03-25 17:13:30 +00:00
Han Fei
233a75505b
Merge pull request #61766 from ditgittube/master_fix_window
Fix RANGE frame is not supported for Nullable columns.
2024-03-25 17:17:58 +01:00
kssenii
5100b0d52e Fix typo 2024-03-25 17:04:44 +01:00
Nikolai Kochetov
3752b13753 See what would happen if constant fold _CAST for scalar subqueries properly. 2024-03-25 15:36:01 +00:00
Alexey Milovidov
dc6d713658
Merge pull request #60774 from canhld94/zookeeper_log_us
Change column name from duration_ms to duration_us in system.zookeeper
2024-03-25 18:07:58 +03:00
Alexey Milovidov
c2209c997c
Merge branch 'master' into geodistance-double-precision 2024-03-25 17:49:32 +03:00
Alexey Milovidov
24261476c4
Merge pull request #61820 from ClickHouse/get-client-http-header
Add a new function `getClientHTTPHeader`
2024-03-25 17:48:24 +03:00
Alexey Milovidov
21a0d17637
Merge branch 'master' into geodistance-double-precision 2024-03-25 17:47:42 +03:00
Alexey Milovidov
d45a6fe9b9 Fix tidy 2024-03-25 15:46:55 +01:00
Pervakov Grigorii
570dc32b07 fix style 2024-03-25 14:09:53 +00:00
Pervakov Grigorii
6b50f5bf10 Reload certificate chain during certificate reload 2024-03-25 14:09:53 +00:00
avogar
192d59e1ff Disable optimize_group_by_function_keys when group_by_use_nulls=1 2024-03-25 14:00:40 +00:00
kssenii
38b15fb2a3 Fix 02494_zero_copy_and_projection_and_mutation_work_together.sql with shared merge tree 2024-03-25 14:59:37 +01:00
Vitaly Baranov
12a7f6afff Fix columns of a materialized views after MODIFY QUERY. 2024-03-25 14:50:36 +01:00
alesapin
d4063e378e
Merge pull request #61554 from ClickHouse/fix_wait_for_mutation_done
Wait for done mutation with more logs and asserts
2024-03-25 14:27:34 +01:00
Nikita Taranov
4e3d4f1c92
Merge branch 'master' into db_on_disk_smth 2024-03-25 14:22:14 +01:00
kssenii
e3d2fb28cf Merge remote-tracking branch 'origin/master' into revert-refert-of-broken-projections-handling 2024-03-25 13:54:39 +01:00
kssenii
513bb7ddbb Minor 2024-03-25 13:54:06 +01:00
Nikolai Kochetov
75150033c8 Cleanup 2024-03-25 12:45:20 +00:00
Nikolai Kochetov
6d5f2cd7b5 Cleanup 2024-03-25 12:44:28 +00:00
Sergei Trifonov
10c6152aac
Merge pull request #61546 from ClickHouse/more-log-for-async-loader
More logging for loading of tables
2024-03-25 13:12:45 +01:00
Yarik Briukhovetskyi
8bdbfce43c
Merge branch 'master' into fix_undrop_query 2024-03-25 13:06:46 +01:00
Yarik Briukhovetskyi
20a45b4073
Merge pull request #61564 from liuneng1994/optimize_in_single_value
New analyzer pass to optimize in single value
2024-03-25 12:53:01 +01:00
kssenii
f7ef5734fa Add more comments 2024-03-25 12:10:26 +01:00
Nikolai Kochetov
abe78e1a7b Merge branch 'master' into fix-virtual-columns-storage-merge-analyzer 2024-03-25 10:43:23 +00:00
Azat Khuzhin
911fab7824 Fix possible connections data-race for distributed_foreground_insert/distributed_background_insert_batch
Previously connection will marked as not in use earlier than
RemoteInserter, while it still may use it and this will lead to crashes,
like in [1].

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/61832/d0cd8d0d7f74ff251d52e1871cba57d26a51873b/stateless_tests_flaky_check__asan_.html

I was able to reproduce the crash locally by running the test
03030_system_flush_distributed_settings in parallel.

Fixes: #45491
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-25 11:25:11 +01:00
Azat Khuzhin
1bfd588035 Remove PoolBase::AllocateNewBypassingPool
The code that it uses had been removed in #58845.
Introduced in #49732

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-25 11:04:05 +01:00
SmitaRKulkarni
a642f4d3ec
Merge pull request #59929 from ClickHouse/Azure_write_buffer
Asynchronous WriteBuffer for AzureBlobStorage
2024-03-25 10:32:56 +01:00
János Benjamin Antal
80a7cda59a Fix style 2024-03-25 09:21:45 +00:00
SmitaRKulkarni
f16dffaefc
Merge pull request #61503 from ClickHouse/Azure_read_buffer
Add support of ParallelReadBuffer to ReadBufferFromAzureBlobStorage
2024-03-25 09:51:59 +01:00
LiuYuan
8e4c25e1c4 Fix RANGE frame is not supported for Nullable columns. 2024-03-25 08:31:46 +00:00
HowePa
d38534e047 add TRUNCATE ALL TABLES 2024-03-25 15:59:15 +08:00
Alexey Milovidov
a600e181ec
Merge branch 'master' into get-client-http-header 2024-03-25 07:23:43 +03:00
Alexey Milovidov
0d1751fd55
Merge pull request #61791 from ClickHouse/enable-output_format_pretty_row_numbers
Enable `output_format_pretty_row_numbers` by default
2024-03-25 06:16:39 +03:00
zhongyuankai
64961edb3f Merge branch 'master' into drop_tables 2024-03-25 11:13:26 +08:00
zhongyuankai
7e264839c9 bug fix 2024-03-25 11:04:12 +08:00
Alexey Milovidov
cbf3b5ea02 Fix error 2024-03-25 03:41:52 +01:00
Alexey Milovidov
d488d4fac5 Remove unused headers 2024-03-25 03:38:47 +01:00
Alexey Milovidov
264b847f1a Fix build 2024-03-25 03:38:47 +01:00
Alexey Milovidov
e3dd42131c Fix build 2024-03-25 03:38:47 +01:00
Alexey Milovidov
4813014710 Merge with master 2024-03-25 03:38:47 +01:00
Alexey Milovidov
3a5ed40eaa Merge with master 2024-03-25 03:38:47 +01:00
Alexey Milovidov
29d51d71b7 Fix the name 2024-03-25 03:38:47 +01:00
Duc Canh Le
271342a871 change column name from duration_ms to duration_us in system.zookeeper
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-03-25 03:38:46 +01:00
Alexey Milovidov
447d202e72
Merge pull request #61849 from ClickHouse/fix-analyzer-shard-offset
Analyzer: fix limit/offset on shards
2024-03-25 05:34:03 +03:00
Alexey Milovidov
f9bff8bd79
Merge pull request #61847 from ClickHouse/fix-distinct-in-subquery-analyzer
Fix: DISTINCT in subquery with analyzer
2024-03-25 05:32:48 +03:00
Alexey Milovidov
8cf4c3bd3f Fix tidy 2024-03-25 03:28:37 +01:00
Alexey Milovidov
3d5908b876 Merge branch 'master' into get-client-http-header 2024-03-25 03:27:18 +01:00
Alexey Milovidov
c7a48f601a More tests 2024-03-25 03:12:11 +01:00
Alexey Milovidov
a2a90467ed Better 2024-03-25 03:11:19 +01:00
Alexey Milovidov
8bf3da136f Merge branch 'master' into geodistance-double-precision 2024-03-25 02:48:27 +01:00
Alexey Milovidov
cd3edf3f5b
Merge pull request #61749 from ClickHouse/pufit/volnitsky-assert-fix
Fix crash in `multiSearchAllPositionsCaseInsensitiveUTF8` for incorrect UTF-8
2024-03-25 04:47:03 +03:00
Alexey Milovidov
8c6a6f2b71
Merge pull request #61832 from azat/dist/flush-settings
Add ability to override initial INSERT SETTINGS via SYSTEM FLUSH DISTRIBUTED
2024-03-25 03:09:01 +03:00
Alexey Milovidov
65f866d2df
Merge branch 'master' into fix-analyzer-shard-offset 2024-03-25 03:04:39 +03:00
Yakov Olkhovskiy
24735354d9 fix add offset step 2024-03-24 23:38:13 +00:00
Alexey Milovidov
4d588c4bbe Merge branch 'master' into enable-output_format_pretty_row_numbers 2024-03-24 23:17:50 +01:00
Alexey Milovidov
65650809b4 Double precision of geoDistance if the arguments are Float64 2024-03-24 23:11:35 +01:00
Igor Nikonov
54c3bde6a7 Fix: DISTINCT in subquery with analyzer
RemoveUnusedProjectionColumnsPass incorrectly removed columns,
unused in outer query, from subqueries with DISTINCT
2024-03-24 21:20:51 +00:00
Dmitry Novik
64301191b1 Merge remote-tracking branch 'origin/master' into enable-analyzer 2024-03-24 21:07:26 +00:00
Alexey Milovidov
baef1cd4d2 Merge branch 'master' into get-client-http-header 2024-03-24 21:37:14 +01:00
Azat Khuzhin
35722be8ec Add ability to override initial INSERT SETTINGS via SYSTEM FLUSH DISTRIBUTED
This is useful to overwrite settings in the initial query during force
flush with SYSTEM FLUSH DISTRIBUTED.

For example imagine that your server is out of queries
(max_max_concurrent_queries_for_all_users had been reached), but you
want to flush the distributed table anyway, after this patch you can
use something like this:

    SYSTEM FLUSH DISTRIBUTED dist SETTINGS max_concurrent_queries_for_all_users=1000000

And also fix flush_on_detach for SYSTEM FLUSH DISTRIBUTED, it should
ignore flush_on_detach.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-24 21:32:34 +01:00
Alexey Milovidov
6323ca0960
Merge pull request #61393 from CurtizJ/fix-nullable-consecutive-keys
Fix consecutive keys optimization for nullable keys
2024-03-24 23:19:22 +03:00
Alexey Milovidov
9210712f4f
Merge pull request #60112 from Unalian/feat-59377
[feature]: allow to attach parts from a different disk
2024-03-24 23:12:43 +03:00
Smita Kulkarni
0d54dbf460 Merge branch 'master' into Azure_write_buffer 2024-03-24 20:09:47 +01:00
Alexey Milovidov
51aada55b1
Merge pull request #61736 from ClickHouse/cucurbita
Fix segfault in SquashingTransform
2024-03-24 22:01:41 +03:00
Alexey Milovidov
bd8dbef9d2
Merge pull request #61827 from azat/better-log-error
Better message for logging errors
2024-03-24 21:58:15 +03:00
pufit
15883a1f20 Merge branch 'refs/heads/master' into pufit/volnitsky-assert-fix 2024-03-24 14:43:14 -04:00
Alexey Milovidov
902cbd0724
Merge pull request #61830 from ClickHouse/remove-unused-code
Remove unused code
2024-03-24 21:02:52 +03:00
Alexey Milovidov
717603802d
Merge pull request #61785 from danipozo/azure-use-managed-identity-for-backups
Use managed identity for backups IO in Azure Blob Storage
2024-03-24 20:31:12 +03:00
vdimir
0e7bedc671
Fix resolvedIdenfiersFromJoinAreEquals function visibility 2024-03-24 17:30:51 +00:00
Alexey Milovidov
233d41d5df Update test 2024-03-24 17:39:47 +01:00
Alexey Milovidov
0067ef0f97
Merge pull request #57857 from canhld94/ch_external_table_enum
Allow declaring enum in external table structure
2024-03-24 19:33:47 +03:00
Alexey Milovidov
8ddfe9a48b
Merge pull request #61665 from ClickHouse/build-improvements-magic-enum-template-instantiation
Build improvements by removing magic enum from header and apply some explicit template instantiation
2024-03-24 19:31:46 +03:00
Alexey Milovidov
93beef8bb5
Merge pull request #61399 from azat/order-by-SimpleAggregateFunction
Forbid SimpleAggregateFunction in ORDER BY of MergeTree tables
2024-03-24 19:31:18 +03:00
Alexey Milovidov
170153ff49 Merge branch 'master' into enable-output_format_pretty_row_numbers 2024-03-24 17:28:23 +01:00
Alexey Milovidov
2796dc7eb1
Merge branch 'master' into dont-cut-single-value 2024-03-24 19:26:29 +03:00
Alexey Milovidov
1bacfaccd4
Merge pull request #61817 from ClickHouse/parquet-orc-arrow-usability
Change defaults of Parquet/ORC/Arrow for better usability
2024-03-24 19:25:34 +03:00
Alexey Milovidov
4db69c36f9 Remove unused code 2024-03-24 17:15:47 +01:00
Alexey Milovidov
5768daf666
Merge pull request #61824 from ClickHouse/remove-datastreams
Remove DataStreams
2024-03-24 19:12:05 +03:00
Azat Khuzhin
adfe1459cf Better message for logging errors
Right now it is possible to get something like this [1]:

    Failed to write a log message: src/Storages/Kafka/KafkaConsumer.cpp:342

Without any details (likely there are some issues with fmt).

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/61526/958659584957ff419a9305d9c7edee5703fedbdc/integration_tests__tsan__[6_6].html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-24 16:40:08 +01:00
kssenii
b87b280e38 Adjust check for duplicate queue entry 2024-03-24 15:15:59 +01:00
alesapin
a41c005a6e
Merge branch 'master' into Azure_write_buffer 2024-03-24 15:04:18 +01:00
alesapin
49f007af60 Merge remote-tracking branch 'origin/master' into fix_wait_for_mutation_done 2024-03-24 13:54:39 +01:00
Nikolai Kochetov
e6242891be Merge branch 'master' into fix-analyzer-group-by-use-nulls 2024-03-24 11:41:14 +00:00
Nikolai Kochetov
ede245e478
Merge pull request #61649 from ClickHouse/fix-00223_shard_distributed_aggregation_memory_efficient-analyzer
Fix 00223_shard_distributed_aggregation_memory_efficient with analyzer
2024-03-24 12:38:46 +01:00
pufit
622b2472b0 Another assertions fix, better initialization 2024-03-23 22:06:04 -04:00
Alexey Milovidov
29a0a657de
Merge pull request #47427 from sunny19930321/add-materialized-view-query-check
Modify materalized view query, check inner table structure
2024-03-24 04:23:49 +03:00
Alexey Milovidov
008c252a26
Merge pull request #61365 from evillique/fix-attach-on-cluster
Fix ATTACH query with external ON CLUSTER
2024-03-24 04:17:42 +03:00
Alexey Milovidov
8936528372 Merge branch 'master' into order-by-SimpleAggregateFunction 2024-03-24 02:16:57 +01:00
Alexey Milovidov
2847b2984f
Update ExternalLoaderStatus.cpp 2024-03-24 04:14:32 +03:00
Alexey Milovidov
46a4307c08 Fix style 2024-03-24 02:11:12 +01:00
Alexey Milovidov
d249d53de6 Remove DataStreams 2024-03-24 02:07:41 +01:00
Alexey Milovidov
df8a6b8d0c Merge branch 'master' into enable-output_format_pretty_row_numbers 2024-03-24 00:58:12 +01:00
Alexey Milovidov
5e83c492d1
Merge pull request #61800 from ClickHouse/output-format-in-client-unification
Unification of handling formats in `clickhouse-client` and `clickhouse-local`
2024-03-24 02:57:01 +03:00
Alexey Milovidov
810c173d35 Merge branch 'master' into parquet-orc-arrow-usability 2024-03-24 00:55:31 +01:00
Alexey Milovidov
08b7dd9591 Merge branch 'master' into get-client-http-header 2024-03-24 00:54:25 +01:00
Alexey Milovidov
3e5ddddb35 Merge branch 'master' into dont-cut-single-value 2024-03-24 00:51:10 +01:00
Alexey Milovidov
5651c187cc
Merge pull request #61770 from yariks5s/add_current_user_mysql_alias
Add `current_user` alias
2024-03-24 01:51:18 +03:00
Alexey Milovidov
ae8c9caa67 Merge branch 'master' into enable-output_format_pretty_row_numbers 2024-03-23 23:44:52 +01:00
Alexey Milovidov
83ad0b85e5
Merge pull request #61802 from ClickHouse/underscore_digit_groups
Underscore digit groups in Pretty formats
2024-03-24 00:30:20 +03:00
kssenii
b91184219d SLRU: disallow concurrent priority increase if there is unfinished space reservation 2024-03-23 22:29:29 +01:00
Alexey Milovidov
78d3351552 Add function getClientHTTPHeader, part 3 2024-03-23 21:48:28 +01:00
Alexey Milovidov
965a3ac2f3 Add function getClientHTTPHeader, part 2 2024-03-23 21:19:35 +01:00
Alexey Milovidov
e195806c5b Add function getClientHTTPHeader, part 1 2024-03-23 20:52:26 +01:00
Alexey Milovidov
aeefba57b5
Update StorageAzureBlob.cpp 2024-03-23 22:49:23 +03:00
Alexey Milovidov
4d4c8f709c Merge branch 'master' into enable-output_format_pretty_row_numbers 2024-03-23 19:53:52 +01:00
Alexey Milovidov
2982abfde0 Merge branch 'master' into parquet-orc-arrow-usability 2024-03-23 19:48:22 +01:00
Alexey Milovidov
66ad264f05 Merge branch 'master' into dont-cut-single-value 2024-03-23 19:46:40 +01:00
Alexey Milovidov
229d12e0de
Merge pull request #61794 from ClickHouse/fix-bad-numbers-pretty-printing
Fix bad numbers pretty printing
2024-03-23 21:46:18 +03:00
vdimir
adbc9c66e9
fix infinite loop in ReplaceColumnsVisitor #ci_set_analyzer 2024-03-23 18:34:20 +00:00
Alexey Milovidov
13b4a2838c
Update StorageReplicatedMergeTree.cpp 2024-03-23 21:26:23 +03:00
Alexey Milovidov
25201919a5 Fix errors 2024-03-23 19:23:01 +01:00
Alexey Milovidov
a5dc6241bb
Update StorageMaterializedView.cpp 2024-03-23 21:10:42 +03:00
Alexey Milovidov
7c189ee94a
Merge branch 'master' into add-materialized-view-query-check 2024-03-23 21:07:58 +03:00
Alexey Milovidov
056c8ce021
Merge pull request #59965 from nickitat/express_support
S3Express support
2024-03-23 20:52:44 +03:00
Antonio Andelic
61e74cc2df
Merge pull request #61752 from ClickHouse/keeper-destroy-dispatcher-first
Keeper fix: destroy `KeeperDispatcher` first
2024-03-23 18:51:32 +01:00
Alexey Milovidov
e84ca3134d Merge branch 'master' into dont-cut-single-value 2024-03-23 18:45:07 +01:00
Alexey Milovidov
b971a8f26f
Merge pull request #61773 from Algunenano/trash_templates_2
FunctionsConversion: Remove another batch of bad templates
2024-03-23 20:38:16 +03:00
Alexey Milovidov
02ccefdca9 Merge branch 'master' into dont-cut-single-value 2024-03-23 18:16:57 +01:00
Alexey Milovidov
8c229565b7 Merge branch 'master' into underscore_digit_groups 2024-03-23 18:13:50 +01:00
Alexey Milovidov
7499922299 Merge branch 'master' into output-format-in-client-unification 2024-03-23 18:07:10 +01:00
Alexey Milovidov
d0a0141a47 Change defaults of Parquet/ORC/Arrow 2024-03-23 17:39:04 +01:00
robot-ch-test-poll
5e51880750
Merge pull request #61789 from ClickHouse/vdimir/analyzer_join_distributed_assert
Analyzer: Fix assert in JOIN with Distributed table
2024-03-23 17:14:18 +01:00
Alexey Milovidov
616046db63 Merge branch 'master' into enable-output_format_pretty_row_numbers 2024-03-23 16:50:12 +01:00
Alexey Milovidov
d76fc0940a Merge branch 'fix-bad-numbers-pretty-printing' into dont-cut-single-value 2024-03-23 16:47:44 +01:00
Alexey Milovidov
93d5e96b2b Merge branch 'master' into fix-bad-numbers-pretty-printing 2024-03-23 16:43:28 +01:00
Alexey Milovidov
b2ebaa1d6c
Merge pull request #61798 from ClickHouse/clang-19-2
Updated clang-19 to master.
2024-03-23 18:42:15 +03:00
vdimir
44f1f62904
fix ReplaceColumnsVisitor #ci_set_analyzer 2024-03-23 15:20:01 +00:00
kssenii
d3c6836e2b More logging 2024-03-23 12:25:16 +01:00
vdimir
ee7d1cf7d9
another fix prewhere on join using column that changed type to supertype
tag: #ci_set_analyzer
2024-03-23 11:05:20 +00:00
Smita Kulkarni
19e7022a87 Merge branch 'master' into Azure_write_buffer 2024-03-23 11:48:10 +01:00
Smita Kulkarni
a8238ded09 Merge branch 'master' into Azure_read_buffer 2024-03-23 11:46:32 +01:00
Alexey Milovidov
c6004cc742 Fix error 2024-03-23 04:57:32 +01:00
Alexey Milovidov
fa3c9dc664 Merge branch 'fix-bad-numbers-pretty-printing' into dont-cut-single-value 2024-03-23 04:57:08 +01:00
Alexey Milovidov
c88c36b253 Merge branch 'clang-19-2' into dont-cut-single-value 2024-03-23 04:56:09 +01:00
Alexey Milovidov
4bc2bc67be Merge branch 'clang-19-2' into fix-bad-numbers-pretty-printing 2024-03-23 04:54:10 +01:00
Alexey Milovidov
f721141c73 Merge branch 'clang-19-2' into output-format-in-client-unification 2024-03-23 04:53:38 +01:00
Alexey Milovidov
f67b8c1258 Merge branch 'clang-19-2' into underscore_digit_groups 2024-03-23 04:53:22 +01:00
Alexey Milovidov
2fae677a85 Merge branch 'clang-19-2' into enable-output_format_pretty_row_numbers 2024-03-23 04:53:03 +01:00
Alexey Milovidov
9d51f014c2 Fix error 2024-03-23 04:52:45 +01:00
Alexey Milovidov
b84772a6a6
Merge pull request #61797 from ClickHouse/output-format-in-client
Support for `--output-format` in client
2024-03-23 06:47:32 +03:00
Alexey Milovidov
d599ecdfdd Fix error 2024-03-23 04:41:07 +01:00
Alexey Milovidov
492052f0cc Merge branch 'clang-19-2' into enable-output_format_pretty_row_numbers 2024-03-23 04:23:05 +01:00
Alexey Milovidov
aad03fbd9e Merge branch 'clang-19-2' into fix-bad-numbers-pretty-printing 2024-03-23 04:22:44 +01:00
Alexey Milovidov
ef9ef9f2d7 Fix error 2024-03-23 04:21:25 +01:00
Alexey Milovidov
cd8cdb480a Fix error 2024-03-23 04:21:06 +01:00
Alexey Milovidov
4cbecd0bbd Add a setting 2024-03-23 04:20:52 +01:00
Alexey Milovidov
a1a6ed1725 Merge branch 'clang-19-2' into underscore_digit_groups 2024-03-23 03:36:49 +01:00
Alexey Milovidov
a2e89c8be7 Fix wrong cases of numbers pretty printing
Add a test

Revert changes from another branch

Add a test

Better test

Revert wrong changes
2024-03-23 03:33:03 +01:00
Alexey Milovidov
a75e9b50c9 Merge branch 'clang-19-2' into output-format-in-client-unification 2024-03-23 03:29:05 +01:00
Alexey Milovidov
f427f8f79a Merge branch 'clang-19-2' into fix-bad-numbers-pretty-printing 2024-03-23 03:28:48 +01:00
Alexey Milovidov
2df466e271 Merge branch 'clang-19-2' into enable-output_format_pretty_row_numbers 2024-03-23 03:27:24 +01:00
Alexey Milovidov
a0bde74acb Fix style 2024-03-23 03:26:59 +01:00
Alexey Milovidov
465b0c16cd Better row numbers 2024-03-23 03:10:14 +01:00
Alexey Milovidov
e334c847fd Merge branch 'clang-19-2' into enable-output_format_pretty_row_numbers 2024-03-23 02:57:27 +01:00
Alexey Milovidov
487ac4c828 Fix tests 2024-03-23 02:50:00 +01:00
Alexey Milovidov
2758bb3883 Merge branch 'clang-19-2' into fix-bad-numbers-pretty-printing 2024-03-23 02:45:16 +01:00
Alexey Milovidov
c0c8cdc185 Add modifications 2024-03-23 02:42:22 +01:00
Alexey Milovidov
3af42e9194 Merge branch 'clang-19-2' into output-format-in-client-unification 2024-03-23 02:19:00 +01:00
Alexey Milovidov
32dbace6a0 Merge branch 'master' into output-format-in-client 2024-03-23 01:49:46 +01:00
Alexey Milovidov
7365f4e32b Add modifications 2024-03-23 01:43:28 +01:00
Alexey Milovidov
46e5a7060b Fix error and remove garbage 2024-03-23 01:30:12 +01:00
Alexander Tokmakov
ace983f3d5 skip more sanity checks for secondary create queries 2024-03-23 00:03:31 +01:00
Alexey Milovidov
a56c113c83 Fix for clang-19 2024-03-22 22:12:59 +01:00
Alexey Milovidov
14c616e696 Fix for clang-19 2024-03-22 21:29:42 +01:00
Alexey Milovidov
bf6d15dceb
Merge branch 'master' into log_processors_profiles 2024-03-22 23:26:28 +03:00
Alexey Milovidov
3200aa3bcb
Merge pull request #61622 from YenchangChan/copy_s3_file
Remove duplicate code in copyS3File.cpp
2024-03-22 23:24:50 +03:00
vdimir
a1036075e0
Merge branch 'master' into vdimir/using_alias_followup 2024-03-22 20:16:26 +00:00
vdimir
5b7a3c276b
fix prewhere on join using column that changed type to supertype 2024-03-22 20:15:08 +00:00
Alexey Milovidov
18c016caaa Support for --output-format in client 2024-03-22 21:06:36 +01:00
Michael Kolupaev
84daaa1c7e Style 2024-03-22 20:00:42 +00:00
Michael Kolupaev
8751737c68
Fix DWARF format failing to skip DW_FORM_strx3 attributes (#61737) 2024-03-22 12:59:21 -07:00
Alexey Milovidov
4621fe6115 Fix wrong cases of numbers pretty printing 2024-03-22 20:22:18 +01:00
Alexey Milovidov
ada32a433a Enable output_format_pretty_row_numbers by default 2024-03-22 19:51:47 +01:00
Nikolai Kochetov
dd87e5793f Merge branch 'master' into fix-analyzer-group-by-use-nulls 2024-03-22 18:24:02 +00:00
vdimir
f54e11176d
u 2024-03-22 18:12:31 +00:00
Nikolai Kochetov
b2ae11d6b6 Fixing tests. 2024-03-22 17:49:01 +00:00
vdimir
edc9e8fbc8
Analyzer: Fix assert in JOIN with Distributed table 2024-03-22 17:30:50 +00:00
kssenii
b69e4541b9 Unify code in SLRU 2024-03-22 18:06:46 +01:00
Nikolai Kochetov
41d9b19a4a
Merge pull request #61059 from ClickHouse/fix-parallel-replicas-explain-syntax-crash
Fix: parallel replicas with CTEs, crash in EXPLAIN SYNTAX with analyzer
2024-03-22 18:06:30 +01:00
Dani Pozo
2736b4ef64 Use managed identity for backups IO in Azure Blob Storage
Also adds option to prevent ClickHouse from trying to create a non-existing container, which requires
a role assignment at the storage account level.
2024-03-22 17:58:07 +01:00
Nikolai Kochetov
cf91d5dcbc FIx 2024-03-22 16:57:42 +00:00
Raúl Marín
9b96e45af4 Merge remote-tracking branch 'blessed/master' into trash_templates_2 2024-03-22 17:56:05 +01:00
Raúl Marín
2377b1eb29 FML 2024-03-22 17:55:50 +01:00
Nikolai Kochetov
5207526910 Fix more tests with wirtual columns in StorageMerge. 2024-03-22 16:55:01 +00:00
kssenii
e91dc87f82 Speed up dynamic resize of filesystem cache 2024-03-22 17:26:12 +01:00
Nikolay Degterinsky
83ccd2a144 Merge remote-tracking branch 'upstream/master' into fix-attach-on-cluster 2024-03-22 16:06:01 +00:00
avogar
47095f63b1 Fix writing exception message in output format in HTTP when http_wait_end_of_query is used 2024-03-22 16:03:28 +00:00
pufit
165022e88b fix 2024-03-22 12:01:18 -04:00