Commit Graph

107049 Commits

Author SHA1 Message Date
Azat Khuzhin
6587d11885 Check return value of close() in self-extracting-executable
And also add description into perror() over callign simply
perror(nullptr).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 11:28:22 +01:00
Azat Khuzhin
8cc41b7f41 Check return value of ::close()
Note, that according close(2), EINTR should not be retriable for close()

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 11:28:22 +01:00
Azat Khuzhin
0ab351c82e Add close() return value check in check-style
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-06 20:20:15 +01:00
Azat Khuzhin
fc48f89b76 Improve chassert() macro to suppress warning in release builds
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-06 20:13:17 +01:00
Azat Khuzhin
e83163e25f Add sanity check of evtimer_del() in QueryProfiler
Saw this one time on CI with EINVAL [1], while this was EINVAL this
time, next time it can be completelly different fd and break something
in a different place.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/45654/1716af465d376f5335720b5045bcccdd9e1823aa/fast_test.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-06 20:13:05 +01:00
Kseniia Sumarokova
38c001ca42
Merge pull request #45957 from xiedeyantu/s3_file_not_found
Throw an error on no files satisfying S3 wildcard
2023-02-06 12:32:12 +01:00
alesapin
d50d442c7a
Merge pull request #46036 from ClickHouse/keeper-systemd
Add checks for installable packages to workflows
2023-02-06 12:29:14 +01:00
Alexander Gololobov
a784750e66
Merge pull request #45949 from bigo-sg/improve_decimal
Improve performance of ColumnArray::filter/replicate  for big int and decimal
2023-02-06 12:27:19 +01:00
Alexander Gololobov
d18364476d
Merge pull request #46047 from azat/system.processes-elapsed-fix
Fix elapsed column in system.processes (10x error)
2023-02-06 12:26:05 +01:00
Vladimir C
5686703e79
Merge pull request #46053 from ucasfl/json-columns
Closes https://github.com/ClickHouse/ClickHouse/issues/46024
2023-02-06 12:22:13 +01:00
Robert Schulze
fa131edba5
Merge pull request #46057 from k-morozov/refactoring/multiversion-atomic-functions
MultiVersion: change mutex to lock-free
2023-02-06 11:55:27 +01:00
Vladimir C
e3712bb2c6
Merge pull request #45961 from ClickHouse/vdimir/sparkbar-fix 2023-02-06 11:52:15 +01:00
Maksim Kita
083732c5d6
Merge pull request #46011 from kitaisreal/analyzer-limit-offset-test-rename
Analyzer limit offset test rename
2023-02-06 12:45:33 +03:00
Antonio Andelic
61ddae6c2f
Merge pull request #46041 from azat/ci/improve-integration-sanitizer-report
Dump sanitizer errors in the integration tests logs
2023-02-06 09:42:26 +01:00
Antonio Andelic
94309db1af
Merge pull request #46000 from azat/fuzzy-search-case
Use "exact" matching for fuzzy search
2023-02-06 09:14:40 +01:00
李扬
444373679a
Merge branch 'master' into improve_decimal 2023-02-06 13:08:51 +08:00
Kseniia Sumarokova
c4f4a1db35
Merge pull request #46052 from ClickHouse/kssenii-patch-6
Temporarily disable one rabbitmq flaky test
2023-02-05 22:33:05 +01:00
Robert Schulze
4a328828b5
Merge pull request #45758 from ClickHouse/qc-max_cache_size
Make Query Cache server-level settings reconfigurable at runtime
2023-02-05 21:55:37 +01:00
Han Fei
532b341de9
Merge pull request #45975 from ucasfl/_part
use LowCardnality for _part and _partition_id virtual column
2023-02-05 18:00:46 +01:00
Robert Schulze
9b841d67e8
Merge remote-tracking branch 'origin/master' into qc-max_cache_size 2023-02-05 16:47:02 +00:00
Robert Schulze
0dae64fe54
Merge pull request #45258 from ClibMouse/openssl_encryption
Add encryption support to OpenSSL
2023-02-05 17:36:42 +01:00
Konstantin Morozov
ff05162904 change mutex to lock-free 2023-02-05 19:25:09 +03:00
flynn
f89a6cf68d Improve format JSONColumns when result is empty 2023-02-05 13:13:21 +00:00
robot-clickhouse
fb288ad5f7 Automatic style fix 2023-02-05 11:58:51 +00:00
Kseniia Sumarokova
7a11b37dae
Update test.py 2023-02-05 12:54:03 +01:00
Azat Khuzhin
5f36f71729 Cover system.processes.elapsed
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-04 22:53:16 +01:00
Azat Khuzhin
1307e6d323 Fix elapsed column in system.processes (10x error)
Fixes: #43455 (cc @Algunenano)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-04 22:37:11 +01:00
bkuschel
1f3b1c697f
Add newline 2023-02-04 15:39:28 -05:00
bkuschel
dc995f7c67
Fix size,free ctx,formatting 2023-02-04 15:03:04 -05:00
Boris Kuschel
d9f3698a43
Fix copy/pasta 2023-02-04 14:59:47 -05:00
Boris Kuschel
1d4cf4fe69
Add encryption support with openssl 2023-02-04 14:59:34 -05:00
xiedeyantu
f13eedd644 change settings name 2023-02-04 22:11:14 +08:00
Azat Khuzhin
177c98b6a9 Use "exact" matching for fuzzy search
Right now fuzzy search is too smart for SQL, it even takes into account
the case, which should not be accounted (you don't want to type "SELECT"
instead of "select" to find the query).

And to tell the truth, I think too smart fuzzy searching for SQL queries
is not required, and is only harming.

Exact matching seems better algorithm for SQL, it is not 100% exact, it
splits by space, and apply separate matcher actually for each word.
Note, that if you think that "space is not enough" as the delimiter,
then you should first know that this is the delimiter only for the
input query, so to match "system.query_log" you can use "sy qu log"
(also you can disable exact mode by prepending "'" char).

But it ignores the case by default, and the behaviour what is expected
from the CaseMatching::Ignore.

TL;DR;

Just for the history I will describe what had been tried.

At first I tried CaseMatching::Ignore - it does not helps for
SkimV1/SkimV2/Clangd matches.

So I converted lines from the history and input query, to the lower
case. However this does not work for UPPER CASE, since only initial
portion of the query had been converted to the lower.

Then I've looked into skim/fuzzy-matcher crates code, and look for the
reason why CaseMatching::Ignore does not work, and found that there is
still a penalty for case mismatch, but there is no way to pass it from
the user code, so I've tried guerrilla to monkey patch the library's
code and it works:

    // Avoid penalty for case mismatch (even with CaseMatching::Ignore)
    let _guard = guerrilla::patch0(SkimScoreConfig::default, || {
        let score_match = 16;
        let gap_start = -3;
        let gap_extension = -1;
        let bonus_first_char_multiplier = 2;

        return SkimScoreConfig{
            score_match,
            gap_start,
            gap_extension,
            bonus_first_char_multiplier,
            bonus_head: score_match / 2,
            bonus_break: score_match / 2 + gap_extension,
            bonus_camel: score_match / 2 + 2 * gap_extension,
            bonus_consecutive: -(gap_start + gap_extension),
            // penalty_case_mismatch: gap_extension * 2,
            penalty_case_mismatch: 0,
        };
    });

But this does not sounds like a trivial code, so I decided, to look
around, and realized that "exact" matching should do what is required
for the completion of queries (at least from my point of view).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-04 14:15:02 +01:00
李扬
ad6f39389d
Update tests/performance/column_array_filter.xml
Co-authored-by: Alexander Gololobov <440544+davenger@users.noreply.github.com>
2023-02-04 18:49:13 +08:00
Azat Khuzhin
0a598c79f4 Remove misleading information that sanitizer errors are in the docker.log
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-04 11:23:26 +01:00
Azat Khuzhin
88dc85e13e Dump sanitizer errors in the integration tests logs
Previously you need to download the artifacts (0.5G+-), or reproduce the
problem.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-04 11:23:26 +01:00
Alexey Milovidov
496cacf25e
Merge pull request #45985 from ClickHouse/fix-crash-in-regression
Fix crash in stochasticLinearRegression.
2023-02-04 03:01:46 +01:00
Alexey Milovidov
22bd0b6f69
Merge pull request #38983 from CurtizJ/randomize-mt-settings
Allow to randomize merge tree settings in tests
2023-02-04 02:59:52 +01:00
Mikhail f. Shiryaev
0c8c04090c
Add checks for installable packages to workflows 2023-02-03 23:40:56 +01:00
Mikhail f. Shiryaev
cd2e1cfada
Merge pull request #45568 from ClickHouse/keeper-systemd
Add systemd.service for clickhouse-keeper
2023-02-03 23:08:02 +01:00
Dan Roscigno
ed6c884083
Merge pull request #46023 from DanRoscigno/fix-headingsincomparison-docs
fix heading level on comparison page
2023-02-03 14:14:25 -05:00
DanRoscigno
8464357bca fix heading level 2023-02-03 13:57:47 -05:00
vdimir
e175b72d79
Update ru doc for sparkbar function 2023-02-03 17:25:28 +00:00
vdimir
6e0d5e4150
Update doc for sparkbar function 2023-02-03 17:23:10 +00:00
vdimir
18e699f459
Add testcases to 02016_aggregation_spark_bar 2023-02-03 17:22:32 +00:00
vdimir
1e45033531
Update AggregateFunctionSparkbar 2023-02-03 17:22:08 +00:00
Alexander Tokmakov
fa620cc927
Merge pull request #45459 from FrankChen021/stack_trace_in_part_log
Save exception stack trace in part_log
2023-02-03 20:05:35 +03:00
Alexander Tokmakov
3f11948bb0
Merge branch 'master' into stack_trace_in_part_log 2023-02-03 20:05:00 +03:00
Alexander Tokmakov
7e6f7c79f2
Merge pull request #45457 from FrankChen021/exception_time
Add last_exception_time to replication_queue
2023-02-03 20:00:15 +03:00
vdimir
c6e473a66a
Canonize 02016_aggregation_spark_bar 2023-02-03 16:55:57 +00:00