Commit Graph

16391 Commits

Author SHA1 Message Date
Nikita Vasilev
84261a2072 fix test 2019-02-06 13:41:43 +03:00
Nikita Vasilev
abcfb53805 fixed minmax tests 2019-02-06 13:11:49 +03:00
Nikita Vasilev
76a35b43e4 moved tests 2019-02-06 12:12:47 +03:00
Nikita Vasilev
28870b4d50 fixed indices register 2019-02-06 12:05:05 +03:00
Nikita Vasilev
fa1e46f8a7 granularity 2019-02-06 11:43:54 +03:00
Nikita Vasilev
e3879c0933 fix 2019-02-06 11:24:16 +03:00
Nikita Vasilev
c3f7344824 style 2019-02-06 11:17:57 +03:00
Nikita Vasilev
258367c1dd ASTs 2019-02-06 10:51:35 +03:00
Nikita Vasilev
ef154a4bb2 r fix 2019-02-06 10:49:18 +03:00
Mihail Fandyushin
60cd766623 fixed clang build; added new line 2019-02-06 09:05:41 +03:00
Mikhail Fandyushin
1ee18203ae handle brotli errors; working wersion of BrotliReadBuffer 2019-02-06 02:12:31 +03:00
Maxim Akhmedov
6d5c0bdf91 Merge remote-tracking branch 'upstream/master' into useful_what_in_exceptions 2019-02-05 23:53:34 +03:00
alexey-milovidov
7012eb63d4
Merge pull request #4280 from yandex/numbers-table-function-zero
Fixed table function numbers with zero argument
2019-02-05 22:34:28 +03:00
Nikita Vasilev
9eaabcbf3f Merge remote-tracking branch 'upstream/master' into nikvas0/index_fix 2019-02-05 22:19:47 +03:00
alexey-milovidov
fda5aa31c2
Merge pull request #4279 from 4ertus2/joins
hotfix for duplicates in JOIN ON
2019-02-05 22:07:10 +03:00
Nikita Vasilev
9921fc6719 removed toString 2019-02-05 21:46:35 +03:00
Nikita Vasilev
3bea03529b fixed bug in unique_index 2019-02-05 21:34:10 +03:00
Alexey Zatelepin
8e437b191e try executing other mutations immediately after KILL MUTATION [#CLICKHOUSE-3912] 2019-02-05 21:09:16 +03:00
Alexey Zatelepin
1bf4174ec1 check readonly when executing KILL QUERY [#CLICKHOUSE-3912] 2019-02-05 21:09:16 +03:00
Alexey Zatelepin
4b4539139b use enum for KILL query type [#CLICKHOUSE-3912] 2019-02-05 21:09:16 +03:00
Alexey Zatelepin
d482f3e5d0 return CancellationCode from killMutation [#CLICKHOUSE-3912] 2019-02-05 21:09:15 +03:00
Alexey Zatelepin
e32f153328 KILL MUTATION for StorageReplicatedMergeTree [#CLICKHOUSE-3912] 2019-02-05 21:09:15 +03:00
Alexey Zatelepin
059c1b3589 write part_log.partition_id everywhere 2019-02-05 21:09:15 +03:00
Alexey Zatelepin
ca93fd483a kill ordinary MergeTree mutations [#CLICKHOUSE-3912] 2019-02-05 21:09:10 +03:00
Alexey Zatelepin
5832e474a4 is_mutation flag in system.merges [#CLICKHOUSE-3912] 2019-02-05 21:09:05 +03:00
Alexey Zatelepin
92a4342c31 system.merges element for mutations [#CLICKHOUSE-3912] 2019-02-05 21:09:00 +03:00
Alexey Zatelepin
51017959f2 fix typo in calculation of part_log.rows_read 2019-02-05 21:09:00 +03:00
Alexey Zatelepin
59bbd8c8dc refactor InterpreterKillQuery a bit [#CLICKHOUSE-3912] 2019-02-05 21:08:55 +03:00
Alexey Zatelepin
67be566325 KILL MUTATION skeleton [#CLICKHOUSE-3912] 2019-02-05 21:08:41 +03:00
Alexey Milovidov
607951895a Fixed table function numbers with zero argument #4276 2019-02-05 20:05:33 +03:00
Maxim Akhmedov
4dfce303fb Remove e.what() from exception message for DB::Exception. 2019-02-05 20:02:05 +03:00
chertus
396d4fb921 hotfix for duplicates in JOIN ON #4271 2019-02-05 19:58:57 +03:00
Alexey Milovidov
9dd2e75b71 Fixed warnings in clang 8 #4143 2019-02-05 19:43:52 +03:00
Nikita Vasilev
89913b9188 fix 2019-02-05 18:22:47 +03:00
Nikita Vasilev
a1b0dede07 Data Skipping Indices (#4143)
* made index parser

* added index parsing

* some fixes

* added index interface and factory

* fixed compilation

* ptrs

* added indexParts

* indextypes

* index condition

* IndexCondition

* added indexes in selectexecutor

* fix

* changed comment

* fix

* added granularity

* comments

* fix

* fix

* added writing indexes

* removed indexpart class

* fix

* added setSkipIndexes

* add rw for MergeTreeIndexes

* fixes

* upd error

* fix

* fix

* reading

* test index

* fixed nullptr error

* fixed

* fix

* unique names

* asts -> exprlist

* minmax index

* fix

* fixed select

* fixed merging

* fixed mutation

* working minmax

* removed test index

* fixed style

* added indexes to checkDataPart

* added tests for minmax index

* fixed constructor

* fix style

* fixed includes

* fixed setSkipIndexes

* added indexes meta to zookeeper

* added parsing

* removed throw

* alter cmds parse

* fix

* added alter

* fix

* alters fix

* fix alters

* fix "after"

* fixed alter

* alter fix + test

* fixes

* upd setSkipIndexes

* fixed alter bug with drop all indices

* fix metadata editing

* new test and repl fix

* rm test files

* fixed repl alter

* fix

* fix

* indices

* MTReadStream

* upd test for bug

* fix

* added useful parsers and ast classes

* fix

* fix comments

* replaced columns

* fix

* fixed parsing

* fixed printing

* fix err

* basic IndicesDescription

* go to IndicesDescr

* moved indices

* go to indicesDescr

* fix test minmax_index*

* fixed MT alter

* fixed bug with replMT indices storing in zk

* rename

* refactoring

* docs ru

* docs ru

* docs en

* refactor

* rename tests

* fix docs

* refactoring

* fix

* fix

* fix

* fixed style

* unique idx

* unique

* fix

* better minmax calculation

* upd

* added getBlock

* unique_condition

* added termForAST

* unique

* fixed not

* uniqueCondition::mayBeTrueOnGranule

* fix

* fixed bug with double column

* is always true

* fix

* key set

* spaces

* test

* tests

* fix

* unique

* fix

* fix

* fixed bug with duplicate column

* removed unused data

* fix

* fixes

* __bitSwapLastTwo

* fix
2019-02-05 17:50:25 +03:00
Nikita Vasilev
263b390c52 removed unnecessary actions 2019-02-05 16:59:43 +03:00
Nikita Vasilev
87a80a4361 fixed create as 2019-02-05 16:52:45 +03:00
Alexey Zatelepin
1512e17ab8 info about failed parts for ReplicatedMergeTree [#CLICKHOUSE-3912] 2019-02-05 16:37:16 +03:00
Alexey Zatelepin
b8ee63fa3a save information about failed parts for ordinary MergeTree mutations [#CLICKHOUSE-3192] 2019-02-05 16:04:58 +03:00
alesapin
abf58cf0a0
Merge pull request #4270 from yandex/try-to-fix-flap-insert_into_distributed
Increase timeout in intergration test to avoid flap
2019-02-05 15:08:42 +03:00
Nikolai Kochetov
a249fc7788 Do nut use Arena in ColumnsHashing for string in functions arrayUniq and arrayEnumerate. 2019-02-05 14:14:09 +03:00
Nikolai Kochetov
44a46825d0 Added perftest for ColumnsHashing. 2019-02-05 13:55:08 +03:00
Nikolai Kochetov
daa051b1f8 Fix tests. 2019-02-05 13:55:34 +03:00
Nikolai Kochetov
91c63c201c Delete commented code. 2019-02-05 13:55:08 +03:00
Nikolai Kochetov
1644349342 Refactor arrayEnumerateUniq using ColumnsHashing. 2019-02-05 13:55:25 +03:00
Nikolai Kochetov
df3ec47e1d Implemented sets using ColumnsHashing. 2019-02-05 13:55:08 +03:00
Nikolai Kochetov
3afc0c8108 Disable prev key optimization for string keys. 2019-02-05 13:55:08 +03:00
Nikolai Kochetov
264da7f9d3 Implemented sets using ColumnsHashing. 2019-02-05 13:55:15 +03:00
Nikolai Kochetov
10b49f3a74 Removed old key getters from Join. 2019-02-05 13:55:08 +03:00
Nikolai Kochetov
8db4116464 Update HashMethodHashed. 2019-02-05 13:55:08 +03:00
Ivan Lezhankin
8c640f54f8 Fix clang-7 warnings 2019-02-05 13:19:34 +03:00
alesapin
edf0344d0e Increase timeout 2019-02-05 13:15:14 +03:00
Alexey Milovidov
29c3195742 Removed bad code; fixed error 2019-02-05 02:18:04 +03:00
Mikhail Fandyushin
7e9e34bebf WIP: Reading brotli encoded HTTP messages. First-draft-ugly implementation, but its works 2019-02-05 01:15:08 +03:00
Alexey Milovidov
26f406c886 Merge branch 'master' of github.com:yandex/ClickHouse into dictionaries-user-profile 2019-02-05 00:57:39 +03:00
Alexey Milovidov
2556a96e9e Fixed race condition in test #4213 2019-02-05 00:38:23 +03:00
alexey-milovidov
23ad22b8a1
Merge pull request #4254 from yandex/fix-system-log-create-on-shutdown
Fixed weird behaviour of system logs
2019-02-05 00:11:36 +03:00
alexey-milovidov
f2c95bf243
Merge pull request #4266 from 4ertus2/cross
CROSS to INNER JOIN (analyze expressions)
2019-02-05 00:10:51 +03:00
DarkWanderer
6e92183854 Fixed format export test, fixed clang compilation 2019-02-04 22:59:59 +03:00
Alexey Milovidov
b186861ef7 Fixed error message 2019-02-04 22:50:21 +03:00
Alexey Milovidov
b0efd6089c Removed preemptive load of external dictionaries in presence of Dictionary database 2019-02-04 22:45:22 +03:00
Alexey Milovidov
1639711364 Merge branch 'master' of github.com:yandex/ClickHouse into dictionaries-user-profile 2019-02-04 22:07:28 +03:00
Alexey Milovidov
f4ee9f4db8 Merge branch 'master' of github.com:yandex/ClickHouse into fix-system-log-create-on-shutdown 2019-02-04 22:02:10 +03:00
alexey-milovidov
143f14cd64
Merge pull request #4261 from yandex/fix-bad-query-id-in-log
Fixed bad code for printing query_id in text logs
2019-02-04 22:01:09 +03:00
alexey-milovidov
d5fcc905f6
Merge pull request #4264 from yandex/run_queries_by_indexes_in_perf_test
Add ability to run queries by indexes
2019-02-04 22:00:46 +03:00
Alexey Milovidov
00ea27db79 Fixed test #4213 2019-02-04 21:55:43 +03:00
Alexey Milovidov
b44fbdd855 Fixed test #4213 2019-02-04 21:55:06 +03:00
Alexey Milovidov
fbe04a3c47 Merge branch 'master' of github.com:yandex/ClickHouse into dictionaries-user-profile 2019-02-04 21:47:36 +03:00
alexey-milovidov
7ac98850c4
Merge pull request #4262 from abyss7/fix-summingMergeTree-test
Round selected results in tests
2019-02-04 21:45:44 +03:00
chertus
27ba299c95 CROSS to INNER JOIN (analyze expressions) 2019-02-04 21:45:31 +03:00
alesapin
e1f4e02766 Add ability to run queries by indexes 2019-02-04 20:37:55 +03:00
Ivan Lezhankin
994926e568 Merge remote-tracking branch 'upstream/master' into CLICKHOUSE-3729 2019-02-04 20:13:50 +03:00
Ivan Lezhankin
764629a0d6 Round selected results in tests
to address the test flakiness problem.
2019-02-04 19:46:38 +03:00
Alexey Milovidov
28114b4419 Merge branch 'master' into dictionaries-user-profile 2019-02-04 19:26:38 +03:00
alexey-milovidov
2216250a84
Merge pull request #4238 from Quid37/yandex_open_code_competition
Implement Shannon entropy aggregate function
2019-02-04 18:43:29 +03:00
Alexey Milovidov
5fcc02bab2 Fixed bad code for printing query_id in text logs 2019-02-04 18:39:08 +03:00
Maxim Akhmedov
d67a3a901e Make exception.what() less useless. 2019-02-04 17:36:09 +03:00
alexey-milovidov
39f8eb571f
Merge pull request #4213 from nvartolomei/nv/http-cancel
Cancel http read only queries if client socket goes away
2019-02-04 17:33:47 +03:00
Alexey Milovidov
94bfad2cfa Merge branch 'clickhouse_server_version_option' of https://github.com/k-lopatin/ClickHouse into k-lopatin-clickhouse_server_version_option 2019-02-04 17:16:13 +03:00
Alexey Milovidov
fe94a15092 Merge branch 'master' into dictionaries-user-profile 2019-02-04 17:11:53 +03:00
Alexey Milovidov
a4d1cacea8 Fixed weird behaviour of system logs [#CLICKHOUSE-4275] 2019-02-04 17:08:39 +03:00
Nikita Vasilev
5a7ca354a5 unknown field 2019-02-04 16:42:13 +03:00
Nicolae Vartolomei
9d5d0a9200
Add test for cancel_http_readonly_queries_on_client_close setting 2019-02-04 13:10:23 +00:00
alexey-milovidov
a29385108a
Update Server.cpp 2019-02-04 15:49:54 +03:00
Nikita Vasilev
fa07d1cf86 replace andBit 2019-02-04 13:42:30 +03:00
Vasily Nemkov
2716df8ab2 IPv4 and IPv6 Domain implementation.
Added:
 * IDataTypeDomain interface;
 * method DataTypeFactory::registerDataTypeDomain for registering domains;
 * DataTypeDomainWithSimpleSerialization domain base class with simple serialization/deserialization;
 * Concrete IPv4 and IPv6 domain implementations: DataTypeDomanIPv6 and DataTypeDomanIPv4;

Updated:
 * IDataType text serialization/deserialization methods;
 * IDataType implementation to use domain for text serialization/deserialization;
 * Refactored implementation of the IPv4/IPv6 functions to use formatIPv4/v6 and parseIPv4/v6 from Common/formatIPv6.h;

Tests:
 * Added test cases for IPv4 and IPv6 domains.
 * Updated IPv4/v6 functions tests to validate more cases;
 * Added performance tests for IPv4 and IPv6 related functions;
2019-02-04 12:37:46 +03:00
Lopatin Konstantin
97cb36ac2e Clickhouse server version option support 2019-02-04 12:21:12 +03:00
Alexey Milovidov
bd04320f13 Added performance test 2019-02-04 01:27:19 +03:00
Alexey Milovidov
1f72b0fb16 Disable JIT compilation for comparison of Date and DateTime and conditional operator 2019-02-04 01:11:28 +03:00
Alexey Milovidov
59318c2ad9 Disable JIT compilation for comparison of Date and DateTime and conditional operator 2019-02-04 01:08:17 +03:00
Lopatin Konstantin
86f226d62e Reduce max memory usage, max memory usage for all querie, mark cache size and uncompressed cache size accordingly to available memory amount 2019-02-04 00:23:17 +03:00
alexey-milovidov
8db13da097
Update HTTPHandler.cpp 2019-02-03 23:40:34 +03:00
Vitaliy Karnienko
d9da430982 add arbitrary const expressions in limit processing 2019-02-03 21:31:17 +03:00
Alexey Milovidov
2129094ba3 Merge branch 'master' into generic-case-for-function-if 2019-02-03 16:01:56 +03:00
andrewsg
31f2f9ce2f Add topKWeighed aggregate function 2019-02-03 13:59:27 +03:00
alexey-milovidov
91d0d403a2
Merge pull request #3890 from zhang2014/fix/ISSUES-3885
ISSUES-3885 temporarily disable predicate optimization for order by
2019-02-03 12:10:20 +03:00
Alexey Milovidov
526b33f607 Added a test 2019-02-03 11:49:49 +03:00
Alexey Milovidov
ad9d5217ec Updated test 2019-02-03 11:43:00 +03:00
Alexey Milovidov
bf19e73386 Added generic case for function "if" 2019-02-03 11:41:25 +03:00
alexey-milovidov
ad2f6b4db3
Merge pull request #4237 from valexey/date_and_datetime_comparison
correct Date and DateTime comparison
2019-02-02 20:58:07 +03:00
alexey-milovidov
592d56ac69
Update FunctionsComparison.h 2019-02-02 20:57:36 +03:00
alexey-milovidov
450c575c7e
Merge pull request #4230 from bsd-conqueror/missing_password_value
Fixed the issue when --password was used without a value
2019-02-02 20:53:15 +03:00
alexey-milovidov
fb297b78ba
Update ConnectionParameters.h 2019-02-02 20:52:57 +03:00
alexey-milovidov
69c18786cb
Update Client.cpp 2019-02-02 20:50:57 +03:00
alexey-milovidov
2e082d9a9e
Merge pull request #4233 from yurriy/server-help-option
Server help option
2019-02-02 20:49:03 +03:00
alexey-milovidov
a3afe6650f
Merge pull request #4232 from syominsergey/my-branch
"-C" option for client and show problematic file path
2019-02-02 20:47:28 +03:00
alexey-milovidov
14f208b9a3
Merge pull request #4239 from danlark1/master
produce hints for typo functions and types
2019-02-02 20:42:35 +03:00
Mike F
723d3b3a99
Merge branch 'master' into brotli 2019-02-02 20:14:29 +03:00
Alexey
ce83b82776 test sql syntax fix 2019-02-02 09:00:29 -08:00
Danila Kutenin
3d00aaa7d8 test for typos 2019-02-02 19:09:24 +03:00
NeZeD [Mac Pro]
2cabe8fcdb
Refactor code logic and make it readable 2019-02-02 18:44:47 +03:00
Yuriy Baranov
defc6bbcf4 added positional arguments description 2019-02-02 15:37:54 +00:00
Sergei Semin
cc8bac78da add tests 2019-02-02 18:32:21 +03:00
Alexey
baa1ae9cf7 upper case for SQL in tests 2019-02-02 07:30:47 -08:00
Alexey
8c73b49e34 empty line on the end of file for tests 2019-02-02 07:20:10 -08:00
alexander kozhikhov
c5924d8bfb review fixes 2019-02-02 18:19:59 +03:00
Alexey
ff02845677 tests 2019-02-02 07:19:06 -08:00
Danila Kutenin
f6acd59929 fix brace 2019-02-02 18:15:53 +03:00
Danila Kutenin
9c7b62e95b fix function 2019-02-02 18:13:31 +03:00
Danila Kutenin
7d6e4083fa fix snake_case 2019-02-02 18:08:45 +03:00
Alexey
fc417a4e62 code cleanup 2019-02-02 07:02:57 -08:00
alexey-milovidov
7e5786a2e2
Merge pull request #4236 from kvinty/kvinty-pdqsort
Use pdqsort instead of std::sort in ORDER BY
2019-02-02 17:58:10 +03:00
Danila Kutenin
5e62a0825a produce hints for typo functions and types 2019-02-02 17:54:50 +03:00
Sergei Semin
adfc3bf5b3 fix typo 2019-02-02 17:43:36 +03:00
Sergei Semin
3f92350c2b rename config file parameter name 2019-02-02 17:40:29 +03:00
alexey-milovidov
e3b32ec679
Merge pull request #4231 from fandyushin/queryid
Added Query-Id to http response header
2019-02-02 17:38:13 +03:00
BSD_Conqueror
fbb3fee9af Fixed a mistype 2019-02-02 17:35:51 +03:00
Mihail Fandyushin
7b51139a80 fixed review notes; remove nullptr 2019-02-02 17:35:35 +03:00
Yuriy Baranov
e6101f3531 removed help message header 2019-02-02 14:33:08 +00:00
Sergei Semin
f3bbb07337 remove extra brackets 2019-02-02 17:29:54 +03:00
Sergei Semin
21cc1f6488 add another option for client configuration file 2019-02-02 17:28:37 +03:00
alexander kozhikhov
9d2a0c69fc Merge branch 'master' of https://github.com/yandex/ClickHouse into yandex_open_code_competition 2019-02-02 17:28:34 +03:00
alexander kozhikhov
8c2726b77c Aggregate function for entropy 2019-02-02 17:27:43 +03:00
Alexey
84bbc83192 use common time for Date and DateTime comparisons 2019-02-02 06:23:44 -08:00
Yuriy Baranov
a97c8a43a7 moved include outside ssl includes 2019-02-02 14:05:27 +00:00
Sergei Semin
c7b52af1f8 Revert "treat "-C" as "-c" parameter for clickhouse-client"
This reverts commit 6ed2a4d4
2019-02-02 17:01:10 +03:00
Yuriy Baranov
0296c9a941 removed duplicate include 2019-02-02 14:00:33 +00:00
Evgenii Pravda
67d26f6528 Use pdqsort instead of std::sort in ORDER BY 2019-02-02 16:52:20 +03:00
Sergei Semin
959952114c move client creation and run under try to show exception message 2019-02-02 16:49:24 +03:00
Sergei Semin
cfa31697b6 Revert "show file path when problems with client config loading"
This reverts commit 425a12d4
2019-02-02 16:48:30 +03:00
BSD_Conqueror
5a7e4c863d Added a comment to explain why '\n' is used as the implicit value for the --password option 2019-02-02 16:43:08 +03:00
Mihail Fandyushin
18952a2b96 Fixed 00501 test, added Query-Id support 2019-02-02 16:38:04 +03:00
alesapin
1a3cef8216 Add brotli to contrib 2019-02-02 16:33:50 +03:00
Yuriy Baranov
a3d0568739 Added --help/-h to server 2019-02-02 13:24:12 +00:00
BSD_Conqueror
171f54a1f6 Merge branch 'missing_password_value' of https://github.com/bsd-conqueror/ClickHouse into missing_password_value 2019-02-02 16:21:55 +03:00
BSD_Conqueror
d2d11d4e96 Removed code duplication in --password handling 2019-02-02 16:20:51 +03:00
Sergei Semin
425a12d48d show file path when problems with client config loading 2019-02-02 16:11:20 +03:00
BSD_Conqueror
375be7b881
Merge branch 'master' into missing_password_value 2019-02-02 16:10:38 +03:00
BSD_Conqueror
c0f72d18d0 Fixed the issues with the --password option and the user name in the prompt
- if --password was used without any value, ask for the password in the prompt
- fixed the issue when a blank user name is shown in the prompt if no user was provided
2019-02-02 16:04:08 +03:00
Sergei Semin
6ed2a4d47d treat "-C" as "-c" parameter for clickhouse-client 2019-02-02 15:36:04 +03:00
alexey-milovidov
fdfb60318c
Merge pull request #4193 from 4ertus2/ast
Refactoring: extract SubqueryForSet to own files
2019-02-02 15:28:31 +03:00
Mihail Fandyushin
7294b8adf2 Added Query-Id to http response header 2019-02-02 15:24:26 +03:00
NeZeD [Mac Pro]
f53826779a
Test SELECT ... WHERE a NOT BETWEEN b AND c 2019-02-02 15:20:18 +03:00
NeZeD [Mac Pro]
764cf232a0
Consistient codestyle 2019-02-02 15:18:30 +03:00
Nicolae Vartolomei
3fdc04428e
Cancel http read only queries if client socket goes away
To check the socket status, try to read one byte from socket in a
non-blocking way:
      0 - client closed the connection
   >= 1 - client send more data, we are ignoring this case for now
timeout - normal case, client is waiting for response
    ... - socket broken?

Dirty, but should do the job. Limiting to readonly queries as I don't
want to mess with alter queries / insert select and others.
2019-02-02 12:14:52 +00:00
BSD_Conqueror
baa504f524 Fixed the issue when --password was used without a value 2019-02-02 14:48:06 +03:00
NeZeD [Mac Pro]
d605c9c104
Fix comparsion logic 2019-02-02 14:47:09 +03:00
alexey-milovidov
297c2511c7
Merge pull request #4229 from nvartolomei/nv/typos
Make START REPLICATED SENDS command start replicated sends
2019-02-02 14:44:51 +03:00
Nicolae Vartolomei
f110d377d2
Fix typo in const name 2019-02-02 11:28:43 +00:00
Nicolae Vartolomei
5a8ebba4e1
Fix typo which prevents to start replicated sends 2019-02-02 11:27:27 +00:00
alexey-milovidov
25502718ae
Merge pull request #4221 from 4ertus2/cross
CROSS JOIN to INNER JOIN converter
2019-02-02 14:27:05 +03:00
NeZeD [Mac Pro]
9265fb34a5
Implement teset for 'NOT BETWEEN' 2019-02-02 14:15:22 +03:00
proller
c7cb8d2db5 Freebsd fixes (#4225)
* CLICKHOUSE-4109 mlock clickhouse

* wip

* Fix

* wip

* fix

* fix

* better place

* wip

* clean

* tidy

* fix

* Freebsd fix

* Fix compile on ARM

* Freebsd fixes

* Simpler test

* Fuzzy test: dont skip already fixed functions
2019-02-02 14:09:22 +03:00
NeZeD [Mac Pro]
9dd0292d77
Implement 'NOT BETWEEN' 2019-02-02 14:07:55 +03:00
proller
a383868442 Remove not used dbms/src/IO/InterserverWriteBuffer.* 2019-02-02 12:03:09 +03:00
alesapin
937053ee8f
Merge pull request #4220 from yandex/aux_queries_in_perf_test
Add ability to create, fill and drop tables in perftest
2019-02-02 11:15:42 +03:00
Alexey Milovidov
f2ded6a0ae Added a link to the list of easy tasks 2019-02-02 03:35:59 +03:00
Alexey Milovidov
733372c836 Added a list of easy tasks 2019-02-02 03:31:58 +03:00
Alexey Milovidov
7b0f6c07ef Added a list of easy tasks 2019-02-02 03:27:25 +03:00
Alexey Milovidov
7f8ac2d26b Fixed bad function name 2019-02-02 03:25:12 +03:00
chertus
f731702de0 rewrite COMMA JOIN too 2019-02-01 20:22:28 +03:00
chertus
e5a05bae47 missing file 2019-02-01 19:48:25 +03:00
chertus
170c108a59 CROSS JOIN to INNER JOIN converter 2019-02-01 19:36:40 +03:00
Alexey Milovidov
0f577da5c2 Updated system.contributors 2019-02-01 18:49:17 +03:00
alesapin
7fb2556a23 Add ability to create, fill and drop tables in perftest 2019-02-01 18:10:13 +03:00
Alexey Milovidov
1de2716c94 Updated instruction 2019-02-01 17:32:59 +03:00
Alexey Milovidov
3a774c80a1 Updated instruction 2019-02-01 17:29:49 +03:00
Alexey Milovidov
26f99cd49c Merge branch 'master' of github.com:yandex/ClickHouse 2019-02-01 17:27:14 +03:00
Alexey Milovidov
d30a316ed3 Updated instruction 2019-02-01 17:27:02 +03:00
chertus
52de2cd927 hotfix for allow_experimental_multiple_joins_emulation 2019-02-01 17:26:36 +03:00
Ivan
e22a271034
Fix style 2019-02-01 17:22:27 +03:00
Alexey Milovidov
2b8c30a93c Updated instruction 2019-02-01 16:57:29 +03:00
Alexey Milovidov
d263f3d941 Removed listen host override from the example server config 2019-02-01 16:56:20 +03:00
Alexey Milovidov
8c87795db9 Updated instruction 2019-02-01 16:49:36 +03:00
Alexey Milovidov
2f833d4753 Updated instruction 2019-02-01 16:19:42 +03:00
chertus
350920d50e test for issue #3567 2019-02-01 15:50:51 +03:00
chertus
f6d7eae0cc better test for joins with dups (add nulls) 2019-02-01 13:39:30 +03:00
Nikolai Kochetov
6a729e59ba Merged with master. 2019-02-01 11:36:57 +03:00
Nikolai Kochetov
d143a78419 Refactor ColumnsHashing 2019-02-01 11:23:38 +03:00
Alexey Milovidov
7a4cffd49e Merge branch 'master' of github.com:yandex/ClickHouse 2019-02-01 01:36:32 +03:00
Alexey Milovidov
f642663a11 Updated instruction 2019-02-01 01:36:23 +03:00
alexey-milovidov
bd62e2d85d
Merge pull request #4184 from 4ertus2/joins
Fix JOIN with duplicates [issue-4108]
2019-02-01 01:35:37 +03:00
Alexey Milovidov
6223e9eecf Updated instruction 2019-01-31 23:54:42 +03:00
alexey-milovidov
012bd5267b
Merge pull request #4195 from yandex/convert-parts-from-old-format
А tool to convert an old month-partition part to the custom-partitioned format
2019-01-31 22:45:44 +03:00
Alexey Milovidov
f3f5204cba Updated instruction 2019-01-31 22:44:58 +03:00
DarkWanderer
e2fe15aafa Build fix: round 2 2019-01-31 22:30:36 +03:00
Alexey Milovidov
bf99e785c8 Removed ZooKeeper example config 2019-01-31 21:58:04 +03:00
Alexey Milovidov
e981caf109 Updated instruction 2019-01-31 21:33:37 +03:00
Alexey Milovidov
e1b232ca07 Merge branch 'master' of github.com:yandex/ClickHouse 2019-01-31 21:17:13 +03:00
Alexey Milovidov
be7f0febcb Added quick start instruction 2019-01-31 21:16:28 +03:00
Alexey Milovidov
435a5497dd Addition to prev. revision 2019-01-31 21:16:11 +03:00
Alexey Milovidov
0852bc98bf Added quick start instruction 2019-01-31 21:15:13 +03:00
chertus
26b2526a3b fix right & full join with dups (complex join on still affected) 2019-01-31 21:10:16 +03:00
proller
335de18102 Fix 2019-01-31 20:18:30 +03:00
proller
157a0eb5d3 Fix compile in directories with spaces 2019-01-31 19:48:37 +03:00
proller
ff30a156c9 Fix compile on ARM
Freebsd fix
2019-01-31 18:38:21 +03:00
alesapin
4675c0bd29 Add fs path to result xml 2019-01-31 16:46:43 +03:00
Ivan Lezhankin
c5eff12015 Another attempt to fix test 2019-01-31 14:19:06 +03:00
zhang2014
cac52f8312 ISSUES-3885 remove useless methods 2019-01-31 07:23:22 +08:00
alexey-milovidov
1fa8553cc6
Merge pull request #4170 from yandex/split-odbc-bridge
Build odbc-bridge as a separate binary. Do not export symbols from it.
2019-01-31 02:22:28 +03:00
DarkWanderer
c8cff57a62 Fix compile errors, added output format test 2019-01-30 23:38:47 +03:00
Nikita Vasilev
094ae0f810 fix 2019-01-30 22:48:24 +03:00
Nikita Vasilev
476f33f9a3 __bitSwapLastTwo 2019-01-30 22:40:01 +03:00
alesapin
6d69eb2341 Merge branch 'split-odbc-bridge' of github.com:yandex/ClickHouse into split-odbc-bridge 2019-01-30 21:48:39 +03:00
alesapin
3ca9c06f79 Remove -rdynamic from odbc-bridge linkage and fix mysql test. Also log config 2019-01-30 21:48:20 +03:00
alexey-milovidov
34ce755117
Merge pull request #4196 from proller/fix14
Fix rethrowing exception #4188
2019-01-30 21:35:53 +03:00
alexey-milovidov
7a5c57ad8d
Merge pull request #4186 from yandex/fix_cache_compressed_buffer
Fix non initialized codec and wrong size in CacheCompressedReadBuffer
2019-01-30 21:18:13 +03:00
Ivan Lezhankin
39e2563f93 Create new consumers on-demand
and give them some time for graceful assignment.
2019-01-30 20:58:49 +03:00
chertus
866c2b2e78 move required right keys calculation to Join.cpp 2019-01-30 18:51:39 +03:00
Alexey Milovidov
18e512d069 Merge branch 'master' into dictionaries-user-profile 2019-01-30 18:18:20 +03:00
Nikita Vasilev
0492ed780f fixes 2019-01-30 18:04:24 +03:00
Alexey Zatelepin
063366307f fix build 2019-01-30 18:03:43 +03:00
Alexey Milovidov
de661e154d Removed linking of clickhouse-odbc-bridge to dictionaries 2019-01-30 17:08:42 +03:00
proller
0e863fff1e Fix rethrowing exception #4188 2019-01-30 17:06:42 +03:00
Alexey Milovidov
73a6209eba Merge branch 'master' into split-odbc-bridge 2019-01-30 17:01:06 +03:00
Alexey Milovidov
2eb861c143 Reverted part of changes #4188 2019-01-30 16:57:44 +03:00
Alexey Milovidov
9b75767135 Merge branch 'fix14' of https://github.com/proller/ClickHouse into proller-fix14 2019-01-30 16:56:53 +03:00
alesapin
3de94798d5
Merge pull request #4171 from yandex/refactor_performance_test
Refactor performance test
2019-01-30 16:54:50 +03:00
Alexey Zatelepin
8957e73681 a tool to convert an old month-partition part to the custom-partitioned format [#CLICKHOUSE-4231] 2019-01-30 16:51:39 +03:00
Nikita Vasilev
bcd07a4074 fix 2019-01-30 16:34:28 +03:00
chertus
d6450bc488 Refactoring: extract SubqueryForSet to own files 2019-01-30 15:01:00 +03:00
alesapin
893b34f31c Rename clear method 2019-01-30 14:48:23 +03:00
DarkWanderer
bcac2722d1 Added RowBinaryWithNamesAndTypes format
* Extended BinaryRowOutputStream with flags allowing to output names/types of columns
* Added one (for now) new output format - RowBinaryWithNamesAndTypes
* Updated docs
2019-01-30 14:30:43 +03:00
alesapin
586c6b3206 Better logging about exception 2019-01-30 14:07:10 +03:00
Nikita Vasilev
69daa33462 removed unused data 2019-01-30 13:58:10 +03:00
Nikita Vasilev
160c8c0807 fixed bug with duplicate column 2019-01-30 13:18:59 +03:00
proller
1cfec66165 Merge remote-tracking branch 'upstream/master' into fix14 2019-01-30 13:01:45 +03:00
proller
dc34e8998c Better fix 2019-01-30 13:01:01 +03:00
alesapin
6496bd423f Add curl to docker image 2019-01-30 12:43:00 +03:00
Nikolai Kochetov
a40f8f9708 Fix unstable test. 2019-01-30 12:20:50 +03:00
alesapin
6edc34bbe9
Merge pull request #4189 from proller/fix10
Allow run dictionaries tests from ctest
2019-01-30 11:36:07 +03:00
alesapin
3d53b5f8c6 Add bridge binary to runner script 2019-01-30 11:24:16 +03:00
Nikita Vasilev
c0d7a8b0fd Merge branch 'nikvas0/index' of github.com:nikvas0/ClickHouse into nikvas0/index 2019-01-30 10:17:19 +03:00
zhang2014
5906d0b545 ISSUES-3885 fix test failure 2019-01-30 14:59:31 +08:00
zhang2014
e0d69071cc ISSUES-3885 fix test failure 2019-01-30 14:17:18 +08:00
zhang2014
3af26ca070 ISSUES-3885 better test & fix isStateful bug 2019-01-30 12:49:00 +08:00
zhang2014
ddbd384f32 ISSUES-3885 mark stateful function & do not optimize their predicate 2019-01-30 12:04:28 +08:00
zhang2014
7dd897f2e6 ISSUES-3885 temporarily disable predicate optimization for order by 2019-01-30 08:03:10 +08:00
alesapin
95db9b4d76 Merge master 2019-01-29 23:17:52 +03:00
Nikita Vasilev
6d7ccc6982 fix 2019-01-29 23:06:31 +03:00
Nikita Vasilev
c12b03d350 Merge remote-tracking branch 'upstream/master' into nikvas0/index 2019-01-29 23:00:12 +03:00
Alexey Milovidov
b57ec0543f Setting user when doing in-process loading of dictionaries (incomplete) 2019-01-29 22:05:32 +03:00
Nikita Vasilev
371e1658f8 fix 2019-01-29 21:40:10 +03:00
alexey-milovidov
fd5ab9ed2e
Merge pull request #4055 from yandex/fix-group-by-array-low-cardibality-arguments
Fix group by array low cardinality arguments
2019-01-29 21:32:45 +03:00
proller
3e999ebc1a Allow run dictionaries tests from ctest 2019-01-29 21:09:31 +03:00
Nikita Vasilev
c4dad05b87 fix 2019-01-29 21:00:40 +03:00
Nikita Vasilev
d3b430d4fd tests 2019-01-29 20:46:46 +03:00
Nikita Vasilev
514987e9f9 test 2019-01-29 20:46:16 +03:00
Nikita Vasilev
9311c01ef7 spaces 2019-01-29 20:28:13 +03:00
Nikita Vasilev
4ec0923fc9 key set 2019-01-29 20:26:45 +03:00
Alexey Milovidov
0b0960e28f Fixed "Attempt to attach to nullptr thread group" when reloading dictionaries 2019-01-29 20:24:54 +03:00
alesapin
4f97c291e6 Always run clickhouse-odbc-bridge; Integration tests now able to run odbc-bridge from separate binary; add symlink to clickhouse-odbc-bridge in dbms/programs folder; 2019-01-29 20:17:31 +03:00
Nikita Vasilev
68ea3f0ae0 fix 2019-01-29 20:09:17 +03:00
Nikita Vasilev
67af98670e is always true 2019-01-29 19:53:44 +03:00
proller
4942e024b1 4177 4156 : Fix crash on dictionary reload if dictionary not available 2019-01-29 19:36:50 +03:00
Nikolai Kochetov
21242ad658 Added tests. Restored recursiveRemoveLowCardinality interface. 2019-01-29 18:44:02 +03:00
alesapin
cb0e77dce6 Fix non initialized codec and wrong size in CacheCompressedReadBuffer 2019-01-29 17:55:57 +03:00
Nikita Vasilev
149b0d84f9 fixed bug with double column 2019-01-29 16:13:18 +03:00
chertus
294f68c4ee fix wrong test result 2019-01-29 15:54:46 +03:00
chertus
9c6f71bb7e fix inner and left join with duplicates [issue-4108] 2019-01-29 15:38:53 +03:00
Nikolai Kochetov
2c2932e185 Merged with master 2019-01-29 15:25:19 +03:00
Nikolai Kochetov
5d29562302 Fix build. 2019-01-29 13:56:44 +03:00
Alexey Milovidov
27b08a7f22 Merge branch 'master' into fixed-clickhouse-localhost-dictionaries 2019-01-29 13:45:06 +03:00
alexey-milovidov
aa06005a32
Merge pull request #4179 from yandex/avoid-overflow-in-function-sleep
Fixed possible overflow in function "sleep" (found by fuzz test with UBSan)
2019-01-29 13:44:39 +03:00
alesapin
ec88c521f2 Fix headres + sort input files 2019-01-29 13:43:35 +03:00
Alexey Milovidov
c792191831 Fixed possible overflow in function "sleep" (found by fuzz test with UBSan) #4166 2019-01-29 13:42:45 +03:00
alesapin
646137b63a Add missed header 2019-01-29 13:05:15 +03:00
Emmanuel Donin de Rosière
4de40e438e Support of Nullable types in MySQL tables 2019-01-29 09:22:03 +01:00
proller
343b31af66 More link with Threads::Threads 2019-01-28 21:21:20 +03:00
proller
5d4c1d9a88 Install fixes 2019-01-28 19:36:39 +03:00
alesapin
3532910023 Fix conflict 2019-01-28 19:25:28 +03:00
alesapin
07b19bd9ea Merge remote-tracking branch 'origin' into refactor_performance_test 2019-01-28 19:23:08 +03:00
alesapin
86aeb4a251 Add normal logging, correct Ctrl+C handling and refactoring 2019-01-28 19:20:29 +03:00
Alexey Milovidov
5330ca16bc Strip clickhouse-odbc-bridge to avoid symbol clash with ODBC drivers #3360 2019-01-28 19:06:07 +03:00
Alexey Milovidov
9b2a5c3dec Merge branch 'master' into split-odbc-bridge 2019-01-28 18:15:18 +03:00
proller
2ab3138eb6 Merge remote-tracking branch 'upstream/master' into fix10 2019-01-28 17:01:06 +03:00
proller
2eee2d97df Update contrib/libmetrohash 2019-01-28 17:00:50 +03:00
Alexey Milovidov
bc4944eed2 Fixed optimization of loading of ClickHouse dictionaries via localhost #1529 2019-01-28 16:26:10 +03:00
proller
403d36a7f4 Fix 2019-01-28 16:24:55 +03:00
proller
a874945e0e Use cpuinfo if cpuid not available 2019-01-28 16:16:08 +03:00
proller
22549cc43b Merge remote-tracking branch 'upstream/master' into fix10 2019-01-28 15:44:25 +03:00
alesapin
1cdb5cfba2 Something runnable 2019-01-28 14:20:44 +03:00
Alexey Milovidov
4e3d9a0f15 Merge branch 'master' of github.com:yandex/ClickHouse into global-thread-pool 2019-01-28 14:20:24 +03:00
Alexey Milovidov
cd326884a5 Addition to prev. revision #4150 2019-01-28 14:18:00 +03:00
Nikita Vasilev
7c036e9b43 fix 2019-01-28 13:35:19 +03:00
Nikita Vasilev
b4d1bf869b uniqueCondition::mayBeTrueOnGranule 2019-01-28 11:15:13 +03:00
Nikita Vasilev
a74ed80f99 fixed not 2019-01-28 10:24:32 +03:00
Nikita Vasilev
00ec4cc6ca unique 2019-01-28 10:05:24 +03:00
alexey-milovidov
032ed27c27
Merge pull request #4154 from 4ertus2/joins
Add IdentifierSemantic and PredicateExpressionsOptimizer refactoring
2019-01-28 01:47:57 +03:00
Nikita Vasilev
aa37d95036 added termForAST 2019-01-28 00:08:14 +03:00
Nikita Vasilev
902c9a9e5c unique_condition 2019-01-27 23:24:33 +03:00
Nikita Vasilev
c701cb7e00 added getBlock 2019-01-27 21:23:08 +03:00
alexey-milovidov
4b8cf83de7
Merge pull request #4151 from ercolanelli-leo/fix/sumMap-overflow
Fix/sum map overflow
2019-01-27 21:11:51 +03:00
alexey-milovidov
ba8fcfd32b
Merge pull request #4158 from vitlibar/add-support-for-absolute-format-schema-paths
Add support for absolute format schema paths.
2019-01-27 21:07:00 +03:00
Nikita Vasilev
537b23ef15 upd 2019-01-27 21:02:15 +03:00
Vitaly Baranov
e9721c9548 Add support for absolute format schema paths. 2019-01-27 12:15:32 +03:00
alexey-milovidov
9557b33e83
Update 00832_storage_file_lock.sql 2019-01-27 03:43:16 +03:00
Alexey Milovidov
de56cc7a8e Added a test #2150 2019-01-27 03:40:54 +03:00
Alexey Milovidov
ef51f126b4 Removed extraordinarily bad code in StorageFile #2150 2019-01-27 03:38:30 +03:00
Alexey Milovidov
7100a74e41 Removed bug 2019-01-27 00:40:24 +03:00
Nikita Vasilev
0ea031d188 Merge branch 'nikvas0/index' into nikvas0/unique_index 2019-01-26 22:43:30 +03:00
Nikita Vasilev
b94915b7da better minmax calculation 2019-01-26 22:31:12 +03:00
Nikita Vasilev
077212f6f8 fix 2019-01-26 20:54:40 +03:00
Nikita Vasilev
387ed1b7c3 unique 2019-01-26 18:45:38 +03:00
Nikita Vasilev
6b6b0aa79a unique idx 2019-01-26 16:12:13 +03:00
Nikita Vasilev
b2915bc844 Merge remote-tracking branch 'upstream/master' into nikvas0/index 2019-01-26 09:27:32 +03:00
Nikita Vasilev
0ea0b171f4 fixed style 2019-01-26 09:26:49 +03:00
Alexander GQ Gerasiov
aac21c5f57 Fix install of binaries when SPLIT_BINARIES is set. 2019-01-25 23:19:45 +03:00
proller
9230fe9917 Merge remote-tracking branch 'upstream/master' into fix10 2019-01-25 23:10:38 +03:00
proller
5328251ff1
Fix build without protobuf, gtest, cppkafka (#4152) 2019-01-25 23:02:03 +03:00
Léo Ercolanelli
f680176ade sumMapWithOverflow: add test 2019-01-25 20:54:46 +01:00
Léo Ercolanelli
e1d6017120 use sumMapWithOverflow in SummingSortedBlockInputStream 2019-01-25 20:36:18 +01:00
Léo Ercolanelli
038a48bb38 sumMap: implement sumMapWithOverflow 2019-01-25 20:35:53 +01:00
proller
6964fb47ff BUILD_DETERMINISTIC 2019-01-25 22:29:01 +03:00
Alexey Milovidov
253ac93459 Addition to prev. revision #4150 2019-01-25 21:44:30 +03:00
alesapin
0d4b7ff82e Refactoring in performance test (may be build, but doesn't work) 2019-01-25 21:35:16 +03:00
alexey-milovidov
8124ee50e8
Merge pull request #4153 from amosbird/joingetfix
Better joinGet.
2019-01-25 20:47:53 +03:00
alexey-milovidov
c07dbee50d
Merge pull request #4148 from vitlibar/master
Use more IO/WriteHelpers.h functions in the class ProtobufSimpleWriter, rename variant=>varint.
2019-01-25 19:22:31 +03:00
chertus
9539467b59 hotfix 2019-01-25 18:48:53 +03:00
chertus
091efcda95 add IdentifierSemantic and PredicateExpressionsOptimizer refactoring 2019-01-25 18:42:24 +03:00
Amos Bird
d8eba7e71b Better joinGet. 2019-01-25 23:38:13 +08:00
Léo Ercolanelli
a78282b834 IDataType.h: remove trailing whitespace 2019-01-25 15:42:44 +01:00
Léo Ercolanelli
57104f81da rename widen to promote for IDataType 2019-01-25 15:16:23 +01:00
Vitaly Baranov
ed1136e49e Use more IO/WriteHelpers.h functions in the class ProtobufSimpleWriter,
rename variant=>varint.
2019-01-25 17:15:44 +03:00
Alexey Milovidov
468f8b4cfb Addition to prev. revision #4150 2019-01-25 17:08:01 +03:00
Alexey Milovidov
65f8e4d4a8 Merge branch 'master' into global-thread-pool 2019-01-25 16:33:50 +03:00
Léo Ercolanelli
0d6094a3ea sumMap: return types less prone to oveflows
It used to be that sumMap would return the same type as the values
columns. If columns of Array(UInt8) were to be given, that would really
easily cause oveflow. It now uses `getWidenDataType` (and ultimately
`NearestFieldType`) in order to define the result type.
2019-01-25 14:29:45 +01:00
Léo Ercolanelli
d9195cda99 implement getWidenType() on IDataType
This is essentially to help implementing the `getReturnType` of
aggregation function susceptible to provoque overflow (such as
`sumMap`).
2019-01-25 14:25:25 +01:00
chertus
02f236e457 one more test 2019-01-25 16:15:29 +03:00
Ivan Lezhankin
681266abd0 Poll messages in batches of max_block_size size. 2019-01-25 15:48:59 +03:00
chertus
a0fafefc96 minor change - add Aliases.h 2019-01-25 14:43:19 +03:00
alesapin
4e413f4c2d Move classes to separate files 2019-01-25 14:03:02 +03:00
alexey-milovidov
20970154d8
Merge pull request #4141 from 4ertus2/ast
JOIN with USING: do not duplicate columns
2019-01-25 03:22:43 +03:00
alexey-milovidov
2626a2614c
Merge pull request #4145 from yandex/fix-fuzz-test-in-ubsan-quantile-weighted
Fix fuzz test in ubsan: added parameter type check for quantile*Weighted.
2019-01-25 02:45:07 +03:00
Alexey Milovidov
ef50601b5c Removed non-breaking spaces: find dbms -name '*.h' -or -name '*.cpp' | xargs grep -l $'\xc2\xa0' | xargs sed -i -r -e 's/\xc2\xa0/ /g' 2019-01-25 02:01:56 +03:00
Alexey Milovidov
5ccc42fd96 Revert "Removed non-breaking spaces: find dbms -name '*.h' -or -name '*.cpp' | xargs grep -l $'\xc2\xa0' | xargs sed -i -r -e 's/\xc2\xa0/ /'"
This reverts commit a28f0acf09.
2019-01-25 01:59:45 +03:00
Alexey Milovidov
304c7b0386 Style #4005 2019-01-24 22:50:16 +03:00
Alexey Milovidov
a28f0acf09 Removed non-breaking spaces: find dbms -name '*.h' -or -name '*.cpp' | xargs grep -l $'\xc2\xa0' | xargs sed -i -r -e 's/\xc2\xa0/ /' 2019-01-24 22:49:36 +03:00
Alexey Milovidov
854817c232 Fixed -Wshadow-field #4005 2019-01-24 22:37:32 +03:00
Alexey Milovidov
04fa827e4b Style 2019-01-24 22:21:47 +03:00